Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

On Wed, Oct 7, 2015 at 9:54 PM, Brian Paul wrote: > On 10/07/2015 12:34 PM, Brian Paul wrote: >> >> On 10/05/2015 07:26 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> This is a start of reworking how st/mesa translates and creates >>> shaders. The result of this patch series is

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On 7 October 2015 at 18:04, Connor Abbott wrote: > On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: >> XXX: commit message, comment in nir_intrinsics.h >> >> Signed-off-by: Emil Velikov >> --- >>

[Mesa-dev] [PATCH 2/4 v2] glsl: Restrict initializers for global variables to constant expression in ES

From: Ian Romanick v2: Combine this check with the existing const and uniform checks. This change depends on the previous patch (glsl: Only set ir_variable::constant_value for const-decorated variables). Fixes: ES2-CTS.shaders.negative.initialize

[Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

From: Ian Romanick Right now we're also setting for uniforms, and that doesn't seem to hurt things. The next patch will make general global variables in GLSL ES, and those definitely should not have constant_value set! Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 4/4] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

From: Ian Romanick Fixes: ES3-CTS.shaders.negative.constant_sequence spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert spec/glsl-es-3.00/compiler/global-initializer/from-sequence.frag Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 3/4] glsl: Add method to determine whether an expression contains the sequence operator

From: Ian Romanick This will be used in the next patch to enforce some language sematics. Signed-off-by: Ian Romanick --- src/glsl/ast.h| 6 src/glsl/ast_function.cpp | 11 +++ src/glsl/ast_to_hir.cpp | 80

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov wrote: > On 7 October 2015 at 18:04, Connor Abbott wrote: >> On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov >> wrote: >>> XXX: commit message, comment in nir_intrinsics.h >>> >>>

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

On Wed, Oct 7, 2015 at 6:58 PM, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in >

[Mesa-dev] [PATCH 12/12] i965: Link compiler unit tests to libi965_compiler.la

We can now link the unit tests against just libi965_compiler.la. This lets us drop a lot of DRI driver dependencies, but we still pull in all of libmesa and more. This also provides a few standalone users of libi965_compiler.la, which will help us accidentally using i965_dri.so functions from the

[Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

We need the debug flag parsing and INTEL_DEBUG in the compiler, but we don't want the dependency on bufmgr (libdrm_intel) in there. Move to intel_screen.c. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/intel_debug.c | 14 +-

[Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 65c3628..b79b4a4 100644 ---

[Mesa-dev] [PATCH 04/12] i965: Move brw_link_shader() and friends to new file brw_link.cpp

We want to use the rest of brw_shader.cpp with the rest of the compiler without pulling in the GLSL linking code. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_link.cpp | 280

[Mesa-dev] [PATCH 11/12] i965: Break out backend compiler to its own library

This introduces a new libtool helper library, libi965_compiler.la. This library is moderately self-contained, but still needs to link to all of libmesa.la among other things. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/Makefile.am | 6 +-

[Mesa-dev] [PATCH 08/12] i965: Move brw_select_clip_planes() to brw_shader.cpp

We call this from the compiler so move it to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_shader.cpp | 26 ++ src/mesa/drivers/dri/i965/brw_vs.c | 25 - 2 files changed, 26

[Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

The initial motivation for this patch was to avoid calling brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the compiler. This commit ends up refactoring things a bit more so as to split out the logic to build the local id payload to brw_fs.cpp. This moves the payload building closer

[Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

We want to use intel_debug.c in code that doesn't link to dri common. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/intel_debug.c | 5 ++-- src/util/Makefile.sources | 2 ++ src/util/debug.c| 53

[Mesa-dev] [PATCH 06/12] i965: Move brw_mark_surface_used() to brw_shader.cpp

brw_program.c won't be part of the compiler library, but we need brw_mark_surface_used() in the compiler. Move to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_program.c | 10 --

[Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

We move these calls one level up into the codegen functions. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_cs.c| 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 13 - src/mesa/drivers/dri/i965/brw_gs.c

[Mesa-dev] [PATCH 00/12] Introduce libi965_compiler.la

This series introduces a new libtool convenience library, libi965_compiler.la. Most of the series is concerned with moving bits of code around to allow for splitting the compiler files in the second-to-last patch. The end result is still not completely ideal - we still have a bunch of

[Mesa-dev] make distclean failing

Noticed recently that make distclean is failing for me - Making distclean in mesa make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa' Makefile:2486: ../glsl/.deps/shader_enums.Plo: No such file or directory make[2]: *** No rule to make target '../glsl/.deps/shader_enums.Plo'.

Re: [Mesa-dev] [PATCH v3 3/6] main: consider that unsized arrays have at least one active element

On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_shader_storage_buffer_object: > > "When using the ARB_program_interface_query extension to enumerate > the > set of active buffer variables, only the first element of arrays > (sized > or unsized) will be enumerated"

Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > Return the number of values written. > > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Timothy Arceri Are you guys going to split SSBO into their own list? There was talk

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #10 from Jason Ekstrand --- I just sent a patch to the list that fixes this bug: http://lists.freedesktop.org/archives/mesa-dev/2015-October/096511.html -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 John Dulaney changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v3 5/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > It doesn't round up to vec4 size. > > Fixes 15 dEQP tests: > > dEQP > -GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_low > p_mat2 > dEQP >

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > On 10/05/2015 05:18 PM, Mark Janes wrote: >> I tested this patch and found: >> >> regressions: >>spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >> expected[1] = 1.00. Read value: 0.00 >> >>

[Mesa-dev] [PATCH 07/12] i965: Use util_next_power_of_two() for brw_get_scratch_size()

This function computes the next power of two, but at least 1024. We can do that by bitwise or'ing in 1023 and calling util_next_power_of_two(). We use brw_get_scratch_size() from the compiler so we need it out of brw_program.c. We could move it to brw_shader.cpp, but let's make it a small inline

[Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

brw_get_shader_time_index() is all tangled up in brw_context state and we can't call it from the compiler. Thanks the Jasons recent refactoring, we can just get the index and pass to the emit functions instead. Signed-off-by: Kristian Høgsberg Kristensen ---

Re: [Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_wm.c > b/src/mesa/drivers/dri/i965/brw_wm.c > index 242114f..1d020f6 100644 > --- a/src/mesa/drivers/dri/i965/brw_wm.c > +++ b/src/mesa/drivers/dri/i965/brw_wm.c >

[Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

The EXT_texture_format_BGRA extension (which mesa supports unconditionally) adds a new format and internal format called GL_BGRA_EXT. Previously, this was not really handled at all in _mesa_ex3_error_check_format_and_type. When the checks were tightened in commit f15a7f3c, we accidentally

Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

On 10/07/2015 12:34 PM, Brian Paul wrote: On 10/05/2015 07:26 PM, Marek Olšák wrote: Hi, This is a start of reworking how st/mesa translates and creates shaders. The result of this patch series is this: In LinkShader or ProgramStringNotify, the shader is translated to TGSI as-is. There are no

Re: [Mesa-dev] make distclean failing

Edit shader_enums.Plo and replace shader_enums.cpp with shader_enums.c (or vice-versa) On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: > Noticed recently that make distclean is failing for me - > > Making distclean in mesa > make[2]: Entering directory

Re: [Mesa-dev] [PATCH 5/6] i965: Implement nir_intrinsic_shader_clock

On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 + > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++ > 2 files changed, 19

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

On Wed, Oct 7, 2015 at 4:18 PM, Ilia Mirkin wrote: > On Wed, Oct 7, 2015 at 6:58 PM, Jason Ekstrand wrote: >> The EXT_texture_format_BGRA extension (which mesa supports >> unconditionally) adds a new format and internal format called GL_BGRA_EXT.

Re: [Mesa-dev] [PATCH v3 1/6] main: fix goto in program_resource_top_level_array_stride

On Wed, 2015-10-07 at 09:20 +0200, Samuel Iglesias Gonsalvez wrote: > Use found_top_level_array_stride instead of > found_top_level_array_size. > > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Timothy Arceri > --- >

Re: [Mesa-dev] [PATCH v3 4/6] main: buffer array variables can have array size of 0 if they are unsized

On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_query_interface: > > For the property ARRAY_SIZE, a single integer identifying the > number of > active array elements of an active variable is written to . > The > array size returned is in units of the

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen > wrote: >> Signed-off-by: Kristian Høgsberg Kristensen >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- >> 1

[Mesa-dev] [PATCH] glsl: add varyings to resource list only with SSO

Varyings can be considered inputs or outputs of a program only when SSO is in use. With multi-stage programs, inputs contain only inputs for first stage and outputs contains outputs of the final shader stage. I've tested that fix works for Assault Android Cactus (demo version) and does not cause

Re: [Mesa-dev] [PATCH v2] main: buffer array variables can have array size of 0 if they are unsized

On 07/10/15 01:19, Timothy Arceri wrote: > On Tue, 2015-10-06 at 15:07 +0200, Samuel Iglesias Gonsálvez wrote: >> On 06/10/15 12:59, Timothy Arceri wrote: >>> On Tue, 2015-10-06 at 10:08 +0200, Samuel Iglesias Gonsalvez wrote: From ARB_program_query_interface: For the property

[Mesa-dev] [PATCH v3 2/6] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

When the active variable is an array which is already a top-level shader storage block member, don't return its array size and stride when querying TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE respectively. Fixes the following 12 dEQP-GLES31 tests:

[Mesa-dev] [PATCH v3 3/6] main: consider that unsized arrays have at least one active element

From ARB_shader_storage_buffer_object: "When using the ARB_program_interface_query extension to enumerate the set of active buffer variables, only the first element of arrays (sized or unsized) will be enumerated" _mesa_program_resource_array_size() is used when getting the name (and name

Re: [Mesa-dev] [PATCH] glsl: Restrict initializers for global variables to constant expression in ES

On Tue, 2015-10-06 at 19:09 -0700, Ian Romanick wrote: > From: Ian Romanick > > It may be possible to consolodate this check with the existing check for consolidate > uniform and const initializers, but a way that didn't require a huge > amount

[Mesa-dev] [PATCH v3 1/6] main: fix goto in program_resource_top_level_array_stride

Use found_top_level_array_stride instead of found_top_level_array_size. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shader_query.cpp

[Mesa-dev] [PATCH v3 4/6] main: buffer array variables can have array size of 0 if they are unsized

From ARB_program_query_interface: For the property ARRAY_SIZE, a single integer identifying the number of active array elements of an active variable is written to . The array size returned is in units of the type associated with the property TYPE. For active variables not corresponding

[Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

Return the number of values written. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index

[Mesa-dev] [PATCH v3 5/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

It doesn't round up to vec4 size. Fixes 15 dEQP tests: dEQP-GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_lowp_mat2 dEQP-GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_mediump_mat2

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #20 from Chih-Wei Huang --- (In reply to Rob Clark from comment #17) > (In reply to Emil Velikov from comment #15) > > (In reply to Chih-Wei Huang from comment #11) > > > Mesa still doesn't support

Re: [Mesa-dev] [RFC 1/2] glsl: Use hash tables for opt_constant_propagation() acp sets.

On 7 October 2015 at 04:00, Kenneth Graunke wrote: > On Sunday, September 20, 2015 07:54:56 PM Rhys Kidd wrote: > > --- > > src/glsl/opt_constant_propagation.cpp | 63 > +-- > > 1 file changed, 38 insertions(+), 25 deletions(-) > > Hi Rhys!

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #12 from Tapani Pälli --- Updating status, existing patches can be scrapped and I will send new *real* fix soon. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [PATCH 1/2] glsl: shader outputs cannot have initializers

GLSL Spec 4.20.8, 4.3 Storage Qualifiers: "Initializers in global declarations may only be used in declarations of global variables with no storage qualifier, with a const qualifier or with a uniform qualifier." We do this for input variables, but not for output variables. AMD and NVIDIA

[Mesa-dev] [PATCH 2/2] glsl: include variable name in error messages about initializers

Also fix style / wrong indentation along the way and make the messages more uniform. --- src/glsl/ast_to_hir.cpp | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index da79597..e5543ca 100644 ---

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

On Oct 7, 2015 3:36 PM, "Kristian Høgsberg" wrote: > > On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: > > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen > > wrote: > >> Signed-off-by: Kristian Høgsberg Kristensen

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting.

On 10/07/2015 08:05 PM, Dave Airlie wrote: > From: Dave Airlie > > So I've known this was broken before, cogl has a workaround > for it from what I know, but with the gallium based swrast > drivers BlitFramebuffer from back to front or vice-versa > was pretty broken. > > The

[Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

--- src/glsl/nir/nir_sweep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_sweep.c b/src/glsl/nir/nir_sweep.c index d354975..b6ce43b 100644 --- a/src/glsl/nir/nir_sweep.c +++ b/src/glsl/nir/nir_sweep.c @@ -154,6 +154,8 @@ nir_sweep(nir_shader *nir) /* First, move

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

https://bugs.freedesktop.org/show_bug.cgi?id=92342 Bug ID: 92342 Summary: BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D Product: Mesa Version: 11.0 Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

On 10/07/2015 03:58 PM, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the checks

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand wrote: > --- Because otherwise it was being freed? > src/glsl/nir/nir_sweep.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/nir/nir_sweep.c b/src/glsl/nir/nir_sweep.c > index d354975..b6ce43b 100644 >

[Mesa-dev] [PATCH 3/4] program: remove other unused functions

From: Marek Olšák --- src/mesa/program/program.c | 134 - src/mesa/program/program.h | 9 --- 2 files changed, 143 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index eb1f8be..1fcb8e0 100644

[Mesa-dev] [PATCH 1/4] program: remove unused function _mesa_find_line_column

From: Marek Olšák --- src/mesa/program/program.c | 43 --- src/mesa/program/program.h | 5 - 2 files changed, 48 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index e94c102..23d8be8 100644 ---

[Mesa-dev] [PATCH 0/4] program: removal of Mesa IR functions

Hi, Some of these functions became unused after I made the big st/mesa patch series. Hopefully, nobody will miss them. The last one is a cleanup. Please review. src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- src/mesa/drivers/dri/i965/brw_program.c | 10 +-

[Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

From: Marek Olšák They didn't do anything useful. --- src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- src/mesa/drivers/dri/i965/brw_program.c| 10 +- .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 2 +-

[Mesa-dev] [PATCH 2/4] program: remove unused cloning and combining functions

From: Marek Olšák --- src/mesa/program/program.c | 250 - src/mesa/program/program.h | 44 2 files changed, 294 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 23d8be8..eb1f8be

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Am 08.10.2015 um 02:02 schrieb Marek Olšák: > Hi Brian, > > This is the commit that broke DrawPixels on llvmpipe, but not radeonsi > and softpipe. It's fixed in v2, which is attached. > > Marek > > On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: >> From: Marek Olšák

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] mesa: Expose function to calculate whether a shader image unit is valid.

On 09/03/2015 06:53 AM, Francisco Jerez wrote: > A future commit will remove all texture object-dependent derived state > from the image unit struct to make validation unnecessary on texture > state changes. Instead of checking gl_image_unit::_Valid drivers will > be required to call this

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

On Wed, Oct 7, 2015 at 8:45 PM, Jason Ekstrand wrote: > On Oct 7, 2015 8:40 PM, "Matt Turner" wrote: >> On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand >> wrote: >> > --- >> >> Because otherwise it was being freed? > > Yes Cool.

Re: [Mesa-dev] Request to expose new AZDO exts: bindless, sparse tex+others exts..

Thanks Kenneth and Ilia for response.. Kenneth what I meant to compete with Vulkan was but was said in AZDO GDC presentation, namely to avoid rewriting current engines to Vulkan for acheiving low overhead in OpenGL using a few new extensions.. Also this *might* in Skyalke for me is a sure yes as

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #11 from Eduardo Lima Mitev --- (In reply to Emil Velikov from comment #8) > Eduardo, the faulty commit (breaking KDE/kwin and weston) has landed a week+ > ago. Will you have a chance to look into it soon ?

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

https://bugs.freedesktop.org/show_bug.cgi?id=92342 kalyank changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Marek On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: > From: Marek Olšák > > - there is no connection to user fragment

[Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting.

From: Dave Airlie So I've known this was broken before, cogl has a workaround for it from what I know, but with the gallium based swrast drivers BlitFramebuffer from back to front or vice-versa was pretty broken. The legacy swrast driver tracks when a front buffer is used

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

On Oct 7, 2015 8:40 PM, "Matt Turner" wrote: > > On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand wrote: > > --- > > Because otherwise it was being freed? Yes > > src/glsl/nir/nir_sweep.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

https://bugs.freedesktop.org/show_bug.cgi?id=92342 --- Comment #1 from Tapani Pälli --- are you testing with patches that fixed bug #92265 ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

On Tue, 2015-10-06 at 10:38 -0700, Ian Romanick wrote: > I had also noticed the unused parameter warning, but I had a patch > that > just papered over the problem. I'm a bit annoyed that GCC didn't > warn > (but I guess it couldn't really) that abs_time might be used > uninitialized. > > This

[Mesa-dev] [PATCH 2/2] i965: remove unneeded src_reg copy in emit_shader_time_write

The variable is already of type src_reg. creating a new instance only to destroy it seems unnecessary. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] i965: remove cache_aux_free_func array

There is only one function that can be called, which is well known at compilation time. The abstraction used here seems unnecessary, so let's use a direct call to brw_stage_prog_data_free() when appropriate, cut down the size of struct brw_cache. Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

On Mon, Oct 05, 2015 at 07:55:24PM +0300, Marius Predut wrote: > On PNV platform, for 1 pixel line thickness or less, > the general anti-aliasing algorithm gives up, and a garbage line is generated. > Setting a Line Width of 0.0 specifies the rasterization > of the "thinnest" (one-pixel-wide),

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #16 from Tapani Pälli --- (In reply to Krzysztof A. Sobiecki from comment #15) > (In reply to Tapani Pälli from comment #14) > > (In reply to Krzysztof A. Sobiecki from comment #13) > > > (In reply to Tapani Pälli

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #14 from Tapani Pälli --- (In reply to Krzysztof A. Sobiecki from comment #13) > (In reply to Tapani Pälli from comment #12) > > Updating status, existing patches can be scrapped and I will send new *real* > > fix

[Mesa-dev] [RFC] [PATCH 00/10] NIR header (C++ compilation) TLC

Hi all, A while back we had a case where NIR had C99 initializers in its public headers. That's not desired as ISO C++ does not allow them. So I took a quick look about wiring up a compilation test at 'make check' and noticed that we've been missing some include guards, plus other trivial

[Mesa-dev] [PATCH 10/10] fixup! automake: nir: add a C++ compile time test

Remove the headers not meant for direct consumption. Note: Explicitly kept as separate to illustrate the issues and the compiler output. Will be squashed before pushing. Signed-off-by: Emil Velikov --- src/glsl/nir/tests/cpp_test.cpp | 2 -- 1 file changed, 2

[Mesa-dev] [PATCH 06/10] nir/builder: undefine macros upon completion

Signed-off-by: Emil Velikov --- src/glsl/nir/nir_builder.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h index 624329d..398de24 100644 --- a/src/glsl/nir/nir_builder.h +++ b/src/glsl/nir/nir_builder.h

[Mesa-dev] [PATCH 07/10] nir/intrinsics: undefine macros upon completion

Signed-off-by: Emil Velikov --- src/glsl/nir/nir_intrinsics.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index 3bc74ec..99b54a9 100644 --- a/src/glsl/nir/nir_intrinsics.h +++

[Mesa-dev] [PATCH 04/10] nir/builder_opcodes: remove spurious tailing semicolon

The ALU# macros already include semicolon. Signed-off-by: Emil Velikov --- src/glsl/nir/nir_builder_opcodes_h.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_builder_opcodes_h.py b/src/glsl/nir/nir_builder_opcodes_h.py index

[Mesa-dev] [PATCH 09/10] automake: nir: add a C++ compile time test

It should allow us to catch any constructs in our headers which are not allowed in the C++ standard Signed-off-by: Emil Velikov --- src/glsl/Makefile.am| 11 ++- src/glsl/nir/tests/cpp_test.cpp | 17 + 2 files changed, 27

[Mesa-dev] [PATCH 01/10] nir: error when directly including nir_builder_opcodes.h

The file is meant to be included via nir_builder.h. Signed-off-by: Emil Velikov --- src/glsl/nir/nir_builder_opcodes_h.py | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_builder_opcodes_h.py b/src/glsl/nir/nir_builder_opcodes_h.py index

[Mesa-dev] [PATCH 03/10] nir: error when directly including nir_opcodes.h

The file is meant to be included via nir.h. Signed-off-by: Emil Velikov --- src/glsl/nir/nir_opcodes_h.py | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_opcodes_h.py b/src/glsl/nir/nir_opcodes_h.py index be15a96..444bee0 100644 ---

[Mesa-dev] [PATCH 08/10] nir/intrinsics: be a good citizen and undefine the macros

Signed-off-by: Emil Velikov --- Side note: we should probably convert nir_intrinsics.[ch] to python/mako and remove the unusual macros ? -Emil src/glsl/nir/nir_intrinsics.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 02/10] nir: add NIR_H include guard

We will reuse it in later commits, to check if other headers are included from within nir.h. Signed-off-by: Emil Velikov --- src/glsl/nir/nir.h | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index bde9f49..b017be2

[Mesa-dev] [PATCH 05/10] nir: error when directly including nir_intrinsics.h

Signed-off-by: Emil Velikov --- src/glsl/nir/nir_intrinsics.h | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index 263d8c1..3bc74ec 100644 --- a/src/glsl/nir/nir_intrinsics.h +++

Re: [Mesa-dev] [PATCH 02/10] nir: add NIR_H include guard

2015-10-07 18:11 GMT+08:00 Emil Velikov : > We will reuse it in later commits, to check if other headers are > included from within nir.h. > > Signed-off-by: Emil Velikov > --- > src/glsl/nir/nir.h | 4 > 1 file changed, 4 insertions(+)

[Mesa-dev] [PATCH 1/6] mesa: add infra for ARB_shader_clock

Signed-off-by: Emil Velikov --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index b2c88c3..64972fa 100644 --- a/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 6/6] i965: enable ARB_shader_clock on gen7+

Signed-off-by: Emil Velikov --- docs/relnotes/11.1.0.html| 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index c755c98..44f08f8 100644

[Mesa-dev] [PATCH 3/6] glsl: add support for the clock2x32ARB function

Signed-off-by: Emil Velikov --- src/glsl/builtin_functions.cpp | 40 1 file changed, 40 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index f0f6be2..ee3dc52 100644 ---

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #13 from Krzysztof A. Sobiecki --- (In reply to Tapani Pälli from comment #12) > Updating status, existing patches can be scrapped and I will send new *real* > fix soon. I the meantime can you revert

[Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

XXX: commit message, comment in nir_intrinsics.h Signed-off-by: Emil Velikov --- src/glsl/nir/glsl_to_nir.cpp | 6 ++ src/glsl/nir/nir_intrinsics.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] [PATCH 5/6] i965: Implement nir_intrinsic_shader_clock

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 + src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++ 2 files changed, 19 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

[Mesa-dev] [PATCH 2/6] glsl: add ARB_shader_clock infrastructure

Signed-off-by: Emil Velikov --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index

  1   2   >