Re: [Mesa-dev] [PATCH v3 17/19] st/mesa: add compute program dispatch callbacks

Am 10.02.2016 um 19:10 schrieb Samuel Pitoiset: > This state tracker implements DispatchCompute() and DispatchComputeIndirect(). > > Signed-off-by: Samuel Pitoiset > Reviewed-by: Marek Olšák > Reviewed-by: Ilia Mirkin > ---

Re: [Mesa-dev] [PATCH v3 17/19] st/mesa: add compute program dispatch callbacks

On 02/13/2016 04:52 PM, Roland Scheidegger wrote: Am 10.02.2016 um 19:10 schrieb Samuel Pitoiset: This state tracker implements DispatchCompute() and DispatchComputeIndirect(). Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH] st/mesa: fix pipe_grid_info initializer

Fixes MSVC build error which doesn't allow empty initializers. Signed-off-by: Samuel Pitoiset Cc: Roland Scheidegger --- src/mesa/state_tracker/st_cb_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v3 17/19] st/mesa: add compute program dispatch callbacks

Am 13.02.2016 um 16:56 schrieb Samuel Pitoiset: > > > On 02/13/2016 04:52 PM, Roland Scheidegger wrote: >> Am 10.02.2016 um 19:10 schrieb Samuel Pitoiset: >>> This state tracker implements DispatchCompute() and >>> DispatchComputeIndirect(). >>> >>> Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] st/mesa: fix pipe_grid_info initializer

Reviewed-by: Roland Scheidegger Am 13.02.2016 um 17:02 schrieb Samuel Pitoiset: > Fixes MSVC build error which doesn't allow empty initializers. > > Signed-off-by: Samuel Pitoiset > Cc: Roland Scheidegger > --- >

Re: [Mesa-dev] [PATCH v3 17/19] st/mesa: add compute program dispatch callbacks

On 02/13/2016 05:06 PM, Roland Scheidegger wrote: Am 13.02.2016 um 16:56 schrieb Samuel Pitoiset: On 02/13/2016 04:52 PM, Roland Scheidegger wrote: Am 10.02.2016 um 19:10 schrieb Samuel Pitoiset: This state tracker implements DispatchCompute() and DispatchComputeIndirect().

[Mesa-dev] [PATCH] clover: fix build failure since bfd695e

--- src/gallium/state_trackers/clover/core/kernel.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 41b3852..a4ef2b1 100644 ---

Re: [Mesa-dev] [PATCH] clover: fix build failure since bfd695e

Except the minor comment below, this patch is: Reviewed-by: Samuel Pitoiset Sorry for this, the next time I'll build clover and learn from my mistakes. :-) On 02/13/2016 06:01 PM, Serge Martin wrote: --- src/gallium/state_trackers/clover/core/kernel.cpp | 7

Re: [Mesa-dev] [PATCH] clover: fix build failure since bfd695e

On Sat, Feb 13, 2016 at 12:01 PM, Serge Martin wrote: > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp >

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use _mesa_geometric_width/height() in glDrawPixels code

On 02/12/2016 06:07 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Thanks, but this comes after the preceding 14 or so patches that I posted before. Care to review those too? -Brian On Fri, Feb 12, 2016 at 8:07 PM, Brian Paul wrote: ---

Re: [Mesa-dev] [PATCH 4/4] st/mesa: rename attr variable in st_DrawTex()

This series is: Reviewed-by: Ilia Mirkin On Fri, Feb 12, 2016 at 10:45 AM, Brian Paul wrote: > Rename to 'tex_attr' to be a bit more clear. > --- > src/mesa/state_tracker/st_cb_drawtex.c | 20 ++-- > 1 file changed, 10 insertions(+), 10

[Mesa-dev] [PATCH v2] clover: fix build failure since bfd695e

--- src/gallium/state_trackers/clover/core/kernel.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 41b3852..3daec3b 100644 ---

[Mesa-dev] [PATCH] nv50/ir: add missing compute system values for GM107

I don't see the necessity to add SV_LBASE and SV_SBASE for now because they are currently not used and I need to double-check the ids first. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 5 + 1 file changed, 5

Re: [Mesa-dev] [PATCH v2] clover: fix build failure since bfd695e

Reviewed-by: Ilia Mirkin On Sat, Feb 13, 2016 at 12:27 PM, Serge Martin wrote: > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] nv50/ir: add missing compute system values for GM107

On Sat, Feb 13, 2016 at 12:32 PM, Samuel Pitoiset wrote: > I don't see the necessity to add SV_LBASE and SV_SBASE for now > because they are currently not used and I need to double-check > the ids first. > > Signed-off-by: Samuel Pitoiset >

[Mesa-dev] [PATCH] docs: document MESA_GLES_VERSION_OVERRIDE envvar

--- Placed under "Core Mesa environment variables" as I didn't find any better place. The text is a summarized version of MESA_GL_VERSION_OVERRIDE documentation. I hope not be forgetting something specific of this envvar. docs/envvars.html | 9 + 1 file changed, 9 insertions(+) diff

Re: [Mesa-dev] [PATCH] docs: document MESA_GLES_VERSION_OVERRIDE envvar

On 02/13/2016 11:12 AM, Alejandro Piñeiro wrote: --- Placed under "Core Mesa environment variables" as I didn't find any better place. The text is a summarized version of MESA_GL_VERSION_OVERRIDE documentation. I hope not be forgetting something specific of this envvar. docs/envvars.html | 9

[Mesa-dev] [PATCH v2] vc4: Correct typo setting 'handled_qinst_cond'

Variable was previously always set to true. Accordingly, the later assert() served no active purpose. Found with GCC warning and code inspection: mesa/src/gallium/drivers/vc4/vc4_qpu_emit.c: In function'vc4_generate_code': mesa/src/gallium/drivers/vc4/vc4_qpu_emit.c:315:22: warning: variable

[Mesa-dev] [PATCH] docs: document MESA_GLES_VERSION_OVERRIDE envvar

v2: Removed reference to FC not being an allowed suffix (Brian Paul) --- docs/envvars.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index ba83335..8c4597c 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -91,6 +91,14 @@ This is

Re: [Mesa-dev] [PATCH] docs: document MESA_GLES_VERSION_OVERRIDE envvar

On 02/13/2016 11:24 AM, Alejandro Piñeiro wrote: v2: Removed reference to FC not being an allowed suffix (Brian Paul) --- docs/envvars.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index ba83335..8c4597c 100644 --- a/docs/envvars.html

Re: [Mesa-dev] [PATCH] docs: document MESA_GLES_VERSION_OVERRIDE envvar

On 13/02/16 20:05, Brian Paul wrote: > On 02/13/2016 11:24 AM, Alejandro Piñeiro wrote: >> v2: Removed reference to FC not being an allowed suffix (Brian Paul) >> --- >> docs/envvars.html | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/docs/envvars.html b/docs/envvars.html

Re: [Mesa-dev] [PATCH v2] clover: fix build failure since bfd695e

Tested-By: Aaron Watry On Sat, Feb 13, 2016 at 11:27 AM, Serge Martin wrote: > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [Bug 94137] build error - incompatible types in assignment of 'unsigned int*' to 'uint [3] {aka unsigned int [3]}'

https://bugs.freedesktop.org/show_bug.cgi?id=94137 Bug ID: 94137 Summary: build error - incompatible types in assignment of 'unsigned int*' to 'uint [3] {aka unsigned int [3]}' Product: Mesa Version: git Hardware: x86-64

[Mesa-dev] [Bug 94137] build error - incompatible types in assignment of 'unsigned int*' to 'uint [3] {aka unsigned int [3]}'

https://bugs.freedesktop.org/show_bug.cgi?id=94137 --- Comment #1 from Samuel Pitoiset --- Hi, Yes, I know that I did break clover with my compute shader series, sorry for that. A bugfix has been already sent by Serge Martin:

Re: [Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/state_tracker/st_context.c > index 9016846..cb2c390 100644 > --- a/src/mesa/state_tracker/st_context.c > +++ b/src/mesa/state_tracker/st_context.c > @@ -241,16

[Mesa-dev] [PATCH] docs: Correct typo in LLVMpipe envvar description

Signed-off-by: Rhys Kidd --- docs/envvars.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/envvars.html b/docs/envvars.html index ba83335..d7697e3 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -224,7 +224,7 @@ See

[Mesa-dev] [PATCH] i965: Fix gl_DrawID in the vec4 backend.

brw_draw_upload.c uploads VertexID/InstanceID first, then DrawID. So we need to assign the attribute mapping in that order as well. Fixes the following Pigit tests with the vec4 backend: - arb_shader_draw_parameters-drawid vertexid - arb_shader_draw_parameters-drawid-indirect basevertex

Re: [Mesa-dev] [PATCH] i965: Fix gl_DrawID in the vec4 backend.

On Sat, Feb 13, 2016 at 12:45 PM, Kenneth Graunke wrote: > brw_draw_upload.c uploads VertexID/InstanceID first, then DrawID. > So we need to assign the attribute mapping in that order as well. > > Fixes the following Pigit tests with the vec4 backend: > -

Re: [Mesa-dev] [v2 08/19] i965: Refactor resolving of auxiliary mode

On Thu, Feb 11, 2016 at 03:49:16PM -0800, Ben Widawsky wrote: > On Thu, Feb 11, 2016 at 08:34:01PM +0200, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/gen8_surface_state.c | 62 > > -- > > 1

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

https://bugs.freedesktop.org/show_bug.cgi?id=89088 Timothy Arceri changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Mesa-dev] [Bug 29272] osmesa 7.8.2 - assertion error drawing thin line with CHAN_BITS=32

https://bugs.freedesktop.org/show_bug.cgi?id=29272 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 69053] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=69053 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] docs: Document VC4_DEBUG envvar

Signed-off-by: Rhys Kidd --- docs/envvars.html | 19 +++ 1 file changed, 19 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index ba83335..c0007a6 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -245,6 +245,25 @@ for details.

Re: [Mesa-dev] AppVeyor: Build failed: mesa 58

Per http://help.appveyor.com/discussions/problems/3801-builds-failing-without-generating-any-log this was a transitory issue. And in fact I never saw it again. Builds have been going reliably, so I've just re-enabled notification emails to this list. Is there any admin here that could

Re: [Mesa-dev] [PATCH] clover: fix build failure since bfd695e

Ilia Mirkin writes: > On Sat, Feb 13, 2016 at 12:01 PM, Serge Martin wrote: >> --- >> src/gallium/state_trackers/clover/core/kernel.cpp | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH 6/6] st/mesa: use new cso_set_viewport_dims() helper

On 12/02/16 15:43, Brian Paul wrote: --- src/mesa/state_tracker/st_cb_bitmap.c | 16 +++- src/mesa/state_tracker/st_cb_clear.c | 13 ++--- src/mesa/state_tracker/st_cb_drawpixels.c | 14 ++ 3 files changed, 7 insertions(+), 36 deletions(-) diff

[Mesa-dev] [PATCH] mesa: Initialize ctx->Const.MaxComputeSharedMemorySize to a default.

Commit be27f772e8b97031bf5177 added ctx->Const.MaxComputeSharedMemorySize, and added a line to initialize it to a default value of 32768 in the standalone GLSL compiler, but didn't initialize a default value in real GL contexts. This regressed arb_compute_shader-minmax on i965, as the value of

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On 2016-02-13 13:49:37, Samuel Pitoiset wrote: > MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression > introduced in be27f77 (mesa: do not use a constant for > MAX_COMPUTE_SHARED_SIZE). > > Signed-off-by: Samuel Pitoiset > Cc: Mark Janes

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On Sat, Feb 13, 2016 at 4:49 PM, Samuel Pitoiset wrote: > MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression > introduced in be27f77 (mesa: do not use a constant for > MAX_COMPUTE_SHARED_SIZE). > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On Saturday, February 13, 2016 10:49:37 PM PST Samuel Pitoiset wrote: > MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression > introduced in be27f77 (mesa: do not use a constant for > MAX_COMPUTE_SHARED_SIZE). > > Signed-off-by: Samuel Pitoiset > Cc:

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On 02/13/2016 10:55 PM, Jordan Justen wrote: On 2016-02-13 13:49:37, Samuel Pitoiset wrote: MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression introduced in be27f77 (mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE). Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On 02/13/2016 10:57 PM, Kenneth Graunke wrote: On Saturday, February 13, 2016 10:49:37 PM PST Samuel Pitoiset wrote: MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression introduced in be27f77 (mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE). Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Initialize force_writemask_all in vec4_builder().

Matt Turner writes: > --- > src/mesa/drivers/dri/i965/brw_vec4_builder.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_builder.h > b/src/mesa/drivers/dri/i965/brw_vec4_builder.h > index be1427c..5d4b452 100644

Re: [Mesa-dev] [PATCH] clover: fix build failure since bfd695e

On Sat, Feb 13, 2016 at 4:45 PM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Sat, Feb 13, 2016 at 12:01 PM, Serge Martin wrote: >>> --- >>> src/gallium/state_trackers/clover/core/kernel.cpp | 7 --- >>> 1 file

Re: [Mesa-dev] [PATCH] clover: fix build failure since bfd695e

Ilia Mirkin writes: > On Sat, Feb 13, 2016 at 4:45 PM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> On Sat, Feb 13, 2016 at 12:01 PM, Serge Martin wrote: ---

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On 2016-02-13 13:57:17, Samuel Pitoiset wrote: > > On 02/13/2016 10:55 PM, Jordan Justen wrote: > > On 2016-02-13 13:49:37, Samuel Pitoiset wrote: > >> MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression > >> introduced in be27f77 (mesa: do not use a constant for > >>

[Mesa-dev] [Bug 94088] [llvmpipe] SIGFPE pthread_barrier_destroy.c:40

https://bugs.freedesktop.org/show_bug.cgi?id=94088 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH] glsl: remove duplicate interpolation_string() function

We already have one in the IR code that can be used everywhere its needed in the AST code so remove the one from the AST. --- src/compiler/glsl/ast.h | 12 src/compiler/glsl/ast_to_hir.cpp | 7 ++- src/compiler/glsl/ast_type.cpp | 13 - 3 files changed, 2

Re: [Mesa-dev] [PATCH v3] clover: fix build failure since bfd695e

Assuming this compiles, this is Reviewed-by: Ilia Mirkin On Sat, Feb 13, 2016 at 5:39 PM, Serge Martin wrote: > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

On Thu, Feb 11, 2016 at 4:41 PM, Matt Turner wrote: > Gen4/5's SEL instruction cannot use conditional modifiers, so min/max > are implemented as CMP + SEL. Handling that after optimization lets us > CSE more. > > On Ironlake: > >total instructions in shared programs:

[Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression introduced in be27f77 (mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE). Signed-off-by: Samuel Pitoiset Cc: Mark Janes --- This patch is untested because I don't

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

Matt Turner writes: > On Thu, Feb 11, 2016 at 4:41 PM, Matt Turner wrote: >> Gen4/5's SEL instruction cannot use conditional modifiers, so min/max >> are implemented as CMP + SEL. Handling that after optimization lets us >> CSE more. >> >> On Ironlake: >>

Re: [Mesa-dev] [PATCH 2/7] st/mesa: use new cso_save/restore_state() functions

On 12/02/16 15:44, Brian Paul wrote: --- src/mesa/state_tracker/st_cb_bitmap.c | 36 src/mesa/state_tracker/st_cb_clear.c | 46 +++ src/mesa/state_tracker/st_cb_drawpixels.c | 46 +++

[Mesa-dev] [PATCH v7 2/7] clover: make use of llvm_ir_compiler

--- .../state_trackers/clover/llvm/invocation.cpp | 234 ++--- 1 file changed, 23 insertions(+), 211 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 4d11c24..d3347de 100644 ---

[Mesa-dev] [PATCH v7 3/7] clover: program::build change opts to std::string

--- src/gallium/state_trackers/clover/core/program.cpp | 4 ++-- src/gallium/state_trackers/clover/core/program.hpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium/state_trackers/clover/core/program.cpp index

[Mesa-dev] [PATCH v7 6/7] clover: add clLinkProgram (CL 1.2)

Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/api/program.cpp | 31 +++--- src/gallium/state_trackers/clover/core/program.hpp | 4 +-- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH v7 4/7] clover: separate compilation and link stages

--- src/gallium/state_trackers/clover/api/program.cpp | 19 -- .../state_trackers/clover/core/compiler.hpp| 7 +- src/gallium/state_trackers/clover/core/error.hpp | 7 ++ src/gallium/state_trackers/clover/core/program.cpp | 38 ++-

[Mesa-dev] [PATCH v7 7/7] clover: add -create-library option support

--- .../state_trackers/clover/llvm/invocation.cpp | 87 -- .../state_trackers/clover/llvm/ir_compiler.cpp | 46 +--- .../state_trackers/clover/llvm/ir_compiler.hpp | 4 +- 3 files changed, 85 insertions(+), 52 deletions(-) diff --git

[Mesa-dev] [PATCH v7 0/7] add clLinkProgram

This serie add clLinkProgram function needed for CL 1.2. However, it lacks the binary type part that is mandatory for input validation and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed in another serie once we agree on the way to store it. Serge Martin (7): clover: add a LLVM

[Mesa-dev] [PATCH v7 1/7] clover: add a LLVM compiler class

--- src/gallium/state_trackers/clover/Makefile.sources | 3 +- .../state_trackers/clover/llvm/ir_compiler.cpp | 282 + .../state_trackers/clover/llvm/ir_compiler.hpp | 59 + 3 files changed, 343 insertions(+), 1 deletion(-) create mode 100644

Re: [Mesa-dev] [PATCH 1/7] cso: add new cso_save/restore_state() functions

On 12/02/16 15:44, Brian Paul wrote: cso_save_state() takes a bitmask of state items to save. Calling cso_restore_state() restores those states. --- src/gallium/auxiliary/cso_cache/cso_context.c | 109 ++ src/gallium/auxiliary/cso_cache/cso_context.h | 24 ++ 2

[Mesa-dev] [PATCH v7 5/7] clover: override ret_object

Return an API object from an intrusive reference to a Clover object, incrementing the reference count of the object. Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/api/util.hpp | 12 1 file changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/mesa: rename attr variable in st_DrawTex()

On 12/02/16 15:45, Brian Paul wrote: Rename to 'tex_attr' to be a bit more clear. --- src/mesa/state_tracker/st_cb_drawtex.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawtex.c

Re: [Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

On 02/13/2016 11:18 PM, Jordan Justen wrote: On 2016-02-13 13:57:17, Samuel Pitoiset wrote: On 02/13/2016 10:55 PM, Jordan Justen wrote: On 2016-02-13 13:49:37, Samuel Pitoiset wrote: MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression introduced in be27f77 (mesa: do

Re: [Mesa-dev] [PATCH] mesa: Initialize ctx->Const.MaxComputeSharedMemorySize to a default.

On Sat, 2016-02-13 at 13:55 -0800, Kenneth Graunke wrote: > Commit be27f772e8b97031bf5177 added ctx- > >Const.MaxComputeSharedMemorySize, > and added a line to initialize it to a default value of 32768 in the > standalone GLSL compiler, but didn't initialize a default value in > real > GL

[Mesa-dev] [PATCH v3] clover: fix build failure since bfd695e

--- src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 41b3852..8396be9 100644 ---

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Feb 11, 2016 at 4:41 PM, Matt Turner wrote: >>> Gen4/5's SEL instruction cannot use conditional modifiers, so min/max >>> are implemented as

Re: [Mesa-dev] [PATCH v3] clover: fix build failure since bfd695e

Thanks kindly. Reviewed-by: Edward O'Callaghan On 2016-02-14 09:39, Serge Martin wrote: --- src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

Matt Turner writes: > On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> On Thu, Feb 11, 2016 at 4:41 PM, Matt Turner wrote: Gen4/5's SEL instruction cannot use

[Mesa-dev] [PATCH 1/3] nvc0: fix compute state initialization on GK110+

For some unknown reasons, the command 0x518, which is FIRMWARE[0x6] from rnndb, totally hangs the GPU, and a reboot is needed. With that removed, I can succesfully launch compute shaders and so the compute support seems to work as expected. Tested on GK208 and GM107. Signed-off-by: Samuel

[Mesa-dev] [PATCH 2/3] nvc0: add compute support for GM107

Fortunately, compute support on GM107 is very close to GK110, except the GK110_COMPUTE.UNK02C4 which is invalid and should not be used. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv_object.xml.h | 1 +

[Mesa-dev] [PATCH 3/3] nvc0: enable compute support on GK110+ with an envvar

Without this NVF0_COMPUTE environment variable, compute support is initialized by default and this is not what we want for now because it might break 3D. Compute will be enabled by default on GK110+ once we are sure that it won't break anything else. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 1/3] nvc0: fix compute state initialization on GK110+

On Sat, Feb 13, 2016 at 6:31 PM, Samuel Pitoiset wrote: > For some unknown reasons, the command 0x518, which is FIRMWARE[0x6] Please make a note that the blob calls it, along with the args passed in (usually via scratch regs iirc). It's probably one of the context

Re: [Mesa-dev] [PATCH 2/3] nvc0: add compute support for GM107

Reviewed-by: Ilia Mirkin On Sat, Feb 13, 2016 at 6:31 PM, Samuel Pitoiset wrote: > Fortunately, compute support on GM107 is very close to GK110, except > the GK110_COMPUTE.UNK02C4 which is invalid and should not be used. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH v3] clover: fix build failure since bfd695e

Serge Martin writes: > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp > b/src/gallium/state_trackers/clover/core/kernel.cpp > index

Re: [Mesa-dev] [PATCH 3/3] nvc0: enable compute support on GK110+ with an envvar

Reviewed-by: Ilia Mirkin On Sat, Feb 13, 2016 at 6:31 PM, Samuel Pitoiset wrote: > Without this NVF0_COMPUTE environment variable, compute support is > initialized by default and this is not what we want for now because > it might break 3D.

[Mesa-dev] [PATCH v2 5/9] st/mesa: call st_finalize_texture from image atoms

From: Nicolai Hähnle Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_image.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_image.c b/src/mesa/state_tracker/st_atom_image.c

[Mesa-dev] [PATCH v2 1/9] gallium: make image views non-persistent objects

Make them akin to shader buffers, with no refcounting/etc. Just used to pass data about the bound image in ->set_shader_images. Signed-off-by: Ilia Mirkin Reviewed-by: Dave Airlie Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH v2 6/9] st/mesa: set pipe_image_view layers correctly for 3D textures

From: Nicolai Hähnle Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_image.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_image.c

[Mesa-dev] [PATCH v2 3/9] tgsi: show textual format representation

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_text.c | 13 ++--- 2 files changed, 11 insertions(+), 4

[Mesa-dev] [PATCH v2 7/9] st/mesa: allow st_format.h to be included from C++ files

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Dave Airlie --- src/mesa/state_tracker/st_format.h | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/state_tracker/st_format.h

[Mesa-dev] [PATCH v2 0/9] st/mesa: add shader image support

OK... v2 is here, rebased across the recent compute support and Dave's AoA changes (and probably other stuff). No significant changes to the patches themselves. Dave, your R-b was conditional on addressing your feedback re writability of surfaces, but I believe you later decided it was OK as-is,

[Mesa-dev] [PATCH v2 2/9] gallium: add PIPE_SHADER_CAP_MAX_SHADER_IMAGES

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst

[Mesa-dev] [PATCH v2 4/9] st/mesa: add an image atom for shader images

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Dave Airlie --- src/mesa/Makefile.sources | 1 + src/mesa/state_tracker/st_atom.c | 6 + src/mesa/state_tracker/st_atom.h | 6 +

[Mesa-dev] [PATCH v2 8/9] st/mesa: convert GLSL image intrinsics into TGSI

Signed-off-by: Ilia Mirkin Reviewed-by: Dave Airlie --- src/mesa/main/mtypes.h | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 214 - 2 files changed, 211 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v2 9/9] st/mesa: enable GL image extensions when backend supports them

This enables ARB_shader_image_load_store and ARB_shader_image_size when the backend claims support for these. It will also implicitly enable the image component of ARB_shader_texture_image_samples. Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH] st/mesa: empty buffer binding if the buffer's not really there

This can happen with 0-sized buffers. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_atomicbuf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_atomicbuf.c

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

On Sat, Feb 13, 2016 at 3:30 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> On Thu, Feb 11, 2016 at 4:41 PM,

Re: [Mesa-dev] [PATCH] st/mesa: empty buffer binding if the buffer's not really there

Reviewed-by: Samuel Pitoiset On 02/14/2016 01:25 AM, Ilia Mirkin wrote: This can happen with 0-sized buffers. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_atomicbuf.c | 8 +--- 1 file changed, 5 insertions(+), 3

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 87389, which changed state. Bug 87389 Summary: [ILK] HL2 & CS:Source water shader broken https://bugs.freedesktop.org/show_bug.cgi?id=87389 What|Removed |Added

Re: [Mesa-dev] [PATCH] glsl: Fix overflow of ImageAccess[] array.

On Sat, Feb 13, 2016 at 8:27 PM, Kenneth Graunke wrote: > The ImageAccess array is statically sized to MAX_IMAGE_UNIFORMS: > >GLenum ImageAccess[MAX_IMAGE_UNIFORMS]; > > There was no bounds checking ensuring we don't overflow. Passing in a > shader with too many

[Mesa-dev] [PATCH] nir: Add a pass for lower indirect variable dereferences

This new pass lowers load/store_var intrinsics that act on indirect derefs to if-ladder of direct load/store_var intrinsics. The if-ladders perform a simple binary search on the indirect. --- src/compiler/Makefile.sources| 1 + src/compiler/nir/Makefile.sources| 1

Re: [Mesa-dev] [PATCH 6/7] glx: remove incorrect refcounting of DRIdrawable

On 02/11/2016 12:58 PM, Miklós Máté wrote: > On 02/09/2016 05:02 PM, Ian Romanick wrote: >> On 02/08/2016 05:11 PM, Ian Romanick wrote: >>> On 02/05/2016 01:11 PM, Miklós Máté wrote: dri drawables must never be released when unbound from a context as long as their corresponding glx

[Mesa-dev] [PATCH 17/21] nir/builder: Add a helper for inserting jump instructions

--- src/compiler/nir/nir_builder.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index d546e41..d131259 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -361,4 +361,11 @@

[Mesa-dev] [PATCH 06/21] nir/print: Better function argument printing

Since we aren't going to put the function parameters or the return variable in the list of locals, it won't get a proper declaration. This changes nir_print to print the type along with each parameter or return variable. --- src/compiler/nir/nir_print.c | 12 ++-- 1 file changed, 10

[Mesa-dev] [PATCH 08/21] nir/clone: Add support for cloning a single function_impl

--- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_clone.c | 112 ++- 2 files changed, 81 insertions(+), 32 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index ff09075..ae57e5f 100644 --- a/src/compiler/nir/nir.h +++

[Mesa-dev] [PATCH 05/21] nir/print: Factor variable name lookup into a helper

Otherwise, we have a problem when we go to print functions with arguments because their names get added to the hash table during declaration which happens after we print the prototype. --- src/compiler/nir/nir_print.c | 66 1 file changed, 36

[Mesa-dev] [PATCH 07/21] nir/validate: Better function validation

--- src/compiler/nir/nir_validate.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index 24094f6..0c9d816 100644 --- a/src/compiler/nir/nir_validate.c +++

[Mesa-dev] [PATCH 11/21] nir/vars_to_ssa: Use the new nir_phi_builder helper

The efficiency should be approximately the same. We do a little more work per phi node because we have to sort the predecessors. However, we no longer have to walk the blocks a second time to pop things off the stack. The bigger advantage, however, is that we can now re-use the phi placement and

[Mesa-dev] [PATCH 00/21] nir: Functions!

This patch series adds actual function support to NIR. Previously all NIR usage relied on GLSL to have lowered functions away entirely. As a result, any support for functions that was there was dead code and not really tested. With SPIR-V on the horizon, NIR will need real function support.

  1   2   >