[Mesa-dev] [PATCH] mesa: expose EXT_base_instance in ES3 contexts

2016-04-02 Thread Ilia Mirkin
This extension is identical to ARB_base_instance. Reuse the same entrypoints. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/es_EXT.xml | 34 + src/mesa/main/extensions_table.h| 1 + src/mesa/main/tests/dispatch_sanity.cpp | 5 + src/mes

[Mesa-dev] [PATCH] mesa: expose EXT_polygon_offset_clamp in ES contexts

2016-04-02 Thread Ilia Mirkin
The extension spec was extended to also support ES. This functionality is provided all the way back to ES 1.0. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/extensions_table.h| 2 +- src/mesa/main/get_hash_params.py| 6 +++--- src/me

Re: [Mesa-dev] radeonsi, r600g ARB_framebuffer_no_attachments rebased

2016-04-02 Thread Ilia Mirkin
On Sat, Apr 2, 2016 at 10:54 PM, Edward O'Callaghan wrote: > This series implements ARB_framebuffer_no_attachments for radeonsi & > r600g. It is a rebase of the last previous patch series with the > respective Rb's added. > > I have given back my R9 hw today and so this was the last time I ran > p

[Mesa-dev] [PATCH] glsl: make *sampler2DMSArray available in ESSL 3.20

2016-04-02 Thread Ilia Mirkin
Also avoid double-adding the *sampler2DMS types when the array ext is enabled. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_types.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/builtin_types.cpp b/src/compiler/glsl/builtin_type

[Mesa-dev] [PATCH 05/14] mesa/st: Use _mesa_geometric_ functions appropriately

2016-04-02 Thread Edward O'Callaghan
Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometric_ convenience functions for those places where the geometry of the gl_framebuffer is needed. This is in contrast to the geometry of the intersection of the attachments of the gl_framebuffe

[Mesa-dev] [PATCH 11/14] radeonsi: Improve assert info out of si_set_framebuffer_state()

2016-04-02 Thread Edward O'Callaghan
Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 10/14] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

2016-04-02 Thread Edward O'Callaghan
For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 5

[Mesa-dev] [PATCH 06/14] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

2016-04-02 Thread Edward O'Callaghan
Here we store the number of samples and layers directly in the pipe_framebuffer_state so that in the case of ARB_framebuffer_no_attachment we may make use of them directly. Further, we adjust various gallium/auxiliary helper functions accordingly. V2: Convert branches in util_framebuffer_get_nu

[Mesa-dev] [PATCH 13/14] r600g: Enable ARB_framebuffer_no_attachments

2016-04-02 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index e6eec3b..36b808f 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH 12/14] radeonsi: Enable ARB_framebuffer_no_attachments

2016-04-02 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 275b676..97be59d 100644 --- a/src/galli

[Mesa-dev] [PATCH 09/14] softpipe: Set samples and layers in set_framebuffer_state() cb

2016-04-02 Thread Edward O'Callaghan
Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/softpipe/sp_state_surface.c | 2 ++ 1 file

[Mesa-dev] [PATCH 01/14] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

2016-04-02 Thread Edward O'Callaghan
Add PIPE_CAP to determine if the GL extension 'GL_ARB_framebuffer_no_attachments' shall be supported. The driver is required to support 'PIPE_FORMAT_NONE' via its 'is_format_supported()' callback in order to determine the MSAA modes the hardware supports so that values requested from the applicati

[Mesa-dev] [PATCH 14/14] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-04-02 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5b6dc89..c48802a 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -172,

[Mesa-dev] [PATCH 08/14] mesa/st: Update framebuffer state with no.of samples, layers

2016-04-02 Thread Edward O'Callaghan
Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH 04/14] mesa: Add comment to framebuffer_parameteri()

2016-04-02 Thread Edward O'Callaghan
V.2: Change 'N.B.,' to 'NOTE:'. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..c81f5a0 100644 --- a/src/mesa/main/fbobject.c +++

[Mesa-dev] [PATCH 03/14] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-04-02 Thread Edward O'Callaghan
Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. V.2: Rewrite MSAA mode loop to be more general. V.3: Move comment to right place after loop was rewritten. Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_atom_framebuffer.

[Mesa-dev] [PATCH 07/14] gallium/trace: Dump no.of samples and layers in fb state

2016-04-02 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c index b53d7db..e805706 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 02/14] gallium: Obtain ARB_framebuffer_no_attachment constants

2016-04-02 Thread Edward O'Callaghan
Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. We also obtain the MaxFramebufferSamples value using a query back to the driver for PIPE_FORMAT_NONE. V.1: Merge if branch predicates into

[Mesa-dev] radeonsi,r600g ARB_framebuffer_no_attachments rebased

2016-04-02 Thread Edward O'Callaghan
This series implements ARB_framebuffer_no_attachments for radeonsi & r600g. It is a rebase of the last previous patch series with the respective Rb's added. I have given back my R9 hw today and so this was the last time I ran piglit to confirm everything passes and all our applications locally tha

[Mesa-dev] [PATCH] glsl: make ssbo predicate return true when in a GLSL 430 or ESSL 310 shader

2016-04-02 Thread Ilia Mirkin
I can't tell whether this actually matters, but we're creating function signatures with this predicate, so it should probably match when SSBO's are available. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/lower_ubo_reference.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH] glsl: allow conservative depth qualifiers in GLSL 420

2016-04-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Noticed by inspection. src/compiler/glsl/ast_to_hir.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index a609ff9..259bec9 100644 --- a/src/compiler/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 7:55 PM, Roland Scheidegger wrote: > I don't really have anything against the new interface (though don't > really feel qualified for a proper review), but it is indeed the > existence of the two interfaces living in parallel seemingly doing > mostly the same which bothers m

[Mesa-dev] [Bug 94116] program interface queries not returning right data for UBO / GL_BLOCK_INDEX

2016-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94116 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

2016-04-02 Thread Roland Scheidegger
I don't really have anything against the new interface (though don't really feel qualified for a proper review), but it is indeed the existence of the two interfaces living in parallel seemingly doing mostly the same which bothers me. To make things worse, the per context fence_finish is even calle

Re: [Mesa-dev] [PATCH 1/2] gallivm: Use standard LLVMSetAlignment from LLVM 3.4 onwards.

2016-04-02 Thread Roland Scheidegger
Ah nice, I wasn't aware this would now work. For the series: Reviewed-by: Roland Scheidegger Am 02.04.2016 um 16:13 schrieb Jose Fonseca: > Only provide a fallback for LLVM 3.3. > > One less dependency on LLVM C++ interface. > --- > src/gallium/auxiliary/draw/draw_llvm.c | 4 ++--

Re: [Mesa-dev] [PATCH 05/26] nir/types: Add a wrapper for count_attribute_slots

2016-04-02 Thread Jason Ekstrand
This one. Feel free to push it if you want. On Mar 26, 2016 9:27 AM, "Rob Clark" wrote: > On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand > wrote: > > > > Reviewed-by: Rob Clark > > > --- > > src/compiler/nir_types.cpp | 7 +++ > > src/compiler/nir_types.h | 3 +++ > > 2 files changed,

[Mesa-dev] [PATCH] nv50/ir: we can't load local memory directly into an output

2016-04-02 Thread Ilia Mirkin
This fixes piglit tests like tests/spec/glsl-1.10/execution/variable-indexing/vs-output-array-float-index-wr.shader_test and related ones. Signed-off-by: Ilia Mirkin Cc: "11.1 11.2" --- Emil, I'd like to get this one into 11.2.0 -- I'm going to push it out very soon. src/gallium/drivers/no

[Mesa-dev] Please revert "nv50/ir: normalize cube coordinates after derivatives have been computed" in stable

2016-04-02 Thread Ilia Mirkin
Hi Emil, Looks like commit 6eeb284e4f74a2fe5ae6cba90f97f219935e24df causes some regressions in the tex-miplevel-selection test, even though it fixes some dEQP tests. I don't know why this is happening... I'm kinda suspecting that the tex-miplevel-selection test is wrong, but it *is* passing for al

Re: [Mesa-dev] [PATCH 08/16] nir: lower-io-types pass

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 4:49 PM, Jason Ekstrand wrote: > > > On Sat, Apr 2, 2016 at 11:50 AM, Rob Clark wrote: >> >> On Fri, Apr 1, 2016 at 1:46 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> >> >> From: Rob Clark >> >> >> >> A pass to lower

[Mesa-dev] [PATCH] glsl/list: make nodes safe for double removal, etc.

2016-04-02 Thread Rob Clark
From: Rob Clark It's no extra overhead to do a _self_link() and it eliminates a class of potential problems. Signed-off-by: Rob Clark Dared-by: Jason Ekstrand --- src/compiler/glsl/list.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/lis

Re: [Mesa-dev] [PATCH 08/16] nir: lower-io-types pass

2016-04-02 Thread Jason Ekstrand
On Sat, Apr 2, 2016 at 11:50 AM, Rob Clark wrote: > On Fri, Apr 1, 2016 at 1:46 PM, Jason Ekstrand > wrote: > > > > > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: > >> > >> From: Rob Clark > >> > >> A pass to lower complex (struct/array/mat) inputs/outputs to primitive > >> types. This

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 4:33 PM, Rob Clark wrote: > On Sat, Apr 2, 2016 at 4:14 PM, Jason Ekstrand wrote: >> On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> Allegedly this was needed still by scons build.. but in practice it >>> doesn't seem to be needed. Remov

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 4:14 PM, Jason Ekstrand wrote: > On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: >> >> From: Rob Clark >> >> Allegedly this was needed still by scons build.. but in practice it >> doesn't seem to be needed. Removing it and running 'scons' results >> in no build errors.

Re: [Mesa-dev] [PATCH 1/2] gallivm: Use standard LLVMSetAlignment from LLVM 3.4 onwards.

2016-04-02 Thread Brian Paul
On 04/02/2016 08:54 AM, Jose Fonseca wrote: On 02/04/16 15:19, Brian Paul wrote: On 04/02/2016 08:13 AM, Jose Fonseca wrote: Only provide a fallback for LLVM 3.3. One less dependency on LLVM C++ interface. --- src/gallium/auxiliary/draw/draw_llvm.c | 4 ++-- src/gallium/auxilia

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Jason Ekstrand
On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: > From: Rob Clark > > Allegedly this was needed still by scons build.. but in practice it > doesn't seem to be needed. Removing it and running 'scons' results > in no build errors. > Hrm... I'm not 100% sure what I'd like to see done here. One

Re: [Mesa-dev] [PATCH 08/16] nir: lower-io-types pass

2016-04-02 Thread Rob Clark
On Fri, Apr 1, 2016 at 1:46 PM, Jason Ekstrand wrote: > > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> A pass to lower complex (struct/array/mat) inputs/outputs to primitive >> types. This allows, for example, linking that removes unused components >> of a lar

[Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
From: Rob Clark Allegedly this was needed still by scons build.. but in practice it doesn't seem to be needed. Removing it and running 'scons' results in no build errors. Signed-off-by: Rob Clark --- So, afaict NIR is not even built w/ scons build (I'm just running 'scons' with no args, so let

Re: [Mesa-dev] [PATCH 10/16] nir: rename lower_outputs_to_temporaries -> lower_io_to_temporaries

2016-04-02 Thread Rob Clark
On Fri, Apr 1, 2016 at 1:48 PM, Jason Ekstrand wrote: > > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> Since it will gain support to lower inputs, give it a more generic name. >> >> Signed-off-by: Rob Clark >> --- >> src/compiler/Makefile.sources

Re: [Mesa-dev] [PATCH] nv50/ir: fix envyas variants when building the code lib

2016-04-02 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Apr 2, 2016 at 1:57 PM, Samuel Pitoiset wrote: > nvc0 and nve4 have been respectively replaced by gf100 and gk104. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/lib/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletio

[Mesa-dev] [PATCH] nv50/ir: fix envyas variants when building the code lib

2016-04-02 Thread Samuel Pitoiset
nvc0 and nve4 have been respectively replaced by gf100 and gk104. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/lib/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/lib/Makefile b/src/gallium/drivers/no

Re: [Mesa-dev] [PATCH 15/16] mesa/st: add nir pass for lowering builtin uniforms

2016-04-02 Thread Rob Clark
On Fri, Apr 1, 2016 at 2:23 PM, Jason Ekstrand wrote: > > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/mesa/Makefile.sources | 2 + >> src/mesa/state_tracker/st_nir.h | 28 +++ >> src

Re: [Mesa-dev] [PATCH 19/20] mesa/st: enable compute shaders if images are also supported

2016-04-02 Thread Ilia Mirkin
On Sat, Apr 2, 2016 at 9:11 AM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/mesa/state_tracker/st_extensions.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/src/mesa/state_tracker/st_extensio

Re: [Mesa-dev] [PATCH 1/2] gallivm: Use standard LLVMSetAlignment from LLVM 3.4 onwards.

2016-04-02 Thread Jose Fonseca
On 02/04/16 15:19, Brian Paul wrote: On 04/02/2016 08:13 AM, Jose Fonseca wrote: Only provide a fallback for LLVM 3.3. One less dependency on LLVM C++ interface. --- src/gallium/auxiliary/draw/draw_llvm.c | 4 ++-- src/gallium/auxiliary/gallivm/lp_bld.h | 14

[Mesa-dev] [PATCH] gallivm: Fix performance regressions due to vector selects.

2016-04-02 Thread Jose Fonseca
LLVM often can't determine the mask elements are all ones/zeros, and there doesn't seem to be a good way to hint that. Thanks to Roland Scheidegger for spotting and analyzing the issue. --- src/gallium/auxiliary/gallivm/lp_bld_logic.c | 33 ++-- 1 file changed, 17 insertio

Re: [Mesa-dev] [PATCH] mesa: remove unrequired else

2016-04-02 Thread Brian Paul
On 04/02/2016 04:07 AM, Timothy Arceri wrote: The if always returns so no need for an else. --- src/mesa/program/prog_parameter.c | 81 +++ 1 file changed, 39 insertions(+), 42 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/

Re: [Mesa-dev] [PATCH 1/2] gallivm: Use standard LLVMSetAlignment from LLVM 3.4 onwards.

2016-04-02 Thread Brian Paul
On 04/02/2016 08:13 AM, Jose Fonseca wrote: Only provide a fallback for LLVM 3.3. One less dependency on LLVM C++ interface. --- src/gallium/auxiliary/draw/draw_llvm.c | 4 ++-- src/gallium/auxiliary/gallivm/lp_bld.h | 14 .../auxiliary/gallivm/lp_bld_fo

Re: [Mesa-dev] [PATCH 00/11] update swr rasterizer

2016-04-02 Thread Brian Paul
On 04/01/2016 06:22 PM, Tim Rowley wrote: More development of the swr rasterizer. Tim Rowley (11): swr: [rasterizer] Misc fixes identified by static code analysis swr: [rasterizer core] Affinitize thread scratch space to numa node of worker swr: [rasterizer common] win32 build fixu

[Mesa-dev] [PATCH 2/2] gallivm: Remove lp_build_load_volatile.

2016-04-02 Thread Jose Fonseca
No longer needed. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 src/gallium/auxiliary/gallivm/lp_bld_misc.h | 4 2 files changed, 12 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index 61a50fa..c1e

[Mesa-dev] [PATCH 1/2] gallivm: Use standard LLVMSetAlignment from LLVM 3.4 onwards.

2016-04-02 Thread Jose Fonseca
Only provide a fallback for LLVM 3.3. One less dependency on LLVM C++ interface. --- src/gallium/auxiliary/draw/draw_llvm.c | 4 ++-- src/gallium/auxiliary/gallivm/lp_bld.h | 14 .../auxiliary/gallivm/lp_bld_format_aos_array.c| 2 +- src/gallium/auxiliar

Re: [Mesa-dev] [PATCH 19/20] mesa/st: enable compute shaders if images are also supported

2016-04-02 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/02/2016 03:11 PM, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracke

[Mesa-dev] [PATCH 11/20] radeonsi: do per cs setup for compute shaders once per cs

2016-04-02 Thread Bas Nieuwenhuizen
Also removes PKT3_CONTEXT_CONTROL as that is already being done by si_begin_new_cs, when emitting init_config. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c| 69 +++- src/gallium/drivers/radeonsi/si_hw_context.c | 2 + src/gallium/dri

[Mesa-dev] [PATCH 08/20] radeonsi: implement TGSI compute shader creation

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 72 +++ 1 file changed, 54 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 1ec695e..f2b13f0 100644

[Mesa-dev] [PATCH 18/20] radeonsi: clean up compute flush

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_pipe.h | 3 --- src/gallium/drivers/radeonsi/si_state_draw.c | 27 ++- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers

[Mesa-dev] [PATCH 15/20] radeonsi: split texture decompression for compute shaders

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_blit.c | 13 +++-- src/gallium/drivers/radeonsi/si_compute.c| 2 ++ src/gallium/drivers/radeonsi/si_pipe.h | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 4 files changed, 16 insertions(+

[Mesa-dev] [PATCH 12/20] radeonsi: rework compute scratch buffer

2016-04-02 Thread Bas Nieuwenhuizen
Instead of having a scratch buffer per program, have one per context. Also removed the per kernel wave count calculations, but that only helped if the total number of waves in the dispatch was smaller than sctx->scratch_waves. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 19/20] mesa/st: enable compute shaders if images are also supported

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 6c0df8d..7bbe87d 100644 --- a/src/mesa/state_tracker/st_exte

[Mesa-dev] [PATCH 13/20] radeonsi: only emit compute shader state when switching shaders

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 142 +- src/gallium/drivers/radeonsi/si_pipe.h| 2 + 2 files changed, 85 insertions(+), 59 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers

[Mesa-dev] [PATCH 10/20] radeonsi: don't pass scratch buffer to user SGPRs

2016-04-02 Thread Bas Nieuwenhuizen
As far as I can see we use relocations for clover too. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 8 1 file changed, 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 3702e80..9

[Mesa-dev] [PATCH 09/20] radeonsi: split input upload off from si_launch_grid

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 94 +-- 1 file changed, 53 insertions(+), 41 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index f2b13f0..3702e80 100644

[Mesa-dev] [PATCH 20/20] radeonsi: enable TGSI support cap for compute shaders

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 21 - src/gallium/drivers/radeonsi/si_pipe.c| 3 ++- 4 files changed, 21

[Mesa-dev] [PATCH 06/20] radeonsi: set maximum work group size based on block size

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 7c7e9e5..28c7923 100644 --- a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 05/20] radeonsi: implement shared atomics

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 89 +++- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 97d4404..7c7e9e5 100644 ---

[Mesa-dev] [PATCH 02/20] radeonsi: lower compute shader arguments

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 41 src/gallium/drivers/radeonsi/si_shader.h | 7 ++ 2 files changed, 48 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_sh

[Mesa-dev] [PATCH 14/20] radeonsi: implement TGSI compute dispatch

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 104 ++ 1 file changed, 77 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 74db8d4..64ad2f3 100644

[Mesa-dev] [PATCH 16/20] radeonsi: split setting graphics and compute descriptors

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++ src/gallium/drivers/radeonsi/si_descriptors.c | 60 ++- src/gallium/drivers/radeonsi/si_state.h | 7 +++- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 4 files chang

[Mesa-dev] [PATCH 01/20] radeonsi: set shader calling conventions

2016-04-02 Thread Bas Nieuwenhuizen
Note that old mesa + new LLVM or new mesa + old LLVM breaks with this change and the corresponding LLVM change (D18559). For LLVM version <= 3.8 we use the old method, but we can't detect people using a post 3.8 svn version that is still too old. Signed-off-by: Bas Nieuwenhuizen --- src/gallium

[Mesa-dev] [PATCH 17/20] radeonsi: do not do two full flushes on every compute dispatch

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 17 ++--- src/gallium/drivers/radeonsi/si_state.c | 6 -- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 03/20] radeonsi: add shared memory

2016-04-02 Thread Bas Nieuwenhuizen
Declares the shared memory as a global variable so that LLVM is aware of it and it does not conflict with passes like AMDGPUPromoteAlloca. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/radeon_llvm.h | 3 ++ .../drivers/radeon/radeon_setup_tgsi_llvm.c| 4 +++

[Mesa-dev] [PATCH 04/20] radeonsi: implement shared memory load/store

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 75 +++- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 2ce37ca..97d4404 100644 --

[Mesa-dev] [PATCH 07/20] radeonsi: update shader count for compute shaders

2016-04-02 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_state.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h index 95a69e8..6d9f02e 100644 --- a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 00/20] GL compute shaders for radeonsi

2016-04-02 Thread Bas Nieuwenhuizen
This series implements OpenGL compute shader for radeonsi. It is based off master + Nicolai Hähnle's SSBO patches. It depends on two patches for LLVM that have not been committed yet: - D18340 - D18559 The series is also available as the si-compute-shader branches of - https://github.com/BN

[Mesa-dev] [PATCH] mesa: remove unrequired else

2016-04-02 Thread Timothy Arceri
The if always returns so no need for an else. --- src/mesa/program/prog_parameter.c | 81 +++ 1 file changed, 39 insertions(+), 42 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c index 02d84f2..c294b00 100644 ---

Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

2016-04-02 Thread Patrick Rudolph
Are there optimizations done on TGSI ? I can't find any file in src/gallium/auxiliary/tgsi that does so. Kind Regards, Patrick On 2016-03-30 06:59 PM, Ian Romanick wrote: > I'd recommend doing this at a higher level. We've been doing this in > NIR (in nir_opt_algebraic.py) for quite some time, a

Re: [Mesa-dev] [PATCH] xlib: fix memory leak on Display close

2016-04-02 Thread Alejandro Piñeiro
On 02/04/16 00:04, John Sheu wrote: > The XMesaVisual instances freed in the visuals table on display close > are being freed with a free() call, instead of XMesaDestroyVisual(), > causing a memory leak. > --- > src/mesa/drivers/x11/fakeglx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(