[Mesa-dev] [PATCH] i965/fs: fix exec_size when emitting DIM instruction

2016-12-22 Thread Samuel Iglesias Gonsálvez
Otherwise, DIM instructions will be emitted with the default exec size which could be 16 in some cases, that is not legal. Signed-off-by: Samuel Iglesias Gonsálvez Suggested-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-22 Thread Samuel Iglesias Gonsálvez
On Thu, 2016-12-22 at 12:13 -0600, Matt Turner wrote: > On Tue, Dec 13, 2016 at 2:01 AM, Samuel Iglesias Gonsálvez > wrote: > > On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: > > > i965/vec4: add a helper function to create double immediates > > > > > >   Can

Re: [Mesa-dev] [PATCH] radv: handle queue present directly to winsys

2016-12-22 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/23/2016 05:26 PM, Dave Airlie wrote: > From: Dave Airlie > > Don't call the QueueSubmit interface, just call direct to the > winsys, so we can pass the wait semaphores. > > Noticed while debugging doom,

Re: [Mesa-dev] [PATCH 1/5] st/xvmc: use goto to make code more readable (v2)

2016-12-22 Thread Nayan Deshmukh
On Thu, Dec 22, 2016 at 4:56 PM, Christian König wrote: > Am 16.12.2016 um 12:58 schrieb Nayan Deshmukh: >> >> v2: add missing semicolon >> >> Signed-off-by: Nayan Deshmukh > > > Patch #2-#4 are Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH] radv: fix rendering to b10g11r11_ufloat_pack32

2016-12-22 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/23/2016 05:43 PM, Dave Airlie wrote: > From: Dave Airlie > > doom was causing a printf about an illegal color, it was due the > non-void returning -1, and the other function checking for 4, > align these. >

[Mesa-dev] [PATCH] radv: fix rendering to b10g11r11_ufloat_pack32

2016-12-22 Thread Dave Airlie
From: Dave Airlie doom was causing a printf about an illegal color, it was due the non-void returning -1, and the other function checking for 4, align these. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH] radv: handle queue present directly to winsys

2016-12-22 Thread Dave Airlie
From: Dave Airlie Don't call the QueueSubmit interface, just call direct to the winsys, so we can pass the wait semaphores. Noticed while debugging doom, doesn't fix anything. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 10 +- 1

Re: [Mesa-dev] [PATCH 0/3] i965: Fix dEQP-EGL.functional.image.modify.tex_rgb5_a1_tex_subimage_rgba8

2016-12-22 Thread Tapani Pälli
Series is Reviewed-by: Tapani Pälli On 12/23/2016 01:22 AM, Chad Versace wrote: The test failed because in glTexImage2D(format=GL_RGBA, type=GL_UNSIGNED_SHORT_5_5_5_1) Mesa chose BRW_SURFACE_FORMAT_R8G8B8A8_UNORM as the storage format. The two formats have incompatible

[Mesa-dev] [PATCH] radv: handle multi-component shared load/stores.

2016-12-22 Thread Dave Airlie
From: Dave Airlie This was seen in doom shaders, so handle it properly. Signed-off-by: Dave AIrlie --- src/amd/common/ac_nir_to_llvm.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] swr: Fix BugID 9919 compile error (icc-only).

2016-12-22 Thread Rowley, Timothy O
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99119 Reviewed-by: Tim Rowley > On Dec 22, 2016, at 6:06 PM, Bruce Cherniak > wrote: ICC doesn't like the use of

[Mesa-dev] [PATCH] [rfc] spirv: work around doom shaders having load/store to sampler types

2016-12-22 Thread Dave Airlie
From: Dave Airlie Doom appears to generate SPIR-V that loads/store samplers before passing them to functions, this confuses NIR, but I'm not sure it's illegal. Workaround this by replacing the value on store with the access chain from the src. This gets doom a bit further.

Re: [Mesa-dev] [PATCH v2] clover: Use Clang's diagnostics

2016-12-22 Thread Aaron Watry
On Wed, Dec 21, 2016 at 6:49 AM, Vedran Miletić wrote: > Presently errors from frontend are handled only if they occur in > clang::CompilerInvocation::CreateFromArgs(). This patch uses > clang::DiagnosticsEngine to detect errors such as invalid values for > Clang frontend

Re: [Mesa-dev] [PATCH] swr: Fix BugID 9919 compile error (icc-only).

2016-12-22 Thread Matt Turner
On Thu, Dec 22, 2016 at 7:06 PM, Bruce Cherniak wrote: > ICC doesn't like the use of nullptr (std::nullptr_t) argument in > p_atomic_set. GCC and clang don't complain. Is BugID 9919 publicly accessible? If so, I'd provide a link to it. If it's not, I'd include the

[Mesa-dev] [PATCH] egl: Emit correct error when robust context creation fails

2016-12-22 Thread Chad Versace
Fixes dEQP-EGL.functional.create_context_ext.robust_* on Intel with GBM. If the user sets the EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR in EGL_CONTEXT_FLAGS_KHR when creating an OpenGL ES context, then EGL_KHR_create_context spec requires that we unconditionally emit EGL_BAD_ATTRIBUTE because that

[Mesa-dev] [Bug 99119] swr_fence_work.cpp(42): error: argument of type "std::nullptr_t" is incompatible with parameter of type "unsigned long"

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99119 --- Comment #2 from Bruce Cherniak --- Patch has been emailed and will be pushed shortly. Only ICC complains, gcc and clang build fine. https://patchwork.freedesktop.org/patch/129272/ Thank you for pointing out the

[Mesa-dev] [Bug 99119] swr_fence_work.cpp(42): error: argument of type "std::nullptr_t" is incompatible with parameter of type "unsigned long"

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99119 Bruce Cherniak changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [PATCH] i965: Allow import/export of ARGB1555 images (v2)

2016-12-22 Thread Chad Versace
To my knowledge, this fixes no tests. I simply wrote the patch for completeness as a follow-up to the previous two patches. v2: Fix copy-paste error. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH] i965/generator/tex: Handle an immediate sampler with an indirect texture

2016-12-22 Thread Jason Ekstrand
In this case we were dying when we tried to do SHL addr sampler imm(8) because that puts an immediate in src0 of a two source instruction. This fixes 2704 of the new separate sampler Vulkan CTS tests on Sky Lake. Cc: "13.0" ---

[Mesa-dev] [PATCH] swr: Fix BugID 9919 compile error (icc-only).

2016-12-22 Thread Bruce Cherniak
ICC doesn't like the use of nullptr (std::nullptr_t) argument in p_atomic_set. GCC and clang don't complain. --- src/gallium/drivers/swr/swr_fence_work.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_fence_work.cpp

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #7 from APoliTech --- regression* On Dec 22, 2016 20:55, "Polihron Alexandru" wrote: > In the stock version of the os everything runs fine so its a regration. > But again if i install the

Re: [Mesa-dev] [PATCH 5/9] meta: Refactor texture format translation

2016-12-22 Thread Anuj Phogat
On Tue, Dec 20, 2016 at 6:45 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/common/meta_tex_subimage.c | 9 +++-- > src/mesa/main/glformats.c | 15 +++ >

Re: [Mesa-dev] [PATCH 3/9] intel/blorp/dbg: Name blit shaders for easy recognition in dumps

2016-12-22 Thread Anuj Phogat
On Tue, Dec 20, 2016 at 6:45 AM, Topi Pohjolainen wrote: > Blorp clears already have an equivalent. > > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp_blit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 9/9] i965: Drop _mesa_meta_pbo_TexSubImage() even for gen < 6

2016-12-22 Thread Anuj Phogat
On Tue, Dec 20, 2016 at 6:45 AM, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_tex_image.c| 24 +++- > src/mesa/drivers/dri/i965/intel_tex_subimage.c | 19

[Mesa-dev] [PATCH 1/3] dri: Add __DRI_IMAGE_FORMAT_ARGB1555

2016-12-22 Thread Chad Versace
This allows eglCreateImage() to accept textures of said format. Patch 1/2 to fix dEQP-EGL.functional.image.modify.tex_rgb5_a1_tex_subimage_rgba8 on Intel. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99185 --- include/GL/internal/dri_interface.h| 2 ++

[Mesa-dev] [PATCH 0/3] i965: Fix dEQP-EGL.functional.image.modify.tex_rgb5_a1_tex_subimage_rgba8

2016-12-22 Thread Chad Versace
The test failed because in glTexImage2D(format=GL_RGBA, type=GL_UNSIGNED_SHORT_5_5_5_1) Mesa chose BRW_SURFACE_FORMAT_R8G8B8A8_UNORM as the storage format. The two formats have incompatible precision in the alpha channel. One provides binary alpha; the other provides gradient alpha. Intel

[Mesa-dev] [PATCH 2/3] mesa/texformat: Handle GL_RGBA + GL_UNSIGNED_SHORT_5_5_5_1

2016-12-22 Thread Chad Versace
_mesa_choose_tex_format() already handles GL_RGBA + GL_UNSIGNED_SHORT_1_5_5_5_REV by converting it to MESA_FORMAT_B5G5R5A1_UNORM. Teach it do the same for the non-reversed type. Otherwise, the switch's fallthrough converts it to an format, which has incompatible precision in the alpha

[Mesa-dev] [PATCH 3/3] i965: Allow import/export of ARGB1555 images

2016-12-22 Thread Chad Versace
To my knowledge, this fixes no tests. I simply wrote the patch for completeness as a follow-up to the previous two patches. --- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH 1/5] nv50/ir: do not insert texture barriers on gm107

2016-12-22 Thread Samuel Pitoiset
It's actually useless to insert those texture barriers post RA because the current control code (ie. st 0x0) will wait for all dependencies before issuing a new instruction. Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 2/5] nv50/ir: improve instruction pipelining on gm107

2016-12-22 Thread Samuel Pitoiset
This makes use of scheduling control codes which are very useful for improving the instruction pipelining. This patch will increase performance on Maxwell GPUs by, at least, x1.5 up to x3.5 for some benchmarks. Although this has been fairly well tested, I would not be suprised if someone hit a

[Mesa-dev] [PATCH 0/5] nvc0: better instruction pipelining for Maxwell GPUs

2016-12-22 Thread Samuel Pitoiset
Hello, This series makes use of the scheduling control code in order to improve the instruction pipelining on Maxwell GPUs. Starting with the Kepler architecture, where a control instruction has to be inserted every 7 instructions, Maxwell added additional control codes and the control

[Mesa-dev] [PATCH 5/5] nvc0: use sched control codes for gm107 MP counters code

2016-12-22 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/nvc0/nvc0_query_hw_sm.c| 88 +++--- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c

[Mesa-dev] [PATCH 4/5] nvc0: use sched control codes for gm107 blitter shader

2016-12-22 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset Acked-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c

[Mesa-dev] [PATCH] nvc0: enable GL 4.3 on gm107+

2016-12-22 Thread Samuel Pitoiset
Although, arb_shader_image_load_store-atomicity will most likely hang your box, I think it's now quite reasonable to enable GL 4.3 on Maxwell/Pascal GPUs. I suspect that test to be wrong because it doesn't even work on the NVIDIA blob. I have tested a bunch of benchmarks (UE4 demos) and real

[Mesa-dev] [PATCH 3/5] nv50/ir: use sched control codes for gm107 builtins

2016-12-22 Thread Samuel Pitoiset
Yes, IMUL/IMAD require dependency barriers and we should definitely replace these instructions by XMAD but the different flags need to be figured out. Note that XMAD only supports 16-bits integers. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Václav Haisman changed: What|Removed |Added CC||vhais...@gmail.com

Re: [Mesa-dev] [PATCH v2] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 2:21 PM, Ian Romanick wrote: > Reviewed-by: Ian Romanick > Thanks! > On 12/22/2016 01:54 PM, Jason Ekstrand wrote: > > This sequence shows up The Talos Principal, at least under Vulkan, > > and prevents loop analysis

Re: [Mesa-dev] [PATCH v2] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 12/22/2016 01:54 PM, Jason Ekstrand wrote: > This sequence shows up The Talos Principal, at least under Vulkan, > and prevents loop analysis from properly computing trip counts in a > few loops. > --- > src/compiler/nir/nir_opt_algebraic.py

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-22 Thread Jason Ekstrand
Pushed with my R-B On Thu, Dec 22, 2016 at 2:03 PM, Arda Coskunses wrote: > Without this check driver crash when application window > closed unexpectedly. > Acked-by: Edward O'Callaghan > --- > src/vulkan/wsi/wsi_common_x11.c | 4 > 1

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null visual

2016-12-22 Thread Jason Ekstrand
pushed On Thu, Dec 22, 2016 at 1:56 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Thu, Dec 22, 2016 at 1:55 PM, Arda Coskunses > wrote: > >> When application window closed unexpectedly due to >> lost window

[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-22 Thread Arda Coskunses
Without this check driver crash when application window closed unexpectedly. Acked-by: Edward O'Callaghan --- src/vulkan/wsi/wsi_common_x11.c | 4 1 file changed, 4 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null visual

2016-12-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Dec 22, 2016 at 1:55 PM, Arda Coskunses wrote: > When application window closed unexpectedly due to > lost window visualtypes getting invlaid parameters > which is causing a crash. Necessary check is added > to

[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null visual

2016-12-22 Thread Arda Coskunses
When application window closed unexpectedly due to lost window visualtypes getting invlaid parameters which is causing a crash. Necessary check is added to prevent the crash. --- src/vulkan/wsi/wsi_common_x11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c

[Mesa-dev] [PATCH v2] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Jason Ekstrand
This sequence shows up The Talos Principal, at least under Vulkan, and prevents loop analysis from properly computing trip counts in a few loops. --- src/compiler/nir/nir_opt_algebraic.py | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: don't crash on null swapchain

2016-12-22 Thread Arda Coskunses
OK agree, spec is clear on this matter. On Thu, Dec 22, 2016 at 1:48 PM, Jason Ekstrand wrote: > Nak. > > From the Vulkan spec 1.0.37, valid usage for vkGetSwapchainimagesKHR: > >- *swapchain* must be a valid VkSwapchainKHR handle > > We don't silently handle invalid

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 1:37 PM, Ian Romanick wrote: > On 12/22/2016 01:14 PM, Jason Ekstrand wrote: > > On Thu, Dec 22, 2016 at 1:13 PM, Ian Romanick > > wrote: > > > > On 12/19/2016 09:32 PM, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Ian Romanick
On 12/22/2016 01:14 PM, Jason Ekstrand wrote: > On Thu, Dec 22, 2016 at 1:13 PM, Ian Romanick > wrote: > > On 12/19/2016 09:32 PM, Jason Ekstrand wrote: > > This sequence shows up The Talos Principal, at least under Vulkan, > > and

Re: [Mesa-dev] [PATCH 4/6] nir: Add an optimization pass to remove trivial continues

2016-12-22 Thread Jason Ekstrand
On Wed, Dec 21, 2016 at 6:33 PM, Jason Ekstrand wrote: > On Dec 21, 2016 8:11 PM, "Timothy Arceri" > wrote: > > On Mon, 2016-12-19 at 20:11 -0800, Jason Ekstrand wrote: > > --- > > src/compiler/Makefile.sources| 1 + > >

Re: [Mesa-dev] [PATCH 13/13] i965: disable loop unrolling in GLSL IR

2016-12-22 Thread Matt Turner
On Wed, Dec 21, 2016 at 8:26 PM, Timothy Arceri wrote: > There is a single regression in loop unrolling which is: > > loops HURT: shaders/orbital_explorer.shader_test GS SIMD8:0 -> 1 > > However the loop is huge so it seems reasonable not to unroll it. It's >

Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Kenneth Thank you for the commit info. Please consider this patch abandoned. On Thu, Dec 22, 2016 at 11:50 AM, Kenneth Graunke wrote: > On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote: > > Hello Mesa-Dev: > > > > To give you some background, we are

Re: [Mesa-dev] V8 Loop unrolling in NIR

2016-12-22 Thread Jason Ekstrand
I have no real opinion on patch 13. Patch 1 is mine so you need to review it. :-) Patch 3/13 needs a fix or it will break clip and cull. We don't need 6/13 or lcssa_phi at all anymore. Pending fixes to the loop unrolling pass to get rid of Vulkan regressions, the series (except 13) is

Re: [Mesa-dev] [PATCH 13/13] i965: disable loop unrolling in GLSL IR

2016-12-22 Thread Matt Turner
On Thu, Dec 22, 2016 at 2:07 PM, Jason Ekstrand wrote: > I have no real opinion on this patch. Matt? Ken? I'm generally in favor. I suggested Tim split this off from his other patch which enabled NIR loop unrolling so that we could see what contributions each logical

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 1:13 PM, Ian Romanick wrote: > On 12/19/2016 09:32 PM, Jason Ekstrand wrote: > > This sequence shows up The Talos Principal, at least under Vulkan, > > and prevents loop analysis from properly computing trip counts in a > > few loops. > > --- > >

Re: [Mesa-dev] [PATCH 13/13] i965: disable loop unrolling in GLSL IR

2016-12-22 Thread Timothy Arceri
On Thu, 2016-12-22 at 12:07 -0800, Jason Ekstrand wrote: > I have no real opinion on this patch.  Matt?  Ken? I've put the full results here [1]. I don't mind holding off on this patch. In the new year I'll be picking up on my nir packing pass and can include this patch in the series to call NIR

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-22 Thread Ian Romanick
On 12/19/2016 09:32 PM, Jason Ekstrand wrote: > This sequence shows up The Talos Principal, at least under Vulkan, > and prevents loop analysis from properly computing trip counts in a > few loops. > --- > src/compiler/nir/nir_opt_algebraic.py | 8 > 1 file changed, 8 insertions(+) > >

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-22 Thread Jason Ekstrand
On second thought... I'm not sure how this is possible without an app bug or genuine out-of-memory (not likely). We never query any X11 objects other than visuals and those shouldn't be changing out from under us. The only way I can see this happening without out-of-memory is if the app has a

Re: [Mesa-dev] [PATCH] i965: allow unsourced enabled VAO

2016-12-22 Thread Ian Romanick
On 11/03/2016 03:02 AM, Juan A. Suarez Romero wrote: > The GL 4.5 spec says: > "If any enabled array’s buffer binding is zero when DrawArrays > or one of the other drawing commands defined in section 10.4 is > called, the result is undefined." > > This commits avoids crashing the

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: don't crash on null visual

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 9:30 AM, Arda Coskunses wrote: > When application window closed unexpectedly due to > lost window visualtypes getting invlaid parameters > which is causing a crash. Necessary check is added > to prevent the crash. > Yeah... X11 is racy. Anything

Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Timothy Arceri
On Thu, 2016-12-22 at 11:58 -0800, Jason Ekstrand wrote: > I'm not actually sure that we need this anymore.  We never run > convert_to_lcssa unless we are about to make actual CF modifications > and, therefore, report progress.  I've got a patch running through > Jenkins now to find out.  I'm not

Re: [Mesa-dev] [PATCH 6/6] i965: Use nir_opt_trivial_continues and nir_opt_if

2016-12-22 Thread Timothy Arceri
On Thu, 2016-12-22 at 11:42 -0800, Jason Ekstrand wrote: > On Thu, Dec 22, 2016 at 3:57 AM, Timothy Arceri bora.com> wrote: > > On Wed, 2016-12-21 at 21:11 -0800, Jason Ekstrand wrote: > > > On Dec 21, 2016 9:17 PM, "Timothy Arceri" > ra.c > > >

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-22 Thread Jason Ekstrand
I think it's right to return false if wsi_conn is NULL, but I believe there is also an application error here. >From the Vulkan 1.0.37 spec valid usage for vkGetPhysicalDeviceSurfaceSupportKHR, - *connection* must point to a valid X11 *xcb_connection_t*. - *window* must be a valid X11

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: don't crash on null swapchain

2016-12-22 Thread Jason Ekstrand
Nak. >From the Vulkan spec 1.0.37, valid usage for vkGetSwapchainimagesKHR: - *swapchain* must be a valid VkSwapchainKHR handle We don't silently handle invalid usage. On Thu, Dec 22, 2016 at 9:30 AM, Arda Coskunses wrote: > When application window closed

Re: [Mesa-dev] [PATCH 03/13] i965: use nir_lower_indirect_derefs() for GLSL

2016-12-22 Thread Jason Ekstrand
On Wed, Dec 21, 2016 at 6:26 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > This moves the nir_lower_indirect_derefs() call into > brw_preprocess_nir() so thats is called by both OpenGL and Vulkan > and removes that call to the old GLSL IR pass > lower_variable_index_to_cond_assign()

Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 11:58 AM, Jason Ekstrand wrote: > I'm not actually sure that we need this anymore. We never run > convert_to_lcssa unless we are about to make actual CF modifications and, > therefore, report progress. I've got a patch running through Jenkins now >

Re: [Mesa-dev] [PATCH 13/13] i965: disable loop unrolling in GLSL IR

2016-12-22 Thread Jason Ekstrand
I have no real opinion on this patch. Matt? Ken? On Wed, Dec 21, 2016 at 6:26 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > There is a single regression in loop unrolling which is: > > loops HURT: shaders/orbital_explorer.shader_test GS SIMD8:0 -> 1 > > However the loop is

Re: [Mesa-dev] [PATCH 12/13] i965: use nir loop unrolling pass

2016-12-22 Thread Jason Ekstrand
On Wed, Dec 21, 2016 at 6:26 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > shader-db results for BDW: > > total instructions in shared programs: 12589614 -> 12590119 (0.00%) > instructions in affected programs: 50525 -> 51030 (1.00%) > helped: 7 > HURT: 145 > > total cycles in

Re: [Mesa-dev] [PATCH 11/13] nir: pass compiler rather than devinfo to functions that call nir_optimize

2016-12-22 Thread Jason Ekstrand
Can we get rid of is_scalar while we're at it? It should be equivalent to compiler->scalar_stage[nir->stage]. Feel free to make that a follow-on. Either way, Reviewed-by: Jason Ekstrand On Wed, Dec 21, 2016 at 6:26 PM, Timothy Arceri < timothy.arc...@collabora.com>

Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Jason Ekstrand
I'm not actually sure that we need this anymore. We never run convert_to_lcssa unless we are about to make actual CF modifications and, therefore, report progress. I've got a patch running through Jenkins now to find out. I'm not strongly opposed to keeping it but I'd like to know if it's

Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Kenneth Graunke
On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote: > Hello Mesa-Dev: > > To give you some background, we are observing that mask values getting > converted to -1 when running multiple dEQP-GLES31 tests in sequence. > > There's already a previous commit >

Re: [Mesa-dev] [PATCH 6/6] i965: Use nir_opt_trivial_continues and nir_opt_if

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 3:57 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Wed, 2016-12-21 at 21:11 -0800, Jason Ekstrand wrote: > > On Dec 21, 2016 9:17 PM, "Timothy Arceri" > om> wrote: > > On Mon, 2016-12-19 at 20:11 -0800, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-22 Thread Chad Versace
On Wed 21 Dec 2016, Xu, Randy wrote: > Hi, Kenneth > > The patch https://android-review.googlesource.com/#/c/291429/ for GLES3.1 has > been merged to dEQP master branch, so expect the GLES3 change should be > merged also. > In this case, we don't need this change in Mesa. The dEQP maitainers

[Mesa-dev] [Bug 99076] dEQP-GLES3.functional.negative_api.texture#teximage3d fails due to wrong Error code

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99076 --- Comment #2 from Chad Versace --- (In reply to Randy from comment #1) > The patch https://android-review.googlesource.com/#/c/291429/ for GLES3.1 > has been merged to dEQP master branch, so expect the GLES3 change

Re: [Mesa-dev] [PATCH v2] egl/dri2: implement query surface hook

2016-12-22 Thread Chad Versace
On Wed 21 Dec 2016, Tapani Pälli wrote: > This makes better guarantee that the values we return are > in sync what the underlying drawable currently has. > > Together with dEQP change in bug #98327 this fixes following test: > >dEQP-EGL.functional.resize.surface_size.grow > > v2: avoid

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #6 from APoliTech --- In the stock version of the os everything runs fine so its a regration. But again if i install the games and then upgrade de mesa version to 13.0 it's running fine. On Dec 22, 2016 8:42 PM,

Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Hello Mesa-Dev: To give you some background, we are observing that mask values getting converted to -1 when running multiple dEQP-GLES31 tests in sequence. There's already a previous commit (b8b1d83c71fd148d2fd84afdc20c0aa367114f92) that attempted to address the test failures by initializing all

[Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Since the maximum supported precision for stencil buffers is 8 bits, we should set bits 8:31 in the input mask values to zero. The problem is that dEQP tests intentionally call glStencilFunc() with mask values of ~0U (0xU) which overflows to -1 when converted to signed integer by glGet*

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #5 from Vedran Miletić --- OK, let's go the other way. Does it happen on stock Ubuntu Mesa/LLVM? Is it a regression? I had a Bonaire card few months ago and it worked fine. -- You are receiving this mail

[Mesa-dev] Mesa 13.0.3 release candidate

2016-12-22 Thread Emil Velikov
Hello list, The candidate for the Mesa 13.0.3 is now available. Currently we have: - 52 queued - 18 nominated (outstanding) - and 6 rejected patch(es) With this series we have - a handful of fixes for i965 and radeonsi. The ANV driver has gained a few improved smoke testing, less memory

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-22 Thread Matt Turner
On Tue, Dec 13, 2016 at 2:01 AM, Samuel Iglesias Gonsálvez wrote: > On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: >> i965/vec4: add a helper function to create double immediates >> >> Can leave for later: Shouldn't we use the DIM instruction (on >> HSW)?

[Mesa-dev] [PATCH 1/2] vulkan/wsi: don't crash on null swapchain

2016-12-22 Thread Arda Coskunses
When application window closed unexpectedly anv_GetSwapchainImagesKHR function getting called with invlid parameters which cause a crash. Necessary Null check added --- src/intel/vulkan/anv_wsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_wsi.c

[Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: don't crash on null visual

2016-12-22 Thread Arda Coskunses
When application window closed unexpectedly due to lost window visualtypes getting invlaid parameters which is causing a crash. Necessary check is added to prevent the crash. --- src/vulkan/wsi/wsi_common_x11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c

Re: [Mesa-dev] [PATCH] anv: implement pipeline statistics queries

2016-12-22 Thread Ilia Mirkin
Ping? Any further comments/feedback/reviews? On Dec 5, 2016 11:22 AM, "Ilia Mirkin" wrote: On Mon, Dec 5, 2016 at 11:11 AM, Robert Bragg wrote: > > > On Sun, Nov 27, 2016 at 7:23 PM, Ilia Mirkin wrote: >> >> The strategy is to

Re: [Mesa-dev] [PATCH] radeonsi: Bugfix needed for hashcat

2016-12-22 Thread Nicolai Hähnle
On 19.12.2016 23:26, Christian Inci wrote: Hashcat needs MAX_GLOBAL_BUFFERS to be 21 or even 22 for some modes. It'll crash otherwise. I'm adding an assert to see if programs need it to be even higher. Signed-off-by: Christian Inci I'm not too familiar with

[Mesa-dev] [PATCH demos] configure.ac: Auto-detect wayland support

2016-12-22 Thread Andreas Boll
Automatically enables building of wayland demo(s) if the required build dependencies are available. Signed-off-by: Andreas Boll --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ddc68b5..517d196

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #4 from APoliTech --- Created attachment 128633 --> https://bugs.freedesktop.org/attachment.cgi?id=128633=edit Kernel 4.9 Log -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #3 from APoliTech --- i did test kernel 4.9 but i have the same problems plus some cpu kernel errors -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #2 from Vedran Miletić --- Can you try a newer kernel? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] radv: bump texel offsets to align with radeonsi

2016-12-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Dec 22, 2016 at 2:09 AM, Dave Airlie wrote: > From: Dave Airlie > > it appears from the amdgpu-pro results the hw can do more, > but let's just align with radeonsi for now. > > No CTS

Re: [Mesa-dev] [PATCH] radv: set some proper values for interp offset limits.

2016-12-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Dec 22, 2016 at 2:53 AM, Dave Airlie wrote: > From: Dave Airlie > > These are taken from the amdgpu-pro driver, and cause no > CTS change. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 6/6] i965: Use nir_opt_trivial_continues and nir_opt_if

2016-12-22 Thread Timothy Arceri
On Wed, 2016-12-21 at 21:11 -0800, Jason Ekstrand wrote: > On Dec 21, 2016 9:17 PM, "Timothy Arceri" om> wrote: > On Mon, 2016-12-19 at 20:11 -0800, Jason Ekstrand wrote: > > --- > >  src/mesa/drivers/dri/i965/brw_nir.c | 2 ++ > >  1 file changed, 2 insertions(+) > >

Re: [Mesa-dev] [PATCH 1/5] st/xvmc: use goto to make code more readable (v2)

2016-12-22 Thread Christian König
Am 16.12.2016 um 12:58 schrieb Nayan Deshmukh: v2: add missing semicolon Signed-off-by: Nayan Deshmukh Patch #2-#4 are Reviewed-by: Christian König . For patch #1 and #5 I'm a bit hesitated to add them without testing. XvMC isn't widely

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 APoliTech changed: What|Removed |Added CC||ppolih...@gmail.com

[Mesa-dev] [Bug 99179] Mesa freez the pc when running gmaes nativ for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 --- Comment #1 from APoliTech --- Created attachment 128627 --> https://bugs.freedesktop.org/attachment.cgi?id=128627=edit Kernel log -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 99179] Mesa freez the pc when running gmaes nativ for linux

2016-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 Bug ID: 99179 Summary: Mesa freez the pc when running gmaes nativ for linux Product: Mesa Version: 13.0 Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 1/4] vl: add h264 constrained baseline profile

2016-12-22 Thread Christian König
Am 20.12.2016 um 23:27 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König for the whole series. --- src/gallium/auxiliary/util/u_video.h | 1 +