Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

2017-02-01 Thread Andres Gomez
LGTM Reviewed-by: Andres Gomez On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov > > The current regex was tracking only the libdrm_foo packages, while with > recent changed we bumped only (and rightfully so) libdrm. >

Re: [Mesa-dev] [PATCH 4/5] travis: add nearly all gallium drivers to the list

2017-02-01 Thread Andres Gomez
LGTM Reviewed-by: Andres Gomez On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov > > Note: we need the explicit --enable-freedreno for libdrm since the > latter is 'smart' and disables it if building on !arm platforms. >

Re: [Mesa-dev] [PATCH 2/5] configure.ac: add swr to the gallium drivers list.

2017-02-01 Thread Andres Gomez
LGTM Reviewed-by: Andres Gomez On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

2017-02-01 Thread Andres Gomez
On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov > > It's unlikely that any of the additions come as a suprise to anyone > i915, nouveau, radeon, r200). Regardless, state clearly what's Opening parenthesis? ^ Otherwise, LGTM.

Re: [Mesa-dev] [PATCH] mesa: disable on-disk shader cache unless supported by the driver

2017-02-01 Thread Timothy Arceri
On Thu, 2 Feb 2017 16:17:02 +1100 Timothy Arceri wrote: > This will stop people enabling the shader cache on drivers that > don't support it via the env vars. Also this will be required once > support is enabled by default to stop drivers without support from > breaking.

[Mesa-dev] [PATCH 1/2] genxml: Add the CACHE_MODE_0 register on gen9

2017-02-01 Thread Jason Ekstrand
--- src/intel/genxml/gen9.xml | 28 1 file changed, 28 insertions(+) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 671322b..ec29d13 100644 --- a/src/intel/genxml/gen9.xml +++ b/src/intel/genxml/gen9.xml @@ -3471,4 +3471,32 @@ +

[Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-01 Thread Jason Ekstrand
This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 155 - src/intel/vulkan/genX_pipeline.c | 6 +- 3 files changed, 156

[Mesa-dev] [PATCH] mesa: disable on-disk shader cache unless supported by the driver

2017-02-01 Thread Timothy Arceri
This will stop people enabling the shader cache on drivers that don't support it via the env vars. Also this will be required once support is enabled by default to stop drivers without support from breaking. --- src/mesa/main/context.c | 3 ++- src/mesa/main/mtypes.h | 3 +++ 2 files changed, 5

[Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

2017-02-01 Thread Dave Airlie
From: Dave Airlie Although this might come from somewhere else require it explicitly. Signed-off-by: Dave Airlie --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index d4302bf..73a0fda 100644 ---

[Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

2017-02-01 Thread Jason Ekstrand
In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped the framerate on the demo by 25-30%. Enabling the PMA fix brought it back up to

[Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-01 Thread Jason Ekstrand
The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer builder. This helps Dota2 by a couple percent because it allows the hardware to move the depth and stencil

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Dave Airlie
On 2 February 2017 at 13:09, Emil Velikov wrote: > On 2 February 2017 at 02:58, Michel Dänzer wrote: >> On 02/02/17 09:10 AM, Emil Velikov wrote: >>> On 1 February 2017 at 23:28, Vinson Lee wrote: Fixes: b8acb6b17981

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 02:58, Michel Dänzer wrote: > On 02/02/17 09:10 AM, Emil Velikov wrote: >> On 1 February 2017 at 23:28, Vinson Lee wrote: >>> Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") >>> Signed-off-by: Vinson Lee

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Michel Dänzer
On 02/02/17 09:10 AM, Emil Velikov wrote: > On 1 February 2017 at 23:28, Vinson Lee wrote: >> Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") >> Signed-off-by: Vinson Lee > Are you sure that's correct ? > > Afaict the follow-up commits

Re: [Mesa-dev] [PATCH 5/5] travis: use both cores for make/make check

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 01:27, Eric Anholt wrote: > Emil Velikov writes: > >> From: Emil Velikov >> >> The instance offers 2 cores, so use them to speed things up. >> >> Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] configure: make intel require the new libdrm version, not all drivers

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 02:35, Dave Airlie wrote: > On 2 February 2017 at 12:33, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin > > For the series. > > Reviewed-by: Dave Airlie > Guys I'm getting tired of this.

Re: [Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 02:33, Ilia Mirkin wrote: > The intent of the libdrm_driver version limits has always been to not > burden the "other" drivers with updating their libdrm unless really > necessary. Unfortunately the configure script erroneously only checked > the

Re: [Mesa-dev] [PATCH 2/2] configure: make intel require the new libdrm version, not all drivers

2017-02-01 Thread Dave Airlie
On 2 February 2017 at 12:33, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin For the series. Reviewed-by: Dave Airlie > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH] configure.ac: describe what all the LIBDRM_*REQUIRED macros mean

2017-02-01 Thread Emil Velikov
From: Emil Velikov They are versions of the respective libdrm package. They are _not_ the version of libdrm[.so] required for driver X. Doing the latter will lead to combinatoric explosion and in all fairness things will likely be broken most of the time. To make

[Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

2017-02-01 Thread Ilia Mirkin
The intent of the libdrm_driver version limits has always been to not burden the "other" drivers with updating their libdrm unless really necessary. Unfortunately the configure script erroneously only checked the driver-specific bit and not the generic bit of libdrm as well. Fix this.

[Mesa-dev] [PATCH 2/2] configure: make intel require the new libdrm version, not all drivers

2017-02-01 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 59053a5..a648b79 100644 --- a/configure.ac +++ b/configure.ac @@ -67,10 +67,10 @@ OPENCL_VERSION=1

[Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

2017-02-01 Thread Jason Ekstrand
This seemed to help Dota 2 by a percent or two. --- src/intel/vulkan/genX_pipeline.c | 133 +-- 1 file changed, 99 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index f6940d2..1961874 100644 ---

[Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

2017-02-01 Thread Jason Ekstrand
In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped the framerate on the demo by 25-30%. Enabling the PMA fix brought it back up to

[Mesa-dev] [PATCH 0/5] anv: Implement the depth PMA fix on Broadwell

2017-02-01 Thread Jason Ekstrand
This little series does a few little cleanups as well as implements the PMA fix on Broadwell. The cleanups are focussed around letting us not set 3DSTATE_WM_DEPTH_STENCIL::Depth/StencilBufferWriteEnable unless we absolutely need to. It turns out that Intel hardware makes early/late depth test

[Mesa-dev] [PATCH 2/5] genxml: Add the CACHE_MODE_1 register on gen8

2017-02-01 Thread Jason Ekstrand
--- src/intel/genxml/gen8.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 970e637..32ed764 100644 --- a/src/intel/genxml/gen8.xml +++ b/src/intel/genxml/gen8.xml @@ -3200,4 +3200,25 @@ + +

[Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-01 Thread Jason Ekstrand
The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer builder. This helps Dota2 by a couple percent because it allows the hardware to move the depth and stencil

[Mesa-dev] [PATCH 4/5] anv/pipeline: Make a copy of VkPipelineDepthStencilStateCreateinfo

2017-02-01 Thread Jason Ekstrand
--- src/intel/vulkan/genX_pipeline.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index a7b294f..f6940d2 100644 --- a/src/intel/vulkan/genX_pipeline.c +++

Re: [Mesa-dev] Samping GL_R32UI?

2017-02-01 Thread Roland Scheidegger
Am 01.02.2017 um 05:32 schrieb Andrew A.: > Are there any known issues with using usampler2D on a GL_R32UI texture > in llvmpipe from within a VS/FS? I'm getting expected results on > Nvidia drivers (proprietary), but not with mesa llvmpipe (always get > zero). Not that I know of. There should be

Re: [Mesa-dev] [PATCH 5/5] travis: use both cores for make/make check

2017-02-01 Thread Eric Anholt
Emil Velikov writes: > From: Emil Velikov > > The instance offers 2 cores, so use them to speed things up. > > Signed-off-by: Emil Velikov They don't just set MAKEFLAGS in the environment? That's weird. Looks

[Mesa-dev] [PATCH] anv/pass: Store the depth-stencil attachment's last subpass index

2017-02-01 Thread Nanley Chery
Commit 968ffd6c868af7226e8f889573eef709888151cb stored the last subpass index of all the attachments but that of the depth-stencil attachment. This could cause depth buffers used in multiple subpasses not to be in the requested final layout. Fix this error. Cc: "17.0"

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 00:36, Dave Airlie wrote: > On 2 February 2017 at 10:06, Emil Velikov wrote: >> On 2 February 2017 at 00:00, Dave Airlie wrote: >>> On 2 February 2017 at 09:58, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH] docs: add link to http://mesamatrix.net/

2017-02-01 Thread Timothy Arceri
On Wed, 2017-02-01 at 14:36 -0700, Brian Paul wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95460 > --- >  docs/features.txt | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/docs/features.txt b/docs/features.txt > index 55b1fbb..300442b 100644 > ---

[Mesa-dev] Samping GL_R32UI?

2017-02-01 Thread Andrew A.
Are there any known issues with using usampler2D on a GL_R32UI texture in llvmpipe from within a VS/FS? I'm getting expected results on Nvidia drivers (proprietary), but not with mesa llvmpipe (always get zero). ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 00:38, Vinson Lee wrote: > On Wed, Feb 1, 2017 at 4:10 PM, Emil Velikov wrote: >> On 1 February 2017 at 23:28, Vinson Lee wrote: >>> Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") >>>

Re: [Mesa-dev] [PATCH 2/2] radv/ac: move to using shared emit_ddxy code.

2017-02-01 Thread Bas Nieuwenhuizen
For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 2, 2017, at 00:56, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 75 >

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 Vinson Lee changed: What|Removed |Added Keywords||bisected

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Vinson Lee
On Wed, Feb 1, 2017 at 4:10 PM, Emil Velikov wrote: > On 1 February 2017 at 23:28, Vinson Lee wrote: >> Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") >> Signed-off-by: Vinson Lee > Are you sure that's correct ?

Re: [Mesa-dev] [PATCH 2/2] radv/ac: use shared thread id code

2017-02-01 Thread Bas Nieuwenhuizen
For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 2, 2017, at 00:41, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 44 >

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Dave Airlie
On 2 February 2017 at 10:06, Emil Velikov wrote: > On 2 February 2017 at 00:00, Dave Airlie wrote: >> On 2 February 2017 at 09:58, Emil Velikov wrote: >>> On 1 February 2017 at 22:19, Dave Airlie wrote:

Re: [Mesa-dev] [PATCH] radv/ac: migrate to using shared code for some load/store stuff.

2017-02-01 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 2, 2017, at 00:19, Dave Airlie wrote: > From: Dave Airlie > > This migrates to the code shared with radeonsi. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c |

Re: [Mesa-dev] [PATCH 2/2] radeonsi/ac: move tbuffer store and buffer load to shared code.

2017-02-01 Thread Bas Nieuwenhuizen
For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 2, 2017, at 00:15, Dave Airlie wrote: > From: Dave Airlie > > These are all reuseable by radv. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_llvm_util.c

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #3 from Emil Velikov --- The member in question was removed with commit efdaf5fa3e74ca4f3d9217dc6955aef6dc698a68 Author: Tim Rowley Date: Tue Jul 12 15:03:42 2016 -0600

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 23:28, Vinson Lee wrote: > Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") > Signed-off-by: Vinson Lee Are you sure that's correct ? Afaict the follow-up commits make use of updated i915_drm.h which should be provided

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

2017-02-01 Thread Anuj Phogat
On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand wrote: > Nothing uses this yet but it serves as a nice bit of documentation > that's relatively easy to find. > --- > src/intel/isl/isl.h| 2 ++ > src/intel/isl/isl_format.c | 15 +++ > 2 files changed, 17

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Emil Velikov
On 2 February 2017 at 00:00, Dave Airlie wrote: > On 2 February 2017 at 09:58, Emil Velikov wrote: >> On 1 February 2017 at 22:19, Dave Airlie wrote: >>> Just make radv depend on enable-gallium-llvm. >>> >>> I really don't want to

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Dave Airlie
On 2 February 2017 at 09:58, Emil Velikov wrote: > On 1 February 2017 at 22:19, Dave Airlie wrote: >> Just make radv depend on enable-gallium-llvm. >> >> I really don't want to make the #defines into the spaghetti this introduces. >> > Not a huge fan

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 22:19, Dave Airlie wrote: > Just make radv depend on enable-gallium-llvm. > > I really don't want to make the #defines into the spaghetti this introduces. > Not a huge fan of it either. We need these for 17.0 and flipping things in a feature freeze period

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: call DrawBuffer(s) driver hook in update_framebuffer for windows-system FB

2017-02-01 Thread Brian Paul
On 01/20/2017 07:18 AM, Manolova, Plamena wrote: This looks good to me :) Reviewed-by: Plamena Manolova > On Fri, Jan 20, 2017 at 9:38 AM, Boyan Ding > wrote: When draw

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #2 from Vinson Lee --- Fedora 26 $ gcc --version gcc (GCC) 7.0.1 20170128 (Red Hat 7.0.1-0.3) Copyright (C) 2017 Free Software Foundation, Inc. This is free software; see the source for copying conditions.

[Mesa-dev] [PATCH 2/2] radv/ac: move to using shared emit_ddxy code.

2017-02-01 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 75 - 1 file changed, 7 insertions(+), 68 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 1/2] radeonsi/ac: move most of emit_ddxy to shared code.

2017-02-01 Thread Dave Airlie
From: Dave Airlie We can reuse this in radv. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c| 74 ++ src/amd/common/ac_llvm_util.h| 12 + src/gallium/drivers/radeonsi/si_shader.c | 78

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #1 from Bruce Cherniak --- What environment are you compiling under (os, compiler (gcc, icc, clang), and version)? Clip::ClipScalar() looks like it might be dead code and should be removed. -- You are

[Mesa-dev] [PATCH 2/2] radv/ac: use shared thread id code

2017-02-01 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 44 ++--- 1 file changed, 2 insertions(+), 42 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 1/2] radeonsi/ac: move get thread id to shared code.

2017-02-01 Thread Dave Airlie
From: Dave Airlie radv will use this. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c| 48 +++ src/amd/common/ac_llvm_util.h| 6 +++- src/gallium/drivers/radeonsi/si_shader.c | 57

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99633 Bug ID: 99633 Summary: rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’ Product: Mesa Version: git Hardware: x86-64

[Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

2017-02-01 Thread Vinson Lee
Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") Signed-off-by: Vinson Lee --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 92339b4..d4302bf 100644 --- a/configure.ac +++ b/configure.ac @@

[Mesa-dev] [PATCH] radv/ac: migrate to using shared code for some load/store stuff.

2017-02-01 Thread Dave Airlie
From: Dave Airlie This migrates to the code shared with radeonsi. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 128 +--- 1 file changed, 28 insertions(+), 100 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radeonsi/ac: move tbuffer store and buffer load to shared code.

2017-02-01 Thread Dave Airlie
From: Dave Airlie These are all reuseable by radv. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c| 154 + src/amd/common/ac_llvm_util.h| 44 +- src/gallium/drivers/radeonsi/si_shader.c | 225

[Mesa-dev] [PATCH 1/2] radeonsi/ac: move a bunch of load/store related things to common code.

2017-02-01 Thread Dave Airlie
From: Dave Airlie These are all shareable with radv, so start migrating them to the common code. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c | 65 src/amd/common/ac_llvm_util.h | 22

Re: [Mesa-dev] [Mesa-stable] [PATCH] android: fix llvm, elf dependencies for M, N releases

2017-02-01 Thread Emil Velikov
On 30 January 2017 at 19:57, Mauro Rossi wrote: > These changes set the correct llvm version and elf include path > which differ for Marshmallow and Nougat > --- > Android.common.mk | 14 -- > src/amd/Android.common.mk | 2 +- >

Re: [Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

2017-02-01 Thread Brian Paul
On 01/30/2017 10:06 AM, Nicolai Hähnle wrote: On 27.01.2017 16:02, Marek Olšák wrote: On Fri, Jan 27, 2017 at 3:38 PM, Roland Scheidegger wrote: Am 27.01.2017 um 12:02 schrieb Marek Olšák: From: Marek Olšák For lower memory usage and more efficient

[Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

2017-02-01 Thread Jason Ekstrand
The term "lossless compression" could potentially mean multisample color compression, single-sample color compression or HiZ because they are all lossless. The term CCS_E, however, has a very precise meaning; in ISL and is only used to refer to single-sample color compression. It's also much

[Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

2017-02-01 Thread Jason Ekstrand
Nothing uses this yet but it serves as a nice bit of documentation that's relatively easy to find. --- src/intel/isl/isl.h| 2 ++ src/intel/isl/isl_format.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index

[Mesa-dev] [PATCH 4/5] intel/isl: Assert that we don't use CCS for storage images

2017-02-01 Thread Jason Ekstrand
I enabled CCS for storage images in the Vulkan driver and ran it through the CTS. It didn't result in any hangs but it demonstrated that the data port cannot handle CCS. --- src/intel/isl/isl_surface_state.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH 3/5] intel/isl: Add a formats_are_ccs_e_compatible helper

2017-02-01 Thread Jason Ekstrand
--- src/intel/blorp/blorp_blit.c | 6 ++ src/intel/isl/isl.h | 4 src/intel/isl/isl_format.c | 31 +++ 3 files changed, 41 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 8a944fb..b89a112 100644 ---

[Mesa-dev] [PATCH 5/5] anv: Remove the finishme for CCS_E with storage images

2017-02-01 Thread Jason Ekstrand
The data port can't handle CCS at all so replace the finishme with better comments. --- src/intel/vulkan/anv_image.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 94436ca..e59ef4d 100644

[Mesa-dev] [PATCH 2/5] configure.ac: add swr to the gallium drivers list.

2017-02-01 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 93e4a1a8a9..0aec5326ba 100644 --- a/configure.ac +++ b/configure.ac @@

[Mesa-dev] [PATCH 5/5] travis: use both cores for make/make check

2017-02-01 Thread Emil Velikov
From: Emil Velikov The instance offers 2 cores, so use them to speed things up. Signed-off-by: Emil Velikov --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

2017-02-01 Thread Emil Velikov
From: Emil Velikov The current regex was tracking only the libdrm_foo packages, while with recent changed we bumped only (and rightfully so) libdrm. Fix the regex to track any libdrm package. Cc: Rhys Kidd Cc: Eric Anholt

[Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

2017-02-01 Thread Emil Velikov
From: Emil Velikov It's unlikely that any of the additions come as a suprise to anyone i915, nouveau, radeon, r200). Regardless, state clearly what's available. Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 4/5] travis: add nearly all gallium drivers to the list

2017-02-01 Thread Emil Velikov
From: Emil Velikov Note: we need the explicit --enable-freedreno for libdrm since the latter is 'smart' and disables it if building on !arm platforms. The ilo, radeonsi and swr are explicitly left out since the former is on its way out, while the latter two require

Re: [Mesa-dev] [PATCH] Revert "i915: Always enable GL 2.0 support."

2017-02-01 Thread Kenneth Graunke
On Wednesday, February 1, 2017 12:35:15 PM PST Eero Tamminen wrote: > Hi, > > On 31.01.2017 21:12, Matt Turner wrote: > > On Sun, Jan 29, 2017 at 8:29 PM, Kenneth Graunke > > wrote: > >> On Sunday, January 29, 2017 6:20:10 PM PST Matt Turner wrote: > >>> This partially

Re: [Mesa-dev] [PATCH] docs: add link to http://mesamatrix.net/

2017-02-01 Thread Kenneth Graunke
On Wednesday, February 1, 2017 2:36:02 PM PST Brian Paul wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95460 > --- > docs/features.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/docs/features.txt b/docs/features.txt > index 55b1fbb..300442b 100644 > ---

Re: [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Dave Airlie
Just make radv depend on enable-gallium-llvm. I really don't want to make the #defines into the spaghetti this introduces. Dave. > diff --git a/configure.ac b/configure.ac > index f956df5120..5101e3bb0b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1001,7 +1001,6 @@

Re: [Mesa-dev] [PATCH 1/2] gallivm: add no-signed-zeros-fp-math option to lp_create_builder

2017-02-01 Thread Brian Paul
On 01/30/2017 11:44 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 --- src/gallium/auxiliary/gallivm/lp_bld_misc.h | 8 +++- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 +-

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 Captain Crutches changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 2/3] vc4: fix arm64 build with Neon

2017-02-01 Thread Eric Anholt
Emil Velikov writes: > On 30 January 2017 at 22:54, Rob Herring wrote: >> The addition of Neon assembly breaks on arm64 builds because the assembly >> syntax is different. For now, restrict Neon to ARMv7 builds. >> >> Signed-off-by: Rob Herring

Re: [Mesa-dev] [RFC PATCH] gallium: add a common uploader to pipe_context

2017-02-01 Thread Brian Paul
On 01/27/2017 04:00 AM, Marek Olšák wrote: On Fri, Jan 27, 2017 at 10:05 AM, Nicolai Hähnle wrote: On 27.01.2017 00:51, Marek Olšák wrote: From: Marek Olšák For lower memory usage and more efficient updates of the buffer residency list. (e.g. if

[Mesa-dev] [Bug 95460] Please add more drivers (freedreno, virgl) to features.txt status document

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95460 --- Comment #5 from Brian Paul --- I'll try to add a link in the docs to point to https://mesamatrix.net -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] docs: add link to http://mesamatrix.net/

2017-02-01 Thread Brian Paul
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95460 --- docs/features.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/features.txt b/docs/features.txt index 55b1fbb..300442b 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -335,3 +335,6 @@ we DO NOT WANT

Re: [Mesa-dev] [PATCH] anv: Don't use bogus alpha swizzles

2017-02-01 Thread Anuj Phogat
On Wed, Feb 1, 2017 at 12:39 PM, Jason Ekstrand wrote: > > For RGB formats in Vulkan, we use the corresponding RGBA format with a > swizzle of RGB1. While this swizzle is exactly what we want for > texturing, it's not allowed for rendering according to the docs. While > we

[Mesa-dev] [Bug 99631] segfault with OSVRTrackerView and openscenegraph git master

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99631 --- Comment #3 from Ilia Mirkin --- Candidate patch sent as https://patchwork.freedesktop.org/patch/136383/ Not sure if it's too heavy. -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [PATCH] vbo: process buffer binding state changes on draw when recording

2017-02-01 Thread Ilia Mirkin
The VBO module keeps track of any vbo buffers. It updates this list when receiving an InvalidateState call, however this never happens when recording draws right now. Make sure that we do all the usual state updates when recording draws so that the VBO list may be kept up to date. Signed-off-by:

[Mesa-dev] [Bug 99631] segfault with OSVRTrackerView and openscenegraph git master

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99631 --- Comment #2 from Brian Paul --- Thanks for looking into this, Ilia. If you get stuck, I'll try to look at it in a few days. BTW, we should probably create a piglit test for this issue. -- You are receiving this mail

[Mesa-dev] [Bug 99631] segfault with OSVRTrackerView and openscenegraph git master

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99631 --- Comment #1 from Ilia Mirkin --- The issue appears that the right buffer object isn't mapped. The fact that the ARRAY_BUFFER is modified doesn't appear to make it into the actx->NewState bit. The following "fixes" the

[Mesa-dev] [PATCH] anv: Don't use bogus alpha swizzles

2017-02-01 Thread Jason Ekstrand
For RGB formats in Vulkan, we use the corresponding RGBA format with a swizzle of RGB1. While this swizzle is exactly what we want for texturing, it's not allowed for rendering according to the docs. While we haven't been getting hangs or anything, we should probably obey the docs. This commit

[Mesa-dev] [PATCH] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-02-01 Thread Bruce Cherniak
If stride is supplied (as either stride or slice_stride), trace_dump_box_bytes will try to read stride bytes, regardless whether start address is offset by box->x. This causes access outside mapped region, and possible segv. (transfer_map stride and layer_stride are not adjusted for box

Re: [Mesa-dev] [PATCH 2/3] vc4: fix arm64 build with Neon

2017-02-01 Thread Emil Velikov
On 30 January 2017 at 22:54, Rob Herring wrote: > The addition of Neon assembly breaks on arm64 builds because the assembly > syntax is different. For now, restrict Neon to ARMv7 builds. > > Signed-off-by: Rob Herring > --- >

[Mesa-dev] [Bug 99631] segfault with OSVRTrackerView and openscenegraph git master

2017-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99631 Bug ID: 99631 Summary: segfault with OSVRTrackerView and openscenegraph git master Product: Mesa Version: git Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl

2017-02-01 Thread Marek Olšák
On Tue, Jan 31, 2017 at 11:23 PM, Alex Deucher wrote: > On Tue, Jan 31, 2017 at 5:06 PM, Emil Velikov > wrote: >> On 31 January 2017 at 15:43, Deucher, Alexander >> wrote: -Original Message- From:

Re: [Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

2017-02-01 Thread Marek Olšák
FYI, if there are no other comments, I'll push this series. Marek On Mon, Jan 30, 2017 at 6:06 PM, Nicolai Hähnle wrote: > On 27.01.2017 16:02, Marek Olšák wrote: >> >> On Fri, Jan 27, 2017 at 3:38 PM, Roland Scheidegger >> wrote: >>> >>> Am 27.01.2017

Re: [Mesa-dev] [PATCH 0/4] configure.ac: LLVM again!

2017-02-01 Thread Marek Olšák
On Wed, Feb 1, 2017 at 7:52 PM, Emil Velikov wrote: > On 1 February 2017 at 17:32, Marek Olšák wrote: >> On Wed, Feb 1, 2017 at 3:04 PM, Emil Velikov >> wrote: >>> On 29 January 2017 at 23:13, Marek Olšák

Re: [Mesa-dev] [PATCH v2] anv: emit DrawID if needed

2017-02-01 Thread Jason Ekstrand
Thanks! Series is Reviewed-by: Jason Ekstrand On Wed, Feb 1, 2017 at 3:09 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > v2: use define for buffer ID (Jason) > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Anuj Phogat

[Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

2017-02-01 Thread Emil Velikov
From: Tobias Droste Currently --enable-gallium-llvm is equivalent to HAVE_LLVM. At the same time, non-gallium users such as radv do not require anything from gallium (let alone the llvm code), thus they do not depend on it. One option is to rename the gallium define to

Re: [Mesa-dev] [PATCH 2/2] blorp: Embed a wm_prog_data in blorp_prog_data

2017-02-01 Thread Jason Ekstrand
Turns out these were already in-tree and I forgot I pushed them... Sorry for the noise. On Wed, Feb 1, 2017 at 12:01 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Jan 31, 2017 at 11:05:28AM -0800, Jason Ekstrand wrote: > > While we're at it, we rename it to remove the brw_

Re: [Mesa-dev] [PATCH 0/4] configure.ac: LLVM again!

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 17:32, Marek Olšák wrote: > On Wed, Feb 1, 2017 at 3:04 PM, Emil Velikov wrote: >> On 29 January 2017 at 23:13, Marek Olšák wrote: >>> On Sun, Jan 29, 2017 at 11:14 PM, Tobias Droste wrote:

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

2017-02-01 Thread Anuj Phogat
On Tue, Jan 31, 2017 at 6:51 PM, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-02-01 Thread Ilia Mirkin
On Wed, Feb 1, 2017 at 1:18 PM, Antía Puentes wrote: > Hi Ilia, > > On mié, 2017-02-01 at 00:37 -0500, Ilia Mirkin wrote: >> On Tue, Jan 31, 2017 at 2:55 PM, Antía Puentes wrote: >> > >> > There was an update in the OpenGL ES 3.2 specification (November

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-02-01 Thread Antía Puentes
Hi Ilia, On mié, 2017-02-01 at 00:37 -0500, Ilia Mirkin wrote: > On Tue, Jan 31, 2017 at 2:55 PM, Antía Puentes wrote: > > > > There was an update in the OpenGL ES 3.2 specification (November 3, > > 2016) addressing this: > > > > - In section "9.2.8 Attaching Texture

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-02-01 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Jan 24, 2017 at 7:39 AM, Plamena Manolova wrote: > Since we already have the functionality in place and games > like Game of Thrones seem to depend on this extension, I > think it makes sense to enable it by

  1   2   >