Re: [Mesa-dev] [PATCH v2 2/2] anv: Implement the Sky Lake stencil PMA optimization

On 17-02-02 13:27:05, Jason Ekstrand wrote: This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 157

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #11 from Bogomil Vasilev --- (In reply to Dave Airlie from comment #10) > Please retest with the radv-wip-doom-wine branch. > > It should be rendering properly now. Works perfect! I don't experience any issues

Re: [Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

Reviewed-by: Samuel Iglesias Gonsálvez On Thu, 2017-02-02 at 13:14 -0800, Kenneth Graunke wrote: > dEQP-EGL.functional.create_context.no_config tries to create a > context > with no config, then immediately destroys it.  The drawbuffer is > never > set up, so we can't

[Mesa-dev] [Bug 99662] DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory

https://bugs.freedesktop.org/show_bug.cgi?id=99662 charlie changed: What|Removed |Added Resolution|--- |NOTABUG

Re: [Mesa-dev] [PATCH] radv: fix shared memory load/stores.

On 3 February 2017 at 13:35, Dave Airlie wrote: > From: Dave Airlie > > If we have an indirect index here we need to scale it by attribute slots > e.g. is this is vec2[256] then we get an indir_index in the 0.255 range > but the vec2 are aligned inside vec4

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

On Thu, Feb 2, 2017 at 3:34 PM, Christian König wrote: > Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: >> >> we anyway allow for multiple slices >> >> Signed-off-by: Nayan Deshmukh >> --- >> src/gallium/state_trackers/va/picture_mpeg12.c | 1

[Mesa-dev] [Bug 99662] DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory

https://bugs.freedesktop.org/show_bug.cgi?id=99662 --- Comment #2 from charlie --- glxinfo reports: OpenGL renderer string: Gallium 0.4 on AMD FIJI (DRM 3.9.0 / 4.10.0-rc3+, LLVM 5.0.0) But that LLVM might be a couple of weeks old. I will recompile todays LLVM git. --

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #10 from Dave Airlie --- Please retest with the radv-wip-doom-wine branch. It should be rendering properly now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 99662] DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory

https://bugs.freedesktop.org/show_bug.cgi?id=99662 --- Comment #1 from Dave Airlie --- try a newer llvm if you are using llvm 4.0 snapshots. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] radv: fix shared memory load/stores.

From: Dave Airlie If we have an indirect index here we need to scale it by attribute slots e.g. is this is vec2[256] then we get an indir_index in the 0.255 range but the vec2 are aligned inside vec4 slots. So scale the indir index, then extract the channels. This appears to

[Mesa-dev] [Bug 99662] DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory

https://bugs.freedesktop.org/show_bug.cgi?id=99662 Bug ID: 99662 Summary: DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

From: Dave Airlie We count the number of slots used, but slots are vec4 sized, so we have to scale by 16 not 4. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

Reviewed-by: Edward O'Callaghan On 02/03/2017 12:04 PM, Dave Airlie wrote: > From: Dave Airlie > > These regressed and caused doom to stop loading. > > Fixes: > 03724af26 radv/ac: Implement Float64 load/store var. > > Signed-off-by: Dave

Re: [Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

Reviewed-by: Edward O'Callaghan On 02/03/2017 12:47 PM, Dave Airlie wrote: > From: Dave Airlie > > We count the number of slots used, but slots are vec4 sized, > so we have to scale by 16 not 4. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

From: Dave Airlie We count the number of slots used, but slots are vec4 sized, so we have to scale by 16 not 4. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

On Wed, Feb 1, 2017 at 9:36 PM, Emil Velikov wrote: > On 2 February 2017 at 02:33, Ilia Mirkin wrote: >> The intent of the libdrm_driver version limits has always been to not >> burden the "other" drivers with updating their libdrm unless really >>

[Mesa-dev] [Bug 99631] segfault with OSVRTrackerView and openscenegraph git master

https://bugs.freedesktop.org/show_bug.cgi?id=99631 Ilia Mirkin changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH v2 2/2] anv/blorp: Disable resolves for transparent black clears

On Thu, Feb 2, 2017 at 3:28 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 08:15:30AM -0800, Nanley Chery wrote: > > Polite ping. Pong Reviewed-by: Jason Ekstrand This is a bit on the hackish side but I think I'm ok with it given how common of

[Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

From: Dave Airlie These regressed and caused doom to stop loading. Fixes: 03724af26 radv/ac: Implement Float64 load/store var. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

On Thu, Feb 2, 2017 at 3:49 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:38:45PM -0800, Jason Ekstrand wrote: > > Perf numbers in the commit message would be nice > > > > How's the following? > >Reclaims about 1.95% FPS for Dota 2 on some configurations. >

[Mesa-dev] [PATCH] radeon/ac: move common llvm build functions to a separate file.

From: Dave Airlie Suggested by Marek. Signed-off-by: Dave Airlie --- src/amd/Makefile.sources | 2 + src/amd/common/ac_llvm_build.c| 752 ++ src/amd/common/ac_llvm_build.h

Re: [Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

On 02/02/2017 10:05 PM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > Although come to think of it, perhaps this *would* be better as > > if (!legal_getteximage_target(ctx, texObj->Target, true)) { >_mesa_error(ctx, GL_INVALID_OPERATION, >

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

On Thu, Feb 02, 2017 at 01:38:45PM -0800, Jason Ekstrand wrote: > Perf numbers in the commit message would be nice > How's the following? Reclaims about 1.95% FPS for Dota 2 on some configurations. > Reviewed-by: Jason Ekstrand Thanks! > > On Thu, Feb 2, 2017 at

Re: [Mesa-dev] [PATCH v2 2/2] anv/blorp: Disable resolves for transparent black clears

On Thu, Feb 02, 2017 at 08:15:30AM -0800, Nanley Chery wrote: Polite ping. > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_blorp.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_blorp.c

[Mesa-dev] X.Org Foundation Membership Renewal

On January 19th all xorg members were expired as part of the regular process to remove inactive members. If you would still like to be a member of the X.Org Foundation, please renew your membership. To renew or to become a first time member, go to https://members.x.org/ . For renewals, log in

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 03:10:21PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > > wrote:

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > wrote: > > > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: >

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > > On Thu,

Re: [Mesa-dev] [PATCH 6/7] nir: Prehash in instr_set to avoid unnecessary hashing

On Thu, Feb 2, 2017 at 12:57 PM, Thomas Helland wrote: > This should prove benefitial in the common case of inserting > and not rewriting anything. > --- > src/compiler/nir/nir_instr_set.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

On 02.02.2017 19:46, Marek Olšák wrote: From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game developer. Cc: 17.0 We're really being pushed towards bindless_texture :) Reviewed-by:

Re: [Mesa-dev] [PATCH 4/7] glsl: Prehash to avoid hashing two times when inserting

2017-02-02 21:57 GMT+01:00 Thomas Helland : > --- > src/compiler/glsl/opt_constant_variable.cpp | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/glsl/opt_constant_variable.cpp > b/src/compiler/glsl/opt_constant_variable.cpp >

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery > wrote: > >

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > > This

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

Perf numbers in the commit message would be nice Reviewed-by: Jason Ekstrand On Thu, Feb 2, 2017 at 8:15 AM, Nanley Chery wrote: > Compressing a render target and decompressing it in the same > single-subpass render pass may waste bandwidth. While

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > >

[Mesa-dev] [PATCH v2 2/2] anv: Implement the Sky Lake stencil PMA optimization

This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 157 -

[Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped the framerate on the demo by 25-30%. Enabling the PMA fix brought it back up to

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #6 from Bruce Cherniak --- Patch has been generated: https://patchwork.freedesktop.org/patch/136674/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

dEQP-EGL.functional.create_context.no_config tries to create a context with no config, then immediately destroys it. The drawbuffer is never set up, so we can't dereference it asking if it's double buffered, or we'll crash on a null pointer dereference. Just bail early. Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

Reviewed-by: Ilia Mirkin Although come to think of it, perhaps this *would* be better as if (!legal_getteximage_target(ctx, texObj->Target, true)) { _mesa_error(ctx, GL_INVALID_OPERATION, "%s(invalid texture)", caller); return; } or something. [No

[Mesa-dev] [Bug 99618] AVX Intrinsics Run in GUI thread only

https://bugs.freedesktop.org/show_bug.cgi?id=99618 Bruce Cherniak changed: What|Removed |Added Status|NEW |ASSIGNED ---

[Mesa-dev] [PATCH 7/7] glsl: Prehash in refcount hash table

_mesa_hash_table_search is one of our hottest function according to perf. Callgrind shows the refcounting as one of the major users of the searching functions. We can reduce the pain by prehashing, so that we avoid hash two times when inserting in the table. On a short shader-db run (with

[Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of the PDF states: "An INVALID_OPERATION error is generated if texture is the name of a buffer or multisample texture." This is currently not being checked and e.g a multisample texture image can be passed down to the

[Mesa-dev] [PATCH 3/7] glsl: Prehash to avoid computing the hash twice

--- src/compiler/glsl/opt_copy_propagation_elements.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_copy_propagation_elements.cpp b/src/compiler/glsl/opt_copy_propagation_elements.cpp index 9f79fa9202..d318417f6c 100644 ---

[Mesa-dev] [PATCH 6/7] nir: Prehash in instr_set to avoid unnecessary hashing

This should prove benefitial in the common case of inserting and not rewriting anything. --- src/compiler/nir/nir_instr_set.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_instr_set.c b/src/compiler/nir/nir_instr_set.c index

[Mesa-dev] [PATCH 1/7] mesa: Avoid unnecessary string hashing in symbol table

This is one of our largest users of hash_table_insert. This causes some code duplication and a parameter to pass in, so might not be worth it. --- src/mesa/program/symbol_table.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 2/7] util: Avoid computing hash twice in string_to_uint_map

This is not a hot path, but when we have the functionality we should take advantage of it. --- src/util/string_to_uint_map.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/string_to_uint_map.h b/src/util/string_to_uint_map.h index e0533ec6ea..3248696e88

[Mesa-dev] [PATCH 5/7] glsl: Prehash in constant propagation

--- src/compiler/glsl/opt_constant_propagation.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/glsl/opt_constant_propagation.cpp index 4039512097..553de9c803 100644 ---

[Mesa-dev] [PATCH 0/7] Prehash all the things

This series converts multiple users of the hash table to reuse the hash when searching, and then inserting an element if the search did not find an entry. Since we have the functionality we should take advantage of it to lower the number of calls to the hashing functions. I'm not quite sold on the

[Mesa-dev] [PATCH 4/7] glsl: Prehash to avoid hashing two times when inserting

--- src/compiler/glsl/opt_constant_variable.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_constant_variable.cpp b/src/compiler/glsl/opt_constant_variable.cpp index 1c06ffe675..a07d64067b 100644 ---

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Thu, Feb 02, 2017 at 12:28:02PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 11:09 AM, Nanley Chery wrote: > > > On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl_surface_state.c | 32

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 +

Re: [Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

Reviewed-by: Samuel Pitoiset This should also fix the glActiveTexture() errors with The Wither 3. On 02/02/2017 07:46 PM, Marek Olšák wrote: From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game

Re: [Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

On 02/02/2017 09:24 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 2:50 PM, Eduardo Lima Mitev wrote: >> This is currently not being checked and e.g a multisample texture image is >> passed >> down to the driver hook. On i965, it is crashing the driver with an >> assertion:

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

I followed up with a v2 that includes the bugzilla reference. Good point, I’ll look into following up with a patch to remove Clip(). Thanks for the quick review. > On Feb 2, 2017, at 2:26 PM, Ilia Mirkin wrote: > > Reviewed-by: Ilia Mirkin > > I

[Mesa-dev] [PATCH v2] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

v2: includes bugzilla reference, same code change Clipper::ClipScalar() is dead code and should be removed. It is causing an error with gcc-7 because it references a now defunct member. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99633 CC: "13.0 17.0"

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

btw, where exactly is it crashing? I grabbed the WebKitForWayland tree.. if I'm looking at the right thing, the only place where it should try to create a pbuffer is in Source/WebCore/platform/graphics/egl/GLContextEGL.cpp and that looks like it should only be a fallback after

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 +

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Thu, Feb 2, 2017 at 11:09 AM, Nanley Chery wrote: > On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_surface_state.c | 32 > > 1 file changed, 32 insertions(+) > > > > diff --git

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

Reviewed-by: Ilia Mirkin I got confused by this code as well when I was trying to understand the clipper. I think the Clip() function can go too now in the .cpp file (as well as the fwd decl in the header)? On Thu, Feb 2, 2017 at 3:15 PM, Bruce Cherniak

Re: [Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

On Thu, Feb 2, 2017 at 2:50 PM, Eduardo Lima Mitev wrote: > This is currently not being checked and e.g a multisample texture image is > passed > down to the driver hook. On i965, it is crashing the driver with an assertion: > > intel_mipmap_tree.c:3125: intel_miptree_map:

[Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

Clipper::ClipScalar() is dead code and should be removed. It is causing an error with gcc-7 because it references a now defunct member. CC: "13.0 17.0" --- src/gallium/drivers/swr/rasterizer/core/clip.h | 39 -- 1 file changed, 39

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On 3 Feb. 2017 03:11, "Chad Versace" wrote: On Thu 02 Feb 2017, Chad Versace wrote: > On Thu 02 Feb 2017, Dave Airlie wrote: > > From: Dave Airlie > > > > Although this might come from somewhere else require it explicitly. > > > > Signed-off-by:

[Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

This is currently not being checked and e.g a multisample texture image is passed down to the driver hook. On i965, it is crashing the driver with an assertion: intel_mipmap_tree.c:3125: intel_miptree_map: Assertion `mt->num_samples <= 1' failed. Similar check exists for GetTextureSubImage.

Re: [Mesa-dev] [PATCH] winsys/amdgpu: avoid potential segfault in amdgpu_bo_map()

Cc stable? Reviewed-by: Marek Olšák Marek On Thu, Feb 2, 2017 at 6:40 PM, Samuel Pitoiset wrote: > cs can be NULL when it comes from r600_buffer_map_sync_with_rings() > to avoid doing the same checks. It was checked for write mappings > but not

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index b735478..c7b220b

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:58 PM, Eduardo Lima Mitev wrote: > On 02/02/2017 07:38 PM, Ilia Mirkin wrote: >> On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: >>> On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: OpenGL 4.5

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On 02/02/2017 07:38 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: >> On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: >>> OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of >>> the PDF states: >>>

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 01, 2017 at 05:43:53PM -0800, Jason Ekstrand wrote: > In order to get good performance numbers for this, I had to hack up the > driver to whack wm_prog_data::uses_kill to true to emulate a discard and > used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped > the

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > machine by about 2-3%. > --- > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/gen8_cmd_buffer.c | 155 > - >

[Mesa-dev] [PATCH 2/3] main/fbobject: implement new 4.5 pnames for GetFramebufferParameter

4.5 added new pnames allowed for GetFramebufferParameter, and GetNamedFramebufferParameter. From OpenGL 4.5 spec, section 9.2.3 "Framebuffer Object Queries" (quoting the paragraph with only the new pnames, not all the supported): "pname may also be one of DOUBLEBUFFER,

[Mesa-dev] [PATCH 1/3] main/framebuffer: refactor _mesa_get_color_read_format/type

Current implementation returns the value for the currently bound read framebuffer. GetNamedFramebufferParameteriv allows to get it for any given framebuffer. GetFramebufferParameteriv would be also interested on that method It was refactored by allowing to pass a given framebuffer. If NULL is

[Mesa-dev] [PATCH 3/3] main/fboject: default_framebuffer allowed for GetFramebufferParameter

Before 4.5, the default framebuffer was not allowed for GetFramebufferParameter, so it should return INVALID_OPERATION for any call using the default framebuffer. 4.5 included new pnames, and some of them are allowed for the default framebuffer. For the rest, INVALID_OPERATION. From OpenGL 4.5

Re: [Mesa-dev] [PATCH] glsl: Allow compatibility shaders with MESA_GL_VERSION_OVERRIDE=...

Tested-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game developer. Cc: 17.0 --- src/gallium/drivers/radeonsi/si_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: >> OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of >> the PDF states: >> >> "An INVALID_OPERATION error is generated if

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: > OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of > the PDF states: > > "An INVALID_OPERATION error is generated if texture is the name of a > buffer > or multisample texture." > >

[Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of the PDF states: "An INVALID_OPERATION error is generated if texture is the name of a buffer or multisample texture." Currently, this is not being checked and the multisample texture image is passed down to the driver

Re: [Mesa-dev] [PATCH] intel/isl: Add a better comment for format_supports_ccs_e

On Thu, Feb 2, 2017 at 9:52 AM, Jason Ekstrand wrote: > Cc: Anuj Phogat > --- > src/intel/isl/isl_format.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c > index 1cd941c..0fdc716

Re: [Mesa-dev] [PATCH] intel/isl: Add a better comment for format_supports_ccs_e

On Thu 02 Feb 2017, Jason Ekstrand wrote: > Cc: Anuj Phogat > --- > src/intel/isl/isl_format.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c > index 1cd941c..0fdc716 100644 > ---

[Mesa-dev] [PATCH v3 2/5] intel/isl: Add a format_supports_ccs_d helper

Nothing uses this yet but it serves as a nice bit of documentation that's relatively easy to find. Reviewed-by: Samuel Iglesias Gonsálvez --- src/intel/isl/isl.h| 2 ++ src/intel/isl/isl_format.c | 22 ++ 2 files changed, 24 insertions(+) diff

Re: [Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

On Wed, Feb 01, 2017 at 02:40:37PM -0800, Jason Ekstrand wrote: > The term "lossless compression" could potentially mean multisample > color compression, single-sample color compression or HiZ because they > are all lossless. The term CCS_E, however, has a very precise meaning; > in ISL and is

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:13 AM, Chad Versace > wrote: > > > On Thu 02 Feb 2017, Anuj Phogat wrote: > > > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand > > wrote: > > > > On Wed, Feb 1, 2017 at 4:07 PM,

Re: [Mesa-dev] [PATCH 5/5] anv: Remove the finishme for CCS_E with storage images

On Wed 01 Feb 2017, Jason Ekstrand wrote: > The data port can't handle CCS at all so replace the finishme with > better comments. > --- > src/intel/vulkan/anv_image.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) Patch is Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH 4/5] intel/isl: Assert that we don't use CCS for storage images

On Wed 01 Feb 2017, Jason Ekstrand wrote: > I enabled CCS for storage images in the Vulkan driver and ran it through > the CTS. It didn't result in any hangs but it demonstrated that the data > port cannot handle CCS. > --- > src/intel/isl/isl_surface_state.c | 6 ++ > 1 file changed, 6

Re: [Mesa-dev] [PATCH 3/5] intel/isl: Add a formats_are_ccs_e_compatible helper

On Wed 01 Feb 2017, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 6 ++ > src/intel/isl/isl.h | 4 > src/intel/isl/isl_format.c | 31 +++ > 3 files changed, 41 insertions(+) > > diff --git a/src/intel/blorp/blorp_blit.c

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu, Feb 2, 2017 at 10:13 AM, Chad Versace wrote: > On Thu 02 Feb 2017, Anuj Phogat wrote: > > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand > wrote: > > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat > wrote: > > >> > >

Re: [Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

On Wed 01 Feb 2017, Jason Ekstrand wrote: > The term "lossless compression" could potentially mean multisample > color compression, single-sample color compression or HiZ because they > are all lossless. The term CCS_E, however, has a very precise meaning; > in ISL and is only used to refer to

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Anuj Phogat wrote: > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand wrote: > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat wrote: > >> > >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand > >> wrote: > >> >

Re: [Mesa-dev] [PATCH 5/5] anv: Remove the finishme for CCS_E with storage images

On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand wrote: > The data port can't handle CCS at all so replace the finishme with > better comments. > --- > src/intel/vulkan/anv_image.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] vbo: process buffer binding state changes on draw when recording

Looks OK to me too. Reviewed-by: Brian Paul On 02/02/2017 01:42 AM, Marek Olšák wrote: Reviewed-by: Marek Olšák > On Feb 1, 2017 10:11 PM, "Ilia Mirkin" > wrote: The

[Mesa-dev] [PATCH v2 2/5] intel/isl: Add a formats_are_ccs_e_compatible helper

Reviewed-by: Samuel Iglesias Gonsálvez --- src/intel/blorp/blorp_blit.c | 6 ++ src/intel/isl/isl.h | 4 src/intel/isl/isl_format.c | 31 +++ 3 files changed, 41 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #5 from Bruce Cherniak --- Then I'm going to have another cup of coffee in hopes that it improves my grammar. :-/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [PATCH] intel/isl: Add a better comment for format_supports_ccs_e

Cc: Anuj Phogat --- src/intel/isl/isl_format.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c index 1cd941c..0fdc716 100644 --- a/src/intel/isl/isl_format.c +++ b/src/intel/isl/isl_format.c @@ -455,6

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

https://bugs.freedesktop.org/show_bug.cgi?id=99633 Bruce Cherniak changed: What|Removed |Added Status|NEW |ASSIGNED --

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #4 from Bruce Cherniak --- I'm create a gcc 7 environment to see if there are other problems behind this. Then, I'll go ahead and remove the offending code and try to fix any other problems I find. -- You

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 1, 2017 at 5:44 PM Jason Ekstrand wrote: > In order to get good performance numbers for this, I had to hack up the > driver to whack wm_prog_data::uses_kill to true to emulate a discard and > used the Sascha "shadowmapping" demo. Setting uses_kill to true

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu, Feb 2, 2017 at 9:31 AM, Anuj Phogat wrote: > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand > wrote: > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat > wrote: > >> > >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand

[Mesa-dev] [PATCH] winsys/amdgpu: avoid potential segfault in amdgpu_bo_map()

cs can be NULL when it comes from r600_buffer_map_sync_with_rings() to avoid doing the same checks. It was checked for write mappings but not for read mappings. Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 17 ++--- 1 file

Re: [Mesa-dev] [PATCH 1/3] ilo: EOL unplumb unmaintained gallium drv from winsys

All three are Acked-by:Chia-I Wu On Thu, Feb 2, 2017 at 12:15 AM, Edward O'Callaghan wrote: > This is no longer actively maintained and is just > accumulating bitrot. > > Signed-off-by: Edward O'Callaghan > --- >

  1   2   >