Re: [Mesa-dev] [PATCH 1/4] radv: change base aligmment for allocated memory.

2017-02-13 Thread Bas Nieuwenhuizen
Series is: Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 14, 2017, at 07:10, Dave Airlie wrote: > From: Dave Airlie > > On some CIK (Hawaii) this needs to be at least 64k, I'm not 100% sure > it doesn't need to be 128k. > > This was causing fast

Re: [Mesa-dev] [PATCH] radv: adopt some init config workarounds from radeonsi.

2017-02-13 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/14/2017 05:25 PM, Dave Airlie wrote: > From: Dave Airlie > > Just one bonaire fix. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/si_cmd_buffer.c | 11 +-- > 1 file

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-13 Thread Michel Dänzer
On 14/02/17 04:50 AM, Matt Arsenault wrote: >> On Feb 6, 2017, at 19:42, Timothy Arceri > > wrote: >> >> This series does not include the patch that adds cache support >> to the radeonsi backend, the main reason for this is that llvm >>

Re: [Mesa-dev] radv cik fixes

2017-02-13 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/14/2017 05:10 PM, Dave Airlie wrote: > Hey, > > This is a bunch of CIK fixes I found thanks to Lyude for remote > access to a test machine. > > The main one is 1/4, it changes the memory base alignment > so that

Re: [Mesa-dev] [PATCH 2/3] Added support for disassembling SENDS and SENDSC.

2017-02-13 Thread Pohjolainen, Topi
On Mon, Feb 13, 2017 at 01:25:57PM +0200, Lonnberg, Toni wrote: > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 109 > +++-- > src/mesa/drivers/dri/i965/brw_inst.h | 31 +- > 2 files changed, 135 insertions(+), 5 deletions(-) > > diff --git

[Mesa-dev] [PATCH] radv: adopt some init config workarounds from radeonsi.

2017-02-13 Thread Dave Airlie
From: Dave Airlie Just one bonaire fix. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #8 from Dave Airlie --- https://patchwork.freedesktop.org/series/19593/ is the series. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #7 from Dave Airlie --- I've posted some patches to the mesa development list that should hopefully fix the VM faults. Please test them. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [PATCH 4/4] radv: re-enable init gfx state on CIK.

2017-02-13 Thread Dave Airlie
From: Dave Airlie Once the color alignment was fixed this works fine now. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 3/4] radv: align the initial state command buffer.

2017-02-13 Thread Dave Airlie
From: Dave Airlie This just adds the padding to align this to an 8 dword boundary. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/amd/vulkan/si_cmd_buffer.c

[Mesa-dev] [PATCH 1/4] radv: change base aligmment for allocated memory.

2017-02-13 Thread Dave Airlie
From: Dave Airlie On some CIK (Hawaii) this needs to be at least 64k, I'm not 100% sure it doesn't need to be 128k. This was causing fast clear eliminate to overwrite the previous buffer, which since my gfx init code, was the indirect buffer. Fixes:

[Mesa-dev] radv cik fixes

2017-02-13 Thread Dave Airlie
Hey, This is a bunch of CIK fixes I found thanks to Lyude for remote access to a test machine. The main one is 1/4, it changes the memory base alignment so that color buffers are aligned properly. Dave. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2/4] radv: fix cik macroModeIndex.

2017-02-13 Thread Dave Airlie
From: Dave Airlie This just a CIK fix ported from radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 7/7] anv: Implement the Skylake stencil PMA optimization

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 6:13 PM, Jason Ekstrand wrote: > On Mon, Feb 13, 2017 at 5:00 PM, Nanley Chery > wrote: > >> On Fri, Feb 10, 2017 at 11:02:21AM -0800, Jason Ekstrand wrote: >> > This improves the performance of Dota 2 on my Sky Lake Skull

Re: [Mesa-dev] [PATCH 1/3] gallivm: Improve debug output

2017-02-13 Thread Roland Scheidegger
Am 10.02.2017 um 23:59 schrieb Ben Crocker: > Improve debug output from gallivm_compile_module and > lp_build_create_jit_compiler_for_module, printing the > -mcpu and -mattr options passed to LLC. > > Signed-off-by: Ben Crocker > Cc: 12.0 13.0 17.0

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

2017-02-13 Thread Michel Dänzer
On 14/02/17 09:28 AM, Samuel Pitoiset wrote: > On 02/13/2017 11:43 PM, Marek Olšák wrote: >> On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák wrote: >>> On Mon, Feb 13, 2017 at 5:04 PM, Samuel Pitoiset >>> wrote: On 02/13/2017 04:51 PM, Marek Olšák

Re: [Mesa-dev] [PATCH 1/2] i965/ps: Use ForceThreadDispatchEnable instead of AccessUAV.

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 6:35 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > The AccessUAV bit is not quite what we want because it's more about > > coherency between storage operations than it is about dispatch. Also, > > the

Re: [Mesa-dev] [PATCH 1/2] i965/ps: Use ForceThreadDispatchEnable instead of AccessUAV.

2017-02-13 Thread Francisco Jerez
Jason Ekstrand writes: > The AccessUAV bit is not quite what we want because it's more about > coherency between storage operations than it is about dispatch. Also, > the 3DSTATE_PS_EXTRA::PixelShaderHasUAV bit seems to cause hangs on > Broadwell for unknown reasons so

Re: [Mesa-dev] [PATCH v2 7/7] anv: Implement the Skylake stencil PMA optimization

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 5:00 PM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 11:02:21AM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > > > This patch looks good. Could we compare our

[Mesa-dev] [PATCH] glsl: Fix missing-braces warning.

2017-02-13 Thread Vinson Lee
CXXglsl/ast_to_hir.lo glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)': glsl/ast_to_hir.cpp:4846:42: warning: missing braces around initializer for 'unsigned int [16]' [-Wmissing-braces] Signed-off-by: Vinson Lee

[Mesa-dev] [PATCH 2/2] anv/pipeline: Use ForceThreadDispatchEnable instead of AccessUAV.

2017-02-13 Thread Jason Ekstrand
The AccessUAV bit is not quite what we want because it's more about coherency between storage operations than it is about dispatch. Also, the 3DSTATE_PS_EXTRA::PixelShaderHasUAV bit seems to cause hangs on Broadwell for unknown reasons so it's best to just leave it off. The

[Mesa-dev] [PATCH 1/2] i965/ps: Use ForceThreadDispatchEnable instead of AccessUAV.

2017-02-13 Thread Jason Ekstrand
The AccessUAV bit is not quite what we want because it's more about coherency between storage operations than it is about dispatch. Also, the 3DSTATE_PS_EXTRA::PixelShaderHasUAV bit seems to cause hangs on Broadwell for unknown reasons so it's best to just leave it off. The

[Mesa-dev] [PATCH 1/3] configure.ac: bump LIBDRM_RADEON requirement to 2.4.71

2017-02-13 Thread Emil Velikov
Such that we can remove all the local fall-back definitions and use the official UABI ones. Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f001743ea2..ce22b374bf 100644

[Mesa-dev] [PATCH 2/3] winsys/radeon: remove fall-back defines

2017-02-13 Thread Emil Velikov
Provided by libdrm as of last commit. Signed-off-by: Emil Velikov --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 12 src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 17 - src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 18

[Mesa-dev] [PATCH 3/3] r100: use correct libdrm_radeon macro

2017-02-13 Thread Emil Velikov
Remove local definition of RADEON_INFO_TILE_CONFIG and use the correct macro provided by libdrm_radeon RADEON_INFO_TILING_CONFIG. Latter was present as of libdrm 2.4.22, sirca 2010. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/radeon/radeon_screen.c | 8

Re: [Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-02-13 Thread Emil Velikov
On 13 February 2017 at 22:08, Samuel Pitoiset wrote: > Only the Radeon kernel driver exposed the GPU temperature and > the shader/memory clocks, this implements the same functionality > for the AMDGPU kernel driver. > > These queries will return 0 if the DRM version is

Re: [Mesa-dev] [PATCH v2 7/7] anv: Implement the Skylake stencil PMA optimization

2017-02-13 Thread Nanley Chery
On Fri, Feb 10, 2017 at 11:02:21AM -0800, Jason Ekstrand wrote: > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > machine by about 2-3%. > This patch looks good. Could we compare our setup and testing in the office? I can't reproduce these numbers. -Nanley > Reviewed-by:

[Mesa-dev] [PATCH 32/32] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-13 Thread Timothy Arceri
--- src/gallium/drivers/r600/r600_pipe.c | 10 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_pipe.c| 11 +++ src/gallium/include/pipe/p_screen.h | 3 +++

[Mesa-dev] [PATCH 29/32] util/disk_cache: check cache exists before calling munmap()

2017-02-13 Thread Timothy Arceri
--- src/util/disk_cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 10b9d81..8eccf72 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -383,7 +383,8 @@ disk_cache_create(const char *gpu_name, const

[Mesa-dev] [PATCH 30/32] util/radv/anv: move *_get_function_timestamp() to utils

2017-02-13 Thread Timothy Arceri
V2: The functions we are now sharing used different return values update the callers to reflect the new common api. --- src/amd/vulkan/radv_device.c | 22 +++--- src/intel/vulkan/anv_device.c | 20 ++-- src/util/disk_cache.h | 17 + 3 files

[Mesa-dev] [PATCH 25/32] st/mesa/glsl: build string of dri options and use as input to building sha for shaders

2017-02-13 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 6 src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 2 ++ src/mesa/drivers/dri/common/xmlconfig.h | 52 + src/mesa/main/mtypes.h | 3 ++

[Mesa-dev] [PATCH 26/32] mesa: remove cache creation from _mesa_initialize_context()

2017-02-13 Thread Timothy Arceri
We will change the way we create the cache directory in the following patches. --- src/mesa/main/context.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 16e25a9..bbc13a9 100644 --- a/src/mesa/main/context.c +++

[Mesa-dev] [PATCH 27/32] util/disk_cache: allow drivers to pass a directory structure

2017-02-13 Thread Timothy Arceri
In order to avoid costly fallback recompiles when cache items are created with an old version of Mesa or for a different gpu on the same system we want to create directories that look like this: ./{TIMESTAMP}_{LLVM_TIMESTAMP}/{GPU_ID} Note: The disk cache util will take a single timestamp

[Mesa-dev] [PATCH 24/32] glsl: reserve parameter storage on cache restore

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Since we know how big the list will be we can allocate the storage upfront. --- src/compiler/glsl/shader_cache.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 31/32] st/mesa: implement a tgsi on-disk shader cache

2017-02-13 Thread Timothy Arceri
Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 222 + src/mesa/state_tracker/st_program.c| 133 - 2 files changed, 350 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 28/32] util/disk_cache: add support for removing old versions of the cache

2017-02-13 Thread Timothy Arceri
--- src/util/disk_cache.c | 37 + 1 file changed, 37 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 34d4a42..10b9d81 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -24,6 +24,7 @@ #ifdef ENABLE_SHADER_CACHE

[Mesa-dev] [PATCH 22/32] glsl: disable on disk shader cache when running as another user

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri --- src/util/disk_cache.c | 4 1 file changed, 4 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 047a016..f26b81d 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -142,6 +142,10 @@

[Mesa-dev] [PATCH 18/32] glsl: don't reference shader prog data during cache fallback

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri We already have a reference. --- src/compiler/glsl/linker.cpp | 3 ++- src/mesa/main/shaderobj.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index

[Mesa-dev] [PATCH 21/32] glsl: don't reprocess or clear UBOs on cache fallback

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/linker.cpp | 62 +++- src/mesa/main/shaderobj.c| 16 +++- 2 files changed, 42 insertions(+), 36 deletions(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 20/32] glsl: skip more uniform initialisation when doing fallback linking

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri We already pull these values from the metadata cache so no need to recreate them. --- src/compiler/glsl/linker.cpp | 20 src/mesa/main/shaderobj.c| 8 +--- 2 files changed, 17 insertions(+), 11 deletions(-) diff

[Mesa-dev] [PATCH 16/32] glsl: add api and glsl version to hash generation for shaders

2017-02-13 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 2fb734f..3e8948f 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@ -1300,6

[Mesa-dev] [PATCH 23/32] glsl: don't try to load/store buffer object values in the cache

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Also add an assert to catch buffer overflows. --- src/compiler/glsl/shader_cache.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 15/32] glsl: cache uniform values

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri These may be lowered constant arrays or uniform values that we set before linking so we need to cache the actual uniform values. Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 33

[Mesa-dev] [PATCH 19/32] glsl: don't lose uniform values when falling back to full compile

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Here we skip the recreation of uniform storage if we are relinking after a cache miss. This is improtant because uniform values may have already been set by the application and we don't want to reset them. ---

[Mesa-dev] [PATCH 17/32] mesa/glsl: add cache_fallback flag to gl_shader_program_data

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri This will allow us to skip certain things when falling back to a full recompile on a cache miss such as avoiding reinitialising uniforms. In this change we use it to avoid reading the program metadata from the cache and skipping linking during

[Mesa-dev] [PATCH 14/32] glsl: make uniform values helper available for use elsewhere

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp

[Mesa-dev] [PATCH 13/32] glsl: cache some more image metadata

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index

[Mesa-dev] [PATCH 09/32] glsl: add support for caching subroutines

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 107 + 1 file changed, 107 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 12/32] glsl: add support for caching atomic buffers

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 11/32] glsl: add shader cache support for buffer blocks

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 163 + 1 file changed, 163 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 10/32] glsl: store subroutine remap table in shader cache

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri V2: use new helpers to store/restore table entries. --- src/compiler/glsl/shader_cache.cpp | 48 +- 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 08/32] glsl: add support for caching shaders with xfb qualifiers

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/linker.cpp | 14 -

[Mesa-dev] [PATCH 07/32] glsl: add shader cache support for samplers

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/shader_cache.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index

[Mesa-dev] [PATCH 04/32] glsl: Serialize three additional hash tables with program metadata

2017-02-13 Thread Timothy Arceri
From: Carl Worth The three additional tables are AttributeBindings, FragDataBindings, and FragDataIndexBindings. The first table (AttributeBindings) was identified as missing by trying to test the shader cache with a program that called glGetAttribLocation. Many thanks to

[Mesa-dev] [PATCH 03/32] glsl: use correct shader source in case of cache fallback

2017-02-13 Thread Timothy Arceri
The scenario is: glShaderSource glCompileShader <-- deferred due to cache hit of shader glShaderSource <-- with new source code glAttachShader glLinkProgram <-- no cache hit for program At this point we need to compile the original source when we fallback. ---

[Mesa-dev] [PATCH 06/32] glsl: add basic support for resource list to shader cache

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri This initially adds support for simple uniforms and varyings. --- src/compiler/glsl/shader_cache.cpp | 121 + 1 file changed, 121 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 01/32] glsl: add initial implementation of shader cache

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri This uses disk_cache.c to write out a serialization of various state that's required in order to successfully load and use a binary written out by a drivers backend, this state is referred to as "metadata" throughout the implementation. This

[Mesa-dev] [PATCH 05/32] glsl: fix uniform remap table cache when explicit locations used

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri V2: don't store pointers use an enum instead to flag what should be restored. Also do the work in a helper that we will later use for the subroutine remap table. --- src/compiler/glsl/shader_cache.cpp | 56 +-

[Mesa-dev] V2 GLSL IR & TGSI on-disk shader cache

2017-02-13 Thread Timothy Arceri
Changes in V2: - no longer mess around storing/restoring any pointers - implemented support for compute shaders - dropped some patches only needed by i965 for now - add fallback support for shader source that is changed after its compiledi (piglit test on the list) - simplify cache enable for

[Mesa-dev] [PATCH 02/32] glsl: make use of on disk shader cache

2017-02-13 Thread Timothy Arceri
From: Timothy Arceri The hash key for glsl metadata is a hash of the hashes of each GLSL source string. This commit uses the put_key/get_key support in the cache put the SHA-1 hash of the source string for each successfully compiled shader into the cache. This

Re: [Mesa-dev] [PATCH] softpipe: implement clear_texture

2017-02-13 Thread Roland Scheidegger
Am 13.02.2017 um 16:20 schrieb Lars Hamre: > Implements the ARB_clear_texture extension for softpipe. > Passes all corresponding piglit tests. > > Signed-off-by: Lars Hamre > > --- > > NOTE: someone with access will need to commit this post > review process > >

Re: [Mesa-dev] [PATCH v3 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-13 Thread Nanley Chery
On Mon, Feb 13, 2017 at 04:14:40PM -0800, Jason Ekstrand wrote: > It's a bit hard to measure because it almost gets lost in the noise, > but this seemed to help Dota 2 by a percent or two on my Broadwell > GT3e desktop. > > Reviewed-by: Lionel Landwerlin > --- >

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

2017-02-13 Thread Samuel Pitoiset
On 02/13/2017 11:43 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 5:04 PM, Samuel Pitoiset wrote: On 02/13/2017 04:51 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 11:57 AM, Samuel

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] radv: switch to flushing according to stage mask.

2017-02-13 Thread Dave Airlie
From: Dave Airlie This uses the stage mask helper for pipeline flushes. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH v3 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-13 Thread Jason Ekstrand
It's a bit hard to measure because it almost gets lost in the noise, but this seemed to help Dota 2 by a percent or two on my Broadwell GT3e desktop. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/genX_pipeline.c | 175 +++

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use common sendmsg emission function.

2017-02-13 Thread Marek Olšák
For 1 & 3: Reviewed-by: Marek Olšák Marek On Mon, Feb 13, 2017 at 11:15 PM, Dave Airlie wrote: > From: Dave Airlie > > This just ports radeonsi to use the sendmsg common code. > > Signed-off-by: Dave Airlie >

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

2017-02-13 Thread Marek Olšák
On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák wrote: > On Mon, Feb 13, 2017 at 5:04 PM, Samuel Pitoiset > wrote: >> >> >> On 02/13/2017 04:51 PM, Marek Olšák wrote: >>> >>> On Mon, Feb 13, 2017 at 11:57 AM, Samuel Pitoiset >>>

Re: [Mesa-dev] [PATCH 2/3] radv/ac: use sendmsg emission interface.

2017-02-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Feb 13, 2017, at 23:15, Dave Airlie wrote: > From: Dave Airlie > > This uses the common code to emit the correct intrinsic. > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH 3/3] radeonsi: use common sendmsg emission function.

2017-02-13 Thread Dave Airlie
From: Dave Airlie This just ports radeonsi to use the sendmsg common code. Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_shader.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] radv/ac: use sendmsg emission interface.

2017-02-13 Thread Dave Airlie
From: Dave Airlie This uses the common code to emit the correct intrinsic. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] radeon/ac/llvm: add support for sendmsg emission

2017-02-13 Thread Dave Airlie
From: Dave Airlie This lets us use the new intrinsic on the correct version of llvm. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 13 + src/amd/common/ac_llvm_build.h | 12 2 files changed, 25 insertions(+)

[Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-02-13 Thread Samuel Pitoiset
Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements the same functionality for the AMDGPU kernel driver. These queries will return 0 if the DRM version is less than 3.10, I don't explicitely check the version here because the query codepath is

[Mesa-dev] [PATCH 2/2] mesa: remove tabs in dri xmlconfig.c

2017-02-13 Thread Timothy Arceri
--- src/mesa/drivers/dri/common/xmlconfig.c | 724 1 file changed, 362 insertions(+), 362 deletions(-) diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c index 4c1b345..d464937 100644 ---

[Mesa-dev] [PATCH 1/2] mesa: style fixes for dri xmlconfig.c

2017-02-13 Thread Timothy Arceri
--- src/mesa/drivers/dri/common/xmlconfig.c | 131 +++- 1 file changed, 94 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c index a8f7c9b..4c1b345 100644 ---

Re: [Mesa-dev] [PATCH 0/2] drm/amdgpu: expose temp and shader/memory clocks

2017-02-13 Thread Samuel Pitoiset
Sorry wrong list, please ignore. On 02/13/2017 11:00 PM, Samuel Pitoiset wrote: Hi, This series exposes the current GPU temperature and the current shader clock (and eventually the memory clock for non-APUs boards). This adds the same functionality as the Radeon driver. The main goal is to

[Mesa-dev] [PATCH 0/2] drm/amdgpu: expose temp and shader/memory clocks

2017-02-13 Thread Samuel Pitoiset
Hi, This series exposes the current GPU temperature and the current shader clock (and eventually the memory clock for non-APUs boards). This adds the same functionality as the Radeon driver. The main goal is to expose the info through the GALLIUM_HUD in Mesa. Alex Deucher suggested to wire-up

[Mesa-dev] [PATCH 2/2] drm/amdgpu: expose the current temperature and shader/memory clocks

2017-02-13 Thread Samuel Pitoiset
The clocks are returned in Mhz and the temperature in millidegrees. Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 27 +++ include/uapi/drm/amdgpu_drm.h |

[Mesa-dev] [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Samuel Pitoiset
Currently, only the GPU temperature, the shader clock and eventually the memory clock are implemented. The main goal is to expose this info to the userspace like Radeon. Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 +++-

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2017-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Phil Wyett changed: What|Removed |Added CC|

Re: [Mesa-dev] software implementation of vulkan for gsoc/evoc

2017-02-13 Thread Roland Scheidegger
Am 13.02.2017 um 03:17 schrieb Jacob Lifshay: > forgot to add mesa-dev when I sent. > -- Forwarded message -- > From: "Jacob Lifshay" > > Date: Feb 12, 2017 6:16 PM > Subject: Re: [Mesa-dev] software implementation of

Re: [Mesa-dev] [PATCH] mesa: lower severity for GLSL compiler warnings

2017-02-13 Thread Timothy Arceri
On 14/02/17 05:07, Matt Turner wrote: Agreed. The GL_KHR_debug spec says MEDIUM means "Severe performance warnings; GLSL or other shader compiler and linker warnings; use of currently deprecated behavior", while HIGH means "Any GL error; dangerous undefined behavior; any GLSL or ARB shader

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-13 Thread Rhys Kidd
On Mon, Feb 13, 2017 at 9:43 AM Elie Tournier wrote: > Seems good to me. > > Reviewed-by: Elie Tournier > Thanks Elie. Given we are both "new-er" Mesa contributors I might wait for one more Reviewed-by before asking for it to be merged. > On

Re: [Mesa-dev] [PATCH] util/disk_cache: fix d7b3707c612

2017-02-13 Thread Jan Vesely
On Sat, 2017-02-11 at 22:32 +1100, Timothy Arceri wrote: > I forgot to error check stat() and also I wasn't using the subdir in > is_two_character_sub_directory(). can you (mostly) swap title and description? git id is better in Fixes: tag and makes title rather non-descriptive. thanks, Jan >

Re: [Mesa-dev] [PATCH] radv/ac: use common interp code for new intrinsics

2017-02-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 13, 2017, at 20:55, Dave Airlie wrote: > From: Dave Airlie > > This uses the common fs interp code to use the new > llvm intrinsics so llvm can drop the old ones. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-13 Thread Matt Arsenault
> On Feb 6, 2017, at 19:42, Timothy Arceri wrote: > > This series does not include the patch that adds cache support > to the radeonsi backend, the main reason for this is that llvm > currently doesn't allow the version to be queried at runtime > (as far as I'm aware)

[Mesa-dev] [PATCH] radv/ac: use common interp code for new intrinsics

2017-02-13 Thread Dave Airlie
From: Dave Airlie This uses the common fs interp code to use the new llvm intrinsics so llvm can drop the old ones. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 61 +++-- 1 file changed, 41

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-13 Thread Dave Airlie
On 13 February 2017 at 19:07, Michel Dänzer wrote: > On 11/02/17 06:36 AM, gregory hainaut wrote: >> >> On GLX side, I can explain some crashes (didn't debug all neither fail) >> and I suspect there are related to the previous report. >> >> At the context creation a glthread

[Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

2017-02-13 Thread Emil Velikov
From: Emil Velikov The version tag used to nominate has bitten even experienced mesa developers. Not to mention that it deviates from the one used in the kernel leading to further confusion. Simplify things and omit it all together. Signed-off-by: Emil Velcro

[Mesa-dev] [PATCH 4/4] docs/submittingpatches.html: document the Fixes tag

2017-02-13 Thread Emil Velikov
From: Emil Velikov Provide information and an example. Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index

[Mesa-dev] [PATCH 2/4] docs/submittingpatches.html: add #backports section

2017-02-13 Thread Emil Velikov
From: Emil Velikov Provide information about merge conflicts resolution and sending backports. Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 1/4] docs/submittingpatches.html: rework the #criteria section

2017-02-13 Thread Emil Velikov
From: Emil Velikov Reword the section to focus on what is allowed, using a more brief, yet descriptive wording. Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 120 +--- 1 file

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-13 Thread Nanley Chery
On Fri, Feb 10, 2017 at 05:04:48PM -0800, Jason Ekstrand wrote: > On Fri, Feb 10, 2017 at 4:47 PM, Nanley Chery wrote: > > > On Fri, Feb 10, 2017 at 03:21:38PM -0800, Jason Ekstrand wrote: > > > On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery > >

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 11:14 AM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 09:26:52PM -0800, Jason Ekstrand wrote: > > On Fri, Feb 10, 2017 at 5:29 PM, Nanley Chery > wrote: > > > > > On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-13 Thread Nanley Chery
On Fri, Feb 10, 2017 at 09:26:52PM -0800, Jason Ekstrand wrote: > On Fri, Feb 10, 2017 at 5:29 PM, Nanley Chery wrote: > > > On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand wrote: > > > On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery > >

Re: [Mesa-dev] [PATCH] intel/isl: Add format metadata for typed reads/writes

2017-02-13 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 13/02/17 17:19, Jason Ekstrand wrote: This adds two columns to the format table as well as two helpers for determining whether or not a given format is supported for typed reads and writes. --- src/intel/isl/isl.h| 4

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-13 Thread gregory hainaut
On Mon, 13 Feb 2017 17:04:01 +0100 Marek Olšák wrote: > On Mon, Feb 13, 2017 at 4:14 PM, Gregory Hainaut > wrote: > > If I remember correctly I got something like 4K-8K fails (total is 40K > > tests) when I broke the GL1 restore dispatch function.

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 9:40 AM, Alex Smith wrote: > Hi Lionel, > > On 13 February 2017 at 17:28, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 09/02/17 16:06, Alex Smith wrote: >> >>> This allows shaders to write to storage images declared with

Re: [Mesa-dev] [PATCH] mesa: lower severity for GLSL compiler warnings

2017-02-13 Thread Matt Turner
Agreed. The GL_KHR_debug spec says MEDIUM means "Severe performance warnings; GLSL or other shader compiler and linker warnings; use of currently deprecated behavior", while HIGH means "Any GL error; dangerous undefined behavior; any GLSL or ARB shader compiler and linker errors;" Reviewed-by:

Re: [Mesa-dev] [PATCH] anv/apply_pipeline_layout: Set image.write_only to false

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 9:48 AM, Alex Smith wrote: > Hi Jason, > > On 13 February 2017 at 16:38, Jason Ekstrand wrote: > >> This makes our driver robust to changes in spirv_to_nir which would set >> this flag on the variable. Right now, our

  1   2   >