[Mesa-dev] [PATCH 2/2] anv: do not subtract the base layer to copute depth in 3DSTATE_DEPTH_BUFFER

According to the PRM description of the Depth field: "This field specifies the total number of levels for a volume texture or the number of array elements allowed to be accessed starting at the Minimum Array Element for arrayed surfaces" However, ISL defines array_len as the length of

[Mesa-dev] [PATCH 1/2] isl: document the meaning of the array_len field in isl_view

--- src/intel/isl/isl.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index c340e6a..e6e9459 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -934,6 +934,12 @@ struct isl_view { * for texturing, they are ignored. */

[Mesa-dev] [PATCH v2 6/8] nir: Add a simple int64 lowering pass

The algorithms used by this pass, especially for division, are heavily based on the work Ian Romanick did for the similar int64 lowering pass in the GLSL compiler. --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 11 ++ src/compiler/nir/nir_lower_int64.c | 284

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

> On Feb 23, 2017, at 19:44, Dave Airlie wrote: > > On 24 February 2017 at 13:36, Matt Arsenault > wrote: >> >> On Feb 23, 2017, at 19:27, Dave Airlie wrote: >> >> +static void set_unroll_metadata(struct

[Mesa-dev] [PATCH 4/4] Revert "glsl: Switch to disable-by-default for the GLSL shader cache"

This reverts commit 0f60c6616e93cba72bff4fbfedb72a753ef78e05. Piglit and all games tested so far seem to be working without issue. This change will allow wide user testing and we can decided before the next release if we need to turn it off again. Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH 1/4] compiler: style clean-ups in blob.h

--- src/compiler/glsl/blob.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/compiler/glsl/blob.h b/src/compiler/glsl/blob.h index 81b9917..21fa43d 100644 --- a/src/compiler/glsl/blob.h +++ b/src/compiler/glsl/blob.h @@ -71,81

[Mesa-dev] [PATCH 2/4] util/disk_cache: add support for detecting corrupt cache entries

--- src/util/disk_cache.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index f5e1145..2a0edca 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -31,20 +31,21 @@ #include

[Mesa-dev] [PATCH V3 3/4] radeonsi: add support for an on-disk shader cache

V2: - when loading from disk cache also binary insert into memory cache. - check that the binary loaded from disk is the correct size. If not delete the cache item and skip loading from cache. V3: - remove unrequired variable Tested-by: Michel Dänzer ---

[Mesa-dev] [PATCH] radv/ac: enable loop unrolling. (v2)

From: Dave Airlie This enables LLVM loop unrolling. v2: limit unroll count to 32, don't fully unroll. (arsenm) Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_helper.cpp | 22 ++ src/amd/common/ac_llvm_util.h | 1 +

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

On 24 February 2017 at 13:36, Matt Arsenault wrote: > > On Feb 23, 2017, at 19:27, Dave Airlie wrote: > > +static void set_unroll_metadata(struct nir_to_llvm_context *ctx, > +LLVMValueRef br) > +{ > + unsigned kind =

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

> On Feb 23, 2017, at 19:27, Dave Airlie wrote: > > +static void set_unroll_metadata(struct nir_to_llvm_context *ctx, > +LLVMValueRef br) > +{ > + unsigned kind = LLVMGetMDKindIDInContext(ctx->context, "llvm.loop", 9); > + LLVMValueRef

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

On 24 February 2017 at 13:27, Dave Airlie wrote: > From: Dave Airlie > > This enables LLVM loop unrolling. Meant to also say it's based on a radeonsi patch Marek wrote. Dave. > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

From: Dave Airlie This enables LLVM loop unrolling. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_helper.cpp | 22 ++ src/amd/common/ac_llvm_util.h | 1 + src/amd/common/ac_nir_to_llvm.c | 24 ++--

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 24/02/17 08:49, Timothy Arceri wrote: On 24/02/17 05:12, Marek Olšák wrote: On Thu, Feb 23, 2017 at 3:09 AM, Timothy Arceri wrote: From: kdj0c V2 (Timothy Arceri): - when loading from disk cache also binary insert into memory cache. - check

[Mesa-dev] [PATCH 8/8] anv: Advertise shaderInt64 on Broadwell and above

--- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 6f570d8..5857ae2 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -478,7 +478,7 @@ void

[Mesa-dev] [PATCH 7/8] i965: Do int64 lowering in NIR

--- src/mesa/drivers/dri/i965/brw_link.cpp | 5 - src/mesa/drivers/dri/i965/brw_nir.c| 7 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 977feb3..4159756 100644 ---

[Mesa-dev] [PATCH 6/8] nir: Add a simple int64 lowering pass

--- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 11 ++ src/compiler/nir/nir_lower_int64.c | 275 + 3 files changed, 287 insertions(+) create mode 100644 src/compiler/nir/nir_lower_int64.c diff --git

[Mesa-dev] [PATCH 5/8] spirv: Use nir_builder for control flow

--- src/compiler/spirv/vtn_cfg.c | 45 ++-- 1 file changed, 14 insertions(+), 31 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 3a31657..54248b1 100644 --- a/src/compiler/spirv/vtn_cfg.c +++

[Mesa-dev] [PATCH 3/8] nir/lower_gs_intrinsics: Use nir_builder control-flow helpers

--- src/compiler/nir/nir_lower_gs_intrinsics.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_lower_gs_intrinsics.c b/src/compiler/nir/nir_lower_gs_intrinsics.c index 3acb742..68e20dd 100644 --- a/src/compiler/nir/nir_lower_gs_intrinsics.c +++

[Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

Each of the pop functions (and push_else) take a control flow parameter as their second argument. If NULL, it assumes that the builder is in a block that's a direct child of the control-flow node you want to pop off the virtual stack. This is what 90% of consumers will want. The SPIR-V pass,

[Mesa-dev] [PATCH 4/8] nir/lower_indirect: Use nir_builder control-flow helpers

--- src/compiler/nir/nir_lower_indirect_derefs.c | 35 1 file changed, 5 insertions(+), 30 deletions(-) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c index 09cc9a3..c949224 100644 ---

[Mesa-dev] [PATCH 2/8] glsl/nir: Use nir_builder's new control-flow helpers

--- src/compiler/glsl/glsl_to_nir.cpp | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 00f20da..fc2a2c4 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 0/8] anv: Add int64 support for gen8+

This little series adds int64 support to Vulkan on Broadwell and newer hardware. In theory, we could also support it on gen7 but that requires more lowering code to be written. Most of this series is the nir_builder control-flow stuff that I sent out earlier with a small addition to make it easy

[Mesa-dev] [PATCH] builtin_functions: Add more 64-bit integers

Seriously, 1000 is not the only 64-bit integer. We should test a few more of them. These new integers trigger a bug in the GLSL IR int64 lowering code. Cc: Ian Romanick --- generated_tests/builtin_function.py | 24 ++-- 1 file changed, 22

Re: [Mesa-dev] [PATCH] mesa: Use _mesa_has_OES_geometry_shader() when validating draws

On Fri, Feb 24, 2017 at 5:00 AM, Kenneth Graunke wrote: > On Thursday, February 23, 2017 10:46:54 AM PST Ilia Mirkin wrote: > > The assumption was that if you're setting that ext, you can do gles31. Is > > there a driver/hw combo where that's not the case? If so, we should

Re: [Mesa-dev] [PATCH 6/6] radv: add sample mask output support

For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 23, 2017 at 7:09 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds support to write to sample mask from the fragment shader. > > We can optimise this later like

Re: [Mesa-dev] [PATCH] util/disk_cache: Use backward compatible st_mtime.

Reviewed-by: Timothy Arceri On 24/02/17 09:29, Vinson Lee wrote: Fix Mac OS X build error. CC libmesautil_la-disk_cache.lo In file included from disk_cache.c:46: ./disk_cache.h:57:20: error: no member named 'st_mtim' in 'struct stat' *timestamp =

[Mesa-dev] [PATCH] configure.ac: check require_basic_egl only if egl enabled

Otherwise the configuration fails when building independant libs like vdpau, vaapi or omx Signed-off-by: Leo Liu --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 44c7883..890a379 100644 --- a/configure.ac

Re: [Mesa-dev] [PATCH 02/37] mapi/glapi: remove unused next_available_offset.sh

On 02/23/2017 09:13 AM, Emil Velikov wrote: > Afaict there was no [documented] users since it was introduced. Back in the old days, some functions would get entry points assigned statically. Just looking at all the XML, it was difficult to tell what the next available offset was. This script

[Mesa-dev] [PATCH] glsl: Fix missing-braces warning.

CXXglsl/ast_to_hir.lo glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)': glsl/ast_to_hir.cpp:4846:42: warning: missing braces around initializer for 'unsigned int [16]' [-Wmissing-braces] Signed-off-by: Vinson Lee

[Mesa-dev] [PATCH] util/disk_cache: Use backward compatible st_mtime.

Fix Mac OS X build error. CC libmesautil_la-disk_cache.lo In file included from disk_cache.c:46: ./disk_cache.h:57:20: error: no member named 'st_mtim' in 'struct stat' *timestamp = st.st_mtim.tv_sec; ~~ ^ Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99918

Re: [Mesa-dev] X test suite regression due to gallivm change

On Thu, 2017-02-23 at 21:59 +0100, Roland Scheidegger wrote: > So, what does the failing test do? Not much, curiously. There are five that fail and they're all fairly trivial, although the xts harness makes that hard to see. XClearArea/6 and XClearWindow/4 set the window background pixmap to

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 24/02/17 05:12, Marek Olšák wrote: On Thu, Feb 23, 2017 at 3:09 AM, Timothy Arceri wrote: From: kdj0c V2 (Timothy Arceri): - when loading from disk cache also binary insert into memory cache. - check that the binary loaded from disk is the

Re: [Mesa-dev] X test suite regression due to gallivm change

Am 23.02.2017 um 19:51 schrieb Adam Jackson: > Starting from: > >> commit 320d1191c61a0a82444605c12e5c4b2ee0b241eb >> Author: Jose Fonseca >> Date: Mon Apr 4 00:05:33 2016 +0100 >> >> gallivm: Use llvm.fmuladd.*. >> >> Reviewed-by: Roland Scheidegger

[Mesa-dev] [PATCH] r600g/sb: Fix memory leak by reworking uses list (rebased)

The author is Heiko Przybyl(CC'ing), the patch is rebased on top of Bartosz Tomczyk's one per Dieter Nützel's comment. Tested-by: Constantine Charlamov -- When fixing the stalls on evergreen I introduced leaking of the useinfo structure(s). Sorry. Instead of

Re: [Mesa-dev] [PATCH] mesa: Use _mesa_has_OES_geometry_shader() when validating draws

On Thursday, February 23, 2017 10:46:54 AM PST Ilia Mirkin wrote: > The assumption was that if you're setting that ext, you can do gles31. Is > there a driver/hw combo where that's not the case? If so, we should fix > that instead... ChromeOS/ARC++ currently disables GLES 3.1 on i965 because we

Re: [Mesa-dev] [PATCH] Revert "i915: Always enable GL 2.0 support."

On Thu, Feb 23, 2017 at 11:41 AM, Emil Velikov wrote: > On 30 January 2017 at 02:20, Matt Turner wrote: >> This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558. >> It leaves ES 2.0 support in place per Ian's suggestion, because ES

Re: [Mesa-dev] [PATCH] Revert "i915: Always enable GL 2.0 support."

On 30 January 2017 at 02:20, Matt Turner wrote: > This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558. > It leaves ES 2.0 support in place per Ian's suggestion, because ES 2.0 > is designed to work on hardware like i915. > > The piglit results look like: > >

[Mesa-dev] Question: How to handle 64-bit sampler/image handles added by ARB_bindless_texture?

Hi there, I started to work on ARB_bindless_texture which is an important missing feature in Mesa. Some games, at least Deus Ex: Mankind Divided, would benefit of this extension. As the spec says: "The ability to access textures without having to bind and/or re-bind them is similar to the

Re: [Mesa-dev] [v2 22/27] intel/isl: Apply render target alignment constraints for MCS

Reviewed-by: Jason Ekstrand I also pushed it because I need it for my little series to implement MCS in the Vulkan driver. --Jason On Thu, Feb 23, 2017 at 5:31 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > v2: Instead of having the same block in

Re: [Mesa-dev] [PATCH] glsl: Raise a link error for non-SSO ES programs with a TES but no TCS.

On Thursday, February 23, 2017 4:03:36 AM PST Andres Gomez wrote: > I would welcome a reference to the text in Secption 7.3 of the OpenGL > ES 3.2 specs as a code comment and commit text but, other than that, > this is: > > Reviewed-by: Andres Gomez I'll add it to the commit

Re: [Mesa-dev] [PATCH] mesa: Use _mesa_has_OES_geometry_shader() when validating draws

The assumption was that if you're setting that ext, you can do gles31. Is there a driver/hw combo where that's not the case? If so, we should fix that instead... On Feb 23, 2017 3:05 AM, "Tomasz Figa" wrote: > In validate_DrawElements_common() we need to check for

[Mesa-dev] [PATCH v2 12/14] anv: don't use Element.get in anv_entrypoints_gen.py

This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the

Re: [Mesa-dev] [PATCH] radeonsi: fix broken tessellation on Carrizo and Stoney

On 02/23/2017 07:48 PM, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99850 Cc: 13.0 17.0 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 +++- 1 file changed, 3 insertions(+),

[Mesa-dev] X test suite regression due to gallivm change

Starting from: > commit 320d1191c61a0a82444605c12e5c4b2ee0b241eb > Author: Jose Fonseca > Date:   Mon Apr 4 00:05:33 2016 +0100 > > gallivm: Use llvm.fmuladd.*. > > Reviewed-by: Roland Scheidegger 'make check' in xserver no longer passes

Re: [Mesa-dev] [PATCH] radeonsi: fix broken tessellation on Carrizo and Stoney

On Thu, Feb 23, 2017 at 1:48 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 13.0 17.0 Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state_shaders.c | 4 +++- > 1 file

[Mesa-dev] [PATCH] radeonsi: fix broken tessellation on Carrizo and Stoney

From: Marek Olšák Cc: 13.0 17.0 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH v2 10/14] anv: anv_entrypoints_gen.py: use reduce function.

Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [PATCH v2 8/14] anv: generate anv_entrypoints.{h, c} in one command

This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. v2: - Update Android.mk

[Mesa-dev] [PATCH v2 13/14] anv: use cElementTree in anv_entrypoints_gen.py

It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 7/14] anv: convert C generation to template in anv_entrypoints_gen.py

This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v2 6/14] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++ 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v2 9/14] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2 14/14] anv: Remove dead prototype from entrypoints

Spotted by Emil. v2: - Add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index b498176..44b6d2c

[Mesa-dev] [PATCH v2 2/14] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

[Mesa-dev] [PATCH v2 11/14] anv: use dict.get in anv_entrypoints_gen.py

Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v2 5/14] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 108 - 1 file

[Mesa-dev] [PATCH v2 4/14] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++

[Mesa-dev] [PATCH v2 1/14] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v2 0/14] cleanup anv_entrpoints_gen.py

There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [PATCH v2 3/14] anv: make constants capitals in anv_entrypoints_gen.py

Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

On 23 February 2017 at 17:54, Matt Turner wrote: > On Thu, Feb 23, 2017 at 9:29 AM, Emil Velikov > wrote: >> On 23 February 2017 at 17:22, Dylan Baker wrote: >>> Quoting Emil Velikov (2017-02-23 02:32:17) On 22 February

[Mesa-dev] [PATCH] glsl: add missing blend_support qualifier in validate_flags()

Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_type.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index 580d216b30..96d20c10af 100644 ---

Re: [Mesa-dev] [PATCH] glsl: add has_shader_image_load_store()

On Thu, Feb 23, 2017 at 10:04 AM, Samuel Pitoiset wrote: > Preliminary work for ARB_bindless_texture which can interact > with ARB_shader_image_load_store. > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/builtin_variables.cpp |

Re: [Mesa-dev] [PATCH 2/2] Revert "glsl: Switch to disable-by-default for the GLSL shader cache"

On Thu, Feb 23, 2017 at 5:55 PM, Timothy Arceri wrote: > On 24/02/17 02:09, Marek Olšák wrote: >> >> On Thu, Feb 23, 2017 at 3:09 AM, Timothy Arceri >> wrote: >>> >>> This reverts commit 0f60c6616e93cba72bff4fbfedb72a753ef78e05. >>> >>> Piglit and

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On Thu, Feb 23, 2017 at 3:09 AM, Timothy Arceri wrote: > From: kdj0c > > V2 (Timothy Arceri): > - when loading from disk cache also binary insert into memory cache. > - check that the binary loaded from disk is the correct size. If not > delete the

Re: [Mesa-dev] [PATCH 01/37] ABI-check: add a note that checking only T symbols is flacky

On 23 February 2017 at 17:34, Matt Turner wrote: > s/flacky/flakey/ in the title. > > On Thu, Feb 23, 2017 at 9:13 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Note that all the symbols/ABI checks in tree do so

Re: [Mesa-dev] [PATCH] mesa: Use _mesa_has_OES_geometry_shader() when validating draws

On Thu, Feb 23, 2017 at 12:05 AM, Tomasz Figa wrote: > In validate_DrawElements_common() we need to check for OES_geometry_shader > extension to determine if we should fail if transform feedback is > unpaused. However current code reads ctx->Extensions.OES_geometry_shader >

[Mesa-dev] [PATCH] glsl: add has_shader_image_load_store()

Preliminary work for ARB_bindless_texture which can interact with ARB_shader_image_load_store. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_variables.cpp | 3 +-- src/compiler/glsl/glsl_parser.yy| 3 +-- src/compiler/glsl/glsl_parser_extras.h

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

On Thu, Feb 23, 2017 at 9:29 AM, Emil Velikov wrote: > On 23 February 2017 at 17:22, Dylan Baker wrote: >> Quoting Emil Velikov (2017-02-23 02:32:17) >>> On 22 February 2017 at 23:35, Dylan Baker wrote: >>> > This changes the

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

Quoting Emil Velikov (2017-02-23 09:29:40) > On 23 February 2017 at 17:22, Dylan Baker wrote: > > Quoting Emil Velikov (2017-02-23 02:32:17) > >> On 22 February 2017 at 23:35, Dylan Baker wrote: > >> > This changes the python generator to write the files

Re: [Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

Sure, I'll add a patch for v2 Quoting Emil Velikov (2017-02-23 03:14:49) > On 22 February 2017 at 23:36, Dylan Baker wrote: > > > +void anv_set_dispatch_devinfo(const struct gen_device_info *info); > Dead declaration since commit

Re: [Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

Quoting Emil Velikov (2017-02-23 02:24:21) > Hi Dylan, > > General question - have you considered porting the series to the radv ? > Alternatively - Bas, Dave you might find these interesting/useful ;-) Yeah, I'm getting there. My goal is mako + python3 readiness for all of mesa. > > On 22

Re: [Mesa-dev] [PATCH 01/37] ABI-check: add a note that checking only T symbols is flacky

s/flacky/flakey/ in the title. On Thu, Feb 23, 2017 at 9:13 AM, Emil Velikov wrote: > From: Emil Velikov > > Note that all the symbols/ABI checks in tree do so :-\ > > Signed-off-by: Emil Velikov > --- > Mostly

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

On 23 February 2017 at 17:22, Dylan Baker wrote: > Quoting Emil Velikov (2017-02-23 02:32:17) >> On 22 February 2017 at 23:35, Dylan Baker wrote: >> > This changes the python generator to write the files itself, rather than >> > piping them out. This has

[Mesa-dev] [PATCH 25/37] st/xa: suffix xa-indent{, .sh} and add a shebang line

From: Emil Velikov Signed-off-by: Emil Velikov --- Is this still used ? Running it produces some some 250+ diff stat. --- src/gallium/state_trackers/xa/Makefile.am | 2 +- src/gallium/state_trackers/xa/{xa-indent =>

[Mesa-dev] [PATCH 34/37] wayland-egl/wayland-egl-symbols-check: do not mandate bash

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/wayland/wayland-egl/wayland-egl-symbols-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/wayland-egl-symbols-check

[Mesa-dev] [PATCH 21/37] mapi/gen: remove shebang from python scripts

From: Emil Velikov All of those should be executed $PYTHON2/python2 [or equivalent] hence why they are missing the execute bit. Signed-off-by: Emil Velikov --- src/mapi/glapi/gen/glX_XML.py | 1 -

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

Quoting Emil Velikov (2017-02-23 02:32:17) > On 22 February 2017 at 23:35, Dylan Baker wrote: > > This changes the python generator to write the files itself, rather than > > piping them out. This has a couple of advantages: first, it encapsulates > > the encoding. Second, it

[Mesa-dev] [PATCH 17/37] i965: remove execute bit from brw_nir_trig_workarounds.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644

[Mesa-dev] [PATCH 22/37] gallium/tests: remove execute bit from TGSI shader - vert-uadd.sh

From: Emil Velikov Just like the the dozens of other shaders, the file is parsed by separate tool and not executed. Cc: José Fonseca Signed-off-by: Emil Velikov --- Jose, please double-check since I've got no idea how

[Mesa-dev] [PATCH 37/37] bin/get-fixes-pick-list.sh: do not mandate bash

From: Emil Velikov Silly thinko on my end, as I was writing the script. There is nothing bash specific in there. Signed-off-by: Emil Velikov --- bin/get-fixes-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 33/37] gbm/gbm-symbols-check: do not mandate bash

From: Emil Velikov Analogous to previous commit. Signed-off-by: Emil Velikov --- src/gbm/gbm-symbols-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-check index

[Mesa-dev] [PATCH 36/37] in/shortlog_mesa.sh: remove the final bashism

From: Emil Velikov Remove the typeset built-in and toggle to /bin/sh Signed-off-by: Emil Velikov --- Sidenote: seems like there is something in the script which causes bash to trip in the odd occasion while zsh works like a charm. Namely

[Mesa-dev] [PATCH 19/37] bin/perf-annotate-jit: add .py suffix

From: Emil Velikov To provide direct feedback about the file in question. Cc: José Fonseca Signed-off-by: Emil Velikov --- Jose, I sincerely hope this doesn't cause issues on your end. --- bin/{perf-annotate-jit =>

[Mesa-dev] [PATCH 35/37] bin/bugzilla_mesa.sh: rework the looping method

From: Emil Velikov We don't use DRYRUN (and no others scripts have one) so just drop it. This allows us to rework the loop to the more commonly used "git | while read foo; do ... done" That in itself gets rid of the only remaining bashism and we can toggle the

[Mesa-dev] [PATCH 23/37] gallium/tools: do not hardcode bash location

It is not guaranteed to be in /bin Signed-off-by: Emil Velikov --- src/gallium/tools/addr2line.sh | 2 +- src/gallium/tools/trace/tracediff.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/tools/addr2line.sh

[Mesa-dev] [PATCH 32/37] egl/egl-symbols-check: do not mandate bash

From: Emil Velikov There's nothing bash specific in the script. Signed-off-by: Emil Velikov --- src/egl/egl-symbols-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/egl-symbols-check

[Mesa-dev] [PATCH 29/37] util: remove shebang from format_srgb.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/util/format_srgb.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/format_srgb.py b/src/util/format_srgb.py index d5cbcf7646..44b35a061d

[Mesa-dev] [PATCH 31/37] glsl/tests: remove any bashisms

From: Emil Velikov Signed-off-by: Emil Velikov --- src/compiler/glsl/tests/optimization-test.sh | 4 ++-- src/compiler/glsl/tests/warnings-test.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 26/37] nir: remove shebang from python scripts

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/compiler/nir/nir_algebraic.py| 1 - src/compiler/nir/nir_builder_opcodes_h.py| 1 - src/compiler/nir/nir_constant_expressions.py | 1 -

[Mesa-dev] [PATCH 24/37] gallium/tools: use correct shebang for python scripts

From: Emil Velikov These are python2 scripts and the generic "python" may point to python3. Signed-off-by: Emil Velikov --- src/gallium/tools/trace/diff_state.py | 2 +- src/gallium/tools/trace/dump.py | 2 +-

[Mesa-dev] [PATCH 18/37] i965: remove shebang from brw_nir_trig_workarounds.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [PATCH 30/37] dri: use correct shebang for gen-symbol-redefs.py

From: Emil Velikov This is a python2 script and the generic "python" may point to python3. Cc: Andreas Boll Signed-off-by: Emil Velikov --- We really want to prune/rename all the conflicting entrypoints. In

[Mesa-dev] [PATCH 20/37] mapi: do not mandate bash for es*api/ABI-check

From: Emil Velikov Seemingly there is nothing bash specific in these. The Debian checkbashisms does not spot neither run in zsh. Signed-off-by: Emil Velikov --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files

[Mesa-dev] [PATCH 15/37] mesa: remove execute bit from main/format_parser.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/mesa/main/format_parser.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 src/mesa/main/format_parser.py diff

[Mesa-dev] [PATCH 27/37] genxml: remove shebang from gen_pack_header.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/intel/genxml/gen_pack_header.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/genxml/gen_pack_header.py

[Mesa-dev] [PATCH 14/37] amd: remove shebang from python scripts

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/amd/common/sid_tables.py | 1 - src/amd/vulkan/vk_format_parse.py | 1 - src/amd/vulkan/vk_format_table.py | 1 - 3 files changed, 3 deletions(-)

[Mesa-dev] [PATCH 28/37] xmlpool: remove shebang from gen_xmlpool.py

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/xmlpool/gen_xmlpool.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/xmlpool/gen_xmlpool.py

[Mesa-dev] [PATCH 16/37] mesa: remove shebang from python scripts

From: Emil Velikov Analogous to earlier commit(s). Signed-off-by: Emil Velikov --- src/mesa/main/format_info.py| 1 - src/mesa/main/format_pack.py| 1 - src/mesa/main/format_parser.py | 1 -

  1   2   >