Re: [Mesa-dev] [PATCH V2 2/3] util/rand_xor: add function to seed rand

If a proper PRNG like arc4random backed by a syscall like getentropy were used this would already handle reseeding on fork and fd exhaustion. And look people have already gone out of their way to provide fallbacks for these interfaces.

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue, Mar 21, 2017 at 09:22:50AM -0700, Dylan Baker wrote: > Quoting Jani Nikula (2017-03-21 07:44:55) > > On Thu, 16 Mar 2017, Dylan Baker wrote: > > > First it's written in python, [...] > > > > How does meson handle python 2 vs. 3? How do you avoid issues in the > >

[Mesa-dev] [PATCH V4 1/3] util/disk_cache: hash timestamps into the cache keys

From: Grazvydas Ignotas Instead of using a directory, hash the timestamps into the cache keys themselves. Since there is no more timestamp directory, there is no more need for deleting the cache of other mesa versions and we rely on eviction to clean up the old cache entries.

[Mesa-dev] [PATCH V2 3/3] util/disk_cache: write cache entry keys to file header

This can be used to deal with key hash collisions from different versions (should we find that to actually happen) and to find which mesa version produced the cache entry. V2: use blob created add cache creation. --- src/util/disk_cache.c | 53 +--

[Mesa-dev] [PATCH V3 2/3] util/disk_cache: hash pointer size and gpu name into cache keys

From: Grazvydas Ignotas This allows to get rid of the arch and gpu name directories. v2: (Timothy Arceri) don't use an opaque data type to store pointer size and gpu name. v3: (Timothy Arceri) use blob to store driver keys just make sure to store null terminator for

[Mesa-dev] [PATCH v2] nouveau: enable glsl/tgsi on-disk cache

v2: Fix argument to nouveau_screen_get_name() Signed-off-by: Boyan Ding --- src/gallium/drivers/nouveau/nouveau_screen.c | 30 src/gallium/drivers/nouveau/nouveau_screen.h | 3 +++ 2 files changed, 33 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 19/23] nir: Return progress from nir_convert_from_ssa().

On Tue, Mar 21, 2017 at 4:59 PM, Matt Turner wrote: > --- > Is this what you had in mind? > More or less. > src/compiler/nir/nir.h | 2 +- > src/compiler/nir/nir_from_ssa.c | 18 -- > 2 files changed, 13 insertions(+), 7 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 2/3] util/disk_cache: hash pointer size and gpu name into cache keys

On 21/03/17 21:23, Timothy Arceri wrote: On 21/03/17 21:01, Nicolai Hähnle wrote: On 21.03.2017 10:22, Timothy Arceri wrote: On 21/03/17 19:25, Nicolai Hähnle wrote: On 21.03.2017 06:14, Timothy Arceri wrote: From: Grazvydas Ignotas This allows to get rid of the

Re: [Mesa-dev] [PATCH] i965: Add the Haswell OA generated files to .gitignore

so do I On Tue, Mar 21, 2017 at 5:43 PM, Chad Versace wrote: > I believe 72c89522c23e54ef19d0a8a7fd85f791727a05d6 already does this. > > On Tue 21 Mar 2017, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/.gitignore | 2 ++ > > 1 file changed, 2

[Mesa-dev] [Bug 99956] build_id.c:36:20: error: unknown type name 'Elf_Nhdr'

https://bugs.freedesktop.org/show_bug.cgi?id=99956 Vinson Lee changed: What|Removed |Added CC|

[Mesa-dev] [PATCH kmscube] Makefile.am: Add -std=c99 to CFLAGS

Currently the following build errors are seen on mips64el: cube-tex.c: In function 'get_fd_rgba': cube-tex.c:230:2: error: 'for' loop initial declarations are only allowed in C99 mode for (uint32_t i = 0; i < texh; i++) { ^ cube-tex.c:230:2: note: use option -std=c99 or -std=gnu99 to compile

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

https://bugs.freedesktop.org/show_bug.cgi?id=100303 Samuel Pitoiset changed: What|Removed |Added Component|Drivers/Gallium/radeonsi

Re: [Mesa-dev] [PATCH V2 3/3] util/disk_cache: use rand_xorshift128plus() to get our random int

On Wed, Mar 22, 2017 at 1:59 AM, Timothy Arceri wrote: > Otherwise for apps that don't seed the regular rand() we will always > remove old cache entries from the same dirs. > > V2: assume bits returned by rand are independent uniformly distributed > bits and grab our

Re: [Mesa-dev] [RESEND v4 00/16] cleanup anv_entrpoints_gen.py

Quoting Dylan Baker (2017-03-20 09:51:58) > Quoting Emil Velikov (2017-03-20 08:11:58) > > On 8 March 2017 at 18:11, Emil Velikov wrote: > > > On 7 March 2017 at 21:14, Dylan Baker wrote: > > >> There are a number of small style cleanups and

Re: [Mesa-dev] [PATCH] i965: Add the Haswell OA generated files to .gitignore

I believe 72c89522c23e54ef19d0a8a7fd85f791727a05d6 already does this. On Tue 21 Mar 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 src/mesa/drivers/dri/i965/.gitignore > > diff --git

Re: [Mesa-dev] [PATCH] anv/image: Return early when unbinding an image

On Tue 21 Mar 2017, Jason Ekstrand wrote: > Found by inspection. > > Cc: "17.0 13.0" > --- > src/intel/vulkan/anv_image.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Chad Versace

[Mesa-dev] [PATCH] anv/image: Return early when unbinding an image

Found by inspection. Cc: "17.0 13.0" --- src/intel/vulkan/anv_image.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index aeb144e..dfd193e 100644 ---

Re: [Mesa-dev] [PATCH 2/3] util/rand_xor: add function to seed rand

On 22/03/17 05:53, Grazvydas Ignotas wrote: On Tue, Mar 21, 2017 at 10:57 AM, Timothy Arceri wrote: --- src/gallium/drivers/radeon/r600_test_dma.c | 3 +- src/util/rand_xor.c| 62 -- src/util/rand_xor.h

[Mesa-dev] [PATCH 19/23] nir: Return progress from nir_convert_from_ssa().

--- Is this what you had in mind? src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_from_ssa.c | 18 -- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index db47699..0a127cd 100644 ---

[Mesa-dev] [PATCH V2 2/3] util/rand_xor: add function to seed rand

V2: pass the seed to the seed function so that we can isolate its uses. Stop leaking fd when urandom couldn't be read. --- src/gallium/drivers/radeon/r600_test_dma.c | 3 +- src/util/rand_xor.c| 57 ++ src/util/rand_xor.h

[Mesa-dev] [PATCH V2 3/3] util/disk_cache: use rand_xorshift128plus() to get our random int

Otherwise for apps that don't seed the regular rand() we will always remove old cache entries from the same dirs. V2: assume bits returned by rand are independent uniformly distributed bits and grab our hex value without taking the modulus of the whole value, this also fixes a bug where

[Mesa-dev] [PATCH V2 1/3] util: move rand_xorshift128plus() to utils

V2: pass the seed to rand_xorshift128plus() so that we can isolate its uses. --- src/gallium/drivers/radeon/r600_test_dma.c | 24 +- src/util/Makefile.sources | 2 ++ src/util/rand_xor.c| 20 ++ src/util/rand_xor.h

[Mesa-dev] [PATCH] util/sha1: harmonize _mesa_sha1_* wrappers

Rather than using 3 different ways to wrap _mesa_sha1_*() to SHA1*() functions (a macro, prototype with implementation in .c and an inline function), make all 3 inline functions. Signed-off-by: Grazvydas Ignotas --- src/util/mesa-sha1.c | 6 -- src/util/mesa-sha1.h | 13

[Mesa-dev] [PATCH] glsl: Link glsl_compiler with CLOCK_LIB.

Fix linking error with build. CXXLD glsl_compiler glsl/.libs/libstandalone.a(lt16-libmesautil_la-u_queue.o): In function `u_thread_get_time_nano': src/util/../../src/util/u_thread.h:84: undefined reference to `clock_gettime' Signed-off-by: Vinson Lee ---

[Mesa-dev] [PATCH 8/8] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 4/8] intel/common: Add func gen_get_version_10x()

It does the obvious. bdw => 80 hsw => 75 ivb => 70 ... g4x => 45 --- src/intel/common/gen_device_info.c | 11 +++ src/intel/common/gen_device_info.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/intel/common/gen_device_info.c

[Mesa-dev] [PATCH 3/8] genxml: Add 3DSTATE_DEPTH_BUFFER to gen5.xml

isl will use this for validating the depth buffer pitch. --- src/intel/genxml/gen5.xml | 56 +++ 1 file changed, 56 insertions(+) diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml index 39fec3723f6..97c13699673 100644 ---

[Mesa-dev] [PATCH 5/8] isl: Validate the calculated row pitch

Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch --- src/intel/isl/isl.c

[Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. Currently, the bitfields in genX_bits.h are those whose name matches /.*Surface(Q?)Pitch/. isl_surf_init() will use the new header to validate that

[Mesa-dev] [PATCH 1/8] genxml: Add pitch bitfield sizes to gen*_pack.h

For each structure or instruction member in gen*_pack.h whose name matches /.*Surface(Q?)Pitch$", add a macro that defines the member's bitfield size. isl will use these macros to validate requested pitches. Example: Changes to RENDER_SURFACE_STATE in gen9_pack.h: #define

[Mesa-dev] [PATCH 0/8] isl: Fix requests for exact row pitch (v2)

All callers of isl_surf_init() that set 'min_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. This series fixes that by adding a field, isl_surf_init_info::row_pitch. This prepares for VK_MESAX_external_image_dma_buf, which requires

[Mesa-dev] [PATCH 6/8] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: Validate the requested row_pitch. Reviewed-by: Jason Ekstrand (v2) --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 7/8] intel: Fix requests for exact surface row pitch (v2)

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. v2: Assert that isl_surf_init() succeeds because the callers assume it.

Re: [Mesa-dev] [PATCH 1/3] gallivm: remove lp_add_attr_dereferenceable in favor of amd/common

On 22 March 2017 at 08:18, Marek Olšák wrote: > From: Marek Olšák For the first 2, Reviewed-by: Dave Airlie > > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 11 --- > src/gallium/auxiliary/gallivm/lp_bld_misc.h |

Re: [Mesa-dev] [PATCH 3/3] configure.ac: adjust strip_unwanted_llvm_flags to fix build with LLVM 5.0svn

This looks like a bug in LLVM. Not sure if Mesa should do anything about it: llvm-config --cxxflags -I/usr/llvm/x86_64-linux-gnu/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers

Re: [Mesa-dev] [PATCH 2/2] i965: Delete tile resource mode code

Both are Reviewed-by: Jason Ekstrand On Tue, Mar 21, 2017 at 2:57 PM, Anuj Phogat wrote: > Yf/Ys tiling never got used in i965 due to not delivering > the expected performance benefits. So, this patch is deleting > this dead code in favor of adding

[Mesa-dev] [PATCH 3/3] configure.ac: adjust strip_unwanted_llvm_flags to fix build with LLVM 5.0svn

From: Marek Olšák I get -fno-rtti-DLLVM_... in LLVM_CXX_FLAGS, so add spaces. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8c9d756..480f493 100644 --- a/configure.ac +++ b/configure.ac @@ -909,23

[Mesa-dev] [PATCH 2/3] ac: fix build with LLVM 5.0svn

From: Marek Olšák --- src/amd/common/ac_llvm_helper.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp index 4f03103..83ad7ff 100644 --- a/src/amd/common/ac_llvm_helper.cpp

[Mesa-dev] [PATCH 1/3] gallivm: remove lp_add_attr_dereferenceable in favor of amd/common

From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 11 --- src/gallium/auxiliary/gallivm/lp_bld_misc.h | 3 --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] i965: Delete tile resource mode code

Yf/Ys tiling never got used in i965 due to not delivering the expected performance benefits. So, this patch is deleting this dead code in favor of adding it later in ISL when we actually find it useful. ISL can then share this code between vulkan and GL. Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH 1/2] i965: Delete fast copy blit code

Fast copy blit was primarily added to support Yf/Ys detiling. But, Yf/Ys tiling never got used in i965 due to not delivering the expected performance benefits. Also, replacing legacy blits with fast copy blit didn't help the benchmarking numbers. This is probably due to a h/w restriction that says

Re: [Mesa-dev] [PATCH v3 1/1] clover: use pipe_resource references

On 03/17/2017 05:20 AM, Jan Vesely wrote: > On Thu, 2017-03-16 at 18:07 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >>> On Thu, 2017-03-16 at 17:22 -0700, Francisco Jerez wrote: Jan Vesely writes: > On Thu, 2017-03-16 at

Re: [Mesa-dev] [PATCH 5/8] [v4] i965/dri: Handle the linear fb modifier

Ok, I think we're finally good to land. Whole series is Reviewed-by: Jason Ekstrand in case you were still missing any. On Tue, Mar 21, 2017 at 2:27 PM, Ben Widawsky wrote: > At image creation create a path for dealing with the linear modifier. >

[Mesa-dev] [PATCH] anv/device: Move push descriptor query handling

The query is a properties query so it needs to be handled in GetPhysicalDeviceProperties2, not GetPhysicalDeviceFeatures2. Cc: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 5/8] [v4] i965/dri: Handle the linear fb modifier

At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During development of this patch series, it was decided that a lack of modifier was an insufficient way to express the required modifiers.

[Mesa-dev] [PATCH] i965: Add the Haswell OA generated files to .gitignore

--- src/mesa/drivers/dri/i965/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 src/mesa/drivers/dri/i965/.gitignore diff --git a/src/mesa/drivers/dri/i965/.gitignore b/src/mesa/drivers/dri/i965/.gitignore new file mode 100644 index 000..e21ae5c --- /dev/null +++

Re: [Mesa-dev] [PATCH] i965/dri: Handle the linear fb modifier

On 17-03-21 14:15:05, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 2:09 PM, Ben Widawsky wrote: At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During development

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hey Kai, Quoting Kai Wasserbäch (2017-03-21 11:36:31) > I hope the rest of the Mesa project would follow such a rule. Because if > there's > something I absolutely hate about all those "new" build systems, then it's > their > tendency to just download stuff and build/include that. This seems to

Re: [Mesa-dev] [PATCH] i965/dri: Handle the linear fb modifier

On Tue, Mar 21, 2017 at 2:09 PM, Ben Widawsky wrote: > At image creation create a path for dealing with the linear modifier. > This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR > was specified. > > During development of this patch series, it was decided

[Mesa-dev] [PATCH] i965/dri: Handle Y-tiled modifier

This patch begins introducing how we'll actually handle the potentially many modifiers coming in from the API, how we'll store them, and the structure in the code to support it. Prior to this patch, the Y-tiled modifier would be entirely ignored. It shouldn't actually be used until this point

[Mesa-dev] [PATCH] i965/dri: Handle the linear fb modifier

At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During development of this patch series, it was decided that a lack of modifier was an insufficient way to express the required modifiers.

Re: [Mesa-dev] [PATCH v2 2/5] intel: Move tools/decoder.[ch] to common/gen_decoder.[ch].

On Tuesday, March 21, 2017 4:40:26 AM PDT Emil Velikov wrote: > On 21 March 2017 at 11:14, Emil Velikov wrote: > > On 20 March 2017 at 22:04, Kenneth Graunke wrote: > >> This way they become part of libintel_common.la so I can use them in > >> the

Re: [Mesa-dev] [PATCH 6/8] i965/dri: Handle Y-tiled modifier

On 17-03-21 13:52:12, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote: This patch begins introducing how we'll actually handle the potentially many modifiers coming in from the API, how we'll store them, and the structure in the code to support it.

Re: [Mesa-dev] [PATCH 6/8] i965/dri: Handle Y-tiled modifier

On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote: > This patch begins introducing how we'll actually handle the potentially > many modifiers coming in from the API, how we'll store them, and the > structure in the code to support it. > > Prior to this patch, the Y-tiled

Re: [Mesa-dev] [PATCH 5/8] i965/dri: Handle the linear fb modifier

On 17-03-21 13:48:13, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote: At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During development

Re: [Mesa-dev] [PATCH 5/8] i965/dri: Handle the linear fb modifier

On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote: > At image creation create a path for dealing with the linear modifier. > This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR > was specified. > > During development of this patch series, it was decided

[Mesa-dev] [PATCH 6/8] i965/dri: Handle Y-tiled modifier

This patch begins introducing how we'll actually handle the potentially many modifiers coming in from the API, how we'll store them, and the structure in the code to support it. Prior to this patch, the Y-tiled modifier would be entirely ignored. It shouldn't actually be used until this point

[Mesa-dev] [PATCH 7/8] i965/dri: Handle X-tiled modifier

This doesn't really "do" anything because the default tiling for the winsys buffer is X tiled. We do however want the X tiled modifier to work correctly from the API perspective, which would imply that if you set this modifier, and later do a get_modifier, you get back at least X tiled. Running

[Mesa-dev] [PATCH 8/8] i965/dri: Turn on support for image modifiers

All the plumbing is in place so the extension just needs to be advertised. Signed-off-by: Ben Widawsky Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 5/8] i965/dri: Handle the linear fb modifier

At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During development of this patch series, it was decided that a lack of modifier was an insufficient way to express the required modifiers.

[Mesa-dev] [PATCH 4/8] i965/dri: Enable modifier queries

New to the patch series after reordering things for landing smaller chunks. This will essentially enable modifiers from clients that were just enabled in previous patches. A client could use the modifiers by setting all of them at create, but had no way to actually query them after creating the

[Mesa-dev] [PATCH 3/8] i965/dri: Store the screen associated with the image

I intend to need to get to the devinfo structure, and storing the screen is an easy way to do that. It seems to be the consensus that you cannot share an image between multiple screens. Scape-goat: Rob Clark Signed-off-by: Ben Widawsky Reviewed-by: Eric

[Mesa-dev] [PATCH 1/8] i965/dri: Disallow image with INVALID modifier

Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index af9c9a45f3..b77933e100 100644 ---

[Mesa-dev] [PATCH 2/8] gbm: Disallow INVALID modifiers returned upon image creation

Signed-off-by: Ben Widawsky --- src/gbm/backends/dri/gbm_dri.c | 28 1 file changed, 28 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index a7ac149365..283a73454e 100644 ---

[Mesa-dev] [PATCH 0/8] [v2] i965 tiling modifiers

v2 of the third chunk of Renderbuffer Decompression support. The big change over the previous version is that now the INVALID modifier is explcitly disallowed in the GBM layer (and the equivalent i965 functionality). The other big change is the priority selection algorithm for modifiers. As

Re: [Mesa-dev] [PATCH 0/2] Compilation fixes for mingw

> On Mar 19, 2017, at 4:37 PM, Emil Velikov wrote: > > On 19 March 2017 at 22:16, Miklós Máté wrote: >> On 19/03/17 22:13, Emil Velikov wrote: >>> >>> Hi Miklós, >>> >>> On 19 March 2017 at 12:28, Miklós Máté wrote:

Re: [Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

On Tue, Mar 21, 2017 at 8:07 PM, Grazvydas Ignotas wrote: > This doesn't build for me: > > make[4]: Entering directory > '/home/notaz/src/radeon/mesa/src/gallium/winsys/amdgpu/drm' > CC amdgpu_bo.lo > amdgpu_bo.c: In function ‘amdgpu_buffer_get_metadata’: >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue, Mar 21, 2017 at 11:56 AM, Emil Velikov wrote: > On 21 March 2017 at 18:06, Matt Turner wrote: >> (1) Non-recursive automake is necessary for parallel build performance > Fully agree > >> (2) Non-recursive automake is intractably

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue, Mar 21, 2017 at 11:56 AM, Emil Velikov wrote: > On 21 March 2017 at 18:06, Matt Turner wrote: > > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: > >> On 21 March 2017 at 15:57, Matt Turner

Re: [Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

This doesn't build for me: make[4]: Entering directory '/home/notaz/src/radeon/mesa/src/gallium/winsys/amdgpu/drm' CC amdgpu_bo.lo amdgpu_bo.c: In function ‘amdgpu_buffer_get_metadata’: amdgpu_bo.c:615:53: error: ‘AMDGPU_TILING_SWIZZLE_MODE_SHIFT’ undeclared (first use in this function)

Re: [Mesa-dev] [PATCH 1/2] anv: automake: use the local headers over any system provided ones

On Tue, Mar 21, 2017 at 2:05 PM, Emil Velikov wrote: > On 20 March 2017 at 21:51, Jason Ekstrand wrote: >> On Mon, Mar 20, 2017 at 8:18 AM, Emil Velikov >> wrote: >>> diff --git a/src/intel/Makefile.vulkan.am

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 21 March 2017 at 18:06, Matt Turner wrote: > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: >> On 21 March 2017 at 15:57, Matt Turner wrote: >>> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 2/3] util/rand_xor: add function to seed rand

On Tue, Mar 21, 2017 at 10:57 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeon/r600_test_dma.c | 3 +- > src/util/rand_xor.c| 62 > -- > src/util/rand_xor.h| 6 ++- > 3 files

[Mesa-dev] [PATCH v2 5/5] Android: drop Android 4.4 (KitKat) support

Any users of KitKat are likely using an older version of Mesa and KitKat support adds complexity to the make files. Dropping support allows removing the MESA_LOLLIPOP_BUILD make variable in various make files. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli

[Mesa-dev] [PATCH v2 4/5] Android: kill off {MESA_}ANDROID_VERSION defines aka Android 4.1 and older

The Android version defines are only needed for versions less than 4.2 which aren't really supported or tested. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - Update subject - drop trailing \ on make variables Android.common.mk

[Mesa-dev] [PATCH v2 3/5] Android: fix libz dependency for host targets

Commit 6facb0c08fa1 ("android: fix libz dynamic library dependencies") added libz as a dependency, but this breaks host targets as the host dependency is libz-host. As no host lib needs libz, just remove the dependency for them. Fixes: 6facb0c08fa1 "android: fix libz dynamic library dependencies"

[Mesa-dev] [PATCH v2 2/5] Android: remove host libmesa_util

The host libmesa_util is never used for Android builds, so remove it. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - no change src/util/Android.mk | 35 --- 1 file changed, 35 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/5] Android: clean-up trailing '\' in make variables

Fixed with the following command: perl -pe 'BEGIN{undef $/;} s/ \\\n\n/\n\n/smg' $(find . -name 'Android.*') Signed-off-by: Rob Herring --- v2: - new patch Android.common.mk | 2 +- src/compiler/Android.glsl.gen.mk | 4 ++--

[Mesa-dev] [PATCH v2 0/5] Android build clean-up and fixes

This is a series of clean-ups and fixes to get Mesa master building on AOSP master again. AOSP master recently changed from X.Y.Z versioning to just the letter commonly used. Primarily, dropping KitKat and earlier support removes most of the version number dependencies and fixes the build. I've

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hey Dylan, Dylan Baker wrote on 21.03.2017 18:34: > Quoting Kai Wasserbäch (2017-03-21 09:50:52) >> I've just a few points, since I'm not too enthused by the prospect of having >> to >> deal with yet another build system with yet another slightly different >> syntax. >> But ultimately this is

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov wrote: > On 21 March 2017 at 15:57, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov >> wrote: >>> On 20 March 2017 at 18:30, Matt Turner

[Mesa-dev] [PATCH 2/2] nvc0/ir: also do ConstantFolding for FMA

Helps mainly Feral-ported games, due to their use of fma() shader-db changes: total instructions in shared programs : 3941587 -> 3940749 (-0.02%) total gprs used in shared programs: 481511 -> 481460 (-0.01%) total local used in shared programs : 27469 -> 27481 (0.04%) total bytes used in

[Mesa-dev] [PATCH 1/2] nvc0/ir: disable support for LIMMs on MAD/FMA

I hit an assert in the emiter while toying around with optimizations, because ConstantFolding immediated a big int into a mad. There is special handling for FMA/MAD in insnCanLoad, which is broken. With this patch the special path should be not hit anymore. Anyway, the constraints for the LIMMS

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hi Kai, Quoting Kai Wasserbäch (2017-03-21 09:50:52) > Hey Dylan, > I've just a few points, since I'm not too enthused by the prospect of having > to > deal with yet another build system with yet another slightly different syntax. > But ultimately this is only a "my 2 cents" e-mail, since others

Re: [Mesa-dev] [PATCH] swr: [rasterizer jitter] fix llvm >= 5.0 build break

On 03/21/2017 05:50 PM, Tim Rowley wrote: > Function::getArgumentList() doesn't exist anymore, switch to using > arg_begin() (existed back to at least llvm-3.6.0). > > CC: > --- > src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 2 +- >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 21 March 2017 at 15:57, Matt Turner wrote: > On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > wrote: >> On 20 March 2017 at 18:30, Matt Turner wrote: >>> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov

[Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

CP DMA and PKT3_WRITE_DATA (in CmdUpdateBuffer) don't (currently) write through L2. Therefore, to make these writes visible to later accesses we must invalidate L2 rather than just writing it back, to avoid the possibility that stale data is read through L2. Cc: "17.0"

[Mesa-dev] [PATCH] swr: [rasterizer jitter] fix llvm >= 5.0 build break

Function::getArgumentList() doesn't exist anymore, switch to using arg_begin() (existed back to at least llvm-3.6.0). CC: --- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 2 +- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 +-

[Mesa-dev] [PATCH] st/mesa: EGLImageTarget error handling

Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. Signed-off-by: Philipp Zabel --- EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe driver's

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hey Dylan, I've just a few points, since I'm not too enthused by the prospect of having to deal with yet another build system with yet another slightly different syntax. But ultimately this is only a "my 2 cents" e-mail, since others are way deeper involved with Mesa and their opinion is what

Re: [Mesa-dev] [PATCH 063/140] amd: resolve remaining definition conflicts with gfx9d.h

On Tue, Mar 21, 2017 at 4:50 PM, Marek Olšák wrote: > On Tue, Mar 21, 2017 at 10:03 AM, Nicolai Hähnle wrote: >> On 20.03.2017 23:43, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Add _GFX6 and _GFX9 suffixes to conflicting

Re: [Mesa-dev] [PATCH 136/140] radeon/vce: add support for firmware 53.14.4

On 03/21/2017 09:54 AM, Alex Deucher wrote: On Tue, Mar 21, 2017 at 9:46 AM, Marek Olšák wrote: On Tue, Mar 21, 2017 at 7:49 AM, Christian König wrote: Am 20.03.2017 um 23:49 schrieb Marek Olšák: From: Leo Liu Signed-off-by:

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Quoting Jani Nikula (2017-03-21 07:44:55) > On Thu, 16 Mar 2017, Dylan Baker wrote: > > First it's written in python, [...] > > How does meson handle python 2 vs. 3? How do you avoid issues in the > build files wrt this? On Debian meson seems to depend on python 3, so > are

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

I would personally rather have scons and autotools than cmake. I've had the misfortune of using all three, and cmake is not an improvement in my opinion. Quoting Grazvydas Ignotas (2017-03-21 08:13:31) > It might make sense to give more attention to cmake just because many > mesa-related projects

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Mon, Mar 20, 2017 at 10:10 PM, Jonathan Gray wrote: > On Mon, Mar 20, 2017 at 11:30:25AM -0700, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> wrote: >> > Seems like we ended up all over the place, so let me try afresh. >> >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Mon, Mar 20, 2017 at 10:00 PM, Jonathan Gray wrote: > On Tue, Mar 21, 2017 at 08:28:22AM +1100, Timothy Arceri wrote: >> >> >> On 21/03/17 06:39, Emil Velikov wrote: >> > On 20 March 2017 at 18:30, Matt Turner wrote: >> > > On Mon, Mar 20, 2017 at 6:55 AM,

Re: [Mesa-dev] [PATCH 139/140] radeon/vce: update vce support to firmware 53.19.4

On 03/21/2017 02:51 AM, Christian König wrote: Am 20.03.2017 um 23:49 schrieb Marek Olšák: From: Leo Liu Signed-off-by: Leo Liu Ah, here it is. This one and the change to version 53.17 should be squashed with the change to 53.14. With that done the

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov wrote: > On 20 March 2017 at 18:30, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> wrote: >>> Seems like we ended up all over the place, so let me try

Re: [Mesa-dev] [PATCH 139/140] radeon/vce: update vce support to firmware 53.19.4

On Tue, Mar 21, 2017 at 4:49 PM, Leo Liu wrote: > > > On 03/21/2017 02:51 AM, Christian König wrote: >> >> Am 20.03.2017 um 23:49 schrieb Marek Olšák: >>> >>> From: Leo Liu >>> >>> Signed-off-by: Leo Liu >> >> >> Ah, here it is. This one and

Re: [Mesa-dev] [PATCH 063/140] amd: resolve remaining definition conflicts with gfx9d.h

On Tue, Mar 21, 2017 at 10:03 AM, Nicolai Hähnle wrote: > On 20.03.2017 23:43, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Add _GFX6 and _GFX9 suffixes to conflicting definitions. >> >> sid.h and gfx9d.h can now be included in the same file. > > >

  1   2   >