Re: [Mesa-dev] Backporting bufmgr fixes to libdrm_intel (Was Re: [PATCH 6/9] i965/bufmgr: Garbage-collect vma cache/pruning)

2017-04-10 Thread Kenneth Graunke
On Monday, April 10, 2017 7:11:18 AM PDT Emil Velikov wrote: > Hi all, > > On 10 April 2017 at 08:18, Kenneth Graunke wrote: > > From: Daniel Vetter > > > > This was done because the kernel has 1 global address space, shared > > with all render

Re: [Mesa-dev] [PATCH] i965/fs: Take into account lower frequency of conditional blocks in spilling cost heuristic.

2017-04-10 Thread Kenneth Graunke
On Monday, April 10, 2017 5:23:20 PM PDT Francisco Jerez wrote: > The individual branches of an if/else/endif construct will be executed > some unknown number of times between 0 and 1 relative to the parent > block. Use some factor in between as weight while approximating the > cost of spill/fill

[Mesa-dev] [PATCH] anv/allocator: Add a BO cache

2017-04-10 Thread Jason Ekstrand
This cache allows us to easily ensure that we have a unique anv_bo for each gem handle. We'll need this in order to support multiple-import of memory objects and semaphores. v2 (Jason Ekstrand): - Reject BO imports if the size doesn't match the prime fd size as reported by lseek(). v3

Re: [Mesa-dev] [PATCH] i965/fs: Take into account lower frequency of conditional blocks in spilling cost heuristic.

2017-04-10 Thread Jason Ekstrand
On Mon, Apr 10, 2017 at 5:23 PM, Francisco Jerez wrote: > The individual branches of an if/else/endif construct will be executed > some unknown number of times between 0 and 1 relative to the parent > block. Use some factor in between as weight while approximating the >

[Mesa-dev] [PATCH] mesa/st: remove _mesa_get_fallback_texture() calls

2017-04-10 Thread Timothy Arceri
These calls look like leftover from fallback texture support first being added to the st in 8f6d9e12be0be and then later being added to core mesa in 00e203fe17cbf21. The piglit test fp-incomplete-tex continues to work with this change. --- src/mesa/state_tracker/st_atom_sampler.c | 8 ++--

Re: [Mesa-dev] [PATCH V3 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

2017-04-10 Thread Brian Paul
On 04/10/2017 06:09 PM, Timothy Arceri wrote: On 11/04/17 03:11, Brian Paul wrote: On 04/07/2017 09:21 PM, Timothy Arceri wrote: This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. V2: dereference any

Re: [Mesa-dev] [PATCH] mesa: use pre_hashed version of search for the mesa hash table

2017-04-10 Thread Eric Anholt
Timothy Arceri writes: > The key is just an unsigned int so there is never any real hashing > done. > --- > src/mesa/main/hash.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c > index

[Mesa-dev] [PATCH] mesa/st: only update samplers for stages that have changed

2017-04-10 Thread Timothy Arceri
Might helper reduce cpu for some apps that use sso. --- src/mesa/state_tracker/st_atom.h | 6 +- src/mesa/state_tracker/st_atom_list.h| 8 ++- src/mesa/state_tracker/st_atom_sampler.c | 94 ++-- src/mesa/state_tracker/st_program.c | 14 ++--- 4 files

[Mesa-dev] [PATCH] mesa: use pre_hashed version of search for the mesa hash table

2017-04-10 Thread Timothy Arceri
The key is just an unsigned int so there is never any real hashing done. --- src/mesa/main/hash.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 670438a..eb25d88 100644 --- a/src/mesa/main/hash.c +++

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-04-10 Thread Dylan Baker
Quoting Dylan Baker (2017-04-10 11:50:36) > Quoting Nirbheek Chauhan (2017-04-10 06:59:02) > > Hello Jose, > > > > On Mon, Apr 10, 2017 at 5:41 PM, Jose Fonseca wrote: > > > I've been trying to get native mingw to build. (It's still important to > > > prototype mesademos

Re: [Mesa-dev] [PATCH] addrlib: don't use linear aligned when pow2Pad is selected.

2017-04-10 Thread Dave Airlie
On 4 April 2017 at 19:11, Marek Olšák wrote: > Why don't you set disableLinearOpt instead? That seems like the wrong answer. Can the hardware do mipmaps with the base level in linear aligned format, but the other levels 1D tiled? If not why does addrlib give me that as a

[Mesa-dev] [PATCH] i965/fs: Take into account lower frequency of conditional blocks in spilling cost heuristic.

2017-04-10 Thread Francisco Jerez
The individual branches of an if/else/endif construct will be executed some unknown number of times between 0 and 1 relative to the parent block. Use some factor in between as weight while approximating the cost of spill/fill instructions within a conditional if-else branch. This favors spilling

Re: [Mesa-dev] [PATCH V3 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

2017-04-10 Thread Timothy Arceri
On 11/04/17 03:11, Brian Paul wrote: On 04/07/2017 09:21 PM, Timothy Arceri wrote: This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. V2: dereference any existing fb attachments and actually attach the

[Mesa-dev] [PATCH 2/4] radv: Rename query pipeline/set layout.

2017-04-10 Thread Bas Nieuwenhuizen
For using them with both occlusion and pipeline statistics queries. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_private.h | 4 ++-- src/amd/vulkan/radv_query.c | 22 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 3/4] radv: Let count be dynamic in radv_break_on_count.

2017-04-10 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_query.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c index cfe16a9d0e2..dc1844adb51 100644 --- a/src/amd/vulkan/radv_query.c +++

[Mesa-dev] [PATCH 4/4] radv: Implement pipeline statistics queries.

2017-04-10 Thread Bas Nieuwenhuizen
The devil is in the shader again, otherwise this is fairly straightforward. The CTS contains no pipeline statistics copy to buffer testcases, so I did a basic smoketest. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_private.h

[Mesa-dev] [PATCH 1/4] radv: Use VK_WHOLE_SIZE for the query buffer bindings.

2017-04-10 Thread Bas Nieuwenhuizen
The buffer sizes are specified just a few lines earlier, so don't repeat ourselves. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_query.c

Re: [Mesa-dev] [PATCH 1/3] glsl: use the BA1 macro for textureCubeArrayShadow()

2017-04-10 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 11/04/17 03:23, Samuel Pitoiset wrote: For both consistency and new bindless sampler types. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 11 ++- 1 file changed,

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

2017-04-10 Thread Samuel Pitoiset
Karol told me that over IRC. Introducing ->getIsa() looks good to me. On 04/11/2017 01:01 AM, Ilia Mirkin wrote: I wanted to flip things over and use smxx notation... On Apr 10, 2017 6:20 PM, "Samuel Pitoiset" > wrote: Not

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

2017-04-10 Thread Ilia Mirkin
I wanted to flip things over and use smxx notation... On Apr 10, 2017 6:20 PM, "Samuel Pitoiset" wrote: > Not sure why you get confused here. The chipset names are globally > consistent inside the codegen part and we never use SMxx. Maybe add a > comment like: > >

Re: [Mesa-dev] [PATCH] anv/pass: Initialize anv_pass::subpass_attachments

2017-04-10 Thread Jason Ekstrand
On Mon, Apr 10, 2017 at 3:13 PM, Nanley Chery wrote: > On Mon, Apr 10, 2017 at 01:31:52PM -0700, Nanley Chery wrote: > > Fixes 0039d0cf278 "anv/pass: Use anv_multialloc for allocating the > anv_pass" > > > > Signed-off-by: Nanley Chery > > --- >

Re: [Mesa-dev] [PATCH 0/5] use atomics for reference counting

2017-04-10 Thread Timothy Arceri
Hi, I've been looking into this recently also. Unfortunately I don't think these will get applied as is. These changes have been submitted before but rejected because they make existing race conditions worse. We really need to fix those first, I really think we are going to need some

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

2017-04-10 Thread Chad Versace
On Tue 04 Apr 2017, Kenneth Graunke wrote: > This series imports libdrm_intel into the i965 driver, hacks and > slashes it down to size, and greatly simplifies our relocation > handling. You did it! IT'S FINALLY HAPPENING!!! Thanks for taking the leap. >

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

2017-04-10 Thread Samuel Pitoiset
Not sure why you get confused here. The chipset names are globally consistent inside the codegen part and we never use SMxx. Maybe add a comment like: #define NVISA_GK104_CHIPSET0xe0 /* SM30 */ If you really need this? On 04/10/2017 11:41 PM, Matthew Mondazzi wrote: Define references to

Re: [Mesa-dev] [PATCH 0/9] nvc0: ARB_shader_ballot for Kepler+ (v3)

2017-04-10 Thread Samuel Pitoiset
Series is: Reviewed-by: Samuel Pitoiset Thanks! On 04/10/2017 04:55 PM, Boyan Ding wrote: This is the third, and hopefully the last revision of ballot series. This series mainly incorporates Ilia's feedback, with some fixes, more check and code cleanup. Please

Re: [Mesa-dev] [PATCH] anv/pass: Initialize anv_pass::subpass_attachments

2017-04-10 Thread Nanley Chery
On Mon, Apr 10, 2017 at 01:31:52PM -0700, Nanley Chery wrote: > Fixes 0039d0cf278 "anv/pass: Use anv_multialloc for allocating the anv_pass" > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_pass.c | 1 + > 1 file changed, 1 insertion(+) > I rescind my

[Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

2017-04-10 Thread Matthew Mondazzi
Define references to chipset did not actually use chipset, leading to confusion. More relevant ISA constants put in place of chipset compares. Signed-off-by: Matthew Mondazzi --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 7 ++--

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-10 Thread Marek Olšák
Pushed the series, thanks! Marek On Mon, Apr 10, 2017 at 10:04 PM, Constantine Kharlamov wrote: > The idea is taken from radeonsi. The code mostly was already checking for null > pixel shader, so little checks had to be added. > > Interestingly, acc. to testing with GTAⅣ,

Re: [Mesa-dev] [PATCH] mesa: use single memcpy when strides match

2017-04-10 Thread Brian Paul
Pushed, with slightly more descriptive commit msg. -Brian On 04/10/2017 12:31 PM, Bartosz Tomczyk wrote: v2: fix indentation --- src/mesa/main/readpix.c | 15 ++- src/mesa/main/texstore.c | 15 +++ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH] anv/pass: Initialize anv_pass::subpass_attachments

2017-04-10 Thread Nanley Chery
Fixes 0039d0cf278 "anv/pass: Use anv_multialloc for allocating the anv_pass" Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index

[Mesa-dev] [PATCH 1/5] mesa/arrayobj: use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
--- src/mesa/main/arrayobj.c | 16 src/mesa/main/mtypes.h | 2 -- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index ab1b834b6d..39bdb2e715 100644 --- a/src/mesa/main/arrayobj.c +++

[Mesa-dev] [PATCH 3/5] mesa/renderbuffer: use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
--- src/mesa/main/fbobject.c | 1 - src/mesa/main/mtypes.h | 1 - src/mesa/main/renderbuffer.c | 15 +++ 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index d486d01195..f85f26674d 100644 ---

[Mesa-dev] [PATCH 4/5] mesa/samplerobj: use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
--- src/mesa/main/mtypes.h | 1 - src/mesa/main/samplerobj.c | 16 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d37a60d61c..5a1be17a92 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@

[Mesa-dev] [PATCH 5/5] mesa/texobj: use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
--- src/mesa/main/mtypes.h | 1 - src/mesa/main/texobj.c | 19 --- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5a1be17a92..a1eabc8bf1 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@

[Mesa-dev] [PATCH 2/5] mesa/pipelineobj: use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
--- src/mesa/main/mtypes.h | 2 -- src/mesa/main/pipelineobj.c | 16 src/mesa/main/shaderapi.c | 2 -- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5de464cc1b..8b1577dd3f 100644 ---

[Mesa-dev] [PATCH 0/5] use atomics for reference counting

2017-04-10 Thread Bartosz Tomczyk
Bartosz Tomczyk (5): mesa/arrayobj: use atomics for reference counting mesa/pipelineobj: use atomics for reference counting mesa/renderbuffer: use atomics for reference counting mesa/samplerobj: use atomics for reference counting mesa/texobj: use atomics for reference counting

[Mesa-dev] [PATCH 0/3 v3] r600g: shader logic improvements

2017-04-10 Thread Constantine Kharlamov
Although I didn't see a statistically significant change in GTAⅣ benchmark, it seem to have reduced stall for opening the door from a house to the outer world at the first savepoint. No changes in gpu.py tests of piglit in gbm mode. v2: In the 1-st patch was occasionally removed empty line.

[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-10 Thread Constantine Kharlamov
The idea is taken from radeonsi. The code mostly was already checking for null pixel shader, so little checks had to be added. Interestingly, acc. to testing with GTAⅣ, though binding of null shader happens a lot at the start (then just stops), but draw_vbo() never actually sees null ps. v2:

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

2017-04-10 Thread Constantine Kharlamov
Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov Reviewed-by: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 +

[Mesa-dev] [PATCH 1/3 v3] r600g: skip repeating vs, gs, and tes shader binds

2017-04-10 Thread Constantine Kharlamov
The idea is taken from radeonsi. The code lacks some checks for null vs, and I'm unsure about some changes against that, so I left it in place. Some statistics for GTAⅣ: Average tesselation bind skip per frame: ≈350 Average geometric shaders bind skip per frame: ≈260 Skip of binding vertex ones

Re: [Mesa-dev] [PATCH] mesa: use single memcpy when strides matches

2017-04-10 Thread Bartosz Tomczyk
Please do, I don't have commits rights. On 10.04.2017 20:44, Brian Paul wrote: On 04/10/2017 12:35 PM, Bartosz Tomczyk wrote: Yes, I tested with Piglit, there is no regression. Do you need me to push this for you? -Brian On 10.04.2017 19:16, Brian Paul wrote: On 04/09/2017 07:58 AM,

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-04-10 Thread Dylan Baker
Quoting Nirbheek Chauhan (2017-04-10 06:59:02) > Hello Jose, > > On Mon, Apr 10, 2017 at 5:41 PM, Jose Fonseca wrote: > > I've been trying to get native mingw to build. (It's still important to > > prototype mesademos with MSVC to ensure meson is up to the task, but long >

Re: [Mesa-dev] [PATCH] mesa: use single memcpy when strides matches

2017-04-10 Thread Brian Paul
On 04/10/2017 12:35 PM, Bartosz Tomczyk wrote: Yes, I tested with Piglit, there is no regression. Do you need me to push this for you? -Brian On 10.04.2017 19:16, Brian Paul wrote: On 04/09/2017 07:58 AM, Bartosz Tomczyk wrote: --- src/mesa/main/readpix.c | 15 ++-

Re: [Mesa-dev] [PATCH] mesa: use single memcpy when strides matches

2017-04-10 Thread Bartosz Tomczyk
Yes, I tested with Piglit, there is no regression. On 10.04.2017 19:16, Brian Paul wrote: On 04/09/2017 07:58 AM, Bartosz Tomczyk wrote: --- src/mesa/main/readpix.c | 15 ++- src/mesa/main/texstore.c | 15 +++ 2 files changed, 21 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH] mesa: use single memcpy when strides match

2017-04-10 Thread Bartosz Tomczyk
v2: fix indentation --- src/mesa/main/readpix.c | 15 ++- src/mesa/main/texstore.c | 15 +++ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 25823230d6..606d1e58e5 100644 --- a/src/mesa/main/readpix.c

Re: [Mesa-dev] [PATCH] vc4: Optimizing vc4_load_utile/vc4_store_utile with sse for x86 build

2017-04-10 Thread Eric Anholt
mas...@eltechs.com writes: > From: Maxim Maslov The commit message needs some explanation of why we would want that (given that 2835 is an ARM) and some performance data justifying the change. > > --- src/gallium/drivers/vc4/vc4_tiling_lt.c | 93

[Mesa-dev] [PATCH] vc4: Optimizing vc4_load_utile/vc4_store_utile with sse for x86 build

2017-04-10 Thread maslov
From: Maxim Maslov --- src/gallium/drivers/vc4/vc4_tiling_lt.c | 93 +++-- 1 file changed, 90 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_tiling_lt.c b/src/gallium/drivers/vc4/vc4_tiling_lt.c index c9cbc65..d291262

Re: [Mesa-dev] [PATCH 9/9] i965/drm: Add stall warnings when mapping or waiting on BOs.

2017-04-10 Thread Chris Wilson
On Mon, Apr 10, 2017 at 10:29:50AM -0700, Kenneth Graunke wrote: > On Monday, April 10, 2017 1:31:11 AM PDT Chris Wilson wrote: > > In general, does 10us resolution require compensation for clock_gettime() > > overhead and checking against clock_getres()? > > FWIW, I copied the 10us threshold

Re: [Mesa-dev] [PATCH 9/9] i965/drm: Add stall warnings when mapping or waiting on BOs.

2017-04-10 Thread Kenneth Graunke
On Monday, April 10, 2017 1:31:11 AM PDT Chris Wilson wrote: > On Mon, Apr 10, 2017 at 10:09:17AM +0200, Daniel Vetter wrote: > > On Mon, Apr 10, 2017 at 12:18:54AM -0700, Kenneth Graunke wrote: > > > diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c > > >

[Mesa-dev] [PATCH 3/3] glsl: use the BA1 macro for textureQueryLevels()

2017-04-10 Thread Samuel Pitoiset
For both consistency and new bindless sampler types. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 65 + 1 file changed, 33 insertions(+), 32 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] glsl: use the BA1 macro for textureSamples()

2017-04-10 Thread Samuel Pitoiset
For both consistency and new bindless sampler types. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH 1/3] glsl: use the BA1 macro for textureCubeArrayShadow()

2017-04-10 Thread Samuel Pitoiset
For both consistency and new bindless sampler types. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

2017-04-10 Thread Charles, Daniel
On Wed, Apr 5, 2017 at 11:27 AM, Kristian Høgsberg wrote: > On Wed, Apr 5, 2017 at 11:11 AM, Jason Ekstrand wrote: >> On Wed, Apr 5, 2017 at 11:03 AM, Emil Velikov >> wrote: >>> >>> On 5 April 2017 at 18:55, Daniel Vetter

Re: [Mesa-dev] [PATCH] mesa: use single memcpy when strides matches

2017-04-10 Thread Brian Paul
On 04/09/2017 07:58 AM, Bartosz Tomczyk wrote: --- src/mesa/main/readpix.c | 15 ++- src/mesa/main/texstore.c | 15 +++ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 25823230d6..14568de497

Re: [Mesa-dev] [PATCH V3 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

2017-04-10 Thread Brian Paul
On 04/07/2017 09:21 PM, Timothy Arceri wrote: This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. V2: dereference any existing fb attachments and actually attach the new rb. v3: split out

[Mesa-dev] [PATCH 07/12] swr: [rasterizer common/core] Fix 32-bit windows build

2017-04-10 Thread Tim Rowley
--- .../drivers/swr/rasterizer/common/simd16intrin.h | 198 +++-- src/gallium/drivers/swr/rasterizer/core/clip.h | 6 +- src/gallium/drivers/swr/rasterizer/core/context.h | 2 +- .../swr/rasterizer/core/format_conversion.h| 8 +-

[Mesa-dev] [PATCH 08/12] swr: [rasterizer jitter] Remove HAVE_LLVM tests supporting llvm < 3.8

2017-04-10 Thread Tim Rowley
--- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 10 --- .../drivers/swr/rasterizer/jitter/JitManager.h | 6 - .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 31 -- .../drivers/swr/rasterizer/jitter/builder_misc.h | 5 4 files changed, 52

[Mesa-dev] [PATCH 10/12] swr: [rasterizer archrast] Fix archrast for MSVC 2017 compiler

2017-04-10 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/archrast/archrast.cpp | 2 +- src/gallium/drivers/swr/rasterizer/archrast/archrast.h| 2 +- src/gallium/drivers/swr/rasterizer/archrast/eventmanager.h| 2 +-

[Mesa-dev] [PATCH 12/12] swr: [rasterizer core] Disable 8x2 tile backend

2017-04-10 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h b/src/gallium/drivers/swr/rasterizer/core/knobs.h index e347558..7928f5d 100644 ---

[Mesa-dev] [PATCH 11/12] swr: [rasterizer common] Add _simd_testz_si alias

2017-04-10 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/simdintrin.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdintrin.h b/src/gallium/drivers/swr/rasterizer/common/simdintrin.h index 1e3f14c..61c0c54 100644 ---

[Mesa-dev] [PATCH 09/12] swr: [rasterizer jitter] Remove unused function

2017-04-10 Thread Tim Rowley
--- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 34 -- .../drivers/swr/rasterizer/jitter/JitManager.h | 1 - 2 files changed, 35 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp

[Mesa-dev] [PATCH 06/12] swr: [rasterizer core] Fix unused variable warnings

2017-04-10 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 2 +- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 1 - src/gallium/drivers/swr/rasterizer/core/binner.cpp | 8 3 files changed, 1 insertion(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 02/12] swr: [rasterizer core] Multisample sample position setup change

2017-04-10 Thread Tim Rowley
--- .../drivers/swr/rasterizer/codegen/gen_backends.py | 25 -- .../drivers/swr/rasterizer/core/multisample.cpp| 44 +- .../drivers/swr/rasterizer/core/multisample.h | 98 -- 3 files changed, 92 insertions(+), 75 deletions(-) diff --git

[Mesa-dev] [PATCH 01/12] swr: [rasterizer core] Reduce templates to speed compile

2017-04-10 Thread Tim Rowley
Quick patch to remove some unused template params to cut down rasterizer compile time. --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 8 +-- .../drivers/swr/rasterizer/core/rasterizer.cpp | 6 +- .../drivers/swr/rasterizer/core/rasterizer.h | 67 +- 3

[Mesa-dev] [PATCH 05/12] swr: [rasterizer core] Code formating change

2017-04-10 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/state.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/state.h b/src/gallium/drivers/swr/rasterizer/core/state.h index eec68cd..535b85e 100644 ---

[Mesa-dev] [PATCH 03/12] swr: [rasterizer core] SIMD16 Frontend WIP - Clipper

2017-04-10 Thread Tim Rowley
Implement widened clipper for SIMD16. --- .../drivers/swr/rasterizer/common/simd16intrin.h | 41 +- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 17 +- src/gallium/drivers/swr/rasterizer/core/clip.cpp | 91 +- src/gallium/drivers/swr/rasterizer/core/clip.h | 1027

[Mesa-dev] [PATCH 04/12] swr: [rasterizer core] SIMD16 Frontend WIP - PA

2017-04-10 Thread Tim Rowley
Fix PA NextPrim for SIMD8 on SIMD16. --- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 44 +++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp b/src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp index

[Mesa-dev] [PATCH 00/12] swr: update rasterizer

2017-04-10 Thread Tim Rowley
Highlights; compile time fix, simd16 work, code cleanup. Tim Rowley (12): swr: [rasterizer core] Reduce templates to speed compile swr: [rasterizer core] Multisample sample position setup change swr: [rasterizer core] SIMD16 Frontend WIP - Clipper swr: [rasterizer core] SIMD16 Frontend

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-10 Thread Marek Olšák
For patches 2-3: Reviewed-by: Marek Olšák Marek On Mon, Apr 10, 2017 at 11:44 AM, Constantine Kharlamov wrote: > If that helps, I can split this patch to two: α) Adding checks for null ps, > and β) removing the dummy ps. I didn't do that originally,

Re: [Mesa-dev] [PATCH 1/3 v2] r600g: skip repeating vs, gs, and tes shader binds

2017-04-10 Thread Marek Olšák
On Sun, Apr 9, 2017 at 11:09 PM, Constantine Kharlamov wrote: > The idea is taken from radeonsi. The code lacks some checks for null vs, > and I'm unsure about some changes against that, so I left it in place. > > Some statistics for GTAⅣ: > Average tesselation bind skip per

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-04-10 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Apr 10, 2017 at 11:49 AM, Samuel Pitoiset wrote: > Only the Radeon kernel driver exposed the GPU temperature and > the shader/memory clocks, this implements the same functionality > for the

Re: [Mesa-dev] [PATCH 2/2] vbo: fix gl_DrawID handling in glMultiDrawArrays

2017-04-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Apr 7, 2017 at 6:30 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes a bug in > KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. > --- >

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add new si_check_render_feedback_texture() helper

2017-04-10 Thread Marek Olšák
Other than my comment on patch 3, the series is: Reviewed-by: Marek Olšák Marek On Thu, Apr 6, 2017 at 12:07 AM, Samuel Pitoiset wrote: > For bindless. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 3/5] radeonsi: add new is_depth_texture() helper

2017-04-10 Thread Marek Olšák
On Thu, Apr 6, 2017 at 12:07 AM, Samuel Pitoiset wrote: > For bindless. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff

[Mesa-dev] [PATCH] intel/blorp: Add a blorp_emit_dynamic macro

2017-04-10 Thread Jason Ekstrand
This makes it much easier to throw together a bit of dynamic state. It also automatically handles flushing so you don't accidentally forget. --- src/intel/blorp/blorp_genX_exec.h | 114 +- 1 file changed, 50 insertions(+), 64 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] ac: add unreachable() in ac_build_image_opcode()

2017-04-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Apr 7, 2017 at 6:44 PM, Samuel Pitoiset wrote: > To silent the following compiler warning: > > common/ac_llvm_build.c: In function ‘ac_build_image_opcode’: > common/ac_llvm_build.c:1080:3: warning: ‘name’

Re: [Mesa-dev] [PATCH] radeonsi: fix gl_BaseVertex value in non-indexed draws

2017-04-10 Thread Marek Olšák
Hi Nicolai, I think there is a simpler way to do this. Instead of going through update_shaders, we can just set some bit in a user data SGPR e.g. SI_SGPR_VS_STATE_BITS[1] and the vertex shader can clear gl_BaseVertex based on that bit. There is no performance concern due to additional

[Mesa-dev] [PATCH v3 8/9] nvc0/ir: Implement TGSI_OPCODE_BALLOT and TGSI_OPCODE_READ_*

2017-04-10 Thread Boyan Ding
v2: Check if each channel is masked in TGSI_OPCODE_BALLOT (Ilia Mirkin) Signed-off-by: Boyan Ding --- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 31 ++ 1 file changed, 31 insertions(+) diff --git

[Mesa-dev] [PATCH v3 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

2017-04-10 Thread Boyan Ding
readInvocationARB() and readFirstInvocationARB() need SHFL.IDX instruction which is introduced in Kepler. Reviewed-by: Ilia Mirkin Signed-off-by: Boyan Ding --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html

[Mesa-dev] [PATCH v3 5/9] nvc0/ir: Allow 0/1 immediate value as source of OP_VOTE

2017-04-10 Thread Boyan Ding
Implementation of readFirstInvocationARB() on nvidia hardware needs a ballotARB(true) used to decide the first active thread. This expressed in gm107 asm as (supposing output is $r0): vote any $r0 0x1 0x1 To model the always true input, which corresponds to the second 0x1 above, we make

[Mesa-dev] [PATCH v3 2/9] nvc0/ir: Properly handle a "split form" of predicate destination

2017-04-10 Thread Boyan Ding
GF100's ISA encoding has a weird form of predicate destination where its 3 bits are split across whole the instruction. Use a dedicated setPDSTL function instead of original defId which is incorrect in this case. v2: (Ilia Mirkin) Change API of setPDSTL() to handle cases of no output Fix setting

[Mesa-dev] [PATCH v3 6/9] nvc0/ir: Add SV_LANEMASK_* system values.

2017-04-10 Thread Boyan Ding
v2: Add name strings in nv50_ir_print.cpp (Ilia Mirkin) Signed-off-by: Boyan Ding --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 +

[Mesa-dev] [PATCH v3 7/9] nvc0/ir: Implement TGSI_SEMANTIC_SUBGROUP_*

2017-04-10 Thread Boyan Ding
Reviewed-by: Ilia Mirkin Signed-off-by: Boyan Ding --- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 ++ 1 file changed, 27 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp

[Mesa-dev] [PATCH v3 3/9] nvc0/ir: Emit OP_SHFL

2017-04-10 Thread Boyan Ding
v2: (Samuel Pitoiset) Add an assertion to check if the target is Kepler Make sure that asImm() is not NULL v3: (Ilia Mirkin) Check the range of immediate value of OP_SHFL Use the new setPDSTL API Signed-off-by: Boyan Ding ---

[Mesa-dev] [PATCH v3 4/9] gk110/ir: Emit OP_SHFL

2017-04-10 Thread Boyan Ding
v2: Make sure that asImm() is not NULL (Samuel Pitoiset) v3: Check the range of immediate in OP_SHFL (Ilia Mirkin) Signed-off-by: Boyan Ding --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 56 ++ 1 file changed, 56 insertions(+) diff --git

[Mesa-dev] [PATCH v3 1/9] gm107/ir: Emit third src 'bound' and optional predicate output of SHFL

2017-04-10 Thread Boyan Ding
v2: Emit the original hard-coded 0x1c03 when OP_SHFL is used in gm107's lowering (Samuel Pitoiset) Signed-off-by: Boyan Ding --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 23 ++ .../nouveau/codegen/nv50_ir_lowering_gm107.cpp | 15

[Mesa-dev] [PATCH 0/9] nvc0: ARB_shader_ballot for Kepler+ (v3)

2017-04-10 Thread Boyan Ding
This is the third, and hopefully the last revision of ballot series. This series mainly incorporates Ilia's feedback, with some fixes, more check and code cleanup. Please review. Boyan Ding (9): gm107/ir: Emit third src 'bound' and optional predicate output of SHFL nvc0/ir: Properly handle a

[Mesa-dev] Backporting bufmgr fixes to libdrm_intel (Was Re: [PATCH 6/9] i965/bufmgr: Garbage-collect vma cache/pruning)

2017-04-10 Thread Emil Velikov
Hi all, On 10 April 2017 at 08:18, Kenneth Graunke wrote: > From: Daniel Vetter > > This was done because the kernel has 1 global address space, shared > with all render clients, for gtt mmap offsets, and that address space > was only 32bit on

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net

[Mesa-dev] [PATCH kmscube 1/2] gst-decoder.c: Only gst_is_dmabuf_memory() once

2017-04-10 Thread Carlos Rafael Giani
This prevents potential segfaults in case the buffer was merged and the mem pointer is then no longer valid Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c

[Mesa-dev] [PATCH kmscube 2/2] gst-video-appsink: Cleanup & add max-lateness & enable QoS

2017-04-10 Thread Carlos Rafael Giani
The QoS and max-lateness settings are copied from GstVideoSink, since here, the appsink subclass specifically handles video Signed-off-by: Carlos Rafael Giani --- gst-video-appsink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-04-10 Thread Nirbheek Chauhan
Hello Jose, On Mon, Apr 10, 2017 at 5:41 PM, Jose Fonseca wrote: > I've been trying to get native mingw to build. (It's still important to > prototype mesademos with MSVC to ensure meson is up to the task, but long > term, I think I'll push for dropping MSVC support from

Re: [Mesa-dev] [PATCH] nvc0: increase texture buffer object alignment to 256 for pre-GM107

2017-04-10 Thread Samuel Pitoiset
On 04/10/2017 02:33 PM, Ilia Mirkin wrote: I assume Pascal is the same as Maxwell. Using tic, it gets 16... Makes sense. Reviewed-by: Samuel Pitoiset On Apr 10, 2017 5:32 AM, "Samuel Pitoiset" >

Re: [Mesa-dev] [PATCH] nvc0: increase texture buffer object alignment to 256 for pre-GM107

2017-04-10 Thread Ilia Mirkin
I assume Pascal is the same as Maxwell. Using tic, it gets 16... On Apr 10, 2017 5:32 AM, "Samuel Pitoiset" wrote: > How about Pascal? > > On 04/08/2017 09:10 PM, Ilia Mirkin wrote: > >> We currently don't pass the low byte of the address via the surface >> info, so

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

2017-04-10 Thread Emil Velikov
On 10 April 2017 at 11:15, Juan A. Suarez Romero wrote: > On Fri, 2017-04-07 at 19:38 +0100, Emil Velikov wrote: >> On 7 April 2017 at 12:30, Juan A. Suarez Romero wrote: >> > Both scripts does not use a file with the commits to ignore. So if we >> >

Re: [Mesa-dev] [PATCH v2 0/4] intel/isl: Add support for emitting depth/stencil

2017-04-10 Thread Pohjolainen, Topi
On Fri, Apr 07, 2017 at 10:42:21PM -0700, Jason Ekstrand wrote: > This is mostly a re-send of previous patches. The two things that have > changed over the last version is that the first patch is now actually > correct for gen6. Prior to sending the original version, I tested it only > with

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-04-10 Thread Jose Fonseca
On 08/04/17 23:07, Jose Fonseca wrote: On 08/04/17 00:24, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-30 15:19:31) Cool. BTW, another alternative (for things like LLVM) would be to chain build systems (ie, have a wrap that builds LLVM invoking CMake) Jose I have no idea whether

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 İsmail Dönmez changed: What|Removed |Added CC||ism...@i10z.com --

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

2017-04-10 Thread Juan A. Suarez Romero
On Fri, 2017-04-07 at 19:38 +0100, Emil Velikov wrote: > On 7 April 2017 at 12:30, Juan A. Suarez Romero wrote: > > Both scripts does not use a file with the commits to ignore. So if we > > have handled one of the suggested commits and decided we won't pick it, > > the

[Mesa-dev] [PATCH 2/2] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-04-10 Thread Samuel Pitoiset
Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements the same functionality for the AMDGPU kernel driver. These queries will return 0 if the DRM version is less than 3.10, I don't explicitely check the version here because the query codepath is

  1   2   >