Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

2017-09-06 Thread Axel Davy
Hi, On 07/09/2017 00:35, Marek Olšák wrote: + /* Out-of-order rasterization can be enabled for these cases: +* +* - color-only rendering: +* + blending must be enabled and commutative +* + only when inexact behavior due to rounding is allowed +*

[Mesa-dev] [Bug 102571] vulkaninfo fails with "trap divide error"

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102571 Vinson Lee changed: What|Removed |Added Keywords||bisected,

Re: [Mesa-dev] [PATCH] mesa/main: Fix GetTransformFeedbacki64 for glTransformFeedbackBufferBase

2017-09-06 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Tue, 2017-09-05 at 14:41 +0200, Iago Toral Quiroga wrote: > The spec has special rules for querying buffer offsets and sizes > when BindBufferBase is used, described  in the OpenGL 4.6 spec, > section 6.8 Buffer Object State: > >   

[Mesa-dev] [Bug 102571] vulkaninfo fails with "trap divide error"

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102571 Bug ID: 102571 Summary: vulkaninfo fails with "trap divide error" Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH] radv/gfx9: allocate events from uncached VA space

2017-09-06 Thread Dave Airlie
From: Dave Airlie This copies what amdgpu-pro does, and allocates the memory for an event with an uncached mtype. This fixes hangs with: dEQP-VK.api.command_buffers.record_simul_use_primary Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-06 Thread Dave Airlie
From: Dave Airlie This fixes some observed hangs on CIK GPUs. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

2017-09-06 Thread Timothy Arceri
On 21/08/17 20:27, Emil Velikov wrote: From: Emil Velikov memmem() does not attribute what the character after the searched string is. Thus it will flag even when haystack is "foobar" while we're looking for "foo". Pull a small helper (based on piglit) that

[Mesa-dev] Mesa 17.2.0 missing git_sha1.h

2017-09-06 Thread dosse91
I'm trying to build Gallium using LLVM 4.0 on Windows, and it says that git_sha1.h is missing. Removing the include from version.c fixes the problem and Mesa compiles as usual. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 09/10] egl/x11: Match depth 30 RGB visuals to 32-bit RGBA EGLConfigs.

2017-09-06 Thread Mario Kleiner
On 09/06/2017 03:18 PM, Eric Engestrom wrote: On Tuesday, 2017-09-05 07:01:13 +0200, Mario Kleiner wrote: Similar to the matching of 24 bit RGB visuals to 32-bit RGBA EGLConfigs. Fixes failure of piglit egl tests to select ARGB2101010 visuals via eglChooseConfig() with EGL_ALPHA_BITS 2 on a

Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Tessellation shader micro-optimizations

2017-09-06 Thread Dieter Nützel
Dear relentless Marek, I've gave it a shot on 'Unigine Heaven' tessellation 'normal'. Not that I found any significant effects, like expected... So this series is: Tested-by: Dieter Nützel on RX580, too. Dieter Am 06.09.2017 19:03, schrieb Marek Olšák: Hi, This

Re: [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

2017-09-06 Thread Timothy Arceri
On 07/09/17 08:37, Marek Olšák wrote: Ping. On Sat, Sep 2, 2017 at 1:34 AM, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102502 Cc: 17.2 ---

Re: [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

2017-09-06 Thread Dieter Nützel
Hello Marek, go ahead. This is: Tested-by: Alexandre Demers Tested-by: Dieter Nützel Solve: https://bugs.freedesktop.org/show_bug.cgi?id=102502 Dieter Am 07.09.2017 00:37, schrieb Marek Olšák: Ping. On Sat, Sep 2, 2017 at 1:34 AM, Marek

Re: [Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

2017-09-06 Thread Matt Turner
On Wed, Sep 6, 2017 at 3:48 PM, Timothy Arceri wrote: > > On 07/09/17 06:59, Matt Turner wrote: >> >> I feel like the commit message is missing some important information. >> What does this fix? Do we have a piglit test? I don't see one from >> you. I see that someone has

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102530 Alexandre Demers changed: What|Removed |Added Status|NEEDINFO

[Mesa-dev] [Bug 102502] [bisected] Kodi crashes since commit 707d2e8b - gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102502 Alexandre Demers changed: What|Removed |Added Status|NEW

Re: [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

2017-09-06 Thread Alexandre Demers
You can add my tested-by to the patch. -- Alexandre Demers ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 2/2] mesa: allow user to set MESA_NO_ERROR=0

2017-09-06 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri Thanks! On 07/09/17 00:23, Eric Engestrom wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102530 Cc: Michel Dänzer Cc: Alexandre Demers Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] disk_cache: make the thread queue resizable and low priority

2017-09-06 Thread Timothy Arceri
Seems reasonable. Acked-by: Timothy Arceri On 07/09/17 08:20, Marek Olšák wrote: From: Marek Olšák --- src/util/disk_cache.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/util/disk_cache.c

Re: [Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

2017-09-06 Thread Timothy Arceri
On 04/09/17 13:33, Timothy Arceri wrote: Sent too early, this breaks a piglit test. I'll try to track down the issue and resend. Whoops, seems I replied to myself and not the list. I have a more comprehensive fix that unrolls even more loop variants in the works, I just need to track don't a

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-09-06 Thread Chema Casanova
Hi Connor and Curro, On 28/08/17 12:24, Alejandro Piñeiro wrote: > On 27/08/17 20:24, Connor Abbott wrote: >> Hi, >> >> On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" > > wrote: >> >> On 24/08/17 21:07, Connor Abbott wrote: >> > >> >

Re: [Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

2017-09-06 Thread Timothy Arceri
On 07/09/17 06:59, Matt Turner wrote: I feel like the commit message is missing some important information. What does this fix? Do we have a piglit test? I don't see one from you. I see that someone has replied with a Tested-by, so presumably they know what it's intended to fix. Huh??? Are

Re: [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

2017-09-06 Thread Marek Olšák
Ping. On Sat, Sep 2, 2017 at 1:34 AM, Marek Olšák wrote: > From: Marek Olšák > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102502 > > Cc: 17.2 > --- > src/mesa/state_tracker/st_draw.c | 7 ++- > 1 file

[Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

2017-09-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 143 +++- src/gallium/drivers/radeonsi/si_state.h | 10 +-

[Mesa-dev] [PATCH 2/2] ac/surface: add radeon_surf::has_stencil for convenience

2017-09-06 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_surface.c| 2 ++ src/amd/common/ac_surface.h| 1 + src/amd/vulkan/radv_device.c | 6 +++--- src/gallium/drivers/r600/evergreen_state.c | 2 +-

[Mesa-dev] [PATCH] winsys/amdgpu: disable local BOs on Raven

2017-09-06 Thread Marek Olšák
From: Marek Olšák It hangs with a high degree of reproducibility. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index

[Mesa-dev] [PATCH] disk_cache: make the thread queue resizable and low priority

2017-09-06 Thread Marek Olšák
From: Marek Olšák --- src/util/disk_cache.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index b789a45..33e4dc8 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -351,27

Re: [Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-09-06 Thread Thomas Helland
I'm busy until Sunday, but I'll see if I can find the time to address Nicolai's comments on Sunday evening. I've addressed the build issues with the tests, and the comment about using util_vsnprintf, so it's getting there. I've also done some general polishing on comments, etc. 6. sep. 2017

[Mesa-dev] [RFC] NIR serialization

2017-09-06 Thread Daniel Schürmann
Hello together! Recently, we had a small discussion (off the list) about the NIR serialization, which was previously discussed in [RFC] ARB_gl_spirv and NIR backend for radeonsi. As this topic could be interesting to more people, I would like to share, what was talked about so far (You might

[Mesa-dev] Mesa 17.1.9 release candidate

2017-09-06 Thread Andres Gomez
Hello list, The candidate for the Mesa 17.1.9 is now available. Currently we have:  - 27 queued  - 0 nominated (outstanding)  - and 3 rejected patches In the current queue we have: In Mesa Core we include a fix for a rendering problem detected while using GoogleEarth with the VMware driver.

Re: [Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-09-06 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel But do NOT apply on current git any longer. With Nicolai's comments addressed new version underway? ;-) Dieter Am 29.08.2017 21:56, schrieb Thomas Helland: This is a resend of the string buffer implementation and related patches

Re: [Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

2017-09-06 Thread Matt Turner
I feel like the commit message is missing some important information. What does this fix? Do we have a piglit test? I don't see one from you. I see that someone has replied with a Tested-by, so presumably they know what it's intended to fix. ___ mesa-dev

Re: [Mesa-dev] [PATCH 13/23] anv: Better support for Android logging

2017-09-06 Thread Chad Versace
On Sat 02 Sep 2017, Jason Ekstrand wrote: > This is going to conflict badly with tapani's work to implement > VK_EXT_debug_report (which I need to finish reviewing). Understood. It probably conflicts with other in-flight patches too. ___ mesa-dev

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

2017-09-06 Thread Chad Versace
On Mon 04 Sep 2017, Eero Tamminen wrote: > Hi, > > On 02.09.2017 11:17, Chad Versace wrote: > > I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). > > > > On Android, stdio goes to /dev/null. On Android, remote gdb is even more > > painful than the usual remote gdb. On

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

2017-09-06 Thread Chad Versace
On Tue 05 Sep 2017, Rob Herring wrote: > On Sat, Sep 2, 2017 at 3:17 AM, Chad Versace wrote: > > I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). > > > > On Android, stdio goes to /dev/null. On Android, remote gdb is even more > > painful than the

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

2017-09-06 Thread Chad Versace
On Sat 02 Sep 2017, Jason Ekstrand wrote: > n Sat, Sep 2, 2017 at 1:17 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > My goal here is not perfection. My goal is to make a minimal, clean API, > that people hate merely a little instead of a lot, and that's good > enough to

Re: [Mesa-dev] [PATCH] fixup! anv/android: Disable surface and swapchain extensions

2017-09-06 Thread Jason Ekstrand
On Wed, Sep 6, 2017 at 1:09 PM, Chad Versace wrote: > --- > > Jason, did you envision a cleanup like this? > Yes, this is better. Eventually, I think we can make it better. --Jason > src/intel/vulkan/anv_extensions.py | 18 +++--- > 1 file changed, 11

[Mesa-dev] [PATCH] fixup! anv/android: Disable surface and swapchain extensions

2017-09-06 Thread Chad Versace
--- Jason, did you envision a cleanup like this? src/intel/vulkan/anv_extensions.py | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index 18062359d31..747b36b71f5 100644 ---

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #11 from Gert Wollny --- Actually this patch seems to fixes some issues I had with some applications lately (specifically QtCreator didn't redraw properly and old screen content would show up instead).

[Mesa-dev] [Bug 102565] u_debug_stack.c:114: undefined reference to `_Ux86_64_getcontext'

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102565 --- Comment #2 from Gert Wollny --- A workaround is to compile with --disable-libunwind, a patch to correct the problem has been submitted to mesa-dev. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [PATCH 1/2] mesa/st/tests: Fix classic build regressions introduced with 7be6d8fe12

2017-09-06 Thread Gert Wollny
Fixes the build in classic only mode, i.e. the new state tracker tests are only build when Gallium is enabled. --- src/mesa/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am index 865735be27..f2097eb209 100644 ---

[Mesa-dev] [PATCH 2/2] mesa/st/tests: Fix regressions with libunwind enabled introduced with 7be6d8fe12

2017-09-06 Thread Gert Wollny
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102565 Add the according flags to link with libunwind. --- src/mesa/state_tracker/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/tests/Makefile.am b/src/mesa/state_tracker/tests/Makefile.am index

[Mesa-dev] glDrawBuffer crashes in case of surfaceless context

2017-09-06 Thread Volker Vogelhuber
I'm currently creating a surfaceless OpenGL context using the EGL_KHR_surfaceless_context extension together with eglGetPlatformDisplay/EGL_PLATFORM_GBM_MESA. So my default framebuffer has no real buffers. I normally only render to textures bound to FBOs. Due to an error on my side I called

[Mesa-dev] [PATCH] intel: Remove unused Kabylake pci id

2017-09-06 Thread Anuj Phogat
I missed this one in Mesa commit ebc5ccf. Signed-off-by: Anuj Phogat Cc: Matt Turner --- include/pci_ids/i965_pci_ids.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index

Re: [Mesa-dev] [PATCH 1/5] intel: Remove unused Kabylake pci ids

2017-09-06 Thread Anuj Phogat
On Tue, Sep 5, 2017 at 5:13 PM, Matt Turner wrote: > The series is > > Reviewed-by: Matt Turner > > I think It should be tagged for the stable branch as well. Does anyone > else have an opinion? Yes, I'll tag them for stable and send to mesa-stable. I

Re: [Mesa-dev] [PATCH v2] i965/fs: Define new shader opcode to set rounding modes

2017-09-06 Thread Chema Casanova
On 05/09/17 23:41, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Although it is possible to emit them directly as AND/OR on brw_fs_nir, >> having a specific opcode makes it easier to remove duplicate settings >> later. >> >> v2: (Curro) >> - Set thread control

[Mesa-dev] [Bug 102502] [bisected] Kodi crashes since commit 707d2e8b - gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102502 --- Comment #4 from Alexandre Demers --- (In reply to Dieter Nützel from comment #3) > Hello Alexandre, > > have you verified, that Marek's patch (fix) for this works? > > [Mesa-dev] [PATCH] st/mesa: skip draw

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #10 from Bruce Cherniak --- Tested-by: Bruce Cherniak -- You are receiving this mail because: You are the QA Contact for the bug.___

[Mesa-dev] [Bug 102502] [bisected] Kodi crashes since commit 707d2e8b - gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102502 --- Comment #3 from Dieter Nützel --- Hello Alexandre, have you verified, that Marek's patch (fix) for this works? [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

Re: [Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

2017-09-06 Thread Dieter Nützel
Tested-by: Dieter Nützel Dieter Am 04.09.2017 05:29, schrieb Timothy Arceri: This code incorrectly assumed that loop terminators will always be at the start of the loop. Fortunately we *seem* to avoid any bugs because the unrolling code loops over and correctly handles

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

2017-09-06 Thread Emil Velikov
On 6 September 2017 at 18:13, Marek Olšák wrote: > On Wed, Sep 6, 2017 at 2:08 PM, Emil Velikov wrote: >> On 6 September 2017 at 12:11, Marek Olšák wrote: >>> On Wed, Sep 6, 2017 at 1:02 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: be precise about merging scopes

2017-09-06 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel Am 06.09.2017 11:54, schrieb Nicolai Hähnle: From: Nicolai Hähnle enclosing_scope already contains enclosing_scope_first_read. What we really want to check here -- not for correctness, but for speed --

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102530 --- Comment #22 from Alexandre Demers --- (In reply to Emil Velikov from comment #21) > The attached patch from Alexandre seems to be a noop. > > This series from Eric treats MESA_NO_ERROR as boolean. >

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102564 Alex Granni changed: What|Removed |Added Version|unspecified |17.2 --- Comment

[Mesa-dev] [Bug 102565] u_debug_stack.c:114: undefined reference to `_Ux86_64_getcontext'

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102565 Vinson Lee changed: What|Removed |Added Keywords||bisected

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #9 from Dieter Nützel --- (In reply to Thomas Hellström from comment #4) > Created attachment 133985 [details] [review] > Patch that should fix the issue > > This patch fixes the issue on my side. Please

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

2017-09-06 Thread Marek Olšák
On Wed, Sep 6, 2017 at 2:08 PM, Emil Velikov wrote: > On 6 September 2017 at 12:11, Marek Olšák wrote: >> On Wed, Sep 6, 2017 at 1:02 PM, Marek Olšák wrote: >>> On Wed, Sep 6, 2017 at 12:38 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] radv: do not use a bitfield when dirtying the vertex buffers

2017-09-06 Thread Gustaw Smolarczyk
2017-09-06 15:53 GMT+02:00 Samuel Pitoiset : > Useless to track which one has been updated because we > re-upload all the vertex buffers in one shot. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- >

Re: [Mesa-dev] [PATCH 1/5] intel: Remove unused Kabylake pci ids

2017-09-06 Thread Anuj Phogat
On Tue, Sep 5, 2017 at 5:13 PM, Matt Turner wrote: > The series is > > Reviewed-by: Matt Turner > > I think It should be tagged for the stable branch as well. Does anyone > else have an opinion? > > I tested a KBL-R system (the 0x5917 PCI ID) with it set

[Mesa-dev] [PATCH 8/9] radeonsi: don't read tcs_out_lds_layout.vertex_size from an SGPR

2017-09-06 Thread Marek Olšák
From: Marek Olšák TCS outputs are usually not written to LDS, so no stats here. --- src/gallium/drivers/radeonsi/si_shader.c | 21 +++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 2 -- src/gallium/drivers/radeonsi/si_state_draw.c |

[Mesa-dev] [PATCH 9/9] radeonsi: don't read tcs_out_lds_layout.patch_stride from an SGPR

2017-09-06 Thread Marek Olšák
From: Marek Olšák Same as before, writing TCS outputs to LDS is rare. --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 7/9] radeonsi/gfx9: don't read LS out vertex stride from an SGPR in monolithic HS

2017-09-06 Thread Marek Olšák
From: Marek Olšák -44 bytes in a monolithic LS-HS binary. --- src/gallium/drivers/radeonsi/si_shader.c| 5 + src/gallium/drivers/radeonsi/si_state_shaders.c | 7 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/9] radeonsi: remove 2 callbacks from si_shader_context

2017-09-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 13 + src/gallium/drivers/radeonsi/si_shader_internal.h | 13 ++--- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 4 ++-- 3 files changed, 13 insertions(+), 17

[Mesa-dev] [PATCH 4/9] radeonsi: don't always apply the PrimID instancing bug workaround on SI

2017-09-06 Thread Marek Olšák
From: Marek Olšák It looks like commit 391673af7ad1565a5f6ac8fc2f8c9fcdd1fe9908 that should have fixed the perf regression didn't really change much if anything. --- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 6/9] radeonsi: don't read the LS output vertex stride from an SGPR in LS

2017-09-06 Thread Marek Olšák
From: Marek Olšák Now it's able to generate ds_write2_b64 instead of ds_write2_b32. -20 bytes in one shader binary. (having only 1 output) --- src/gallium/drivers/radeonsi/si_shader.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 5/9] radeonsi: don't read the number of TCS out vertices from an SGPR in TCS

2017-09-06 Thread Marek Olšák
From: Marek Olšák -16 bytes in one shader binary. --- src/gallium/drivers/radeonsi/si_shader.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH 0/9] RadeonSI: Tessellation shader micro-optimizations

2017-09-06 Thread Marek Olšák
Hi, This series seemed like a good idea and results in eliminations of shader instructions. However I haven't been able to find an app where it has a measurable effect. Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 3/9] radeonsi: optimize TCS epilog when invocation 0 writes tess factors

2017-09-06 Thread Marek Olšák
From: Marek Olšák This removes the barrier and LDS stores and loads for tess factors when it's possible. The removal of the barrier seems more important to me though. In one shader, it removes 17 * 4 bytes from the shader binary. ---

[Mesa-dev] [PATCH 1/9] tgsi/scan: add a new pass that analyzes tess factor writes

2017-09-06 Thread Marek Olšák
From: Marek Olšák The pass tries to deduce whether tess factors are always written by invocation 0 (at least). The implication for radeonsi is that it doesn't have to use a barrier near the end of TCS, and doesn't have to use LDS for passing the tess factors to the epilog.

Re: [Mesa-dev] [PATCH v6 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

2017-09-06 Thread Ilia Mirkin
On Wed, Sep 6, 2017 at 12:29 PM, Emil Velikov wrote: > On 6 September 2017 at 17:17, Ilia Mirkin wrote: >> One might ask the question of why st/mesa is being built at all >> without HAVE_GALLIUM... >> > The following snippet might answer your

[Mesa-dev] [Bug 102565] u_debug_stack.c:114: undefined reference to `_Ux86_64_getcontext'

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102565 Bug ID: 102565 Summary: u_debug_stack.c:114: undefined reference to `_Ux86_64_getcontext' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102530 --- Comment #21 from Emil Velikov --- The attached patch from Alexandre seems to be a noop. This series from Eric treats MESA_NO_ERROR as boolean. https://patchwork.freedesktop.org/series/29888/ -- You are receiving

Re: [Mesa-dev] [PATCH v6 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

2017-09-06 Thread Emil Velikov
On 6 September 2017 at 17:17, Ilia Mirkin wrote: > One might ask the question of why st/mesa is being built at all > without HAVE_GALLIUM... > The following snippet might answer your question (that or I'm having a dull moment). src/mesa/Makefile.am:if HAVE_GALLIUM

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102530 --- Comment #20 from Alexandre Demers --- Created attachment 134015 --> https://bugs.freedesktop.org/attachment.cgi?id=134015=edit Enable KHR_NO_ERROR only if MESA_NO_ERROR's value is different from 0 >From

Re: [Mesa-dev] [PATCH mesa] glx: remove dead code

2017-09-06 Thread Emil Velikov
On 6 September 2017 at 17:17, Adam Jackson wrote: > On Fri, 2017-09-01 at 15:04 +0100, Eric Engestrom wrote: >> These fields were added in 2d94601582 but never used; hasPresent was >> never set, while the other ones were set but never read. > > I think this patch is wrong: > >> -

Re: [Mesa-dev] [PATCH v6 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

2017-09-06 Thread Ilia Mirkin
One might ask the question of why st/mesa is being built at all without HAVE_GALLIUM... On Wed, Sep 6, 2017 at 12:11 PM, Emil Velikov wrote: > Hi Gert, > > This seems to have broken the "classic only" build - see > https://travis-ci.org/evelikov/Mesa/jobs/272529714. >

Re: [Mesa-dev] [PATCH mesa] glx: remove dead code

2017-09-06 Thread Adam Jackson
On Fri, 2017-09-01 at 15:04 +0100, Eric Engestrom wrote: > These fields were added in 2d94601582 but never used; hasPresent was > never set, while the other ones were set but never read. I think this patch is wrong: > - dri3_reply = xcb_dri3_query_version_reply(c, dri3_cookie, ); > - if

Re: [Mesa-dev] [PATCH v6 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

2017-09-06 Thread Emil Velikov
Hi Gert, This seems to have broken the "classic only" build - see https://travis-ci.org/evelikov/Mesa/jobs/272529714. In there the following is executed DRI_LOADERS="--enable-glx --enable-gbm --enable-egl --with-platforms=x11,drm,surfaceless,wayland --enable-osmesa"

Re: [Mesa-dev] [PATCH] glsl: disallow mixed varying types within a location

2017-09-06 Thread Ilia Mirkin
On Wed, Sep 6, 2017 at 12:13 AM, Timothy Arceri wrote: > > > On 06/09/17 11:59, Ilia Mirkin wrote: >> >> On Tue, Sep 5, 2017 at 9:54 PM, Timothy Arceri >> wrote: >>> >>> >>> On 06/09/17 11:23, Ilia Mirkin wrote: The enhanced layouts

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #8 from Bruce Cherniak --- Sounds like the right solution then. Thanks for taking a look at this. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #7 from Thomas Hellström --- (In reply to Bruce Cherniak from comment #6) > Verified. Your patch does fix this issue. > > Does this negate the original intent of your "Reduce the number of > frontbuffer

Re: [Mesa-dev] [PATCH v2 3/4] i965/screen: Report the correct number of image planes

2017-09-06 Thread Emil Velikov
On 5 September 2017 at 19:31, Jason Ekstrand wrote: > On Tue, Sep 5, 2017 at 10:25 AM, Emil Velikov > wrote: >> >> Hi Jason, >> >> On 5 September 2017 at 16:48, Jason Ekstrand wrote: >> > For non-CCS images, we were reporting

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102564 Alex Granni changed: What|Removed |Added Attachment #134011|GPU Caps Viewer randomly|GPU Caps Viewer

Re: [Mesa-dev] [PATCH 17/17] i965: Disentangle batch and state buffer flushing.

2017-09-06 Thread Chris Wilson
Quoting Kenneth Graunke (2017-09-06 16:33:48) > On Wednesday, September 6, 2017 5:26:10 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-09-06 01:09:50) > > > We now flush the batch when either the batchbuffer or statebuffer > > > reaches the original intended batch size, instead of

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

2017-09-06 Thread Nicolai Hähnle
On 06.09.2017 11:47, Marek Olšák wrote: On Wed, Sep 6, 2017 at 4:44 AM, Dave Airlie wrote: On 6 September 2017 at 03:11, Marek Olšák wrote: On Tue, Sep 5, 2017 at 5:50 PM, Brian Paul wrote: On 09/04/2017 05:29 AM, Marek Olšák wrote:

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102564 Bug ID: 102564 Summary: swr: GPU Caps Viewer crashes with any 3D demo Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 14/17] i965: Grow the batch/state buffers if we need space and can't flush.

2017-09-06 Thread Chris Wilson
Quoting Kenneth Graunke (2017-09-06 16:20:00) > On Wednesday, September 6, 2017 3:08:44 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-09-06 01:09:47) > > > Previously, we would just assert fail and die in this case. The only > > > safeguard is the "estimated max prim size" checks

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 --- Comment #6 from Bruce Cherniak --- Verified. Your patch does fix this issue. Does this negate the original intent of your "Reduce the number of frontbuffer flush calls"? -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH v9 0/7] mesa/st: glsl_to_tgsi: refined register merge algorithm

2017-09-06 Thread Nicolai Hähnle
On 06.09.2017 17:00, Dieter Nützel wrote: Am 06.09.2017 11:53, schrieb Nicolai Hähnle: I finally went over this again, and I think it's good enough to go in. R-b and pushed! Thanks for making all the adjustments and your patience :) I did notice some minor things, I'm about to send out

Re: [Mesa-dev] [PATCH 00/17] i965: Growing the batch buffer, separate state buffers

2017-09-06 Thread Kenneth Graunke
On Wednesday, September 6, 2017 2:21:51 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 01:09:33) > > A couple issues remain: the series drops the malloc'd shadow copy of > > the batch for non-LLC systems. I haven't checked how dire this is. > > The last patch also dramatically

Re: [Mesa-dev] [PATCH 17/17] i965: Disentangle batch and state buffer flushing.

2017-09-06 Thread Kenneth Graunke
On Wednesday, September 6, 2017 5:26:10 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 01:09:50) > > We now flush the batch when either the batchbuffer or statebuffer > > reaches the original intended batch size, instead of when the sum of > > the two reaches a certain size

Re: [Mesa-dev] [PATCH 17/17] i965: Disentangle batch and state buffer flushing.

2017-09-06 Thread Kenneth Graunke
On Wednesday, September 6, 2017 4:23:37 AM PDT Chris Wilson wrote: > Quoting Chris Wilson (2017-09-06 11:13:54) > > Quoting Kenneth Graunke (2017-09-06 01:09:50) > > > We now flush the batch when either the batchbuffer or statebuffer > > > reaches the original intended batch size, instead of when

Re: [Mesa-dev] [PATCH 14/17] i965: Grow the batch/state buffers if we need space and can't flush.

2017-09-06 Thread Kenneth Graunke
On Wednesday, September 6, 2017 3:08:44 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 01:09:47) > > Previously, we would just assert fail and die in this case. The only > > safeguard is the "estimated max prim size" checks when starting a draw > > (or compute dispatch or BLORP

Re: [Mesa-dev] [PATCH 06/17] i965: Drop a useless ret == 0 check.

2017-09-06 Thread Kenneth Graunke
On Wednesday, September 6, 2017 2:31:11 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 01:09:39) > > Prior to the previous patch, we would pwrite the batchbuffer contents, > > and wanted to skip the execbuffer if that failed. Now, we write things > > directly to the map, so we

Re: [Mesa-dev] [PATCH v9 0/7] mesa/st: glsl_to_tgsi: refined register merge algorithm

2017-09-06 Thread Dieter Nützel
Am 06.09.2017 11:53, schrieb Nicolai Hähnle: I finally went over this again, and I think it's good enough to go in. R-b and pushed! Thanks for making all the adjustments and your patience :) I did notice some minor things, I'm about to send out patches to clean things up afterwards. Cheers,

Re: [Mesa-dev] [PATCH v2 3/3] docs/release-calendar: update and extend

2017-09-06 Thread Andres Gomez
On Tue, 2017-09-05 at 18:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > v2: Use correct 17.1.10 version, adjust some names. > > Cc: Juan A. Suárez > Cc: Andres Gomez > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 1/2] radv: remove unused radv_meta_saved_state::vertex_saved field

2017-09-06 Thread Bas Nieuwenhuizen
Correct, the code that set it has been removed with bcf705b62e00c45a178e07ef01e7d266f73c2acc. With the old_vertex_bindings removed, this patch is Reviewed-by: Bas Nieuwenhuizen On Wed, Sep 6, 2017, at 16:24, Samuel Pitoiset wrote: > Just noticed that

Re: [Mesa-dev] [PATCH 1/2] radv: remove unused radv_meta_saved_state::vertex_saved field

2017-09-06 Thread Samuel Pitoiset
Just noticed that old_vertex_bindings should also be removed in this patch. On 09/06/2017 03:53 PM, Samuel Pitoiset wrote: It's always false. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c | 6 -- src/amd/vulkan/radv_meta.h | 1 - 2 files

[Mesa-dev] [PATCH mesa 2/2] mesa: allow user to set MESA_NO_ERROR=0

2017-09-06 Thread Eric Engestrom
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102530 Cc: Michel Dänzer Cc: Alexandre Demers Signed-off-by: Eric Engestrom --- src/mesa/main/context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH mesa 1/2] util: rename include guard to avoid clash

2017-09-06 Thread Eric Engestrom
src/mesa/main/debug.h uses the same include guard. Signed-off-by: Eric Engestrom --- src/util/debug.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/debug.h b/src/util/debug.h index 11a8561eb5..75ebc2ebff 100644 ---

Re: [Mesa-dev] [PATCH 5/5] radv/gfx9: fix tile swizzle handling for gfx9

2017-09-06 Thread Emil Velikov
Hi Dave, Bas, On 21 August 2017 at 13:59, Emil Velikov wrote: > Hi Dave, > > On 15 August 2017 at 06:26, Dave Airlie wrote: >> From: David Airlie >> >> This sets the tile swizzle up properly for gfx9. >> >>

  1   2   >