Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

On 09/14/2017 02:03 AM, Chad Versace wrote: From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Thank you. I have closed https://bugs.freedesktop.org/show_bug.cgi?id=102552 Best regards, Denis. On Sep 14, 2017 2:01 AM, "Marek Olšák" wrote: > I pushed the patch. Thanks. > > Marek > > On Wed, Sep 13, 2017 at 9:27 PM, Denis Pauk

[Mesa-dev] [PATCH 2/3] glsl: check if induction var incremented before use in terminator

do-while loops can increment the starting value before the condition is checked. e.g. do { ndx++; } while (ndx < 3); This commit changes the code to detect this and reduces the iteration count by 1 if found. --- src/compiler/glsl/loop_analysis.cpp | 38

[Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator at the start of the loop we might actually ignore any other terminators that might be

[Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

These instruction will be executed on every iteration of the loop we cannot drop them. --- src/compiler/glsl/loop_analysis.h | 7 +++ src/compiler/glsl/loop_controls.cpp | 15 +++ src/compiler/glsl/loop_unroll.cpp | 7 --- 3 files changed, 22 insertions(+), 7

Re: [Mesa-dev] [PATCH 5/5] radeonsi: allow out-of-order rasterization in commutative blending cases

For the series: Tested-by: Dieter Nützel Greetings, Dieter Am 09.09.2017 12:43, schrieb Nicolai Hähnle: From: Nicolai Hähnle We do not enable this by default for additive blending, since it slightly breaks OpenGL invariance guarantees due

Re: [Mesa-dev] [PATCH 0/5] Resend of string buffer series

Even for this series, too: Tested-by: Dieter Nützel You 'lost' all of my former tb's. Dieter Am 11.09.2017 22:21, schrieb Thomas Helland: I think I should have addressed all review feedback pointed out to me by Nicolai, fixed the build issues with the tests (thanks to

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #25 from Michel Dänzer --- (In reply to 赵九胤 from comment #24) > I ran the S3(the computer suspends into memory) test 500 times and my Linux > system crashed, [...] That doesn't sound related to this bug report at

Re: [Mesa-dev] [PATCH 5/5] glcpp: Avoid unnecessary call to strlen

On 09/11/2017 01:21 PM, Thomas Helland wrote: > @@ -621,12 +636,17 @@ u64vec4 KEYWORD_WITH_ALT(0, 0, 0, 0, > yyextra->ARB_gpu_shader_int64_enable, U64V > [_a-zA-Z][_a-zA-Z0-9]* { > struct _mesa_glsl_parse_state *state = yyextra; >

Re: [Mesa-dev] [PATCH 5/5] glcpp: Avoid unnecessary call to strlen

On 09/11/2017 01:21 PM, Thomas Helland wrote: > Length of the token was already calculated by flex and stored in yyleng, > no need to implicitly call strlen() via linear_strdup(). > > Reviewed-by: Nicolai Hähnle > Reviewed-by: Timothy Arceri > > V2: Also convert this

Re: [Mesa-dev] [PATCH 12/27] i965: add support for cached shaders with xfb qualifiers

On 14/09/17 10:04, Matt Turner wrote: On 08/19, Jordan Justen wrote: From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. ---

Re: [Mesa-dev] [PATCH] gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE

Reviewed-by: Marek Olšák Marek On Wed, Sep 13, 2017 at 6:53 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > To be able to properly distinguish between GL_ANY_SAMPLES_PASSED > and GL_ANY_SAMPLES_PASSED_CONSERVATIVE. > >

Re: [Mesa-dev] [PATCH v2 03/15] i965: Use a WC map and memcpy for the batch instead of pwrite.

On Wednesday, September 13, 2017 3:51:03 PM PDT Matt Turner wrote: > On 09/13, Kenneth Graunke wrote: > >We'd like to eliminate the malloc'd shadow copy eventually, but there > >are still unresolved performance problems. In the meantime, let's at > >least get rid of pwrite. > > I don't know much

Re: [Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

On 14/09/17 09:53, Matt Turner wrote: On 08/19, Jordan Justen wrote: From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done

Re: [Mesa-dev] [Mesa-stable] [PATCH 5/5] amd/common: add workaround for cube map array layer clamping

For the series: Reviewed-by: Marek Olšák Marek On Wed, Sep 13, 2017 at 7:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes dEQP-GLES31.functional.texture.filtering.cube_array.* > > Cc:

Re: [Mesa-dev] [PATCH] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

On 08/17, Jeremy Huddleston Sequoia wrote: Signed-off-by: Jeremy Huddleston Sequoia CC: Nicolai Hähnle CC: Matt Turner CC: Ian Romanick CC: Brian Paul This looks fine to me. Reviewed-by:

Re: [Mesa-dev] [PATCH 5/5] radeonsi: allow out-of-order rasterization in commutative blending cases

For the series: Reviewed-by: Marek Olšák Marek On Sat, Sep 9, 2017 at 12:43 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We do not enable this by default for additive blending, since it slightly > breaks OpenGL

Re: [Mesa-dev] [PATCH 26/27] i965: Initialize disk shader cache when INTEL_SHADER_CACHE env var is set

On 08/19, Jordan Justen wrote: We use the build-id of i965_dri.so for the timestamp, and the name from i965_pci_ids.h for the device name. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c| 2 ++ src/mesa/drivers/dri/i965/brw_disk_cache.c |

Re: [Mesa-dev] [PATCH 12/27] i965: add support for cached shaders with xfb qualifiers

On 08/19, Jordan Justen wrote: From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- If I understand correctly, at this point

Re: [Mesa-dev] [PATCH 07/27] i965: Add shader cache support for vertex and fragment stages

On 08/19, Jordan Justen wrote: From: Timothy Arceri This enables the cache on vertex and fragment shaders only. [jordan.l.jus...@intel.com: reword subject] [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

On 08/19, Jordan Justen wrote: From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth.

Re: [Mesa-dev] [PATCH] i965: Record NOS dependencies for shader programs and only check those.

On 08/22, Kenneth Graunke wrote: Previously, the state upload code listened to a broad set of dirty flags that corresponded to all possible state dependencies for a shader stage. This is somewhat overkill. For example, if a shader has no textures, there is no need to listen to _NEW_TEXTURE.

Re: [Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.

The series looks good to me. I had a question on 03/15, mostly for clarification in the commit message. The series is Reviewed-by: Matt Turner signature.asc Description: Digital signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix theoretical memory leak

Reviewed-by: Timothy Arceri On 14/09/17 03:05, Nicolai Hähnle wrote: From: Nicolai Hähnle It can't *really* happen since we don't use subroutines. CID: 1417491 --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 7 +-- 1 file

[Mesa-dev] [PATCH 15/20] anv/image: Refactor creation of aux surfaces (v2)

From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded in a large, deep 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into one function per aux type: try_make_hiz_surface() try_make_ccs_surface()

[Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply

[Mesa-dev] [PATCH 11/20] intel: Add simple logging façade for Android

From: Chad Versace I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). On Android, stdio goes to /dev/null. On Android, remote gdb is even more painful than the usual remote gdb. On Android, nothing works like you expect and debugging is hell. I need

[Mesa-dev] [PATCH 18/20] anv: Add sizeless anv_bo_cache_import()

From: Chad Versace The patch renames anv_bo_cache_import() to anv_bo_cache_import_with_size(); and adds a new variant, anv_bo_cache_import(), that lacks the 'size' parameter. Same as pre-patch, anv_bo_cache_import_with_size() continues to validate the imported size.

[Mesa-dev] [PATCH 19/20] anv: Add func anv_gem_get_tiling()

From: Chad Versace Will use in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_gem.c | 16 src/intel/vulkan/anv_private.h | 1 + 2 files changed, 17 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index

[Mesa-dev] [PATCH 17/20] anv: Move close(fd) from anv_bo_cache_import to its callers

From: Chad Versace This will allow us to implement VK_ANDROID_native_buffer without dup'ing the fd. We must close the fd in VK_KHR_external_memory_fd, but we should not in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_allocator.c | 12

[Mesa-dev] [PATCH 16/20] anv: Add field anv_image::bo_is_owned

From: Chad Versace If this flag is set, then the image and it's bo have the same lifetime. vkDestroyImage will release the bo. We need this for VK_ANDROID_native_buffer, because that extension creates the VkImage and imports its memory in the same call, vkCreateImage.

[Mesa-dev] [PATCH 10/20] intel: Move definition of LOG_TAG from header into Makefiles

From: Chad Versace This patch prevents compilation failures in upcoming Android Vulkan patches, failures due to redefinition of LOG_TAG in Android system headers. This patch does not change the value of LOG_TAG. It remains "INTEL-MESA". (I don't like it, though. The

[Mesa-dev] [PATCH 13/20] anv/image: Better var names for image-create-info structs

From: Chad Versace Upcoming patches teach vkCreateImage to understand VkNativeBufferANDROID. And much later patches will do the same for whatever VkImageCreateInfo-chained struct imports dma-bufs. And then again for the struct that will be introduced by the inevitable

[Mesa-dev] [PATCH 07/20] anv: Feed vk_android_native_buffer.xml to generators

From: Chad Versace Feed the XML to anv_extensions.py and anv_entrypoints_gen.py. Do it on all platforms, not just Android. Tested on Android and Fedora. We always parse the Android XML, regardless of target platform, to help reduce the chance that people working on

[Mesa-dev] [PATCH 14/20] anv/image: Refactor how tiling is chosen

From: Chad Versace The code that restricts the VkImage's tiling flags, extract it into a new function named choose_isl_tiling_flags(). This reduces the diff in upcoming patches for VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_image.c | 31

[Mesa-dev] [PATCH 12/20] anv: Better support for Android logging (v2)

From: Chad Versace In src/intel/vulkan/*, redirect all instances of printf, vk_error, anv_loge, anv_debug, anv_finishme, anv_perf_warn, anv_assert, and their many variants to the new intel_log functions. I believe I caught them all. The other subdirs of src/intel are

[Mesa-dev] [PATCH 08/20] anv/android: Disable surface and swapchain extensions (v2)

From: Chad Versace Android's Vulkan loader implements VK_KHR_surface and VK_KHR_swapchain, and applications cannot access the driver's implementation. Moreoever, if the driver exposes the those extension strings, then tests dEQP-VK.api.info.instance.extensions and

[Mesa-dev] [PATCH 09/20] anv: Link to Android libraries in the autotools build

From: Chad Versace A first step to supporting Vulkan on ARC++. Mesa on ARC++ uses Autotools, not Android.mk. Doing this now, even before VK_ANDROID_native_buffer is implemented, allows us to incrementally add Android support to the Autotools build. ---

[Mesa-dev] [PATCH 04/20] vulkan/util: Teach gen_enum_to_str.py to parse mutliple XML files

From: Chad Versace To give the script multiple XML files, call it like so: gen_enum_to_str.py --xml a.xml --xml b.xml --xml c.xml ... The script parses the XML files in the given order. This will allow us to feed the script XML files for extensions that are

[Mesa-dev] [PATCH 05/20] vulkan/registry: Feed vk_android_native_buffer.xml to gen_enum_to_str.py

From: Chad Versace Tested on Android and Fedora. --- src/vulkan/Android.mk | 9 +++-- src/vulkan/Makefile.am | 9 +++-- src/vulkan/util/gen_enum_to_str.py | 20 +++- 3 files changed, 33 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 03/20] vulkan/registry: Add VK_ANDROID_native_buffer

From: Chad Versace The VK_ANDROID_native_buffer extension is missing from the official vk.xml. This patch defines the extension in a separate, minimal XML file: vk_android_native_buffer.xml. I chose to add the extension to a new XML file instead of adding it to the

[Mesa-dev] [PATCH 02/20] vulkan: Add #ifdef hack to vk_android_native_buffer.h

From: Chad Versace This patch consolidates many potential `#ifdef ANDROID` messes throughout src/vulkan and src/intel/vulkan into a simple, localized hack. The hack is an `#ifdef ANDROID` in vk_android_native_buffer.h that, on non-Android platorms, avoids including the

[Mesa-dev] [PATCH 01/20] vulkan: Import vk_android_native_buffer.h

From: Chad Versace Just as Mesa imports the Khronos Vulkan headers, it should import this Android-private Vulkan header too. This guarantees that Mesa will continue to build even when upstream Android breaks header compatibility. This header is only for *implementers*

[Mesa-dev] [PATCH 06/20] anv: Teach generator scripts how to parse mutliple XML files

From: Chad Versace The taught scripts are anv_extensions.py and anv_entrypoints_gen.py. To give a script multiple XML files, call it like so: anv_extensions.py --xml a.xml --xml b.xml --xml c.xml ... The scripts parse the XML files in the given order. This will

[Mesa-dev] [PATCH 00/23] anv: Implement VK_ANDROID_native_buffer (v2)

From: Chad Versace This series adds Android support to Anvil. And Android requires VK_ANDROID_native_buffer. I tested the series on 64-bit ARC++ on a Skylake Chromebook with a 3.18 kernel. (ARC++ is the Android container in Chrome OS). (Yes, I said 3.18. That's not a

Re: [Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

On 14/09/17 01:22, Nicolai Hähnle wrote: On 12.09.2017 03:33, Timothy Arceri wrote: On 12/09/17 00:57, Nicolai Hähnle wrote: On 11.09.2017 16:47, Ilia Mirkin wrote: On Mon, Sep 11, 2017 at 10:44 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

I pushed the patch. Thanks. Marek On Wed, Sep 13, 2017 at 9:27 PM, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i

Re: [Mesa-dev] [PATCH v2 03/15] i965: Use a WC map and memcpy for the batch instead of pwrite.

On 09/13, Kenneth Graunke wrote: We'd like to eliminate the malloc'd shadow copy eventually, but there are still unresolved performance problems. In the meantime, let's at least get rid of pwrite. I don't know much about this. What is wrong with pwrite, and why is WC better? Does this change

[Mesa-dev] [Bug 102573] fails to build on armel

https://bugs.freedesktop.org/show_bug.cgi?id=102573 --- Comment #2 from Shmerl --- (In reply to Emil Velikov from comment #1) > I don't have a armel setup handy, so if > anyone anyone can polish/fix the test and send a patch, that would be > appreciated. It might be

Re: [Mesa-dev] [PATCH 11/19] anv: Use GNU C empty brace initializer

On 08/29/2017 10:19 AM, Emil Velikov wrote: > On 29 August 2017 at 18:10, Matt Turner wrote: >> On Tue, Aug 29, 2017 at 3:35 AM, Emil Velikov >> wrote: >>> On 29 August 2017 at 11:11, Eric Engestrom >>> wrote: On

Re: [Mesa-dev] [PATCH 2/3] intel/blorp/hiz: Always set sample number

On 09/11, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen Patches 2-3 (because I don't know a lot about this code) are Acked-by: Matt Turner Chromium has been disabling HiZ on Braswell for stability reasons (trying to find out more

Re: [Mesa-dev] [PATCH 1/3] i965/gen8: Remove unused gen8_emit_3dstate_multisample()

On 09/11, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen Reviewed-by: Matt Turner signature.asc Description: Digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

On 13 September 2017 at 22:13, Matt Turner wrote: > On Mon, Aug 21, 2017 at 3:27 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> memmem() does not attribute what the character after the searched string >> is. Thus

Re: [Mesa-dev] [PATCH 23/23] anv: Implement VK_ANDROID_native_buffer

On 13 September 2017 at 22:15, Chad Versace wrote: >> > + >> > +static void UNUSED >> > +static_asserts(void) >> > +{ >> > + STATIC_ASSERT(HWVULKAN_DISPATCH_MAGIC == ICD_LOADER_MAGIC); >> > +} > >> Seems like a left over? With that gone, there should be no need for

Re: [Mesa-dev] [PATCH mesa 2/6] dri/radeon: use ARRAY_SIZE macro

Reviewed-by: Ian Romanick On 09/07/2017 03:21 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/mesa/drivers/dri/radeon/radeon_tcl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] automake: enable libunwind in `make distcheck'

On 09/11, Emil Velikov wrote: From: Emil Velikov Enable the toggle to catch when the library is missing from the link path. Better to test, fail and address before releasing Mesa ;-) Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

On 13 September 2017 at 20:27, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i need to send new mail with

Re: [Mesa-dev] [PATCH] i965: Implement another VF cache invalidate workaround on Gen8+.

Ken, Looks like this patch never landed upstream? We also need it for CNL. On Mon, Jan 30, 2017 at 10:59 AM, Pohjolainen, Topi wrote: > On Sun, Jan 29, 2017 at 08:24:16PM -0800, Kenneth Graunke wrote: >> ...and provide a better citation for the existing one. >> >>

Re: [Mesa-dev] [PATCH 23/23] anv: Implement VK_ANDROID_native_buffer

On Wed 13 Sep 2017, Emil Velikov wrote: > Hi Chad, > > On the topic of keep this in the driver vs separate module - I think > it makes sense to keep it internal. > > Sure radv/others won't be able to reuse the code [that easily], at the > same time it gives greater control and one could make

Re: [Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

On Mon, Aug 21, 2017 at 3:27 AM, Emil Velikov wrote: > From: Emil Velikov > > memmem() does not attribute what the character after the searched string > is. Thus it will flag even when haystack is "foobar" while we're looking > for "foo". > >

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

On 13 September 2017 at 21:35, Matt Turner wrote: > On 09/13, Emil Velikov wrote: >> >> As Andres pointed out this commit depends on 4fab67a4415 et al, which >> seems to be missing in 17.1 and 17.2. >> >> I've ported this to 17.2 by moving the brw_inst_src[01]_reg_type() >>

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

On 13 September 2017 at 11:07, Gert Wollny wrote: > Am Dienstag, den 12.09.2017, 17:15 +0100 schrieb Eric Engestrom: >> On Tuesday, 2017-09-12 17:26:43 +0200, Gert Wollny wrote: >> > Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: >> > > On 12 September 2017

[Mesa-dev] [PATCH v2 14/15] i965: Disentangle batch and state buffer flushing.

We now flush the batch when either the batchbuffer or statebuffer reaches the original intended batch size, instead of when the sum of the two reaches a certain size (which makes no sense now that they're separate buffers). With this change, we also need to update our "are we near the end?"

[Mesa-dev] [PATCH v2 15/15] i965: Print size of validation and relocation lists in INTEL_DEBUG=flush

It's nice to have this information. While we're at it, tweak the formatting to try and vertically align numbers in the common case. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2 07/15] i965: Split brw_emit_reloc into brw_batch_reloc and brw_state_reloc.

brw_batch_reloc emits a relocation from the batchbuffer to elsewhere. brw_state_reloc emits a relocation from the statebuffer to elsewhere. For now, they do the same thing, but when we actually split the two buffers, we'll change brw_state_reloc to use the state buffer. ---

[Mesa-dev] [PATCH v2 12/15] i965: Make BLORP properly avoid batch wrapping.

We need to set brw->no_batch_wrap to actually avoid flushing in the middle of our BLORP operation, and instead grow the batchbuffer. --- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH v2 11/15] i965: Grow the batch/state buffers if we need space and can't flush.

Previously, we would just assert fail and die in this case. The only safeguard is the "estimated max prim size" checks when starting a draw (or compute dispatch or BLORP operation)...which are woefully broken. Growing is fairly straightforward: 1. Allocate a new larger BO. 2. memcpy the

[Mesa-dev] [PATCH v2 09/15] i965: Pass screen to intel_batchbuffer_reset().

This will let us access screen->kernel_features in the next patch. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c

[Mesa-dev] [PATCH v2 13/15] i965: Delete BATCH_RESERVED handling.

Now that we can grom the batchbuffer if we absolutely need the extra space, we don't need to reserve space for the final do-or-die ending commands. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 11 +++ src/mesa/drivers/dri/i965/intel_batchbuffer.h | 26 -- 2

[Mesa-dev] [PATCH v2 10/15] i965: Use a separate state buffer, but avoid changing flushing behavior.

Previously, we emitted GPU commands and indirect state into the same buffer, using a stack/heap like system where we filled in commands from the start of the buffer, and state from the end of the buffer. We then flushed before the two met in the middle. Meeting in the middle is fatal, so you

[Mesa-dev] [PATCH v2 06/15] i965: Refactor relocs into a brw_reloc_list structure.

I'm planning on splitting batch and state into separate buffers, at which point we'll need two relocation lists. In preparation for that, this patch refactors the relocation stuff into a structure we can replicate...which looks a lot like anv_reloc_list. Reviewed-by: Chris Wilson

[Mesa-dev] [PATCH v2 08/15] i965: Prepare INTEL_DEBUG=bat decoding for a separate statebuffer.

We'll need to read from both buffers when decoding state. This also drops the "failed to map" fallback - it's completely useless on LLC systems where we write directly to the mapped BO. It's not that useful on non-LLC systems either. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 110

[Mesa-dev] [PATCH v2 02/15] i965: Use batch->bo->size in brw_emit_reloc assertion.

This makes the assertion safe against batchbuffers growing. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index

[Mesa-dev] [PATCH v2 03/15] i965: Use a WC map and memcpy for the batch instead of pwrite.

We'd like to eliminate the malloc'd shadow copy eventually, but there are still unresolved performance problems. In the meantime, let's at least get rid of pwrite. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff

[Mesa-dev] [PATCH v2 05/15] i965: Move brw_state_batch code to intel_batchbuffer.c

The batch buffer and state buffer code is fairly tied together, and having it in one .c file will make refactoring easier. Also, drop some commentary above brw_state_batch. The "aperture checking performance hacks" are long since gone, so that paragraph makes little sense at this point. ---

[Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.

This assertion prevents you from doing intel_batchbuffer_require_space with a size so huge it won't fit in the batchbuffer. This doesn't seem like a common mistake, and I've never seen the assert to be useful. Soon, I hope to have batches grow, at which point this won't make sense. ---

[Mesa-dev] [PATCH v2 04/15] i965: Drop a useless ret == 0 check.

Prior to the previous patch, we would pwrite the batchbuffer contents, and wanted to skip the execbuffer if that failed. Now that we memcpy, we don't set ret != 0 on failure anymore, so it will always be 0. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 42 +-- 1

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

On 13 September 2017 at 20:48, Nicolai Hähnle wrote: > On 13.09.2017 20:28, Emil Velikov wrote: >> >> Hi Nicolai, >> >> I'm doing a final run through the lists for 17.2.1 and doesn't seem >> like this landed in master. >> Just a friendly poke, in case it fell through the

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

On 09/13, Emil Velikov wrote: As Andres pointed out this commit depends on 4fab67a4415 et al, which seems to be missing in 17.1 and 17.2. I've ported this to 17.2 by moving the brw_inst_src[01]_reg_type() calls as in the original patch. The brw_inst_src[01]_reg_file() ones are left as-is.

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On 13.09.2017 21:48, Connor Abbott wrote: On Wed, Sep 13, 2017 at 3:46 PM, Nicolai Hähnle wrote: On 13.09.2017 20:45, Connor Abbott wrote: Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with

Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

On 13.09.2017 22:20, Dave Airlie wrote: On 14 September 2017 at 03:04, Nicolai Hähnle wrote: From: Nicolai Hähnle The NIR-to-LLVM pass already does this; now the same fix covers radeonsi as well. Fixes various tests of

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On 13.09.2017 20:45, Connor Abbott wrote: Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with DPP (although we'll have to rename has_ds_bpermute to has_dpp...). Is there a reason for not deriving has_dpp from

Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

On 14 September 2017 at 03:04, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The NIR-to-LLVM pass already does this; now the same fix covers > radeonsi as well. > > Fixes various tests of >

Re: [Mesa-dev] [PATCH] radv/ac: bump params array for image atomic comp swap

On 13 September 2017 at 23:36, Andres Gomez wrote: > Hi Dave, > > This patch landed tagged for 17.2 only. Was it, then, not nominated for > 17.1 intentionally ? Actually good point, this one should be in 17.1 as well. Thanks, Dave.

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

On 13.09.2017 20:28, Emil Velikov wrote: Hi Nicolai, I'm doing a final run through the lists for 17.2.1 and doesn't seem like this landed in master. Just a friendly poke, in case it fell through the cracks. Are you absolutely sure about that? ;-) Admittedly it's only been ~3 hours since I

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On Wed, Sep 13, 2017 at 3:46 PM, Nicolai Hähnle wrote: > On 13.09.2017 20:45, Connor Abbott wrote: >> >> Not sure if we'll want to do this, since we'll need to need to >> effectively revert it anyways when we implement derivatives with DPP >> (although we'll have to

Re: [Mesa-dev] [PATCH 01/23] vulkan: Import vk_android_native_buffer.h

On Wed 13 Sep 2017, Emil Velikov wrote: > On 2 September 2017 at 09:17, Chad Versace wrote: > > Just as Mesa imports the Khronos Vulkan headers, it should import this > > Android-private Vulkan header too. This guarantees that Mesa will > > continue to build even when

Re: [Mesa-dev] [PATCH] util/build_id: Include

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Could you please commit this changes? I have not found what i need to do next after recieve "approve" for changes in https://www.mesa3d.org/submittingpatches.html#reviewing. Do i need to send new mail with "Reviewed-by: " mark? On Wed, Sep 13, 2017 at 6:36 PM, Marek Olšák

[Mesa-dev] [Bug 102710] vkCmdBlitImage with arrayLayers > 1 fails

https://bugs.freedesktop.org/show_bug.cgi?id=102710 --- Comment #1 from Bas Nieuwenhuizen --- Do you have a testcase? Could you also tell a bit more about what you do and what happens? Do you use VK_REMAINING_ARRAY_LAYERS? Is the result only the first layer being

[Mesa-dev] [PATCH] util/build_id: Include

Fix the build for Android Nougat. The dladdr(3) manpage says that is required. On Linux, the build succeeded without it because build_id.c includes which includes . On Android, we must include directly. Fixes: 5c98d382 "util: Query build-id by symbol address, not library name" Cc: Matt Turner

Re: [Mesa-dev] [PATCH mesa] swr: use ARRAY_SIZE macro

Regardless of making it a v2, etc. :-) Sorry for the complication of not being able to just accept the original. Reviewed-by: Bruce Cherniak > On Sep 12, 2017, at 8:03 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom

[Mesa-dev] [Bug 102710] vkCmdBlitImage with arrayLayers > 1 fails

https://bugs.freedesktop.org/show_bug.cgi?id=102710 Bug ID: 102710 Summary: vkCmdBlitImage with arrayLayers > 1 fails Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with DPP (although we'll have to rename has_ds_bpermute to has_dpp...). On Wed, Sep 13, 2017 at 1:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

Hi all, On 31 August 2017 at 23:48, Jason Ekstrand wrote: > We are looking up the execution type prior to checking how many sources > we have. This leads to looking for a type for src1 on MOV instructions > which is bogus. On BDW+, the src1 register type overlaps with the

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

Hi Nicolai, I'm doing a final run through the lists for 17.2.1 and doesn't seem like this landed in master. Just a friendly poke, in case it fell through the cracks. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 3/5] amd/common: add chip_class to ac_llvm_context

On 13.09.2017 19:25, Emil Velikov wrote: Hi Nicolai, On 13 September 2017 at 18:04, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 5 - src/amd/common/ac_llvm_build.h

Re: [Mesa-dev] [PATCH 3/5] amd/common: add chip_class to ac_llvm_context

Hi Nicolai, On 13 September 2017 at 18:04, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/amd/common/ac_llvm_build.c | 5 - > src/amd/common/ac_llvm_build.h | 7 ++- >

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

On Wed, Sep 13, 2017 at 6:03 AM, Andres Gomez wrote: > Jason, this patch landed tagged for mesa-stable but without mentioning > any specific branch. > > For 17.1 it depends on earlier commit 4fab67a4415 which did not land in > the branch so I'm keeping it out. > > I hope this

Re: [Mesa-dev] [PATCH] mesa/st/tests: Correct build flags and force -std=c++11

On 13 September 2017 at 13:42, Gert Wollny wrote: > Am Mittwoch, den 13.09.2017, 13:11 +0100 schrieb Emil Velikov: >> Hi Gert, >> >> On 13 September 2017 at 09:32, Gert Wollny >> wrote: >> > Include src/gallium/Automake.inc, correct the build flags >>

  1   2   >