[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

https://bugs.freedesktop.org/show_bug.cgi?id=102891 Dave Airlie changed: What|Removed |Added Status|NEW |NEEDINFO ---

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

Hello Lucas, On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote: > Hi Wladimir! > > etna_resource_needs_flush is only called from two places - here, and > > in resource_flush, where it also determines whether to do a > > resolve-to-self, but before presenting the image. There it also

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

On Thu, 2017-11-09 at 16:34 -0800, Jason Ekstrand wrote: > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace g> > wrote: > > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[1] > > > sigles...@igalia.com> wrote: >

[Mesa-dev] [Bug 103658] addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression

https://bugs.freedesktop.org/show_bug.cgi?id=103658 Bug ID: 103658 Summary: addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

Re: [Mesa-dev] [PATCH 05/17] main, glsl: Add UniformDataDefaults which stores uniform defaults

On 09/11/17 17:42, Jordan Justen wrote: The ARB_get_program_binary extension requires that uniform values in a program be restored to their initial value just after linking. This patch saves off the initial values just after linking. When the program is restored by glProgramBinary, we can use

Re: [Mesa-dev] [PATCH 09/17] i965: Fix memory leak when serializing nir

6-9: Reviewed-by: Timothy Arceri On 09/11/17 17:42, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_program.c

Re: [Mesa-dev] [PATCH 04/17] glsl: Split out shader program serialization

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] r600: don't emit atomic save if we have no atomic counters.

From: Dave Airlie Otherwise we end up emitting the fence. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/r600/evergreen_state.c

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

On 2017-11-09 08:07:57, Jose Fonseca wrote: > On 09/11/17 13:19, Emil Velikov wrote: > > Hi Jordan, > > > > On 9 November 2017 at 06:42, Jordan Justen > > wrote: > >> Signed-off-by: Jordan Justen > >> --- > >> src/util/Makefile.sources |

[Mesa-dev] [PATCH v2] radeonsi: copy some nir gs info

v2: copy input primitive --- src/gallium/drivers/radeonsi/si_shader_nir.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 5b68ff2a07..c7880b7f87 100644 ---

[Mesa-dev] [PATCH 20/20] radeonsi: enable gs support for nir backend

--- src/gallium/drivers/radeonsi/si_pipe.c | 3 +- src/gallium/drivers/radeonsi/si_shader_nir.c | 43 src/mesa/state_tracker/st_glsl_to_nir.cpp| 3 +- 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 17/20] ac: add si_nir_load_input_gs() to the abi

--- src/amd/common/ac_nir_to_llvm.c | 24 - src/amd/common/ac_shader_abi.h| 7 ++ src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi/si_shader_internal.h | 5 +

[Mesa-dev] [PATCH 19/20] radeonsi: copy some nir gs info

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 5b68ff2a07..1933c8c770 100644 --- a/src/gallium/drivers/radeonsi/si_shader_nir.c +++

[Mesa-dev] [PATCH 18/20] ac: add gs_{prim, invocation}_id to the abi

--- src/amd/common/ac_nir_to_llvm.c | 16 src/amd/common/ac_shader_abi.h| 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 14 ++ src/gallium/drivers/radeonsi/si_shader_internal.h | 2 -- 4 files changed, 16

[Mesa-dev] [PATCH 15/20] radeonsi: add basic nir -> llvm type helper

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 847d75ba14..fca16f46cf 100644 ---

[Mesa-dev] [PATCH 16/20] ac: move build_varying_gather_values() to ac_llvm_build.h and expose

--- src/amd/common/ac_llvm_build.c | 22 ++ src/amd/common/ac_llvm_build.h | 4 src/amd/common/ac_nir_to_llvm.c | 34 ++ 3 files changed, 32 insertions(+), 28 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH 09/20] radeonsi: get llvm types from ac

--- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c index 9ec5a876f3..59d02605e9 100644 ---

[Mesa-dev] [PATCH 14/20] radeonsi: create si_llvm_load_input_gs()

This creates a common function that can be shared by the tgsi and nir backends. --- src/gallium/drivers/radeonsi/si_shader.c | 61 ++- src/gallium/drivers/radeonsi/si_shader_internal.h | 6 +++ 2 files changed, 44 insertions(+), 23 deletions(-) diff --git

[Mesa-dev] [PATCH 08/20] radeonsi: gather stream info in nir path

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 37 1 file changed, 37 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 32f6d86647..847d75ba14 100644 ---

[Mesa-dev] [PATCH 07/20] radeonsi: add nir support for gs epilogue

--- src/gallium/drivers/radeonsi/si_shader.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 10b1890b4f..efaab0a7a1 100644 ---

[Mesa-dev] [PATCH 06/20] radeonsi: add nir support for es epilogue

--- src/gallium/drivers/radeonsi/si_shader.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index cc68d0ac6f..10b1890b4f 100644 ---

[Mesa-dev] [PATCH 12/20] radeonsi: add llvm_type_is_64bit() helper

--- src/gallium/drivers/radeonsi/si_shader.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 33c37d438b..3708696c69 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++

[Mesa-dev] [PATCH 13/20] radeonsi: pass llvm type to lds_load()

--- src/gallium/drivers/radeonsi/si_shader.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 3708696c69..37d97cb341 100644 ---

[Mesa-dev] [PATCH 10/20] radeonsi: introduce bitcast_llvmtype()

This is like bitcast() but takes an llvm type rather than a tgsi type. --- src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 9 + 2 files changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH 11/20] radeonsi: pass llvm type to si_llvm_emit_fetch_64bit()

--- src/gallium/drivers/radeonsi/si_shader.c| 11 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 2 +- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 17 ++--- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 03/20] radeonsi: rework gs_vtx_offset handling

This simplifies things a bit and will enable it to work with the common NIR -> LLVM code. --- src/gallium/drivers/radeonsi/si_shader.c | 25 --- src/gallium/drivers/radeonsi/si_shader_internal.h | 7 +-- 2 files changed, 10 insertions(+), 22 deletions(-) diff

[Mesa-dev] [PATCH 01/20] st/glsl_to_nir: disable io type lowering for stages other than vs and fs

This is too simple and breaks gs and I'm not sure its required there anyway. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index

[Mesa-dev] [PATCH 05/20] radeonsi: add nir support for ls epilogue

--- src/gallium/drivers/radeonsi/si_shader.c | 37 +++- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 47ca64fdea..cc68d0ac6f 100644 ---

[Mesa-dev] [PATCH 02/20] nir: add streams to nir data

This will be used by gallium drivers. --- src/compiler/glsl/glsl_to_nir.cpp | 1 + src/compiler/nir/nir.h| 8 2 files changed, 9 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index caea2ea3b2..d327f52be6 100644 ---

[Mesa-dev] Initial GS NIR support for radeonsi

The support is still WIP but the patches as starting to pile up so thought I'd see if I could land these before continuing. Whats missing? Vega support for gs_vtx_offset handling (see patch 3), I don't have one yet for testing so didn't attempt to adapt the code. Lots of piglit tests still

[Mesa-dev] [PATCH 04/20] ac: add emit_vertex to the abi

--- src/amd/common/ac_nir_to_llvm.c | 11 +- src/amd/common/ac_shader_abi.h | 4 src/gallium/drivers/radeonsi/si_shader.c | 35 +++- 3 files changed, 31 insertions(+), 19 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 1/3] i965: Make a better helper function for UBO/SSBO/ABO surface handling.

On Thu, Nov 9, 2017 at 2:42 PM, Kenneth Graunke wrote: > On Thursday, November 9, 2017 12:31:18 PM PST Jason Ekstrand wrote: > > On Thu, Nov 9, 2017 at 12:45 AM, Kenneth Graunke > > wrote: > > > > > This fixes the missing AutomaticSize handling in

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: > On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: >> >>> On Nov 10, 2017, at 07:41, Marek Olšák wrote: >>> >>> Hi, >>> >>> This fixes the TCS gl_ClipDistance piglit failure that was

Re: [Mesa-dev] [PATCH] intel/fs: Use a pure vertical stride for large register strides

On Thu, Nov 9, 2017 at 2:23 PM, Matt Turner wrote: > On Thu, Nov 2, 2017 at 3:54 PM, Jason Ekstrand > wrote: > > Register strides higher than 4 are uncommon but they can happen. For > > instance, if you have a 64-bit extract_u8 operation, we turn that

Re: [Mesa-dev] [PATCH v2 11/26] gallium/u_threaded: avoid syncs for get_query_result

This commit makes most query piglit tests crash. I've not investigated further. Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Queries should still get marked as flushed when flushes are executed >

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace wrote: > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[1] > > sigles...@igalia.com> wrote: > > > > The HW has some limits but, according to the spec, we can

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

On Wed 08 Nov 2017, Jason Ekstrand wrote: > This function is used to determine when we need to re-allocate a > miptree. Since we do nothing different in miptree allocation for > sRGB vs. linear, loosening this should be safe and may lead to less > copying and reallocating in some odd cases. > >

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

On Wed 08 Nov 2017, Jason Ekstrand wrote: > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[1] > sigles...@igalia.com> wrote: > > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. When we allocate > that

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: > >> On Nov 10, 2017, at 07:41, Marek Olšák wrote: >> >> Hi, >> >> This fixes the TCS gl_ClipDistance piglit failure that was uncovered >> by a recent LLVM change. The solution is to set volatile on

Re: [Mesa-dev] [PATCH 1/3] radv: Fix architecture in radeon_icd.{arch}.json

for the series: Reviewed-by: Dylan Baker Quoting Chad Versace (2017-11-09 15:45:00) > Use the host arch, not the target arch. In Meson and in recent > Autotools, the host arch is where the binary will be used. The target > arch is useful only when compiling a compiler. > >

Re: [Mesa-dev] [RFC PATCH v1 03/30] anv: Refactor get_buffer_format_properties()

On Tue 07 Nov 2017, Lionel Landwerlin wrote: > On 07/11/17 14:47, Chad Versace wrote: > > Make it a stand-alone function. Pre-patch, for some formats the function > > returned incorrect VkFormatFeatureFlags which were cleaned up by the > > caller. > > > > This prepares for a cleaner

Re: [Mesa-dev] [PATCH 1/3] radv: Fix architecture in radeon_icd.{arch}.json

Reviewed-by: Bas Nieuwenhuizen On 10 Nov 2017 00:45, "Chad Versace" wrote: > Use the host arch, not the target arch. In Meson and in recent > Autotools, the host arch is where the binary will be used. The target > arch is useful only when

Re: [Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

On Tue 07 Nov 2017, Jason Ekstrand wrote: > I think I'd prefer we not make "Fix" the first word in the title unless it > fixes an actual bug.  How about "Refactor"?  Same for the ASTC patch. Sure, I'll s/Fix/Refactor/ in those patches. ___ mesa-dev

Re: [Mesa-dev] [PATCH] i965: Pretend there are 4 subslices for compute shader threads on Gen9+.

On Thu, Nov 09, 2017 at 01:50:29PM -0800, Kenneth Graunke wrote: > On Thursday, November 9, 2017 11:22:34 AM PST Rafael Antognolli wrote: > > On Thu, Nov 09, 2017 at 12:59:12AM -0800, Jordan Justen wrote: > > > Reviewed-by: Jordan Justen > > > > It's also > > > >

[Mesa-dev] [PATCH 2/3] anv: Fix architecture in intel_icd.{arch}.json

Use the host arch, not the target arch. In Meson and in recent Autotools, the host arch is where the binary will be used. The target arch is useful only when compiling a compiler. See: http://mesonbuild.com/Cross-compilation.html See:

[Mesa-dev] [PATCH 3/3] anv/meson: Generate dev_icd.json

I tested this in a setup where the builddir was outside of the srcdir. Reviewed-by: Eric Engestrom Acked-by: Dylan Baker --- src/intel/vulkan/meson.build | 12 1 file changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH 1/3] radv: Fix architecture in radeon_icd.{arch}.json

Use the host arch, not the target arch. In Meson and in recent Autotools, the host arch is where the binary will be used. The target arch is useful only when compiling a compiler. See: http://mesonbuild.com/Cross-compilation.html See:

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

> On Nov 10, 2017, at 07:41, Marek Olšák wrote: > > Hi, > > This fixes the TCS gl_ClipDistance piglit failure that was uncovered > by a recent LLVM change. The solution is to set volatile on loads > and stores to enforce proper ordering. > > Please review. > Every LDS

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

Quoting Eric Anholt (2017-11-08 13:26:12) > We shouldn't have to manually specify most of these deps, I think, since > they should be transitively pulled in by the static libraries using > them, right? It's fine either way, though. > > > + install : true, > > + version : '1.5.0', > > Looks

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

FWIW it looks like this series also broke compilation on mac os (I suppose that was f0d3a4de75fdb865c058aba8614f0fe6ba5f0969 though): [...truncated 173 lines...] pthread_barrier_destroy(barrier); ^~~

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

On Thu 09 Nov 2017, Eric Engestrom wrote: > On Wednesday, 2017-11-08 13:40:13 -0800, Chad Versace wrote: > > On Tue 07 Nov 2017, Dylan Baker wrote: > > > Quoting Eric Engestrom (2017-11-07 07:25:53) > > > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > > > I tested this in a

Re: [Mesa-dev] [PATCH 1/3] i965: Make a better helper function for UBO/SSBO/ABO surface handling.

On Thursday, November 9, 2017 12:31:18 PM PST Jason Ekstrand wrote: > On Thu, Nov 9, 2017 at 12:45 AM, Kenneth Graunke > wrote: > > > This fixes the missing AutomaticSize handling in the ABO code, removes > > a bunch of duplicated code, and drops an extra layer of wrapping

[Mesa-dev] [PATCH 2/5] radeonsi: do 64-bit LDS loads recursively

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index ff4ea95..ec4cf89 100644 ---

[Mesa-dev] [PATCH 5/5] radeonsi: use ac.lds for shared memory

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 2 -- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 3/5] ac: LDS stores in LS and ES don't have to be volatile

From: Marek Olšák I like the writeonly wrapper more than using ac_build_store directly. --- src/amd/common/ac_llvm_build.c | 6 ++ src/amd/common/ac_llvm_build.h | 2 ++ src/amd/common/ac_nir_to_llvm.c | 4 ++--

[Mesa-dev] [PATCH 4/5] ac: LDS loads of TCS and GS inputs can be non-volatile and invariant

From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 6 ++ src/amd/common/ac_llvm_build.h | 2 ++ src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.c | 25 ++--- 4 files changed, 24

[Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

Hi, This fixes the TCS gl_ClipDistance piglit failure that was uncovered by a recent LLVM change. The solution is to set volatile on loads and stores to enforce proper ordering. Please review. Thanks, Marek ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/5] ac: mark LDS loads and stores as volatile

From: Marek Olšák LLVM uses arbitrary scheduling if we don't set volatile. volatile is a keyword, so use Volatile --- src/amd/common/ac_llvm_build.c | 38 src/amd/common/ac_llvm_build.h | 13 ---

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

On 11/09/2017 02:41 PM, Nicolai Hähnle wrote: Sorry for the mess. Not a huge deal. FWIW, you can test the MinGW cross-compile pretty easily: 1. apt-get install g++-mingw-w64-x86-64 (or equivalent) 2. cd mesa ; scons platform=windows -Brian Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] autotools: Set C++ visibility flags on Intel

On Thu, Nov 9, 2017 at 1:58 PM, Dylan Baker wrote: > These flags are set for C sources, but not C++. This causes symbol > visibility leaks from the C++ parts of the Intel compiler. > > fixes: 700bebb958e93f4d ("i965: Move the back-end compiler to > src/intel/compiler")

Re: [Mesa-dev] [PATCH] intel/fs: Use a pure vertical stride for large register strides

On Thu, Nov 2, 2017 at 3:54 PM, Jason Ekstrand wrote: > Register strides higher than 4 are uncommon but they can happen. For > instance, if you have a 64-bit extract_u8 operation, we turn that into > UB -> UQ MOV with a source stride of 8. Our previous calculation would >

[Mesa-dev] [PATCH] autotools: Set C++ visibility flags on Intel

These flags are set for C sources, but not C++. This causes symbol visibility leaks from the C++ parts of the Intel compiler. fixes: 700bebb958e93f4d ("i965: Move the back-end compiler to src/intel/compiler") Signed-off-by: Dylan Baker --- src/intel/Makefile.am | 3

[Mesa-dev] [PATCH 1/3] glx: Lower GLX opcode lookup into SendMakeCurrentRequest

Signed-off-by: Adam Jackson --- src/glx/indirect_glx.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 4302a8ff28..cfae12f6c0 100644 --- a/src/glx/indirect_glx.c +++

[Mesa-dev] [PATCH 0/3] Misc GLX cleanups

Testing the EXT_no_config_context series revealed that a bunch more things were broken than I expected. While I work my way through that, here's one trivial cleanup and a couple of pretty obvious bugfixes. - ajax ___ mesa-dev mailing list

[Mesa-dev] [PATCH 3/3] glx/dri3: Fix passing renderType into glXCreateContext

Without this, trying to create a GLX_RGBA_FLOAT_TYPE_ARB context would fail, because GLX_RGBA_TYPE would be a mismatch with the fbconfig. Signed-off-by: Adam Jackson --- src/glx/dri3_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c

[Mesa-dev] [PATCH 2/3] glx/drisw: Fix glXMakeCurrent(dpy, None, ctx)

This is perfectly legal in GL 3.0+. Fixes piglit/glx-create-context-no-current-framebuffer. Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index

Re: [Mesa-dev] [PATCH] i965: Pretend there are 4 subslices for compute shader threads on Gen9+.

On Thursday, November 9, 2017 11:22:34 AM PST Rafael Antognolli wrote: > On Thu, Nov 09, 2017 at 12:59:12AM -0800, Jordan Justen wrote: > > Reviewed-by: Jordan Justen > > It's also > > Tested-by: Rafael Antognolli Sorry, I forgot to sync

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

Sorry for the mess. Reviewed-by: Nicolai Hähnle On 09.11.2017 17:46, Brian Paul wrote: Fixes: f1a364878431c8 ("threads: update for late C11 changes") --- include/c11/threads_win32.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] i965/fs: Split all 32->64-bit MOVs on CHV, BXT, GLK

Fixes the following tests on CHV, BXT, and GLK: KHR-GL46.shader_ballot_tests.ShaderBallotFunctionBallot dEQP-VK.spirv_assembly.instruction.compute.uconvert.uint32_to_int64 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103115 --- src/intel/compiler/brw_fs_nir.cpp | 8 1

Re: [Mesa-dev] [PATCH 0/4] st/mesa: use asynchronous flushes

Reviewed-by: Andres Rodriguez Been going through these patches as they are tightly related to the semaphore series I'm working on. Regards, Andres On 2017-11-09 08:45 AM, Nicolai Hähnle wrote: Hi all, I've previously sent some of this series, but I'm splitting it up

Re: [Mesa-dev] [PATCH] st/mesa: remove 'struct' keyword on function parameter

Reviewed-by; Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 11:31:16 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: remove 'struct' keyword on function

Re: [Mesa-dev] [PATCH 3/3] i965: Fold ABO state upload code into the SSBO/UBO state upload code.

On Thu, Nov 9, 2017 at 12:45 AM, Kenneth Graunke wrote: > Having this separate could potentially make programs that rebind atomics > but no other surfaces ever so slightly faster. But it's a tiny amount > of code to add to the existing UBO/SSBO atom, and very related. > >

Re: [Mesa-dev] [PATCH 1/3] i965: Make a better helper function for UBO/SSBO/ABO surface handling.

On Thu, Nov 9, 2017 at 12:45 AM, Kenneth Graunke wrote: > This fixes the missing AutomaticSize handling in the ABO code, removes > a bunch of duplicated code, and drops an extra layer of wrapping around > brw_emit_buffer_surface_state(). > --- >

Re: [Mesa-dev] [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes

For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 11:31:42 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 3/3] mesa: s/GLint/gl_buffer_index/

Re: [Mesa-dev] [PATCH] swr: Fixed an uncommon freed-memory access during state validation

Looks good.. Reviewed-By: George Kyriazis > On Nov 8, 2017, at 6:39 PM, Bruce Cherniak > wrote: State validation is performed during clear and draw calls. Validation during

[Mesa-dev] [PATCH] mesa/st/nir: assign driver_location for images

Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index e9a8d6414e7..b748e13de1b 100644 ---

[Mesa-dev] [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes

Also fix local variable declarations and replace -1 with BUFFER_NONE. No Piglit changes. --- src/mesa/drivers/common/meta.c | 2 +- src/mesa/main/buffers.c | 16 src/mesa/main/clear.c| 9 + src/mesa/main/framebuffer.c | 4

[Mesa-dev] [PATCH 1/3] mesa: minor reformatting, add const to gl_external_samplers()

This function should probably be moved elsewhere, too. --- src/mesa/main/mtypes.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d092630..af9115e 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@

[Mesa-dev] [PATCH 2/3] mesa: s/GLint/gl_buffer_index/ for _ColorReadBufferIndex

BUFFER_NONE is -1 so no reason for GLint. --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index af9115e..a8e2b39 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3484,7 +3484,7 @@

[Mesa-dev] [PATCH] st/mesa: remove 'struct' keyword on function parameter

st_src_reg is a class, not a struct. Simply remove 'struct' to silence a MSVC compiler warning (class vs. struct mismatch). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] radv: do not wait for idle when SURFACE_SYNC is emitted

IIRC if we wait using SURFACE_SYNC other waits in other rings seemed to sometimes get insanely long, almost like it got stuck behind it. However, the shader waits don't have this issue. On Thu, Nov 9, 2017 at 8:00 PM, Marek Olšák wrote: > What high priority interactions? > >

Re: [Mesa-dev] [PATCH] i965: Pretend there are 4 subslices for compute shader threads on Gen9+.

On Thu, Nov 09, 2017 at 12:59:12AM -0800, Jordan Justen wrote: > Reviewed-by: Jordan Justen It's also Tested-by: Rafael Antognolli > On 2017-11-08 10:56:00, Kenneth Graunke wrote: > > Similar to what we did for pixel shader threads - see

[Mesa-dev] [PATCH 2/2] anv/gen10: Enable float blend optimization

On CNL this bit has been moved to CACHE_MODE_SS register. We already have this enabled in OpenGL driver. See Mesa commit 6c681b4cc1 Signed-off-by: Anuj Phogat Cc: Nanley Chery Cc: Rafael Antognolli ---

[Mesa-dev] [PATCH] st/dri: fix android fence regression

From: Marek Olšák Fixes piglit - egl_khr_fence_sync/android_native tests. Broken by 884a0b2a9e55d4c1ca39475b50d9af598d7d7280. --- src/gallium/include/state_tracker/st_api.h | 2 ++ src/gallium/state_trackers/dri/dri_helpers.c | 2 +- src/mesa/state_tracker/st_manager.c

[Mesa-dev] [PATCH 1/2] anv/gen10: Implement WaSampleOffsetIZ workaround

We already have this workaround in OpenGL driver. See Mesa commit 3cf4fe2219. Signed-off-by: Anuj Phogat Cc: Nanley Chery Cc: Rafael Antognolli --- src/intel/vulkan/genX_state.c | 61

Re: [Mesa-dev] [PATCH 2/3] intel/fs: Don't let undefined values prevent copy propagation.

Reviewed-by: Jason Ekstrand On Fri, Oct 27, 2017 at 5:05 PM, Francisco Jerez wrote: > This makes the dataflow propagation logic of the copy propagation pass > more intelligent in cases where the destination of a copy is known to > be undefined for

Re: [Mesa-dev] [PATCH v2 07/26] winsys/amdgpu: handle cs_add_fence_dependency for deferred/unsubmitted fences

FYI, this breaks: piglit/bin/bufferstorage-persistent read -auto and a bunch of others. Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The idea is to fix the following interleaving of operations > that can

[Mesa-dev] [PATCH 3/5] r600: use ieee version of rcp

From: Roland Scheidegger r600 used the clamped version for rcp, whereas both evergreen and cayman used the ieee version. I don't know why that discrepancy exists (it does so since day 1) but there does not seem to be a valid reason for this, so make it consistent. This seems

Re: [Mesa-dev] [PATCH] radv: do not wait for idle when SURFACE_SYNC is emitted

What high priority interactions? Marek On Thu, Nov 9, 2017 at 6:22 PM, Bas Nieuwenhuizen wrote: > Nack. We had that and Andres removed it due to high priority interactions. > > > On 9 Nov 2017 18:01, "Samuel Pitoiset" wrote: > > Copied from

[Mesa-dev] [PATCH 4/5] r600: use ieee version of rsq

From: Roland Scheidegger Both r600 and evergreen used the clamped version, whereas cayman used the ieee one. I don't think there's a valid reason for this discrepancy, so let's switch to the ieee version for r600 and evergreen too, since we generally want to stick to ieee

[Mesa-dev] [PATCH 1/5] r600: use min_dx10/max_dx10 instead of min/max

From: Roland Scheidegger I believe this is the safe thing to do, especially ever since the driver actually generates NaNs for muls too. The ISA docs are not very helpful here, however the dx10 versions will pick a non-nan result over a NaN one (this is also the ieee754

[Mesa-dev] [PATCH 5/5] r600: set the number type correctly for float rts in cb setup

From: Roland Scheidegger Float rts were always set as unorm instead of float. Not sure of the consequences, but at least it looks like the blend clamp would have been enabled, which is against the rules (only eg really bothered to even attempt to specify this correctly, r600

[Mesa-dev] [PATCH 2/5] r600: use DX10_CLAMP bit in shader setup

From: Roland Scheidegger The docs are not very concise in what this really does, however both Alex Deucher and Nicolai Hähnle suggested this only really affects instructions using the CLAMP output modifier, and I've confirmed that with the newly changed piglit isinf_and_isnan

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

Looks alright to me. Reviewed-by: Roland Scheidegger Am 09.11.2017 um 17:46 schrieb Brian Paul: > Fixes: f1a364878431c8 ("threads: update for late C11 changes") > --- > include/c11/threads_win32.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 3/4] r600: use ieee version of rcp

Am 09.11.2017 um 18:58 schrieb Roland Scheidegger: > Am 09.11.2017 um 18:27 schrieb Jan Vesely: >> On Thu, 2017-11-09 at 03:58 +0100, srol...@vmware.com wrote: >>> From: Roland Scheidegger >>> >>> r600 used the clamped version for rcp, whereas both evergreen and cayman >>>

Re: [Mesa-dev] [PATCH 3/4] r600: use ieee version of rcp

Am 09.11.2017 um 18:27 schrieb Jan Vesely: > On Thu, 2017-11-09 at 03:58 +0100, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> r600 used the clamped version for rcp, whereas both evergreen and cayman >> used the ieee version. I don't know why that discrepancy

Re: [Mesa-dev] [PATCH 1/4] r600: use min_dx10/max_dx10 instead of min/max

Am 09.11.2017 um 18:43 schrieb Jan Vesely: > On Thu, 2017-11-09 at 18:39 +0100, Nicolai Hähnle wrote: >> On 09.11.2017 18:26, Roland Scheidegger wrote: >>> Am 09.11.2017 um 18:19 schrieb Jan Vesely: On Thu, 2017-11-09 at 03:58 +0100, srol...@vmware.com wrote: > From: Roland Scheidegger

Re: [Mesa-dev] [PATCH 1/4] r600: use min_dx10/max_dx10 instead of min/max

On Thu, 2017-11-09 at 18:39 +0100, Nicolai Hähnle wrote: > On 09.11.2017 18:26, Roland Scheidegger wrote: > > Am 09.11.2017 um 18:19 schrieb Jan Vesely: > > > On Thu, 2017-11-09 at 03:58 +0100, srol...@vmware.com wrote: > > > > From: Roland Scheidegger > > > > > > > > I

Re: [Mesa-dev] [PATCH] i965: disable BLORP color clears for gen 4-5

On 9 November 2017 at 17:23, Jason Ekstrand wrote: > This is a really rubbish solution. Yes, it fixes a crash in MPV but unless > we disable all blorp on gen4-5 (which I don't think is possible anymore), we > haven't actually fixed it for real. > Fully agreed - it is nasty.

Re: [Mesa-dev] [PATCH 1/4] r600: use min_dx10/max_dx10 instead of min/max

On 09.11.2017 18:26, Roland Scheidegger wrote: Am 09.11.2017 um 18:19 schrieb Jan Vesely: On Thu, 2017-11-09 at 03:58 +0100, srol...@vmware.com wrote: From: Roland Scheidegger I believe this is the safe thing to do, especially ever since the driver actually generates NaNs

  1   2   >