[Mesa-dev] [PATCH 16/16] src/intel/tools: add BatchbufferLogger to meson build system

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- meson_options.txt | 6 src/intel/tools/meson.build | 71 + 2 files changed, 77 insertions(+) diff --git a/meson_options.txt

Re: [Mesa-dev] [PATCH v2 00/25] Initial gl_spirv and spirv_extensions support in Mesa and i965

On 12/12/2017 03:01 AM, Ian Romanick wrote: > Any chance you could push an updated branch to your github? :) Yes, sure. I was meant to send the v3 series already yesterday. I just pushed the latest version of this series to. And

[Mesa-dev] [PATCH 15/16] intel/tools: add command line GEN shader disassembler tool

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/Makefile.tools.am | 21 ++- src/intel/tools/.gitignore| 1 + src/intel/tools/gen_shader_disassembler.c | 213 ++ 3 files

[Mesa-dev] [PATCH 14/16] intel/tools/BatchbufferLogger (output-json): add json outputter

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/Makefile.tools.am| 6 +- src/intel/tools/.gitignore | 1 + .../tools/i965_batchbuffer_dump_show_json.cpp | 253

[Mesa-dev] [PATCH 12/16] intel/tools/BatchbufferLogger (txt-output): example txt dumper

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/Makefile.tools.am | 5 + src/intel/tools/.gitignore | 1 + src/intel/tools/i965_batchbuffer_dump_show.c | 135 +++ 3

[Mesa-dev] [PATCH 09/16] intel/compiler: add print_offsets argument to brw_disassemble()

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/compiler/brw_compile_clip.c | 4 +++- src/intel/compiler/brw_compile_sf.c | 4 +++- src/intel/compiler/brw_disasm_info.c | 4 +++-

[Mesa-dev] [PATCH 08/16] intel/common: add new debug option print_offsets options for dumping assembly

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c index

[Mesa-dev] [PATCH 13/16] intel/tools/BatchbufferLogger (output-xml): add outputter to XML

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/Makefile.tools.am| 6 +- src/intel/tools/.gitignore | 1 + src/intel/tools/i965_batchbuffer_dump_show_xml.cpp | 217

[Mesa-dev] [PATCH 11/16] intel/tools/BatchbufferLogger: install i965_batchbuffer non-driver interface headers

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/Makefile.tools.am | 12 +++ src/intel/tools/.gitignore| 1 + src/intel/tools/i965_batchbuffer_logger_sh.in | 108 ++

[Mesa-dev] [PATCH 06/16] intel/tools/disasm: gen_disasm_disassemble to take const void* instead of void*

From: Kevin Rogovin Reviewed-by: Matt Turner Signed-off-by: Kevin Rogovin --- src/intel/tools/disasm.c | 6 +++--- src/intel/tools/gen_disasm.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/tools/disasm.c

[Mesa-dev] [PATCH 03/16] intel/tools: BatchBufferLogger define output file format of tool

From: Kevin Rogovin Define the output format of the BatchbufferLogger. The output is a sequence of blocks where blocks can have member blocks or values. The top level blocks come from the application calling into the BatchBufferLogger when an GL/GLES API call is started

[Mesa-dev] [PATCH 07/16] intel/tools/disasm: add gen_disasm_assembly_length function

From: Kevin Rogovin The length function is needed if one wishes to save GEN binary shaders to file. Signed-off-by: Kevin Rogovin --- src/intel/tools/disasm.c | 7 +++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed, 9

[Mesa-dev] [PATCH 05/16] i965: Enable BatchbufferLogger in i965 driver

From: Kevin Rogovin The interface for BatchbufferLogger is that it is active only if it is LD_PRELOAD'ed. Thus, the i965 driver is to use dlsym to see if it is there, and if so fetch the object at intel_screen creation. Signed-off-by: Kevin Rogovin

[Mesa-dev] [PATCH 04/16] i965: assign BindingTableEntryCount of INTERFACE_DESCRIPTOR_DATA

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/genX_state_upload.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c

[Mesa-dev] [PATCH 01/16] intel/tools: define BatchBufferLogger driver interface

From: Kevin Rogovin Define the driver interface for BatchbufferLogger. The interface assumes that for any -thread- there is only one batchbuffer to which commands are to be added. A driver needs to provide the information on what is the active batchbuffer on a calling

[Mesa-dev] [PATCH 02/16] intel/tools: define BatchbufferLogger application interface

From: Kevin Rogovin Define the application interface to BatchbufferLogger. The BatchbufferLogger needs from the application when a GL/GLES API call is issues and returns. It will use this information to correctly correlate batchbuffer additions to GL/GLES API calls. In

[Mesa-dev] [PATCH 00/16] Batchbuffer Logger for Intel GPU (v3)

From: Kevin Rogovin This patch series defines and implements a BatchbufferLogger for Intel GEN. The main purpose of the BatchbufferLogger is to strongly correlate API calls to data added to a batchbuffer. In addition to this function, the BatchbufferLogger also tracks

Re: [Mesa-dev] [PATCH] i965/nir: do int64 lowering before optimization

On Mon, 2017-12-11 at 08:01 -0800, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral > wrote: > > This didn't get any reviews yet. Any takers? > > > > > > > > On Fri, 2017-12-01 at 13:46 +0100, Iago Toral Quiroga wrote: > > > > > Otherwise loop unrolling

[Mesa-dev] [Bug 101560] SPIR-V OpSwitch with int64 not supported even though shaderInt64 is true

https://bugs.freedesktop.org/show_bug.cgi?id=101560 Jason Ekstrand changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

On 28/11/17 11:07, Samuel Iglesias Gonsálvez wrote: > This patch is still unreviewed. > Gently reminder. Sam > Sam > > On Tue, 2017-11-14 at 09:45 +0100, Samuel Iglesias Gonsálvez wrote: >> The HW has some limits but, according to the spec, we can create >> the image as it has not yet any

[Mesa-dev] [PATCH 2/2] i965: Enable CCS_E sampling of sRGB textures as UNORM

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index b87d356..e21e1da 100644 ---

[Mesa-dev] [PATCH 1/2] i965/draw: Do resolves properly for textures used by TXF

--- src/mesa/drivers/dri/i965/brw_draw.c | 41 1 file changed, 41 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 7e29dcf..549735d 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++

Re: [Mesa-dev] [PATCH 2/2] nir: fix shift for uint64_t

How about just using 1ull? On Mon, Dec 11, 2017 at 7:47 PM, Timothy Arceri wrote: > --- > src/compiler/nir/nir_lower_io_arrays_to_elements.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c >

[Mesa-dev] [PATCH] ac: fix nir_op_f2f64

Without this we get the error "FPExt only operates on FP" when converting the following: vec1 32 ssa_5 = b2f ssa_4 vec1 64 ssa_6 = f2f64 ssa_5 Which results in: %44 = and i32 %43, 1065353216 %45 = fpext i32 %44 to double With this patch we now get: %44 = and i32 %43, 1065353216

[Mesa-dev] [PATCH 2/2] nir: fix shift for uint64_t

--- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c b/src/compiler/nir/nir_lower_io_arrays_to_elements.c index dca5719f114..cdf9a76a881 100644 ---

[Mesa-dev] [PATCH 1/2] st/glsl_to_nir: skip forced array splitting for tcs

nir_lower_io_to_temporaries() does not support tcs so we cannot assume there are no indirects here. Also the radeonsi backend (the only backend to support tess) has support for tcs indirects so there is no need to lower them anyway. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 ++- 1 file

Re: [Mesa-dev] [PATCH v2 00/25] Initial gl_spirv and spirv_extensions support in Mesa and i965

Any chance you could push an updated branch to your github? :) On 11/30/2017 09:28 AM, Eduardo Lima Mitev wrote: > Hello, > > This is the second version of the series providing initial support for > ARB_gl_spirv and ARB_spirv_extensions in Mesa and i965. > > First version of the series can be

Re: [Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

On Mon, Dec 11, 2017 at 10:41 PM, Roland Scheidegger wrote: > Am 11.12.2017 um 18:42 schrieb Brian Paul: >> --- >> src/gallium/auxiliary/cso_cache/cso_context.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c >>

Re: [Mesa-dev] [PATCH v2 19/25] mesa/glspirv: Add a _mesa_spirv_link_shaders() placeholder

On 07/12/17 20:59, Eduardo Lima Mitev wrote: On 12/07/2017 05:51 AM, Timothy Arceri wrote: Please squash this with patch 22 tis is just code churn. Ok, this makes sense, though I will have to re-order a bit the patches to keep each single one building fine. None of the patches in between

Re: [Mesa-dev] [PATCH v2 13/25] spirv_extensions: add list of extensions and to_string method

I might be blind but in which patch does this end up being used? Also this and the following patches seem to reinvent a system for exposing extension support. Is there a good reason for not simply expanding extensions_table.h to support tracking the spriv extensions? On 01/12/17 04:28,

Re: [Mesa-dev] [PATCH 01/10] mapi: autotools: remove unused MAPI_FILES file list

Patches 1, 2, and 3 are Reviewed-by: Ian Romanick I'm going to send a trivial nit on patch 4, and I'll try to look at the others later. On 12/07/2017 09:07 AM, Emil Velikov wrote: > From: Emil Velikov > > The sole user was OpenVG, which

Re: [Mesa-dev] [PATCH 04/10] swrast: remove non-applicable GLX_SWAP_COPY_OML comment

On 12/07/2017 09:07 AM, Emil Velikov wrote: > From: Emil Velikov > > Noticed while skimming for GLX_ instances i the dri codebase. in With that fixed, this patch is also Reviewed-by: Ian Romanick

Re: [Mesa-dev] [PATCH 08/29] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

On Mon, Dec 11, 2017 at 03:57:58PM -0800, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 17 - > > 1 file changed, 8 insertions(+), 9 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH v2 6/8] spirv: Add better parameter validation for vector

Reviewed-by: Ian Romanick On 12/11/2017 03:13 PM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c >

Re: [Mesa-dev] [PATCH 08/29] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_tgsi: Add support for SYSTEM_VALUE_BASE_VERTEX_ID

On Wednesday, November 22, 2017 6:03:25 AM PST Neil Roberts wrote: > SYSTEM_VALUE_BASE_VERTEX has changed to be the correct value for > gl_BaseVertex, which means it will be zero when used with a > non-indexed call. The new BASE_VERTEX_ID value can be used as before > as an offset to calculate a

Re: [Mesa-dev] [PATCH 07/29] anv/image: Support color aspects in layout_to_aux_usage

On Mon, Nov 27, 2017 at 07:05:57PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 48 > ++-- > 1 file changed, 29 insertions(+), 19 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git

Re: [Mesa-dev] [PATCH 1/2] freedreno: Update to handle rename of the base vertex ID intrinsic

On Wednesday, November 22, 2017 6:03:24 AM PST Neil Roberts wrote: > The old intrinsic called base_vertex that is used to add to > gl_VertexID is now called base_vertex_id so that base_vertex can be > used for the value of gl_BaseVertex, which is different. As far as I > can tell freedreno doesn’t

Re: [Mesa-dev] [PATCH] spirv: Allow ignoring decorations for workgroup variables

Reviewed-by: Jordan Justen On 2017-12-11 15:34:08, Jason Ekstrand wrote: > Since we switched over to lowering SLM access directly in SPIR-V -> NIR, > we no longer have vtn_variables for SLM. It's all safe as with UBOs and > SSBOs but we need to let it through in the

[Mesa-dev] [PATCH] spirv: Allow ignoring decorations for workgroup variables

Since we switched over to lowering SLM access directly in SPIR-V -> NIR, we no longer have vtn_variables for SLM. It's all safe as with UBOs and SSBOs but we need to let it through in the assert. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104213 Fixes:

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #27 from Germano Massullo --- Screenshots of malfunction https://bugzilla.mozilla.org/attachment.cgi?id=8932561 https://bugzilla.mozilla.org/attachment.cgi?id=8932563(In reply to Germano Massullo from

Re: [Mesa-dev] Gallium ARB_get_program_binary support

I'll check that when I'm next home On Mon, 11 Dec 2017 at 21:19 Timothy Arceri wrote: > On 12/12/17 08:13, Mike Lothian wrote: > > Tested with Dead Island, Dirt Rally and Serious Sam BFG (which I believe > > uses this extension) > > > > Do you know any other games that

[Mesa-dev] [PATCH v2 6/8] spirv: Add better parameter validation for vector

--- src/compiler/spirv/spirv_to_nir.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 82e5c8c..c5d6131 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

Re: [Mesa-dev] [PATCH 7/8] spirv: Restructure the case loop in OpSwitch handling

On 12/11/2017 02:50 PM, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 10:08 AM, Ian Romanick > wrote: > > On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > > Instead of calling vtn_add_case for the default case and then looping, > >

Re: [Mesa-dev] [PATCH 7/8] spirv: Restructure the case loop in OpSwitch handling

On Mon, Dec 11, 2017 at 10:08 AM, Ian Romanick wrote: > On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > > Instead of calling vtn_add_case for the default case and then looping, > > add an is_default variable and do everything inside the loop. This will > > make the next

Re: [Mesa-dev] [PATCH 6/8] spirv: Add better parameter validation for vector and matrix types

On Mon, Dec 11, 2017 at 10:05 AM, Ian Romanick wrote: > On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > > --- > > src/compiler/spirv/spirv_to_nir.c | 14 +++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

On Mon, Dec 11, 2017 at 11:13 AM, Ian Romanick wrote: > On 12/11/2017 10:50 AM, Jason Ekstrand wrote: > > On Mon, Dec 11, 2017 at 9:50 AM, Ian Romanick > > wrote: > > > > On 12/07/2017 08:12 AM, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

Quoting Emil Velikov (2017-12-11 12:06:35) > On 7 December 2017 at 17:25, Dylan Baker wrote: > > Quoting Emil Velikov (2017-12-07 08:40:27) > >> On 7 December 2017 at 14:51, Eric Engestrom > >> wrote: > >> > Bugzilla:

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

On Mon, Dec 11, 2017 at 12:08 PM, Emil Velikov wrote: > On 21 November 2017 at 00:13, Andres Gomez wrote: > > Jason, this nominated series landed without mentioning any specific > > stable queue. > > > > From what I'm seeing, both depend on

Re: [Mesa-dev] [PATCH v2 5/7] nir: Offset vertex_id by first_vertex instead of base_vertex

On Mon, Dec 11, 2017 at 8:43 PM, Ian Romanick wrote: > On 12/04/2017 12:12 PM, Antia Puentes wrote: >> From: Neil Roberts >> >> base_vertex will be zero for non-indexed calls, but we need it to >> include the ‘first’ parameter. This is true for both GL

Re: [Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

Am 11.12.2017 um 18:42 schrieb Brian Paul: > --- > src/gallium/auxiliary/cso_cache/cso_context.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c > b/src/gallium/auxiliary/cso_cache/cso_context.c > index df5543c..dd9821e 100644 > ---

Re: [Mesa-dev] Gallium ARB_get_program_binary support

On 12/12/17 08:13, Mike Lothian wrote: Tested with Dead Island, Dirt Rally and Serious Sam BFG (which I believe uses this extension) Do you know any other games that use this? I believe Dying Light uses it also. On Mon, 11 Dec 2017 at 02:17 Dieter Nützel

Re: [Mesa-dev] [PATCH 21/18] ac: skip type for tcs input on RADV

On 12/12/17 05:44, Dieter Nützel wrote: Tim, I'm somewhat baffled... V1 do not have 20,21 V2 do not have 19,21 V3 do not have 19,20 Which one is right? These are follow-on patches for the tess nir support for radeonsi (v1). The other two patches are standalone but this patch should probably

Re: [Mesa-dev] Gallium ARB_get_program_binary support

Tested with Dead Island, Dirt Rally and Serious Sam BFG (which I believe uses this extension) Do you know any other games that use this? On Mon, 11 Dec 2017 at 02:17 Dieter Nützel wrote: > For the V2 series: > > Tested-by: Dieter Nützel > and >

Re: [Mesa-dev] [PATCH] egl: remove unneeded _eglGetNativePlatform check

On 6 December 2017 at 20:36, Ian Romanick wrote: > Do we have any tests at all that exercise this path? I don't know this > code well enough to feel comfortable reviewing this (says everyone). :( > At first I was thinking that the error "can never happen", although it seems

[Mesa-dev] [PATCH 2/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes a number of Piglit ext_framebuffer_multisample blit tests such as ext_framebuffer_multisample/no-color 2 depth combined with

[Mesa-dev] [PATCH 1/2] gallium/u_blitter: add code to save/set/restore min_samples for msaa

Will be used by the next patch. --- src/gallium/auxiliary/util/u_blitter.c | 8 src/gallium/auxiliary/util/u_blitter.h | 11 +++ 2 files changed, 19 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

On 21 November 2017 at 00:13, Andres Gomez wrote: > Jason, this nominated series landed without mentioning any specific > stable queue. > > From what I'm seeing, both depend on 2c4097aff1b which didn't make it > for 17.2 so I'm dropping them for that queue. > This is a

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

On 28 November 2017 at 13:32, Andres Gomez wrote: > Julien, this looks like a good candidate to nominate for inclusion in > the 17.2 stable queue. > > What do you think? > Based on the discussion in the bugreport, we really want that in 17.2. I've picked it up for 17.2.7,

Re: [Mesa-dev] [PATCH v4 1/2] glsl: allow any l-value of an input variable as interpolant in interpolateAt*

On 28 November 2017 at 14:31, Nicolai Hähnle wrote: > On 28.11.2017 14:58, Andres Gomez wrote: >> >> Nicolai, this looks like a good candidate to nominate for inclusion in >> all the stable queues. >> >> What do you think? > > > It's a rare enough use case, but the change

Re: [Mesa-dev] [Mesa-stable] [PATCH 01/12] i965/fs: Unpack count argument to 64-bit shift ops on Atom

On 29 November 2017 at 03:25, Matt Turner wrote: > On Tue, Nov 28, 2017 at 5:54 AM, Andres Gomez wrote: >> Matt, this looks like a good candidate to nominate for inclusion in >> the 17.2 stable queue. >> >> What do you think? > > Yes, I think so. I didn't

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

Quoting Eric Engestrom (2017-12-11 08:17:50) > On Friday, 2017-12-08 16:27:22 -0800, Dylan Baker wrote: > > This has only been compile tested. > > > > cc: Curro Jerez > > Signed-off-by: Dylan Baker > > --- > > include/meson.build

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

On 7 December 2017 at 17:25, Dylan Baker wrote: > Quoting Emil Velikov (2017-12-07 08:40:27) >> On 7 December 2017 at 14:51, Eric Engestrom >> wrote: >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 >> > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH 1/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

On 12/11/2017 11:06 AM, Marek Olšák wrote: On Thu, Dec 7, 2017 at 5:09 PM, Brian Paul wrote: If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes a number

[Mesa-dev] [ANNOUNCE] Mesa 17.2.7 release candidate

Hello list, The candidate for the Mesa 17.2.7 is now available. Currently we have: - 45 queued - 2 nominated (outstanding) - and 1 rejected patches The current queue consists of a variety of fixes, with a sizeable hunk in the shared GLSL codebase. Whereas for individual drivers - i965 has a

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

Quoting Eric Engestrom (2017-12-11 07:55:30) > On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Should come after the current 4/4, but > Reviewed-by: Eric Engestrom > > > --- > >

Re: [Mesa-dev] [PATCH v2 5/7] nir: Offset vertex_id by first_vertex instead of base_vertex

On 12/04/2017 12:12 PM, Antia Puentes wrote: > From: Neil Roberts > > base_vertex will be zero for non-indexed calls, but we need it to > include the ‘first’ parameter. This is true for both GL and Vulkan. > > I think this patch will also affect freedreno and radeonsi. I

Re: [Mesa-dev] [PATCH v2 4/7] i965: Let nir lower gl_VertexID instead of the linker

I sent this patch a few weeks ago. Since my commit message has additional information, can we use mine instead? https://patchwork.freedesktop.org/patch/189441/ On 12/04/2017 12:12 PM, Antia Puentes wrote: > From: Neil Roberts > > --- >

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

On 12/04/2017 12:12 PM, Antia Puentes wrote: > The new order is: > * VE 1: > * VE 2: > > Previously it was: > * VE 1: > * VE 2: > > The gl_BaseVertex is in a new location now, and firstvertex

Re: [Mesa-dev] [PATCH] gallivm: fix texture wrapping for texture gather for mirror modes

Am 11.12.2017 um 18:39 schrieb Jose Fonseca: > Looks good AFAICT.  Thanks for the detailed comments. I can't really > follow the math to the minutiae, but I trust your testing. > > I wonder how much we gain by maitaining these gather and non-gather > paths.  That is, I wonder if the hit of just

Re: [Mesa-dev] [PATCH v2 1/7] compiler: Add SYSTEM_VALUE_FIRST_VERTEX and instrinsics

On 12/04/2017 12:12 PM, Antia Puentes wrote: > This VS system value will contain the value passed as > for indexed draw calls or the value passed as for non-indexed > draw calls. It will be used to calculate the gl_VertexID as > SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_FIRST_VERTEX. >

Re: [Mesa-dev] [PATCH 1/4] meson: Build SWR driver

Quoting Eric Engestrom (2017-12-11 07:49:07) > > +if with_gallium_swr > > + if meson.version().version_compare('< 0.44.0') > > +error('SWR requires meson 0.44.0 or greater.') > > + endif > > Mixed feelings about this, but I guess I'd rather land this now and > remove these three lines

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

On 12/11/2017 10:50 AM, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 9:50 AM, Ian Romanick > wrote: > > On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > > This autogenerated pass will automatically find and set the type field > >

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

On Tuesday, December 5, 2017 3:23:03 PM PST Kenneth Graunke wrote: > Reviewed-by: Kenneth Graunke It turns out that patches 1-3 by themselves cause piles of Piglit and CTS failures. Please make sure the series doesn't cause regressions at each step along the way. For

Re: [Mesa-dev] [PATCH 1/3] nir: Fix interaction of GL_CLAMP lowering with texture offsets.

For some reason the patches didn't show up in my inbox, but I found it on patchwork. Series is Reviewed-by: Ian Romanick On 12/06/2017 07:10 PM, Eric Anholt wrote: > Eric Anholt writes: > >> We want the clamping of the coordinate to apply after the

Re: [Mesa-dev] [PATCH 9/9] mesa: always compare optype with symbolic name in ATI_fs

For the series: Reviewed-by: Marek Olšák Marek On Sat, Dec 2, 2017 at 11:35 PM, Miklós Máté wrote: > Signed-off-by: Miklós Máté > --- > src/mesa/main/atifragshader.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

On Mon, Dec 11, 2017 at 9:50 AM, Ian Romanick wrote: > On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > > This autogenerated pass will automatically find and set the type field > > on all vtn_values. This way we always have the type and can use it for > > validation and

Re: [Mesa-dev] [PATCH 21/18] ac: skip type for tcs input on RADV

Tim, I'm somewhat baffled... V1 do not have 20,21 V2 do not have 19,21 V3 do not have 19,20 Which one is right? Thanks, Dieter Am 11.12.2017 10:56, schrieb Timothy Arceri: The type can be a struct on RADV and causes an assert() to be thrown, for radeonsi all structs should have been lowered

Re: [Mesa-dev] [PATCH 2/2] gallium/util: don't pass a pipe_resource to util_resource_is_array_texture()

Reviewed-by: Marek Olšák Marek On Thu, Dec 7, 2017 at 11:25 PM, Brian Paul wrote: > No need to pass a pipe_resource when we can just pass the target. > This makes the function potentially more usable. Rename it too. > --- >

Re: [Mesa-dev] [PATCH mesa] i915: add missing 0 defines

Reviewed-by: Ian Romanick On 12/04/2017 06:52 AM, Eric Engestrom wrote: > Thanks to Emil's -Wundef, t_dd_dmatmp.h now complains that intel_render.c > is missing a couple `#define`s. > > Assigning them to 0 keeps the existing behaviour; I'll let someone else > turn them

Re: [Mesa-dev] testing for certain compiler options does not work

On 12/07/2017 02:15 AM, Marc Dietrich wrote: > Hi Ian, > > Am Mittwoch, 6. Dezember 2017, 21:21:53 CET schrieb Ian Romanick: >> On 11/29/2017 08:16 AM, Marc Dietrich wrote: >>> Hi, >>> >>> just found that my gcc 'gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch >>> revision 253932]' does not warn

Re: [Mesa-dev] [PATCH 1/2] gallium/aux: include nr_samples in util_resource_size() computation

Reviewed-by: Marek Olšák Marek On Thu, Dec 7, 2017 at 11:25 PM, Brian Paul wrote: > This function is only used in two places: > 1. VMware driver, but only for HUD reporting > 2. st/nine state tracker, used for texture memory accounting > --- >

Re: [Mesa-dev] [PATCH 8/8] spirv: Add support for all bit sizes in OpSwitch

This patch is Reviewed-by: Ian Romanick On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101560 > Cc: Juan A. Suarez Romero > --- > src/compiler/spirv/vtn_cfg.c | 33

Re: [Mesa-dev] [PATCH 7/8] spirv: Restructure the case loop in OpSwitch handling

On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > Instead of calling vtn_add_case for the default case and then looping, > add an is_default variable and do everything inside the loop. This will > make the next commit easier. > --- > src/compiler/spirv/vtn_cfg.c | 17 ++--- > 1 file

Re: [Mesa-dev] [PATCH 2/2] gallium/u_blitter: replace tabs with spaces

Reviewed-by: Marek Olšák Marek On Thu, Dec 7, 2017 at 5:09 PM, Brian Paul wrote: > --- > src/gallium/auxiliary/util/u_blitter.c | 36 > +- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

On Thu, Dec 7, 2017 at 5:09 PM, Brian Paul wrote: > If we're doing a Z -> Z MSAA blit (for example) we need to enable > msaa rasterization when drawing the quads so that we can properly > write the per-sample values. > > This fixes a number of Piglit ext_framebuffer_multisample

Re: [Mesa-dev] [PATCH 6/8] spirv: Add better parameter validation for vector and matrix types

On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c > index 11c8c2a..4b93b11 100644 > ---

Re: [Mesa-dev] [PATCH 4/8] spirv: Set lengths on scalar and vector types

This patch is Reviewed-by: Ian Romanick On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c >

Re: [Mesa-dev] [PATCH 5/8] spirv: Add type validation for OpSelect

On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c > index 253a012..11c8c2a 100644 > ---

Re: [Mesa-dev] [PATCH 1/8] spirv: Add a vtn_type field to all vtn_values

This patch is Reviewed-by: Ian Romanick On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > At the moment, this just lets us drop the const_type for constants and > unify things a bit. Eventually, we will use this to store the types of > all SPIR-V SSA values. > --- >

Re: [Mesa-dev] [PATCH] gallivm: fix texture wrapping for texture gather for mirror modes

Looks good AFAICT. Thanks for the detailed comments. I can't really follow the math to the minutiae, but I trust your testing. I wonder how much we gain by maitaining these gather and non-gather paths. That is, I wonder if the hit of just using the more accurate gather paths is

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

On 12/07/2017 02:26 PM, Jason Ekstrand wrote: > On Thu, Dec 7, 2017 at 11:54 AM, Michael Schellenberger Costa > > wrote: > > Hi Jason, > > > Am 07.12.2017 um 17:12 schrieb Jason Ekstrand: > > ---

Re: [Mesa-dev] [PATCH] winsys/amdgpu: disable local BOs again due to worse performance

On 11.12.2017 16:31, Marek Olšák wrote: From: Marek Olšák Cc: 17.3 Reviewed-by: Nicolai Hähnle --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

On 12/07/2017 08:12 AM, Jason Ekstrand wrote: > This autogenerated pass will automatically find and set the type field > on all vtn_values. This way we always have the type and can use it for > validation and other checks. > --- > src/compiler/Makefile.nir.am | 4 + >

Re: [Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

On 11.12.2017 18:42, Brian Paul wrote: --- src/gallium/auxiliary/cso_cache/cso_context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index df5543c..dd9821e 100644 ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] xlib: call _mesa_warning() instead of fprintf()

Reviewed-by: Ian Romanick On 12/11/2017 09:42 AM, Brian Paul wrote: > We use _mesa_warning() everywhere else in this code. Change requested > by Rick Irons of Mathworks. > > CC: > --- > src/mesa/drivers/x11/fakeglx.c | 3 ++- > 1

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #4 from Sven --- Yes, I can reproduce the issue with steam overlay disabled. I will have to try gdb some other day when I have some more time. -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [PATCH] cso: add point rasterization sanity check assertion

--- src/gallium/auxiliary/cso_cache/cso_context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index df5543c..dd9821e 100644 --- a/src/gallium/auxiliary/cso_cache/cso_context.c +++

[Mesa-dev] [PATCH] xlib: call _mesa_warning() instead of fprintf()

We use _mesa_warning() everywhere else in this code. Change requested by Rick Irons of Mathworks. CC: --- src/mesa/drivers/x11/fakeglx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c

Re: [Mesa-dev] [PATCH 11/20] mesa: reduce the size of gl_vertex_array_object

On Wed, Nov 22, 2017 at 11:10 PM, Ian Romanick wrote: > On 11/21/2017 10:01 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> RelativeOffset should actually be uint, not intptr, >> according to ARB_vertex_attrib_binding. >> >> gl_vertex_array_object:

  1   2   >