Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

Do we really want to wait until a subpass that uses the given view or do we just want to clear all of the relevant slices in the first subpass that touches it? I haven't really thought about this much. On Fri, Jan 5, 2018 at 8:38 AM, Iago Toral Quiroga wrote: > When

Re: [Mesa-dev] [PATCH 1/2] anv/blorp: only clear enabled views when multiview is used

On Fri, Jan 5, 2018 at 1:28 AM, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/anv_blorp.c | 55 ++ > ++ > 1 file changed, 40 insertions(+), 15 deletions(-) > > diff --git a/src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH 1/2] i965/miptree: Take an aux_usage in prepare/finish_render

Both patches are: Reviewed-by: Iago Toral Quiroga On Tue, 2018-01-23 at 01:33 -0800, Jason Ekstrand wrote: > Both callers of intel_miptree_prepare/finish_render have to call > intel_miptree_render_aux_usage anyway for other reasons. They may as > well pass the result in

Re: [Mesa-dev] [PATCH 1/1] nir: Use a freelist in nir_opt_dce to avoid spamming ralloc

2018-01-21 23:58 GMT+01:00 Eric Anholt : > Thomas Helland writes: > >> Also, allocate worklist_elem in groups of 20, to reduce the burden of >> allocation. Do not use rzalloc, as there is no need. This lets us drop >> the number of calls to ralloc from

Re: [Mesa-dev] [PATCH] anv/pipeline: lower constant initializers on output variables earlier

This is still waiting for review, any takers? On Wed, 2018-01-17 at 09:08 +0100, Iago Toral Quiroga wrote: > If a shader only writes to an output via a constant initializer we > need to lower it before we call nir_remove_dead_variables so that > this pass sees the stores from the initializer and

Re: [Mesa-dev] [PATCH v2 1/3] anv/blorp: only clear enabled views when multiview is used

This is still unreviewed, any chances that someone can have a look and provide feedback? This is required to pass new tests that will be merged in CTS soon. Iago On Fri, 2018-01-05 at 17:38 +0100, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/anv_blorp.c | 55

Re: [Mesa-dev] [PATCH 1/4] Revert "anv/meson: Make anv_entrypoints_gen.py depend on anv_extensions.py"

I am not a meson expert but changes look fine. The series is: Reviewed-by: Samuel Iglesias Gonsálvez Sam On 23/01/18 18:44, Dylan Baker wrote: > This reverts commit 10d1b0be8e9c463dbc35cd66968299f33c76672c. > > This is unnecessary, the depend_files argument is for adding

Re: [Mesa-dev] [PATCH] anv: correct a duplicate check in an assert

Reviewed-by: Tapani Pälli On 23.01.2018 00:57, Grazvydas Ignotas wrote: Looks like checking both sources was intended, instead of the first one twice. Found with Coccinelle, coccinellery/xand/xand.cocci semantic patch. Signed-off-by: Grazvydas Ignotas

Re: [Mesa-dev] [PATCH] i965: Mark the workaround BO with EXEC_OBJECT_WRITE in BLORP.

On Tuesday, January 23, 2018 1:32:53 AM PST Chris Wilson wrote: > Quoting Kenneth Graunke (2018-01-23 09:28:20) > > The purpose of the workaround BO is to write to it. > > Do you care for the serialisation here? I thought the purpose of the wa > was just for write-only memory, so lying to the

[Mesa-dev] [PATCH] radv: enable two other DB_EQAA bits.

From: Dave Airlie amdvlk appears to enable these bits always, no explaination of why. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c

[Mesa-dev] [PATCH] radv: don't enable tc compat for d32s8 + 4/8 samples

From: Dave Airlie This seems to be broken, at least the cts tests fail. This fixes: dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_4 dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_8 2 samples seems to pass fine, amdvlk

Re: [Mesa-dev] [PATCH 1/3] st/glsl_to_tgsi: move nir detection earlier and set nir options

For the series: Tested-by: Dieter Nützel on RX580 with UH (even wireframe mode works, now - GREAT!), UV, US, glmark2, Blender 2.79, DiRT Rally, F1 2017 and smoketest --- all I throw at it. Together with: [Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once,

[Mesa-dev] [Bug 101814] es2gears_wayland only achieves 40 FPS (in Weston and Gnome Shell)

https://bugs.freedesktop.org/show_bug.cgi?id=101814 --- Comment #4 from Daniel van Vugt --- Thanks. It looks like mesa-demos hasn't had a release for 2 years... https://cgit.freedesktop.org/mesa/demos/ So this fix still isn't released either. Any idea of when a

Re: [Mesa-dev] [PATCH] vbo: fix incorrect min/max_index values in display list draw call

On 01/23/2018 05:59 PM, Clayton Craft wrote: On Tue, Jan 23, 2018 at 11:44:01AM -0700, Brian Paul wrote: This fixes another regression from commit 8e4efdc895ea ("vbo: optimize some display list drawing").  The problem was the min_index, max_index values passed to the vbo drawing function were

[Mesa-dev] [PATCH] radv: add multisample Z optimisation from amdvlk

From: Dave Airlie This was just found while reading for other stuff, rc/core/hw/gfxip/gfx6/gfx6DepthStencilView.cpp. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible (v2)

Tested-by: Dieter Nützel on RX580 with UH, UV, US, glmark2, Blender 2.79, DiRT Rally, F1 2017 and smoketest Together with: Mesa-dev] [PATCH 1/3] st/glsl_to_tgsi: move nir detection earlier and set nir options Am 23.01.2018 21:14, schrieb Kai Wasserbäch: Changes

[Mesa-dev] [PATCH] radv: move spi_baryc_cntl to pipeline

From: Dave Airlie We need to enable the pos float location 2 mode anytime we have persample not just when forced by the frag shader. This fixes: dEQP-VK.pipeline.multisample.min_sample_shading* Fixes: 58c97a079 (radv: enable location at sample when persample is forced.)

Re: [Mesa-dev] Add interpolateAt builtin support to the radeonsi nir backend

On 24/01/18 11:44, Dieter Nützel wrote: Rebase underway? ;-) Please direct these type of questions to IRC, rather than creating extra traffic and threads on the mailing list. Am 15.01.2018 04:46, schrieb Timothy Arceri: This series is intended to be applied on top of the previous serires

Re: [Mesa-dev] [PATCH] vbo: fix incorrect min/max_index values in display list draw call

On Tue, Jan 23, 2018 at 11:44:01AM -0700, Brian Paul wrote: This fixes another regression from commit 8e4efdc895ea ("vbo: optimize some display list drawing"). The problem was the min_index, max_index values passed to the vbo drawing function were not computed to compensate for the biased

Re: [Mesa-dev] [PATCH] radv: don't use hw resolve for certain image formats. (v2)

Hello Dave, is this one obsolete or should it go before the 2 committed but without the first line (duplicate)? Dieter Am 23.01.2018 06:29, schrieb Dave Airlie: From: Dave Airlie From reading AMDVLK it currently never uses hw resolve paths. This patch limits the paths

Re: [Mesa-dev] [PATCH 2/3] st: add nir shader disk cache support

I should note that compute support is missing (asserts) as I was unable to test it with radeonsi currently. On 24/01/18 11:41, Timothy Arceri wrote: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- src/mesa/state_tracker/st_program.c| 6 +-

Re: [Mesa-dev] Add interpolateAt builtin support to the radeonsi nir backend

Rebase underway? ;-) Am 15.01.2018 04:46, schrieb Timothy Arceri: This series is intended to be applied on top of the previous serires that ebales glsl 450 starting with: [PATCH 1/5] ac/radeonsi: add tcs load outputs support ___ mesa-dev mailing

[Mesa-dev] [PATCH 3/3] st/radeonsi: enable disk cache for nir

--- src/gallium/drivers/radeonsi/si_pipe.c | 4 src/mesa/state_tracker/st_program.c| 15 +++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 676d199618..c096165b03 100644

[Mesa-dev] [PATCH 2/3] st: add nir shader disk cache support

--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- src/mesa/state_tracker/st_program.c| 6 +- src/mesa/state_tracker/st_shader_cache.c | 133 +++-- src/mesa/state_tracker/st_shader_cache.h | 8 +- 4 files changed, 115 insertions(+), 34 deletions(-)

[Mesa-dev] [PATCH 1/3] st/glsl_to_tgsi: move nir detection earlier and set nir options

We move the nir check before the shader cache call so that we can call a nir based caching function in a following patch. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 10 ++--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 36 +++--- 2 files changed, 30

Re: [Mesa-dev] [PATCH v2 16/24] anv/cmd_buffer: Re-arrange the logic around UNDEFINED fast-clears

On Fri, Jan 19, 2018 at 03:47:33PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 31 ++- > 1 file changed, 14 insertions(+), 17 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git

Re: [Mesa-dev] meson builds don't read dri options

Quoting Kenneth Graunke (2018-01-23 15:04:18) > On Tuesday, January 23, 2018 10:34:25 AM PST Dylan Baker wrote: > > There's a bug in our meson build, and I sent a patch. We need to join_dirs > > with > > get_option('prefix'). I got a little confused because when you pass a > > relative > >

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

Sure enough, it does use ':' You might want to send the patch to the list and CC Emil, and probably stable. Although Emil also mentioned that maybe it would just be better to delete this option since we have LIBGL_DRIVERS_PATH. Quoting Eric Engestrom (2018-01-23 15:28:50) > On Tuesday,

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

On Wed, Jan 24, 2018 at 12:00 AM, Dave Airlie wrote: > From: Dave Airlie > > This is ported from radeonsi and fixes: > dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* > > v2: don't call this path for radeonsi, it does it in the epilog. > use

Re: [Mesa-dev] [PATCH 0.5/5] i965/tiled_memcpy: linear_to_ytiled a cache line at a time

Quoting Scott D Phillips (2018-01-23 14:42:43) > TileY's low 6 address bits are: v1 v0 u3 u2 u1 u0 > Thus a cache line in the tiled surface is composed of a 2d area of > 16x4 bytes of the linear surface. > > Add a special case where the area being copied is 4-line aligned > and a multiple of

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

On 2018-01-23 — 15:16, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-01-23 — 14:04, Francisco Jerez wrote: > >> Pierre Moreau writes: > >> > >> > If creating a library, do not allow non-compiled object in it, as > >> > executables

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

Pierre Moreau writes: > On 2018-01-23 — 14:04, Francisco Jerez wrote: >> Pierre Moreau writes: >> >> > If creating a library, do not allow non-compiled object in it, as >> > executables are not allowed, and libraries would make it really hard to >>

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

On Tuesday, 2018-01-23 21:53:14 +, Dylan Baker wrote: > Quoting Eric Engestrom (2018-01-18 15:02:46) > > On Thursday, 2018-01-18 17:09:33 +, Dylan Baker wrote: > > > Currently there is not a separate option for setting the search path of > > > DRI drivers in meson, like there is in scons

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

Pierre Moreau writes: > On 2018-01-23 — 14:03, Francisco Jerez wrote: >> Pierre Moreau writes: >> >> > From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: >> > >> >> If program is created with clCreateProgramWithBinary, then the

Re: [Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

On 2018-01-23 — 14:03, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/core/device.cpp | 11 +++ > > src/gallium/state_trackers/clover/core/device.hpp | 3 +++

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

On 2018-01-23 — 14:03, Francisco Jerez wrote: > Pierre Moreau writes: > > > From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: > > > >> If program is created with clCreateProgramWithBinary, then the > >> program binary must be an executable binary (not

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

On 2018-01-23 — 14:04, Francisco Jerez wrote: > Pierre Moreau writes: > > > If creating a library, do not allow non-compiled object in it, as > > executables are not allowed, and libraries would make it really hard to > > enforce the "-enable-link-options" flag. > > > >

Re: [Mesa-dev] [PATCH 2/5] i965/miptree: Use cpu tiling/detiling when mapping

Quoting Scott D Phillips (2018-01-10 07:16:59) > +/* Compute extent parameters for use with tiled_memcpy functions. > + * xs are in units of bytes and ys are in units of strides. */ > +static inline void > +tile_extents(struct intel_mipmap_tree *mt, struct intel_miptree_map *map, > +

Re: [Mesa-dev] meson builds don't read dri options

On Tuesday, January 23, 2018 10:34:25 AM PST Dylan Baker wrote: > There's a bug in our meson build, and I sent a patch. We need to join_dirs > with > get_option('prefix'). I got a little confused because when you pass a relative > directory to meson's `install` option it will autotmatically make

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

On Tue, Jan 23, 2018 at 11:46 PM, Francisco Jerez wrote: > Pierre Moreau writes: > >> On 2018-01-23 — 14:02, Francisco Jerez wrote: >>> Karol Herbst writes: >>> >>> > there seem to be some patches missing? >>> > >>> > On Tue, Jan

Re: [Mesa-dev] [PATCH v2 12/24] anv/cmd_buffer: Add a mark_image_written helper

On Mon, Jan 22, 2018 at 05:25:31PM -0800, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 3:22 PM, Nanley Chery wrote: > > > On Fri, Jan 19, 2018 at 03:47:29PM -0800, Jason Ekstrand wrote: > > > Currently, this helper does nothing but we call it every place where an > > >

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

Pierre Moreau writes: > On 2018-01-23 — 14:02, Francisco Jerez wrote: >> Karol Herbst writes: >> >> > there seem to be some patches missing? >> > >> > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau >> > wrote: >> >> Hello, >>

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

From: Dave Airlie This is ported from radeonsi and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* v2: don't call this path for radeonsi, it does it in the epilog. use the radeonsi code path. v3: handle NULL pCreateInfo->pMultisampleState properly

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

On 2018-01-23 — 14:02, Francisco Jerez wrote: > Karol Herbst writes: > > > there seem to be some patches missing? > > > > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau > > wrote: > >> Hello, > >> > >> Here is the second version of my initial series

[Mesa-dev] [PATCH 0.5/5] i965/tiled_memcpy: linear_to_ytiled a cache line at a time

TileY's low 6 address bits are: v1 v0 u3 u2 u1 u0 Thus a cache line in the tiled surface is composed of a 2d area of 16x4 bytes of the linear surface. Add a special case where the area being copied is 4-line aligned and a multiple of 4-lines so that entire cache lines will be written at a time.

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

On 2018-01-23 — 14:08, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/core/program.cpp | 22 > > +- > > 1 file changed, 17 insertions(+), 5

Re: [Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

Pierre Moreau writes: > On 2018-01-23 — 14:06, Francisco Jerez wrote: >> Pierre Moreau writes: >> >> > Signed-off-by: Pierre Moreau >> > --- >> > .../state_trackers/clover/spirv/spirv.hpp11| 997 >> >

Re: [Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

On 2018-01-23 — 14:08, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > Same comment as Karol, let's update the header instead. I will do that. Though that won’t impact this patch, as cl_khr_il_program is not

Re: [Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/device.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/state_trackers/clover/api/device.cpp >

Re: [Mesa-dev] ***SPAM*** [PATCH v2 16/22] clover: Implement clCreateProgramWithILKHR

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/dispatch.hpp | 4 ++ > src/gallium/state_trackers/clover/api/program.cpp | 29 - > src/gallium/state_trackers/clover/core/program.cpp | 68

Re: [Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

On 2018-01-23 — 14:06, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > .../state_trackers/clover/spirv/spirv.hpp11| 997 > > + > > 1 file changed, 997 insertions(+) > >

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/core/program.cpp | 22 > +- > 1 file changed, 17 insertions(+), 5 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

Pierre Moreau writes: > Signed-off-by: Pierre Moreau Same comment as Karol, let's update the header instead. > --- > include/CL/cl_ext.h | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v2 14/22] clover: Add a pointer property to return ILs

Pierre Moreau writes: > OpenCL 2.1, and cl_khr_il_program, gives the ability to query for a > program’s IL, which is returned as a pointer. > > Signed-off-by: Pierre Moreau I'm not convinced this is correct, but... It seems fully unnecessary, I

Re: [Mesa-dev] [PATCH v2 12/22] clover: Refuse to compile source code to SPIR-V

Pierre Moreau writes: > Creating a program using clCreateProgramWithSource to SPIR-V requires a > non-upstreamed version of LLVM and clang, therefore it is currently not > supported. > > Signed-off-by: Pierre Moreau > --- >

Re: [Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > .../state_trackers/clover/spirv/spirv.hpp11| 997 > + > 1 file changed, 997 insertions(+) > create mode 100644

Re: [Mesa-dev] [PATCH v2 07/22] clover: Move platform extensions definitions to clover/platform.cpp

Pierre Moreau writes: > Signed-off-by: Pierre Moreau Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- > src/gallium/state_trackers/clover/core/platform.cpp | 5 + >

Re: [Mesa-dev] [PATCH v2 06/22] clover: Move device extensions definitions to core/device.cpp

Pierre Moreau writes: > Signed-off-by: Pierre Moreau Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/device.cpp | 11 +-- > src/gallium/state_trackers/clover/core/device.cpp | 14

Re: [Mesa-dev] [PATCH v2 01/22] clover/api: Fix tab indentation to spaces

Pierre Moreau writes: > Signed-off-by: Pierre Moreau Acked-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/device.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

Pierre Moreau writes: > If creating a library, do not allow non-compiled object in it, as > executables are not allowed, and libraries would make it really hard to > enforce the "-enable-link-options" flag. > > Signed-off-by: Pierre Moreau > --- >

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

Pierre Moreau writes: > From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: > >> If program is created with clCreateProgramWithBinary, then the >> program binary must be an executable binary (not a compiled binary or >> library). > > Signed-off-by:

Re: [Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/core/device.cpp | 11 +++ > src/gallium/state_trackers/clover/core/device.hpp | 3 +++ > 2 files changed, 14 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

Karol Herbst writes: > there seem to be some patches missing? > > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau wrote: >> Hello, >> >> Here is the second version of my initial series for adding SPIR-V support to >> clover, after the RFC back in May

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

On 2018-01-23 — 13:33, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-01-23 — 14:07, Jan Vesely wrote: > >> On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > >> > Signed-off-by: Pierre Moreau > >> > --- > >> >

[Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") Reported-by: Marc Dietrich Signed-off-by: Dylan Baker --- src/util/meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/util/meson.build

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

Quoting Emil Velikov (2018-01-19 10:28:18) > On 17 January 2018 at 21:34, Dylan Baker wrote: > > Currently there is not a separate option for setting the search path of > > DRI drivers in meson, like there is in scons and autotools. This is an > > oversight and needs to be

Re: [Mesa-dev] meson builds don't read dri options

There's a bug in our meson build, and I sent a patch. We need to join_dirs with get_option('prefix'). I got a little confused because when you pass a relative directory to meson's `install` option it will autotmatically make it absolute, but when you pass it to a C define it doesn't. Quoting

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

Quoting Eric Engestrom (2018-01-18 15:02:46) > On Thursday, 2018-01-18 17:09:33 +, Dylan Baker wrote: > > Currently there is not a separate option for setting the search path of > > DRI drivers in meson, like there is in scons and autotools. This is an > > oversight and needs to be fixed. This

[Mesa-dev] [PATCH 4/4] meson: add convenience variable for anv_extensions.py depdendency

Signed-off-by: Dylan Baker --- src/intel/vulkan/meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index 1be389b67e3..41dba420cb4 100644 --- a/src/intel/vulkan/meson.build

[Mesa-dev] [PATCH 2/4] meson: use depend_files to track extra file dependencies

cc: Jason Ekstrand cc: Samuel Iglesias Gonsálvez Fixes: f93994080993bda ("anv: Split anv_extensions.py into two files") Signed-off-by: Dylan Baker --- src/intel/vulkan/meson.build | 4 ++-- 1 file changed, 2

[Mesa-dev] [PATCH 3/4] meson: use depend_files for adding extra file dependencies

cc: Jason Ekstrand cc: Samuel Iglesias Gonsálvez Fixes: dd088d4bec74f37ffe4 ("anv/extensions: Generate a header file with extension tables") Signed-off-by: Dylan Baker --- src/intel/vulkan/meson.build | 4 ++-- 1 file

Re: [Mesa-dev] meson builds don't read dri options

Hi Marc, I have two theories 1) Is your locale non-english by chance? generation of drirc support for translations is still on the list 2) The search path may not be correct, I'll double check that now. Quoting Marc Dietrich (2018-01-23 03:31:23) > Hi Dylan, > > running "Heaven" fails with

Re: [Mesa-dev] [PATCH] meson: fix some defines misspelled errors in meson.build

This needs to go into the 18.0 release. CC'ing stable. Quoting Eric Engestrom (2018-01-23 07:46:14) > On Tuesday, 2018-01-23 15:49:43 +0100, Marc Dietrich wrote: > > Defines > > - HAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL > > - HAVE_FUNC_ATTRIBUTE_VISIBILITY > > were misspelled. > > Wow, good catch!

[Mesa-dev] [PATCH 1/4] Revert "anv/meson: Make anv_entrypoints_gen.py depend on anv_extensions.py"

This reverts commit 10d1b0be8e9c463dbc35cd66968299f33c76672c. This is unnecessary, the depend_files argument is for adding dependencies on files that are not part of the input, which is already done. cc: Jason Ekstrand cc: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH] meson: remove lib prefix from libd3dadapter9.so

I've added Eric and I's rbs and a fixes tag and pushed to master. Thanks for fixing this! Quoting Christoph Haag (2018-01-20 09:53:13) > --- > src/gallium/targets/d3dadapter9/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/targets/d3dadapter9/meson.build >

[Mesa-dev] [PATCH] st/glsl_to_nir: remove reallocation of sampler/image location

As far as I can tell this always just reassigns the same value. Also as we don't curretly store UniformHash in the shader cache removing this will help with adding a shader cache to gallium nir drivers. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 8 1 file changed, 8 deletions(-)

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

Pierre Moreau writes: > On 2018-01-23 — 14:07, Jan Vesely wrote: >> On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: >> > Signed-off-by: Pierre Moreau >> > --- >> > src/gallium/include/pipe/p_defines.h | 1 + >> > 1 file changed, 1

Re: [Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

On 2018-01-23 — 14:20, Jan Vesely wrote: > On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > do these tools handle the original SPIR format as well? can this be > used to support cl_khr_spir? > > Jan They do not I’m afraid. I

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

On 2018-01-23 — 14:07, Jan Vesely wrote: > On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/include/pipe/p_defines.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

Also, the associated piglit patches: https://lists.freedesktop.org/archives/piglit/2017-December/023600.html On 2018-01-23 01:13 PM, Andres Rodriguez wrote: On 2018-01-23 01:04 PM, Andres Rodriguez wrote: Rebased on latest mesa and dropped the gallium fence->semaphore rename. There is

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: use separate bindings for graphics and compute descriptors

On Tue, Jan 23, 2018 at 2:27 PM, Samuel Pitoiset wrote: > The Vulkan spec says: > >"pipelineBindPoint is a VkPipelineBindPoint indicating whether > the descriptors will be used by graphics pipelines or compute > pipelines. There is a separate set of bind

[Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible (v2)

Changes since v1: * Rebased on top of e68150de263156a3f3d1b609b6506c5649967f61 and 82adf53308c137ce0dc5f2d5da4e7cc40c5b808c. Cc: Timothy Arceri Tested-by: Dieter Nützel (v1) Signed-off-by: Kai Wasserbäch --- Hey,

Re: [Mesa-dev] Logging infrastructure?

On Jan 22, 2018 09:02, "Kenneth Graunke" wrote: On Thursday, January 18, 2018 1:44:47 PM PST Chuck Atkins wrote: > Is there a logging infrastructure currently available to drivers in Mesa? > I was looking to clean up some of swr's debug / info output and have it >

Re: [Mesa-dev] Logging infrastructure?

On Jan 22, 2018 09:02, "Kenneth Graunke" wrote: On Thursday, January 18, 2018 1:44:47 PM PST Chuck Atkins wrote: > Is there a logging infrastructure currently available to drivers in Mesa? > I was looking to clean up some of swr's debug / info output and have it >

Re: [Mesa-dev] [PATCH 2/2] radv: don't use hw resolve for integer image formats

Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 23, 2018 at 6:52 AM, Dave Airlie wrote: > From: Dave Airlie > > From reading AMDVLK it currently never uses hw resolve paths. > > This patch takes from radeonsi which doesn't use hw

Re: [Mesa-dev] [PATCH 1/2] radv: add fs_key meta format support to resolve passes.

On Tue, Jan 23, 2018 at 6:52 AM, Dave Airlie wrote: > From: Dave Airlie > > Some of the hw resolve passes need the SPI color format setup > correctly. > > This fixes lots of 16-bit and 32-bit format tests in > dEQP-VK.renderpass.suballocation.multisample* >

Re: [Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau do these tools handle the original SPIR format as well? can this be used to support cl_khr_spir? Jan > --- > configure.ac | 5 + > meson.build | 2 ++ > 2 files changed, 7

Re: [Mesa-dev] [PATCH v4 02/10] mesa/st/glsl_to_tgsi: Add some operators for glsl_to_tgsi related classes

Just some nit-picks below. On 01/23/2018 03:11 AM, Gert Wollny wrote: Add the equal operator and the "<<" stream write operator for the st_*_reg classes and the "<<" operator to the instruction class, and make use of these operators in the debugging output. ---

Re: [Mesa-dev] [PATCH v4 03/10] mesa/st/tests: Fix zero-byte allocation leaks

On 01/23/2018 03:11 AM, Gert Wollny wrote: Don't allocate a zero-sized array, when no texture offsets are given. Reviewed-by: Nicolai Hähnle Signed-off-by: Gert Wollny --- .../tests/test_glsl_to_tgsi_lifetime.cpp | 23

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/include/pipe/p_defines.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/include/pipe/p_defines.h >

[Mesa-dev] [Bug 104752] Account Request for Chuck Atkins

https://bugs.freedesktop.org/show_bug.cgi?id=104752 Brian Paul changed: What|Removed |Added Component|Other |New Accounts

[Mesa-dev] [Bug 104742] [swrast] piglit gl-1.4-dlist-multidrawarrays regression

https://bugs.freedesktop.org/show_bug.cgi?id=104742 --- Comment #1 from Brian Paul --- Vinson, I posted a patch to mesa-dev to which fixes this and 104746. If you can test too, that'd be helpful. -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

On 22 January 2018 at 18:02, Chuck Atkins wrote: > Hi Emil, > >> Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin") > > > It doesn't fix anything that was broken from that commit. The issues with > error handling were already present before then,

[Mesa-dev] [Bug 104749] rasterizer/jitter/JitManager.cpp:252:91: error: no matching function for call to ‘llvm::DIBuilder::createBasicType(const char [8], int, llvm::dwarf::TypeKind)’

https://bugs.freedesktop.org/show_bug.cgi?id=104749 --- Comment #1 from Juan A. Suarez --- Tracked to: commit 01ab218bbc5c8058a99077a6bc3dc9884e9d218a Author: George Kyriazis Date: Fri Jan 19 15:46:59 2018 -0600 swr/rast: Initial work for

[Mesa-dev] [PATCH] vbo: fix incorrect min/max_index values in display list draw call

This fixes another regression from commit 8e4efdc895ea ("vbo: optimize some display list drawing"). The problem was the min_index, max_index values passed to the vbo drawing function were not computed to compensate for the biased prim::start values.

[Mesa-dev] [Bug 104752] Account Request for Chuck Atkins

https://bugs.freedesktop.org/show_bug.cgi?id=104752 --- Comment #4 from Emil Velikov --- Ack from me. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [PATCH 10/20] mesa: add support for semaphore object signal/wait v3

Memory synchronization is left for a future patch. v2: flush vertices/bitmaps moved to mesa/main v3: removed spaces before/after braces Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 38

[Mesa-dev] [PATCH] Revert "radv: Initialize DCC on transition from preinitialized."

This reverts commit 2ce11ac11fee594ca01608c4006b38c0c8ea37ff. SteamVR has been updated to correctly use UNDEFINED as the initial layout transition state. So we should go back to behaving according to the spec in radv. Fixes: 44fcf58744 "radv: Disable DCC for GENERAL layout and compute transfer

[Mesa-dev] [ANNOUNCE] mesa 18.0.0-rc2

This release corrects the version number, to follow the standard naming scheme. Emil Velikov (1): Update version to 18.0.0-rc2 git tag: mesa-18.0.0-rc2 https://mesa.freedesktop.org/archive/mesa-18.0.0-rc2.tar.gz MD5: 755ced6e9039d2f3394b09a99e3ed2e2 mesa-18.0.0-rc2.tar.gz SHA1:

Re: [Mesa-dev] [PATCH 10/20] mesa: add support for semaphore object signal/wait v2

On 01/23/2018 11:05 AM, Andres Rodriguez wrote: Memory synchronization is left for a future patch. v2: flush vertices/bitmaps moved to mesa/main Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++ src/mesa/main/externalobjects.c | 38

  1   2   >