Re: [Mesa-dev] [PATCH] util/build-id: Fix address comparison for binaries with LOAD vaddr > 0

I've verified this gets the correct address. Very nice work figuring this out Stephan! Reviewed-by: Tapani Pälli On 01/24/2018 04:13 PM, Stephan Gerhold wrote: build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD segment has a virtual address

Re: [Mesa-dev] [PATCH v2 0.5/5] i965/tiled_memcpy: linear_to_ytiled a cache line at a time

The OCD in me is seeing a couple more places you could micro-optimize. Before I actually point them out, Reviewed-by: Jason Ekstrand On Thu, Jan 25, 2018 at 8:23 AM, Scott D Phillips < scott.d.phill...@intel.com> wrote: > TileY's low 6 address bits are: v1 v0 u3 u2 u1 u0

[Mesa-dev] [PATCH] meson: Add new picture_{h264, hevc}_enc.c files to meson too

--- Very nice that this finally arrives. Can you add the files to meson too, something like this patch? I can't test it because I only have Polaris here. src/gallium/state_trackers/va/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] mesa: add blob overrun check to program binary reads

--- src/mesa/main/program_binary.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/main/program_binary.c b/src/mesa/main/program_binary.c index 2786487362..68a15ec258 100644 --- a/src/mesa/main/program_binary.c +++ b/src/mesa/main/program_binary.c @@ -287,5 +287,19 @@

[Mesa-dev] [PATCH 2/2] st/shader_cache: restore num_tgsi_tokens when loading from cache

Without this we will fail to correctly serialise programs when using glGetProgramBinary() if the program was retrieved from the disk cache rather than freshly compiled. Fixes: c69b0dd6817b "st/glsl_to_tgsi: store num_tgsi_tokens in st_*_program" Bugzilla:

Re: [Mesa-dev] [PATCH 1/2] radeon/vcn: add and manage render picture list

Hi Emil, I cherry-picked these 2 patches over to the 17.3 branch, then tested locally and confirmed that it works fine. I also added bugzilla reference to the patch as well. Please see the details in the links below: https://lists.freedesktop.org/archives/mesa-dev/2018-January/183485.html

[Mesa-dev] [PATCH] mesa: silence MinGW 'may be unused uninitialized' warning in get.c

The warning happens on line 2114 for the memcpy(data, p, size) call. I'm not sure why that generates the warning but not the earlier use of p in the code. --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index

[Mesa-dev] [PATCH 2/2] radeon/uvd: add and manage render picture list

From: Boyuan Zhang Create a list in decoder to store all render picture buffer pointers that currently being used in reference picture lists. During get message buffer call, check each pointer in render_pic_list[] within given pic->ref[] list, remove pointer that no longer

[Mesa-dev] [PATCH 1/2] radeon/vcn: add and manage render picture list

From: Boyuan Zhang Create a list in decoder to store all render picture buffer pointers that currently being used in reference picture lists. During get message buffer call, check each pointer in render_pic_list[] within given pic->ref[] list, remove pointer that no longer

[Mesa-dev] [PATCH v2 2/5] i965/miptree: Use cpu tiling/detiling when mapping

Rename the (un)map_gtt functions to (un)map_map (map by returning a map) and add new functions (un)map_tiled_memcpy that return a shadow buffer populated with the intel_tiled_memcpy functions. v2: Compute extents properly in the x|y-rounded-down case (Chris Wilson) ---

[Mesa-dev] [PATCH v2 0.5/5] i965/tiled_memcpy: linear_to_ytiled a cache line at a time

TileY's low 6 address bits are: v1 v0 u3 u2 u1 u0 Thus a cache line in the tiled surface is composed of a 2d area of 16x4 bytes of the linear surface. Add a special case where the area being copied is 4-line aligned and a multiple of 4-lines so that entire cache lines will be written at a time.

[Mesa-dev] [PATCH] ac/nir: Correctly handle imod with different signs.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102032 --- src/amd/common/ac_nir_to_llvm.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 8ae8650a7b..4f1e4af37b 100644 ---

[Mesa-dev] [Bug 102032] nir_op_imod is incorrectly implemented as LLVM's srem

https://bugs.freedesktop.org/show_bug.cgi?id=102032 --- Comment #1 from Bas Nieuwenhuizen --- I went looking to why there were no good CTS tests for this and found this in the vulkan spec: For the OpSRem and OpSMod instructions, if either operand is negative the result

Re: [Mesa-dev] [PATCH 4/4] anv/pipeline: remove the pipeline layout field from anv_pipeline

3 and 4 are Reviewed-by: Jason Ekstrand On Thu, Jan 25, 2018 at 4:24 AM, Iago Toral Quiroga wrote: > It no longer has any users. > > Suggested-by: Jason Ekstrand > --- > src/intel/vulkan/anv_pipeline.c | 2 -- >

Re: [Mesa-dev] [PATCH 2/4] anv/pipeline: don't take the layout from the pipeline to compile shaders

I had a few nits below. With those fixed, Reviewed-by: Jason Ekstrand On Thu, Jan 25, 2018 at 4:24 AM, Iago Toral Quiroga wrote: > The Vulkan spec states that VkPipelineLayout objects must not be > destroyed while any command buffer that uses them is

Re: [Mesa-dev] [PATCH 3/4] r600: add ARB_query_buffer_object support

Am 25.01.2018 um 01:40 schrieb Dave Airlie: > From: Dave Airlie > > This uses a different shader than radeonsi, as we can't address non-256 > aligned ssbos, which the radeonsi code does. This passes some extra > offsets into the shader. Couldn't you just require the query

Re: [Mesa-dev] [PATCH 1/4] anv/descriptor_set: add reference counting for descriptor set layouts

On Thu, Jan 25, 2018 at 4:24 AM, Iago Toral Quiroga wrote: > The spec states that descriptor set layouts can be destroyed almost > at any time: > >"VkDescriptorSetLayout objects may be accessed by commands that > operate on descriptor sets allocated using that layout,

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

It landed as 4b69ba381766cd911eb1284f1b0332a139ec8a75 On Thu, Jan 25, 2018 at 3:27 AM, Emil Velikov wrote: > On 18 January 2018 at 01:16, Jason Ekstrand wrote: > > Without this, we may end up dereferencing blend before we check for > >

[Mesa-dev] [PATCH 09/12] st/va: enable dual instances encode only for H264

From: Boyuan Zhang Logics that related to dual instances encode should only be done for H264, not other codecs. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 3 ++- src/gallium/state_trackers/va/surface.c | 23

[Mesa-dev] [PATCH 06/12] st/va: move H264 enc functions into separate file

From: Boyuan Zhang Move all H264 encode related functions into separate file. Similar to VAAPI decode side, there will be separate file for each codec on encode side as well. Signed-off-by: Boyuan Zhang ---

[Mesa-dev] [PATCH 10/12] st/va: add HEVC encode functions

From: Boyuan Zhang Add a separate file for HEVC encode functions. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c | 56 +--

[Mesa-dev] [PATCH 12/12] radeonsi: enable vcn encode for HEVC main

From: Boyuan Zhang Enable vcn encode for HEVC main profile on Raven. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c

[Mesa-dev] [PATCH 11/12] st/va: implement HEVC encode functions

From: Boyuan Zhang Implement HEVC encode functions based on VAAPI HEVC encode interface. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture_hevc_enc.c | 130 ++- 1 file changed, 125 insertions(+), 5

[Mesa-dev] [PATCH 02/12] radeon/vcn: add vcn encode interface for HEVC

From: Boyuan Zhang Add vcn encode interface for HEVC, and rename radeon_enc_h264_enc_pic to radeon_enc_pic since radeon_enc_pic is used by both H264 and HEVC. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 82

[Mesa-dev] [PATCH 03/12] radeon/vcn: support picture parameters for HEVC

From: Boyuan Zhang Pass pipe_picture_desc instead of pipe_h264_enc_picture_desc so that it can be used for different codecs. Add functions to handle picture parameters that will be used for HEVC encode. Signed-off-by: Boyuan Zhang ---

[Mesa-dev] [PATCH 05/12] radeon/vcn: add header implementations for HEVC

From: Boyuan Zhang Implement encoding of sps, pps, vps, aud, and slice headers for HEVC based on HEVC specs. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 348 +++- 1 file changed, 347

[Mesa-dev] [PATCH 07/12] st/va: add HEVC picture desc

From: Boyuan Zhang Add HEVC picture desc, and add codec check when creating and destroying context. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/context.c| 26 ++

[Mesa-dev] [PATCH 08/12] st/va: add entrypoint check for HEVC

From: Boyuan Zhang Add entrypoint check for HEVC to differentiate decode and encode jobs. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/context.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff

[Mesa-dev] [PATCH 04/12] radeon/vcn: add ib implementations for HEVC

From: Boyuan Zhang Implement required ibs for vcn HEVC encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 267 1 file changed, 222 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 01/12] vl: add parameters for HEVC encode

From: Boyuan Zhang Add HEVC encode interface Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 100 +++ 1 file changed, 100 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h

Re: [Mesa-dev] [PATCH] i965/fs: Reset the register file to VGRF in lower_integer_multiplication

On Thu, Jan 25, 2018 at 10:08 AM, Matt Turner wrote: > On Fri, Dec 15, 2017 at 5:12 PM, Jason Ekstrand > wrote: > > 18fde36ced4279f2577097a1a7d31b55f2f5f141 changed the way temporary > > registers were allocated in lower_integer_multiplication so that

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.0.68

pushed On Thu, Jan 25, 2018 at 10:30 AM, Chad Versace wrote: > On Wed 24 Jan 2018, Jason Ekstrand wrote: > > --- > > include/vulkan/vulkan.h| 54 --- > > src/vulkan/registry/vk.xml | 91 ++ > +++- > >

Re: [Mesa-dev] [PATCH] mesa: Fix function pointers initialization in status tracker

On 01/25/2018 01:09 PM, Eleni Maria Stea wrote: We assigned the function that gets the device uuid to the GetDriverUuid function pointer and the function that gets the driver uuid to the GetDeviceUuid function pointer inside the state tracker. Exchanged the pointers. ---

[Mesa-dev] [PATCH] mesa: Fix function pointers initialization in status tracker

We assigned the function that gets the device uuid to the GetDriverUuid function pointer and the function that gets the driver uuid to the GetDeviceUuid function pointer inside the state tracker. Exchanged the pointers. --- src/mesa/state_tracker/st_context.c | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH] radv: emit a cache flush before enabling predication

On 26 Jan. 2018 01:10, "Matthew Nicholls" wrote: Otherwise cache flushes could get conditionally disabled while still clearing the flush_bits, and thus flushes due to application pipeline barriers may never get executed. I wonder would we better not predicating

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: > Hey Tomasz, > > On 01/24/2018 11:04 AM, Tomasz Figa wrote: >> >> Hi Robert, >> >> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss >> wrote: >>> >>> This series moves

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

Hi Emil, I'll squash it before pushing >> > > Thanks! Hopefully once my new account goes through I can push on my own. > It looks like my account finally went through so I can just take care of pushing it myself. - Chuck ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] swr/rast: Optimize DumpToFile output size

Reviewed-by: Bruce Cherniak > On Jan 24, 2018, at 2:50 PM, George Kyriazis > wrote: > > Modify DumpToFile to only dump the function, not the entire module. > Reduces file sizes and speeds up the dumping. > --- >

Re: [Mesa-dev] [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, January 25, 2018 10:38:51 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: s/Bool/SVGA3dBool/ in

Re: [Mesa-dev] [PATCH 04/10] swrast: remove non-applicable GLX_SWAP_COPY_OML comment

On 12 December 2017 at 00:19, Ian Romanick wrote: > On 12/07/2017 09:07 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> Noticed while skimming for GLX_ instances i the dri codebase. > > in > > With

[Mesa-dev] [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult

And fix whitespace. To sync up with in-house code. --- src/gallium/drivers/svga/include/svga3d_devcaps.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/include/svga3d_devcaps.h b/src/gallium/drivers/svga/include/svga3d_devcaps.h index

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.0.68

On Wed 24 Jan 2018, Jason Ekstrand wrote: > --- > include/vulkan/vulkan.h| 54 --- > src/vulkan/registry/vk.xml | 91 > +- > 2 files changed, 130 insertions(+), 15 deletions(-) Acked-by: Chad Versace

[Mesa-dev] [Bug 104141] include/c11/threads_posix.h:96: undefined reference to `pthread_once'

https://bugs.freedesktop.org/show_bug.cgi?id=104141 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/5] swr/rast: Support USE_SIMD16_FRONTEND=0 for EarlyRast

Series Reviewed-by: Bruce Cherniak > On Jan 24, 2018, at 9:31 AM, George Kyriazis > wrote: > > Early Rasterization did not initially work with USE_SIMD16_FRONTEND=0. > Fix it so it works there, too. Please note that the default setting >

[Mesa-dev] [Bug 104710] [swrast] piglit draw-batch regression

https://bugs.freedesktop.org/show_bug.cgi?id=104710 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH v3 2/8] compiler: Add SYSTEM_VALUE_FIRST_VERTEX and instrinsics

This VS system value will contain the value passed as for indexed draw calls or the value passed as for non-indexed draw calls. It can be used to calculate the gl_VertexID as SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_FIRST_VERTEX. From the OpenGL 4.6 spec, 10.4 "Drawing Commands Using

[Mesa-dev] [PATCH v3 8/8] i965: gl_BaseVertex must be zero for non-indexed draw calls

We keep 'firstvertex' as it is and move gl_BaseVertex to the drawID vertex element. The previous Vertex Elements order was: * VE 1: * VE 2: and now it is: * VE 1: * VE 2: To move the BaseVertex keeping VE1 as it is, allows to keep

[Mesa-dev] [PATCH v3 3/8] intel/compiler: Add a uses_firstvertex flag

From: Neil Roberts Reviewed-by: Kenneth Graunke --- src/intel/compiler/brw_compiler.h | 1 + src/intel/compiler/brw_vec4.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h

[Mesa-dev] [PATCH v3 5/8] spirv: Lower BaseVertex to FIRST_VERTEX instead of BASE_VERTEX

From: Neil Roberts The base vertex in Vulkan is different from GL in that for non-indexed primitives the value is taken from the firstVertex parameter instead of being set to zero. This coincides with the new SYSTEM_VALUE_FIRST_VERTEX instead of BASE_VERTEX. ---

[Mesa-dev] [PATCH v3 6/8] i965: Don't request GLSL IR lowering of gl_VertexID

From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in

[Mesa-dev] [PATCH v3 7/8] nir: Offset vertex_id by first_vertex instead of base_vertex

From: Neil Roberts base_vertex will be zero for non-indexed calls and in that case we need vertex_id to be offset by the ‘first’ parameter instead. That is what we get with first_vertex. This is true for both GL and Vulkan. The freedreno driver is also setting

[Mesa-dev] [PATCH v3 1/8] i965: allocate a SGVS element when VertexID or InstanceID are read

From: Iago Toral Quiroga Although on gen8+ platforms we can in theory use 3DSTATE_VF_SGVS to put these beyond the last vertex element it seems that we still need to allocate the SVGS element, otherwise we have observed cases where we end up reading garbage. Specifically, the

[Mesa-dev] [PATCH v3 4/8] intel: Handle firstvertex in an identical way to BaseVertex

Until we set gl_BaseVertex to zero for non-indexed draw calls both have an identical value. The Vertex Elements are kept like that: * VE 1: * VE 2: --- src/intel/compiler/brw_nir.c | 3 +++ src/intel/compiler/brw_vec4.cpp | 1 +

Re: [Mesa-dev] [PATCH] i965/fs: Reset the register file to VGRF in lower_integer_multiplication

On Fri, Dec 15, 2017 at 5:12 PM, Jason Ekstrand wrote: > 18fde36ced4279f2577097a1a7d31b55f2f5f141 changed the way temporary > registers were allocated in lower_integer_multiplication so that we > allocate regs_written(inst) space and keep the stride of the original >

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 25.01.2018 um 17:56 schrieb Roland Scheidegger: > Am 25.01.2018 um 16:30 schrieb Michel Dänzer: >> On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >>> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >>> --- >>> src/mesa/main/fbobject.c | 3 +++ >>> 1 file changed, 3 insertions(+)

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 18:02 GMT+01:00 Roland Scheidegger : > Am 25.01.2018 um 16:55 schrieb Brian Paul: > > The newest version of WSI Fusion makes several glDrawPixels calls > > per frame. By caching more than one image, we get better performance > > when panning/zomming the map. >

Re: [Mesa-dev] [PATCH] configure.ac: correct driglx-direct help text

On 20 December 2017 at 17:34, Emil Velikov wrote: > The default was toggled a while back, but the text wasn't updated. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

On 24 November 2017 at 18:26, Eric Engestrom wrote: > On Friday, 2017-11-24 18:14:41 +, Emil Velikov wrote: >> On 24 November 2017 at 14:32, Eric Engestrom >> wrote: >> > On Friday, 2017-11-24 14:25:02 +, Emil Velikov wrote: >> >>

Re: [Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

Looks good. For the series, Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, January 25, 2018 8:48:00 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger

Re: [Mesa-dev] [PATCH] configure.ac: correct driglx-direct help text

On 20 December 2017 at 17:34, Emil Velikov wrote: > From: Emil Velikov > > The default was toggled a while back, but the text wasn't updated. > > Fixes: bd526ec9e1b ("configure: Always default to > --enable-driglx-direct") > Cc: Jon TURNEY

Re: [Mesa-dev] [PATCH 2/2] radv: fix RADV_DEBUG=syncshaders on GFX9

Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 25, 2018 at 3:46 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 11 ++- > 1 file changed, 10

Re: [Mesa-dev] [PATCH 1/2] radv: fix a GPU hang with RADV_DEBUG=syncshaders

Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 25, 2018 at 3:46 PM, Samuel Pitoiset wrote: > The GPU hangs when the driver forces a PS_PARTIAL_FLUSH after > a dispatch call (and vice versa for graphics). Something has > changed in the kernel

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

Am 25.01.2018 um 16:55 schrieb Brian Paul: > The newest version of WSI Fusion makes several glDrawPixels calls > per frame. By caching more than one image, we get better performance > when panning/zomming the map. Still zooming :-) > > v2: move pixel unpack param checking out of cache search

[Mesa-dev] [Bug 104749] rasterizer/jitter/JitManager.cpp:252:91: error: no matching function for call to ‘llvm::DIBuilder::createBasicType(const char [8], int, llvm::dwarf::TypeKind)’

https://bugs.freedesktop.org/show_bug.cgi?id=104749 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, January 25, 2018 8:48:00 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger Subject: [PATCH 3/3]

[Mesa-dev] [Bug 104710] [swrast] piglit draw-batch regression

https://bugs.freedesktop.org/show_bug.cgi?id=104710 --- Comment #1 from Emil Velikov --- Vinson I'm suspecting that this should be fixed with 365a48abddcabf6596c2e34a784d91c8ab929918. Can you please confirm? -- You are receiving this mail because: You are the assignee

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 25.01.2018 um 16:30 schrieb Michel Dänzer: > On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >> --- >> src/mesa/main/fbobject.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

--- src/mesa/main/varray.h | 55 ++ 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h index 03d81d0..93f2f47 100644 --- a/src/mesa/main/varray.h +++ b/src/mesa/main/varray.h @@ -44,9

[Mesa-dev] [PATCH 2/3] mesa: include mtypes.h in varray.h

We actually use some of the types from mtypes.h so include it directly instead of relying on indirectly including it via bufferobj.h --- src/mesa/main/varray.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h index

[Mesa-dev] [PATCH 1/3] mesa: s/gl_vertex_attrib_array/gl_array_attributes/ in comments

The structure type was renamed some time ago, but some comments were not updated. --- src/mesa/main/arrayobj.c | 2 +- src/mesa/main/mtypes.h | 2 +- src/mesa/main/varray.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/arrayobj.c

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

> > > +if test "x$enable_glx" == xgallium-xlib; then > > +GL_PC_LIB_PRIV="$GL_PC_LIB_PRIV $LLVM_LIBS" > > +fi > > +if test "x$enable_gallium_osmesa" = xyes; then > > +OSMESA_PC_LIB_PRIV="$OSMESA_PC_LIB_PRIV $LLVM_LIBS" > > +fi > I'm itching to add a comment above

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hey Tomasz, On 01/24/2018 11:04 AM, Tomasz Figa wrote: Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea

Re: [Mesa-dev] [PATCH mesa] egl: keep extension list sorted, per comment at the top

On Thu, 2018-01-25 at 10:14 +, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

The newest version of WSI Fusion makes several glDrawPixels calls per frame. By caching more than one image, we get better performance when panning/zomming the map. v2: move pixel unpack param checking out of cache search loop, per Roland --- src/mesa/state_tracker/st_cb_drawpixels.c | 196

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

On 25 January 2018 at 14:43, Chuck Atkins wrote: > v2: Only add as dependencies for gallium-osmesa and gallium-xlib > > CC: > Signed-of-by: Chuck Atkins Reviewed-by: Emil Velikov

[Mesa-dev] [PATCH] radeonsi: Export signalled sync file instead of -1.

-1 is considered an error for EGL_ANDROID_native_fence_sync, so we need to actually create a sync file. Fixes: f536f45250 "radeonsi: implement sync_file import/export" --- src/gallium/drivers/radeon/radeon_winsys.h | 5 + src/gallium/drivers/radeonsi/si_fence.c| 2 ++

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

On 01/24/2018 09:06 PM, Roland Scheidegger wrote: Am 25.01.2018 um 00:19 schrieb Brian Paul: The newest version of WSI Fusion makes several glDrawPixels calls per frame. By caching more than one image, we get better performance when panning/zomming the map. zooming ---

Re: [Mesa-dev] [PATCH 2/3] anv/gen10: Ignore push constant packets during context restore.

On Wed, Jan 24, 2018 at 05:08:54PM -0800, Jason Ekstrand wrote: > On Wed, Jan 24, 2018 at 4:33 PM, Rafael Antognolli > > wrote: > > Similar to the GL driver, ignore 3DSTATE_CONSTANT_* packets when doing a > context restore. > > Signed-off-by: Rafael

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: > This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. > --- > src/mesa/main/fbobject.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index d23916d1ad7..c72204e11a0 100644

[Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

texture_format_error_check_gles() displays error like "glTexImage%dD". This patch just replace the %d by the correct dimension. Signed-off-by: Elie Tournier --- src/mesa/main/teximage.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

On Thursday, 2018-01-25 10:31:12 +0100, Marc Dietrich wrote: > Am Donnerstag, 25. Januar 2018, 10:28:26 CET schrieb Marc Dietrich: > > Am Donnerstag, 25. Januar 2018, 10:18:16 CET schrieb Eric Engestrom: > > > On Wednesday, 2018-01-24 22:02:42 +0100, Marc Dietrich wrote: > > > > Btw, there is

Re: [Mesa-dev] [PATCH] mesa: simplify _mesa_delete_list() a bit, add some assertions

On 01/24/2018 09:41 PM, Roland Scheidegger wrote: Am 25.01.2018 um 00:19 schrieb Brian Paul: All but two cases of the switch did the same n += InstSize[n[0].opcode] instruction. Just move it after the switch. Add some sanity check assertions. --- src/mesa/main/dlist.c | 39

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/build-id: Fix address comparison for binaries with LOAD vaddr > 0

On Thu, Jan 25, 2018 at 11:22:10AM +, Emil Velikov wrote: > On 24 January 2018 at 14:13, Stephan Gerhold wrote: > > build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD > > segment has a virtual address other than 0x0. > > > > For most shared

[Mesa-dev] [PATCH] radv: emit a cache flush before enabling predication

Otherwise cache flushes could get conditionally disabled while still clearing the flush_bits, and thus flushes due to application pipeline barriers may never get executed. Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_meta_fast_clear.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH] gallivm: fix crash with seamless cube filtering with different min/mag filter

Looks great. Reviewed-by: Jose Fonseca On 25/01/18 03:33, srol...@vmware.com wrote: From: Roland Scheidegger We are not allowed to modify the incoming coords values, or things may crash (as we may be inside a llvm conditional and the values may be

[Mesa-dev] [PATCH 1/2] radv: fix a GPU hang with RADV_DEBUG=syncshaders

The GPU hangs when the driver forces a PS_PARTIAL_FLUSH after a dispatch call (and vice versa for graphics). Something has changed in the kernel driver because it used to work. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 15 +++ 1

[Mesa-dev] [PATCH 2/2] radv: fix RADV_DEBUG=syncshaders on GFX9

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index ba5fd92f2a1..b694174de68 100644 ---

[Mesa-dev] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

v2: Only add as dependencies for gallium-osmesa and gallium-xlib CC: Signed-of-by: Chuck Atkins --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..448bd3a6ba

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) Yes, good point, will add that. Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

On Thu, Jan 25, 2018 at 08:40:00AM -0500, Ilia Mirkin wrote: > On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan > wrote: > > Also update BLEND_ to BLEND2_ opcodes to accomodate. > > Are you saying this doesn't compile right now? I would have expected > the accompanying

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's called... I forget.) On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan wrote: > Denormalized texture coordinates are required for text rendering in > GALLIUM_HUD. > > Signed-off-by: Wladimir J. van der

Re: [Mesa-dev] [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan wrote: > Also update BLEND_ to BLEND2_ opcodes to accomodate. Are you saying this doesn't compile right now? I would have expected the accompanying change to a2xx.xml.h for that. Perhaps this landed into the wrong

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: add missing llvm dependencies to .pc files

> Should be used only for gallium-xlib based glx, since it embeds the > swr/llvmpipe driver. > ... ... > There is no LLVM specific code in these - ^^ should not be needed. > Correct. This was initially to address the problem for OSMesa but I realized it was likely an issue for more than just

[Mesa-dev] [PATCH 6/7] freedreno: a2xx: implement SEQ/SNE instructions

Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 7/7] freedreno: a2xx: Implement DP2 instruction

Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c

[Mesa-dev] [PATCH 2/7] freedreno: a2xx: Fix fd2_tex_swiz

Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1 file

[Mesa-dev] [PATCH 3/7] freedreno: a2xx: Prevent crash in emit_texture if view is not set

Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 11 +-- 1 file changed, 9 insertions(+), 2

[Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 +

[Mesa-dev] [PATCH 5/7] freedreno: a2xx: Compressed textures support

Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 insertions(+)

[Mesa-dev] [PATCH 1/7] freedreno: a2xx: Update rnndb header

Also update BLEND_ to BLEND2_ opcodes to accomodate. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++ src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 4 ++-- 2 files changed, 15 insertions(+), 22

  1   2   >