Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

On 30/01/18 01:24, Roland Scheidegger wrote: > Am 29.01.2018 um 17:03 schrieb Alejandro Piñeiro: >> On 29/01/18 16:38, Roland Scheidegger wrote: >>> Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: On 27/01/18 12:09, Roland Scheidegger wrote: > Am 27.01.2018 um 09:52 schrieb Alejandro

Re: [Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

On Wed, 2018-02-21 at 09:58 -0800, Nanley Chery wrote: > On Wed, Feb 21, 2018 at 09:18:49AM +0100, Iago Toral Quiroga wrote: > > We were only resolving the first. > > > > v2: > > - Do not require that the number of layers on dst and src are an > > exact match, it is okay if the dst has more

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: > > On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov > wrote: > > On 21 February 2018 at 18:50, Rob Herring wrote: > >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov

[Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

From: Mathias Fröhlich Provided the _DrawVAO and the derived state that is maintained if we have the _DrawVAO set, implement a method to incrementally update the array of gl_vertex_array input pointers. v2: Add some more comments. Rename _vbo_array_init to

[Mesa-dev] [PATCH 06/13] vbo: Use _DrawVAO for array type draw commands.

From: Mathias Fröhlich Switch over to use the _DrawVAO for all the array type draws. The _DrawVAO needs to be set before we enter _mesa_update_state, so move setting the draw method in front of the first call to _mesa_update_state which is in turn called from the

[Mesa-dev] [PATCH 07/13] mesa: Add flush_vertices to _mesa_{enable, disable}_vertex_array_attrib.

From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/main/enable.c | 4 ++--

[Mesa-dev] [PATCH 10/13] vbo: Implement tool functions for vbo specific VAO setup.

From: Mathias Fröhlich Correct VBO_MATERIAL_SHIFT value. The functions will be used next in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_attrib.h | 4 ++-- src/mesa/vbo/vbo_private.h | 53

[Mesa-dev] [PATCH 13/13] vbo: Make use of _DrawVAO from the dlist code.

From: Mathias Fröhlich Finally use an internal VAO to execute display list draws. Avoid duplicate state validation for display list draws. Remove client arrays previously used exclusively for display lists. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 01/13] mesa: Provide an alternative to get_vp_mode()

From: Mathias Fröhlich To get equivalent information than get_vp_mode(), track the vertex processing mode in a per context variable at gl_vertex_program_state::_VPMode. This aims to replace get_vp_mode() as seen in the vbo module. But instead of the get_vp_mode()

[Mesa-dev] [PATCH 03/13] vbo: Remove get_vp_mode() and enum vp_mode.

From: Mathias Fröhlich Is now unused. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_private.h | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/vbo/vbo_private.h b/src/mesa/vbo/vbo_private.h

[Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will be used for immediate mode and dlist rendering. v2: More comments about the _DrawVAO, filter and enabled mask. Rename

[Mesa-dev] [PATCH 09/13] mesa: Add flush_vertices to _mesa_bind_vertex_buffer.

From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 16 +--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/varray.c

[Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. The function will be needed later in the series. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 02/13] vbo: Use _VPMode instead of get_vp_mode().

From: Mathias Fröhlich At those places where we used get_vp_mode() use gl_vertex_program_state::_VPMode instead. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.c | 4 ++-- src/mesa/vbo/vbo_exec_array.c | 11 ++-

[Mesa-dev] [PATCH 11/13] vbo: Make use of _DrawVAO from immediate mode draw

From: Mathias Fröhlich Finally use an internal VAO to execute immediate mode draws. Avoid duplicate state validation for immediate mode draws. Remove client arrays previously used exclusively for immediate mode draws. Signed-off-by: Mathias Fröhlich

[Mesa-dev] [PATCH 00/13] Switch over to use VAOs for drawing v2.

From: Mathias Fröhlich Hi Brian, Thanks for the review on v1!! The following series moves over to draw via a VAO in all draw paths. At the current stage this introduces an additional indirection for the immediate mode and display list draws. But in the mid term using

[Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for those and only those VAO objects. Signed-off-by: Mathias

[Mesa-dev] [PATCH] nv50, nvc0: fix integer MS resolves using 2d engine

We don't want filtering for integer textures, same as depth/stencil. Fixes: KHR-GL45.direct_state_access.renderbuffers_storage_multisample Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_blit.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] glsl: Parse 'layout' as a token with advanced blending or bindless

On Tue, Feb 20, 2018 at 6:28 AM, Kenneth Graunke wrote: > Both KHR_blend_equation_advanced and ARB_bindless_texture provide > layout qualifiers, and are exposed in compatibility contexts. We > need to parse the layout qualifier as a token in order for those > to work, but

Re: [Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

6 is Acked-By: Aaron Watry 7-11 (regardless of my comment in 9) are Reviewed-By: Aaron Watry --Aaron On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > Reviewed-by: Francisco Jerez > Signed-off-by: Pierre

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

On 22 February 2018 at 11:58, Dieter Nützel wrote: > Am 22.02.2018 02:35, schrieb Dave Airlie: >> >> 2018-02-22 10:57 GMT+10:00 Dieter Nützel : >>> >>> Making all in vulkan >>> make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten >>> make[3]: ***

Re: [Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > One flag that needs to be tracked is whether a library is allowed to > received mathematics optimisations or not, as the authorisation is given > when creating the library while the optimisations are specified when >

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

Am 22.02.2018 02:35, schrieb Dave Airlie: 2018-02-22 10:57 GMT+10:00 Dieter Nützel : Making all in vulkan make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten make[3]: *** Keine Regel vorhanden, um das Ziel „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“,

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

https://bugs.freedesktop.org/show_bug.cgi?id=105161 Kenneth Graunke changed: What|Removed |Added Resolution|--- |NOTABUG

Re: [Mesa-dev] [PATCH v3 05/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Patches 1-5: Reviewed-By: Aaron Watry On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/core/device.cpp | 6 +- > 1 file changed, 1 insertion(+), 5

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-22 10:57 GMT+10:00 Dieter Nützel : > Making all in vulkan > make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten > make[3]: *** Keine Regel vorhanden, um das Ziel > „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, > benötigt von

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

Making all in vulkan make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten make[3]: *** Keine Regel vorhanden, um das Ziel „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, benötigt von „wsi/linux-dmabuf-unstable-v1-protocol.c“, zu erstellen. Schluss. make[3]: Verzeichnis

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace wrote: > On Thu 21 Dec 2017, Daniel Vetter wrote: >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen >> wrote: >>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico >>>

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed 21 Feb 2018, Daniel Vetter wrote: > On Tue, Feb 20, 2018 at 10:14:47PM -0800, Chad Versace wrote: > > On Thu 21 Dec 2017, Daniel Vetter wrote: > > > On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen > > > wrote: > > >> On Wed, Dec 20, 2017 at 12:41 PM, Miguel

Re: [Mesa-dev] [PATCH 6/6] intel/isl: Improve the documentation on get_default_aux_state

On Wed 24 Jan 2018, Jason Ekstrand wrote: > Cc: Chad Versace > --- > src/intel/isl/isl.h | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h > index e3acb0e..cf53b5a 100644 > ---

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

Kenneth Graunke writes: > On Thursday, February 8, 2018 8:47:00 PM PST Emil Velikov wrote: >> Rejected (9) >> >> Jason Ekstrand (2): >> e52a9f18d69c94b7cb7f81361cdb9e2582c3d742 i965: Replace >> draw_aux_buffer_disabled with draw_aux_usage >>

Re: [Mesa-dev] [PATCH 1/6] i965/state: Ignore intel_obj->_Format for depth/stencil and ETC2

On Tue 20 Feb 2018, Jason Ekstrand wrote: > On Mon, Feb 19, 2018 at 10:01 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 24 Jan 2018, Jason Ekstrand wrote: > > We're about to start letting the intel_obj->_Format be the "real" > > texture format.  For depth/stencil

[Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/api/program.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH v3 20/21] clover: Implement clCreateProgramWithIL from OpenCL 2.1

Signed-off-by: Pierre Moreau --- Notes: v3: Remove the const from the length argument of clCreateProgramWithIL src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9

[Mesa-dev] [PATCH v3 16/21] clover: Implement clCreateProgramWithILKHR

Signed-off-by: Pierre Moreau --- Notes: v3: * Remove the const on the length argument to CreateProgramWithILKHR (Francisco Jerez); * Capitalize comment (Francisco Jerez); * Store the IL as a std::vector instead of a pointer + size (Francisco Jerez);

[Mesa-dev] [PATCH v3 19/21] clover: Advertise cl_khr_il_program

Signed-off-by: Pierre Moreau --- Notes: v3: Advertise cl_khr_il_program if if the device support NATIVE as IR src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 2 files changed, 5 insertions(+), 1

[Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Signed-off-by: Pierre Moreau --- Notes: v3: * Bump the required version of SPIRV-Tools to the latest release; * Add a dependency on llvm-spirv. configure.ac | 10 ++ meson.build | 4 2 files changed, 14 insertions(+) diff --git a/configure.ac

[Mesa-dev] [PATCH v3 17/21] clover: Handle CL_PROGRAM_IL_KHR in clGetProgramInfo

Signed-off-by: Pierre Moreau --- Notes: v3: Switch from using a pointer attribute to a vector (Francisco Jerez) src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH v3 18/21] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

Signed-off-by: Pierre Moreau --- Notes: v3: Throw an exception if the cl_khr_il_program extension is not supported (Francisco Jerez) src/gallium/state_trackers/clover/api/device.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3

[Mesa-dev] [PATCH v3 15/21] include/CL: Add cl_khr_il_program

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f..5ea4968042 100644 ---

[Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

Signed-off-by: Pierre Moreau --- .../state_trackers/clover/llvm/invocation.cpp | 26 ++ .../state_trackers/clover/llvm/invocation.hpp | 4 src/gallium/state_trackers/clover/meson.build | 2 +- 3 files changed, 31 insertions(+), 1

[Mesa-dev] [PATCH v3 12/21] clover: Remove the TGSI backend as unused

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/Makefile.am | 11 +- src/gallium/state_trackers/clover/Makefile.sources | 4 - src/gallium/state_trackers/clover/core/program.cpp | 15 +-- src/gallium/state_trackers/clover/meson.build | 9

[Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 39 +- src/gallium/state_trackers/clover/core/program.cpp | 3 +- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH v3 05/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index

[Mesa-dev] [PATCH v3 04/21] clover: Add an helper for checking if an IR is supported

Signed-off-by: Pierre Moreau --- Notes: v3: * Dropped supported_irs() (Francisco Jerez) * Changed supports_ir() argument type to `enum pipe_shader_ir` (Francisco Jerez) src/gallium/state_trackers/clover/core/device.cpp | 6 ++

[Mesa-dev] [PATCH v3 10/21] clover: Move device extensions definitions to core/device.cpp

Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++

[Mesa-dev] [PATCH v3 07/21] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v3 03/21] clover/api: Fix tab indentation to spaces

Acked-by: Francisco Jerez Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3 02/21] clover: update ICD table to support everything up to 2.2

From: Karol Herbst v2: add more prototypes Signed-off-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.cpp | 29 +++- src/gallium/state_trackers/clover/api/dispatch.hpp | 190

[Mesa-dev] [PATCH v3 08/21] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- Notes:

[Mesa-dev] [PATCH v3 00/21] Introducing SPIR-V support to clover

Hello, This updated series contains some additional fixes to clover, updates to the OpenCL headers shipped with Mesa, the removal of the TGSI backend in clover (as unused), the introduction of a new dependency, llvm-spirv, and some more changes summarised further down. llvm-spirv can be

[Mesa-dev] [AppVeyor] mesa master #6986 completed

Build mesa 6986 completed Commit c7e22483fe by Daniel Stone on 2/20/2018 8:56 PM: vulkan/wsi/x11: Consistently update and return swapchain status\n\nUse a helper function for updating the swapchain status. This will be\nused later to handle VK_SUBOPTIMAL_KHR,

[Mesa-dev] [AppVeyor] mesa master #6985 failed

Build mesa 6985 failed Commit cdeac00267 by Timothy Arceri on 2/21/2018 3:36 AM: nir: remove old assert\n\nThis was originally intended to make sure the remap location\nwas not -1. However the code has changed alot since then,\nthe location is now never set to

Re: [Mesa-dev] [PATCH v11 00/15] Modifiers for X11 EGL/Vulkan, WL/VK

Assuming you're ok with the squash-in and modifications in my branch, the whole lot is Reviewed-by: Jason Ekstrand except, of course, for the ones written by me. Let's make this happen! --Jason On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote:

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov wrote: > On 21 February 2018 at 18:50, Rob Herring wrote: >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> Pardon for dropping in late. I think

Re: [Mesa-dev] [PATCH v11 14/15] egl/x11: Support DRI3 v1.1

On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > Add support for DRI3 v1.1, which allows pixmaps to be backed by > multi-planar buffers, or those with format modifiers. This is both > for allocating render

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

On Wed, Feb 21, 2018 at 11:04 AM, Matt Turner wrote: > On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat wrote: >> On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli >> wrote: >>> My understanding is that this commit is enough

Re: [Mesa-dev] [PATCH] anv: Don't assert that stencil HiZ clears are single-slice

On Wed, Feb 21, 2018 at 01:08:26PM -0800, Jason Ekstrand wrote: > It's true for depth HiZ clears because we only have HiZ on single-slice > images right now. However, for stencil-only clears there is no such > restriction. > --- > src/intel/vulkan/genX_cmd_buffer.c | 9 ++--- > 1 file

[Mesa-dev] [PATCH v3 08/13] i965/miptree: Add space to store the clear value in the aux surface.

Similarly to vulkan where we store the clear value in the aux surface, we can do the same in GL. v2: Remove unneeded extra function. v3: Use clear_value_state_size instead of clear_value_size. Signed-off-by: Rafael Antognolli ---

[Mesa-dev] [PATCH v3 11/13] i965/surface_state: Silence warning.

This warning showed up after aux_bo started being used inside if (use_clear_address) {... But use_clear_address depends on aux_surf being not null, in which case aux_bo would also be set. Make the compiler happy anyway. Signed-off-by: Rafael Antognolli Reviewed-by:

[Mesa-dev] [PATCH v3 09/13] i965/blorp: Update the fast clear color entry buffer.

On Gen10, whenever the fast clear color changes, update it on the clear color entry buffer. This allow us to use it directly when emitting the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_blorp.c | 26 ++

[Mesa-dev] [PATCH v3 12/13] anv: Emit the fast clear color address, instead of value.

On Gen10+, instead of copying the clear color from the state buffer to the surface state, just use the address of the state buffer in the surface state directly. This way we can avoid the copy from state buffer to surface state. Signed-off-by: Rafael Antognolli ---

[Mesa-dev] [PATCH v3 13/13] anv: Use clear address for HiZ fast clears too.

Store the default clear address for HiZ fast clears on a global bo, and point to it when needed. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/anv_device.c | 19 +++ src/intel/vulkan/anv_image.c | 10 +++---

[Mesa-dev] [PATCH v3 10/13] i965/surface_state: Emit the clear color address instead of value.

On Gen10, when emitting the surface state, use the value stored in the clear color entry buffer by using a clear color address in the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 1 file

[Mesa-dev] [PATCH v3 07/13] intel/blorp: Add suport for fast clear address.

On gen10+, if surface->clear_color_addr is present, use it directly intead of copying it to the surface state. Signed-off-by: Rafael Antognolli --- src/intel/blorp/blorp_genX_exec.h | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v3 04/13] intel/isl: Update size of clear color value.

On gen10 and newer, there's a struct describing how to use the indirect clear color buffer, and it seems to be 8 dwords long - 4 for the clear color and the last 4 used by the hardware, apparently depending on the generation. So just set aside space for them since gen10. Optionally we can later

[Mesa-dev] [PATCH v3 00/13] Use clear color address in surface state.

Rebase of this series after lots of aux surface changes on anv. Cc: Jason Ekstrand Cc: Jordan Justen Cc: Topi Pohjolainen Rafael Antognolli (13): anv/image: Do not override lower bits of dword. genxml: Preserve

[Mesa-dev] [PATCH v3 02/13] genxml: Preserve fields that share dword space with addresses.

Some instructions contain fields that are either an address or a value of some type based on the content of other fields, such as clear color values vs address. That works fine if these fields are in the less significant dword, the lower 32 bits of the address, because they get OR'ed with the

[Mesa-dev] [PATCH v3 03/13] intel/genxml: Use a single field for clear color address on gen10.

genxml does not support having two address fields with different names but same position in the state struct. Both "Clear Color Address" and "Clear Depth Address Low" mean the same thing, only for different surface types. To workaround this genxml limitation, rename "Clear Color Address" to

[Mesa-dev] [PATCH v3 05/13] intel/genxml: Add Clear Color struct.

The size of the clear color struct (expected by the hardware) is 8 dwords (isl_dev.ss.clear_value_state_size here). But we still need to track the size of the clear color, used when memcopying it to/from the state buffer. For that we keep isl_dev.ss.clear_value_size. Signed-off-by: Rafael

[Mesa-dev] [PATCH v3 01/13] anv/image: Do not override lower bits of dword.

The lower bits seem to have extra fields in every platform but gen8 (even though we don't use them in gen9). So just go ahead and avoid using them for the address. Signed-off-by: Rafael Antognolli Reviewed-by: Topi Pohjolainen ---

[Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

gen10 can emit the clear color by setting it on a buffer somewhere, and then adding only the address to the surface state. This commit add support for that on isl_surf_fill_state, and if that is requested, skip setting the clear value itself. v2: Add assert to make sure we are at least on gen10.

Re: [Mesa-dev] [PATCH] radeonsi/nir: disable GLSL IR loop unrolling

On 22/02/18 06:09, Ilia Mirkin wrote: On Tue, Feb 20, 2018 at 8:35 PM, Timothy Arceri wrote: Delaying unrolling and allowing NIR to do it instead has been shown to result in better code in drivers such as i965. shader-db results appear to should the same is true for

Re: [Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

On Wed, Feb 21, 2018 at 1:32 PM, Daniel Stone wrote: > Hi, > > On 21 February 2018 at 20:50, Jason Ekstrand wrote: > > On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone > wrote: > >> @@ -832,7 +832,7 @@

Re: [Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

Hi, On 21 February 2018 at 21:24, Jason Ekstrand wrote: > On Wed, Feb 21, 2018 at 1:22 PM, Jason Ekstrand > wrote: >>> + uint32_t n = 0; >>> + uint32_t counts[2]; >>> + uint64_t *modifiers[2]; >>> + >>> + if (mod_reply->num_drawable_modifiers)

Re: [Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

Hi, On 21 February 2018 at 20:50, Jason Ekstrand wrote: > On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: >> @@ -832,7 +832,7 @@ x11_acquire_next_image_from_queue(struct x11_swapchain >> *chain, >> VkResult result =

Re: [Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

On Wed, Feb 21, 2018 at 1:22 PM, Jason Ekstrand wrote: > On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone > wrote: > >> Adds support for multiple planes and buffer modifiers. >> >> v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" >> Signed-off-by:

Re: [Mesa-dev] [PATCH] anv: Don't assert that stencil HiZ clears are single-slice

Tested-by: Rafael Antognolli On Wed, Feb 21, 2018 at 01:08:26PM -0800, Jason Ekstrand wrote: > It's true for depth HiZ clears because we only have HiZ on single-slice > images right now. However, for stencil-only clears there is no such > restriction. > --- >

Re: [Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: > Adds support for multiple planes and buffer modifiers. > > v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" > Signed-off-by: Daniel Stone > --- > src/vulkan/wsi/wsi_common_x11.c | 185

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

On Wed, Feb 21, 2018 at 3:03 PM, Daniel Schürmann wrote: > >> On Wed, Feb 21, 2018 at 1:00 PM, >> wrote: >>> >>> From: Dave Airlie >>> >>> Co-authored-by: Daniel Schürmann

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

On 21 February 2018 at 15:10, Chuck Atkins wrote: >> Something doesn't look quite right - it seems that xmesa_init_display >> should be fixed instead. >> >> Currently it returns non-NULL when either of the following fail: >> - driver.create_pipe_screen() >> -

[Mesa-dev] [PATCH] anv: Don't assert that stencil HiZ clears are single-slice

It's true for depth HiZ clears because we only have HiZ on single-slice images right now. However, for stencil-only clears there is no such restriction. --- src/intel/vulkan/genX_cmd_buffer.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi/nir: fix tess varying loads for doubles

For the series: Reviewed-by: Marek Olšák Marek On Wed, Feb 21, 2018 at 12:42 AM, Timothy Arceri wrote: > Fixes the following piglit tests: > > tests/spec/arb_tessellation_shader/execution/double-array-vs-tcs-tes.shader_test >

Re: [Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: > The FIFO thread signals shutdown by pushing UINT32_MAX into the acquire > queue, and shutdown is signaled to it by pushing UINT32_MAX into the > present queue. > > Explicitly catch a push of UINT32_MAX in either

Re: [Mesa-dev] [PATCH] radeonsi/nir: collect more accurate output_usagemask

Reviewed-by: Marek Olšák Marek On Wed, Feb 21, 2018 at 7:03 AM, Timothy Arceri wrote: > Fixes assert in glsl-1.50-gs-max-output-components piglit test. > > Note that the double handling will only work for doubles that > don't take up multiple slots

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli wrote: > My understanding is that this commit is enough to make the driver try to > initialize, at least for i965. If that's the case, how about we add > something like what was removed by commit >

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat wrote: > On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli > wrote: >> My understanding is that this commit is enough to make the driver try to >> initialize, at least for i965. If that's the case,

Re: [Mesa-dev] [PATCH v11 07+08/15] vulkan/wsi/x11: Consistently update and return swapchain status

For this one, I'm making live edits to see if I like the suggested changes. I'll send out the v2 with the comments incorporated when I'm done. On Wed, Feb 21, 2018 at 11:32 AM, Jason Ekstrand wrote: > From: Daniel Stone > > Use a helper function

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On 21 February 2018 at 18:50, Rob Herring wrote: > On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov > wrote: >> Hi all, >> >> Pardon for dropping in late. I think you've got nearly everything >> settled down, just sharing a couple of ideas. >> >> On 21

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

On Wed, Feb 21, 2018 at 3:13 PM, Connor Abbott wrote: > On Wed, Feb 21, 2018 at 3:03 PM, Daniel Schürmann > wrote: >> >>> On Wed, Feb 21, 2018 at 1:00 PM, >>> wrote: From: Dave Airlie

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov wrote: > Hi all, > > Pardon for dropping in late. I think you've got nearly everything > settled down, just sharing a couple of ideas. > > On 21 February 2018 at 04:19, Tomasz Figa wrote: >> On Wed, Feb

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

On Wed, Feb 21, 2018 at 11:09 AM, Scott D Phillips wrote: > Anuj Phogat writes: > >> On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips >> wrote: >>> Matt Turner writes: >>> From: Anuj

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

Please split this up into 4 patches: 1 for the core nir part, 1 for the spirv part, 1 for the ac part and finally 1 for the radv. On Wed, Feb 21, 2018 at 7:00 PM, wrote: > From: Dave Airlie > > Co-authored-by: Daniel Schürmann

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Tue, Feb 20, 2018 at 10:14:47PM -0800, Chad Versace wrote: > On Thu 21 Dec 2017, Daniel Vetter wrote: > > On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen > > wrote: > >> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico > >> wrote: > >>>

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

Hi George, This first showed up on one of our older dashboard machines without AVX (Nehalem processor). You can easily reproduce it by building with --with-swr-archs=knl,skx when the machine you're trying to use it on is neither. Note that dri-glx seems to handle this case just fine but

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

I believed I created the same failure by deleting libswr*.so, however in my case (running glxgears) I hit a SEGV in XMesaCreateVisual (calling xmdpy->screen->is_format_supported()), because xmesa_init_display() created an xmdpy with a NULL screen. I never get to the xmesa_close_display().

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #6 from Allan Sandfeld Jensen --- Right. I think NVidia can get away with it because this requirement is new in the KHR version, they also implement the original NV version which doesnt have it (and like is OpenGL

[Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

v2: fix indentation, prefix with "4.3:" like other sections. --- src/xdemos/glinfo_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index efa96e6..3668026 100644 --- a/src/xdemos/glinfo_common.c +++

  1   2   >