Re: [Mesa-dev] [PATCH] radeonsi: add a debug flag to zero vram allocations

2018-06-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 3:25 PM, Grazvydas Ignotas wrote: > This allows to avoid having to see garbage in Dying Light loading screen > at least, which probably expects Windows/NV behavior of all allocations > being zeroed by default. > > Analogous to radv flag

Re: [Mesa-dev] [PATCH] radeonsi: use shifts for sign extension

2018-06-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 3:25 PM, Grazvydas Ignotas wrote: > Avoids a branch and reduces code size a tiny bit: > text data bss dechex filename > 10804563 398653 2070368 13273584 ca89f0 /tmp/radeonsi_dri.so.old > 10804499 398653 2070368 13273520

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #10 from Timothy Arceri --- (In reply to xinghua from comment #9) > (In reply to Jordan Justen from comment #1) > > Any chance you might be able to write a small piglit test > > that shows the bug? For example: > > > >

Re: [Mesa-dev] [PATCH mesa 2/4] vulkan: add VK_EXT_display_control [v8]

2018-06-20 Thread Jason Ekstrand
Two more below. I had them in the previous email by my phone app decided to hide them. :-( On June 20, 2018 15:53:04 Keith Packard wrote: This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence

Re: [Mesa-dev] [PATCH mesa 3/4] anv: add VK_EXT_display_control to anv driver [v4]

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: >> + fence = vk_alloc2(>instance->alloc, allocator, sizeof (*fence), >> 8, >> + VK_SYSTEM_ALLOCATION_SCOPE_OBJECT); > > zalloc? Yes, definitely. Thanks for catching this. Updated and pushed the series. -- -keith signature.asc Description: PGP

Re: [Mesa-dev] [PATCH mesa 2/4] vulkan: add VK_EXT_display_control [v8]

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: >> + /* Look for a DPMS property if we haven't already found one */ >> + for (int p = 0; connector->dpms_property == 0 && p < >> drm_connector->count_props; p++) { > > I'm guessing this is well over 80 characters Sorry I missed this -- I haven't managed to configure

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #9 from xinghua --- (In reply to Jordan Justen from comment #1) > Any chance you might be able to write a small piglit test > that shows the bug? For example: > > https://cgit.freedesktop.org/piglit/commit/?id=f1dc46ddf8c1 Hi,

Re: [Mesa-dev] [PATCH mesa 2/4] vulkan: add VK_EXT_display_control [v8]

2018-06-20 Thread Jason Ekstrand
On June 20, 2018 15:53:04 Keith Packard wrote: This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Remove DRM_CRTC_SEQUENCE_FIRST_PIXEL_OUT flag. This has been

Re: [Mesa-dev] [PATCH mesa 3/4] anv: add VK_EXT_display_control to anv driver [v4]

2018-06-20 Thread Jason Ekstrand
On June 20, 2018 15:53:00 Keith Packard wrote: This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Adopt Jason Ekstrand's coding conventions Declare variables

Re: [Mesa-dev] [PATCH] mesa: fix glGetInteger64v for arrays of integers

2018-06-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 21/06/18 11:02, Marek Olšák wrote: From: Marek Olšák Cc: 18.1 --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 772ca00da1f..db0079beb51 100644 ---

Re: [Mesa-dev] [PATCH v2] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Jason Ekstrand
On June 20, 2018 17:04:25 Jordan Justen wrote: features.txt? It looks like some others have been missed recently. Yeah, I keep forgetting that's a thing. Should probably update that one of these days... --Jason -Jordan On 2018-06-20 08:07:20, Jason Ekstrand wrote: Cc: Keith Packard

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 8:55 PM, Robert Tarasov wrote: > From: "Joe M. Kniss" > > Add support for glsl 'invariant' modifier for output data declarations. > Gallium drivers that use TGSI serialization currently loose invariant > modifiers in glsl shaders. > > v2:

[Mesa-dev] [PATCH] mesa: fix glGetInteger64v for arrays of integers

2018-06-20 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 772ca00da1f..db0079beb51 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1996,21 +1996,21 @@

[Mesa-dev] [PATCH 4/4] ac/surface: disallow rotated micro tile mode

2018-06-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_surface.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 618b755afc7..6a335111314 100644 --- a/src/amd/common/ac_surface.c +++

[Mesa-dev] [PATCH 2/4] radeonsi: handle non-clearable DCC buffers as MSAA resolve dst

2018-06-20 Thread Marek Olšák
From: Marek Olšák This is reproducible on Stoney, but other chips may be affected too. Cc 18.1 --- src/gallium/drivers/radeonsi/si_blit.c | 5 + src/gallium/drivers/radeonsi/si_clear.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH O/4] RadeonSI fixes for Stoney

2018-06-20 Thread Marek Olšák
These were all discovered on Stoney except for the last patch, which is a precaution. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/4] radeonsi: disable DCC MSAA for 128bpp formats on Stoney

2018-06-20 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 --- src/gallium/drivers/radeonsi/si_texture.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_texture.c b/src/gallium/drivers/radeonsi/si_texture.c index b46208be252..05d5d1b8a6d 100644 ---

[Mesa-dev] [PATCH 3/4] radeonsi: fix occlusion queries with 16x AA without FBO attachments on Stoney

2018-06-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index cfe32bc7f5e..a7377f38745 100644 ---

Re: [Mesa-dev] [PATCH 1/6] mesa: add Uniform*d support to display lists

2018-06-20 Thread Timothy Arceri
On 20/06/18 15:16, Mathias Fröhlich wrote: Hi, It seems that dlist.c is getting popular again, but can't we generate most of dlist.c using the api files? Probably saves a lot of typing, copying and pasting in the long run. Should also be less error prone in the long run. Not that I think code

[Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-20 Thread Robert Tarasov
From: "Joe M. Kniss" Add support for glsl 'invariant' modifier for output data declarations. Gallium drivers that use TGSI serialization currently loose invariant modifiers in glsl shaders. v2: use boolean for invariant instead of unsigned. Change-Id: Ieac8639116def45233513b6867a847cf7fda2f55

[Mesa-dev] [PATCH 3/2] mesa: expose some ARB_viewport_array dependent extensions in compat

2018-06-20 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index bc1f21a2926..b1ee0214d6c 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@

[Mesa-dev] [PATCH 2/2] mesa: enable ARB_viewport_array in compat profile

2018-06-20 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py| 16 src/mesa/main/extensions_table.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py index e69c6b4df16..1a91785d375 100644 ---

[Mesa-dev] [PATCH 1/2] mesa: add ARB_viewport_array display list support

2018-06-20 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 211 ++ 1 file changed, 211 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 57ece6c30e0..8b1ddb05038 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -290,6 +290,15 @@ typedef enum

Re: [Mesa-dev] [PATCH v2] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Jordan Justen
features.txt? It looks like some others have been missed recently. -Jordan On 2018-06-20 08:07:20, Jason Ekstrand wrote: > Cc: Keith Packard > --- > src/amd/vulkan/radv_extensions.py | 1 + > src/amd/vulkan/radv_wsi_display.c | 57 + > src/intel/vulkan/anv_extensions.py | 1 +

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 --- Comment #2 from Bas Nieuwenhuizen --- Created attachment 140254 --> https://bugs.freedesktop.org/attachment.cgi?id=140254=edit Miscompiled shader Attached is the failing shader. spirv2nir is enough to trigger if you add a

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 Bas Nieuwenhuizen changed: What|Removed |Added Component|Drivers/Vulkan/radeon |Drivers/Vulkan/Common QA

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 --- Comment #1 from Bas Nieuwenhuizen --- with some print debugging, it looks like the failing validate is here: https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/amd/vulkan/radv_shader.c#L233 which is directly after spirv_to_nir. I

Re: [Mesa-dev] [PATCH] st/nir: Disable varying packing when doing transform feedback.

2018-06-20 Thread Timothy Arceri
nir_compact_varyings() is meant to skip over varyings used by xfb: /* We can't repack xfb varyings. */ if (var->data.always_active_io) continue; Any idea why that isn't working in this case? On 21/06/18 06:30, Eric Anholt wrote: If one of the TF variables got

[Mesa-dev] [PATCH mesa 3/4] anv: add VK_EXT_display_control to anv driver [v4]

2018-06-20 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Adopt Jason Ekstrand's coding conventions Declare variables at first use, eliminate extra whitespace

[Mesa-dev] [PATCH mesa 2/4] vulkan: add VK_EXT_display_control [v8]

2018-06-20 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Remove DRM_CRTC_SEQUENCE_FIRST_PIXEL_OUT flag. This has been removed from the proposed kernel API. Add

[Mesa-dev] [PATCH mesa 4/4] radv: add VK_EXT_display_control to radv driver [v5]

2018-06-20 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Rework fence integration into the driver so that waiting for any of a mixture of fence types (wsi,

[Mesa-dev] [PATCH mesa 1/4] anv: Support wait for heterogeneous list of fences [v3]

2018-06-20 Thread Keith Packard
Handle the case where the set of fences to wait for is not all of the same type by either waiting for them sequentially (waitAll), or polling them until the timer has expired (!waitAll). We hope the latter case is not common. While the current code makes sure that it always has fences of only one

[Mesa-dev] [PATCH mesa 0/4] Add EXT_display_control [v8]

2018-06-20 Thread Keith Packard
Here's the latest version of this series with only a few minor changes. It adapts to the API changes for surface_get_capabilities and changes how the allocator is found for fences. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: > That seems good to me. Unless, of course, DPMS is something we expect to > change over time somehow. Then again, we don't handle that at all right > now so meh. Let's go with what you wrote above for now. It's not even the dpms value, it's the dpms property itself,

Re: [Mesa-dev] [PATCH 6/7] anv: add VK_EXT_display_control to anv driver [v2]

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: > I believe that the WSI common code should be capable of fishing the > instance allocator out of the wsi_display so we need only pass the > allocator argument unmodified through to the core WSI code. Make sense? Thanks, I think I've sorted it out. I've pushed an updated

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 Bug ID: 106980 Summary: Basemark GPU vulkan benchmark fails. Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2 08/21] spirv: translate default-block uniforms

2018-06-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 12/05/18 19:40, Alejandro Piñeiro wrote: From: Nicolai Hähnle They are supported by SPIR-V for ARB_gl_spirv. v2 (changes on top of Nicolai's original patch): * Handle UniformConstant storage class for uniforms other than samplers and images. (Eduardo

Re: [Mesa-dev] [PATCH] squash! nir/linker: Add gl_nir_link_uniforms()

2018-06-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 20/06/18 22:27, Alejandro Piñeiro wrote: From: Neil Roberts Sets var->driver.location if the uniform was found from a previous stage. --- Hi Timothy, thanks for the review of the original patch. Recently we found that we missed a little thing (one line). As

Re: [Mesa-dev] [PATCH v2 13/16] intel: tools: dump-gpu: dump 48-bit addresses

2018-06-20 Thread Rafael Antognolli
On Tue, Jun 19, 2018 at 02:45:28PM +0100, Lionel Landwerlin wrote: > From: Scott D Phillips > > For gen8+, write out PPGTT tables in aub files so that full 48-bit > addresses can be serialized. > > v2: Fix handling of `end` index in map_ppgtt > > Signed-off-by: Scott D Phillips >

Re: [Mesa-dev] [PATCH v2 12/16] intel: tools: import intel_aubdump

2018-06-20 Thread Rafael Antognolli
diff -u --ignore-all-space shows that this and the original file are roughly the same, except for some macros, some includes and how we check for hardware gen. Acked-by: Rafael Antognolli On Tue, Jun 19, 2018 at 02:45:27PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin >

[Mesa-dev] [Bug 106910] Primus Segfaults after updating Mesa to 18.1.1

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106910 Daniel Serpell changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-20 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 9:44 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > >> + if (!prop) > >> + continue; > >> + if (prop->flags & DRM_MODE_PROP_ENUM) { > >> + if (!strcmp(prop->name, "DPMS")) > >> +connector->dpms_property =

Re: [Mesa-dev] [PATCH v2 11/16] intel: tools: update intel_aub.h

2018-06-20 Thread Rafael Antognolli
On Tue, Jun 19, 2018 at 02:45:26PM +0100, Lionel Landwerlin wrote: > Scott added new stuff in IGT. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/intel_aub.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/src/intel/tools/intel_aub.h

Re: [Mesa-dev] [PATCH] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: > I just sent a v2 which allocates a temporary array, calls properties2, and > then copies it back over. It doesn't duplicate the iteration code and > instead just leverages propertie2. On the down side, it's a bit more > allocation and data motion but, compared to the

Re: [Mesa-dev] [PATCH v2] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: All looks good to me. Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 06/16] intel: aubinator: handle GGTT mappings

2018-06-20 Thread Lionel Landwerlin
On 20/06/18 19:19, Rafael Antognolli wrote: On Tue, Jun 19, 2018 at 02:45:21PM +0100, Lionel Landwerlin wrote: We use memfd to store physical pages as they get read/written to and the GGTT entries translating virtual address to physical pages. Based on a commit by Scott Phillips.

[Mesa-dev] [PATCH] st/nir: Disable varying packing when doing transform feedback.

2018-06-20 Thread Eric Anholt
If one of the TF variables got varying-packed, it would end up with a new driver_location, despite the pipe_stream_output already being set up for the old driver location. This left the gallium driver with no way to work back to what varying was referenced by pipe_stream_output. Fixes these

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-20 Thread Cherniak, Bruce
> On Jun 18, 2018, at 9:23 AM, Juan A. Suarez Romero > wrote: > > RADV now requires LLVM 5.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 4.0. > > Let's bump required LLVM to 5.0 in swr too. Sorry, I didn't see this sooner. We are fine with bumping the swr

[Mesa-dev] [Bug 105699] s3tc fbo-generatemipmap-formats tests fail unless optimized

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105699 --- Comment #3 from Nanley Chery --- Is this still an issue? I'm not able to reproduce this on my SKL. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] radeonsi: add a debug flag to zero vram allocations

2018-06-20 Thread Grazvydas Ignotas
This allows to avoid having to see garbage in Dying Light loading screen at least, which probably expects Windows/NV behavior of all allocations being zeroed by default. Analogous to radv flag with the same name. --- src/gallium/drivers/radeonsi/si_pipe.c| 1 +

[Mesa-dev] [PATCH] radeonsi: use shifts for sign extension

2018-06-20 Thread Grazvydas Ignotas
Avoids a branch and reduces code size a tiny bit: text data bss dechex filename 10804563 398653 2070368 13273584 ca89f0 /tmp/radeonsi_dri.so.old 10804499 398653 2070368 13273520 ca89b0 /tmp/radeonsi_dri.so --- src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- 1 file

Re: [Mesa-dev] [PATCH v2 07/16] intel/tools/aubinator: aubinate ppgtt aubs

2018-06-20 Thread Rafael Antognolli
On Wed, Jun 20, 2018 at 12:01:28PM -0700, Rafael Antognolli wrote: > On Wed, Jun 20, 2018 at 11:03:32AM +0100, Lionel Landwerlin wrote: > > On 20/06/18 01:00, Rafael Antognolli wrote: > > > On Tue, Jun 19, 2018 at 02:45:22PM +0100, Lionel Landwerlin wrote: > > > > From: Scott D Phillips > > > >

Re: [Mesa-dev] [PATCH v2 07/16] intel/tools/aubinator: aubinate ppgtt aubs

2018-06-20 Thread Rafael Antognolli
On Wed, Jun 20, 2018 at 11:03:32AM +0100, Lionel Landwerlin wrote: > On 20/06/18 01:00, Rafael Antognolli wrote: > > On Tue, Jun 19, 2018 at 02:45:22PM +0100, Lionel Landwerlin wrote: > > > From: Scott D Phillips > > > > > > v2: by Lionel > > > Fix memfd_create compilation issue I guess

Re: [Mesa-dev] [PATCH v2 06/16] intel: aubinator: handle GGTT mappings

2018-06-20 Thread Rafael Antognolli
On Tue, Jun 19, 2018 at 02:45:21PM +0100, Lionel Landwerlin wrote: > We use memfd to store physical pages as they get read/written to and > the GGTT entries translating virtual address to physical pages. > > Based on a commit by Scott Phillips. > > Signed-off-by: Lionel Landwerlin > --- >

[Mesa-dev] [Bug 106976] Compilation failure due to missing xcb_randr_lease_t

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106976 --- Comment #3 from Danylo --- https://patchwork.freedesktop.org/patch/230449/ fixes meson build and only adds dependency on xrandr to autoconf. Meanwhile I fixed autoconf build. -- You are receiving this mail because: You are the QA Contact

Re: [Mesa-dev] [PATCH mesa] vulkan: EXT_acquire_xlib_display requires libXrandr headers to build

2018-06-20 Thread Keith Packard
Eric Engestrom writes: > On Tuesday, 2018-06-19 16:06:14 -0700, Keith Packard wrote: >> When VK_USE_PLATFORM_XLIB_XRANDR_EXT is defined, vulkan.h includes >> X11/extensions/Xrandr.h for the RROutput typedef which is used in >> the vkGetRandROutputDisplayEXT interface. >> >> Make sure we have

[Mesa-dev] [PATCH v4 6/7] mesa: add INTEL_blackhole_render

2018-06-20 Thread Lionel Landwerlin
v2: Implement missing Enable/Disable (Emil) v3: Drop unused NewIntelBlackholeRender (Ken) v4: Bring back NewIntelBlackholeRender as i965 implementation uses it again (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Kenneth Graunke --- src/mesa/main/enable.c | 14

[Mesa-dev] [PATCH v4 1/7] i965: add force posted register load

2018-06-20 Thread Lionel Landwerlin
Inspired by what is already in the kernel. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/intel_batchbuffer.c | 13 + 3 files changed, 16 insertions(+) diff

[Mesa-dev] [PATCH v4 2/7] i965: add a skylake only pipe control recommendation

2018-06-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c b/src/mesa/drivers/dri/i965/brw_pipe_control.c index 122ac260703..1b89e55c396 100644 ---

[Mesa-dev] [PATCH v4 3/7] i965: pipecontrol: allow NULL bo for writing registers

2018-06-20 Thread Lionel Landwerlin
When doing a LRI Post Sync operation, you can put the register offset in the lower 32bits of the address but won't need a BO. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v4 7/7] i965: enable INTEL_blackhole_render

2018-06-20 Thread Lionel Landwerlin
v2: condition the extension on context isolation support from the kernel (Chris) v3: (Lionel) The initial version of this change used a feature of the Gen7+ command parser to turn the primitive instructions into no-ops. Unfortunately this doesn't play well with how we're using

[Mesa-dev] [PATCH v4 4/7] intel: genxml: add Force Posted field to MI_LRI

2018-06-20 Thread Lionel Landwerlin
The kernel uses it. It's not recommended to use it in the batchbuffer, but the hardware doesn't seem to complain. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 1 + src/intel/genxml/gen11.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 +

[Mesa-dev] [PATCH v4 0/7] mesa/i965: Add support for INTEL_blackhole_render

2018-06-20 Thread Lionel Landwerlin
Hi all, This is a respin of the blackhole render extension with Haswell disabled. After digging a bit I found out that the kernel command parser drops our batch when it contains a write to INSTPM. Unfortunately I have to land those patches to be able to land the kernel ones. Cheers, Lionel

Re: [Mesa-dev] [PATCH mesa] vulkan: EXT_acquire_xlib_display requires libXrandr headers to build

2018-06-20 Thread Eric Engestrom
On Tuesday, 2018-06-19 16:06:14 -0700, Keith Packard wrote: > When VK_USE_PLATFORM_XLIB_XRANDR_EXT is defined, vulkan.h includes > X11/extensions/Xrandr.h for the RROutput typedef which is used in > the vkGetRandROutputDisplayEXT interface. > > Make sure we have the required header by checking

Re: [Mesa-dev] [PATCH 6/7] anv: add VK_EXT_display_control to anv driver [v2]

2018-06-20 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 10:31 PM, Keith Packard wrote: > Jason Ekstrand writes: > > >> + if (allocator) > >> + alloc = allocator; > >> + else > >> + alloc = >instance->alloc; > >> > > > > This is what vk_alloc2 is for. :-) > ... > > And vk_free2 > ... > > This isn't needed if you're

Re: [Mesa-dev] [PATCH v4 1/3] gallium/util: Fix build error due to cast to different size

2018-06-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 9:26 AM, Robert Foss wrote: > Signed-off-by: Robert Foss > Reviewed-by: Tomasz Figa > --- > Changes since v3: > - Added r-b from Tomasz > > src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++-- > 1 file changed, 2

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

2018-06-20 Thread Marek Olšák
It looks good. Thanks! Marek On Wed, Jun 20, 2018 at 12:47 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-06-20 08:58:05) >> On Wed, Jun 20, 2018 at 11:26 AM, Dylan Baker wrote: >> > Quoting Marek Olšák (2018-06-08 20:16:54) >> >> From: Marek Olšák >> >> >> >> This improves performance

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

2018-06-20 Thread Dylan Baker
Quoting Marek Olšák (2018-06-20 08:58:05) > On Wed, Jun 20, 2018 at 11:26 AM, Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-08 20:16:54) > >> From: Marek Olšák > >> > >> This improves performance for certain games. > >> > >> Cc: 18.1 > >> --- > >> src/gallium/drivers/radeonsi/si_buffer.c

[Mesa-dev] [Bug 106910] Primus Segfaults after updating Mesa to 18.1.1

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106910 --- Comment #2 from Daniel Serpell --- There is a backtrace in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901701: Thread 2.3 "glxgears" received signal

[Mesa-dev] [Bug 106976] Compilation failure due to missing xcb_randr_lease_t

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106976 --- Comment #2 from Bas Nieuwenhuizen --- I think this patch already on the list should also fix it? https://patchwork.freedesktop.org/patch/230449/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA

Re: [Mesa-dev] [PATCH 2/2] radv: set EVENT_WRITE_EOP.INT_SEL = wait for write confirmation

2018-06-20 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Wed, Jun 20, 2018 at 4:10 PM, Samuel Pitoiset wrote: > Ported from RadeonSI. > Not sure why this is needed but AMDVLK does something similar. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/si_cmd_buffer.c | 12 +--- > 1

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

2018-06-20 Thread Marek Olšák
On Wed, Jun 20, 2018 at 11:26 AM, Dylan Baker wrote: > Quoting Marek Olšák (2018-06-08 20:16:54) >> From: Marek Olšák >> >> This improves performance for certain games. >> >> Cc: 18.1 >> --- >> src/gallium/drivers/radeonsi/si_buffer.c | 6 +- >> 1 file changed, 5 insertions(+), 1

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

2018-06-20 Thread Dylan Baker
Quoting Marek Olšák (2018-06-08 20:16:54) > From: Marek Olšák > > This improves performance for certain games. > > Cc: 18.1 > --- > src/gallium/drivers/radeonsi/si_buffer.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_buffer.c

Re: [Mesa-dev] [PATCH] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-20 Thread andrii.simiklit
Hello, Thanks for your feedback. We don't implement GS before gen6, and I don't think there are plans for it at this point, so I think we can just simplify the patch by assuming that devinfo->gen is always going to be 6 here (later gens use a different implementation of GS). Got it. I will fix

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

2018-06-20 Thread Dylan Baker
Quoting Gert Wollny (2018-06-20 01:24:51) > Hi Dylan & Eric, > > are you fine with how the flag is added now in meson? If you don't have > any complaints I'm going to push the changes later today. > > many thanks, > Gert > > Am Dienstag, den 19.06.2018, 10:07 +0200 schrieb Gert Wollny: > >

Re: [Mesa-dev] [PATCH] docs/release-calendar: restore the missing 18.1 column

2018-06-20 Thread Dylan Baker
Quoting Emil Velikov (2018-06-20 05:33:48) > From: Emil Velikov > > Earlier commit removed the column, instead of adjusting it's height. > > Cc: Dylan Baker > Fixes: 0d4f338a116 ("docs: Update release-notes and calendar") > Signed-off-by: Emil Velikov > --- > docs/release-calendar.html | 1 +

Re: [Mesa-dev] [PATCH] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 10:05 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > Thoughts? > > You've looked at the code more closely than I have; please feel free to > leave it if you think it would seem worse as separate functions. > I just sent a v2 which allocates a temporary array,

[Mesa-dev] [PATCH v2] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Jason Ekstrand
Cc: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi_display.c | 57 + src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi_display.c | 56 + src/vulkan/wsi/wsi_common_display.c | 175 +---

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #22 from pritzl3...@gmail.com --- I am away travelling and I wont be able to try the patch until late next week. I will try the patch when I'm back and get back with the results. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH mesa 1/2] intel/aubinator: fix mem leak

2018-06-20 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 19/06/18 16:05, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/intel/tools/aubinator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index

[Mesa-dev] [PATCH] radv: remove unused 'predicated' param from some functions

2018-06-20 Thread Samuel Pitoiset
It's always false. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +-- src/amd/vulkan/radv_private.h| 2 -- src/amd/vulkan/radv_query.c | 7 ++- src/amd/vulkan/si_cmd_buffer.c | 28 4 files changed, 15 insertions(+), 25

Re: [Mesa-dev] [PATCH] virgl: add ARB_texture_view support

2018-06-20 Thread Gert Wollny
Looks good to me Reviewed-By: Gert Wollny Am Freitag, den 08.06.2018, 11:20 +1000 schrieb Dave Airlie: > From: Dave Airlie > > --- > docs/features.txt| 2 +- > src/gallium/drivers/virgl/virgl_encode.c | 7 +-- > src/gallium/drivers/virgl/virgl_hw.h | 1 + >

Re: [Mesa-dev] [PATCH 1/2] freedreno: a2xx: fix crash on first clear

2018-06-20 Thread Rob Clark
On Wed, Jun 20, 2018 at 10:01 AM, Ilia Mirkin wrote: > On Wed, Jun 20, 2018 at 9:56 AM, Rob Clark wrote: >> On Tue, Jun 19, 2018 at 9:02 PM, Jonathan Marek wrote: >>> blend can be NULL, so check for that >> >> hmm, which case are you hitting that? From a quick look I think >> a3xx-a5xx would

Re: [Mesa-dev] [PATCH 1/2] freedreno: a2xx: fix crash on first clear

2018-06-20 Thread Rob Clark
On Tue, Jun 19, 2018 at 9:02 PM, Jonathan Marek wrote: > blend can be NULL, so check for that hmm, which case are you hitting that? From a quick look I think a3xx-a5xx would have the same issue. Maybe we should just init ctx->blend to a dummy state obj when the ctx is created? BR, -R > >

[Mesa-dev] [Bug 106976] Compilation failure due to missing xcb_randr_lease_t

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106976 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #1 from

[Mesa-dev] [PATCH] configure.ac: Check for xcb-randr version and xrandr to enable leasing

2018-06-20 Thread Danylo Piliaiev
VK_USE_PLATFORM_XLIB_XRANDR_EXT requires xlib leasing which requires xcb-randr >= 1.13. Also xrandr header is required for this extension. The extension should not be automatically enabled if these dependencies aren't satisfied. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106976

[Mesa-dev] [PATCH v4 0/3] egl/android: Add DRM node probing and filtering

2018-06-20 Thread Robert Foss
This series replaces the dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD with DRM node probing and disables the support for drm_gralloc. The series has been tested on Qemu+AOSP, where a virtio gpu was successfully probed for and opened. The current branch can be found here:

[Mesa-dev] [PATCH v4 1/3] gallium/util: Fix build error due to cast to different size

2018-06-20 Thread Robert Foss
Signed-off-by: Robert Foss Reviewed-by: Tomasz Figa --- Changes since v3: - Added r-b from Tomasz src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp

[Mesa-dev] [PATCH v4 3/3] egl/android: Add DRM node probing and filtering

2018-06-20 Thread Robert Foss
This patch both adds support for probing & filtering DRM nodes and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD gralloc call. Currently the filtering is based just on the driver name, and the desired name is supplied using the "drm.gpu.vendor_name" Android property.

[Mesa-dev] [PATCH v4 2/3] egl/android: #ifdef out flink name support

2018-06-20 Thread Robert Foss
From: Rob Herring Maintaining both flink names and prime fd support which are provided by 2 different gralloc implementations is problematic because we have a dependency on a specific gralloc implementation header. This mostly disables the dependency on the gralloc implementation and headers.

[Mesa-dev] [Bug 106976] Compilation failure due to missing xcb_randr_lease_t

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106976 Bug ID: 106976 Summary: Compilation failure due to missing xcb_randr_lease_t Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-20 Thread emil . velikov
Hi Tomeu, On Wed, May 23, 2018 at 10:54:06AM +0200, Tomeu Vizoso wrote: > --- a/src/mesa/main/texcompress_etc.h > +++ b/src/mesa/main/texcompress_etc.h > @@ -28,6 +28,7 @@ > #include "glheader.h" > #include "texcompress.h" > #include "texstore.h" > +#include "pipe/p_format.h" > Gallium

[Mesa-dev] [PATCH] docs/release-calendar: restore the missing 18.1 column

2018-06-20 Thread Emil Velikov
From: Emil Velikov Earlier commit removed the column, instead of adjusting it's height. Cc: Dylan Baker Fixes: 0d4f338a116 ("docs: Update release-notes and calendar") Signed-off-by: Emil Velikov --- docs/release-calendar.html | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH v2 08/21] spirv: translate default-block uniforms

2018-06-20 Thread Alejandro Piñeiro
Hi Timothy, thanks for the review of the patches of this series. This patch and the squash I have just sent are the only patches pending to be reviewed. Would you mind to take a look to this patch too? Thanks in advance On 12/05/18 11:40, Alejandro Piñeiro wrote: > From: Nicolai Hähnle > >

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-06-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #20 from Samuel Pitoiset --- Created attachment 140246 --> https://bugs.freedesktop.org/attachment.cgi?id=140246=edit possible fix Does this patch help? -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [PATCH] squash! nir/linker: Add gl_nir_link_uniforms()

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts Sets var->driver.location if the uniform was found from a previous stage. --- Hi Timothy, thanks for the review of the original patch. Recently we found that we missed a little thing (one line). As we didn't push it to master yet, could you take a look to this change, so we

Re: [Mesa-dev] [PATCH] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-20 Thread Iago Toral
On Tue, 2018-06-19 at 17:06 +0300, Andrii Simiklit wrote: > We can not use the VUE Dereference flags combination for EOT > message under ILK and SNB because the threads are not initialized > there with initial VUE handle unlike Pre-IL. > So to avoid GPU hangs on SNB and ILK we need > to avoid

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-20 Thread Robert Foss
Hey Tomasz, Thanks for the quick feedback. On 2018-06-14 08:30, Tomasz Figa wrote: Hi Rob, Thanks for sending v3. Please see few more comments inline. On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote: This patch both adds support for probing & filtering DRM nodes and switches away from

Re: [Mesa-dev] [PATCH v2 07/16] intel/tools/aubinator: aubinate ppgtt aubs

2018-06-20 Thread Lionel Landwerlin
On 20/06/18 01:00, Rafael Antognolli wrote: On Tue, Jun 19, 2018 at 02:45:22PM +0100, Lionel Landwerlin wrote: From: Scott D Phillips v2: by Lionel Fix memfd_create compilation issue Fix pml4 address stored on 32 instead of 64bits Return no buffer if first ppgtt page is not

Re: [Mesa-dev] [PATCH v2 02/16] intel: aubinator: remove standard input processing option

2018-06-20 Thread Lionel Landwerlin
On 19/06/18 23:56, Rafael Antognolli wrote: On Tue, Jun 19, 2018 at 11:40:30AM -0700, Rafael Antognolli wrote: On Tue, Jun 19, 2018 at 02:45:17PM +0100, Lionel Landwerlin wrote: Now that we rely on mmap of the data to parse, we can't process the standard input anymore. Didn't we rely on mmap

  1   2   >