[Mesa-dev] [PATCH 10/11] ac: make some fns static

2018-06-26 Thread Dave Airlie
From: Dave Airlie Some of the compiler functions are no longer called outside the util file. --- src/amd/common/ac_llvm_util.c | 12 ++-- src/amd/common/ac_llvm_util.h | 7 --- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/amd/common/ac_llvm_util.c

[Mesa-dev] [PATCH 07/11] ac/radv: move llvm compiler info to struct and init in one place

2018-06-26 Thread Dave Airlie
From: Dave Airlie This creates a common per-thread compiler info struct, and adds the init code to it. This is mostly ported from radeonsi. The common info struct is used in radv first and replaces the current code. --- src/amd/common/ac_llvm_util.c | 50 +++

[Mesa-dev] [PATCH 09/11] radeonsi: port to shared ac llvm per-thread structs.

2018-06-26 Thread Dave Airlie
From: Dave Airlie The new structs are pretty much based on the radeonsi code, so it just ports over the uses to them. --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c| 50 --- src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH 02/11] radv: drop copy of ac_create_target_machine.

2018-06-26 Thread Dave Airlie
From: Dave Airlie Once we split the init once stuff out, this can be shared again. --- src/amd/vulkan/radv_shader.c | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index

[Mesa-dev] [PATCH 11/11] ac/radv: using tls to store llvm related info and speed up compiles (v3)

2018-06-26 Thread Dave Airlie
From: Dave Airlie I'd like to encourage people to test this to see if it helps (like does it make app startup better or less hitching in dxvk). The basic idea is to store a bunch of LLVM related data structs in thread local storage so we can avoid reiniting them every time we compile a shader.

[Mesa-dev] [PATCH 06/11] ac: add target library info helpers

2018-06-26 Thread Dave Airlie
From: Dave Airlie --- src/amd/common/ac_llvm_helper.cpp | 13 + src/amd/common/ac_llvm_util.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp index 1a2aee3bc9a..4bb89726b88 100644 ---

[Mesa-dev] [PATCH 08/11] ac/radv: wrap compiler emit to memory.

2018-06-26 Thread Dave Airlie
From: Dave Airlie This will be used later. --- src/amd/common/ac_llvm_helper.cpp | 9 + src/amd/common/ac_llvm_util.h | 4 src/amd/vulkan/radv_nir_to_llvm.c | 4 ++-- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_llvm_helper.cpp

[Mesa-dev] [PATCH 03/11] ac/radeonsi: refactor out pass manager init to common code.

2018-06-26 Thread Dave Airlie
From: Dave Airlie --- src/amd/common/ac_llvm_util.c | 30 ++ src/amd/common/ac_llvm_util.h | 2 ++ src/gallium/drivers/radeonsi/si_pipe.c | 27 ++- 3 files changed, 34 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 04/11] radv: port to use common passmgr code.

2018-06-26 Thread Dave Airlie
From: Dave Airlie This adds a inline always pass, but otherwise should work the same. --- src/amd/common/ac_llvm_util.c | 5 +++-- src/amd/vulkan/radv_nir_to_llvm.c | 26 +++--- 2 files changed, 6 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] radv/radeonsi : per thread compiler info refactoring

2018-06-26 Thread Dave Airlie
This series cleans up the idea for using thread local storage for the llvm target machine ref and the pass manager which has quite a large setup overhead. It first ports radv and radeonsi to a shared compiler info struct, based on the one radeonsi already uses, the final patch then adds the

[Mesa-dev] [PATCH 01/11] ac/radv: split the non-common init_once code from the common target code.

2018-06-26 Thread Dave Airlie
From: Dave Airlie This just splits out the non-shared code and reuses ac_get_llvm_target in radv. --- src/amd/common/ac_llvm_util.c | 6 -- src/amd/common/ac_llvm_util.h | 2 ++ src/amd/vulkan/radv_shader.c | 20

[Mesa-dev] [PATCH 05/11] radv: create/destroy passmgr at the higher level.

2018-06-26 Thread Dave Airlie
From: Dave Airlie This is prep work for moving this to a per-thread struct --- src/amd/vulkan/radv_nir_to_llvm.c | 15 +++ src/amd/vulkan/radv_private.h | 2 ++ src/amd/vulkan/radv_shader.c | 7 +-- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH] radeonsi: Add debug option to enable LLVM GlobalISel

2018-06-26 Thread Tom Stellard
R600_DEBUG=gisel will tell LLVM to use GlobalISel rather than SelectionDAG for instruction selection. --- src/amd/common/ac_llvm_util.c | 14 -- src/amd/common/ac_llvm_util.h | 1 + src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 7 +++

[Mesa-dev] [PATCH] i965/bufmgr: Use the correct argument order for bo_alloc_internal

2018-06-26 Thread Jason Ekstrand
The memzone and flags parameters were accidentally flipped in the call from brw_bo_alloc_tiled_2d. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c

Re: [Mesa-dev] [PATCH 19/23] intel/eu: Fix up various type conversions in brw_eu.c that are illegal C++.

2018-06-26 Thread Francisco Jerez
Kenneth Graunke writes: > On Monday, June 11, 2018 7:26:11 PM PDT Francisco Jerez wrote: >> diff --git a/src/intel/compiler/brw_eu.c b/src/intel/compiler/brw_eu.c >> index 6ef0a6a577c..80f05240b42 100644 >> --- a/src/intel/compiler/brw_eu.c >> +++ b/src/intel/compiler/brw_eu.c >> @@ -356,14

[Mesa-dev] [PATCHv2 09/23] intel/eu: Use descriptor constructors for pixel interpolator messages.

2018-06-26 Thread Francisco Jerez
v2: Use SET_BITS macro instead of left shift (Ken). --- src/intel/compiler/brw_eu.h | 15 +++ src/intel/compiler/brw_eu_emit.c | 23 ++- 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/src/intel/compiler/brw_eu.h b/src/intel/compiler/brw_eu.h

[Mesa-dev] [PATCHv2 11/23] intel/eu: Use descriptor constructors for dataport untyped surface messages.

2018-06-26 Thread Francisco Jerez
v2: Use SET_BITS macro instead of left shift (Ken). --- src/intel/compiler/brw_eu.h | 14 +++ src/intel/compiler/brw_eu_emit.c | 88 +--- 2 files changed, 52 insertions(+), 50 deletions(-) diff --git a/src/intel/compiler/brw_eu.h

[Mesa-dev] [PATCHv2 08/23] intel/eu: Use descriptor constructors for dataport write messages.

2018-06-26 Thread Francisco Jerez
v2: Use SET_BITS macro instead of left shift (Ken). --- src/intel/compiler/brw_eu.h | 41 src/intel/compiler/brw_eu_emit.c | 100 -- src/intel/compiler/brw_vec4_generator.cpp | 22 +++ 3 files changed, 65 insertions(+), 98

[Mesa-dev] [PATCHv2 07/23] intel/eu: Use descriptor constructors for dataport read messages.

2018-06-26 Thread Francisco Jerez
v2: Use SET_BITS macro instead of left shift (Ken). --- src/intel/compiler/brw_eu.h | 38 +++ src/intel/compiler/brw_eu_emit.c | 77 ++- src/intel/compiler/brw_fs_generator.cpp | 32 ++---

[Mesa-dev] [PATCHv2 06/23] intel/eu: Use descriptor constructors for sampler messages.

2018-06-26 Thread Francisco Jerez
v2: Use SET_BITS macro instead of left shift (Ken). --- src/intel/compiler/brw_eu.h | 37 +++- src/intel/compiler/brw_eu_emit.c | 45 +++ src/intel/compiler/brw_fs_generator.cpp | 72 ++-

[Mesa-dev] [PATCH 2.5/23] intel/eu: Define SET_BITS helper more easily reusable than SET_FIELD.

2018-06-26 Thread Francisco Jerez
Allows to specify a bitfield based on its upper and lower bounds instead of a symbolic field definition, kind of what the current GET_BITS macro is to GET_FIELD. --- src/intel/compiler/brw_eu_defines.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/compiler/brw_eu_defines.h

[Mesa-dev] [PATCHv2 03/23] intel/eu: Use brw_set_desc() along with a helper to set common descriptor controls.

2018-06-26 Thread Francisco Jerez
This replaces brw_set_message_descriptor() with the composition of brw_set_desc() and a new inline helper function that packs the common message descriptor controls into an integer. The goal is to represent all message descriptors as a 32-bit integer which is written at once into the instruction,

Re: [Mesa-dev] [PATCH 4/8] radv: add all dependencies from external to the first subpass

2018-06-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for patch 3-4. Not sure they should go to stable though, since they are optimizations? On Tue, Jun 26, 2018 at 11:49 PM, Fredrik Höglund wrote: > This is to avoid repeating dependencies when more than one subpass > has a dependency from external. > > Cc: >

Re: [Mesa-dev] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

2018-06-26 Thread Bas Nieuwenhuizen
Don't we still need this when having layout transitions? On Tue, Jun 26, 2018 at 11:49 PM, Fredrik Höglund wrote: > The Vulkan specification says: > >"An execution dependency with only VK_PIPELINE_STAGE_BOTTOM_OF_- > PIPE_BIT in the destination stage mask [...] does not delay >

[Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

2018-06-26 Thread Keith Packard
Instead of encouraging the client to re-create the swapchain and keep going with an OUT_OF_DATE error, tell the client that further use of the current surface will not succeed as the associated kernel objects are no longer valid. In particular, when a DRM lease is revoked, then the client needs

Re: [Mesa-dev] [PATCH 2/8] radv: handle multiple subpass dependencies with same dst

2018-06-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 26, 2018 at 11:49 PM, Fredrik Höglund wrote: > A subpass can have dependencies from multiple sources, and more > than one subpass can have a dependency to external. > > Cc: > Signed-off-by: Fredrik Höglund > --- > src/amd/vulkan/radv_pass.c | 12

Re: [Mesa-dev] [PATCH] radv: use separate bind points for the dynamic buffers

2018-06-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 26, 2018 at 11:19 AM, Samuel Pitoiset wrote: > The Vulkan spec says: > >"pipelineBindPoint is a VkPipelineBindPoint indicating whether > the descriptors will be used by graphics pipelines or compute > pipelines. There is a separate set of

[Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-26 Thread Drew Davenport
This change lets the following test pass on virgl: dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv --- src/gallium/drivers/virgl/virgl_screen.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 8/8] radv: take accesses into account in subpass dependencies

2018-06-26 Thread Fredrik Höglund
On Tuesday 26 June 2018, Fredrik Höglund wrote: > Limit implicit external dependencies to accesses performed on the > attachments in a render pass instance. Note that I'm not sure if we are supposed to optimize implicit dependencies in this way. I have a similar patch that takes load/store ops

[Mesa-dev] [PATCH 2/8] radv: handle multiple subpass dependencies with same dst

2018-06-26 Thread Fredrik Höglund
A subpass can have dependencies from multiple sources, and more than one subpass can have a dependency to external. Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pass.c

[Mesa-dev] [PATCH 7/8] radv: add implicit external subpass dependencies

2018-06-26 Thread Fredrik Höglund
Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c| 107 +++--- src/amd/vulkan/radv_private.h | 8 ++- 2 files changed, 105 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c index

[Mesa-dev] [PATCH 4/8] radv: add all dependencies from external to the first subpass

2018-06-26 Thread Fredrik Höglund
This is to avoid repeating dependencies when more than one subpass has a dependency from external. Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c index

[Mesa-dev] [PATCH 3/8] radv: ignore subpass self-dependencies

2018-06-26 Thread Fredrik Höglund
These are not automatically performed during a render pass instance. Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c index c41d4c2ba92..2827f5f1a8d 100644 ---

[Mesa-dev] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

2018-06-26 Thread Fredrik Höglund
The Vulkan specification says: "An execution dependency with only VK_PIPELINE_STAGE_BOTTOM_OF_- PIPE_BIT in the destination stage mask [...] does not delay processing of subsequent commands." Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_cmd_buffer.c | 3 ++-

[Mesa-dev] [PATCH 6/8] radv/meta: add explicit subpass dependencies

2018-06-26 Thread Fredrik Höglund
No functional change. Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_meta_blit.c | 66 +-- src/amd/vulkan/radv_meta_blit2d.c | 66 +-- src/amd/vulkan/radv_meta_clear.c | 45 +-

[Mesa-dev] [PATCH 8/8] radv: take accesses into account in subpass dependencies

2018-06-26 Thread Fredrik Höglund
Limit implicit external dependencies to accesses performed on the attachments in a render pass instance. Cc: Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c| 19 +++ src/amd/vulkan/radv_private.h | 1 + 2 files changed, 8 insertions(+), 12 deletions(-) diff

[Mesa-dev] [PATCH 5/8] radv: refactor render pass creation

2018-06-26 Thread Fredrik Höglund
Allocate the render pass with a single call to vk_zalloc2. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_pass.c| 45 +-- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 17 insertions(+), 29 deletions(-) diff --git a/src/amd/vulkan/radv_pass.c

Re: [Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

2018-06-26 Thread Denis Pauk
If someone can test I can also add support for bptc to swr tracker. (I have no access to Intel CPUs with avx* support.) Best regards, Denis. On Tue, Jun 26, 2018, 11:44 PM Denis Pauk wrote: > Sorry for mess, i forgot to send cover letter and used "git send-email -v3 > @~4

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-26 Thread Marek Olšák
On Tue, Jun 26, 2018 at 12:47 PM, Michel Dänzer wrote: > On 2018-06-26 06:37 PM, Marek Olšák wrote: >> On Tue, Jun 26, 2018, 4:26 AM Michel Dänzer wrote: >> >>> On 2018-06-26 03:49 AM, Marek Olšák wrote: Good timing. I have a patch that removes LLVM 5.0 support from AMD Mesa drivers.

[Mesa-dev] [PATCH 1/2] intel/blorp: Add a blorp_filter enum for use in blorp_blit

2018-06-26 Thread Jason Ekstrand
At the moment, this is entirely internal but we'll expose it to clients of the BLORP API in the next commit. --- src/intel/blorp/blorp.h | 8 ++ src/intel/blorp/blorp_blit.c | 212 +++ src/intel/blorp/blorp_priv.h | 12 +- 3 files changed, 123

[Mesa-dev] [PATCH 2/2] intel/blorp: Take an explicit filter parameter in blorp_blit

2018-06-26 Thread Jason Ekstrand
This lets us move the glBlitFramebuffer nonsense into the GL driver and make the usage of BLORP mutch more explicit and obvious as to what it's doing. --- src/intel/blorp/blorp.h | 3 +- src/intel/blorp/blorp_blit.c | 44 ++- src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

2018-06-26 Thread Denis Pauk
Sorry for mess, i forgot to send cover letter and used "git send-email -v3 @~4 --in-reply-to="<20180623131928.4186-1-pauk.de...@gmail.com>"". That have broke logic in https://patchwork.freedesktop.org/series/45301/. All mails with "v3" prefix contains fully same patches. On Tue, Jun 26, 2018 at

Re: [Mesa-dev] [PATCH] radv: remove unused 'predicated' parameter from some functions

2018-06-26 Thread Dave Airlie
On 27 June 2018 at 06:35, Samuel Pitoiset wrote: > It's always false. > > Signed-off-by: Samuel Pitoiset Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 3 +-- > src/amd/vulkan/radv_private.h| 2 -- > src/amd/vulkan/radv_query.c | 7 ++- >

[Mesa-dev] [PATCH] anv: Print the actual enum for ignored structure types

2018-06-26 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 33ae9fb82f2..3967f8de265 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -57,6 +57,7

[Mesa-dev] [PATCH] radv: remove unused 'predicated' parameter from some functions

2018-06-26 Thread Samuel Pitoiset
It's always false. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +-- src/amd/vulkan/radv_private.h| 2 -- src/amd/vulkan/radv_query.c | 7 ++- src/amd/vulkan/si_cmd_buffer.c | 28 4 files changed, 15 insertions(+), 25

[Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

2018-06-26 Thread Denis Pauk
v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Matt Turner --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v3 3/4] gallium/softpipe: Enable support bptc format.

2018-06-26 Thread Denis Pauk
v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry --- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index

[Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

2018-06-26 Thread Denis Pauk
Reuse code shared with mesa/main/texcompress_bptc. v2: Use block decompress function v3: Include static bptc code from texcompress_bptc_tmp.h Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Nicolai Hähnle CC: Marek Olšák CC: Gert Wollny ---

[Mesa-dev] [PATCH v3 1/4] mesa: add header for share bptc decompress functions

2018-06-26 Thread Denis Pauk
Move shared bptc functions to texcompress_bptc_tmp.h: * fetch_rgba_unorm_from_block * fetch_rgb_float_from_block * compress_rgba_unorm * compress_rgb_float Create decompress functions: * decompress_rgba_unorm * decompress_rgb_float Functions will be reused in gallium/auxiliary code. v2: Add

[Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

2018-06-26 Thread Denis Pauk
This series add code for reuse in gallium bptc decode logic from mesa/main/texcompress_bptc.c. Checked on x86_64 by: * LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER={llvmpipe,softpipe} * piglit/bin/bptc-float-modes * piglit/bin/bptc-modes * piglit/bin/compressedteximage

[Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

2018-06-26 Thread Denis Pauk
Reuse code shared with mesa/main/texcompress_bptc. v2: Use block decompress function v3: Include static bptc code from texcompress_bptc_tmp.h Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Nicolai Hähnle CC: Marek Olšák CC: Gert Wollny ---

[Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

2018-06-26 Thread Denis Pauk
v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Matt Turner --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v3 3/4] gallium/softpipe: Enable support bptc format.

2018-06-26 Thread Denis Pauk
v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry --- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index

[Mesa-dev] [PATCH v3 1/4] mesa: add header for share bptc decompress functions

2018-06-26 Thread Denis Pauk
Move shared bptc functions to texcompress_bptc_tmp.h: * fetch_rgba_unorm_from_block * fetch_rgb_float_from_block * compress_rgba_unorm * compress_rgb_float Create decompress functions: * decompress_rgba_unorm * decompress_rgb_float Functions will be reused in gallium/auxiliary code. v2: Add

[Mesa-dev] [PATCH] [rfc] ac/radv: using tls to store llvm related info and speed up compiles

2018-06-26 Thread Dave Airlie
From: Dave Airlie I'd like to encourage people to test this to see if it helps (like does it make app startup better or less hitching in dxvk). The basic idea is to store a bunch of LLVM related data structs in thread local storage so we can avoid reiniting them every time we compile a shader.

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add header for share bptc decompress functions

2018-06-26 Thread Denis Pauk
Hi! Thank you. I will move all shared code to texcompress_bptc_tmp.h, and send new patch series. On Mon, Jun 25, 2018 at 7:47 PM Marek Olšák wrote: > This looks OK, but did you try to build other gallium state trackers? > They don't link with anything in src/mesa, so the build will fail, >

Re: [Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

2018-06-26 Thread Dylan Baker
Quoting Marek Olšák (2018-06-26 09:31:40) > > > On Tue, Jun 26, 2018, 11:57 AM Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-18 16:33:08) > > From: Marek Olšák > > > > Some fields shouldn't be initialized, like framebuffers_bound and other > stats. > > It's

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

2018-06-26 Thread Jason Ekstrand
On Tue, Jun 26, 2018 at 4:08 AM, Iago Toral Quiroga wrote: > Storage images require to patch push constant stateto work, which happens > during > binding table emision. In the scenario where our pipeline and descriptors > are > not dirty, we don't re-emit the binding table, however, if our push

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-26 Thread Michel Dänzer
On 2018-06-26 06:37 PM, Marek Olšák wrote: > On Tue, Jun 26, 2018, 4:26 AM Michel Dänzer wrote: > >> On 2018-06-26 03:49 AM, Marek Olšák wrote: >>> Good timing. I have a patch that removes LLVM 5.0 support from AMD >>> Mesa drivers. :) >> >> Keep in mind that we have to support at least two

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-26 Thread Marek Olšák
On Tue, Jun 26, 2018, 4:26 AM Michel Dänzer wrote: > On 2018-06-26 03:49 AM, Marek Olšák wrote: > > Good timing. I have a patch that removes LLVM 5.0 support from AMD > > Mesa drivers. :) > > Keep in mind that we have to support at least two major versions of > LLVM, otherwise we force our users

Re: [Mesa-dev] [PATCH 01/19] radeonsi: clean up passing the is_monolithic flag for compilation

2018-06-26 Thread Marek Olšák
On Tue, Jun 26, 2018, 4:09 AM Emil Velikov wrote: > On 26 June 2018 at 01:48, Timothy Arceri wrote: > > On 26/06/18 09:51, Dieter Nützel wrote: > >> > >> Hello Marek, > >> > >> after this series landed I get this: > >> > >> Making all in targets/pipe-loader > >> make[4]: Verzeichnis

Re: [Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

2018-06-26 Thread Marek Olšák
On Tue, Jun 26, 2018, 11:57 AM Dylan Baker wrote: > Quoting Marek Olšák (2018-06-18 16:33:08) > > From: Marek Olšák > > > > Some fields shouldn't be initialized, like framebuffers_bound and other > stats. > > It's hopefully complete now. > > > > Cc: 18.1 > > --- > >

Re: [Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

2018-06-26 Thread Dylan Baker
Quoting Marek Olšák (2018-06-18 16:33:08) > From: Marek Olšák > > Some fields shouldn't be initialized, like framebuffers_bound and other stats. > It's hopefully complete now. > > Cc: 18.1 > --- > src/gallium/drivers/radeonsi/si_texture.c | 31 ++- > 1 file changed, 25

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-26 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-06-19 00:08:27) > On Fri, 2018-06-15 at 09:36 -0700, Dylan Baker wrote: > > Quoting Juan A. Suarez Romero (2018-06-15 07:26:18) > > > On Thu, 2018-06-14 at 10:16 -0700, Dylan Baker wrote: > > > > Quoting Bas Nieuwenhuizen (2018-06-14 09:21:49) > > > > > On Thu,

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

2018-06-26 Thread Dylan Baker
Quoting Emil Velikov (2018-06-26 06:19:08) > On 21 June 2018 at 16:15, Dylan Baker wrote: > > Quoting Emil Velikov (2018-04-24 10:49:21) > >> From: Emil Velikov > >> > >> Bring back the "detection" of the said variables, to allow > >> standalone execution. > >> > >> Fixes: db8cd8e36771

[Mesa-dev] [PATCH 2/2] intel/blorp: Take an explicit filter parameter in blorp_blit

2018-06-26 Thread Jason Ekstrand
This lets us move the glBlitFramebuffer nonsense into the GL driver and make the usage of BLORP mutch more explicit and obvious as to what it's doing. --- src/intel/blorp/blorp.h | 3 +- src/intel/blorp/blorp_blit.c | 44 ++- src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH 1/2] intel/blorp: Add a blorp_filter enum for use in blorp_blit

2018-06-26 Thread Jason Ekstrand
At the moment, this is entirely internal but we'll expose it to clients of the BLORP API in the next commit. --- src/intel/blorp/blorp.h | 8 ++ src/intel/blorp/blorp_blit.c | 212 +++ src/intel/blorp/blorp_priv.h | 12 +- 3 files changed, 123

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

2018-06-26 Thread Emil Velikov
On 21 June 2018 at 16:15, Dylan Baker wrote: > Quoting Emil Velikov (2018-04-24 10:49:21) >> From: Emil Velikov >> >> Bring back the "detection" of the said variables, to allow >> standalone execution. >> >> Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python >> script") >> Cc:

Re: [Mesa-dev] [PATCH 2/2] freedreno: a2xx: fix crash when freeing context

2018-06-26 Thread Erik Faye-Lund
On Tue, Jun 26, 2018, 14:00 Rob Clark wrote: > On Tue, Jun 26, 2018 at 3:32 AM, Erik Faye-Lund > wrote: > > On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek > wrote: > >> > >> Signed-off-by: Jonathan Marek > >> --- > >> src/gallium/drivers/freedreno/a2xx/fd2_program.c | 2 ++ > >> 1 file

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-26 Thread Roland Scheidegger
Am 26.06.2018 um 09:59 schrieb Gert Wollny: > Am Montag, den 25.06.2018, 23:47 +0200 schrieb Roland Scheidegger: >> >> Alright albeit you have logic to handle incoming z offsets, whereas >> that should always be 0. > I'm preparing for future standards that allow for these z-offsets ;) > >> To be

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-26 Thread Emil Velikov
Hi Stuart, On 20 June 2018 at 00:10, Stuart Young wrote: > Whichever way this goes, is it possible to have the pre-announce include a > link to the git repo/branch in question? > > This way, even if it's not part of the main repo, people can easily find it > and check out the pre-release in

Re: [Mesa-dev] [PATCH 2/2] freedreno: a2xx: fix crash when freeing context

2018-06-26 Thread Rob Clark
On Tue, Jun 26, 2018 at 3:32 AM, Erik Faye-Lund wrote: > On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek wrote: >> >> Signed-off-by: Jonathan Marek >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_program.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git

Re: [Mesa-dev] [PATCH] radv: make sure CP DMA is idle at the end of IBs

2018-06-26 Thread Samuel Pitoiset
On 06/22/2018 05:37 PM, Bas Nieuwenhuizen wrote: I'm wondering whether we need to do this more often in pipeline barriers? Yeah, you are right. Also I'd really appreciate if you could add a check to see if there is any CP DMA activity in the first place. Sure, will do. Thanks for your

Re: [Mesa-dev] [PATCH] radv: emit PIPELINESTAT_{START, STOP} events for pipeline stats queries

2018-06-26 Thread Samuel Pitoiset
On 06/26/2018 12:00 PM, Bas Nieuwenhuizen wrote: I assume the extra START when doing a stop and then a start immediately is not a problem? Probably not. Reviewed-by: Bas Nieuwenhuizen On Fri, Jun 22, 2018 at 7:16 PM, Samuel Pitoiset wrote: Ported from RadeonSI. This appears to fix

Re: [Mesa-dev] [PATCH] mesa: Return number of result bits for GL_ANY_SAMPLES_PASSED_CONSERVATIVE

2018-06-26 Thread Tapani Pälli
LGTM, enum is checked by get_query_binding_point before coming here (requires ARB_ES3_compatibility), this patch is: Reviewed-by: Tapani Pälli On 06/21/2018 12:34 PM, Danylo Piliaiev wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106986 Signed-off-by: Danylo Piliaiev ---

[Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

2018-06-26 Thread Iago Toral Quiroga
Storage images require to patch push constant stateto work, which happens during binding table emision. In the scenario where our pipeline and descriptors are not dirty, we don't re-emit the binding table, however, if our push constant state is dirty, we will re-emit the push constant state,

[Mesa-dev] [Bug 106283] Shader replacements works only for limited use cases

2018-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106283 --- Comment #14 from Tapani Pälli --- Created attachment 140342 --> https://bugs.freedesktop.org/attachment.cgi?id=140342=edit fix wip I believe this should do the trick. If this works OK for you I can clean it up and send it forward. --

Re: [Mesa-dev] [PATCH] radv: emit PIPELINESTAT_{START, STOP} events for pipeline stats queries

2018-06-26 Thread Bas Nieuwenhuizen
I assume the extra START when doing a stop and then a start immediately is not a problem? Reviewed-by: Bas Nieuwenhuizen On Fri, Jun 22, 2018 at 7:16 PM, Samuel Pitoiset wrote: > Ported from RadeonSI. > This appears to fix some random fails with: > dEQP-VK.query_pool.statistics_query.* > >

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Mesa-dev] [PATCH] radv: use separate bind points for the dynamic buffers

2018-06-26 Thread Samuel Pitoiset
The Vulkan spec says: "pipelineBindPoint is a VkPipelineBindPoint indicating whether the descriptors will be used by graphics pipelines or compute pipelines. There is a separate set of bind points for each of graphics and compute, so binding one does not disturb the other." CC:

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-26 Thread Michel Dänzer
On 2018-06-26 03:49 AM, Marek Olšák wrote: > Good timing. I have a patch that removes LLVM 5.0 support from AMD > Mesa drivers. :) Keep in mind that we have to support at least two major versions of LLVM, otherwise we force our users to upgrade Mesa and LLVM in lockstep, which can be painful.

Re: [Mesa-dev] [PATCH] radv: enable VK_EXT_shader_stencil_export

2018-06-26 Thread Bas Nieuwenhuizen
Did not see that we already had tests for it. Reviewed-by: Bas Nieuwenhuizen On Mon, Jun 25, 2018 at 3:56 PM, Samuel Pitoiset wrote: > The driver already supports exporting the stencil value. > > The following CTS test now pass: > dEQP-VK.pipeline.shader_stencil_export.op_replace > >

Re: [Mesa-dev] [PATCH 01/19] radeonsi: clean up passing the is_monolithic flag for compilation

2018-06-26 Thread Emil Velikov
On 26 June 2018 at 01:48, Timothy Arceri wrote: > On 26/06/18 09:51, Dieter Nützel wrote: >> >> Hello Marek, >> >> after this series landed I get this: >> >> Making all in targets/pipe-loader >> make[4]: Verzeichnis „/opt/mesa/src/gallium/targets/pipe-loader“ wird >> betreten >>CXXLD

Re: [Mesa-dev] [PATCH] radv: ignore pInheritanceInfo for primary command buffers

2018-06-26 Thread Bas Nieuwenhuizen
CC to stable? Reviewed-by: Bas Nieuwenhuizen On Mon, Jun 25, 2018 at 4:22 PM, Samuel Pitoiset wrote: > From the Vulkan spec: > "If this is a primary command buffer, then this value is ignored." > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 3 ++- > 1 file

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-26 Thread Gert Wollny
Am Montag, den 25.06.2018, 23:47 +0200 schrieb Roland Scheidegger: > > Alright albeit you have logic to handle incoming z offsets, whereas > that should always be 0. I'm preparing for future standards that allow for these z-offsets ;) > To be honest I'm actually kind of surprised the hw would

Re: [Mesa-dev] [PATCH 2/2] freedreno: a2xx: fix crash when freeing context

2018-06-26 Thread Erik Faye-Lund
On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek wrote: > > Signed-off-by: Jonathan Marek > --- > src/gallium/drivers/freedreno/a2xx/fd2_program.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_program.c >

Re: [Mesa-dev] Testing drm_hwcomposer in RPi

2018-06-26 Thread chris simmonds
Hi Stefan, On 25 June 2018 at 18:09, Stefan Schake wrote: > Hey Chris, > > On Fri, Jun 22, 2018 at 12:09 PM, chris simmonds > wrote: > > Hi. > > > > I would like to try out drm_hwcomposer on a RPi 3. Can anyone point me > to a > > howto or something that tells me how? > > > > FYI, this is part

[Mesa-dev] [PATCH] nir/opt_if: Remove unneeded phis if we make progress

2018-06-26 Thread Samuel Iglesias Gonsálvez
Thanks a lot for fixing this, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 26/06/18 01:47, Jason Ekstrand wrote: > Now that SSA values can be derefs and they have special rules, we have > to be a bit more careful about our LCSSA phis. In particular, we need > to clean up in case LCSSA ended

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-26 Thread Mike Lothian
Hi I can confirm I no longer need to pass MESA_GL_VERSION_OVERRIDE to Dying Light Tested-by: Mike Lothian Cheers Mike On Tue, 26 Jun 2018 at 04:41 Dieter Nützel wrote: > Am 25.06.2018 13:26, schrieb Timothy Arceri: > > Please note I've fixed up make check where is was broken when enabling