Re: [Mesa-dev] [PATCH] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-07 Thread Harish Krupo
Ilia, Ilia Mirkin writes: > On Sat, Jul 7, 2018 at 11:15 PM, Harish Krupo > wrote: >> Ilia, >> >> Ilia Mirkin writes: >> >>> On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo >>> wrote: Clamp the x and y co-ordinates of the rectangles. Signed-off-by: Harish Krupo ---

Re: [Mesa-dev] [PATCH] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-07 Thread Ilia Mirkin
On Sat, Jul 7, 2018 at 11:15 PM, Harish Krupo wrote: > Ilia, > > Ilia Mirkin writes: > >> On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo >> wrote: >>> Clamp the x and y co-ordinates of the rectangles. >>> >>> Signed-off-by: Harish Krupo >>> --- >>> src/egl/main/eglapi.c | 23

Re: [Mesa-dev] [PATCH] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-07 Thread Harish Krupo
Ilia, Ilia Mirkin writes: > On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo > wrote: >> Clamp the x and y co-ordinates of the rectangles. >> >> Signed-off-by: Harish Krupo >> --- >> src/egl/main/eglapi.c | 23 +-- >> 1 file changed, 9 insertions(+), 14 deletions(-) >> >>

Re: [Mesa-dev] [PATCH] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-07 Thread Ilia Mirkin
On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo wrote: > Clamp the x and y co-ordinates of the rectangles. > > Signed-off-by: Harish Krupo > --- > src/egl/main/eglapi.c | 23 +-- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/src/egl/main/eglapi.c

Re: [Mesa-dev] [PATCH] nv50/ir: don't rely on inbound edge order in phi nodes

2018-07-07 Thread Karol Herbst
On Sun, Jul 8, 2018 at 1:01 AM, Rhys Perry wrote: > Previously, a phi node's sources were implicitly ordered by the inbound edge > order. This patch changes that so that a phi node instead has a basic block > stored for each source in a deque. > > There are no regressions in Unigine Heaven,

[Mesa-dev] [PATCH] nv50/ir: don't rely on inbound edge order in phi nodes

2018-07-07 Thread Rhys Perry
Previously, a phi node's sources were implicitly ordered by the inbound edge order. This patch changes that so that a phi node instead has a basic block stored for each source in a deque. There are no regressions in Unigine Heaven, Valley and Superposition (with a SERIALIZE hack to fix unrelated

Re: [Mesa-dev] [PATCH] i965: fix clear color bo address relocation

2018-07-07 Thread Kenneth Graunke
On Saturday, July 7, 2018 12:04:35 PM PDT Kenneth Graunke wrote: > On Saturday, July 7, 2018 6:08:34 AM PDT Lionel Landwerlin wrote: > > Fixes: 7987d041fda0c9 ("i965/surface_state: Emit the clear color address > > instead of value.") > > Signed-off-by: Lionel Landwerlin > > --- > >

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 100239, which changed state. Bug 100239 Summary: Incorrect rendering in CS:GO https://bugs.freedesktop.org/show_bug.cgi?id=100239 What|Removed |Added

[Mesa-dev] [PATCH] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-07 Thread Harish Krupo
Clamp the x and y co-ordinates of the rectangles. Signed-off-by: Harish Krupo --- src/egl/main/eglapi.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index c110349119..c7d07c4fde 100644 ---

Re: [Mesa-dev] [PATCH] st/wgl: check for NULL piAttribList in wglCreatePbufferARB()

2018-07-07 Thread Brian Paul
Thanks for investigating that one! Reviewed-by: Brian Paul On Fri, Jul 6, 2018 at 5:09 PM, Charmaine Lee wrote: > Java2d opengl pipeline passes NULL piAttribList to > wglCreatePbufferARB(). So skip parsing the attribute list > if it is NULL. > --- >

[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots

2018-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107146 --- Comment #1 from Roland Scheidegger --- (In reply to Bernhard Rosenkraenzer from comment #0) > createInstructionSimplifierPass() has been removed in LLVM. This is used in > a few places in SWR; looks like this can safely be removed because

Re: [Mesa-dev] [PATCH] i965: fix clear color bo address relocation

2018-07-07 Thread Kenneth Graunke
On Saturday, July 7, 2018 6:08:34 AM PDT Lionel Landwerlin wrote: > Fixes: 7987d041fda0c9 ("i965/surface_state: Emit the clear color address > instead of value.") > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- > 1 file changed, 1

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #26 from pritzl3...@gmail.com --- (In reply to Samuel Pitoiset from comment #21) > If my patch doesn't help, can you try master with "export > RADV_DEBUG=nocompute"? The game still hangs in the same way using LLVM 7 and Mesa master

[Mesa-dev] [PATCH v2] egl/dri: Use __DRI2_DAMAGE extension for KHR_partial_update

2018-07-07 Thread Harish Krupo
Use the DRI2 interface callback to pass the damage rects to the driver. v2: check for dri2_dpy->damage_extension after checking for optional_core_extensions in dr2_setup_extensions. Signed-off-by: Harish Krupo --- src/egl/drivers/dri2/egl_dri2.c | 46 ++---

Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-07 Thread Jason Ekstrand
On Thu, Jul 5, 2018 at 6:34 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Wed, Jun 27, 2018 at 07:00:56PM -0700, Jason Ekstrand wrote: > > The back-end compiler emits the number of color writes specified by > > wm_prog_key::nr_color_regions regardless of what

[Mesa-dev] [PATCH 1/7] vulkan: Update the XML and headers to 1.1.80

2018-07-07 Thread Jason Ekstrand
--- include/vulkan/vulkan_core.h | 193 +++- src/vulkan/registry/vk.xml | 280 +-- 2 files changed, 423 insertions(+), 50 deletions(-) diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h index a28661f4530..06c860707b8

[Mesa-dev] [PATCH 6/7] anv: Make subpass::depth_stencil_attachment a pointer

2018-07-07 Thread Jason Ekstrand
This makes certain checks a bit easier and means that we don't have the attachment information duplicated in the attachment list and in depth_stencil_attachment. --- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/anv_cmd_buffer.c | 4 ++-- src/intel/vulkan/anv_pass.c| 24

[Mesa-dev] [PATCH 4/7] anv/pass: Move some dependency setup into a helper

2018-07-07 Thread Jason Ekstrand
This new helper takes a VkSubpassDependency2KHR for future-proofing. --- src/intel/vulkan/anv_pass.c | 52 - 1 file changed, 34 insertions(+), 18 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index fe9b3d69819..b70de87a82b

[Mesa-dev] [PATCH 7/7] anv: Add support for VK_KHR_create_renderpass2

2018-07-07 Thread Jason Ekstrand
The implementation of CreateRenderPass2 uses the helpers we broke out in previous commits. The implementations of the new vkCmd functions just call the old versions. --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pass.c| 140 +

[Mesa-dev] [PATCH 2/7] anv/pass: Use a designated initailizer for attachments

2018-07-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 994a7e274f4..38460cb2fe3 100644 --- a/src/intel/vulkan/anv_pass.c +++ b/src/intel/vulkan/anv_pass.c @@

[Mesa-dev] [PATCH 3/7] anv/pass: Move a bunch of analysis into a separate "compile" stage

2018-07-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c | 114 1 file changed, 64 insertions(+), 50 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 38460cb2fe3..fe9b3d69819 100644 --- a/src/intel/vulkan/anv_pass.c +++

[Mesa-dev] [PATCH 5/7] anv/pass: Move implicit dependency setup to anv_render_pass_compile

2018-07-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c | 133 +--- 1 file changed, 63 insertions(+), 70 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index b70de87a82b..cb5e4bb7b79 100644 --- a/src/intel/vulkan/anv_pass.c +++

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-07 Thread Karol Herbst
On Sat, Jul 7, 2018 at 12:56 PM, Rhys Perry wrote: > I don't really see how things like RDSV(COMBINED_TID) + EXTBF + EXTBF > can be improved unless you create separate RDSV instructions (which is > against the point of this patch) or merge the EXTBF with later > instructions (and I don't really

[Mesa-dev] [PATCH] i965: fix clear color bo address relocation

2018-07-07 Thread Lionel Landwerlin
Fixes: 7987d041fda0c9 ("i965/surface_state: Emit the clear color address instead of value.") Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-07 Thread Rhys Perry
I don't really see how things like RDSV(COMBINED_TID) + EXTBF + EXTBF can be improved unless you create separate RDSV instructions (which is against the point of this patch) or merge the EXTBF with later instructions (and I don't really see how that can be done). It's only increases the size of

Re: [Mesa-dev] [PATCH] nir/print: Print texture and sampler indices

2018-07-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Jul 7, 2018 at 6:01 AM, Jason Ekstrand wrote: > Commit 5fb69daa6076e56b deleted support from nir_print for printing the > texture and sampler indices on texture instructions. This commit just > brings it back as best as we can. > --- >