This happens in situations where we might do
vec.wzyx[i] = ...
The swizzle would get effectively ignored because of the interaction
between how ir_assignment->set_lhs works and overwriting the write_mask.
Fixes the following WebGL test:
https://www.khronos.org/registry/webgl/sdk/tests/conform
On 10/4/18 7:48 PM, Gurchetan Singh wrote:
On Thu, Oct 4, 2018 at 7:41 AM Gert Wollny wrote:
From: Tomeu Vizoso
Pass the size of a resource when creating it so a backing can be kept in
the other side.
Also pass the required offset to transfer commands.
This moves vtest closer to how virtio
https://bugs.freedesktop.org/show_bug.cgi?id=108135
--- Comment #5 from Thiago Macieira ---
Please note that Clear was affected by this GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87522. HJ is on it. It affects
LTO.
However, there's still one load-time initialisation left even without
https://bugs.freedesktop.org/show_bug.cgi?id=108135
--- Comment #4 from Alok Hota ---
Hi Thiago,
Thanks for taking such a deep look into this. We probably shouldn't need to be
specifically targeting a specific architecture in the jitter. We may be able to
fix this by tweaking the build system.
https://bugs.freedesktop.org/show_bug.cgi?id=108135
Alok Hota changed:
What|Removed |Added
Assignee|timothy.o.row...@intel.com |alok.h...@intel.com
--
You are receiving t
From: Dave Airlie
Found by coverity
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 7ada3476961..dea91c7a189 100644
--- a/src/mesa/state_tracker/st_gl
Since we're modifying swrast now, we should change the commit title tag
from mesa/format_pack: to just mesa:
On Mon, Oct 01, 2018 at 07:18:41PM +0300, Illia Iorin wrote:
> Fixed pack_uint_Z_FLOAT32 by casting row data to float instead uint.
> Remove code duplicate function pack_uint_Z_FLOAT32_X24
From: Dave Airlie
There may be some security or sandbox reason this might fail, so
check and fail appropriately.
---
src/amd/vulkan/radv_meta.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c
index 1ec8896afa2..6616b1
From: Dave Airlie
If we fail the init path then don't call the free path.
Found by coverity
---
src/vulkan/wsi/wsi_common_wayland.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vulkan/wsi/wsi_common_wayland.c
b/src/vulkan/wsi/wsi_common_wayland.c
index 6b34e21bd9
From: Dave Airlie
We have never opened master_Fd at this point, so remove code to
close it.
Found by coverity.
---
src/amd/vulkan/radv_device.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 429d47325a3..88786c999de 100644
From: Dave Airlie
The value is always >= 0 here.
Found by coverity
---
src/amd/vulkan/radv_nir_to_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_nir_to_llvm.c
b/src/amd/vulkan/radv_nir_to_llvm.c
index 32d347ebd0f..bf6b8aee50e 100644
--- a/src/amd
From: Dave Airlie
Not going to matter, but be consistent.
Found by coverity
---
src/intel/vulkan/anv_allocator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c
index f62d48ae3fe..67f2f73aa11 100644
--- a/src/intel/vulkan/a
From: Dave Airlie
This might never happen, but handle it better.
Found by coverity
---
src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
index 9
From: Dave Airlie
Found by coverity
---
src/mesa/main/glspirv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
index fecf7384eb3..972989055e9 100644
--- a/src/mesa/main/glspirv.c
+++ b/src/mesa/main/glspirv.c
@@ -73,8 +73,6 @@ _mesa_spirv_s
Coverity pointed out a problem with svga_destroy_shader_variant, and
the functions that call it twice.
ret = svga_destroy_shader_variant(svga, SVGA3D_SHADERTYPE_VS, variant);
if (ret != PIPE_OK) {
svga_context_flush(svga, NULL);
ret = svga_destroy_shader_variant(svga,
From: Dave Airlie
Coverity pointed out we were copying 168 bytes here unnecessarily.
---
src/amd/vulkan/radv_pipeline.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 4b626a59af2..c1fe4ece396
On 10/ 3/18 10:57 PM, Roland Mainz wrote:
The term "small" is not right here, for example:
2. HSM (=Hierarchical Storage Management) may need some time
(=minutes) to fetch data from tape
3. You may not have the permission to |stat()| the specific file or
directory, thanks to the wonders of ACLs a
On Thu, Oct 4, 2018 at 3:25 AM Samuel Pitoiset
wrote:
>
> Did you benchmark copies and clears with GDS?
No, I didn't.
Marek
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Oct 4, 2018 at 3:25 AM Samuel Pitoiset
wrote:
>
>
>
> On 10/3/18 12:35 AM, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > ---
> > src/amd/common/sid.h | 5 +
> > src/gallium/drivers/radeonsi/si_fence.c | 19 ++-
> > src/gallium/dri
On Fri, Sep 14, 2018 at 10:45 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> Add basic helpers for doing tests on the vars related optimization
> passes. The main goal is to lower the barrier to create tests during
> development and debugging of the passes. Full coverage i
On Fri, Sep 14, 2018 at 10:46 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> Useful to walk the array removing elements by swapping them with the
> last element.
> ---
> src/util/u_dynarray.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/util/u_dynarray
https://bugs.freedesktop.org/show_bug.cgi?id=108082
--- Comment #6 from Vinson Lee ---
These warnings also appear with Intel C Compiler.
icc: command line warning #10148: option '-Wno-format-truncation' not supported
--
You are receiving this mail because:
You are the QA Contact for the bug.
Y
On Thu, Oct 4, 2018 at 7:41 AM Gert Wollny wrote:
>
> From: Tomeu Vizoso
>
> Pass the size of a resource when creating it so a backing can be kept in
> the other side.
>
> Also pass the required offset to transfer commands.
>
> This moves vtest closer to how virtio-gpu works, making it more usefu
On Thu, Oct 4, 2018 at 10:04 AM Matt Turner wrote:
> Nice.
>
> Reviewed-by: Matt Turner
>
> A piglit test would be a great addition as well.
>
As you wish:
https://patchwork.freedesktop.org/patch/254839/
That test doesn't actually trigger the bug though. You have to hack the
driver up to do
https://bugs.freedesktop.org/show_bug.cgi?id=97444
--- Comment #12 from Fabian Maurer ---
No, doesn't seem to happen anymore.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mai
I've attached the diff (no guarantees, can't test it right now).
nopt is useful because if there's tons of shaders to compile compilation is
quite a bit faster (but generally you really don't want to do this).
Not sure about why dumpbc isn't debug only, might not have been a deliberate
decision.
On Thu, Oct 4, 2018 at 7:41 AM Gert Wollny wrote:
>
> From: Gert Wollny
>
> The transfer size used in virglrenderer refers to uint32_t, so one
> must add 3 and then divide by 4 instead of adding 3/4 which is a no-op
> with integers.
>
> Fixes: b3b82fe8ea virgl/vtest: add vtest driver
>
> Signed-o
https://bugs.freedesktop.org/show_bug.cgi?id=108245
--- Comment #1 from Alex Smith ---
Created attachment 141900
--> https://bugs.freedesktop.org/attachment.cgi?id=141900&action=edit
Screenshot from the test case
--
You are receiving this mail because:
You are the assignee for the bug.
You ar
https://bugs.freedesktop.org/show_bug.cgi?id=108245
Bug ID: 108245
Summary: RADV/Vega: Low mip levels of large BCn textures get
corrupted by vkCmdCopyBufferToImage
Product: Mesa
Version: git
Hardware: Other
https://bugs.freedesktop.org/show_bug.cgi?id=97444
Michel Dänzer changed:
What|Removed |Added
Assignee|xorg-driver-...@lists.x.org |mesa-dev@lists.freedesktop.
Jenkins is good, I have pushed the patch with a small style fix and a
v2 tag in the commit log.
Iago
On Thu, 2018-10-04 at 10:15 +0300, Vadim Shovkoplias wrote:
> Thanks, I'll appreciate if you will push the patch once test will be
> finished.
> чт, 4 окт. 2018 г. в 9:52, Iago Toral :
> > On Wed, 2
https://bugs.freedesktop.org/show_bug.cgi?id=108109
Iago Toral changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Nice.
Reviewed-by: Matt Turner
A piglit test would be a great addition as well.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wednesday, 2018-10-03 11:05:36 -0700, Dylan Baker wrote:
> Quoting Dylan Baker (2018-10-03 10:35:45)
> > Currently mesa only supports EGL on Unix like systems, cygwin, and
> > haiku. Meson should actually enforce this. This fixes the default build
> > on MacOS.
> >
> > v2: - invert the conditio
From: Tomeu Vizoso
Pass the size of a resource when creating it so a backing can be kept in
the other side.
Also pass the required offset to transfer commands.
This moves vtest closer to how virtio-gpu works, making it more useful
for testing.
v2: - Use new messages for creation and transfers,
From: Gert Wollny
The transfer size used in virglrenderer refers to uint32_t, so one
must add 3 and then divide by 4 instead of adding 3/4 which is a no-op
with integers.
Fixes: b3b82fe8ea virgl/vtest: add vtest driver
Signed-off-by: Gert Wollny
---
src/gallium/winsys/virgl/vtest/virgl_vtest_
From: Andrii Simiklit
GLSL 3.7 (Identifiers):
"However, as noted in the specification, there are some cases where
previously declared variables can be redeclared to change or add some
property, and predeclared "gl_" names are allowed to be redeclared in a
shader only for these specific purposes.
Am Donnerstag, den 04.10.2018, 11:00 +0200 schrieb Gert Wollny:
>
> >
> > What does vtest_get_transfer_size return in most cases? It could
> > be one of two options:
> >
> > (a) (box->width * box->height * box->depth *
> > util_format_get_stride(res->format, box->width)
> > (b) (box->width * bo
Gives a +3.89% to +5.27% FPS improvement with Hitman and +2.73% to +2.82%
FPS improvement with Dirt Rally on my GTX 1060.
Signed-off-by: Rhys Perry
---
src/gallium/drivers/nouveau/nouveau_buffer.c | 4 +---
src/gallium/drivers/nouveau/nouveau_screen.c | 1 +
src/gallium/drivers/nouveau/nouve
Am Mittwoch, den 03.10.2018, 11:06 -0700 schrieb Gurchetan Singh:
> +
> > +
> > + if (vcmd == VCMD_TRANSFER_PUT2)
> > + vtest_hdr[VTEST_CMD_LEN] += (data_size + 3) / 4;
>
> Can you explain this calculation with a comment?
Will do.
> Also,
> virgl_vtest_send_transfer_cmd still uses "dat
https://bugs.freedesktop.org/show_bug.cgi?id=108164
Samuel Pitoiset changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Thu, Oct 4, 2018 at 10:42 AM Samuel Pitoiset
wrote:
>
> Since the driver no longer uses the availability bit for
> timestamp queries it shouldn't reset it. Instead, it should
> reset the query values to UINT32_MAX. This fixes VM faults.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id
Since the driver no longer uses the availability bit for
timestamp queries it shouldn't reset it. Instead, it should
reset the query values to UINT32_MAX. This fixes VM faults.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108164
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_qu
https://bugs.freedesktop.org/show_bug.cgi?id=108164
--- Comment #4 from Samuel Pitoiset ---
Does this help https://patchwork.freedesktop.org/patch/254755/ ?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug._
On Wed, Oct 3, 2018 at 9:17 PM Jason Ekstrand wrote:
>
> The ssa_for_alu_src helper will correctly handle swizzles and other
> source modifiers for you. The expansions for unpack_half_2x16,
> pack_uvec2_to_uint, and pack_uvec4_to_uint were all broken with regards
> to swizzles. The brokenness of
Am Montag, den 01.10.2018, 18:37 +0200 schrieb Guido Günther:
> The later are sensitive to unalligned accesses on arm64[1] and we don't
> need an uncached mapping here.
>
> [1]: https://lists.freedesktop.org/archives/etnaviv/2018-September/001956.html
>
> > Signed-off-by: Guido Günther
> ---
>
Fixes the garbage output I was seeing with bloom enabled. Thanks!
Tested-by: Alex Smith
On Wed, 3 Oct 2018 at 20:16, Jason Ekstrand wrote:
> The ssa_for_alu_src helper will correctly handle swizzles and other
> source modifiers for you. The expansions for unpack_half_2x16,
> pack_uvec2_to_uin
https://bugs.freedesktop.org/show_bug.cgi?id=108164
--- Comment #3 from Samuel Pitoiset ---
Polaris is affected as well. I'm looking.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa
Sure, my fault.
чт, 4 окт. 2018 г. в 10:27, Tapani Pälli :
> Reviewed-by: Tapani Pälli
>
> In the future, please remember update patch version when making changes
> and posting patch again, easiest way is to give '-v2' to
> git-format-patch and then update commit message with information what
>
Am Mittwoch, den 03.10.2018, 20:47 + schrieb Roland Scheidegger:
> Is it worth it splitting out to another var?
> We actually have code branches internally where we just define the
> gallivm_debug var always, and some of the debug flags outside the
> #ifdef
> debug (we'll actually need more t
https://bugs.freedesktop.org/show_bug.cgi?id=108164
--- Comment #2 from Józef Kucia ---
(In reply to Samuel Pitoiset from comment #1)
> What GPU? This looks like Vega?
Vega.
--- snip ---
vendorID = 0x1002
deviceID = 0x687f
deviceType = DISCRETE_GPU
deviceName = AMD RADV VEG
https://bugs.freedesktop.org/show_bug.cgi?id=108164
--- Comment #1 from Samuel Pitoiset ---
What GPU? This looks like Vega?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev maili
Reviewed-by: Tapani Pälli
In the future, please remember update patch version when making changes
and posting patch again, easiest way is to give '-v2' to
git-format-patch and then update commit message with information what
was changed. This will help the review process. Otherwise it may not
Did you benchmark copies and clears with GDS?
On 10/3/18 12:35 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 104 ++-
src/gallium/drivers/radeonsi/si_pipe.c | 4 +
src/gallium/drivers/radeonsi/si_pipe.h | 2 +
3 files c
On 10/3/18 12:35 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/amd/common/sid.h | 5 +
src/gallium/drivers/radeonsi/si_fence.c | 19 ++-
src/gallium/drivers/radeonsi/si_perfcounter.c | 2 ++
src/gallium/drivers/radeonsi/si_pipe.h
Thanks, I'll appreciate if you will push the patch once test will be
finished.
чт, 4 окт. 2018 г. в 9:52, Iago Toral :
> On Wed, 2018-10-03 at 16:24 +0300, Vadim Shovkoplias wrote:
>
> Hi Iago,
>
> I also think that compiler is the best place for the fix. But from my
> understanding compiler fix
56 matches
Mail list logo
