Re: [Mesa-dev] [PATCH v3 3/3] intel/i965: Enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
Am Donnerstag, den 18.10.2018, 13:22 -0700 schrieb Ian Romanick: > On 10/18/2018 09:39 AM, Gert Wollny wrote: > > From: Gert Wollny > > > > Enables and passes on i965: > > dEQP- > > GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* > > > > Signed-off-by: Gert Wollny > > ---

[Mesa-dev] [PATCH v2] meson: Add -Werror=return-type when supported.

2018-10-18 Thread Kenneth Graunke
This warning detects non-void functions with a missing return statement, return statements with a value in void functions, and functions with an bogus return type that ends up defaulting to int. It's already enabled by default with -Wall. Generally, these are fairly serious bugs in the code,

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-18 Thread Marek Olšák
It looks like there is a deadlock in LLVM when 2 shaders are compiled at the same time. I don't know why it doesn't happen with OpenGL. Marek On Thu, Oct 18, 2018 at 3:32 AM Michel Dänzer wrote: > On 2018-10-17 6:43 p.m., Marek Olšák wrote: > > Can you test the attached patch? > > Doesn't

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-18 Thread Ian Romanick
On 10/16/2018 08:49 PM, Timothy Arceri wrote: > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324, ssa_391 > > Can be simplified to: > >

Re: [Mesa-dev] Scons/GLES: shared_glapi and osmesa link failure

2018-10-18 Thread Jose Fonseca
I still can't make much sense of that github issue thread. Applications on Windows use opengl32.dll for acceleration, not libEGL/libGLESv1/libGLESv2 as these are not provided by the OS. The only place you see these DLLs are things like GLES -> D3D11/GL translators like Angle. So the

Re: [Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

2018-10-18 Thread Matt Turner
On Thu, Oct 18, 2018 at 1:28 PM Roland Scheidegger wrote: > > Am 18.10.18 um 19:25 schrieb Matt Turner: > > On Thu, Oct 18, 2018 at 8:46 AM Eric Engestrom > > wrote: > >> > >> Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" > >> Cc: Bas Nieuwenhuizen > >> Signed-off-by: Eric

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:46 PM Ian Romanick wrote: > On 10/18/2018 01:22 PM, Jason Ekstrand wrote: > > On Thu, Oct 18, 2018 at 3:11 PM Ian Romanick > > wrote: > > > > On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > > > From: Connor Abbott

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Ian Romanick
On 10/18/2018 01:22 PM, Jason Ekstrand wrote: > On Thu, Oct 18, 2018 at 3:11 PM Ian Romanick > wrote: > > On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > > From: Connor Abbott mailto:cwabbo...@gmail.com>> > > > > Shader-db results on Haswell: > >

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:24 PM Jason Ekstrand wrote: > On Thu, Oct 18, 2018 at 3:17 PM Jan Vesely wrote: > >> Hi, >> >> I think this patch breaks the build: >> https://travis-ci.org/jvesely/mesa/jobs/443356781 >> > > Interesting. It appears that it breaks when you have one of the WSI >

Re: [Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

2018-10-18 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Oct 18, 2018 at 5:46 PM Eric Engestrom wrote: > > Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" > Cc: Bas Nieuwenhuizen > Signed-off-by: Eric Engestrom > --- > src/amd/vulkan/si_cmd_buffer.c | 8 > 1 file changed, 4

Re: [Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

2018-10-18 Thread Roland Scheidegger
Am 18.10.18 um 19:25 schrieb Matt Turner: > On Thu, Oct 18, 2018 at 8:46 AM Eric Engestrom > wrote: >> >> Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" >> Cc: Bas Nieuwenhuizen >> Signed-off-by: Eric Engestrom >> --- >> src/amd/vulkan/si_cmd_buffer.c | 8 >> 1

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:17 PM Jan Vesely wrote: > Hi, > > I think this patch breaks the build: > https://travis-ci.org/jvesely/mesa/jobs/443356781 > Interesting. It appears that it breaks when you have one of the WSI extensions disabled. I'll take a look. --Jason > Jan > > On Tue,

Re: [Mesa-dev] [PATCH v3 3/3] intel/i965: Enable extension EXT_sRGB_write_control

2018-10-18 Thread Ian Romanick
On 10/18/2018 09:39 AM, Gert Wollny wrote: > From: Gert Wollny > > Enables and passes on i965: > dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* > > Signed-off-by: Gert Wollny > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 1 file changed, 1

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:11 PM Ian Romanick wrote: > On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > > From: Connor Abbott > > > > Shader-db results on Haswell: > > > > total instructions in shared programs: 2180337 -> 2154080 (-1.20%) > > instructions in affected programs: 959766 ->

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jan Vesely
Hi, I think this patch breaks the build: https://travis-ci.org/jvesely/mesa/jobs/443356781 Jan On Tue, 2018-10-16 at 08:18 -0500, Jason Ekstrand wrote: > FYI, patch 1 is required for this patch to build. It also means this patch > found a nice little bug. I'll respond to patch 1 in more

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Ian Romanick
On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > From: Connor Abbott > > Shader-db results on Haswell: > > total instructions in shared programs: 2180337 -> 2154080 (-1.20%) > instructions in affected programs: 959766 -> 933509 (-2.74%) > helped: 5653 > HURT: 2560 > > total

Re: [Mesa-dev] [PATCH] radeonsi: fix a radeon kernel clear state error

2018-10-18 Thread Marek Olšák
Hi Sonny, Can you send a version that only does >= CIK && drm_major == 3? It's equivalent to your version but simpler. Marek On Thu, Oct 18, 2018 at 12:40 PM Jiang, Sonny wrote: > Signed-off-by: Sonny Jiang > --- > src/gallium/drivers/radeonsi/si_pipe.c | 7 +-- >

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 2:49 PM Ian Romanick wrote: > On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > > From: Connor Abbott > > > > Shader-db results on Haswell: > > > > total instructions in shared programs: 2180337 -> 2154080 (-1.20%) > > instructions in affected programs: 959766 ->

Re: [Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-18 Thread Ian Romanick
On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > From: Connor Abbott > > Shader-db results on Haswell: > > total instructions in shared programs: 2180337 -> 2154080 (-1.20%) > instructions in affected programs: 959766 -> 933509 (-2.74%) > helped: 5653 > HURT: 2560 > > total

Re: [Mesa-dev] [PATCH 1/3] intel/peephole_ffma: Fix swizzle propagation

2018-10-18 Thread Ian Romanick
I was looking at this code just yesterday. How fortuitous. :) This patch is Reviewed-by: Ian Romanick On 10/17/2018 11:33 AM, Jason Ekstrand wrote: > The num_components value passed into get_mul_for_src is used to only > compose the parts of the swizzle that we know will be used so we don't >

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Bump number of allowed global buffers to 32

2018-10-18 Thread Marek Olšák
This is OK. Reviewed-by: Marek Olšák Marek On Thu, Oct 18, 2018 at 3:43 PM Jan Vesely wrote: > Fixes assertion failure/crash when running luxmark/luxball on clover. > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108272 > CC: mesa-sta...@lists.freedesktop.org > Signed-off-by: Jan

[Mesa-dev] [PATCH 1/1] radeonsi: Bump number of allowed global buffers to 32

2018-10-18 Thread Jan Vesely
Fixes assertion failure/crash when running luxmark/luxball on clover. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108272 CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Jan Vesely --- This is just a stop gap measure. OpenCL does not limit the number of global buffers, but we can

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

2018-10-18 Thread Marek Olšák
I think you need something like this: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack=ad774f9db1d735811a8d830ad90a2f8208aa0a7b I also have: rgtc: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack=c9c0ffc2d40f0119fb31bf0515f321cd877090dd bptc:

[Mesa-dev] [PATCH] radv: fix check for perftest options size

2018-10-18 Thread Andres Rodriguez
It was using the debug options array size. CC: mesa-sta...@lists.freedesktop.org Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

2018-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108355 --- Comment #9 from Hadrien Nilsson --- Created attachment 142083 --> https://bugs.freedesktop.org/attachment.cgi?id=142083=edit Xorg log with amdgpu_drv 18.1.0 I think you're right to be doubtful. I looked at the log and "amdgpu_drv.so"

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

2018-10-18 Thread Ilia Mirkin
On Thu, Oct 18, 2018 at 2:26 PM Erik Faye-Lund wrote: > On Oct 18, 2018 18:21, Ilia Mirkin wrote: > > Have you verified that this works OK on GLES2? This extension enables > online compression, which isn't normally available in GLES, and I > wouldn't be surprised if the current mesa TexImage

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

2018-10-18 Thread Erik Faye-Lund
On Oct 18, 2018 18:21, Ilia Mirkin wrote:Have you verified that this works OK on GLES2? This extension enables online compression, which isn't normally available in GLES, and I wouldn't be surprised if the current mesa TexImage handlers prevent it. The way I read the extension spec, it

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-18 Thread Jan Vesely
On Thu, 2018-10-18 at 09:32 +0200, Michel Dänzer wrote: > On 2018-10-17 6:43 p.m., Marek Olšák wrote: > > Can you test the attached patch? > > Doesn't help, unfortunately. Backtraces with the patch attached. > > FWIW, this is on Bonaire. Hi, fwiw, I don't see this hang on my carrizo/iceland

Re: [Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

2018-10-18 Thread Matt Turner
On Thu, Oct 18, 2018 at 8:46 AM Eric Engestrom wrote: > > Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" > Cc: Bas Nieuwenhuizen > Signed-off-by: Eric Engestrom > --- > src/amd/vulkan/si_cmd_buffer.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

[Mesa-dev] [ANNOUNCE] Mesa 18.2.3 release candidate

2018-10-18 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.3 is now available. Currently we have: - 38 queued - 1 nominated (outstanding) - and 0 rejected patches The current queue consists of: Several fixes and workarounds for different games, inlcuding RAGE, Yakuza and The Evil Within, Wolfenstein The

[Mesa-dev] [PATCH] radeonsi: fix a radeon kernel clear state error

2018-10-18 Thread Jiang, Sonny
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_pipe.c | 7 +-- src/gallium/drivers/radeonsi/si_state.c | 5 +++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index

[Mesa-dev] [PATCH v3 3/3] intel/i965: Enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny Enables and passes on i965: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* Signed-off-by: Gert Wollny --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c

[Mesa-dev] [PATCH v3 1/3] mesa/core: Add support for EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny This GLES extension gives the applications the control over deciding whether the conversion from linear space to sRGB is necessary by enabling or disabling this conversion at framebuffer write or blending time just like it is possible for desktop GL. v2: - Correct the

[Mesa-dev] [PATCH v3 0/3] Add and enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny The series now also correct for the Gallium drivers. best, Gert Gert Wollny (3): mesa/core: Add support for EXT_sRGB_write_control mesa/st: enable EXT_sRGB_write_control for drivers that support it intel/i965: Enable extension EXT_sRGB_write_control

[Mesa-dev] [PATCH v3 2/3] mesa/st: enable EXT_sRGB_write_control for drivers that support it

2018-10-18 Thread Gert Wollny
From: Gert Wollny With this patch the extension EXT_sRGB_write_control is enabled for gallium drivers that support sRGB formats as render targets. Tested (and pass) on r600 (evergreen) and softpipe: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* with

[Mesa-dev] [PATCH] anv: Allow presenting via a different GPU

2018-10-18 Thread Alex Smith
anv_GetPhysicalDeviceSurfaceSupportKHR will already return success for this, but anv_GetPhysicalDevice{Xcb,Xlib}PresentationSupportKHR do not. Apps which check for presentation support via the latter (all Feral Vulkan games at least) will therefore fail. This allows me to render on an Intel GPU

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

2018-10-18 Thread Ilia Mirkin
Have you verified that this works OK on GLES2? This extension enables online compression, which isn't normally available in GLES, and I wouldn't be surprised if the current mesa TexImage handlers prevent it. -ilia On Thu, Oct 18, 2018 at 11:05 AM Erik Faye-Lund wrote: > > The extension is

Re: [Mesa-dev] [PATCH] vulkan/wsi: Use VK_EXT_pci_bus_info for DRM fd matching

2018-10-18 Thread Eric Engestrom
On Thursday, 2018-10-18 10:13:39 -0500, Jason Ekstrand wrote: > This lets us avoid passing the DRM fd around all over the place and gets > us closer to layer utopia. Yay! Reviewed-by: Eric Engestrom > --- > src/amd/vulkan/radv_wsi.c | 3 -- > src/amd/vulkan/radv_wsi_x11.c | 4

[Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

2018-10-18 Thread Eric Engestrom
Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" Cc: Bas Nieuwenhuizen Signed-off-by: Eric Engestrom --- src/amd/vulkan/si_cmd_buffer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c

Re: [Mesa-dev] [PATCH] vulkan/wsi: Use VK_EXT_pci_bus_info for DRM fd matching

2018-10-18 Thread Lionel Landwerlin
Looks good : Reviewed-by: Lionel Landwerlin On 18/10/2018 16:13, Jason Ekstrand wrote: This lets us avoid passing the DRM fd around all over the place and gets us closer to layer utopia. --- src/amd/vulkan/radv_wsi.c | 3 -- src/amd/vulkan/radv_wsi_x11.c | 4 +--

[Mesa-dev] [PATCH] vulkan/wsi: Use VK_EXT_pci_bus_info for DRM fd matching

2018-10-18 Thread Jason Ekstrand
This lets us avoid passing the DRM fd around all over the place and gets us closer to layer utopia. --- src/amd/vulkan/radv_wsi.c | 3 -- src/amd/vulkan/radv_wsi_x11.c | 4 +-- src/intel/vulkan/anv_wsi.c | 4 +-- src/intel/vulkan/anv_wsi_x11.c | 4 +--

[Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

2018-10-18 Thread Erik Faye-Lund
The extension is written against both GL 1.2 and GLES 2.0, so let's also enable it on GLES 2.0. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h

Re: [Mesa-dev] correction: only regresses for Gallium drivers

2018-10-18 Thread Gert Wollny
Am Donnerstag, den 18.10.2018, 16:01 +0200 schrieb Gert Wollny: > Ignore this series, there are regressions, at least > > dEQP-GLES2.functional.texture.specification. > basic_copyteximage2d.2d_alpha > > glCopyTexImage2D(srgb usage mismatch) This regresses on gallium drivers (tested r600,

Re: [Mesa-dev] Scons/GLES: shared_glapi and osmesa link failure

2018-10-18 Thread Liviu Prodea
Well, all this started in that Github issue thread. That guy @elkhalafy was using llvmpipe to get Blender 2.80 to work on his system with unsupported (too old) iGPU. I don't know what he did but it resulted in Blender failing with missing libglapi.dll. So I researched about how to build it and

[Mesa-dev] [PATCH 1/3] ac: Introduce ac_build_expand()

2018-10-18 Thread Connor Abbott
And implement ac_bulid_expand_to_vec4() on top of it. Fixes: 7e7ee82698247d8f93fe37775b99f4838b0247dd ("ac: add support for 16bit buffer loads") --- src/amd/common/ac_llvm_build.c | 40 ++ src/amd/common/ac_llvm_build.h | 3 +++ 2 files changed, 29

[Mesa-dev] [PATCH 3/3] Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"

2018-10-18 Thread Connor Abbott
This reverts commit 647c2b90e96a9ab8571baf958a7c67c1e816911a. There was one recently-introduced bug in ac for dvec3 loads, but the other test failures were actually bugs in the tests. See https://github.com/cwabbott0/VK-GL-CTS/tree/voteallequal-fixes --- src/amd/vulkan/radv_device.c | 6 ++ 1

[Mesa-dev] [PATCH 2/3] ac: Fix loading a dvec3 from an SSBO

2018-10-18 Thread Connor Abbott
The comment was wrong, since the loop above casts to a type with the correct bitsize already. Fixes: 7e7ee82698247d8f93fe37775b99f4838b0247dd ("ac: add support for 16bit buffer loads") --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

2018-10-18 Thread Eric Engestrom
On Thursday, 2018-10-18 08:02:42 -0500, Jason Ekstrand wrote: > On October 18, 2018 05:40:14 Eric Engestrom wrote: > > > On Wednesday, 2018-10-17 15:14:03 -0500, Jason Ekstrand wrote: > > > We already have wsi_device and we know the instance allocator at > > > wsi_device_init time so there's no

[Mesa-dev] Ignore this series, was Re: [PATCH v2 0/3] Add and enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
Ignore this series, there are regressions, at least dEQP-GLES2.functional.texture.specification. basic_copyteximage2d.2d_alpha glCopyTexImage2D(srgb usage mismatch) Best, Gert Am Donnerstag, den 18.10.2018, 10:46 +0200 schrieb Gert Wollny: > From: Gert Wollny > > This is the updated

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

2018-10-18 Thread Jason Ekstrand
On October 18, 2018 05:40:14 Eric Engestrom wrote: On Wednesday, 2018-10-17 15:14:03 -0500, Jason Ekstrand wrote: We already have wsi_device and we know the instance allocator at wsi_device_init time so there's no need to pass it into the physical device queries. This also fixes a memory

Re: [Mesa-dev] Scons/GLES: shared_glapi and osmesa link failure

2018-10-18 Thread Jose Fonseca
I don't know what gles=y entails anymore, but if it's broken we should simply remove it. That said, our WGL GLES contexts, via WGL_EXT_create_context_es2_profile extension, even without gles=y option. So what exactly are you looking for here? Jose On 18/10/18 13:02, Liviu Prodea wrote:

[Mesa-dev] Scons/GLES: shared_glapi and osmesa link failure

2018-10-18 Thread Liviu Prodea
scons build=release platform=windows machine=x86 gles=y libgl-gdi osmesa Creating library build\windows-x86\mesa\drivers\osmesa\osmesa.lib and object build\windows-x86\mesa\drivers\osmesa\osmesa.exp osmesa.obj : error LNK2001: unresolved external symbol __imp___glapi_check_multithread osmesa.obj

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

2018-10-18 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 17/10/2018 21:14, Jason Ekstrand wrote: We already have wsi_device and we know the instance allocator at wsi_device_init time so there's no need to pass it into the physical device queries. This also fixes a memory allocation domain bug that can occur if

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi: Implement GetPhysicalDevicePresentRectanglesKHR

2018-10-18 Thread Lionel Landwerlin
Awesome! Reviewed-by: Lionel Landwerlin On 17/10/2018 21:14, Jason Ekstrand wrote: This got missed during 1.1 enabling because it was defined as an interaction between device groups and WSI and it wasn't obvious it was in the delta. The idea behind it is that it's supposed to provide a hint

Re: [Mesa-dev] [PATCH 02/15] meson: update required amdgpu version to 2.4.95

2018-10-18 Thread Liu, Leo
On 2018-10-17 3:03 p.m., boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > VCN jpeg requires new hw ip Patch 1 & 2 are: Reviewed-by: Leo Liu > > Signed-off-by: Boyuan Zhang > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

2018-10-18 Thread Eric Engestrom
On Wednesday, 2018-10-17 15:14:03 -0500, Jason Ekstrand wrote: > We already have wsi_device and we know the instance allocator at > wsi_device_init time so there's no need to pass it into the physical > device queries. This also fixes a memory allocation domain bug that can > occur if

Re: [Mesa-dev] [PATCH 3/3] mesa: Add missed include guards

2018-10-18 Thread Emil Velikov
Hi Michał, On Wed, 17 Oct 2018 at 07:42, wrote: > > From: Michał Janiszewski > > Signed-off-by: Michał Janiszewski > --- > src/compiler/glsl/ir_builder.h| 5 + > src/gallium/drivers/svga/include/svga3d_surfacedefs.h | 5 + >

Re: [Mesa-dev] [PATCH 1/3] gallium: Fix mismatched ifdef-guards

2018-10-18 Thread Emil Velikov
Hi Michał, Welcome to Mesa :-) On Wed, 17 Oct 2018 at 07:42, wrote: > > From: Michał Janiszewski > > Signed-off-by: Michał Janiszewski > --- > src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This and 2/3 are

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 1/1] swr/rast: ignore CreateElementUnorderedAtomicMemCpy

2018-10-18 Thread Emil Velikov
On Wed, 17 Oct 2018 at 21:43, Alok Hota wrote: > > This function's API changed between LLVM 5 and 6. Compile errors occur > when building with LLVM 6+ if LLVM 5 was used for a dist tarball > > CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107865 Reviewed-by: Emil Velikov Thanks

[Mesa-dev] [PATCH v2 2/3] mesa/st: enable EXT_sRGB_write_control for drivers that support it

2018-10-18 Thread Gert Wollny
From: Gert Wollny With this patch the extension EXT_sRGB_write_control is enabled for gallium drivers that support sRGB formats as render targets. Tested (and pass) on r600 (evergreen) and softpipe: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* with

[Mesa-dev] [PATCH v2 0/3] Add and enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny This is the updated version of the patches following Ilia's pointers, but also correcting some additional parts. Changes: - core: Correct the extension table to list the extension as GLES only - core: drop EXTRA_API_ES3, the requirements for get operations listed

[Mesa-dev] [PATCH v2 3/3] intel/i965: Enable extension EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny Enables and passes on i965: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled*, and still passes dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum when extension is manually disabled via MESA_EXTENSION_OVERRIDE.

[Mesa-dev] [PATCH v2 1/3] mesa/core: Add support for EXT_sRGB_write_control

2018-10-18 Thread Gert Wollny
From: Gert Wollny This GLES extension gives the applications the control over deciding whether the conversion from linear space to sRGB is necessary by enabling or disabling this conversion at framebuffer write or blending time just like it is possible for desktop GL. Note, the extension could

Re: [Mesa-dev] [PATCH] intel/tools: Remove hardcoded PADDING_SIZE from sanitizer

2018-10-18 Thread Danylo Piliaiev
On Wed, Oct 17, 2018 at 6:47 PM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Wed, Oct 17, 2018 at 06:08:34PM +0300, Danylo Piliaiev wrote: > > Signed-off-by: Danylo Piliaiev > > --- > > src/intel/tools/intel_sanitize_gpu.c | 38 +++- > > 1 file changed,

[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

2018-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108355 --- Comment #8 from Michel Dänzer --- (In reply to Hadrien Nilsson from comment #7) > amdgpu.dc=0 had no effect, but using xf86-video-amdgpu 18.1.0 indeed fixed > the problem :) Thank you Michel. Well, that's a surprising result though. Please

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-18 Thread Michel Dänzer
On 2018-10-17 6:43 p.m., Marek Olšák wrote: > Can you test the attached patch? Doesn't help, unfortunately. Backtraces with the patch attached. FWIW, this is on Bonaire. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |