_mesa_es3_error_check_format_and_type isn't specific to OpenGL ES 3.x,
it applies to all versions of OpenGL ES. So let's rename it to reflect
this.
While we're at it, let's also rename a helper function it uses similarly.
As the helper is static, we can also remove the namespacing-prefix from
the
This makes the logic a little bit easier to follow; this is *either*
about ES2 compatibility *or* about gles. GL_RGB565 was added already in
OpenGL ES 1.0.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/mai
_mesa_has_FOO_bar() knows about the APIs these extensions should be
supported under, so let's use that to simplify these checks a bit.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/mesa/main
On Thu, 2018-11-22 at 13:26 +0100, Mathias Fröhlich wrote:
> Hi Erik,
>
> The series looks very reasonable and I could not spot loosing any
> negating ! in the
> query logic. Even if I have not been able time wise to double checked
> every move when
> which texture format got introduced in which E
https://bugs.freedesktop.org/show_bug.cgi?id=108848
--- Comment #3 from ilia ---
Created attachment 142590
--> https://bugs.freedesktop.org/attachment.cgi?id=142590&action=edit
Wine backtrace of game segfault
In doubt is this relevant, but game also segfaults with this backtrace when
pressing
https://bugs.freedesktop.org/show_bug.cgi?id=108848
--- Comment #2 from ilia ---
Created attachment 142588
--> https://bugs.freedesktop.org/attachment.cgi?id=142588&action=edit
Log with nine disabled
Same env variables as with nine enabled.
--
You are receiving this mail because:
You are the
On Fri, 2018-11-23 at 07:45 +0200, Tapani Pälli wrote:
> Ping, this series has not landed yet, planning to land it soon?
>
Sorry for the delay, pushed now!
> On 11/9/18 7:58 AM, Tapani Pälli wrote:
> > Thanks, _mesa_has makes things a lot cleaner and simpler to manage;
> >
> > Reviewed-by: Tapa
https://bugs.freedesktop.org/show_bug.cgi?id=108848
--- Comment #1 from ilia ---
Created attachment 142587
--> https://bugs.freedesktop.org/attachment.cgi?id=142587&action=edit
Log with nine enabled
Game running with
GALLIUM_HUD="fps,requested-VRAM" LIBGL_DEBUG=verbose GALLIUM_PRINT_OPTIONS=al
https://bugs.freedesktop.org/show_bug.cgi?id=108848
Bug ID: 108848
Summary: 3d image broken in Dragon age: origins
Product: Mesa
Version: 18.2
Hardware: Other
OS: All
Status: NEW
Severity: normal
Hi,
On 21.11.2018 20.13, Dylan Baker wrote:
From: Arfrever Frehtes Taifersar Arahesis
Meson has two modules for finding python, the python3 module and the
python module. Python3 is older, and has some corner cases, python is
newer, has no known corner cases and can detect python2. Things have
We don't need to flush anything before these two commands as well.
This is because they have to be externally synchronized, so the
app should have called CmdPipelineBarrier() prior to that and the
driver should have flushed the caches.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_
We really need to refactor this...
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index f8e5ea40954..b41ae89deec 100644
--- a/src/amd/vulkan/radv_pass.c
+++ b/sr
Hello Tapani,
since you wrote the original code, could you have a look at this patch?
Many thanks,
Gert
Am Freitag, den 16.11.2018, 19:12 +0100 schrieb Gert Wollny:
> From: Gert Wollny
>
> When a shader program is de-serialized the gl_shader_program passed
> in
> may actually still hold memo
From the vulkan spec 33.3 "Extension Dependencies":
"Any device extension that has an instance extension dependency that is
not enabled by vkCreateInstance is considered to be unsupported, hence
it must not be returned by vkEnumerateDeviceExtensionProperties for any
VkPhysicalDevice child of the i
From the vulkan spec 3.2 "Instances":
"Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an
apiVersion of 0 is equivalent to providing an apiVersion of
VK_MAKE_VERSION(1,0,0)."
---
src/amd/vulkan/radv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Mathias Fröhlich
In st_atom_array, we only need to unmap the upload buffer that
was actually used.
Signed-off-by: Mathias Fröhlich
---
src/mesa/state_tracker/st_atom_array.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_atom_array.c
b/sr
From: Mathias Fröhlich
Use VAO binding information in feedback rendering. In theory
it should reduce the amount of buffer objects scheduled for rendering.
Feedback rendering is implemented in a crude way anyhow, so I do not
expect much gain here. But for the sake of code reuse we should
use the s
From: Mathias Fröhlich
Factor out vertex array setup routines from the array state atom.
The factored functions will be used in feedback rendering in the
next change.
Signed-off-by: Mathias Fröhlich
---
src/mesa/state_tracker/st_atom.h | 17 ++
src/mesa/state_tracker/st_atom_array.c
From: Mathias Fröhlich
The change removes the reference that is held on the entries of the
vbuffers[] array. The new code does not do that anymore as following
the code into draw_set_vertex_buffers() the draw context holds an
other reference as long as it is reset down the function again.
So it s
From: Mathias Fröhlich
Signed-off-by: Mathias Fröhlich
---
src/mesa/state_tracker/st_atom.h | 3 ---
src/mesa/state_tracker/st_atom_array.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom.h b/src/mesa/state_tracker/st_atom.h
index d36f0
From: Mathias Fröhlich
Hi,
The series unifies functions for array setup into gallium.
Instead of just walking all VAO attributes we can make use of
the enabled and required attribute arrays also for feedback
rendering.
Along that way cleanup duplicate references and unneeded
calls to the uploade
From: Mathias Fröhlich
In st_atom_array, we only need to care for unmapping the upload buffer
if we actually used it.
Signed-off-by: Mathias Fröhlich
---
src/mesa/state_tracker/st_atom_array.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_a
101 - 122 of 122 matches
Mail list logo
