Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri :
>
> This adds allows loop analysis to detect inductions varibales that
> are incremented in both branches of an if rather than in a main
> loop block. For example:
>
>loop {
> block block_1:
> /* preds: block_0 block_7 */
>
Reviewed-by: Iago Toral Quiroga
On Tue, 2018-11-27 at 15:34 -0800, Kenneth Graunke wrote:
> Vulkan and Gallium don't use Mesa's gl_program data structure, so
> they
> can't poke at 'prog'. But we can simply use the copy of the shader
> info
> stored with the NIR shader, which is guaranteed to
This adds the "Developer's Certificate of Origin 1.1" from the Linux
kernel. It indicates that by using Signed-off-by you are certifying
that your patch meets the DCO 1.1 guidelines.
It also changes Signed-off-by from being optional to being required.
Signed-off-by: Jordan Justen
Cc: Matt
Reviewed-by: Matt Turner
I'll commit it tomorrow.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/22/18 8:00 PM, Gert Wollny wrote:
Originally the driver reported GL_FRAMEBUFFER_UNSUPPORTED in all cases,
adding more specific error messages was not correct and broke many tests.
Mostly revert this and only report GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT
for MESA_FORMAT_R_SRGB8.
Fixes:
On 11/22/18 8:00 PM, Gert Wollny wrote:
The format is emulated by using ISL_FORMAT_L8_SRGB, therefore we need to
force swizzles for the GBA channels. However, doing this only based on the
data type GL_RED breaks other formats, therefore, test specifically for the
format.
Fixes:
The common truncf(x + 0.5) fails for the floating-point value just less
than 0.5 (nextafterf(0.5, 0.0)). nextafterf(0.5, 0.0) + 0.5, after
rounding is 1.0, thus truncf does not produce the desired value.
The solution is to add nextafterf(0.5, 0.0) instead of 0.5 before
truncating. This works for
On 2018-11-27 19:53:38, Matt Turner wrote:
> On Tue, Nov 27, 2018 at 7:26 PM Jordan Justen
> wrote:
> > On 2018-11-27 18:04:17, Matt Turner wrote:
> > > By all means, require it (with a git hook) if you like.
> >
> > I personally don't want to push for that right now.
> >
> > I guess I would
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965"
On Tue, Nov 27, 2018 at 7:45 PM Jordan Justen wrote:
>
> On 2018-11-27 19:20:09, Matt Turner wrote:
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > wrote:
> > >
> > > This documents a mechanism for using GitLab Merge Requests as an
> > > optional, secondary way to get code reviews for
On Tue, Nov 27, 2018 at 7:26 PM Jordan Justen wrote:
>
> On 2018-11-27 18:04:17, Matt Turner wrote:
> > On Tue, Nov 27, 2018 at 6:00 PM Jordan Justen
> > wrote:
> > >
> > > On 2018-11-27 17:17:15, Matt Turner wrote:
> > > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > > > wrote:
> > > >
On Tue, Nov 27, 2018 at 9:17 PM Ilia Mirkin wrote:
> On Tue, Nov 27, 2018 at 9:00 PM Marek Olšák wrote:
> >
> > From: Marek Olšák
> >
> > For format fallbacks like ETC and ASTC, switching between sRGB and linear
> > decoding is undefined, or at least is not bit-exact. Same as
> >
On 2018-11-27 19:20:09, Matt Turner wrote:
> On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> wrote:
> >
> > This documents a mechanism for using GitLab Merge Requests as an
> > optional, secondary way to get code reviews for patchsets.
> >
> > We still require all patches to be emailed.
> >
> >
Wouldn't it be better to just include the stdlib.h/stddef.h header
that defines NULL?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965"
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965"
https://bugs.freedesktop.org/show_bug.cgi?id=32211
--- Comment #16 from Timothy Arceri ---
(In reply to Danylo from comment #15)
> Created attachment 142567 [details] [review]
> Removing unnecessary continue
>
> Optimization in question.
Thanks! I've tried a few variations of this patch and
This will allow us to improve analysis to find more induction
variables.
---
src/compiler/nir/nir_loop_analyze.c | 34 ++---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/src/compiler/nir/nir_loop_analyze.c
b/src/compiler/nir/nir_loop_analyze.c
index
---
src/compiler/nir/nir_loop_analyze.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir/nir_loop_analyze.c
b/src/compiler/nir/nir_loop_analyze.c
index c804a66ac4..8903e15105 100644
--- a/src/compiler/nir/nir_loop_analyze.c
+++
This adds allows loop analysis to detect inductions varibales that
are incremented in both branches of an if rather than in a main
loop block. For example:
loop {
block block_1:
/* preds: block_0 block_7 */
vec1 32 ssa_8 = phi block_0: ssa_4, block_7: ssa_20
vec1 32
On 2018-11-27 18:04:17, Matt Turner wrote:
> On Tue, Nov 27, 2018 at 6:00 PM Jordan Justen
> wrote:
> >
> > On 2018-11-27 17:17:15, Matt Turner wrote:
> > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > > wrote:
> > > >
> > > > This adds the "Developer's Certificate of Origin 1.1" from the
From: Danylo Piliaiev
Removing the last continue can allow more loops to unroll. Also
inserting code into the if branch can allow the various if opts
to progress further.
The insertion of some loops into the if branch also reduces VGPR
use in some shaders.
vkpipeline-db results (VEGA):
Totals
On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen wrote:
>
> This documents a mechanism for using GitLab Merge Requests as an
> optional, secondary way to get code reviews for patchsets.
>
> We still require all patches to be emailed.
>
> Aside from the potential usage for code review comments, it
On Tue, Nov 27, 2018 at 9:00 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> For format fallbacks like ETC and ASTC, switching between sRGB and linear
> decoding is undefined, or at least is not bit-exact. Same as
> EXT_texture_sRGB_decode on GLES.
>
> There are no piglit or dEQP regresssions.
Rb for this patch
On November 27, 2018 18:39:25 "Ian Romanick" wrote:
From: Ian Romanick
nir_sweep already marks all metadata invalid, so it is safe to release
the memory here too.
mean soft fp64 using uint64: 1,342,759,331 => 1,010,670,475
gfxbench5 aztec ruins high 11:63,555,571 =>
On Tue, Nov 27, 2018 at 6:00 PM Jordan Justen wrote:
>
> On 2018-11-27 17:17:15, Matt Turner wrote:
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > wrote:
> > >
> > > This adds the "Developer's Certificate of Origin 1.1" from the Linux
> > > kernel. It indicates that by using
From: Marek Olšák
There no spec changes.
---
docs/relnotes/19.0.0.html| 1 +
src/mapi/glapi/gen/es_EXT.xml| 13 +
src/mesa/main/extensions_table.h | 1 +
3 files changed, 15 insertions(+)
diff --git a/docs/relnotes/19.0.0.html b/docs/relnotes/19.0.0.html
index
From: Marek Olšák
For format fallbacks like ETC and ASTC, switching between sRGB and linear
decoding is undefined, or at least is not bit-exact. Same as
EXT_texture_sRGB_decode on GLES.
There are no piglit or dEQP regresssions.
---
docs/features.txt | 2 +-
On 2018-11-27 17:17:15, Matt Turner wrote:
> On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> wrote:
> >
> > This adds the "Developer's Certificate of Origin 1.1" from the Linux
> > kernel. It indicates that by using Signed-off-by you are certifying
> > that your patch meets the DCO 1.1
On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen wrote:
>
> This adds the "Developer's Certificate of Origin 1.1" from the Linux
> kernel. It indicates that by using Signed-off-by you are certifying
> that your patch meets the DCO 1.1 guidelines.
Do we gain anything if it's optional?
This documents a mechanism for using GitLab Merge Requests as an
optional, secondary way to get code reviews for patchsets.
We still require all patches to be emailed.
Aside from the potential usage for code review comments, it might also
help reviewers to find unmerged patchsets which need
This adds the "Developer's Certificate of Origin 1.1" from the Linux
kernel. It indicates that by using Signed-off-by you are certifying
that your patch meets the DCO 1.1 guidelines.
Signed-off-by: Jordan Justen
Cc: Matt Turner
---
docs/submittingpatches.html | 53
From: Ian Romanick
Replace the old array in each value with a hash table in each value.
Changes in peak memory usage according to Valgrind massif:
mean soft fp64 using uint64: 5,499,875,082 => 1,343,991,403
gfxbench5 aztec ruins high 11:63,619,971 =>63,619,971
deus ex mankind divided
From: Ian Romanick
Now everything with type 'struct slab_child_pool *' is name pool, and
everything with type 'struct slab_mempool *' is named mempool.
Signed-off-by: Ian Romanick
---
src/util/slab.c | 20 ++--
src/util/slab.h | 8
2 files changed, 14 insertions(+),
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/util/hash_table.c | 39 ++-
src/util/hash_table.h | 8
2 files changed, 34 insertions(+), 13 deletions(-)
diff --git a/src/util/hash_table.c b/src/util/hash_table.c
index
From: Ian Romanick
Found using pahole.
Changes in peak memory usage according to Valgrind massif:
mean soft fp64 using uint64: 1,343,991,403 => 1,342,759,331
gfxbench5 aztec ruins high 11:63,619,971 =>63,555,571
deus ex mankind divided 148: 62,887,728 =>62,845,304
deus ex
From: Ian Romanick
Signed-off-by: Ian Romanick
Reviewed-by: Jason Ekstrand
---
src/compiler/nir/nir_phi_builder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir/nir_phi_builder.c
b/src/compiler/nir/nir_phi_builder.c
index cc5ce81d120..add3efd2dfc
After incorporating several of Jason's suggestions, I have decided to
just resend this series. The end result is the same for the worst case.
The other cases are 1% - 4% less peak memory usage. The new series is
also about 80 lines less code (git diff phi-builder-v1..phi-builder-v2
is 72
From: Ian Romanick
nir_sweep already marks all metadata invalid, so it is safe to release
the memory here too.
mean soft fp64 using uint64: 1,342,759,331 => 1,010,670,475
gfxbench5 aztec ruins high 11:63,555,571 =>61,889,811
deus ex mankind divided 148: 62,845,304 =>
Vulkan and Gallium don't use Mesa's gl_program data structure, so they
can't poke at 'prog'. But we can simply use the copy of the shader info
stored with the NIR shader, which is guaranteed to exist.
Reviewed-by: Jason Ekstrand
---
src/intel/compiler/brw_vec4_gs_visitor.cpp | 2 +-
1 file
Yes, it could be added back.
Marek
On Tue, Nov 27, 2018 at 3:15 AM Tom Butler wrote:
> Hello,
>
> I realise this was removed for a reason (
> https://lists.freedesktop.org/archives/mesa-dev/2014-September/067864.html
> ) but there are cases where it is useful. In older games that do not
>
Reviewed-by: Marek Olšák
Marek
On Tue, Nov 27, 2018 at 2:26 PM Eric Anholt wrote:
> Fixes: 0d17b685b1ff ("gallium/u_tests: add a compute shader test that
> clears an image")
> ---
> src/gallium/auxiliary/util/u_tests.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
This patch has been:
Reviewed-by: Robert Foss
On 2018-11-27 20:50, Gert Wollny wrote:
From: Gert Wollny
vtest doesn't implement the according API and would segfault:
Program received signal SIGSEGV, Segmentation fault.
#0 0x in ?? ()
#1 in virgl_fence_server_sync
This patch has been:
Reviewed-by: Robert Foss
On 2018-11-27 20:50, Gert Wollny wrote:
From: Gert Wollny
Avoids:
Conditional jump or move depends on uninitialised value(s)
at 0x9E2B39F: virgl_vtest_winsys_resource_cache_create
(virgl_vtest_winsys.c:379)
by 0x9E2725F:
Eric Engestrom writes:
> Fixes: da997ebec92942193955 "vulkan: Add KHR_display extension using DRM
> [v10]"
> Cc: Keith Packard
> Signed-off-by: Eric Engestrom
Reviewed-by: Keith Packard
I checked to ensure that this is sufficient to clean all allocated
objects:
* Creating a display
On Wed, 28 Nov 2018 at 05:51, Gert Wollny wrote:
>
> From: Gert Wollny
>
> vtest doesn't implement the according API and would segfault:
>
> Program received signal SIGSEGV, Segmentation fault.
> #0 0x in ?? ()
> #1 in virgl_fence_server_sync at
>
From: Gert Wollny
vtest doesn't implement the according API and would segfault:
Program received signal SIGSEGV, Segmentation fault.
#0 0x in ?? ()
#1 in virgl_fence_server_sync at
src/gallium/drivers/virgl/virgl_context.c:1049
#2 in st_server_wait_sync at
From: Gert Wollny
Avoids:
Conditional jump or move depends on uninitialised value(s)
at 0x9E2B39F: virgl_vtest_winsys_resource_cache_create
(virgl_vtest_winsys.c:379)
by 0x9E2725F: virgl_buffer_create (virgl_buffer.c:169)
by 0x9E246D5: virgl_resource_create (virgl_resource.c:60)
by
On Tue, Nov 27, 2018 at 12:55 PM Ian Romanick wrote:
> On 11/22/2018 10:46 AM, Jason Ekstrand wrote:
> > The vec4 path has only been compile-tested as there's no easy way to
> > generate a vec4 shader with an unordered equality.
> > ---
> > src/intel/compiler/brw_compiler.c | 3 +++
> >
Fixes: 0d17b685b1ff ("gallium/u_tests: add a compute shader test that clears an
image")
---
src/gallium/auxiliary/util/u_tests.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_tests.c
b/src/gallium/auxiliary/util/u_tests.c
index 7c4e98402bef..365d4fa8f171 100644
On 27.11.2018 19.05, Matt Turner wrote:
> On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen wrote:
>>
>> On 17.11.2018 6.04, Dylan Baker wrote:
>>> Quoting Dylan Baker (2018-09-17 09:44:07)
I feel like for !windows meson is in good enough shape at this point that
we
can start having
On 11/22/2018 10:46 AM, Jason Ekstrand wrote:
> The vec4 path has only been compile-tested as there's no easy way to
> generate a vec4 shader with an unordered equality.
> ---
> src/intel/compiler/brw_compiler.c | 3 +++
> src/intel/compiler/brw_fs_nir.cpp | 20 +---
>
On 11/26/2018 01:05 PM, Eric Anholt wrote:
> Jason Ekstrand writes:
>
>> This way, it's explicit in the opcode name that it's an unordered
>> comparison.
>> ---
>> src/amd/common/ac_nir_to_llvm.c | 2 +-
>> src/compiler/glsl/glsl_to_nir.cpp | 4 +-
>>
Seems obviously correct.
Reviewed-by: Ian Romanick
On 11/27/2018 01:24 AM, Iago Toral Quiroga wrote:
> This wasn't handling 64-bit cases properly. Found by inspection.
> ---
> src/intel/compiler/brw_fs_sel_peephole.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
On 11/26/2018 09:31 PM, Timothy Arceri wrote:
> After trying multiple times to merge if-statements with phis
> between them I've come to the conclusion that it cannot be done
> without regressions. The problem is for some shaders we end up
> with a whole bunch of phis for the merged ifs resulting
Hi,
On 27.11.2018 19.05, Matt Turner wrote:
On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen wrote:
On 17.11.2018 6.04, Dylan Baker wrote:
Quoting Dylan Baker (2018-09-17 09:44:07)
I feel like for !windows meson is in good enough shape at this point that we
can start having the discussion
On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen wrote:
>
> On 17.11.2018 6.04, Dylan Baker wrote:
> > Quoting Dylan Baker (2018-09-17 09:44:07)
> >> I feel like for !windows meson is in good enough shape at this point that
> >> we
> >> can start having the discussion about deleting the autotools
Fixes: da997ebec92942193955 "vulkan: Add KHR_display extension using DRM [v10]"
Cc: Keith Packard
Signed-off-by: Eric Engestrom
---
src/vulkan/wsi/wsi_common_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_display.c
On Tuesday, 2018-11-27 11:39:42 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As we fail to open the node, we leak the node/device name.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/platform_wayland.c | 2 ++
>
From: Emil Velikov
As we fail to open the node, we leak the node/device name.
Cc: mesa-sta...@lists.freedesktop.org
Cc: Eric Engestrom
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Emil Velikov
Currently as the function fails, we pass uninitialized data to the
authentication function. Stop doing that and print an warning when
the function fails.
v2: Plug memory leak in error path (Eric)
Cc: mesa-sta...@lists.freedesktop.org
Cc: Tapani Pälli (v1)
Cc: Eric Engestrom
On 27.11.2018 12.20, Erik Faye-Lund wrote:
> On Tue, 2018-11-27 at 11:13 +0200, Timo Aaltonen wrote:
>> On 17.11.2018 6.04, Dylan Baker wrote:
>>> Quoting Dylan Baker (2018-09-17 09:44:07)
I feel like for !windows meson is in good enough shape at this
point that we
can start having
On Mon, Nov 26, 2018 at 01:13:16PM -0800, Eric Anholt wrote:
> The compiler doesn't know that ny != 0, so x might be uninitialized for
> the printf at the end.
Reviewed-by: Elie Tournier
> ---
> src/gallium/tests/trivial/compute.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Since we don't know the exact format at creation time, some initialization
is done only when bound with memory in vkBindImageMemory.
v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if
image has external format
v3: refactor prepare_ahw_image, support vkBindImageMemory2,
This makes it cleaner to introduce more cases where we import memory
from different types of external memory buffers.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_device.c | 64 +++
1 file changed, 34 insertions(+), 30 deletions(-)
diff --git
If external format is used, we store the external format identifier in
conversion to be used later when creating VkImageView.
v2: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 13 +
1 file changed, 13 insertions(+)
diff --git
v2: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 31
src/intel/vulkan/anv_android.h | 2 ++
src/intel/vulkan/anv_android_stubs.c | 7 +++
3 files changed, 40 insertions(+)
diff --git
Use the anv_format address in formats table as implementation-defined
external format identifier for now. When adding YUV format support this
might need to change.
v2: code cleanup (Jason)
v3: set anv_format address as identifier
v4: setup suggestedYcbcrModel and suggested[X|Y]ChromaOffset
as
v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason)
v3: add HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL, we make it define
for now to avoid direct dependency to minigbm headers
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/vk_format_info.h | 50 +++
1 file changed, 50
If a conversion struct was passed, then initialize view using
format from the conversion structure.
v2: use vk_format directly from the anv_format struct
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 4
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 6e7807579df..f27456fa41d 100644
--- a/src/intel/vulkan/anv_formats.c
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 22 +++---
src/intel/vulkan/anv_private.h | 5 +
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
v3: properly handle usage bits when creating from image
v4: refactor, code cleanup (Jason)
v5: rebase to b43f955037c changes,
initialize bo flags as ANV_BO_EXTERNAL (Lionel)
Signed-off-by: Tapani Pälli
---
v2: have separate memory properties for android, set usage
flags for buffers correctly
v3: code cleanup (Jason)
+ limit maxArrayLayers to 1 for AHardwareBuffer based images
v4: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 41
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 7c81228f705..ed9b2edef32 100644
--- a/src/intel/vulkan/anv_extensions.py
+++
Hi;
Series was rebased and fixes applied from review, also some changes
applied to support HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL. With these
changes android.graphics.cts.MediaVulkanGpuTest starts to pass, now
all tests utilizing AHardwareBuffer pass (CTS + SkQP) \o/
tree:
This fulfills a requirement for clients that want to utilize same
code path for images with external formats (VK_FORMAT_UNDEFINED) and
"regular" RGBA images where format is known. This is similar to how
OES_EGL_image_external works.
To support this, we allow color conversion samplers for non-YUV
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 78 ++
src/intel/vulkan/anv_private.h | 5 +++
2 files changed, 46 insertions(+), 37 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index
This will make it possible for next patch to rip
anv_image_create_info out from make_surface function.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 1 +
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c
On Tue, 2018-11-27 at 11:13 +0200, Timo Aaltonen wrote:
> On 17.11.2018 6.04, Dylan Baker wrote:
> > Quoting Dylan Baker (2018-09-17 09:44:07)
> > > I feel like for !windows meson is in good enough shape at this
> > > point that we
> > > can start having the discussion about deleting the autotools
Am 27.11.18 um 00:02 schrieb Marek Olšák:
From: Marek Olšák
---
src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
index
Seems already unused at the commit that introduced it ..
Reviewed-by: Tapani Pälli
On 11/27/18 10:10 AM, Matt Turner wrote:
---
src/compiler/glsl/glsl_to_nir.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
Reviewed-by: Tapani Pälli
On 11/27/18 10:08 AM, Matt Turner wrote:
We normally call with stderr which is unbuffered, so this won't affect
that, but it does let me call nir_print_shader(nir, fopen("log", "w+"))
from gdb and actually get the whole shader in my file.
---
This wasn't handling 64-bit cases properly. Found by inspection.
---
src/intel/compiler/brw_fs_sel_peephole.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/compiler/brw_fs_sel_peephole.cpp
b/src/intel/compiler/brw_fs_sel_peephole.cpp
index
Tested-by: Alex Smith
Confirmed it fixes both the testcase and the in-game bug it was causing.
Thanks!
On Tue, 27 Nov 2018 at 08:34, Samuel Pitoiset
wrote:
> cc stable?
>
> Reviewed-by: Samuel Pitoiset
>
> On 11/24/18 11:31 PM, Bas Nieuwenhuizen wrote:
> > Mirrors AMDVLK. Looks like if we go
https://bugs.freedesktop.org/show_bug.cgi?id=108245
Bas Nieuwenhuizen changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On Tue, 2018-11-27 at 07:11 +0100, Mathias Fröhlich wrote:
> Hi Erik,
>
> > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote:
> > > > I know this is *very* late notice, but this commit broke Super
> > > > Tux
> > > > Kart
> > > > on VirGL. Both the player-models as as well as the
On 17.11.2018 6.04, Dylan Baker wrote:
> Quoting Dylan Baker (2018-09-17 09:44:07)
>> I feel like for !windows meson is in good enough shape at this point that we
>> can start having the discussion about deleting the autotools build. So, is
>> there
>> anything left that autotools can do that
https://bugs.freedesktop.org/show_bug.cgi?id=106958
--- Comment #14 from Samuel Pitoiset ---
The trace crashes for me as well. Can you record a renderdoc capture instead? I
don't have that game, so can't do anything.
--
You are receiving this mail because:
You are the QA Contact for the bug.
cc stable?
Reviewed-by: Samuel Pitoiset
On 11/24/18 11:31 PM, Bas Nieuwenhuizen wrote:
Mirrors AMDVLK. Looks like if we go over the alignment of height
we actually start to change the addressing. Seems like the extra
miplevels actually work with this.
Bugzilla:
Hello,
I realise this was removed for a reason (
https://lists.freedesktop.org/archives/mesa-dev/2014-September/067864.html
) but there are cases where it is useful. In older games that do not
support native FSAA being able to force it in the driver is the only way
to enable it.
A quick
---
src/compiler/glsl/glsl_to_nir.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
index dc6ffa3599d..61b544fd6d3 100644
--- a/src/compiler/glsl/glsl_to_nir.cpp
+++ b/src/compiler/glsl/glsl_to_nir.cpp
@@ -96,8 +96,6
---
src/intel/compiler/brw_fs.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index e030f7215ce..c3a09d31938 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -6036,6 +6036,11 @@
We normally call with stderr which is unbuffered, so this won't affect
that, but it does let me call nir_print_shader(nir, fopen("log", "w+"))
from gdb and actually get the whole shader in my file.
---
src/compiler/nir/nir_print.c | 1 +
1 file changed, 1 insertion(+)
diff --git
94 matches
Mail list logo
