Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

I don't plan to do anything else if this patch is enough to fix certain 32-bit games. Marek On Fri, Dec 14, 2018 at 6:10 PM Axel Davy wrote: > Hi Marek, > > That seems a good idea. > Several 32bits games have virtual address space issues as well with both > Nine and Wine (but Nine seems a bit

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On Fri, Dec 14, 2018 at 9:16 PM Timothy Arceri wrote: > On 15/12/18 7:32 am, Marek Olšák wrote: > > For patches 1-3: > > > > Reviewed-by: Marek Olšák marek.ol...@amd.com>> > > > > Thanks! > > > I'm not so knowledgeable to be able to comment on patch 4. > > > > Does it also merge varyings such

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: clean up src2 in ConstantFolding

On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > no changes in shader-db > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp >

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 1:16 pm, Timothy Arceri wrote: On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák > Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák mailto:marek.ol...@amd.com>> Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs

[Mesa-dev] [PATCH] st/mesa: remove sampler associated with buffer texture in pbo logic

A long time ago, when this was first implemented, not having a sampler bound would cause problems on Fermi. I didn't work out the reasons, but the solution was simple -- just put the samplers back in. Since then, regular texturing paths appear to have lost their associated samplers which required

[Mesa-dev] SPIR-V: Use NIR deref instructions for UBO/SSBO access

New MR: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/17 This MR begins the process of being able to optimize external memory access by first moving us over to using deref instructions for UBO/SSBO access. Many of the patches are cleanups or fairly small refactors of NIR or SPIR-V.

[Mesa-dev] [PATCH] i965: Don't override subslice count to 4 on Gen11.

Gen9-10 have fewer than 4 subslices per slice, so they need this to be rounded up. Gen11 isn't documented as needing this hack, and it can also have more than 4 subslices, so the hack actually can break things. --- src/mesa/drivers/dri/i965/brw_program.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] last call for autotools

Quoting Dave Airlie (2018-12-14 12:27:35) > On Fri, 14 Dec 2018 at 16:19, Ilia Mirkin wrote: > > > > I have to say that the user experience for autotools is WAY better > > than for meson. As a concrete example, I had a meson build. Then I > > updated meson (0.48.1 to 0.48.2). Now ninja -C foo

[Mesa-dev] [PATCH 3/3] nv50/ir: convert slct with boolean result to set

From: Karol Herbst helps mainly feral ported games changes in shader-db: total instructions in shared programs : 7565661 -> 7545812 (-0.26%) total gprs used in shared programs: 797213 -> 797088 (-0.02%) total shared used in shared programs : 639636 -> 639636 (0.00%) total local

[Mesa-dev] [PATCH 2/3] nv50/ir: optimize slct(b, c, set(a, 0)) to slct(b, c, a)

From: Karol Herbst helps mainly feral ported games shader-db changes: total instructions in shared programs : 7614782 -> 7565661 (-0.65%) total gprs used in shared programs: 798045 -> 797213 (-0.10%) total shared used in shared programs : 639636 -> 639636 (0.00%) total local

[Mesa-dev] [PATCH 1/3] nv50/ir: clean up src2 in ConstantFolding

no changes in shader-db Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index

Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

Hi Marek, That seems a good idea. Several 32bits games have virtual address space issues as well with both Nine and Wine (but Nine seems a bit more affected because more libs are loaded). Maybe the patch could go a little bit further by doing the same for buffers the first time they

Re: [Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

On Fri, 14 Dec 2018 at 14:33, Erik Faye-Lund wrote: > > On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > > From: Emil Velikov > > > > The helper will also be used by the new Khronos gl.xml aware > > generator. > > > > v2: Move existing one, instead of duplicating it. > > > >

[Mesa-dev] [PATCH v3 17/24] meson: wire the new generator for es1 and es2

From: Emil Velikov v2: use ${foo})_py naming (Dylan) v3: use symbolic name for genCommon.py Signed-off-by: Emil Velikov --- src/mapi/es1api/meson.build| 6 +++--- src/mapi/es2api/meson.build| 6 +++--- src/mapi/glapi/gen/meson.build | 7 +++ src/mapi/meson.build | 1 + 4

[Mesa-dev] [PATCH v3 07/24] mapi: move genCommon.py to src/mapi/new

From: Emil Velikov The helper will also be used by the new Khronos gl.xml aware generator. v2: Move existing one, instead of duplicating it. v3: Correct genCommon.py references in meson [Erik] Suggested-by: Kyle Brenneman Signed-off-by: Emil Velikov --- src/egl/Makefile.am

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

https://bugs.freedesktop.org/show_bug.cgi?id=108946 Andrew Keller changed: What|Removed |Added CC||andrew@thekellers.email -- You are

[Mesa-dev] [PATCH 4/6] radeonsi: use u_decomposed_prims_for_vertices instead of u_prims_for_vertices

From: Marek Olšák It seems to be the same, but this doesn't use integer division with a variable divisor. --- src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c

[Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

From: Marek Olšák Team Fortress 2 32-bit version runs out of the CPU address space. --- src/gallium/drivers/radeonsi/si_texture.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_texture.c b/src/gallium/drivers/radeonsi/si_texture.c index

[Mesa-dev] [PATCH 2/6] radeonsi: call si_fix_resource_usage for the GS copy shader as well

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index ee0c668431c..68afff449fd 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++

[Mesa-dev] [PATCH 5/6] radeonsi: remove unused variables in si_insert_input_ptr

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 68afff449fd..250e0cc5db4 100644 ---

[Mesa-dev] [PATCH 1/6] radeonsi: don't emit redundant PKT3_NUM_INSTANCES packets

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 3 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 9 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h index

[Mesa-dev] [PATCH 3/6] radeonsi: make si_cp_wait_mem more configurable

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_fence.c | 6 ++ src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_query.c | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 3

[Mesa-dev] [PATCH v2] nvc0/ir: replace cvt instructions with add to improve shader performance

gives me an performance boost of 0.2% in pixmark_piano on my gk106, gm204 and gp107. changes in shader-db: total instructions in shared programs : 7614782 -> 7614782 (0.00%) total cvt instructions in shared programs : 139343 -> 95856 (-31.21%) total gprs used in shared programs:

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

The way I see it, pipe_surface is a render target view for pipe_framebuffer_state. The fact that other functions also accept pipe_surface is a historic artifact. resource_copy_region used to accept 2 pipe_surfaces before it was changed to 2 pipe_resources + parameters. Somebody might decide to

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

I don't mind renaming it to invalidate_subsurface() if you prefer that, but I really prefer that it takes a surface rather than a resource... pipe_resource is the wrong level to do this. Even though surfaces are transient, tracking the invalidate state in the surface works out much easier in the

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

Can you please call it invalidate_subresource and inline relevant pipe_surface variables inside the parameters? Thanks, Marek On Wed, Dec 12, 2018 at 10:48 AM Rob Clark wrote: > A new API to implement glInvalidateFramebuffer() and friends. It is > similar to invalidate_resource() but can be

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

For patches 1-3: Reviewed-by: Marek Olšák I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y,z,undef) and (x,y,undef,undef) where the vertex shader is a SSO. Marek On Mon,

Re: [Mesa-dev] last call for autotools

On Fri, 14 Dec 2018 at 16:19, Ilia Mirkin wrote: > > I have to say that the user experience for autotools is WAY better > than for meson. As a concrete example, I had a meson build. Then I > updated meson (0.48.1 to 0.48.2). Now ninja -C foo doesn't work. meson > --reconfigure (which presumably

Re: [Mesa-dev] [PATCH] st/nir: Use nir_src_as_uint for tokens

Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:20 PM Jason Ekstrand wrote: > --- > src/mesa/state_tracker/st_nir_lower_builtin.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] pci_ids: add new vega10 pci ids

Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:01 PM Alex Deucher wrote: > Ping? > > Alex > On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > > > Signed-off-by: Alex Deucher > > Cc: mesa-sta...@lists.freedesktop.org > > --- > > include/pci_ids/radeonsi_pci_ids.h | 8

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On 14/12/2018 15:15, Emil Velikov wrote: On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as functions prototyped by it are used in

[Mesa-dev] [PATCH 2/2] appveyor: Add a Cygwin build script

Signed-off-by: Jon Turney --- appveyor.yml| 19 +- scripts/appveyor_cygwin.bat | 40 + 2 files changed, 54 insertions(+), 5 deletions(-) create mode 100644 scripts/appveyor_cygwin.bat diff --git a/appveyor.yml b/appveyor.yml

[Mesa-dev] [PATCH 1/2] appveyor: put build steps in a script, rather than inline in appveyor.yml

Signed-off-by: Jon Turney --- appveyor.yml | 32 +++- scripts/appveyor_msvc.bat | 38 ++ 2 files changed, 41 insertions(+), 29 deletions(-) create mode 100644 scripts/appveyor_msvc.bat diff --git a/appveyor.yml

[Mesa-dev] [PATCH 0/2] appveyor: add Cygwin

This is a refresh of my patch set from [1], which I posted, and then kind of forgot about. [1] https://lists.freedesktop.org/archives/mesa-dev/2018-February/185066.html Jon Turney (2): appveyor: put build steps in a script, rather than inline in appveyor.yml appveyor: Add a Cygwin build

Re: [Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

Quoting Christian Gmeiner (2018-12-13 12:07:23) > Signed-off-by: Christian Gmeiner > --- > meson.build | 2 +- > meson_options.txt | 2 +- > src/gallium/drivers/etnaviv/meson.build | 3 ++- > 3 files changed, 4 insertions(+), 3 deletions(-) > >

[Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116 Signed-off-by: Rhys Perry --- Unfortunately I was not able to test this patch on a Polaris due to hardware issues. It fixed the deqp-vk tests mentioned in the

Re: [Mesa-dev] last call for autotools

On Fri, Dec 14, 2018 at 11:25 AM Andre Heider wrote: > On 14/12/2018 17:53, Dylan Baker wrote: > > Quoting Gert Wollny (2018-12-14 03:44:32) > >> Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > >> (2) It would be nice if Meson would distribute some default cross build > >> files,

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

Quoting Emil Velikov (2018-12-13 08:15:57) > From: Emil Velikov > > Reasonably often people will want to build the loader w/o any drivers. > Be that debugging an issue in the former, distribution bundle or other. > > Currently there is an artificial restriction preventing people to build > a

Re: [Mesa-dev] [PATCH 01/18] meson: don't require glx/egl/gbm with gallium drivers

Quoting Emil Velikov (2018-12-13 08:05:50) > From: Emil Velikov > > The gallium drivers do not require a DRI loader. Drop the artificial > and unnecessary restriction. > > Fixes: af9d276134d ("meson: build libmesa_gallium") > Signed-off-by: Emil Velikov > --- > There are a few use cases: > >

Re: [Mesa-dev] [PATCH 18/18] travis: meson: port gallium build combinations over

Quoting Emil Velikov (2018-12-13 08:06:07) > From: Emil Velikov > > This commit adds a number of build combos: > > - Gallium Drivers {SWR, RadeonSI, Others) > Each one has different LLVM requirements. Building SWR alone is twice > as slow as all other drivers combined. > > - Gallium ST

Re: [Mesa-dev] [PATCH 14/18] travis: meson: use FOO_DRIVERS directly

Quoting Emil Velikov (2018-12-13 08:06:03) > From: Emil Velikov > > It makes for a shorter MESON_OPTIONS and cleaner handling. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/.travis.yml b/.travis.yml

Re: [Mesa-dev] [PATCH 11/18] travis: meson: use native files to override llvm-config

Quoting Emil Velikov (2018-12-13 08:06:00) > From: Dylan Baker > > This is the supported way to do this, and should be more robust and > reliable. > > v2: [Emil] > - enable backslash escapes > - don't hardcode the path > - pass the argument directly to meson > > Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH 10/18] travis: printout llvm-config --version

Quoting Emil Velikov (2018-12-13 08:05:59) > From: Emil Velikov > > Provides quick and easy feedback. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 6fefe06617a..c69f322d7b3 100644 > ---

Re: [Mesa-dev] [PATCH 08/18] travis: flip to distro xenial, sudo true

Quoting Emil Velikov (2018-12-13 08:05:57) > From: Emil Velikov > > The latter is the default these days and Travis will be removing sudo > soonish. > > Flipping to xenial, allows us to remove a bunch of hacks we have. Plus > it prevents us from adding new ones, to workaround what seems like a

Re: [Mesa-dev] [PATCH 09/18] travis: meson: print the configured state

Quoting Emil Velikov (2018-12-13 08:05:58) > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > .travis.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.travis.yml b/.travis.yml > index deec40cb135..6fefe06617a 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -670,5

Re: [Mesa-dev] [PATCH 07/18] configure: add CXX11_CXXFLAGS to LLVM_CXXFLAGS

Quoting Emil Velikov (2018-12-13 08:05:56) > From: Emil Velikov > > Seemingly with LLVM7 and GCC 5.0, the former won't properly advertise > -std=c++11 and the latter will choke. > > dd this temporary workaround, otherwise we'll get errors like: > > In file included from

Re: [Mesa-dev] [PATCH 06/18] glx/test: meson: assorted include fixes

Quoting Emil Velikov (2018-12-13 08:05:55) > From: Emil Velikov > > Swap '..' with the symbolic inc_glx and add glproto as dependency. That > will pull the correct include, effectively fixing the tests on macOS. > > Fixes: a47c525f328 ("meson: build glx") > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 05/18] glx: meson: wire up the dispatch-index-check test

Quoting Emil Velikov (2018-12-13 08:05:54) > From: Emil Velikov > > Accidentally dropped with earlier commit.! > > Fixes: 4ccb9816737 ("meson: Use consistent style for tests") > Signed-off-by: Emil Velikov > --- > src/glx/tests/meson.build | 5 + > 1 file changed, 5 insertions(+) > >

Re: [Mesa-dev] Let's talk about -DDEBUG

Quoting Tapani Pälli (2018-12-14 05:03:06) > > > On 12/14/18 12:53 PM, Erik Faye-Lund wrote: > > On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: > >> Dylan Baker writes: > >> > >>> [ Unknown signature status ] > >>> In the autotools discussion I've come to realize that we also need > >>>

Re: [Mesa-dev] last call for autotools

Quoting Andre Heider (2018-12-14 09:24:56) > On 14/12/2018 17:53, Dylan Baker wrote: > > Quoting Gert Wollny (2018-12-14 03:44:32) > >> Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > >> (2) It would be nice if Meson would distribute some default cross build > >> files, currently

Re: [Mesa-dev] last call for autotools

On 14/12/2018 17:53, Dylan Baker wrote: Quoting Gert Wollny (2018-12-14 03:44:32) Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: (2) It would be nice if Meson would distribute some default cross build files, currently everybody has to roll its own, and I guess in the end they all

[Mesa-dev] [PATCH] st/nir: Use nir_src_as_uint for tokens

--- src/mesa/state_tracker/st_nir_lower_builtin.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c b/src/mesa/state_tracker/st_nir_lower_builtin.c index 195dc40b2ef..ab74d3183dc 100644 ---

Re: [Mesa-dev] [PATCH 04/18] glx: meson: drop includes from a link-only library

Quoting Emil Velikov (2018-12-13 08:05:53) > From: Emil Velikov > > When producing the final libGL.so/libGLX_mesa.so we only link the local > static helper lib (libglx). Thus there's no reason for the includes. > > Fixes: a47c525f328 ("meson: build glx") > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

Quoting Emil Velikov (2018-12-13 08:05:52) > From: Emil Velikov > > The library is the dri capable one, push the check src/meson.build, > instead of the current partial handling in src/glx/meson.build. > > Fixes: a47c525f328 ("meson: build glx") This is just a refactor, the Fixes: is

Re: [Mesa-dev] [PATCH 02/18] pipe-loader: meson: reference correct library

Quoting Emil Velikov (2018-12-13 08:05:51) > From: Emil Velikov > > The library is called libgalliumvl_stub - note singular. > > Fixes: 42ea0631f10 ("meson: build clover") > Signed-off-by: Emil Velikov > --- > src/gallium/targets/pipe-loader/meson.build | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/2] pci_ids: add new vega10 pci ids

Ping? Alex On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/pci_ids/radeonsi_pci_ids.h >

Re: [Mesa-dev] [PATCH v6 0/8] Add and enable extension EXT_sRGB_write_control

Hi all, Since I like MRs I've pushed the new version to https://gitlab.freedesktop.org/mesa/mesa/merge_requests/14 There is actually only one one-line change with respect to the series as posted here, so using the MR also saves everyones band-width. So far it was tested on r600 with the GLES

Re: [Mesa-dev] last call for autotools

Quoting Gert Wollny (2018-12-14 03:44:32) > Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > > Meson 0.49.0 has been out for a couple of days now, and I'd like to > > make the final call for autotools. My patch is so massive that it's a > > huge pain to send to the list, the latest

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #1 from Dylan Baker --- In meson we iterate through all of the libdrm versions required for each enabled target, then select the hightest version and check only for that version of libdrm and libdrm_*. We do this specifically to

Re: [Mesa-dev] last call for autotools

On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and

Re: [Mesa-dev] last call for autotools

On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and

Re: [Mesa-dev] last call for autotools

On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > I second that, I voiced my concerns in a former thread, especially that > so far this upcoming change has not been officially announced in the > release notes or on mesa-user, and that I don't understand why it is so > urgent to drop autotools

[Mesa-dev] [PATCH] clover: Fix include of CodeGenOptions.h, upstream moved it in r348827

Signed-off-by: Kai Wasserbäch --- src/gallium/state_trackers/clover/llvm/compat.hpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp b/src/gallium/state_trackers/clover/llvm/compat.hpp index 975012cbda..9c5b9d8917 100644 ---

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

https://bugs.freedesktop.org/show_bug.cgi?id=109062 Emil Velikov changed: What|Removed |Added CC||baker.dyla...@gmail.com,

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

https://bugs.freedesktop.org/show_bug.cgi?id=109062 Bug ID: 109062 Summary: meson incorrectly handles/reports libdrm_$foo Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 109039] [CLOVER][CLANG-SVN] build failure CodeGenOptions.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=109039 network...@rkmail.ru changed: What|Removed |Added CC||network...@rkmail.ru -- You are

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: > > Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical > (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) > > Include again, as functions prototyped by it are used in > the GLX_USE_WINDOWSGL path. > > Make

[Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as functions prototyped by it are used in the GLX_USE_WINDOWSGL path. Make the include guard around the __glxGetMscRate() definition

Re: [Mesa-dev] [PATCH v2 17/24] meson: wire the new generator for es1 and es2

For 16 and 17: Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > v2: use ${foo})_py naming (Dylan) > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > src/mapi/es1api/meson.build| 6 +++--- >

Re: [Mesa-dev] [PATCH v2 14/24] mapi/new: fixup the GLDEBUGPROCKHR typedef to the non KHR one

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > This way we can reuse the latter, which is already present in the > headers that we use. Thus we can drop the manual typedef we generate. > > We might want to merge this back in GLVND.

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > There is no need for the noop functions, the public_stubs and > public_entries table or table size defines. Remove those. > > Pretty much all of this is applicable to GLVND, although it > requires preparatory

Re: [Mesa-dev] [PATCH v2 11/24] mapi/new: reinstate _NO_HIDDEN suffixes in the new generator

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Strictly speaking we can rework the rest of the code so we do not > need > those. That said, this will require a series on it's own so let's > carry > this local quirk for now. > >

Re: [Mesa-dev] [PATCH v2 10/24] mapi/new: use the static_data offsets in the new generator

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise the incorrect ones will be used, effectively breaking the > ABI. > > Note: some entries in static_data.py list a suffixed API, while (for > ES* > at least) we expect the one

Re: [Mesa-dev] [PATCH v2 09/24] mapi/new: sort by slot number

I assume this will be kicked out of the branch before we merge? I mean, either works, it just seems a bit pointless to keep patches to aid comparisons in our tree. On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Makes it easier to compare the newly generated

Re: [Mesa-dev] [PATCH v2 08/24] mapi/new: import mapi scripts from glvnd

On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we have over 20 scripts that generate the libGL* dispatch > and > various other functionality. More importantly we're using local XML > files instead of the Khronos provides one(s). Resulting in an >

Re: [Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > The helper will also be used by the new Khronos gl.xml aware > generator. > > v2: Move existing one, instead of duplicating it. > > Suggested-by: Kyle Brenneman > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH v2 05/24] mapi: add all _glapi_table entrypoints to static_data.py

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Currently various parts of mesa use the glapi_table differently. > > Some use _glapi_get_proc_offset() to get the offset, while others > directly reference the specific offset via

Re: [Mesa-dev] [PATCH v2 06/24] genCommon.py: Fix typo in _LIBRARY_FEATURE_NAMES.

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Port glvnd commit 37fc6caa4b8 ("Fix typo in _LIBRARY_FEATURE_NAMES.") > from Michal Srb. > > Signed-off-by: Emil Velikov > --- > src/egl/generate/genCommon.py | 2 +- > 1 file

Re: [Mesa-dev] [PATCH v2 03/24] Revert "mesa/main: remove ARB suffix from glGetnTexImage"

Acked-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > This reverts commit f1998e15ffccf260552bf559abe1a733a8ce990e. > > This changes the ABI, such that glGetnTexImageARB entry-point from > the > GLAPI gets removed. Thus accessing many functions by offset (as we > do)

Re: [Mesa-dev] [PATCH v2 01/24] mesa: correctly use os.path.join in our python scripts

Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > With Windows in mind, using forward slash isn't the right thing to > do. > Even if it just works, we might want to fix it. > > As here, use __file__ instead of argv[0] and

[Mesa-dev] [PATCH v2 20/24] mapi/es*api: remove GL_OES_EGL_image entrypoints

From: Emil Velikov As some point in the past we fixed the scripts so, these are no longer exported. Drop them from the list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es1api/ABI-check | 3 --- src/mapi/es2api/ABI-check | 3 --- 2 files changed, 6 deletions(-) diff

[Mesa-dev] [PATCH v2 06/24] genCommon.py: Fix typo in _LIBRARY_FEATURE_NAMES.

From: Emil Velikov Port glvnd commit 37fc6caa4b8 ("Fix typo in _LIBRARY_FEATURE_NAMES.") from Michal Srb. Signed-off-by: Emil Velikov --- src/egl/generate/genCommon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/generate/genCommon.py

[Mesa-dev] [PATCH v2 12/24] mapi/new: split out public_entries handling

From: Emil Velikov The only instance that requires the public_entries table is the dispatch library - split that into another function. We have to be careful with when undefining the guard, so split it out. We might want to merge this back in GLVND. Minor GLVND cleanup will be needed first.

[Mesa-dev] [PATCH v2 21/24] mapi/es*api: remove GL_EXT_multi_draw_arrays entrypoints

From: Emil Velikov Now we use the upstream XML file and a cleaner generator. Thus the symbols are no longer exported and we can drop them from this list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es1api/ABI-check | 7 +-- src/mapi/es2api/ABI-check | 6 +- 2

[Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use "gldispatch" instead of not "glesv1" "glesv2" -

[Mesa-dev] [PATCH v2 16/24] autotools: wire the new generator for es1 and es2

The output produced functionally identical, with the following changes: - A cosmetic: swapped ABI compatible types [ GLclampf -> GLfloat, etc ] - B cosmetic: renamed parameters [ zNear -> n, etc ] - C dropped extension entrypoints - invalid/incorrect To make things easier to validate,

[Mesa-dev] [PATCH v2 22/24] mapi/es2api: remove no longer present entrypoints

From: Emil Velikov With the previous scripts API from the following was incorrectly exported. Drop them from the list, since they're no longer around. GL_EXT_blend_func_extended GL_EXT_texture_integer Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es2api/ABI-check | 5

[Mesa-dev] [PATCH v2 17/24] meson: wire the new generator for es1 and es2

From: Emil Velikov v2: use ${foo})_py naming (Dylan) Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Emil Velikov --- src/mapi/es1api/meson.build| 6 +++--- src/mapi/es2api/meson.build| 6 +++--- src/mapi/glapi/gen/meson.build | 7 +++ 3 files changed, 13 insertions(+), 6

[Mesa-dev] [PATCH v2 14/24] mapi/new: fixup the GLDEBUGPROCKHR typedef to the non KHR one

From: Emil Velikov This way we can reuse the latter, which is already present in the headers that we use. Thus we can drop the manual typedef we generate. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov --- src/mapi/new/genCommon.py | 1 +

[Mesa-dev] [PATCH v2 15/24] mapi/new: remove duplicate GLvoid/void substitution

From: Emil Velikov We already do it a few lines above - drop the duplicate. Note that for consistency sake, we keep the substitution since the GL API is a mixed bad - some use GLvoid while others a normal void. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH v2 18/24] scons: wire the new generator for es1 and es2

From: Emil Velikov Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/shared-glapi/SConscript | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/mapi/shared-glapi/SConscript b/src/mapi/shared-glapi/SConscript index

[Mesa-dev] [PATCH v2 23/24] mapi: remove old, unused ES* generator code

From: Emil Velikov As of earlier commit, everyone has switched to the new script for the ES dispatch. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/glapi/gen/gl_XML.py | 56 +- src/mapi/mapi_abi.py | 58

[Mesa-dev] [PATCH v2 24/24] mapi: remove machinery handling CSV files

From: Emil Velikov We haven't have one in years, so just drop the code. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/mapi_abi.py | 80 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/src/mapi/mapi_abi.py

[Mesa-dev] [PATCH v2 10/24] mapi/new: use the static_data offsets in the new generator

From: Emil Velikov Otherwise the incorrect ones will be used, effectively breaking the ABI. Note: some entries in static_data.py list a suffixed API, while (for ES* at least) we expect the one w/o suffix. v2: - rework path handling (Dylan) - use else if chain (Erik) Signed-off-by: Emil

[Mesa-dev] [PATCH v2 04/24] mapi: sort static entrypoints numerically

From: Emil Velikov A few of the entrypoints were incorrectly placed. Sort those to align with the rest of the list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/glapi/gen/static_data.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH v2 19/24] Revert "mapi/new: sort by slot number"

This reverts commit a1f5d9412cf7cacb3534635f6c2409fafbe6574e. We no longer needed to sort - it was meant only to ease compare against the old generated files. --- src/mapi/new/genCommon.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mapi/new/genCommon.py b/src/mapi/new/genCommon.py

[Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

From: Emil Velikov The helper will also be used by the new Khronos gl.xml aware generator. v2: Move existing one, instead of duplicating it. Suggested-by: Kyle Brenneman Signed-off-by: Emil Velikov --- src/egl/Makefile.am | 6 --

[Mesa-dev] [PATCH v2 11/24] mapi/new: reinstate _NO_HIDDEN suffixes in the new generator

From: Emil Velikov Strictly speaking we can rework the rest of the code so we do not need those. That said, this will require a series on it's own so let's carry this local quirk for now. Signed-off-by: Emil Velikov --- src/mapi/new/gen_gldispatch_mapi.py | 12 ++-- 1 file changed, 6

[Mesa-dev] [PATCH v2 05/24] mapi: add all _glapi_table entrypoints to static_data.py

From: Emil Velikov Currently various parts of mesa use the glapi_table differently. Some use _glapi_get_proc_offset() to get the offset, while others directly reference the specific offset via _gloffset_Function. Add all static entries, to ensure things don't break as we flip to the upstream

  1   2   >