[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 Ian Romanick changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-18 Thread Matt Turner
On Tue, Dec 18, 2018 at 6:53 PM Ilia Mirkin wrote: > > On Tue, Dec 18, 2018 at 6:40 PM Gert Wollny wrote: > > > > Hi Ilia, > > > > Am Sonntag, den 16.12.2018, 12:40 -0500 schrieb Ilia Mirkin: > > > On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny > > > wrote: > > > > > > > > Since Meson will

Re: [Mesa-dev] nir/algebraic: Generalize an optimization - RADV / DXVK 0.93+0.94 regression with LS2019

2018-12-18 Thread Dieter Nützel
Sorry guys, but my son got a RADV + DXVK 0.93 and 0.94 (D3D11) regression running brand new LS2019 (https://www.farming-simulator.com/?lang=en=us) on our Polaris 20. All heaven textures are gone and some others are wrong. git bisect bad 445867c80d git bisect good e4f9a37ace /opt/mesa> git

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #7 from Ilia Mirkin --- Patch available at: https://patchwork.freedesktop.org/patch/268721/ Makes this example work, and doesn't appear to regress existing piglit tests. -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-18 Thread Ilia Mirkin
Not sure if this ever worked, but the current logic for setting the min/max index is definitely wrong for indexed draws. While we're at it, bring in all the usual logic from the non-indirect drawing path. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109086 Signed-off-by: Ilia Mirkin

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #6 from Ilia Mirkin --- (In reply to Ilia Mirkin from comment #5) > Note that the address is (very likely) bogus. It also dies with draw using > llvm (same address), but ... harder to debug that. Will try to investigate > further.

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #5 from Ilia Mirkin --- With valgrind, forcing DRAW_USE_LLVM=0 to make our lives a little easier, it dies in: ==12812== Process terminating with default action of signal 11 (SIGSEGV) ==12812== Access not within mapped region at

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #4 from Daniel Stone --- The content of attachment 142850 has been deleted for the following reason: spam -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #3 from Daniel Stone --- The content of attachment 142849 has been deleted for the following reason: spam -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #2 from Vian --- Created attachment 142850 --> https://bugs.freedesktop.org/attachment.cgi?id=142850=edit hwhwhw -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 --- Comment #1 from Vian --- Created attachment 142849 --> https://bugs.freedesktop.org/attachment.cgi?id=142849=edit bug -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Jason Ekstrand
On December 18, 2018 19:42:56 Rhys Perry wrote: The 32-bit condition was in one of radv's meta shaders and had it from the start. 32-bit conditions seems to be valid after lowering booleans to 32-bit. Are they supposed to be invalid before the lowering? It's not invalid in the sense that

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Rhys Perry
The 32-bit condition was in one of radv's meta shaders and had it from the start. 32-bit conditions seems to be valid after lowering booleans to 32-bit. Are they supposed to be invalid before the lowering? On Wed, 19 Dec 2018 at 00:59, Jason Ekstrand wrote: > > Seems reasonable though I'm a bit

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #9 from Philip Rebohle --- The patch that Ian posted fixes both the Witcher 3 hang and the Overwatch issue. -- You are receiving this mail because: You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Jason Ekstrand
Seems reasonable though I'm a bit surprised your running peephole_select after lowering booleans. On December 18, 2018 18:16:46 Timothy Arceri wrote: Reviewed-by: Timothy Arceri On 18/12/18 3:16 am, Rhys Perry wrote: Signed-off-by: Rhys Perry ---

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 18/12/18 3:16 am, Rhys Perry wrote: Signed-off-by: Rhys Perry --- src/compiler/nir/nir_opt_peephole_select.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_peephole_select.c

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-18 Thread Ilia Mirkin
On Tue, Dec 18, 2018 at 6:40 PM Gert Wollny wrote: > > Hi Ilia, > > Am Sonntag, den 16.12.2018, 12:40 -0500 schrieb Ilia Mirkin: > > On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny > > wrote: > > > > > > Since Meson will eventually be the only build system deprecate > > > autotools > > > now. It can

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-18 Thread Gert Wollny
Hi Ilia, Am Sonntag, den 16.12.2018, 12:40 -0500 schrieb Ilia Mirkin: > On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny > wrote: > > > > Since Meson will eventually be the only build system deprecate > > autotools > > now. It can still be used by invoking configure with the flag > >

[Mesa-dev] [PATCH] autotools: Remove tegra vdpau driver

2018-12-18 Thread Dylan Baker
This has never functioned and probably wont ever function, due to the way gallium media state trackers are architected and the tegra video decoder is architected. Cc: Thierry Reding Fixes: 1755f608f5201e0a23f00cc3ea1b01edd07eb6ef ("tegra: Initial support") ---

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-18 Thread Dylan Baker
Quoting Thierry Reding (2018-12-18 14:19:32) > On Tue, Dec 18, 2018 at 11:34:31AM -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-12-18 09:43:18) > > > > > > > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker > > > wrote: > > > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > >

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #8 from Timothy Arceri --- (In reply to Ian Romanick from comment #5) > The problem is the quotation marks around 1.0 cause it to be treated as a > string instead of a floating point value. The generator then treats it as > an

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-18 Thread Thierry Reding
On Tue, Dec 18, 2018 at 11:34:31AM -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2018-12-18 09:43:18) > > > > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker > > wrote: > > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > > >

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #7 from Ian Romanick --- Test case sent to the piglit list: https://patchwork.freedesktop.org/patch/268702/ -- You are receiving this mail because: You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-18 Thread Dylan Baker
Quoting Emil Velikov (2018-12-18 03:09:55) > On Mon, 17 Dec 2018 at 22:27, Matt Turner wrote: > > > > On Mon, Dec 17, 2018 at 2:12 PM Emil Velikov > > wrote: > > > Additionally, distributions build latest loader and use it with DRI1 > > > era drivers. > > > > I'm curious if there are

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

2018-12-18 Thread Dylan Baker
Quoting Emil Velikov (2018-12-18 02:33:56) > On Mon, 17 Dec 2018 at 19:44, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-17 10:58:11) > > > On Fri, 14 Dec 2018 at 17:13, Dylan Baker wrote: > > > > > > > > Quoting Emil Velikov (2018-12-13 08:05:52) > > > > > From: Emil Velikov > > > >

Re: [Mesa-dev] [PATCH] meson: Fix libsensors detection.

2018-12-18 Thread Dylan Baker
Quoting Vinson Lee (2018-12-18 13:01:43) > On Tue, Dec 18, 2018 at 11:42 AM Dylan Baker wrote: > > > > Quoting Vinson Lee (2018-12-18 09:52:08) > > > Fixes: 5e71efef44b9 ("meson: Add lmsensors support") > > > Signed-off-by: Vinson Lee > > > --- > > > meson.build | 2 +- > > > 1 file changed, 1

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 Ian Romanick changed: What|Removed |Added Status|ASSIGNED|NEEDINFO --- Comment #6 from Ian

[Mesa-dev] MR: nir/algebraic: Don't put quotes around floating point literals

2018-12-18 Thread Ian Romanick
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/30 NOTE: This is still running through our CI, and I'm trying to come up with a piglit test case that will reproduce it. The quotation marks around 1.0 cause it to be treated as a string instead of a floating point value. The generator then

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 Ian Romanick changed: What|Removed |Added CC||ja...@jlekstrand.net,

Re: [Mesa-dev] [PATCH] meson: Fix libsensors detection.

2018-12-18 Thread Vinson Lee
On Tue, Dec 18, 2018 at 11:42 AM Dylan Baker wrote: > > Quoting Vinson Lee (2018-12-18 09:52:08) > > Fixes: 5e71efef44b9 ("meson: Add lmsensors support") > > Signed-off-by: Vinson Lee > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

[Mesa-dev] [PATCH 4/5] radv: add support for FMASK expand

2018-12-18 Thread Samuel Pitoiset
Original patch by Dave Airlie. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/Makefile.sources | 1 + src/amd/vulkan/meson.build | 1 + src/amd/vulkan/radv_cmd_buffer.c| 7 + src/amd/vulkan/radv_meta.c | 8 + src/amd/vulkan/radv_meta.h

[Mesa-dev] [PATCH 5/5] radv: enable shaderStorageImageMultisample feature on GFX8+

2018-12-18 Thread Samuel Pitoiset
Untested on older chips. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_formats.c | 3 +-- src/amd/vulkan/radv_shader.c | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 3/5] radv: initialize FMASK for images in fully expanded mode

2018-12-18 Thread Samuel Pitoiset
The value depends on the number of samples. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 25 + src/amd/vulkan/radv_meta.h | 2 ++ src/amd/vulkan/radv_meta_clear.c | 9 + src/amd/vulkan/radv_private.h| 3 +++ 4 files changed,

[Mesa-dev] [PATCH 2/5] ac/nir: restrict fmask lookup to image load intrinsics

2018-12-18 Thread Samuel Pitoiset
We don't ever want to do the fmask lookup on a atomic or store, the fmask should have been decompressed if the surface has been moved to IMAGE_LAYOUT. Original patch by Dave Airlie. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 1/5] spirv: add support for SpvCapabilityStorageImageMultisample

2018-12-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/compiler/shader_info.h| 1 + src/compiler/spirv/spirv_to_nir.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index b21db3e60f0..05f37c8d197 100644 ---

[Mesa-dev] [PATCH 0/5] radv: add support for shaderStorageImageMultisample feature

2018-12-18 Thread Samuel Pitoiset
Hi, This small series enables shaderStorageImageMultisample on GFX8+. This series is originally based on Dave Airlie's work, but I made some changes to make it work. Please review, Thanks! Samuel Pitoiset (5): spirv: add support for SpvCapabilityStorageImageMultisample ac/nir: restrict

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 pritzl3...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #13 from pritzl3...@gmail.com --- I just played a little bit and there was a spot it always hung for me but now it works fine. I havent tried the game since I last updated the bug I think until today. -- You are receiving this

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-18 09:43:18) > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker wrote: > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > > wrote: > > > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: >

Re: [Mesa-dev] [PATCH] meson: Fix libsensors detection.

2018-12-18 Thread Dylan Baker
Quoting Vinson Lee (2018-12-18 09:52:08) > Fixes: 5e71efef44b9 ("meson: Add lmsensors support") > Signed-off-by: Vinson Lee > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 57dd8b59cb..d591ca377b 100644 > ---

Re: [Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Rob Clark
On Tue, Dec 18, 2018 at 9:46 AM Ilia Mirkin wrote: > > On Tue, Dec 18, 2018 at 9:42 AM Eduardo Lima Mitev wrote: > > > > emit_intrinsic_store_image() is always using 4 components when > > collecting registers for the value. When image has less than > > 4 components (e.g, r32f, r32i, r32ui) this

[Mesa-dev] [PATCH] etnaviv: implement check_resource_capability

2018-12-18 Thread Lucas Stach
We try to avoid sharing all resources with KMS side of renderonly, as this adds some overhead that isn't really needed for most resources. If someone tries to validate a resource for scanout, this is a good indication that the sharing with the KMS side is actually needed. Signed-off-by: Lucas

Re: [Mesa-dev] [PATCH] egl/wayland: break double/tripple buffering feedback loops

2018-12-18 Thread Lucas Stach
Am Dienstag, den 18.12.2018, 17:43 + schrieb Emil Velikov: > > On Tue, 18 Dec 2018 at 11:16, Lucas Stach wrote: > > > > Currently we dispose any unneeded color buffers immediately if we detect > > that > > there are more unlocked buffers than we need. This can lead to feedback > > loops >

Re: [Mesa-dev] [PATCH] radv: Work around non-renderable 128bpp compressed 3d textures on GFX9.

2018-12-18 Thread Haehnle, Nicolai
On 18.12.18 00:02, Bas Nieuwenhuizen wrote: > Exactly what title says, the new addrlib does not allow the above with > certain dimensions that the CTS seems to hit. Work around it by not > allowing the app to render to it via compat with other 128bpp formats > and do not render to it ourselves

[Mesa-dev] [PATCH] meson: Fix libsensors detection.

2018-12-18 Thread Vinson Lee
Fixes: 5e71efef44b9 ("meson: Add lmsensors support") Signed-off-by: Vinson Lee --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 57dd8b59cb..d591ca377b 100644 --- a/meson.build +++ b/meson.build @@ -1395,7 +1395,7 @@ endif

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #10 from Dylan Baker --- Relevant to this change proposal though, lets say we have: /usr/lib/libdrm*.2.4.75; /usr/local/lib/libdrm*.2.4.95 and PKG_CONFIG_PATH=/usr/lib/pkg-config:/usr/local/lib/pkg-config if our dependencies are:

Re: [Mesa-dev] [PATCH] amd/surface: fix setting of ADDR2_SURFACE_FLAGS::color

2018-12-18 Thread Haehnle, Nicolai
On 18.12.18 18:36, Bas Nieuwenhuizen wrote: > Hi Nicolai, > > I happened to be writing something similar which also fixes up radv to > never render to those surfaces as r32g32b32a32: > https://patchwork.freedesktop.org/series/54172/ I can split out the > radv specific stuff and this one is r-b

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #9 from Dylan Baker --- tl;dr: that only works if you can *always know* that you wont need a fallback and that the only way to discover all of the dependencies is via pkg-config and not via cmake or a *-config tool. imagine you

Re: [Mesa-dev] [PATCH] egl/wayland: break double/tripple buffering feedback loops

2018-12-18 Thread Emil Velikov
On Tue, 18 Dec 2018 at 11:16, Lucas Stach wrote: > > Currently we dispose any unneeded color buffers immediately if we detect that > there are more unlocked buffers than we need. This can lead to feedback loops > between the compositor and the application causing rapid toggling between > double

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-18 Thread Eric Engestrom
On December 18, 2018 5:36:19 PM UTC, Dylan Baker wrote: > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > wrote: > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > > Under what circumstances would tegra have a vdpau >

Re: [Mesa-dev] last call for autotools

2018-12-18 Thread Nicolai Hähnle
On 17.12.18 23:46, Dylan Baker wrote: Quoting Marek Olšák (2018-12-17 12:25:29) On Mon, Dec 17, 2018 at 1:18 PM Eric Anholt wrote: Eero Tamminen writes: > Hi, > > On 17.12.2018 8.08, Marek Olšák wrote: > [...] >> I think one of the serious usability issues is

Re: [Mesa-dev] [PATCH] amd/surface: fix setting of ADDR2_SURFACE_FLAGS::color

2018-12-18 Thread Bas Nieuwenhuizen
Hi Nicolai, I happened to be writing something similar which also fixes up radv to never render to those surfaces as r32g32b32a32: https://patchwork.freedesktop.org/series/54172/ I can split out the radv specific stuff and this one is r-b after than. Thanks, Bas On Tue, Dec 18, 2018 at 5:37 PM

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-18 Thread Dylan Baker
Quoting Ilia Mirkin (2018-12-06 09:39:25) > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > wrote: > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > Under what circumstances would tegra have a vdpau implementation? > > > > I don't know about that, but this patch brings

[Mesa-dev] [PATCH] amd/surface: fix setting of ADDR2_SURFACE_FLAGS::color

2018-12-18 Thread Nicolai Hähnle
From: Nicolai Hähnle In the gfx9 addrlib, this bit has been clarified as meaning that the surface can be used as a color buffer (render target). Setting this for compressed surfaces triggers a workaround that is only required for surfaces that can be render targets, and ends up breaking the

[Mesa-dev] [Bug 108720] System crash vulkan cemu

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108720 --- Comment #1 from Samuel Pitoiset --- Are you still able to reproduce? If yes, can you give more info like dmesg and eventually a renderdoc or apitrace capture, please? -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 105049] Invalid usage of vulkan pipeline barriers can cause amdgpu to deadlock

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105049 --- Comment #7 from Samuel Pitoiset --- Well, the validation layers report a bunch of errors with your app, like: Validation layer: (F8) [ VUID-vkCmdEndRenderPass-commandBuffer-cmdpool ] Object: 0x5638b8e4f6b0 (Type = 6) | Cannot call

[Mesa-dev] [Bug 105049] Invalid usage of vulkan pipeline barriers can cause amdgpu to deadlock

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105049 Samuel Pitoiset changed: What|Removed |Added Resolution|FIXED |NOTOURBUG -- You are receiving this

[Mesa-dev] [Bug 105049] Invalid usage of vulkan pipeline barriers can cause amdgpu to deadlock

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105049 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-18 Thread Andres Gomez
On Tue, 2018-12-18 at 10:47 +, Emil Velikov wrote: > On Mon, 17 Dec 2018 at 22:35, Andres Gomez wrote: > > > > On Mon, 2018-12-17 at 18:36 +, Emil Velikov wrote: > > > On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > > > > > > > On Mon, 2018-12-17 at 16:43 +, Emil Velikov

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #12 from Samuel Pitoiset --- Are you still able to reproduce this? FWIW, I launch Talos with different settings almost every week and I never got any GPU hangs. -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
On Tue, Dec 18, 2018 at 9:42 AM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g, r32f, r32i, r32ui) this results in extra mov > instructions. > > This patch uses the

[Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
emit_intrinsic_store_image() is always using 4 components when collecting registers for the value. When image has less than 4 components (e.g, r32f, r32i, r32ui) this results in extra mov instructions. This patch uses the actual number of components from the image format. For example, in a

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-18 Thread Kyle Brenneman
On 12/14/2018 07:04 AM, Emil Velikov wrote: There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use

Re: [Mesa-dev] [PATCH v2] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
Looks like you missed the R*16_SNORM's (and UNORM's now that I look closer.) On Tue, Dec 18, 2018 at 9:16 AM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g, r32f, r32i,

[Mesa-dev] [PATCH v2] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
emit_intrinsic_store_image() is always using 4 components when collecting registers for the value. When image has less than 4 components (e.g, r32f, r32i, r32ui) this results in extra mov instructions. This patch uses the actual number of components from the image format. For example, in a

Re: [Mesa-dev] [Freedreno] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
On 12/18/18 2:31 PM, Rob Clark wrote: > On Mon, Dec 17, 2018 at 3:41 PM Eduardo Lima Mitev wrote: >> >> emit_intrinsic_store_image() is always using 4 components when >> collecting registers for the value. When image has less than >> 4 components (e.g, r32f, r32i, r32ui) this results in extra mov

Re: [Mesa-dev] [Freedreno] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Rob Clark
On Mon, Dec 17, 2018 at 3:41 PM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g, r32f, r32i, r32ui) this results in extra mov > instructions. > > This patch uses the

[Mesa-dev] [Bug 109086] Crash software mesa with gl_select render mode

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109086 Bug ID: 109086 Summary: Crash software mesa with gl_select render mode Product: Mesa Version: 18.3 Hardware: Other OS: Windows (All) Status: NEW

[Mesa-dev] [PATCH] egl/wayland: break double/tripple buffering feedback loops

2018-12-18 Thread Lucas Stach
Currently we dispose any unneeded color buffers immediately if we detect that there are more unlocked buffers than we need. This can lead to feedback loops between the compositor and the application causing rapid toggling between double and tripple buffering. Scenario: 2 buffers already qeued to

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-18 Thread Emil Velikov
On Mon, 17 Dec 2018 at 22:27, Matt Turner wrote: > > On Mon, Dec 17, 2018 at 2:12 PM Emil Velikov wrote: > > Additionally, distributions build latest loader and use it with DRI1 > > era drivers. > > I'm curious if there are distributions that still ships the DRI1 > drivers. Do you know which, if

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-18 Thread Emil Velikov
On Mon, 17 Dec 2018 at 22:17, Dylan Baker wrote: > > Quoting Tobias Klausmann (2018-12-17 14:05:13) > > > > On 17.12.18 20:33, Dylan Baker wrote: > > > Quoting Emil Velikov (2018-12-17 11:10:00) > > >> On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: > > >>> Quoting Emil Velikov (2018-12-13

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #8 from Emil Velikov --- time for i in `seq 1 100`; do pkg-config --libs "libdrm_nouveau >= 2.4.20" &>/dev/null; pkg-config --libs "libdrm >= 2.4.20" &>/dev/null; done real0m0.738s user0m0.476s sys 0m0.270s time

Re: [Mesa-dev] [PATCH] meson: Fix typo.

2018-12-18 Thread Emil Velikov
On Tue, 18 Dec 2018 at 02:32, Vinson Lee wrote: > > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > Signed-off-by: Vinson Lee > --- Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
On 12/18/18 11:18 AM, Ilia Mirkin wrote: > Nv_image_formats adds all the core formats to gles. > > It's pretty easy to add them all in, so I don't see why not. > Ok, I didn't know about that extension, thanks for the pointer. It then makes sense to support all these formats, yes. I will submit

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-18 Thread Emil Velikov
On Mon, 17 Dec 2018 at 22:35, Andres Gomez wrote: > > On Mon, 2018-12-17 at 18:36 +, Emil Velikov wrote: > > On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > > > > > On Mon, 2018-12-17 at 16:43 +, Emil Velikov wrote: > > > > Currently our is_sha_nomination does: > > > > - folds any

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

2018-12-18 Thread Emil Velikov
On Mon, 17 Dec 2018 at 19:44, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-17 10:58:11) > > On Fri, 14 Dec 2018 at 17:13, Dylan Baker wrote: > > > > > > Quoting Emil Velikov (2018-12-13 08:05:52) > > > > From: Emil Velikov > > > > > > > > The library is the dri capable one, push the

[Mesa-dev] [PATCH v2 20/29] i965/fs/nir: add nir_op_unpack_half_2x16_split_*_flush_to_zero

2018-12-18 Thread Samuel Iglesias Gonsálvez
The denorm mode is set in the control register, no need to do something else. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index

[Mesa-dev] [PATCH v2 27/29] anv: add support for VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FLOAT_CONTROLS_PROPERTIES_KHR

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_device.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 67ea86c4b66..1b57e7b56f5 100644 --- a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH v2 22/29] i965/fs: define emit_shader_float_controls_execution_mode() and aux functions

2018-12-18 Thread Samuel Iglesias Gonsálvez
We need this function to emit code that setups the control register later with the defined execution mode for the shader. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs.h | 1 + src/intel/compiler/brw_fs_visitor.cpp | 52 +++ 2 files

[Mesa-dev] [PATCH v2 19/29] i965/fs: add nir_op_f2f*_{rtne,rtz}

2018-12-18 Thread Samuel Iglesias Gonsálvez
This way, we can implement its support later if SPIR-V supports it. Right now, the RTZ, RTNE support in SPIR-V in FPRoundingMode only applies to f2f16 conversions. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs_nir.cpp | 4 1 file changed, 4 insertions(+) diff

[Mesa-dev] [PATCH v2 28/29] anv: enable support for SPV_KHR_shader_float_controls capabilities

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_pipeline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index c303ba321c3..2781b8f0ee0 100644 --- a/src/intel/vulkan/anv_pipeline.c +++

[Mesa-dev] [PATCH v2 21/29] i965/fs/generator: add support to set floating points modes in control register

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_eu.h | 4 src/intel/compiler/brw_eu_defines.h | 10 ++ src/intel/compiler/brw_eu_emit.c| 26 + src/intel/compiler/brw_fs_generator.cpp | 8 +++-

[Mesa-dev] [PATCH v2 18/29] intel/nir: call nir_opt_constant_folding before brw_nir_apply_trig_workarounds

2018-12-18 Thread Samuel Iglesias Gonsálvez
If we have fsin or fcos trigonometric operations with constant values as inputs, we will multiply the result by 0.7 in brw_nir_apply_trig_workarounds, making the result wrong. Running nir_opt_constant_folding before, we will calculate correctly the result for these trignometric ops.

[Mesa-dev] [PATCH v2 26/29] i965/fs: add support for shader float control to remove_extra_rounding_modes()

2018-12-18 Thread Samuel Iglesias Gonsálvez
The remove_extra_rounding_modes() optimization will remove duplicated rounding mode changes. v2: - Fix bug in the rounding mode change (Alejandro) Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs.cpp | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 24/29] i965/fs: set rounding mode when emitting affected conversion instructions

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs_nir.cpp | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index d9376e92220..be197b5f745 100644 ---

[Mesa-dev] [PATCH v2 29/29] anv: enable VK_KHR_shader_float_controls extension

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index e481c45d5d5..2e29e941bfa 100644 --- a/src/intel/vulkan/anv_extensions.py +++

[Mesa-dev] [PATCH v2 25/29] i965/fs: remove brw_rounding_mode() and use brw_float_controls_mode() instead

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_eu.h | 4 --- src/intel/compiler/brw_eu_emit.c| 36 - src/intel/compiler/brw_fs_generator.cpp | 13 +++-- 3 files changed, 11 insertions(+), 42 deletions(-) diff --git

[Mesa-dev] [PATCH v2 23/29] i965/fs: emit shader float controls execution modes as first instruction of shaders

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 12971eeb549..0ccff00dd4c 100644 --- a/src/intel/compiler/brw_fs.cpp +++

[Mesa-dev] [PATCH v2 16/29] nir: fix denorm flush-to-zero in sqrt's lowering at nir_lower_double_ops

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_double_ops.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_double_ops.c b/src/compiler/nir/nir_lower_double_ops.c index b3543bc6963..c27e2d384a5 100644 ---

[Mesa-dev] [PATCH v2 15/29] nir: fix denorms in unpack_half_1x16()

2018-12-18 Thread Samuel Iglesias Gonsálvez
According to VK_KHR_shader_float_controls: "Denormalized values obtained via unpacking an integer into a vector of values with smaller bit width and interpreting those values as floating-point numbers must: be flushed to zero, unless the entry point is declared with the code:DenormPreserve

[Mesa-dev] [PATCH v2 17/29] nir: fix fmin/fmax support for doubles

2018-12-18 Thread Samuel Iglesias Gonsálvez
Until now, it was using the floating point version of fmin, instead of the double version. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_opcodes.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_opcodes.py

[Mesa-dev] [PATCH v2 02/29] spirv: check support for SPV_KHR_shader_float_controls capabilities

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/shader_info.h| 1 + src/compiler/spirv/spirv_to_nir.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index b4bc95912a5..53a89a38244 100644 ---

[Mesa-dev] [PATCH v2 07/29] spirv/glsl450: fix reflect(denorm, denorm) FTZ = 0.0 case

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_glsl450.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/compiler/spirv/vtn_glsl450.c b/src/compiler/spirv/vtn_glsl450.c index 82cc7dc909c..c40594290a3 100644 ---

[Mesa-dev] [PATCH v2 14/29] nir: fix constant expressions for rounding mode conversions

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_constant_expressions.py | 46 +--- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir_constant_expressions.py b/src/compiler/nir/nir_constant_expressions.py index

[Mesa-dev] [PATCH v2 12/29] nir: add new rounding mode conversions

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir.h| 2 + src/compiler/nir/nir_opcodes.py | 87 --- src/compiler/nir/nir_opcodes_c.py | 4 +- 3 files changed, 50 insertions(+), 43 deletions(-) diff --git a/src/compiler/nir/nir.h

[Mesa-dev] [PATCH v2 01/29] spirv: Update SPIR-V json and headers to Khronos master

2018-12-18 Thread Samuel Iglesias Gonsálvez
This corresponds to commit 17da9f8231f78cf519b4958c2229463a63ead9e2 on GitHub. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/spirv.core.grammar.json | 316 +++-- src/compiler/spirv/spirv.h | 84 +++--- 2 files changed, 281 insertions(+), 119

[Mesa-dev] [PATCH v2 03/29] spirv/nir: keep track of SPV_KHR_shader_float_controls execution modes

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/shader_enums.h | 14 ++ src/compiler/shader_info.h| 3 +++ src/compiler/spirv/spirv_to_nir.c | 26 ++ 3 files changed, 43 insertions(+) diff --git a/src/compiler/shader_enums.h

[Mesa-dev] [PATCH v2 05/29] spirv/glsl450: fix atan2(0, 0) lowering

2018-12-18 Thread Samuel Iglesias Gonsálvez
We were returning 3*pi/4 when we should return 0.0 according to IEEE 754. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_glsl450.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/vtn_glsl450.c b/src/compiler/spirv/vtn_glsl450.c

[Mesa-dev] [PATCH v2 11/29] util: add fp64 -> fp32 conversion support for RTNE and RTZ rounding modes

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/util/Makefile.sources | 2 + src/util/double.c | 197 ++ src/util/double.h | 46 + src/util/meson.build | 2 + 4 files changed, 247 insertions(+) create mode 100644

[Mesa-dev] [PATCH v2 09/29] nir: create new conversion opcodes with floating point rounding modes

2018-12-18 Thread Samuel Iglesias Gonsálvez
It adds round-towards-zero and round-to-nearest-even opcodes for floating point conversions. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_opcodes.py | 2 +- src/compiler/nir/nir_opcodes_c.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

  1   2   >