On Tue, 2019-01-29 at 07:20 -0800, Jason Ekstrand wrote:
>
>
>
>
>
> On January 29, 2019 05:27:50 Iago Toral wrote:
> > On Thu, 2019-01-17 at 18:18 -0600, Jason Ekstrand wrote:
> > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga <
> > > ito...@igalia.com> wrote:
> > > > Reviewed-by:
On Tue, Jan 29, 2019 at 11:32:59AM -0800, Eric Anholt wrote:
> Rich Felker writes:
>
> > On Tue, Jan 29, 2019 at 08:29:32AM +0100, Patrick Steinhardt wrote:
> >> On Mon, Jan 28, 2019 at 02:09:18PM -0800, Dylan Baker wrote:
> >> > Quoting Adam Jackson (2019-01-28 09:00:13)
> >> > > On Sat,
On 1/28/19 9:43 AM, Guido Günther wrote:
> Hi,
> just style nits:
>
> On Sat, Jan 12, 2019 at 10:22:20PM +0100, Marek Vasut wrote:
>> From: Christian Gmeiner
>>
>> A pipe_resource can be shared by all the pipe_context's hanging off the
>> same pipe_screen.
Fixed both, thanks.
--
Best regards,
Panfrost is a community-led, free software driver for Mali Midgard and
Bifrost GPUs. This patchset contains the initial changes for upstreaming
the driver. On the command stream side, for now only a stub and winsys
integration is included; the full driver is pending on kernel changes.
As for
From: Christian Gmeiner
A pipe_resource can be shared by all the pipe_context's hanging off the
same pipe_screen.
Signed-off-by: Christian Gmeiner
Signed-off-by: Marek Vasut
To: mesa-dev@lists.freedesktop.org
Cc: etna...@lists.freedesktop.org
---
Changes from v1 -> v2:
- to remove the
https://bugs.freedesktop.org/show_bug.cgi?id=109446
fin4...@hotmail.com changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
Adam Jackson wrote:
> On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> > This series enables fp16 fbconfigs and visuals by leveraging existing
> > off-screen rendering support.
> >
> > These formats can be used in conjunction with
> > EXT_surface_SMPTE2086_metadata (not yet
Adam Jackson wrote:
> On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> > Expose configs when allow_fp16_configs has been enabled and
> > DRI_LOADER_CAP_FP16 is set in the loader.
> >
> > Also, make kms_swrast_dri respect format bpp, to allow for allocating
> > buffers wider than 32 bpp.
Adam Jackson wrote:
> On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> > @@ -237,19 +268,35 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig
> > *dri_config, int id,
> > break;
> >
> >case __DRI_ATTRIB_RED_MASK:
> > - dri_masks[0] = value;
> > +
https://bugs.freedesktop.org/show_bug.cgi?id=109500
Bug ID: 109500
Summary: rpcs3 diagonal lines
Product: Mesa
Version: 18.3
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Thanks Brian and Ilia for the review.
Regards,
Neha
From: Ilia Mirkin
Sent: Tuesday, January 29, 2019 1:20:50 PM
To: Brian Paul
Cc: Neha Bhende; mesa-dev@lists.freedesktop.org
Subject: Re: [Review Request (master branch)] st/mesa: Fix
Ernestas Kulik writes:
> Reported by Coverity: in the case where there exist hardware and
> non-hardware queries, the code does not jump to err_free_query and leaks
> the query.
>
> CID: 1430194
> Signed-off-by: Ernestas Kulik
I just found these deep in my inbox, and pushed them.
On Fri, Oct 12, 2018 at 01:46:34PM -0500, Jason Ekstrand wrote:
> Reviewed-by: Topi Pohjolainen
> ---
> src/intel/isl/isl.c | 36
> src/intel/isl/isl.h | 2 +-
> 2 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/src/intel/isl/isl.c
On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> @@ -237,19 +268,35 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig
> *dri_config, int id,
> break;
>
>case __DRI_ATTRIB_RED_MASK:
> - dri_masks[0] = value;
> + dri_shifts[0] = ffs(value) - 1;
>
On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> This series enables fp16 fbconfigs and visuals by leveraging existing
> off-screen rendering support.
>
> These formats can be used in conjunction with EXT_surface_SMPTE2086_metadata
> (not yet implemented by any drivers) to support
On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> Expose configs when allow_fp16_configs has been enabled and
> DRI_LOADER_CAP_FP16 is set in the loader.
>
> Also, make kms_swrast_dri respect format bpp, to allow for allocating
> buffers wider than 32 bpp.
Was this the only offender?
-
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/171
Depends on
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/121, only the
last three commits are new.
Caio Marcelo de Oliveira Filho (3):
nir/copy_prop_vars: add tests for indirect array deref
nir/copy_prop_vars:
https://bugs.freedesktop.org/show_bug.cgi?id=109229
--- Comment #10 from smt ---
Not the poster of this bug but a couple of us have tested this and indeed Godot
appears to be running fine now, thank you very much
--
You are receiving this mail because:
You are the assignee for the
Reviewed-by: Ilia Mirkin
Note - not sure that initializing pad is necessary. And there's a
handful of fields missing (like the draw id comes to mind). But ...
it's not important. Sorry again for the screwup!
On Tue, Jan 29, 2019 at 4:17 PM Brian Paul wrote:
>
> LGTM. Reviewed-by: Brian Paul
That shouldn't change anything as we check if the last
subpass id is the final subpass.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
The Vulkan spec says:
"If pResolveAttachments is not NULL, for each resolve attachment
that does not have the value VK_ATTACHMENT_UNUSED, the
corresponding color attachment must not have the value
VK_ATTACHMENT_UNUSED."
Signed-off-by: Samuel Pitoiset
---
The different masks should be accumulated. For example if two
subpasses declare an outgoing dependency (ie. dst ==
VK_SUBPASS_EXTERNAL).
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Instead of doing them in radv_cmd_buffer_set_subpass().
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 44 +--
src/amd/vulkan/radv_meta_clear.c | 5 +--
src/amd/vulkan/radv_meta_resolve.c| 2 +-
src/amd/vulkan/radv_meta_resolve_fs.c
Original patch by Fredrik Höglund.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 16 +++-
src/amd/vulkan/radv_pass.c | 6 --
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
We don't use that.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_blit.c | 12 ++--
src/amd/vulkan/radv_meta_blit2d.c | 12 ++--
src/amd/vulkan/radv_meta_clear.c | 8
src/amd/vulkan/radv_meta_resolve_fs.c | 4 ++--
4 files changed, 18
To share common code that handles subpass dependencies.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 78 +++---
1 file changed, 38 insertions(+), 40 deletions(-)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 440f09a363c..914ff0055d9 100644
---
LGTM. Reviewed-by: Brian Paul
I'll push this tomorrow, or after Ilia reviews too.
On 01/29/2019 12:21 PM, Neha Bhende wrote:
> We need to initialize all fields in rs->prim explicitly while
> creating new rastpos stage.
>
> Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 3 +++
src/amd/vulkan/radv_pipeline.c | 10 +-
src/amd/vulkan/radv_private.h | 3 +++
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index
Outgoing dependencies (ie. external) should happen after the subpass.
This doesn't change anything for subpass resolves as we already
make sure that attachments are shader readable.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2
radv_render_pass_compile() is common to vkCreateRenderPass()
and vkCreateRenderPass2().
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 66 ++
1 file changed, 38 insertions(+), 28 deletions(-)
diff --git a/src/amd/vulkan/radv_pass.c
In case two or more subpasses declare ingoing external dependencies.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index 0a37392322f..08ea2454750 100644
---
To unify some code in BeginRenderPass() and NextSubpass().
Based on Intel ANV driver.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 44 +++-
1 file changed, 32 insertions(+), 12 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
Hi,
My plan is to rework transitions a bit and improve them. Like initializing
all undefined layouts in one shot instead of syncing inbetween. Also,
some subpass clears can be merged when the driver already initializes
metadata, and probably more.
This series is just a first step that cleanups
This reworks how the depth stencil attachment is used for
simplicity. This also introduces radv_render_pass_compile()
helper that will be used for further optimizations.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 16 +++---
src/amd/vulkan/radv_meta_clear.c |
To share common code between CmdEndRenderPass() and
CmdNextSubpass().
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 70 +---
1 file changed, 38 insertions(+), 32 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c| 12
src/amd/vulkan/radv_private.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index 1102ef689b2..ac9f9381216 100644
---
Trivial.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 5ecaf829cb0..dcd20595eeb 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++
Trivial.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c| 10 --
src/amd/vulkan/radv_private.h | 1 -
2 files changed, 11 deletions(-)
diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index 3652eb7ce69..3a70006f6bb 100644
---
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 7f7f052986e..5ecaf829cb0 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++
Emil Velikov writes:
> From: Emil Velikov
>
> Earlier commit addressed 7 of the 8 instances available.
>
> Cc: Carsten Haitzler (Rasterman)
> Cc: Eric Anholt
> Fixes: 300d3ae8b14 ("vc4: Declare the cpu pointers as being modified in NEON
> asm.")
> Signed-off-by: Emil Velikov
> ---
> Gents
Rich Felker writes:
> On Tue, Jan 29, 2019 at 08:29:32AM +0100, Patrick Steinhardt wrote:
>> On Mon, Jan 28, 2019 at 02:09:18PM -0800, Dylan Baker wrote:
>> > Quoting Adam Jackson (2019-01-28 09:00:13)
>> > > On Sat, 2019-01-26 at 13:56 +0100, Patrick Steinhardt wrote:
>> > >
>> > > >
We need to initialize all fields in rs->prim explicitly while
creating new rastpos stage.
Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with GL_SELECT
feedback")
v2: Initializing all fields in rs->prim as per Ilia.
Reviewed-by: Brian Paul
---
> Would it be wise to just initialize everything explicitly? For example
> this is what _mesa_draw_arrays does:
>
>memset(, 0, sizeof(prim));
>prim.begin = 1;
>prim.end = 1;
>prim.mode = mode;
>prim.num_instances = numInstances;
>prim.base_instance = baseInstance;
>
Would it be wise to just initialize everything explicitly? For example
this is what _mesa_draw_arrays does:
memset(, 0, sizeof(prim));
prim.begin = 1;
prim.end = 1;
prim.mode = mode;
prim.num_instances = numInstances;
prim.base_instance = baseInstance;
prim.draw_id = drawID;
On 01/29/2019 11:34 AM, Neha Bhende wrote:
> This patch fixes regression caused by
> bac8534267- st/mesa: allow glDrawElements to work with GL_SELECT feedback
> We also need to set instance count while creating new rastpos stage.
I forgot to previously mention, you should have a line like this in
This patch fixes regression caused by
bac8534267- st/mesa: allow glDrawElements to work with GL_SELECT feedback
We also need to set instance count while creating new rastpos stage.
Reviewed-by: Brian Paul
---
src/mesa/state_tracker/st_cb_rasterpos.c | 1 +
1 file changed, 1 insertion(+)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=109393
--- Comment #1 from Jaap Buurman ---
Still happening with Mesa 18.3.2, LVM 7.0.1 and 4.20.5 kernel.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
On Tue, 2019-01-29 at 17:51 +0100, Mario Kleiner wrote:
> Thanks for the quick review!
>
> Patchwork didn't pick the r-b's up though. Do i need to do anything /
> ping somebody to get those merged to master ideally before the close
> 19.0 branchpoint and not overlooked?
I've created a merge
From: Emil Velikov
Earlier commit addressed 7 of the 8 instances available.
Cc: Carsten Haitzler (Rasterman)
Cc: Eric Anholt
Fixes: 300d3ae8b14 ("vc4: Declare the cpu pointers as being modified in NEON
asm.")
Signed-off-by: Emil Velikov
---
Gents my ARM assembly is limited so a confirmation
On Fri, Jan 25, 2019 at 02:15:25PM -0600, Jason Ekstrand wrote:
> On Fri, Jan 25, 2019 at 1:53 PM Stéphane Marchesin <
> stephane.marche...@gmail.com> wrote:
>
> > On Fri, Jan 25, 2019 at 2:25 AM Gert Wollny wrote:
> > >
> > > Am Donnerstag, den 24.01.2019, 22:25 -0800 schrieb Stéphane
Thanks for the quick review!
Patchwork didn't pick the r-b's up though. Do i need to do anything /
ping somebody to get those merged to master ideally before the close
19.0 branchpoint and not overlooked?
thanks,
-mario
On Tue, Jan 29, 2019 at 5:13 PM Daniel Stone wrote:
>
> Hi,
>
> On Tue, 29
On Tue, 2019-01-29 at 14:41 +, Roland Scheidegger wrote:
> Am 29.01.19 um 10:10 schrieb Erik Faye-Lund:
> > On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote:
> > > Use the trick of adding and then subtracting 2**52 (52 is the
> > > number
> > > of
> > > explicit mantissa bits a
Hi,
On Tue, 29 Jan 2019 at 16:05, Adam Jackson wrote:
> On Tue, 2019-01-29 at 14:45 +0100, Mario Kleiner wrote:
> > could i get some review of the last two missing patches of mine for
> > depth 30 support in Mesa's egl/wayland wl-drm backend? They are over
> > six months old now, well-tested at
On Tue, 2019-01-29 at 14:45 +0100, Mario Kleiner wrote:
> Hi,
>
> could i get some review of the last two missing patches of mine for
> depth 30 support in Mesa's egl/wayland wl-drm backend? They are over
> six months old now, well-tested at time of original submission:
>
>
On January 29, 2019 05:27:50 Iago Toral wrote:
On Thu, 2019-01-17 at 18:18 -0600, Jason Ekstrand wrote:
On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga wrote:
Reviewed-by: Topi Pohjolainen
---
.../compiler/brw_fs_combine_constants.cpp | 60 +++
1 file changed, 49
Am 29.01.19 um 10:10 schrieb Erik Faye-Lund:
> On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote:
>> Use the trick of adding and then subtracting 2**52 (52 is the number
>> of
>> explicit mantissa bits a double-precision floating-point value has)
>> to
>> implement round-to-even.
>>
>> Cuts the
Hi,
could i get some review of the last two missing patches of mine for
depth 30 support in Mesa's egl/wayland wl-drm backend? They are over
six months old now, well-tested at time of original submission:
https://patchwork.freedesktop.org/project/mesa/list/?submitter=14956
Would be good to get
On Thu, 2019-01-17 at 18:18 -0600, Jason Ekstrand wrote:
> On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga > wrote:
> > Reviewed-by: Topi Pohjolainen
> >
> > ---
> >
> > .../compiler/brw_fs_combine_constants.cpp | 60
> > +++
> >
> > 1 file changed, 49 insertions(+),
On Monday, 2019-01-28 14:29:00 -0500, Ilia Mirkin wrote:
> 2. I've seen a bunch of things land where I would have had comments
> beforehand. Once the patch is in, I don't really have an easy way to
> provide feedback. In the past if such a thing would happen, I just
> take the subject of the
On Monday, January 28, 2019 11:29:00 AM PST Ilia Mirkin wrote:
> A few thoughts. Given past experience, I don't really expect these to
> have any serious impact on the direction taken, but I also don't want
> to just sit brooding in silence. Please note that full time/paid
> contributors probably
On Tue, 2019-01-29 at 10:10 +0100, Erik Faye-Lund wrote:
> On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote:
> > Use the trick of adding and then subtracting 2**52 (52 is the number
> > of
> > explicit mantissa bits a double-precision floating-point value has)
> > to
> > implement
On Mon, Jan 28, 2019 at 02:09:18PM -0800, Dylan Baker wrote:
> Quoting Adam Jackson (2019-01-28 09:00:13)
> > On Sat, 2019-01-26 at 13:56 +0100, Patrick Steinhardt wrote:
> >
> > > Unfortunately, I'm not aware of any easy way to do this. The
> > > problem is not due to the compiler, as the
On Mon, 2019-01-28 at 17:20 -0500, Rob Clark wrote:
> On Mon, Jan 28, 2019 at 2:29 PM Ilia Mirkin
> wrote:
> > 2. I've seen a bunch of things land where I would have had comments
> > beforehand. Once the patch is in, I don't really have an easy way
> > to
> > provide feedback. In the past if such
On Tue, Jan 29, 2019 at 08:29:32AM +0100, Patrick Steinhardt wrote:
> On Mon, Jan 28, 2019 at 02:09:18PM -0800, Dylan Baker wrote:
> > Quoting Adam Jackson (2019-01-28 09:00:13)
> > > On Sat, 2019-01-26 at 13:56 +0100, Patrick Steinhardt wrote:
> > >
> > > > Unfortunately, I'm not aware of any
On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote:
> Use the trick of adding and then subtracting 2**52 (52 is the number
> of
> explicit mantissa bits a double-precision floating-point value has)
> to
> implement round-to-even.
>
> Cuts the number of instructions on SKL of the piglit test
>
On Mon, 2019-01-28 at 09:22 -0800, Eric Anholt wrote:
> Erik Faye-Lund writes:
>
> > On Fri, 2019-01-25 at 13:41 -0800, Eric Anholt wrote:
> > > Nick Kreeger writes:
> > >
> > > > The OES_texture* extensions for float and half-float are valid
> > > > when
> > > > GLES2 is present w/ the
https://bugs.freedesktop.org/show_bug.cgi?id=109258
--- Comment #8 from Pekka Paalanen ---
Eric, are you sure software render was never implemented?
I am pretty sure that if you bring up EGL GBM platform and you miss a hardware
driver, it will use llvmpipe and it will get stuff on screen (even
68 matches
Mail list logo
