[Mesa-dev] [Bug 111039] [radv] - Persona 5 in RPCS3 emulator has glitches when using hardware fp16 (LLVM 9)

https://bugs.freedesktop.org/show_bug.cgi?id=111039 Bug ID: 111039 Summary: [radv] - Persona 5 in RPCS3 emulator has glitches when using hardware fp16 (LLVM 9) Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] radeonsi: glmark2 - regression (GL_INVALID_OPERATION in glFramebufferTexture2D) - bisected

Hello Emil et al., sorry Emil you were NOT the right person to blame for this - see below. Am 22.06.2019 04:55, schrieb Dieter Nützel: Hello Emil, I see glmark2 - [desktop] blur-radius=5 libpng warning: iCCP: known incorrect sRGB profile Mesa: User error: GL_INVALID_OPERATION in

[Mesa-dev] [Bug 111019] radv doesn't handle variable descriptor count properly

https://bugs.freedesktop.org/show_bug.cgi?id=111019 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 5/5] anv: disable repacking for compression for applicable gen

On Thu, Jun 27, 2019 at 9:55 AM Dongwon Kim wrote: > > set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register Repacking With minor nits fixed. This series is: Reviewed-by: Anuj Phogat I'll push the series after testing with these changes. Thanks for the patches :) > if the gen

Re: [Mesa-dev] [PATCH 4/5] iris: disable repacking for compression for applicable gen

On Thu, Jun 27, 2019 at 9:55 AM Dongwon Kim wrote: > > set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register Repacking > if the gen attribute, 'disable_ccs_repack' is set. > > Signed-off-by: Dongwon Kim > --- > src/gallium/drivers/iris/iris_state.c | 10 ++ > 1 file

Re: [Mesa-dev] [PATCH 3/5] i965: disable repacking for compression for applicable gen

On Thu, Jun 27, 2019 at 9:55 AM Dongwon Kim wrote: > > set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register Disable Repacking > if the gen attribute, 'disable_ccs_repack' is set. > > Signed-off-by: Dongwon Kim > --- > src/mesa/drivers/dri/i965/brw_defines.h | 1 + >

Re: [Mesa-dev] [PATCH 2/5] intel: add disable_ccs_repack to gen_device_info

On Thu, Jun 27, 2019 at 9:55 AM Dongwon Kim wrote: > > add a new attribute, 'disable_ccs_repack' to gen_device info, which > indicates whether repacking of components in certain pixel formats > before compression needs to be disabled to keep the compatibility > with decompression capability of

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

https://bugs.freedesktop.org/show_bug.cgi?id=110345 Francisco Pina Martins changed: What|Removed |Added CC||f.pinamart...@gmail.com --

Re: [Mesa-dev] What does WIP really mean in an MR?

On Sat, Jun 29, 2019 at 4:40 PM Eric Engestrom wrote: > > On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: > > > > On 29/6/19 2:30, Rob Clark wrote: > > > I had interpreted it as literally the "block the gitlab merge button" > > > option, ie. "I want to get feedback but it is not ready to

Re: [Mesa-dev] [PATCH v2 7/7] radv: enable DCC for layers on GFX8

r-b for the series On Mon, Jul 1, 2019 at 4:27 PM Samuel Pitoiset wrote: > > It's currently only enabled if dcc_slice_size is equal to > dcc_slice_fast_clear_size because the driver assumes that > portions of multiple layers are contiguous but it's not > always true. > > Still not supported on

Re: [Mesa-dev] [PATCH v2] panfrost: Add the sampled texture BO to the job

R-b, thank you! :) On Mon, Jul 01, 2019 at 07:04:44PM +0200, Boris Brezillon wrote: > Otherwise we get random use-after-{free,unmap} errors. > > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Move the panfrost_job_add_bo() call out of the loop > --- >

[Mesa-dev] [Bug 111016] Building Mesa GLX with Meson for macOS fails

https://bugs.freedesktop.org/show_bug.cgi?id=111016 --- Comment #5 from Dylan Baker --- I've proposed a fix here for the glx bits: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1222 You really should turn off xvmc and vdpau, as even if those happen to compile (which meson should

[Mesa-dev] [PATCH v2] panfrost: Add the sampled texture BO to the job

Otherwise we get random use-after-{free,unmap} errors. Signed-off-by: Boris Brezillon --- Changes in v2: - Move the panfrost_job_add_bo() call out of the loop --- src/gallium/drivers/panfrost/pan_context.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

https://bugs.freedesktop.org/show_bug.cgi?id=109258 Emil Velikov changed: What|Removed |Added Resolution|NOTABUG |--- Status|RESOLVED

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #6 from Stuart Naylor --- whoops xorg [rock@rockpi4 lib]$ cat /var/log/Xorg.0.log [ 1102.877] (--) Log file renamed from "/var/log/Xorg.pid-1950.log" to "/var/log/Xorg.0.log" [ 1102.878] X.Org X Server 1.20.5 X Protocol Version

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

(aarch64) 20190701 Desktop: LXQt Display Server: X Server 1.20.5 Compiler: GCC 8.3.0 Security: l1tf: Not affected + mds: Not affected + meltdown: Not affected + spec_store_bypass: Vulnerable

[Mesa-dev] radv: use rtld for shader uploads

Hey folks, the merge request at https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1220 moves radv to using the rtld for shader uploads for parity with radeonsi and to address some issues that arose with changes in LLVM behavior. Please review! Cheers, Nicolai -- Lerne, wie die Welt

Re: [Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

On Mon, 1 Jul 2019 08:28:03 -0700 Alyssa Rosenzweig wrote: > > > > @@ -848,6 +850,7 @@ panfrost_upload_tex( > > for (unsigned l = first_level; l <= last_level; ++l) { > > for (unsigned f = first_layer; f <= last_layer; ++f) { > > > > +

Re: [Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

> > @@ -848,6 +850,7 @@ panfrost_upload_tex( > for (unsigned l = first_level; l <= last_level; ++l) { > for (unsigned f = first_layer; f <= last_layer; ++f) { > > +panfrost_job_add_bo(job, rsrc->bo); >

[Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

Otherwise we get random use-after-{free,unmap} errors. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index

Re: [Mesa-dev] [PATCH 7/7] panfrost: Implement instanced rendering

> If you're interested, nouveau has logic to optionally go the shared > (1:N) or non-shared (1:1) way of doing it. Have a look at nvc0_vbo.c > if you're curious -- look for mentions of "shared". Hmm, I see. A bit more complex than I was hoping for the moment. signature.asc Description: PGP

Re: [Mesa-dev] [PATCH 7/7] panfrost: Implement instanced rendering

On Mon, Jul 1, 2019 at 10:56 AM Alyssa Rosenzweig wrote: > As a side effect, we rework how vertex buffers are handled, duplicating > them to be 1:1 with vertex descriptors to simplify instancing code paths > dramatically. This might be a performance regression, but this remains > to be seen; if

[Mesa-dev] [PATCH 2/7] panfrost: Implement dispatch helpers

Rather than open-coding workgroups_shift_* type fields, we include a general routine for packing the vertex/tiler/compute descriptor based on the provided dispatch parameters. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/meson.build | 1 +

[Mesa-dev] [PATCH 3/7] panfrost/midgard: Use the appropriate ld_attr type

Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index

[Mesa-dev] [PATCH 4/7] panfrost/midgard: Add unsigned ld/st ops

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard.h | 4 src/gallium/drivers/panfrost/midgard/midgard_compile.c | 4 +++- src/gallium/drivers/panfrost/midgard/midgard_ops.c | 4 3 files changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 6/7] panfrost/decode: Compute padded_num_vertices for MODULO

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pandecode/decode.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c b/src/gallium/drivers/panfrost/pandecode/decode.c index

[Mesa-dev] [PATCH 7/7] panfrost: Implement instanced rendering

We implement GLES3.0 instanced rendering with full support for instanced arrays (via instance divisors). To do so, we use the new invocation helpers to invoke a triplet of (1, vertex_count, instance_count), rather than simply (1, vertex_count, 1). We rewrite the attribute handling code into a new

[Mesa-dev] [PATCH 1/7] panfrost: Remove ancient comment

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/include/panfrost-job.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h b/src/gallium/drivers/panfrost/include/panfrost-job.h index 4abff22f33c..444e5ad9e69 100644 ---

[Mesa-dev] [PATCH 5/7] panfrost/midgard: Emit type appropriate ld_vary

Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 21 +-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index

[Mesa-dev] [PATCH v2 2/7] ac: compute the DCC fast clear size per slice on GFX8

v2: - add dcc_slice_fast_clear_size to be more confortable about RadeonSI Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_surface.c | 27 +++ src/amd/common/ac_surface.h | 1 + 2 files changed, 28 insertions(+) diff --git a/src/amd/common/ac_surface.c

[Mesa-dev] [PATCH v2 7/7] radv: enable DCC for layers on GFX8

It's currently only enabled if dcc_slice_size is equal to dcc_slice_fast_clear_size because the driver assumes that portions of multiple layers are contiguous but it's not always true. Still not supported on GFX9. v2: - only if dcc_slice_size == dcc_slice_fast_clear_size Signed-off-by: Samuel

[Mesa-dev] [PATCH v2 6/7] radv: do not enable DCC for mipmapped arrays because performance is worse

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 4099c57aa85..07d89d32edf 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -179,6

[Mesa-dev] [PATCH v2 5/7] radv: implement clearing DCC layers on GFX8

v2: - use dcc_slice_fast_clear_size Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 -- src/amd/vulkan/radv_meta_clear.c | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH v2 4/7] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

This will help for clearing DCC arrays because we need to know the subresource range. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 52 ++-- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/src/amd/vulkan/radv_meta_clear.c

[Mesa-dev] [PATCH v2 3/7] radv: add support for decompressing DCC layers with compute

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 104 +- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index a642d6243d4..d601686f8f6 100644 ---

[Mesa-dev] [PATCH v2 1/7] ac: compute the size of one DCC slice on GFX8

Addrlib doesn't provide this info. Because DCC is linear, at least on GFX8, it's easy to compute the size of one slice. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_surface.c | 6 ++ src/amd/common/ac_surface.h | 1 + 2 files changed, 7 insertions(+) diff --git

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

https://bugs.freedesktop.org/show_bug.cgi?id=109258 --- Comment #14 from Brendan King --- That block of code in platform_drm.c appears to be incorrect. The ForceSoftware flag is derived from the LIBGL_ALWAYS_SOFTWARE environment variable, but platform_drm uses GBM, with the DRM backend, which

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #4 from Stuart Naylor --- Apols in future I will add much more. I saw the ToDos i the error messages so was a bit half assed as expecting you know and are working on things. Its RK3399 Rockpi4 running Manjaro 19.04 they are

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #3 from Daniel Stone --- Could you please tell us which SoC you're running on? Knowing which GPU you actually have - Panfrost supports multiple different hardware generations - is pretty critical to finding out what's going on.

[Mesa-dev] [Bug 111026] TODO 5.2rc6 with mesa 19.1.1 on manjaro SLAVE FAULT

https://bugs.freedesktop.org/show_bug.cgi?id=111026 --- Comment #2 from Stuart Naylor --- Yeah I have and it seems like things are better still not completely fixed. But from first error with rc6 and rc6 it logged on and ran a firefox window. I got a feeling of wow this feels quite snappy and

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #2 from Stuart Naylor --- I am not sure with rc6 I would get a greeter but logon would throw out back to greeter with the error in #111026 rc7 no greeter and white screen that is continually flooding that error message. Just

[Mesa-dev] [Bug 111024] Commit 69f9fbab8a92a2bb797723f28fe8dad5cd8c8a64 breaks building mesa on Arch Linux.

https://bugs.freedesktop.org/show_bug.cgi?id=111024 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #1 from Daniel Stone --- Same comment as #111026. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 111026] TODO 5.2rc6 with mesa 19.1.1 on manjaro SLAVE FAULT

https://bugs.freedesktop.org/show_bug.cgi?id=111026 --- Comment #1 from Daniel Stone --- Can you please include the exact system you're running on (e.g. which GPU?), which kernel version, and the full dmesg output? You may also be better off trying Mesa master. -- You are receiving this mail

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

https://bugs.freedesktop.org/show_bug.cgi?id=111036 Bug ID: 111036 Summary: 5.2-rc7 19.1.1-1 repetitive error loop Product: Mesa Version: 19.1 Hardware: ARM OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 111023] build regression: ERROR: ['/usr/bin/python3']> is not a valid python

https://bugs.freedesktop.org/show_bug.cgi?id=111023 Sergii Romantsov changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

[Mesa-dev] [Bug 111023] build regression: ERROR: ['/usr/bin/python3']> is not a valid python

https://bugs.freedesktop.org/show_bug.cgi?id=111023 --- Comment #2 from Fabio Pedretti --- Indeed, with it it compiles, thanks. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [Bug 111023] build regression: ERROR: ['/usr/bin/python3']> is not a valid python

https://bugs.freedesktop.org/show_bug.cgi?id=111023 --- Comment #1 from Sergii Romantsov --- Hello, Fabia. Seems its meson-issue: https://github.com/mesonbuild/meson/issues/5422 Please, try to install package python3-distutils (at least on Ubuntu) -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 2/3] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

On Mon, Jul 1, 2019 at 2:15 PM Samuel Pitoiset wrote: > > > On 7/1/19 2:13 PM, Bas Nieuwenhuizen wrote: > > On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset > > wrote: > >> This will help for clearing DCC arrays because we need to know > >> the subresource range. > > How will it help? I don't

Re: [Mesa-dev] [PATCH 2/3] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

On 7/1/19 2:13 PM, Bas Nieuwenhuizen wrote: On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: This will help for clearing DCC arrays because we need to know the subresource range. How will it help? I don't think we use it in the next commit in the series? It will help for arrays, not

Re: [Mesa-dev] [PATCH 2/3] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > This will help for clearing DCC arrays because we need to know > the subresource range. How will it help? I don't think we use it in the next commit in the series? > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 3/3] radv: fix decompressing DCC levels with compute

r-b On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c >

Re: [Mesa-dev] [PATCH 1/3] radv: make sure to mark the image as compressed when clearing DCC levels

r-b On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > Found while working on DCC for arrays. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 22 ++ > src/amd/vulkan/radv_meta.h | 3 --- > src/amd/vulkan/radv_meta_clear.c | 10

Re: [Mesa-dev] [PATCH 4/4] radv: rework how the number of VGPRs is computed

r-b for the series On Wed, Jun 26, 2019 at 3:07 PM Samuel Pitoiset wrote: > > Just a cleanup, it shouldn't change anything. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 22 > src/amd/vulkan/radv_shader.c | 34

Re: [Mesa-dev] boolean usage in gallium

Yep. It's better to just use C99 bool everywhere. Jose On 30/06/2019 06:00, Marek Olšák wrote: > boolean predates c99 support in MSVC. I think there is no reason for > boolean in gallium now. > > Marek > > On Sat., Jun. 29, 2019, 00:09 Ilia Mirkin, > wrote: > >

Re: [Mesa-dev] [PATCH] panfrost: Rewrite u-interleaving code

Am 28.06.2019 um 22:56 schrieb Vasily Khoruzhick: On Tue, Jun 25, 2019 at 1:26 PM Alyssa Rosenzweig wrote: Rather than using a magic lookup table with no explanations, let's add liberal comments to the code to explain what this tiling scheme is and how to encode/decode it efficiently. It's

Re: [Mesa-dev] [PATCH] panfrost: Rewrite u-interleaving code

On Tue, Jun 25, 2019 at 1:26 PM Alyssa Rosenzweig wrote: > > Rather than using a magic lookup table with no explanations, let's add > liberal comments to the code to explain what this tiling scheme is and > how to encode/decode it efficiently. > > It's not so mysterious after all -- just