Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

On Tue, 11 Jun 2019 at 14:32, Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 10.06.19 um 15:56 schrieb Bas Nieuwenhuizen: > > On Sat, Jun 8, 2019 at 3:36 PM Alex Smith > wrote: > >> On Mon, 3 Jun 2019 at 13:27, Koenig, Christian < > christia

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

On Mon, 3 Jun 2019 at 13:27, Koenig, Christian wrote: > Am 03.06.19 um 14:21 schrieb Alex Smith: > > On Mon, 3 Jun 2019 at 11:57, Koenig, Christian > wrote: > >> Am 02.06.19 um 12:32 schrieb Alex Smith: >> > Put the uncached GTT type at a higher index than the

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

Thanks, will have a look - can't look right now, will see if I can sometime tomorrow. Alex On Mon, 3 Jun 2019 at 13:27, Koenig, Christian wrote: > Am 03.06.19 um 14:21 schrieb Alex Smith: > > On Mon, 3 Jun 2019 at 11:57, Koenig, Christian > wrote: > >> Am 02.06.19 um 12:

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

On Mon, 3 Jun 2019 at 11:57, Koenig, Christian wrote: > Am 02.06.19 um 12:32 schrieb Alex Smith: > > Put the uncached GTT type at a higher index than the visible VRAM type, > > rather than having GTT first. > > > > When we don't have dedicated VRAM, we don't have

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

On Sun, 2 Jun 2019 at 11:59, Bas Nieuwenhuizen wrote: > On Sun, Jun 2, 2019 at 12:32 PM Alex Smith > wrote: > > > > Put the uncached GTT type at a higher index than the visible VRAM type, > > rather than having GTT first. > > > > When we don't have dedicat

[Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

Ridge), this improves average FPS in the Rise of the Tomb Raider benchmark by up to ~30%. Tested a couple of other (Feral) games and saw similar improvement on those as well. Signed-off-by: Alex Smith --- I noticed that the memory types advertised on my Raven laptop looked a bit odd so played around

Re: [Mesa-dev] [PATCH v3 3/3] radv: add support for VK_EXT_memory_budget

Reviewed-by: Alex Smith for the series. On Wed, 9 Jan 2019 at 13:37, Samuel Pitoiset wrote: > A simple Vulkan extension that allows apps to query size and > usage of all exposed memory heaps. > > The different usage values are not really accurate because > they are per drm-fd,

Re: [Mesa-dev] [PATCH v2 3/3] radv: add support for VK_EXT_memory_budget

Thanks! I've played around with this a bit and it looks like it's behaving how I'd expect. One comment inline below... On Tue, 8 Jan 2019 at 15:17, Samuel Pitoiset wrote: > A simple Vulkan extension that allows apps to query size and > usage of all exposed memory heaps. > > The different usage

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

On Mon, 7 Jan 2019 at 17:20, Samuel Pitoiset wrote: > > On 1/7/19 6:06 PM, Alex Smith wrote: > > Hi Samuel, > > Thanks for implementing this - I've been wanting this extension for a > while so it's good it's finally available. > > This is just reporting the total heap

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

Hi Samuel, Thanks for implementing this - I've been wanting this extension for a while so it's good it's finally available. This is just reporting the total heap sizes as the budget, which is the same info we already get from the basic heap properties. The way I'd expected budget to work (and

Re: [Mesa-dev] [PATCH] radv: reset pending_reset_query when flushing caches

Reviewed-by: Alex Smith On Wed, 5 Dec 2018 at 10:32, Samuel Pitoiset wrote: > If the driver used a compute shader for resetting a query pool, > it should be completed when caches are flushed. > > This might reduce the number of stalls if operations are done > between vkCm

Re: [Mesa-dev] [PATCH] radv: Flush before vkCmdWriteTimestamp() if needed

CP DMA copies are not. I plan to change this at some point. > > Reviewed-by: Samuel Pitoiset > > On 12/5/18 10:52 AM, Alex Smith wrote: > > As done for vkCmdBeginQuery() already. Prevents timestamps from being > > overwritten by previous vkCmdResetQueryPool() calls if the shad

[Mesa-dev] [PATCH] radv: Flush before vkCmdWriteTimestamp() if needed

hader for resetting the query pool") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_query.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c index 550abe307a..e226bcef6a 100644 --- a/src/

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

On Tue, 4 Dec 2018 at 21:57, Bas Nieuwenhuizen wrote: > On Tue, Dec 4, 2018 at 4:52 PM Samuel Pitoiset > wrote: > > > > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > > safe to use it for timestamp queries. If we only wait on the low > > 32 bits of a timestamp query we could

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

Tested-by: Alex Smith Thanks! s/Queryool/QueryPool/ in the subject, btw. On Tue, 4 Dec 2018 at 15:52, Samuel Pitoiset wrote: > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > safe to use it for timestamp queries. If we only wait on the low > 32 bits of a timestamp

Re: [Mesa-dev] [PATCH] radv: Clamp gfx9 image view extents to the allocated image extents.

Tested-by: Alex Smith Confirmed it fixes both the testcase and the in-game bug it was causing. Thanks! On Tue, 27 Nov 2018 at 08:34, Samuel Pitoiset wrote: > cc stable? > > Reviewed-by: Samuel Pitoiset > > On 11/24/18 11:31 PM, Bas Nieuwenhuizen wrote: > > Mirrors AMDVLK

Re: [Mesa-dev] [PATCH] anv: Fix sanitization of stencil state when the depth test is disabled

In either case, > > Reviewed-by: Jason Ekstrand > > On Thu, Oct 25, 2018 at 5:25 AM Alex Smith > wrote: > >> When depth testing is disabled, we shouldn't pay attention to the >> specified depthCompareOp, and just treat it as always passing. Before, >> if

[Mesa-dev] [PATCH] anv: Fix sanitization of stencil state when the depth test is disabled

() would have incorrectly changed passOp to VK_STENCIL_OP_KEEP. Signed-off-by: Alex Smith --- src/intel/vulkan/genX_pipeline.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 33f1f7832a..877a9fb850

Re: [Mesa-dev] [PATCH] amd/common: check DRM version 3.27 for JPEG decode

Thanks, that's fixed it for me. On Tue, 23 Oct 2018 at 18:05, Liu, Leo wrote: > JPEG was added after DRM version 3.26 > > Signed-off-by: Leo Liu > Fixes: 4558758c51749(amd/common: add vcn jpeg ip info query) > Cc: Boyuan Zhang > Cc: Alex Smith > --- > src/amd/

Re: [Mesa-dev] [PATCH 13/15] amd/common: add vcn jpeg ip info query

Hi, With this commit, both radeonsi and radv fail to load for me with: amdgpu: amdgpu_query_hw_ip_info(vcn_jpeg) failed. If I comment out that query in ac_gpu_info.c, then they work again. I'm running kernel 4.18.7 with a Vega 64 - is the DRM version check on that correct? Thanks, Alex On

[Mesa-dev] [PATCH v2] anv: Allow presenting via a different GPU

and present to a display connected to an AMD card (tested HD 530 + Vega 64). v2: Rebase on current master. Signed-off-by: Alex Smith --- src/intel/vulkan/anv_wsi_x11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_wsi_x11.c b/src/intel/vulkan

[Mesa-dev] [PATCH] anv: Allow presenting via a different GPU

and present to a display connected to an AMD card (tested HD 530 + Vega 64). Signed-off-by: Alex Smith --- src/intel/vulkan/anv_wsi_x11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_wsi_x11.c b/src/intel/vulkan/anv_wsi_x11.c index 2feb5f1337

Re: [Mesa-dev] [PATCH] radv: Add support for VK_KHR_driver_properties.

This patch never landed in git, is that intentional? On Mon, 1 Oct 2018 at 17:46, Jason Ekstrand wrote: > On Sun, Sep 30, 2018 at 1:04 PM Bas Nieuwenhuizen > wrote: > >> --- >> src/amd/vulkan/radv_device.c | 27 +++ >> src/amd/vulkan/radv_extensions.py | 1 + >>

[Mesa-dev] [PATCH] ac/nir: Use context-specific LLVM types

uot; Fixes: 7e7ee82698 "ac: add support for 16bit buffer loads" Cc: "18.2" Signed-off-by: Alex Smith --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH] nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions

Fixes the garbage output I was seeing with bloom enabled. Thanks! Tested-by: Alex Smith On Wed, 3 Oct 2018 at 20:16, Jason Ekstrand wrote: > The ssa_for_alu_src helper will correctly handle swizzles and other > source modifiers for you. The expansions for unpack_hal

Re: [Mesa-dev] [PATCH] anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START

Fixes a crash I see on Broadwell. Tested-by: Alex Smith Cc to stable for 18.2? The crash is reproducible there as well. On Tue, 2 Oct 2018 at 23:25, Jason Ekstrand wrote: > Previously, we just went ahead and emitted MI_BATCH_BUFFER_START as > normal. If we are near enough to t

Re: [Mesa-dev] [PATCH] radv: use radeon_info::name

FWIW, putting "RADV" inside the brackets (e.g. " (RADV, LLVM ...)") would still work for us. On 17 August 2018 at 10:38, Samuel Pitoiset wrote: > Yeah, ignore this patch. > > On 8/17/18 11:25 AM, Alex Smith wrote: > >> All of our Vulkan games re

Re: [Mesa-dev] [PATCH] radv: use radeon_info::name

All of our Vulkan games rely on the presence of "RADV" somewhere in the device name string to distinguish between RADV and AMDVLK/GPU-PRO, and that's used to check whether the driver version is supported, whether to enable bug workarounds, etc. This will certainly break that. Thanks, Alex On 17

[Mesa-dev] [PATCH v2] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

According to the spec, these should apply to all read/write access types (so would be equivalent to specifying all other access types individually). Currently, they were doing nothing. v2: Handle VK_ACCESS_MEMORY_WRITE_BIT in dstAccessMask. Signed-off-by: Alex Smith Cc: mesa-sta

Re: [Mesa-dev] [PATCH] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

On 20 July 2018 at 19:01, Jason Ekstrand wrote: > On Fri, Jul 20, 2018 at 8:37 AM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 20/07/18 11:44, Alex Smith wrote: >> >> According to the spec, these should apply to all read/write access

[Mesa-dev] [PATCH] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

According to the spec, these should apply to all read/write access types (so would be equivalent to specifying all other access types individually). Currently, they were doing nothing. Signed-off-by: Alex Smith Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_private.h | 6

Re: [Mesa-dev] [PATCH] radv: optimize vkCmd{Set, Reset}Event() a little bit

FWIW none of our released Vulkan games will be using these functions. On 29 June 2018 at 03:28, Dieter Nützel wrote: > Tested-by: Dieter Nützel > > on RX 580 with F1 2017. > > Dieter > > > Am 28.06.2018 12:21, schrieb Samuel Pitoiset: > >> Always emitting a bottom-of-pipe event is quite dumb.

Re: [Mesa-dev] [PATCH 11/11] ac/radv: using tls to store llvm related info and speed up compiles (v3)

Hi Dave, I did a quick test with this on Rise of the Tomb Raider. It reduced the time taken to create all pipelines for the whole game over 8 threads (with RADV_DEBUG=nocache) from 12m24s to 11m35s. Nice improvement :) Also didn't see any issues, so: Tested-by: Alex Smith Thanks, Alex On 27

Re: [Mesa-dev] [PATCH mesa] radv: fix reported number of available VGPRs

Reviewed-by: Alex Smith On 15 June 2018 at 17:52, Eric Engestrom wrote: > It's a bit late to round up after an integer division. > > Fixes: de889794134e6245e08a2 "radv: Implement VK_AMD_shader_info" > Cc: Alex Smith > Signed-off-by: Eric Engestrom > --- > s

Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

Thanks, I've pushed it. On 8 June 2018 at 10:38, Lionel Landwerlin wrote: > Sorry for missing that. > > Fixes: e73d136a023080 ("vulkan/wsi/x11: Implement FIFO mode.") > Reviewed-by: Lionel Landwerlin > > > On 01/06/18 12:16, Cameron Kumar wrote: > >> The queue_manager thread can access the

Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

Any feedback on this? On 1 June 2018 at 12:16, Cameron Kumar wrote: > The queue_manager thread can access the images from x11_present_to_x11, > hence this reorder prevents dereferencing of dangling pointers. > > Cc: "18.1" > --- > src/vulkan/wsi/wsi_common_x11.c | 6 +++--- > 1 file changed,

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 1 June 2018 at 22:51, Dylan Baker wrote: > Quoting Samuel Pitoiset (2018-06-01 08:58:42) > > > > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > > > Quoting Alex Smith (2018-06-01 07:56:38) > > >> On 1 June 2018 at 15:48, Dylan Baker wrote: > &g

Re: [Mesa-dev] [PATCH] radv: Don't pass a TESS_EVAL shader when tesselation is not enabled.

Oops. Thanks for tracking that down. Reviewed-by: Alex Smith On 2 June 2018 at 13:31, Bas Nieuwenhuizen wrote: > Otherwise on pre-GFX9, if the constant layout allows both TESS_EVAL and > GEOMETRY shaders, but the PIPELINE has only GEOMETRY, it would return the > GEOMET

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 1 June 2018 at 16:58, Samuel Pitoiset wrote: > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > >> Quoting Alex Smith (2018-06-01 07:56:38) >> >>> On 1 June 2018 at 15:48, Dylan Baker wrote: >>> >>> Quoting Alex Smith (2018-

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 1 June 2018 at 15:48, Dylan Baker wrote: > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, but to the stages still > > present after merging if they were.

Re: [Mesa-dev] [PATCH 3/3] radv: Handle GFX9 merged shaders in radv_flush_constants()

On 31 May 2018 at 21:15, Bas Nieuwenhuizen wrote: > On Thu, May 31, 2018 at 5:44 PM, Alex Smith > wrote: > > This was not previously handled correctly. For example, > > push_constant_stages might only contain MESA_SHADER_VERTEX because > > only that stage was cha

[Mesa-dev] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

With GFX9 merged shaders, active_stages would be set to the original stages specified if shaders were not cached, but to the stages still present after merging if they were. Be consistent and use the original stages. Signed-off-by: Alex Smith Cc: "18.1" --- src/amd/vulkan/radv_pipe

[Mesa-dev] [PATCH 2/3] radv: Consolidate GFX9 merged shader lookup logic

This was being handled in a few different places, consolidate it into a single radv_get_shader() function. Signed-off-by: Alex Smith Cc: "18.1" --- src/amd/vulkan/radv_cmd_buffer.c | 20 src/amd/vulkan/radv_pipeline.c | 38 -

[Mesa-dev] [PATCH 3/3] radv: Handle GFX9 merged shaders in radv_flush_constants()

ade the address get emitted twice. Signed-off-by: Alex Smith Cc: "18.1" --- src/amd/vulkan/radv_cmd_buffer.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index da9591b9a5..c6a2d6c5b9 100

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Fix crash on shaders using MSAA image load/store

radeonsi doesn't support MSAA images. > > Marek > > On Wed, May 30, 2018 at 4:48 AM, Alex Smith > wrote: > >> The value returned by tgsi_util_get_texture_coord_dim() does not >> account for the sample index. This means image_fetch_coords() will not >> fetch it, lea

[Mesa-dev] [PATCH] radeonsi: Fix crash on shaders using MSAA image load/store

). Signed-off-by: Alex Smith Cc: "18.1" --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c index

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

Any more thoughts on this? Any objections to it going to stable as well (it fixes bugs, but is quite a large change)? Thanks, Alex On 19 April 2018 at 09:27, Matthew Nicholls wrote: > On 18/04/18 22:56, Dave Airlie wrote: > > On 18 April 2018 at 00:31, Matthew

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On 10 April 2018 at 15:49, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > > I don't know exactly what's causing it, no. I noticed the issue was > fixed on master so just bisected to this. > > >

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

est to catch this also but presumably you guys > don't actually know the exact shader combination thats tripping things up? > > > On 03/04/18 19:36, Samuel Pitoiset wrote: > >> This fixes a rendering issue with Wolfenstein 2 as well. A backport >> sounds reasonable to me. >>

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

Hi Timothy, This patch fixes some rendering issues I see with RADV on SI. It doesn't sound like it was really intended to fix anything, so possibly it's masking some other issue, but would you object to nominating the series for stable? Applying it on the 18.0 branch fixes the issue there as

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

On 16 March 2018 at 12:46, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > On Fri, 2018-03-16 at 13:40 +0100, Juan A. Suarez Romero wrote: > > On Fri, 2018-03-16 at 12:17 +0000, Alex Smith wrote: > > > Hi Juan, > > > > > > On 16 March 2018 at 11:42,

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

e0c6e8e9a44d7f8dccf96c5ac18f0f) > > squashed with > > configure/meson: Bump libdrm_amdgpu version requirement. > > (cherry picked from commit 52be440f48ac7c337f6604846bb6f0cfd88e7118) > > > commit 6ddf838def69036a48524e2f5ae79fb01170e59c > Author: Bas Nieuwenhuizen &

Re: [Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

On 13 March 2018 at 19:14, Dave Airlie <airl...@gmail.com> wrote: > On 13 March 2018 at 01:38, Alex Smith <asm...@feralinteractive.com> wrote: > > From the spec: > > > > "When copying between compressed and uncompressed formats the > > e

[Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

at we copy the correct number of layers for 2D to 3D copies. Fixes: 7b890a36 "radv: Fix vkCmdCopyImage for 2d slices into 3d Images" Cc: <mesa-sta...@lists.freedesktop.org> Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_meta_copy.c | 23 +++

Re: [Mesa-dev] [PATCH] radv: Increase the number of dynamic uniform buffers.

Tested-by: Alex Smith <asm...@feralinteractive.com> Thanks! On 9 March 2018 at 16:21, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > The vulkan API is not ideal as it does not allow us have a > shared limit. > > Feral needs 15+6 for one of their

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

Ping. Maybe it'd be better to just increase MAX_DYNAMIC_BUFFERS? I can't see any side effects of that other than increasing the size of radv_cmd_buffer? Alex On 5 March 2018 at 09:59, Alex Smith <asm...@feralinteractive.com> wrote: > I just checked what Rise of the Tomb Raider

Re: [Mesa-dev] [ANNOUNCE] mesa 18.0.0-rc4

Hi Emil, Just wondering what the status of the 18.0 release is? It's been almost a month since this last RC. Thanks, Alex On 5 March 2018 at 17:28, Ernst Sjöstrand wrote: > Is there a lot of new patches queued up before the 18.0 release? In > that case you could push them to

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

of either type? > > - Bas > > On Fri, Mar 2, 2018 at 4:28 PM, Alex Smith <asm...@feralinteractive.com> > wrote: > > These were set to MAX_DYNAMIC_BUFFERS / 2, which is too restrictive > > since an app may have it's total usage of both uniform and storage > > wi

Re: [Mesa-dev] [Mesa-stable] [PATCH] [RFC] gallivm: Use new LLVM fast-math-flags API

Hi Emil, On 2 March 2018 at 18:38, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Alex, > > On 28 February 2018 at 15:25, Alex Smith <asm...@feralinteractive.com> > wrote: > > Hi, > > > > Could this (commit 5d61fa4e68b7eb6d481a37efdbb35fdce675a6ad

[Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

ed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 36d7a406bf..1e81ddb891 100644 --- a/src/amd/vulkan/radv_device.c +

Re: [Mesa-dev] [PATCH] radv: do not set pending_reset_query in BeginCommandBuffer()

Reviewed-by: Alex Smith <asm...@feralinteractive.com> On 1 March 2018 at 09:53, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > This is just useless for two reasons: > 1) flush_bits is not set accordingly, so nothing will be flushed >in BeginQuery(). > 2

Re: [Mesa-dev] [PATCH v3] radv: make sure to emit cache flushes before starting a query

Hi Samuel, On 28 February 2018 at 20:47, Samuel Pitoiset wrote: > If the query pool has been previously resetted using the compute > shader path. > > v3: set pending_reset_query only for the compute shader path > v2: handle multiple commands buffers with same pool > >

Re: [Mesa-dev] [PATCH] [RFC] gallivm: Use new LLVM fast-math-flags API

Hi, Could this (commit 5d61fa4e68b7eb6d481a37efdbb35fdce675a6ad on master) be backported to the 17.3 branch to allow it to build with LLVM 6? Thanks, Alex On 6 November 2017 at 21:16, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Mon,

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

That commit is "anv/pipeline: Don't assert on more than 32 samplers"? https://cgit.freedesktop.org/mesa/mesa/commit/?id=4b69ba381766cd911eb1284f1b0332a139ec8a75 On 25 January 2018 at 22:53, Jason Ekstrand wrote: > It landed as 4b69ba381766cd911eb1284f1b0332a139ec8a75 > >

Re: [Mesa-dev] [PATCH 3/4] ac/nir: set amdgpu.uniform and invariant.load for UBOs

Tested-by: Alex Smith <asm...@feralinteractive.com> This fixes a regression seen after 41c36c45 ("amd/common: use ac_build_buffer_load() for emitting UBO loads"). On 24 January 2018 at 22:26, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > UBOs are constant

Re: [Mesa-dev] [PATCH] radv: restore previous stencil reference after depth-stencil clear

Reviewed-by: Alex Smith <asm...@feralinteractive.com> On 19 January 2018 at 15:14, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > > > On 01/19/2018 03:11 PM, Matthew Nicholls wrote: > >>

Re: [Mesa-dev] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

Oops, sorry about that. Reviewed-by: Alex Smith <asm...@feralinteractive.com> On 18 January 2018 at 01:16, Jason Ekstrand <ja...@jlekstrand.net> wrote: > Without this, we may end up dereferencing blend before we check for > binding->index != UINT32_MAX. However, Vulkan a

Re: [Mesa-dev] [PATCH 2/2] [rfc] radv: inline push constants where possible. (v2)

} else { > + user_sgpr_info->num_inline_push_consts > = remaining_sgprs; > + } > + > + if (user_sgpr_info->num_inline_push_consts > > AC_UD_MAX_INLINE_PUSH_CONST) &g

Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

Hi Dave, This seems to cause some breakage when both push constants and dynamic descriptors are used. I've commented 2 fixes inline below needed to avoid a crash, but with those F1 2017 will still hang pretty quick before the main menu, not sure why so far. Mad Max is OK but that doesn't use

Re: [Mesa-dev] [PATCH] anv: Make sure state on primary is correct after CmdExecuteCommands

Thanks Jason. I take it you didn't find any other state that needed resetting then? Alex On 9 January 2018 at 16:49, Jason Ekstrand <ja...@jlekstrand.net> wrote: > From: Alex Smith <asm...@feralinteractive.com> > > After executing a secondary command buffer, we need to u

Re: [Mesa-dev] [PATCH] spirv: Use correct type for sampled images

On 6 January 2018 at 01:03, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Nov 7, 2017 at 3:08 AM, Alex Smith <asm...@feralinteractive.com> > wrote: > >> Thanks Jason. Can someone push this? >> > > Did you never get

Re: [Mesa-dev] [PATCH v2] anv: Allow PMA optimization to be enabled in secondary command buffers

On 5 January 2018 at 21:43, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, Jan 5, 2018 at 9:06 AM, Alex Smith <asm...@feralinteractive.com> > wrote: > >> This was never enabled in secondary buffers because hiz_enabled was >> never set to true for

[Mesa-dev] [PATCH v2] anv: Allow PMA optimization to be enabled in secondary command buffers

the command buffer. This improves performance by ~13% on an internal benchmark on Skylake. v2: Use anv_cmd_buffer_get_depth_stencil_view(). Signed-off-by: Alex Smith <asm...@feralinteractive.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/genX_cmd_b

Re: [Mesa-dev] [PATCH] anv: Allow PMA optimization to enabled in secondary command buffers

> > Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > > Thanks! > > > On 05/01/18 11:20, Alex Smith wrote: > >> This was never enabled in secondary buffers because hiz_enabled was >> never set to true for those. >> >> If the

[Mesa-dev] [PATCH] anv: Allow PMA optimization to enabled in secondary command buffers

the command buffer. This improves performance by ~13% on an internal benchmark on Skylake. Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/intel/vulkan/genX_cmd_buffer.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/

[Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

into account in this function. This is consistent with how things are done on i965. Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/genX_pipeline.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH] anv: Make sure state on primary is correct after CmdExecuteCommands

command buffers in some cases. Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/genX_cmd_buffer.c | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_bu

[Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

Fixes hangs seen due to the lock not being released here. Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_allocator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_allocat

Re: [Mesa-dev] radv: gfx9 3d image fixes

Nice - this does fix the issue I was seeing, thanks. Can at least patches 2 and 3 go to stable? On 21 December 2017 at 01:50, Dave Airlie wrote: > This series fixes about 340 CTS tests on Vega that involve 3D images. > > The two main things are to use 3D samplers for copy

Re: [Mesa-dev] [PATCH] radv/gfx9: add 3d sampler image->buffer copy shader. (v2)

samplers) is expected to work - see VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR. Is there no way to make that work on GFX9? Thanks, Alex On 20 December 2017 at 14:49, Alex Smith <asm...@feralinteractive.com> wrote: > Tested-by: Alex Smith <asm...@feralinteractive.com> > > Fixe

Re: [Mesa-dev] [PATCH] radv/gfx9: add 3d sampler image->buffer copy shader. (v2)

Tested-by: Alex Smith <asm...@feralinteractive.com> Fixes 3D texture contents being captured incorrectly in RenderDoc for me. On 19 December 2017 at 07:36, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > On GFX9 we must access 3

Re: [Mesa-dev] [PATCH] Revert "radv: do not load unused gl_LocalInvocationID/gl_WorkGroupID components"

Tested-by: Alex Smith <asm...@feralinteractive.com> On 15 December 2017 at 15:01, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > This reverts commit 2294d35b243dee15af15895e876a63b7d22e48cc. > > We can't do this without adjusting the input SGPRs/VGPRs logic. > Fo

Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of bitfield_insert

Pushed. On 6 December 2017 at 17:35, Matt Turner wrote: > On Wed, Dec 6, 2017 at 3:55 AM, James Legg > wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104119 > > CC: > > CC: Samuel Pitoiset

[Mesa-dev] [PATCH] radv: Add LLVM version to the device name string

Allows apps to determine the LLVM version so that they can decide whether or not to enable workarounds for LLVM issues. Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: "17.2 17.3" <mesa-sta...@lists.freedesktop.org> --- src/amd/vulk

Re: [Mesa-dev] [PATCH] nir/spirv: tg4 requires a sampler

apply for commit access. :-) > > On Tue, Nov 7, 2017 at 2:52 AM, Alex Smith <asm...@feralinteractive.com> > wrote: > >> Gather operations in both GLSL and SPIR-V require a sampler. Fixes >> gathers returning garbage when using separate texture/samplers (on AMD, >> was using an

Re: [Mesa-dev] [PATCH] spirv: Use correct type for sampled images

Thanks Jason. Can someone push this? On 6 November 2017 at 16:21, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Mon, Nov 6, 2017 at 2:37 AM, Alex Smith <asm...@feralinteractive.com> > wrote: > >> We should use the result type of the OpSampledImage opco

[Mesa-dev] [PATCH] nir/spirv: tg4 requires a sampler

Gather operations in both GLSL and SPIR-V require a sampler. Fixes gathers returning garbage when using separate texture/samplers (on AMD, was using an invalid sampler descriptor). Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: "17.2 17.3" <mesa-sta...@lists.freede

Re: [Mesa-dev] [PATCH] radv: force enable LLVM sisched for The Talos Principle

On 7 November 2017 at 09:28, Samuel Pitoiset wrote: > > > On 11/07/2017 10:18 AM, Michel Dänzer wrote: > >> On 07/11/17 10:08 AM, Samuel Pitoiset wrote: >> >>> It seems safe and it improves performance by +4% (73->76). >>> >>> Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] spirv: Use correct type for sampled images

to the wrong LLVM intrinsics being emitted by RADV. Signed-off-by: Alex Smith <asm...@feralinteractive.com> Cc: "17.2 17.3" <mesa-sta...@lists.freedesktop.org> --- src/compiler/spirv/spirv_to_nir.c | 10 -- src/compiler/spirv/vtn_private.h | 1 + src/compiler/spirv/vtn

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Thanks, Alex On 3 November 2017 at 10:02, Samuel Pitoiset wrote: > TC compatible HTILE only supports D32_SFLOAT on VI, while GFX9 > supports both.

[Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3] radv: Implement VK_AMD_shader_info

the shader debug info when we retrieve cached shaders. v2: Improvements to resource usage reporting v3: Disassembly string must be null terminated (string_buffer's length does not include the terminator) Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_de

[Mesa-dev] [PATCH v2] radv: Implement VK_AMD_shader_info

the shader debug info when we retrieve cached shaders. v2: Improvements to resource usage reporting Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_device.c | 9 ++ src/amd/vulkan/radv_extensions.py| 1 + src/amd/vulkan/radv_pipeline.c | 2 +

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_AMD_shader_info

On 25 October 2017 at 21:58, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > On Wed, Oct 25, 2017 at 4:03 PM, Samuel Pitoiset > <samuel.pitoi...@gmail.com> wrote: > > > > > > On 10/25/2017 02:20 PM, Alex Smith wrote: > >> > >> On 2

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_AMD_shader_info

x > > > On 10/25/2017 01:18 PM, Alex Smith wrote: > >> This allows an app to query shader statistics and get a disassembly of >> a shader. RenderDoc git has support for it, so this allows you to view >> shader disassembly from a capture. >> >> When thi

[Mesa-dev] [PATCH 2/2] radv: Implement VK_AMD_shader_info

the shader debug info when we retrieve cached shaders. Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_device.c | 9 ++ src/amd/vulkan/radv_extensions.py| 1 + src/amd/vulkan/radv_pipeline.c | 2 +- src/amd/vulkan/radv_pipeline_cache.c

[Mesa-dev] [PATCH 1/2] vulkan: Update headers and registry to 1.0.64

Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- include/vulkan/vulkan.h| 50 +- src/vulkan/registry/vk.xml | 159 + 2 files changed, 181 insertions(+), 28 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/

Re: [Mesa-dev] [PATCH] ac/nir: generate correct instruction for atomic min/max on unsigned images

Forgot to add Cc: "17.2 17.3" On 25 October 2017 at 11:24, Matthew Nicholls < mnicho...@feralinteractive.com> wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH] radv: Update code pointer correctly if a variant is already created

her create all or none of the variants), but fix this anyway in case things change later. Signed-off-by: Alex Smith <asm...@feralinteractive.com> --- src/amd/vulkan/radv_pipeline_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline_cache.c

Re: [Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

euwenhuizen.nl> > > and pushed. Thanks. > > On Thu, Oct 19, 2017 at 12:49 PM, Alex Smith > <asm...@feralinteractive.com> wrote: > > Need to lock around the whole process of retrieving cached shaders, and > > around GetPipelineCacheData. > > > > This fi

  1   2   >