[Mesa-dev] [PATCH] anv/image: Fix VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT

We incorrectly detected VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT. We looked for the bit in VkImageCreateInfo::usage, but it's actually in VkImageCreateInfo::flags. Found by assertion failures while enabling VK_ANDROID_native_buffer. Cc: mesa-sta...@lists.freedesktop.org --- Can someone at Intel

Re: [Mesa-dev] [PATCH v3 12/14] i965: Pretend that CCS modified images are two planes

s_aux(uint64_t modifier) > +{ > + return isl_drm_modifier_get_info(modifier)->aux_usage != > ISL_AUX_USAGE_NONE; > +} Thanks for this improvement in v3. Reviewed-by: Chad Versace <chadvers...@chromium.org> If I missed any patches, let me know. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 11/14] i965/screen: Support import and export of surfaces with CCS

brw_bo_unreference(image->bo); > + free(image); > + return NULL; > + } Thanks for the comment. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 10/14] i965/miptree: Allocate mcs_buf for an image's CCS

t; Acked-by: Daniel Stone <dani...@collabora.com> > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 102 > -- > 1 file changed, 95 insertions(+), 7 deletions(-) LGTM Reviewed

Re: [Mesa-dev] [PATCH v3 08/14] i965: Support images with aux buffers

com> > --- > src/mesa/drivers/dri/i965/intel_image.h | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 05/14] i965/screen: Allocate ZEROED BOs for images

in the pass-through state which is what we want. > +*/ Bullet #2 should be postponed to a later patch, as the bo here does not contain an aux surface until later in the series. But that's a small nit. This is Reviewed-by: Chad Versace <chadvers...@chromium.org> > image

Re: [Mesa-dev] [PATCH v3 04/14] i965/bufmgr: Add a BO_ALLOC_ZEROED flag

-) > + /* All new BOs we get from the kernel are zeroed, so we don't need to > + * worry about that here. > + */ Assuming the above comment is true, then Reviewed-by: Chad Versace <chadvers...@chromium.org> >ret = drmIoctl(bufmgr->fd, DRM_IO

Re: [Mesa-dev] [PATCH v3 03/14] i965/miptree: Replace is_lossless_compressed with mt->aux_usage checks

intel_mipmap_tree.c| 39 > > src/mesa/drivers/dri/i965/intel_mipmap_tree.h| 4 --- > 5 files changed, 10 insertions(+), 41 deletions(-) Yes. This patch makes me feel more confident that this miptree code is correct. Reviewed-by: Ch

Re: [Mesa-dev] [PATCH v3 02/14] i965/miptree: Allocate HiZ up-front

-front. > --- I've read of rendering techniques that use high-quality, pre-rendered cascading shadow maps for scenes with fixed lights. And that would trigger the glTexSubImage2D case. But, even in that case, so little memory is wasted that I don't care. Reviewed-by: Chad Versac

Re: [Mesa-dev] [PATCH v3 01/14] i965/miptree: Gather initial aux allocation into a single function

struct intel_mipmap_tree *mt) This is much nicer. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 24/27] i965/screen: Support import and export of surfaces with CCS

On Fri 14 Jul 2017, Jason Ekstrand wrote: > On Fri, Jul 14, 2017 at 11:46 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 12 Jul 2017, Jason Ekstrand wrote: > > On Wed, Jul 12, 2017 at 11:18 AM, Chad Versace <[1][2] > If it's

Re: [Mesa-dev] [PATCH v2 22/27] i965/miptree: Allocate mcs_buf for an image's CCS

On Wed 12 Jul 2017, Jason Ekstrand wrote: > On Wed, Jul 12, 2017 at 11:05 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Thu 29 Jun 2017, Jason Ekstrand wrote: > Why require that aux_offset > 0? Why reject images where the aux surface > p

Re: [Mesa-dev] [PATCH v2 24/27] i965/screen: Support import and export of surfaces with CCS

On Wed 12 Jul 2017, Jason Ekstrand wrote: > On Wed, Jul 12, 2017 at 11:18 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Thu 29 Jun 2017, Jason Ekstrand wrote: > > Reviewed-by: Topi Pohjolainen <[2]topi.pohjolai...@intel.com> > > --

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

ulting in swapped colors. Based > on further investigation by Chad Versace, moving the RGBX/RGBA configs > to the end is enough to prevent breaking GLX. > > The handling of RGBA/RGBX in dri_fill_st_visual is a fix from Marek > Olšák. > > Cc: Eric Anholt <e...@anholt.net>

Re: [Mesa-dev] [PATCH v2 27/27] i965: Advertise the CCS modifier

; > +#ifndef I915_FORMAT_MOD_Y_TILED_CCS > +#define I915_FORMAT_MOD_Y_TILED_CCS fourcc_mod_code(INTEL, 4) > +#endif Due to this #define, the two instances in this patch of /* I915_FORMAT_MOD_Y_TILED_CCS */ fourcc_mod_code(INTEL, 4) can get cleaned up. With that, this is Reviewed-by:

Re: [Mesa-dev] [PATCH v2 26/27] i965/miptree: More conservatively resolve external images

used to > +* create or import the surface. > +*/ > + uint64_t drm_modifier; My natural question was "and what about non-external surfaces?". The question has a non-obvious answer since default initialization sets drm_modifier to a valid modifier (DRM_FORMAT_MOD_LINEAR

Re: [Mesa-dev] [PATCH v2 25/27] i965: Pretend that CCS modified images are two planes

case __DRI_IMAGE_ATTRIB_NUM_PLANES: > - *value = 1; > + *value = image->aux_offset ? 2 : 1; It makes me uncomfortable that we use image->aux_offset throughout the patch to detect the presence of an aux surface. It just feels wrong to me, and I'd like to se

Re: [Mesa-dev] [PATCH v2 24/27] i965/screen: Support import and export of surfaces with CCS

On Thu 29 Jun 2017, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_screen.c | 55 > +--- > 1 file changed, 50 insertions(+), 5 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 22/27] i965/miptree: Allocate mcs_buf for an image's CCS

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in > later if preferred. > >

Re: [Mesa-dev] [PATCH v2 21/27] i965: Support images with aux buffers

On Thu 29 Jun 2017, Jason Ekstrand wrote: > From: Ben Widawsky > > Previously images did not support any auxiliary compression surfaces > (CCS, MCS, or HiZ). That's about to change. This patch just adds the > fields to __DRIimageRec to make auxiliary surfaces possible. > >

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

On Mon 10 Jul 2017, Chad Versace wrote: > On Fri 07 Jul 2017, Rob Herring wrote: > > On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace <chadvers...@chromium.org> > > wrote: > > > On Fri 30 Jun 2017, Rob Herring wrote: > > >> Add support for 32-bit RGBX/R

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

On Fri 07 Jul 2017, Rob Herring wrote: > On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace <chadvers...@chromium.org> wrote: > > On Fri 30 Jun 2017, Rob Herring wrote: > >> Add support for 32-bit RGBX/RGBA formats which are required for Android. > >> > >&g

Re: [Mesa-dev] [PATCH v2 10/27] i965/miptree: Add a colorspace parameter to create_for_dri_image

map_tree.c | 24 ++-- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > src/mesa/drivers/dri/i965/intel_tex_image.c | 3 ++- > 4 files changed, 28 insertions(+), 5 deletions(-) I like this patch. Reviewed-by: Chad Versace &

Re: [Mesa-dev] [PATCH v2 09/27] main/formats: Add a get_linear_format_srgb helper

Patch 9 is Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 08/27] main/formats: Autogenerate _mesa_get_srgb_format_linear

LPHA8_ASTC_5x4x4 MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5x4 MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5x5 MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x5x5 MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6x5 MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6x6 With those two thin

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

oid. > > > > The original patch (commit ccdcf91104a5) was reverted (commit > > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > > on further investigation by Chad Versace, moving the RGBX/RGBA configs > > to the end is enough to prevent

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

On Fri 30 Jun 2017, Rob Herring wrote: > Add support for 32-bit RGBX/RGBA formats which are required for Android. > > The original patch (commit ccdcf91104a5) was reverted (commit > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > on further investigation

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

On Wed 28 Jun 2017, Rob Herring wrote: > On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > The new function takes a mesa_format and, if the format is an alpha > > format with a non-alpha variant, returns the non-alpha format. &

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

On Wed 28 Jun 2017, Rob Herring wrote: > On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > The new function takes a mesa_format and, if the format is an alpha > > format with a non-alpha variant, returns the non-alpha format. &

Re: [Mesa-dev] [PATCH 15/30] i965: Use create_for_dri_image in intel_update_image_buffer

Patches 14 and 15 are Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 16/30] i965/miptree: Move CCS allocation into create_for_dri_image

e same 'if' tree appears immediately above it. With the hunk de-duplicated, this patch is Reviewed-by: Chad Versace <chadvers...@chromium.org> > return mt; > } > > -- > 2.5.0.400.gff86faf > > ___ > mesa-dev maili

Re: [Mesa-dev] [PATCH 26/30] intel/isl: Add a row_pitch parameter to surf_get_ccs_surf

+--- > 4 files changed, 11 insertions(+), 6 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 23/30] intel/isl: Add support for I915_FORMAT_MOD_Y_TILED_CCS

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl_drm.c | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freede

Re: [Mesa-dev] [PATCH 22/30] i965/screen: Drop get_tiled_height

On Fri 16 Jun 2017, Jason Ekstrand wrote: > It's no longer used. And the tree still builds. Reviewed-by: Chad Versace <chadvers...@chromium.org> > --- > src/mesa/drivers/dri/i965/intel_screen.c | 20 +++- > 1 file changed, 3 insertion

Re: [Mesa-dev] [PATCH 21/30] i965/screen: Use ISL for doing image import checks

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_screen.c | 32 > > 1 file changed, 28 insertions(+), 4 deletions(-) This patch adds more code, but it's code I trust. Reviewed-by: Chad Versace <chadvers.

Re: [Mesa-dev] [PATCH 20/30] i965/screen: Use ISL for allocating image BOs

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_screen.c | 51 > ++-- > 1 file changed, 29 insertions(+), 22 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> __

Re: [Mesa-dev] [PATCH 19/30] intel/isl: Add a helper to convert tilings fro ISL to i915

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 3 +++ > src/intel/isl/isl_drm.c | 23 +++ > 2 files changed, 26 insertions(+) Reviewed-by: Chad Versace <chadvers...@chromium.org> __

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Wed 28 Jun 2017, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 02:05, Jason Ekstrand wrote: > > Would you feel more comfortable with a boolean sRGB parameter? That would > > make the answers to the above questions much more obvious at the cost of > > some code. > >

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

On Tue 27 Jun 2017, Jason Ekstrand wrote: > On Tue, Jun 27, 2017 at 12:19 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > &

Re: [Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

Daniel, I have a question for you below. On Tue 27 Jun 2017, Kenneth Graunke wrote: > On Tuesday, June 27, 2017 11:00:48 AM PDT Chad Versace wrote: > > The Android framework requires support for EGLConfigs with > > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. >

Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Improve the surface format support in the Wayland Vulkan WSI, by > automating the matching between wl_drm and Vulkan formats. The same > mechanism can be used to

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Introduce utilities to describe, find and compare Vulkan formats based > on their color component masks, taking into account system endianness. > --- >

Re: [Mesa-dev] [PATCH 18/30] intel/isl: Add basic modifier introspection

hanged, 83 insertions(+) > create mode 100644 src/intel/isl/isl_drm.c > +const struct isl_drm_modifier_info * ATTRIBUTE_CONST > +isl_drm_modifier_get_info(uint64_t modofier); Typo in 'modoifier'. Other than that, this patch is Reviewed-by: Chad Ver

Re: [Mesa-dev] [PATCH 17/30] i965: Add an isl_device to intel_screen

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ > src/mesa/drivers/dri/i965/intel_screen.h | 4 > 3 files changed, 8 insertions(+), 1 deletion(-) Patch 17 is Reviewed-b

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > src/mesa/drivers/dri/i965/intel_tex_image.c | 3 ++- > 4 files

Re: [Mesa-dev] [PATCH v2] mesa: Add _mesa_format_fallback_rgba_to_rgbx()

On Tue 20 Jun 2017, Jason Ekstrand wrote: > From: Chad Versace <chadvers...@chromium.org> > > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. &g

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Allows us to continue utilizing common miptree creation using __DRIimage > > without creating a new DRIimage (for the

[Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. Even though all RGBX formats are disabled on gen9 by brw_surface_formats.c, the new configs work correctly on Broxton thanks to _mesa_format_fallback_rgbx_to_rgba(). On GLX, this

[Mesa-dev] [PATCH 2/3] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

This enables support for importing RGBX EGLImage textures on Skylake. Chrome OS needs support for RGBX EGLImage textures because because the Android framework produces HAL_PIXEL_FORMAT_RGBX winsys surfaces, which the Chrome OS compositor consumes as dma_bufs. On hardware for which

[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

The new function takes a mesa_format and, if the format is an alpha format with a non-alpha variant, returns the non-alpha format. Otherwise, it returns the original format. Example: input -> output // Fallback exists MESA_FORMAT_R8G8B8X8_UNORM -> MESA_FORMAT_R8G8B8A8_UNORM

[Mesa-dev] [PATCH 0/3 v2] i965: Add RGBX, RGBA configs, even on gen9

ives on the tag http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/i965-r8g8b8x8-config-v02 Chad Versace (3): mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D() i965/dri: Support R8G8B8A8 and R8G8B8X8 configs src/m

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Mon 26 Jun 2017, Eero Tamminen wrote: > Hi, > > On 22.06.2017 23:14, Chad Versace wrote: > > On Thu 22 Jun 2017, Chad Versace wrote: > > > On Thu 22 Jun 2017, Kenneth Graunke wrote: > > > > The author eventually emailed me and said that he considers it a &g

Re: [Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

On Thu 22 Jun 2017, Jason Ekstrand wrote: > ACK Pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glapi: Fix -Wduplicate-decl-specifier due to double-const

Fix all lines in src/mesa/main/marshal_generated.c that declare double-const variables. Below is all such lines, with duplicates removed: $ grep 'const const' marshal_generated.c | sort -u const const GLboolean * pointer = cmd->pointer; const const GLvoid * indices = cmd->indices;

[Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

anv_layout_to_aux_usage() lacked a case for VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Add an unreachable case, because we don't support the extension. --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Thu 22 Jun 2017, Chad Versace wrote: > On Thu 22 Jun 2017, Kenneth Graunke wrote: > > The author eventually emailed me and said that he considers it a > > "finished experiment" and said the rendering method (geometry shader > > based approach) is inefficient,

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Thu 22 Jun 2017, Kenneth Graunke wrote: > The author eventually emailed me and said that he considers it a > "finished experiment" and said the rendering method (geometry shader > based approach) is inefficient, and he intends to fully rewrite it > someday. A total tangent... The author and I

Re: [Mesa-dev] [PATCH 11/30] i965/miptree: Add a return for updating of winsys

.com> > > Acked-by: Daniel Stone <dani...@collabora.com> > > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> (v2) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/10] egl: Little cleanups

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:46 BST, Chad Versace <chadvers...@chromium.org> wrote: > > No behavioral change. > > > > Chad Versace (10): > > egl/android: Declare loop vars inside their loops (v2) > > egl/drm: Move

Re: [Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:54 BST, Chad Versace <chadvers...@chromium.org> wrote: > > No behavioral change. Just a readability cleanup. > > > > Instead of modifying this small array on each loop iteration, we now > > initi

Re: [Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:55 BST, Chad Versace <chadvers...@chromium.org> wrote: > > No behavioral change. Just a readability cleanup. > > > > Instead of modifying this small array on each loop iteration, we now > > initi

Re: [Mesa-dev] [PATCH 10/30] i965: Use miptree_create_for_dri_image in image_target_renderbuffer_storage

e any problems. But it's nice to record in the git log just in case a bug bisects to here. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/30] i965/miptree: Set level_x/h in create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 08/30] i965/miptree: Add tile_x/y to total_width/height

does not alter the entropy. For consistency with intel_image_target_renderbuffer_storage(), and no other reason, this patch is Reviewed-by: Chad Versace <chadvers...@chromium.org> Please update the commit message to mention that at least mt->total_width is used. > src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 07/30] i965/miptree: Pass the offset into create_for_bo in create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 06/30] i965: Move the DRIimage -> miptree code to intel_mipmap_tree.c

65/intel_tex_image.c | 97 > +-- > 3 files changed, 97 insertions(+), 96 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 02/10] egl/drm: Move loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 37 +++-- 1 file changed, 15 insertions(+), 22

[Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c |

[Mesa-dev] [PATCH 07/10] egl/android: Declare EGLConfig attrib array inside loop (v2)

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. v2: Rebase. Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov ---

[Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c |

[Mesa-dev] [PATCH 10/10] egl: Rename 'count' in ${platform}_add_configs_for_visuals (v2)

Rename 'count' to 'config_count'. I didn't understand what the variable did until I untangled the for-loops. Now the next person won't have that problem. v2: Rebase. Fix typo. Apply to all platforms (for emil). Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov

[Mesa-dev] [PATCH 06/10] egl/dri2: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. This patch touches only egl_dri2.c. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 43 ++--- 1 file

[Mesa-dev] [PATCH 05/10] egl/wayland: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 44 + 1 file changed, 17 insertions(+), 27

[Mesa-dev] [PATCH 01/10] egl/android: Declare loop vars inside their loops (v2)

That is, consistently do this: for (int i = 0; ...) No behavioral change. v2: Rebase. Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 34 +++-- 1 file changed, 15

[Mesa-dev] [PATCH 03/10] egl/x11: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 04/10] egl/surfaceless: Move loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 00/10] egl: Little cleanups

No behavioral change. Chad Versace (10): egl/android: Declare loop vars inside their loops (v2) egl/drm: Move loop vars inside the loop egl/x11: Declare loop vars inside the loop egl/surfaceless: Move loop vars inside the loop egl/wayland: Declare loop vars inside the loop egl/dri2

Re: [Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

On Thu 22 Jun 2017, Rob Herring wrote: > On Tue, Jun 20, 2017 at 5:03 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > Many Android apps (such as Google's official NDK GLES2 example app), and > > even portions the core framework code (such as SystemServ

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Wed 21 Jun 2017, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 12:33 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > This commit replaces the complex and confusing set of disable flags with > &

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

On Tue 20 Jun 2017, Jason Ekstrand wrote: > On Wed, Jun 7, 2017 at 4:45 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Tue 06 Jun 2017, Daniel Stone wrote: > > Hi Chad, > > > > On 6 June 2017 at 21:36, Chad Versace <[

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This commit replaces the complex and confusing set of disable flags with > two fairly straightforward fields which describe the intended auxiliary > surface usage and whether or not the miptree supports fast clears. > Right now, supports_fast_clear can

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This commit replaces the complex and confusing set of disable flags with > two fairly straightforward fields which describe the intended auxiliary > surface usage and whether or not the miptree supports fast clears. > Right now, supports_fast_clear can

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

On Tue 20 Jun 2017, Jason Ekstrand wrote: > > > On Tue, Jun 20, 2017 at 3:24 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > While we're here, we also make the two support checks static since ther

Re: [Mesa-dev] [PATCH 04/30] i965: Clamp clear colors to the representable range

src/mesa/drivers/dri/i965/brw_meta_util.c | 40 > +++ > 1 file changed, 40 insertions(+) This reminded me that GL has no GL_UNSIGNED_FLOAT. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH 03/30] i965: Don't bother with HiZ in renderbuffer_move_to_temp

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This function is only used on gen4-5 which don't support HiZ. Yup. Did I write that code? Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

ly the same thing. In fact, we can probably drop the tiling check here. The miptree check should be sufficient (and if it's not, that's a bug in my opinion). Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/30] i965/miptree: Delete the layered rendering resolve

we can cross that bridge when we come to it. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 -- > 1 file changed, 14 deletions(-) Yep, do_single_blorp_clear() bails on layered renderbuffers. Reviewed-by: Chad Versace <

[Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

Many Android apps (such as Google's official NDK GLES2 example app), and even portions the core framework code (such as SystemServiceManager in Nougat), incorrectly choose their EGLConfig. They neglect to match the EGLConfig's EGL_NATIVE_VISUAL_ID against the window's native format, and instead

Re: [Mesa-dev] [PATCH 2/5] egl/android: Declare 'const' the EGLConfig attribs template array

On Tue 20 Jun 2017, Emil Velikov wrote: > On 17 June 2017 at 03:37, Chad Versace <chadvers...@chromium.org> wrote: > > No behavioral change. Just a cleanup. > > > > Post-patch, we no longer modify the same array on each iteration of the > > inner loop of droid_a

Re: [Mesa-dev] [PATCH 5/5] egl/android: Change order of EGLConfig generation

On Tue 20 Jun 2017, Emil Velikov wrote: > On 17 June 2017 at 03:37, Chad Versace <chadvers...@chromium.org> wrote: > > Many Android apps (such as Google's official NDK GLES2 example app), and > > even portions the core framework code (such as SystemServiceManager in > >

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Tue 20 Jun 2017, Eric Engestrom wrote: > On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote: > > On Tue 20 Jun 2017, Dave Airlie wrote: > > > > > I'm not sure why avoiding drmIoctl is even a thing, there are plenty > > > of huge optimisation opportuni

Re: [Mesa-dev] [PATCH] i965: Resolve framebuffers before signaling the fence

On Mon 19 Jun 2017, Chris Wilson wrote: > Quoting Chad Versace (2017-06-19 19:42:16) > > On Mon 12 Jun 2017, Chris Wilson wrote: > > > brw_emit_mi_flush(brw); > > > > > > switch (fence->type) { > > > @@ -335,6 +363,8 @@

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

On Tue 20 Jun 2017, Marathe, Yogesh wrote: > > From the framework's perspective, at least from the comments in > > aosp://system/core/include/system/window.h [1], it's legal to call > > ANativeWindow::queueBuffer with fenceFd=-1 if implicit sync is enabled. > > And, as far as I know, implicity

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Tue 20 Jun 2017, Dave Airlie wrote: > I'm not sure why avoiding drmIoctl is even a thing, there are plenty > of huge optimisation opportunities, this just seems like a feel good > pointless microptimisation. There is very little usage of libdrm remaining in i965. If the last bit were dropped,

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

On Fri 16 Jun 2017, Christian Gmeiner wrote: > 2017-06-16 14:54 GMT+02:00 Emil Velikov : > > On 15 June 2017 at 21:47, Robert Foss wrote: > >> From: Tomeu Vizoso > >> > >> Signed-off-by: Robert Foss

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On Thu 15 Jun 2017, Gurchetan Singh wrote: > Emil, would you be fine with leaving the image extension in dri2.c but still > adding it as a drisw extension?  That solution would look like: > > [1]https://patchwork.freedesktop.org/patch/154807/   Observations: -

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Mon 19 Jun 2017, Eric Engestrom wrote: > On Monday, 2017-06-19 09:41:13 -0700, Jason Ekstrand wrote: > > On Mon, Jun 19, 2017 at 7:43 AM, Chris Wilson > > wrote: > > > > > Just a cosmetic improvement, but quite straightforward. > > > > I think it's a bit hard to call

Re: [Mesa-dev] [PATCH] i965: Resolve framebuffers before signaling the fence

t;i965/sync: Implement DRI2_Fence extension") > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Sergi Granell <xerpi.g...@gmail.com> > Cc: Rob Clark <robdcl...@gmail.com> > Cc: Chad Versace <chadvers...@chromium.org> > Cc: Daniel Stone <dani

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

On Thu 15 Jun 2017, Eric Engestrom wrote: > On Thursday, 2017-06-15 16:17:20 -0400, Rob Clark wrote: > > On Thu, Jun 15, 2017 at 1:17 PM, Tapani Pälli > > wrote: > > > On 06/15/2017 07:57 PM, Rob Clark wrote: > > > > > > On Thu, Jun 15, 2017 at 12:04 PM, Tapani Pälli

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On Fri 16 Jun 2017, Chad Versace wrote: > On Thu 15 Jun 2017, Rob Herring wrote: > > While not i965, I tested the similar code and change in gallium. With > > the RGBA/RGBX formats at the end of the list I get: > > > > EGL-MAIN: Native format mismatch: 0x1 != 0x5

<    1   2   3   4   5   6   7   8   9   10   >