Re: [Mesa-dev] [PATCH] etnaviv: fix some pm query issues

2019-06-02 Thread Christian Gmeiner
gt; Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > This only fixes the obvious issues. I still believe there are some > GPU/CPU synchronization issues in this code, that need to be fixed > separately. What is your current test for synchronization correctness?

[Mesa-dev] [PATCH] etnaviv: implement set_active_query_state(..) for hw queries

2019-05-28 Thread Christian Gmeiner
Clear w/ quad uses a normal draw which adds up to OQ. st/meta uses set_active_query_state(..) to tell the driver to pause queries in such cases. Fixes spec@arb_occlusion_query@occlusion_query_meta_save piglit. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query.c

[Mesa-dev] [PATCH] etnaviv: drop a bunch of duplicated gallium PIPE_CAP default code

2019-05-27 Thread Christian Gmeiner
Now that we have the util function for the default values, we can get rid of the boilerplate. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 157 --- 1 file changed, 157 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c

[Mesa-dev] [PATCH] etnaviv: rs: choose clear format based on block size

2019-05-26 Thread Christian Gmeiner
Fixes following piglit and does not introduce any regressions. spec@ext_packed_depth_stencil@fbo-depth-gl_depth24_stencil8-blit Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH 2/2] etnaviv: blt: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Hi Fabio, Am Fr., 24. Mai 2019 um 13:10 Uhr schrieb Fabio Estevam : > > Hi Christian, > > On Fri, May 24, 2019 at 7:52 AM Christian Gmeiner > wrote: > > > > Signed-off-by: Christian Gmeiner > > Maybe you could remove the '&& s/FALSE/false' from t

[Mesa-dev] [PATCH 1/2] etnaviv: rs: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c index a9d3872ad41..e64babfdd0a 100644 --- a/src

[Mesa-dev] [PATCH 2/2] etnaviv: blt: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c b/src/gallium/drivers/etnaviv/etnaviv_blt.c index 42190d75d4e..cb6e81999fc 100644 --- a/src/gallium

[Mesa-dev] [RFC PATCH 00/17] An other look at nir

2019-05-10 Thread Christian Gmeiner
he targets. At the moment I am not sure how to move on form this point. Thanks PS: You can find this changes here too https://github.com/austriancoder/mesa/commits/eir-v3 Christian Gmeiner (17): etnaviv: add basic block based backend ir: eir eir: add legalization eir: add live ranges pass

[Mesa-dev] [RFC PATCH 08/17] eir: add nir compiler and all its infrastructure

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir_compiler.c | 61 ++ src/etnaviv/compiler/eir_compiler.h | 29 + src/etnaviv/compiler/eir_compiler_nir.c | 1035 +++ src/etnaviv/compiler/eir_shader.c | 312 +++ src/etnaviv/compiler

[Mesa-dev] [RFC PATCH 15/17] eir: make use of eir_nir_lower_alu_to_scalar(..)

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir_nir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/etnaviv/compiler/eir_nir.c b/src/etnaviv/compiler/eir_nir.c index 6e75f2c5fd8..a579037a667 100644 --- a/src/etnaviv/compiler/eir_nir.c +++ b/src/etnaviv/compiler

[Mesa-dev] [RFC PATCH 07/17] eir: add eir_print(..)

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h | 3 + src/etnaviv/compiler/eir_print.c | 222 +++ src/etnaviv/compiler/meson.build | 1 + 3 files changed, 226 insertions(+) create mode 100644 src/etnaviv/compiler/eir_print.c diff --git

[Mesa-dev] [RFC PATCH 01/17] etnaviv: add basic block based backend ir: eir

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.c | 239 ++ src/etnaviv/compiler/eir.h | 499 src/etnaviv/compiler/eir_uniform.c | 108 + src/etnaviv/compiler/meson.build| 38 ++ src/etnaviv

[Mesa-dev] [RFC PATCH 03/17] eir: add live ranges pass

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h| 3 + src/etnaviv/compiler/eir_live_variables.c | 258 ++ src/etnaviv/compiler/meson.build | 1 + .../compiler/tests/eir_live_variables.cpp | 162 +++ src/etnaviv

[Mesa-dev] [RFC PATCH 06/17] eir: add nir optimization loop

2019-05-10 Thread Christian Gmeiner
This change adds the eir_optimize_nir(..) function which gets used to optimize and transform a nir shader for our needs. Besides this there are some other nir helpers for compiler options and tgsi handling. Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir_nir.c | 131

[Mesa-dev] [RFC PATCH 11/17] etnaviv: add eir_compiler

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/eir_cmdline.c | 189 ++ src/gallium/drivers/etnaviv/meson.build | 20 +++ 2 files changed, 209 insertions(+) create mode 100644 src/gallium/drivers/etnaviv/eir_cmdline.c diff --git a/src/gallium/drivers

[Mesa-dev] [RFC PATCH 17/17] eir: add peephole optimization

2019-05-10 Thread Christian Gmeiner
Some created shaders can contain instructions like: mov t0 t0 This simple pass removes that kind of mov instructions. Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir_opt_peephole.c | 63 + src/etnaviv/compiler/eir_optimize.c | 4 +- src/etnaviv

[Mesa-dev] [RFC PATCH 16/17] eir: add optimization 'framework'

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h | 3 ++ src/etnaviv/compiler/eir_compiler_nir.c | 6 src/etnaviv/compiler/eir_optimize.c | 48 + src/etnaviv/compiler/eir_optimize.h | 31 src/etnaviv/compiler

[Mesa-dev] [RFC PATCH 12/17] etnaviv: add debug option to report NIR as supported and preferred shader IR

2019-05-10 Thread Christian Gmeiner
Add a debug option ETNA_MESA_DEBUG="nir" that will cause the etnaviv gallium pipe driver to advertise support and preference for NIR shaders. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- src/gallium/drivers/etnaviv/etnaviv_debug.h | 3 +++

[Mesa-dev] [RFC PATCH 14/17] eir: add nir alu to scalar lowering pass

2019-05-10 Thread Christian Gmeiner
Some operations are scalar and need special treatment. Those are exp and log2. dst := exp2(src2.x) dst := log2(src2.x) The result is broadcasted over all active destination components. Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir_nir.h| 3 + .../compiler

[Mesa-dev] [RFC PATCH 13/17] etnaviv: enable nir paths

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.c | 23 ++-- src/gallium/drivers/etnaviv/etnaviv_shader.c | 55 +-- 2 files changed, 68 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c b/src/gallium

[Mesa-dev] [RFC PATCH 09/17] etnaviv: become independed of the used compiler backend

2019-05-10 Thread Christian Gmeiner
This change preps etnaviv to be able to swap the used compiler backend easily. It takes care of uniform stuff and the actual creation of shader variants. In the long run - if one backend won - we can remove this again. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv

[Mesa-dev] [RFC PATCH 02/17] eir: add legalization

2019-05-10 Thread Christian Gmeiner
- if shader is empty add a NOP instruction - avoid multiple uniform src for alu ops - resolve jump target Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h | 3 + src/etnaviv/compiler/eir_legalize.c | 177 src/etnaviv/compiler

[Mesa-dev] [RFC PATCH 05/17] eir: implement actual register allocator

2019-05-10 Thread Christian Gmeiner
Some unit tests would be great. Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h | 10 +- src/etnaviv/compiler/eir_register_allocate.c | 176 ++- 2 files changed, 184 insertions(+), 2 deletions(-) diff --git a/src/etnaviv/compiler/eir.h b/src

[Mesa-dev] [RFC PATCH 04/17] eir: add virtual register classes

2019-05-10 Thread Christian Gmeiner
. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter Signed-off-by: Christian Gmeiner --- src/etnaviv/compiler/eir.h | 4 + src/etnaviv/compiler/eir_compiler.h | 41 + src/etnaviv/compiler/eir_register_allocate.c | 179 +++ src/etnaviv/compiler

[Mesa-dev] [RFC PATCH 10/17] etnaviv: hook-up eir into gallium driver

2019-05-10 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_eir.c| 454 +++ src/gallium/drivers/etnaviv/etnaviv_eir.h| 71 +++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 15 + src/gallium/drivers

[Mesa-dev] [PATCH] etnaviv: use the correct uniform dirty bits

2019-05-09 Thread Christian Gmeiner
Found during code inspection. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.c b/src/gallium/drivers/etnaviv

Re: [Mesa-dev] [PATCH] etnaviv: fill missing offset in etna_resource_get_handle

2019-05-09 Thread Christian Gmeiner
Am Fr., 3. Mai 2019 um 12:05 Uhr schrieb Philipp Zabel : > > Without this gbm_bo_get_offset() can return 0 where it shouldn't. Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Mesa-dev] [PATCH] etnaviv: calculate load balancing value at link time

2019-05-09 Thread Christian Gmeiner
Move the calculation out of the compiler. Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_compiler.c| 28 .../drivers/etnaviv/etnaviv_compiler.h| 1 - src/gallium/drivers/etnaviv/etnaviv_shader.c | 32 +-- 3 files changed, 30

[Mesa-dev] [MR] etnaviv: add low level ISA library

2019-05-09 Thread Christian Gmeiner
://gitlab.freedesktop.org/mesa/mesa/merge_requests/848 -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] etnaviv: create optional 2d pipe in screen

2019-05-02 Thread Christian Gmeiner
this patch-set? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/8] etnaviv: export etna_submit_rs_state

2019-04-26 Thread Christian Gmeiner
Am Fr., 12. Apr. 2019 um 19:38 Uhr schrieb Lucas Stach : > > The new 2D YUV blit needs this in some cases, so make it available. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_rs.c | 2 +- > src/gallium/drivers

Re: [Mesa-dev] [PATCH 0/6] Add support for NV12

2019-04-26 Thread Christian Gmeiner
Hi Lucas > > Am Mittwoch, den 24.04.2019, 08:36 +0200 schrieb Christian Gmeiner: > > This patch series goes a complete different route then the one from > > Lucas Stach. I am using the integrated YUV tiler instead of using > > the 2D core for format conversion. I am r

Re: [Mesa-dev] [PATCH 6/8] etnaviv: use filter blit for 2D YUV import on old GC320

2019-04-26 Thread Christian Gmeiner
f}, > +.clear_mode = VIVS_RS_CLEAR_CONTROL_MODE_DISABLED, > +.width = blit_info->dst.box.width, > +.height = blit_info->dst.box.height, > + }); > + > + /* The combined color/depth cache flush is required to avoid pixels > stuck > + * in the caches being flushed to the RS target. This seems to be some > bug > + * found on at least GC2000, with no other known workaround. > + */ > + etna_set_state(ctx->stream, VIVS_GL_FLUSH_CACHE, > + VIVS_GL_FLUSH_CACHE_COLOR | VIVS_GL_FLUSH_CACHE_DEPTH); > + etna_stall(ctx->stream, SYNC_RECIPIENT_RA, SYNC_RECIPIENT_PE); > + etna_set_state(ctx->stream, VIVS_TS_MEM_CONFIG, 0); > + ctx->dirty |= ETNA_DIRTY_TS; > + etna_submit_rs_state(ctx, _blit); > + > + /* flush now, so we can get rid of the temp BO right here */ > + etna_cmd_stream_flush(ctx->stream); > + etna_bo_del(temp_bo); > + } > + > return TRUE; > } > -- > 2.20.1 > > ___ > etnaviv mailing list > etna...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/etnaviv -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/6] Add support for NV12

2019-04-24 Thread Christian Gmeiner
This patch series goes a complete different route then the one from Lucas Stach. I am using the integrated YUV tiler instead of using the 2D core for format conversion. I am reusing some patches from Lucas and this series sits on-top of Lucas "st/dri: YUV" patches. Christian

[Mesa-dev] [PATCH 4/6] etnaviv: direct YUYV/UYVY support

2019-04-24 Thread Christian Gmeiner
The GPU is able to sample from YUYV/UYVY textures directly. Passes following piglits: - ext_image_dma_buf_import-sample_yuv -fmt=YUYV - ext_image_dma_buf_import-sample_yuv -fmt=UYVY Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- src/gallium

[Mesa-dev] [PATCH 2/6] etnaviv: remember data offset into BO

2019-04-24 Thread Christian Gmeiner
From: Lucas Stach Imported resources might not start at offset 0 into the buffer object. Make sure to remember the offset that is provided with the handle on import. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH 6/6] etnaviv: add multi-planar YUV support

2019-04-24 Thread Christian Gmeiner
-up patch. Tested with kmscube (nv12-1img). Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 3 + src/gallium/drivers/etnaviv/etnaviv_rs.c | 5 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 4

[Mesa-dev] [PATCH 1/6] etnaviv: clear out next pointer when allocating resource

2019-04-24 Thread Christian Gmeiner
Stach Reviewed-by: Philipp Zabel Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnaviv/etnaviv_resource.c index 83179d3cd08..77d027ac806

[Mesa-dev] [PATCH 3/6] etnaviv: improve PIPE_BIND_LINEAR handling

2019-04-24 Thread Christian Gmeiner
the resource isn't used for rendering. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium

[Mesa-dev] [PATCH 5/6] etnaviv: update headers from rnndb

2019-04-24 Thread Christian Gmeiner
Update to etna_viv commit 1ccc35b. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- .../drivers/etnaviv/hw/common_3d.xml.h| 2 +- src/gallium/drivers/etnaviv/hw/state.xml.h| 4 +-- src/gallium/drivers/etnaviv/hw/state_3d.xml.h | 35

Re: [Mesa-dev] [PATCH 3/8] etnaviv: remember data offset into BO

2019-04-23 Thread Christian Gmeiner
Am Fr., 12. Apr. 2019 um 19:38 Uhr schrieb Lucas Stach : > > Imported resources might not start at offset 0 into the buffer object. > Make sure to remember the offset that is provided with the handle on > import. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmei

Re: [Mesa-dev] [PATCH 7/8] etnaviv: improve PIPE_BIND_LINEAR handling

2019-04-23 Thread Christian Gmeiner
andle this case seems limited, we only respect the flag when the > resource isn't used for rendering. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 > 1 file changed, 8 insertions(+) > > d

Re: [Mesa-dev] [PATCH 2/8] etnaviv: clear out next pointer when allocating resource

2019-04-19 Thread Christian Gmeiner
his out when > allocating a new resource. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c > b/src/gal

[Mesa-dev] [PATCH] etnaviv: direct YUYV/UYVY support

2019-04-14 Thread Christian Gmeiner
The GPU is able to sample from YUYV/UYVY textures directly. Passes following piglits: - ext_image_dma_buf_import-sample_yuv -fmt=YUYV - ext_image_dma_buf_import-sample_yuv -fmt=UYVY Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- src/gallium

Re: [Mesa-dev] [PATCH 1/2] nir: Add nir_lower_viewport_transform

2019-04-14 Thread Christian Gmeiner
his > is > + * used in depth clipping computations > + */ > + > +nir_ssa_def *screen_space = nir_vec4(, > + nir_channel(, screen, 0), > + nir_channel(, screen, 1), > + nir_channel

Re: [Mesa-dev] [PATCH 2/2] etnaviv: flush all pending contexts when accessing a resource with the CPU

2019-03-27 Thread Christian Gmeiner
t; shared (read) mode have been executed. > > Fixes: 64813541d575 (etnaviv: fix resource usage tracking across > different pipe_context's) > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 10 -- >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: don't flush own context when updating resource use

2019-03-27 Thread Christian Gmeiner
w call, causing huge CPU overhead. > > Fixes: 64813541d575 (etnaviv: fix resource usage tracking across > different pipe_context's) > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 11 ++- > 1 file c

Re: [Mesa-dev] [PATCH] etnaviv: only try to construct scanout resource when on KMS winsys

2019-03-27 Thread Christian Gmeiner
d-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c > b/src/gallium/drivers/etnaviv/etnaviv_resour

[Mesa-dev] [PATCH] etnaviv: shrink struct etna_3d_state

2019-03-27 Thread Christian Gmeiner
Drop struct members which are only written to but never read from. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 17 - src/gallium/drivers/etnaviv/etnaviv_internal.h | 6 -- 2 files changed, 23 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-03-17 Thread Christian Gmeiner
; > > ctx->dirty |= ETNA_DIRTY_DERIVE_TS; > While the V6 of this patch [1] is now in mesa upstream, this hunk is > missing from the V6 . Any special reason for that or is this just an > omission ? > This and an other change was done in separates commits - see: https://cgit.freedesktop.org/mesa/mesa/commit/?id=7244e768040859126a5b74023f587beaa8bef81c https://cgit.freedesktop.org/mesa/mesa/commit/?id=c56e73449698c31fe72b99a95b7e4ecdb2985b73 So everything went in. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Christian Gmeiner
* `needle`, returns whether the modifier is found */ > + > +static bool > +drm_find_modifier(uint64_t needle, const uint64_t *haystack, unsigned count) > +{ static inline bool drm_find_modifier(..) > +unsigned i; > + > +for (i = 0; i < count; i++) { > +

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-08 Thread Christian Gmeiner
hat u_transfer_helper is fragile :) -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-07 Thread Christian Gmeiner
Am Fr., 1. März 2019 um 16:54 Uhr schrieb Christian Gmeiner : > > Use u_transfer_helper_resource_create(..) instead which uses the > resource_create(..) function specified in u_transfer_vtbl. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/auxiliary/util/u_transfer

[Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-01 Thread Christian Gmeiner
Use u_transfer_helper_resource_create(..) instead which uses the resource_create(..) function specified in u_transfer_vtbl. Signed-off-by: Christian Gmeiner --- src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit

2019-02-28 Thread Christian Gmeiner
e define / enum / struct / whatever in, it will be forgotten > to time. Ok, thanks. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 0/4] Add ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
piglit: spec/!opengl es 3.0/oes_compressed_etc2_texture-miptree_gles3 Christian Gmeiner (4): etnaviv: implement ETC2 block patching for HALTI0 etnaviv: keep track of mapped bo address etnaviv: hook-up etc2 patching etnaviv: enable ETC2 texture compression support for HALTI0 GPUs src/gallium

[Mesa-dev] [PATCH v3 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Christian Gmeiner
ation why DRM_ETNA_PREP_WRITE is needed Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_resource.c| 3 + .../drivers/etnaviv/etnaviv_resource.h| 5 ++ .../drivers/etnaviv/etnaviv_transfer.c| 56 +++ 3 files changed, 64 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH v3 2/4] etnaviv: keep track of mapped bo address

2019-02-27 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19

[Mesa-dev] [PATCH v3 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Changes v2 -> v3: - Drop redundant format check Signed-off-by: Christian Gmeiner Acked-by: Lucas St

[Mesa-dev] [PATCH v3 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-27 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index

Re: [Mesa-dev] [PATCH v2 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:22 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > ETC2 is supported with HALTI0, however that implementation is buggy > > in hardware. The blob driver does per-block patching to work a

Re: [Mesa-dev] [PATCH v2 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:19 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > Changes v1 -> v2: > > - Avoid the GPU sampling from the resource that gets mutated by the the > >transfer map by

Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit

2019-02-27 Thread Christian Gmeiner
t; struct mali_vertex_tiler_prefix { > /* This is a dynamic bitfield containing the following things in > this order: super nitpicking: What is the purpose of this change? Should this define be added when it really gets used? -- greets -- Christian Gmeiner, MSc https://chri

[Mesa-dev] [PATCH v2 3/4] etnaviv: hook-up etc2 patching

2019-02-26 Thread Christian Gmeiner
Changes v1 -> v2: - Avoid the GPU sampling from the resource that gets mutated by the the transfer map by setting DRM_ETNA_PREP_WRITE. Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_resource.c| 3 + .../drivers/etnaviv/etnaviv_resource.h|

[Mesa-dev] [PATCH v2 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-26 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium

[Mesa-dev] [PATCH v2 0/4] Add ETC2 block patching for HALTI0

2019-02-26 Thread Christian Gmeiner
piglit: spec/!opengl es 3.0/oes_compressed_etc2_texture-miptree_gles3 Christian Gmeiner (4): etnaviv: implement ETC2 block patching for HALTI0 etnaviv: keep track of mapped bo address etnaviv: hook-up etc2 patching etnaviv: enable ETC2 texture compression support for HALTI0 GPUs src/gallium

[Mesa-dev] [PATCH v2 2/4] etnaviv: keep track of mapped bo address

2019-02-26 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19

[Mesa-dev] [PATCH v2 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-26 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index de822fc85ca..ee32a499fb5 100644

[Mesa-dev] [PATCH] st/dri: allow direct UYVY import

2019-02-26 Thread Christian Gmeiner
Push this format to the pipe driver unchanged. Signed-off-by: Christian Gmeiner --- include/GL/internal/dri_interface.h | 1 + src/gallium/state_trackers/dri/dri2.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal

[Mesa-dev] [PATCH v6] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-23 Thread Christian Gmeiner
s from v4 -> v5: - Fix coding style issues reported by Guido Changes from v5 -> v6: - Add missing locking in etna_transfer_map(..) (Boris) Signed-off-by: Christian Gmeiner Signed-off-by: Marek Vasut Signed-off-by: Boris Brezillon Tested-by: Marek Vasut --- src/gallium/drivers/etnaviv/e

[Mesa-dev] [PATCH] etnaviv: blt: mark used src resource as read from

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c b/src/gallium/drivers/etnaviv/etnaviv_blt.c index 52731a9c770..42190d75d4e 100644 --- a/src/gallium/drivers/etnaviv

[Mesa-dev] etnaviv: rs: mark used src resource as read from

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c index fc4f65dbeee..a9d3872ad41 100644 --- a/src/gallium/drivers/etnaviv

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Christian Gmeiner
Hi Boris, Am Fr., 22. Feb. 2019 um 10:30 Uhr schrieb Boris Brezillon : > > On Thu, 21 Feb 2019 23:29:53 +0100 > Boris Brezillon wrote: > > > Christian, Marek, > > > > On Wed, 30 Jan 2019 05:28:14 +0100 > > Marek Vasut wrote: > > > > > From:

[Mesa-dev] [PATCH 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-22 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium

[Mesa-dev] [PATCH 0/4] Add ETC2 block patching for HALTI0

2019-02-22 Thread Christian Gmeiner
piglit: spec/!opengl es 3.0/oes_compressed_etc2_texture-miptree_gles3 Christian Gmeiner (4): etnaviv: implement ETC2 block patching for HALTI0 etnaviv: keep track of mapped bo address etnaviv: hook-up etc2 patching etnaviv: enable ETC2 texture compression support for HALTI0 GPUs src/gallium

[Mesa-dev] [PATCH 3/4] etnaviv: hook-up etc2 patching

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_resource.c| 3 ++ .../drivers/etnaviv/etnaviv_resource.h| 5 ++ .../drivers/etnaviv/etnaviv_transfer.c| 49 +++ 3 files changed, 57 insertions(+) diff --git a/src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index de822fc85ca..ee32a499fb5 100644

[Mesa-dev] [PATCH 2/4] etnaviv: keep track of mapped bo address

2019-02-22 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19 ++- 2 files

Re: [Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-28 Thread Christian Gmeiner
Hi Lucas, Am Fr., 25. Jan. 2019 um 17:02 Uhr schrieb Lucas Stach : > > Hi Christian, > > Am Montag, den 21.01.2019, 07:50 +0100 schrieb Christian Gmeiner: > > If the GPU supports linear sampling, linear addressing mode > > will be used as default. > > > >

Re: [Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-23 Thread Christian Gmeiner
Am Mo., 21. Jan. 2019 um 10:10 Uhr schrieb Lucas Stach : > > Am Montag, den 21.01.2019, 07:50 +0100 schrieb Christian Gmeiner: > > If the GPU supports linear sampling, linear addressing mode > > will be used as default. > > > > > Signed-off-by: Christian Gmeiner

Re: [Mesa-dev] [PATCH 1/4] etnaviv: extend etna_resource with an addressing mode

2019-01-23 Thread Christian Gmeiner
Hi Lucas Am Mo., 21. Jan. 2019 um 10:03 Uhr schrieb Lucas Stach : > > Hi Christian, > > first of all, thanks for figuring this out. This is really nice > to finally know how it works. > > Am Montag, den 21.01.2019, 07:49 +0100 schrieb Christian Gmeiner: > > Defines h

Re: [Mesa-dev] [PATCH 1/2] pl111: Rename the pl111 driver to "kmsro".

2019-01-23 Thread Christian Gmeiner
will actually support: > various sorts of KMS displays with the renderonly layer used to attach a > GPU. I like the idea of this patch and it is good starting point torwards a generic solution for kms displays with the renderonly framework. Reviewed-by: Christian Gm

[Mesa-dev] [PATCH 3/4] etnaviv: add linear sampling support

2019-01-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_texture_state.c | 21 +++ .../drivers/etnaviv/etnaviv_texture_state.h | 1 + 2 files changed, 22 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture_state.c b/src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH 2/4] etnaviv: update headers from rnndb

2019-01-20 Thread Christian Gmeiner
Update to etna_viv commit 4d2f857. Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/hw/cmdstream.xml.h| 8 +- src/gallium/drivers/etnaviv/hw/common.xml.h | 171 +- .../drivers/etnaviv/hw/common_3d.xml.h| 12 +- src/gallium/drivers/etnaviv/hw

[Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-20 Thread Christian Gmeiner
If the GPU supports linear sampling, linear addressing mode will be used as default. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- src/gallium/drivers/etnaviv/etnaviv_texture.c | 4 +++- 2 files changed, 10 insertions(+), 4 deletions

[Mesa-dev] [PATCH 1/4] etnaviv: extend etna_resource with an addressing mode

2019-01-20 Thread Christian Gmeiner
Defines how sampler (and pixel pipes) needs to access the data represented with a resource. The used default is mode is ETNA_ADDRESSING_MODE_TILED. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 17 +++-- src/gallium/drivers/etnaviv

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Christian Gmeiner
Am So., 16. Dez. 2018 um 12:24 Uhr schrieb Gert Wollny : > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny Reviewed-by: Christian Gme

Re: [Mesa-dev] [PATCH] etnaviv_screen: Fix typo in cflush_all description

2019-01-07 Thread Christian Gmeiner
Am Mo., 7. Jan. 2019 um 15:00 Uhr schrieb Guido Günther : > > Signed-off-by: Guido Günther Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etn

[Mesa-dev] [PATCH v2] etnaviv: fix resource usage tracking across different pipe_context's

2019-01-02 Thread Christian Gmeiner
A pipe_resource can be shared by all the pipe_context's hanging off the same pipe_screen. Changes from v1 -> v2: - to remove the resource from the used_resources set when it is destroyed Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.c | 21

Re: [Mesa-dev] [PATCH] etnaviv: implement check_resource_capability

2018-12-28 Thread Christian Gmeiner
gt; pscreen->resource_changed = etna_resource_changed; > pscreen->resource_destroy = etna_resource_destroy; > + pscreen->check_resource_capability = etna_check_resource_capability; > } > -- > 2.19.1 > >

Re: [Mesa-dev] [PATCH v2 2/2] etnaviv: annotate variables only used in debug build

2018-12-28 Thread Christian Gmeiner
s Stach Reviewed-by: Christian Gmeiner > --- > v2: get rid of superfluous variable initialization > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etna

Re: [Mesa-dev] [PATCH v2 1/2] etnaviv: enable full overwrite in a few more cases

2018-12-28 Thread Christian Gmeiner
s Stach Reviewed-by: Christian Gmeiner > --- > v2: clarify comment > --- > src/gallium/drivers/etnaviv/etnaviv_blend.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_blend.c > b/src/galli

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Christian Gmeiner
ssa_undef: > + case nir_instr_type_phi: > + case nir_instr_type_tex: > +nir_foreach_ssa_def(instr, rewrite_1bit_ssa_def_to_32bit, > +); > +break; > + > + default: > +nir_foreach_ssa_def

Re: [Mesa-dev] [PATCH] etnaviv: Consolidate buffer references from framebuffers

2018-12-17 Thread Christian Gmeiner
Tomeu Vizoso > Reported-by: Sjoerd Simons Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_context.c | 10 ++ > src/gallium/drivers/etnaviv/etnaviv_internal.h | 1 - > src/gallium/drivers/etnaviv/etnaviv_state.c| 8 +++- > 3 files ch

Re: [Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

2018-12-15 Thread Christian Gmeiner
Hi Dylan Am Fr., 14. Dez. 2018 um 20:13 Uhr schrieb Dylan Baker : > > Quoting Christian Gmeiner (2018-12-13 12:07:23) > > Signed-off-by: Christian Gmeiner > > --- > > meson.build | 2 +- > > meson_options.txt |

[Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

2018-12-13 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- meson.build | 2 +- meson_options.txt | 2 +- src/gallium/drivers/etnaviv/meson.build | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index fe647f682c

[Mesa-dev] [PATCH] etnaviv: drop redundant ctx function parameter

2018-12-12 Thread Christian Gmeiner
There is no need to have an extra ctx paramter as all the other parameters carry all the needed information. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_shader.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv

Re: [Mesa-dev] [RFC PATCH 0/5] last call for autotools (meson travis fixes)

2018-12-12 Thread Christian Gmeiner
gh Travis CI. I helped me to find missing parts in makefiles etc. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] nir: add fceil lowering

2018-11-19 Thread Christian Gmeiner
Am Mo., 19. Nov. 2018 um 21:17 Uhr schrieb Jonathan marek : > > I don't have push rights, but robclark added this patch to his staging > branch so I imagine he will push it soon. > Great.. > On 11/19/2018 03:15 PM, Christian Gmeiner wrote: > > Am Mo., 12. Nov. 2018 um 19:17

Re: [Mesa-dev] [PATCH 1/3] nir: add fceil lowering

2018-11-19 Thread Christian Gmeiner
Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek : > > lowers ceil(x) as -floor(-x) > > Signed-off-by: Jonathan Marek Do you have push rights? As I am interested in this one I would push it for you if needed. -- greets -- Christian Gmeiner, MSc https://christian-

  1   2   3   4   5   >