[Mesa-dev] [PATCH mesa 07/12] i965: turn "unreachable" assert() into unreachable()

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index b6bf96706f837606dcd6..627a18027cd13ada959b

[Mesa-dev] [PATCH mesa 09/12] i965: move #ifdef to fix -Wswitch when SSE 4.1 is not supported

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index 836f83d4a43a45e76b48..89d7a69d217829742c01

[Mesa-dev] [PATCH mesa 04/12] r600: fix memset(0) of non-trivial structs

Signed-off-by: Eric Engestrom --- src/gallium/drivers/r600/sb/sb_expr.cpp | 10 +- src/gallium/drivers/r600/sb/sb_if_conversion.cpp | 4 ++-- src/gallium/drivers/r600/sb/sb_ir.h | 2 +- src/gallium/drivers/r600/sb/sb_peephole.cpp | 4 ++-- 4 files changed

[Mesa-dev] [PATCH mesa 02/12] nouveau: remove unused class member

Signed-off-by: Eric Engestrom --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h index 4136b1ecfebcd7d7d1a5

[Mesa-dev] [PATCH mesa 11/12] egl: remove wayland special case which is also the default case

Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index c5fa935657e8165be49c..7d9e24d79ddf833802fb 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH mesa 08/12] i965: add missing case to fix -Wswitch

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index 627a18027cd13ada959b

[Mesa-dev] [PATCH mesa 01/12] scons: drop unused HAVE_STDINT_H macro

Signed-off-by: Eric Engestrom --- scons/llvm.py | 3 --- src/gallium/drivers/svga/SConscript| 4 src/gallium/drivers/svga/svga_hw_reg.h | 6 -- src/gallium/winsys/svga/drm/SConscript | 1 - 4 files changed, 14 deletions(-) diff --git a/scons/llvm.py b/scons

[Mesa-dev] [PATCH mesa 03/12] nouveau: fix memset(0) of non-trivial structs

Signed-off-by: Eric Engestrom --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 3 +-- src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gallium/drivers

[Mesa-dev] [PATCH mesa 05/12] mesa: fix memset(0) of non-trivial structs

Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 +-- src/mesa/state_tracker/st_glsl_to_tgsi_private.cpp | 7 ++- src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 1 + 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src

[Mesa-dev] [PATCH mesa 06/12] mesa: fix struct/class mismatch

Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_array_merge.cpp | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_array_merge.h | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 4 ++-- 4 files

Re: [Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

On Monday, 2018-10-29 10:11:53 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-29 09:46:46) > > On Monday, 2018-10-29 09:07:30 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-10-28 06:45:05) > > > > Meson already automatically tracks includ

Re: [Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

On Monday, 2018-10-29 09:07:30 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-28 06:45:05) > > Meson already automatically tracks included headers, so there's no need > > to add them everywhere; cleans up the code a bit. > > > > Signed-off-by: Eric En

Re: [Mesa-dev] [PATCH mesa v2 1/4] anv: add missing meson build dependency

On Monday, 2018-10-29 09:08:06 -0700, Dylan Baker wrote: > for the series: > Reviewed-by: Dylan Baker Thanks; pushed > > Quoting Eric Engestrom (2018-10-28 06:18:39) > > Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" > > Signed-off-by

Re: [Mesa-dev] [PATCH mesa 4/4] vulkan/wsi: fix pointer casting warning on 32bit

On Sunday, 2018-10-28 17:29:34 -0500, Jason Ekstrand wrote: > On October 28, 2018 08:45:30 Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > --- > > src/vulkan/wsi/wsi_common_wayland.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH mesa v2 1/4] anv: add missing meson build dependency

On Sunday, 2018-10-28 17:26:18 -0500, Jason Ekstrand wrote: > Rb Thanks! I assume that's just anv, not the rest of the series? > > On October 28, 2018 08:19:19 Eric Engestrom wrote: > > > Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties"

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

On Monday, 2018-10-29 10:44:28 +0200, Sergii Romantsov wrote: > Hello, > > > > What problem are we solving? > > That we don't get fast paths in rounding.h by default on i686, I think? > > Yes, it adds optimization for rounding.h. On x86_64 msse is enabled by > default (as example by gcc). > And a

[Mesa-dev] [PATCH mesa] intel/batch-decoder: remove never-used function

This function was there when the file was introduced in commit 38f10d5a03542c60a589 "intel: tools: add aubinator viewer", but was never actually used. Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- Lionel, was this function no longer needed in the final revision of this comm

[Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

Meson already automatically tracks included headers, so there's no need to add them everywhere; cleans up the code a bit. Signed-off-by: Eric Engestrom --- src/vulkan/wsi/meson.build | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/src/vulka

[Mesa-dev] [PATCH mesa 3/4] vulkan/wsi: s/#if/#ifdef/ to fix -Wundef

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.h b/src/vulkan/wsi/wsi_common_display.h index 50d7f836a754d3ef488c..be0bd4e06fb9c818eed5 100644 --- a/src/vulkan/wsi

[Mesa-dev] [PATCH mesa 2/4] vulkan/wsi: deduplicate get_current_time() functions

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common.c | 9 + src/vulkan/wsi/wsi_common.h | 3 +++ src/vulkan/wsi/wsi_common_display.c | 16 src/vulkan/wsi/wsi_common_x11.c | 14 ++ 4 files changed, 18 insertions(+), 24 deletions

[Mesa-dev] [PATCH mesa 4/4] vulkan/wsi: fix pointer casting warning on 32bit

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index e9cc22ec60372e486e8e..c3cb066bd6dfedb6a363 100644 --- a/src/vulkan/wsi

[Mesa-dev] [PATCH mesa v2 3/4] clover: add missing meson build dependency

Fixes: 42ea0631f108d82554339 "meson: build clover" Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/clover/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/meson.build b/src/gallium/state_trackers/clover/m

[Mesa-dev] [PATCH mesa v2 4/4] radv: add missing meson build dependency

Fixes: 9d40ec2cf6ec6d3d9d78 "radv: Add support for VK_KHR_driver_properties." Signed-off-by: Eric Engestrom --- src/amd/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/meson.build b/src/amd/vulkan/meson.build index 1ed5299d75

[Mesa-dev] [PATCH mesa v2 1/4] anv: add missing meson build dependency

Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" Signed-off-by: Eric Engestrom --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index 941186d38e

[Mesa-dev] [PATCH mesa v2 2/4] svga: add missing meson build dependency

Fixes: a537231b226280bc1e5b7 "meson: build svga driver on linux" Signed-off-by: Eric Engestrom --- src/gallium/drivers/svga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/meson.build b/src/gallium/drivers/svga/meson.b

Re: [Mesa-dev] [Mesa-stable] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

On Friday, 2018-10-26 08:55:46 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-25 09:44:14) > > On Tuesday, 2018-10-02 13:44:07 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-10-02 07:09:03) > > > > Cc: mesa-sta...@lists.freedesktop.o

Re: [Mesa-dev] [PATCH 2/2] anv: Return VK_ERROR_DEVICE_LOST from anv_device_set_lost

On Friday, 2018-10-26 11:42:12 -0500, Jason Ekstrand wrote: > This lets us get rid of a bunch of duplicated error messages. Better than mine :P Reviewed-by: Eric Engestrom > --- > src/intel/vulkan/anv_device.c | 50 +++--- > src/intel/vulkan/anv_pr

Re: [Mesa-dev] [PATCH mesa] anv: set error in anv_device_set_lost()

On Friday, 2018-10-26 12:39:25 -0500, Jason Ekstrand wrote: > I sent two patches for this an hour ago Oops, should've checked before sending mine :) Your solution is cleaner; r-b > > On Fri, Oct 26, 2018 at 12:31 PM Eric Engestrom > wrote: > > > This de-dup

[Mesa-dev] [PATCH mesa] anv: set error in anv_device_set_lost()

This de-duplicates the error messages. Signed-off-by: Eric Engestrom --- Kinda hacky, so I won't take it personally if I get a "heck no!" :P --- src/intel/vulkan/anv_device.c | 27 --- src/intel/vulkan/anv_private.h | 5 + src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH 3/3] anv: Handle the device loss abort in anv_device_set_lost

; *object, > > intel_loge("%s", report); > > - if (error == VK_ERROR_DEVICE_LOST && > - env_var_as_boolean("ANV_ABORT_ON_DEVICE_LOSS", false)) > - abort(); > - You can now drop `#include "util/debug.h"` fro

Re: [Mesa-dev] [PATCH 2/2] kmsro: Extend to include hx8357d.

m driver? Impressive! (nit: `.driver_name` missing one space of indentation) Code-wise, patch #1 is: Reviewed-by: Eric Engestrom Not completely sure this is all that's needed for this patch, so only: Acked-by: Eric Engestrom That said, ... (scroll down) > { > .driv

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

es (it's not in the mailman archive either), but this patch is: Reviewed-by: Eric Engestrom > --- > src/util/xmlpool/gen_xmlpool.py | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xml

Re: [Mesa-dev] [PATCH mesa] radv: remove duplicate brackets in version string

;ll probably push it tomorrow. > On Thu, Oct 25, 2018 at 6:40 PM Eric Engestrom > wrote: > > > > MESA_GIT_SHA1 resolves to either an empty "" string if not build > from git, > > or " (git-DEADBEEF)" if it is. No need to wrap it in additional &g

Re: [Mesa-dev] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

On Tuesday, 2018-10-02 13:44:07 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-02 07:09:03) > > Cc: mesa-sta...@lists.freedesktop.org > > Signed-off-by: Eric Engestrom > > --- > > src/mesa/meson.build | 3 +-- > > src/meson.build | 13

[Mesa-dev] [PATCH mesa] radv: remove duplicate brackets in version string

MESA_GIT_SHA1 resolves to either an empty "" string if not build from git, or " (git-DEADBEEF)" if it is. No need to wrap it in additional "()". Fixes: 9d40ec2cf6ec6d3d9d78 "radv: Add support for VK_KHR_driver_properties." Signed-off-by: Eric Engestrom ---

Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

On Thursday, 2018-10-25 17:54:16 +1100, Timothy Arceri wrote: > On 25/10/18 7:42 am, Ian Romanick wrote: > > On 10/23/2018 04:15 AM, Eric Engestrom wrote: > > > Suggested-by: Timothy Arceri > > Um no :P I suggested you fix the formatting in your patch to match the Mes

Re: [Mesa-dev] [PATCH] m4: add Werror when checking for compiler flags

and it will succeed, while > > at the same time throwing an annoying warning. > > > > Add -Werror so that everything gets flagged and set accordingly. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108082 > > Cc: Eric Engestrom > > Cc: Dy

[Mesa-dev] [PATCH mesa] vulkan: drop always-true param

Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi_x11.c | 2 -- src/intel/vulkan/anv_wsi_x11.c | 2 -- src/vulkan/wsi/wsi_common_x11.c | 5 - src/vulkan/wsi/wsi_common_x11.h | 1 - 4 files changed, 10 deletions(-) diff --git a/src/amd/vulkan/radv_wsi_x11.c b/src/amd/vulkan

Re: [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

;; > xetnaviv) > diff --git a/meson.build b/meson.build > index 505cc6c79bd..d483c61f5c9 100644 > --- a/meson.build > +++ b/meson.build > @@ -1112,7 +1112,6 @@ _drm_amdgpu_ver = '2.4.93' Just above this: 8< diff --git a/meson.build b/meson.

[Mesa-dev] [PATCH mesa] anv: move variable to proper scope and mark as MAYBE_UNUSED

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_queue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c index db89385b86644417d47a..05739cb26df571c5f4db 100644 --- a/src/intel/vulkan/anv_queue.c +++ b/src

[Mesa-dev] [PATCH mesa] anv: wrap API errors in vk_error()

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_android.c | 2 +- src/intel/vulkan/anv_device.c | 10 +- src/intel/vulkan/anv_formats.c | 2 +- src/intel/vulkan/anv_image.c | 2 +- src/intel/vulkan/anv_queue.c | 6 +++--- src/intel/vulkan

[Mesa-dev] [PATCH mesa] anv: use snprintf() instead of memset()+strcpy()

snprintf() guarantees that it will not write more chars than allowed, and that the string will be null-terminated, without the need to fill the whole thing with zeroes to begin with. Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 7 +++ 1 file changed, 3 insertions(+), 4

[Mesa-dev] [PATCH mesa] anv: drop unused includes

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_wsi_wayland.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/vulkan/anv_wsi_wayland.c b/src/intel/vulkan/anv_wsi_wayland.c index 3aeb1994110c563456cd..26383f42387ea28af0b5 100644 --- a/src/intel/vulkan/anv_wsi_wayland.c

[Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

Suggested-by: Timothy Arceri Signed-off-by: Eric Engestrom --- Timothy, I opted to remove them all instead of adding even more, as it would break again next time something changes (the set_foreach() one was already broken before my patch for instance) and result in lots of unnecessary churn for

[Mesa-dev] [PATCH mesa 1/2] util: use C99 declaration in the for-loop hash_table_foreach() macro

Signed-off-by: Eric Engestrom --- src/amd/common/ac_nir_to_llvm.c| 1 - src/broadcom/compiler/vir_live_variables.c | 2 -- src/broadcom/compiler/vir_lower_uniforms.c | 1 - src/compiler/glsl/ast_to_hir.cpp | 1 - src/compiler/glsl

[Mesa-dev] [PATCH mesa 2/2] util: use C99 declaration in the for-loop set_foreach() macro

Signed-off-by: Eric Engestrom --- src/compiler/glsl/opt_copy_propagation_elements.cpp | 1 - src/compiler/glsl/standalone.cpp | 2 -- src/compiler/nir/nir_control_flow.c | 1 - src/compiler/nir/nir_dominance.c | 4 src/compiler

Re: [Mesa-dev] [RFC] docs: Add a copyright.c template we can copy when making new files.

On Friday, 2018-10-19 20:43:44 +0100, Chris Wilson wrote: > Quoting Kenneth Graunke (2018-10-19 18:51:36) > > Usually when making a new file, people copy some random other file > > to get the copyright header comments. Unfortunately, some of them > > are commented in a decades-old style, are word

Re: [Mesa-dev] [PATCH v2] meson: Add -Werror=return-type when supported.

ning to change much based on the compiler > version, so hopefully it won't become a problem for packagers/builders. > > See the GCC documentation or 'man gcc' for more details: > https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/Warning-Options.html#index-Wreturn-type Reviewed-by:

Re: [Mesa-dev] [PATCH] vulkan/wsi: Use VK_EXT_pci_bus_info for DRM fd matching

On Thursday, 2018-10-18 10:13:39 -0500, Jason Ekstrand wrote: > This lets us avoid passing the DRM fd around all over the place and gets > us closer to layer utopia. Yay! Reviewed-by: Eric Engestrom > --- > src/amd/vulkan/radv_wsi.c | 3 -- > src/amd/vulkan/radv_wsi_x

[Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" Cc: Bas Nieuwenhuizen Signed-off-by: Eric Engestrom --- src/amd/vulkan/si_cmd_buffer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cm

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

On Thursday, 2018-10-18 08:02:42 -0500, Jason Ekstrand wrote: > On October 18, 2018 05:40:14 Eric Engestrom wrote: > > > On Wednesday, 2018-10-17 15:14:03 -0500, Jason Ekstrand wrote: > > > We already have wsi_device and we know the instance allocator at > > > wsi_

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

gt; *alloc, > bool has_present_v1_2 = false; > > struct wsi_x11_connection *wsi_conn = > - vk_alloc(alloc, sizeof(*wsi_conn), 8, > + vk_alloc(&wsi_dev->instance_alloc, sizeof(*wsi_conn), 8, > VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE); > if (!

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

On Wednesday, 2018-10-17 17:25:22 +0200, Neil Roberts wrote: > Eric Engestrom writes: > > > You might want to remove these instead, and use the .editorconfig [1] > > already present at src/gallium/drivers/freedreno/.editorconfig This is > > much easier to maintain

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

On Wednesday, 2018-10-17 15:48:41 +0200, Neil Roberts wrote: > The modeline was missing a ‘:’ after the tab-width and Emacs was > complaining every time you open a file. This patch was made with: > > sed -ri '1 s/; tab-width ([0-9])/; tab-width: \1/' \ > $(find -name \*.\[ch\] -exec grep -l --

Re: [Mesa-dev] [PATCH] meson: Add -Werror=return-type when supported.

rror=missing-prototypes', '-Werror=return-type', > + '-fno-math-errno', I think we should add this to C++ code as well (~20 lines below). With C++ getting the same treatment: Reviewed-by: Eric Engestrom (btw, we might want to add the same to configure.a

[Mesa-dev] [PATCH mesa] util: use *unsigned* ints for bit operations

Fixes errors thrown by GCC's Undefined Behaviour sanitizer (ubsan) every time this macro is used. Signed-off-by: Eric Engestrom --- src/util/bitset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/bitset.h b/src/util/bitset.h index adafc72a5f74d46

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

butors of projects that follow X.Org's > purpose as enacted in its bylaws. Other projects can continue to be > hosted on fd.o but won't receive X.Org membership for the mere reason > of > being hosted on fd.o. With my member hat on, I think this is the best choice. Acked

Re: [Mesa-dev] [PATCH libdrm] xf86drmHash: remove redundant zero init

On Thursday, 2018-10-11 19:18:10 -0400, mesa-dev-boun...@lists.freedesktop.org wrote: > From: Rob Clark > > drmMalloc() is already calloc() Sounds very much like an implementation detail, but everything relies on it already, so... Reviewed-by: Eric Engestrom > > Signed-of

Re: [Mesa-dev] [PATCH v4 2/5] util: Get program name based on path when possible

e also been walking these strings so many times by now that one more time doesn't make any timing difference, but makes the code way more intuitive: if (...) return strrchr(path, '/') + 1; You can always cache it like you're caching `path` ;) With either of those

[Mesa-dev] [PATCH mesa 3/3] meson: fix wayland-less builds

/wayland-drm/wayland-drm.xml src/egl/wayland/wayland-drm/wayland-drm-client-protocol.h /bin/sh: client-header: command not found ninja: build stopped: subcommand failed. Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" Signed-off-by: Eric Engestrom --- Ki

[Mesa-dev] [PATCH mesa 1/3] meson: only run vulkan's meson.build when building vulkan

Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" Signed-off-by: Eric Engestrom --- src/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build index a8c1f53b62c1295d557d..2b8fcc36be5b0b168

[Mesa-dev] [PATCH mesa 2/3] gbm: remove unnecessary meson include

`inc_wayland_drm` is only used if wayland is built, and it's already added in that case a few lines below. Fixes: a29869e8720b385d3692f "gbm: Don't traverse backwards for includes" Signed-off-by: Eric Engestrom --- src/gbm/meson.build | 1 - 1 file changed, 1 deletion(-)

[Mesa-dev] [PATCH mesa] meson: drop option description relic

`platforms` is no longer a comma-separated string, and some of our option descriptions are way too long already. Just drop the incorrect bit. Signed-off-by: Eric Engestrom --- meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson_options.txt b

Re: [Mesa-dev] [PATCH] egl: Use correct shared libraries suffix on macOS.

..4200f9c07f3a 100755 > --- a/src/egl/egl-symbols-check > +++ b/src/egl/egl-symbols-check > @@ -1,7 +1,12 @@ > #!/bin/sh > set -eu > > -LIB=${1-.libs/libEGL.so} > +if [ "$(uname)" = "Darwin" ] > +then > + LIB=${1-.libs/libEGL.dylib} This matches t

Re: [Mesa-dev] [PATCH] anv/android: we need git_sha1.h in include paths

y to add a -I include path? If so: Acked-by: Eric Engestrom > > On 10/3/18 1:46 PM, Tapani Pälli wrote: > > Fixes: e4538b9 "anv: Implement VK_KHR_driver_properties" > > Signed-off-by: Tapani Pälli > > --- > > src/intel/Android.vulkan.mk | 1 + > &g

Re: [Mesa-dev] [PATCH v2] i965/miptree: Use enum instead of boolean.

On Wednesday, 2018-10-10 16:13:37 -0700, Rafael Antognolli wrote: > ISL_AUX_USAGE_NONE happens to be the same as "false", but let's do the > right thing and use the enum. > > v2: fix intel_miptree_finish_depth too (Caio) > > Reviewed-by: Dylan Baker > Reviewed-by: Caio Marcelo de Oliveira Filho

Re: [Mesa-dev] [PATCH v2] meson: Don't allow building EGL on Windows or MacOS

On Wednesday, 2018-10-10 09:22:46 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-04 07:54:07) > > On Wednesday, 2018-10-03 11:05:36 -0700, Dylan Baker wrote: > > > Quoting Dylan Baker (2018-10-03 10:35:45) > > > > Currently mesa only supports EGL on

[Mesa-dev] [PATCH mesa] st/dri: remove leftover local variable

Left over from the cleanup in 6ccc435e7ad92bb0ba77d "pipe-loader: move dup(fd) within pipe_loader_drm_probe_fd" Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/dri/dri2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/s

Re: [Mesa-dev] [PATCH 1/3] meson: only build clapi tests when OpenGL is being built

On Friday, 2018-10-05 11:05:10 -0700, Dylan Baker wrote: > Otherwise building just vulkan (among other things) will build these > tests, pull in a bunch of stuff they shouldn't, and potentially fail to > compile. Series looks good to me: Reviewed-by: Eric Engestrom > ---

Re: [Mesa-dev] [PATCH mesa] radv: add missing meson c++ visibility arguments

On Monday, 2018-10-08 08:45:18 -0700, Dylan Baker wrote: > Reviewed-by: Dylan Baker > > You could add radv_flags to future safety, but it's not used currently so this > should fix things. Good point, thanks. Added with your r-b and pushed :) > > Quoting Eric Engestr

[Mesa-dev] [PATCH mesa] radv: add missing meson c++ visibility arguments

Fixes: 6f3aee40f90d725653b6 "radv: using tls to store llvm related info and speed up compiles (v10)" Cc: Dave Airlie Signed-off-by: Eric Engestrom --- src/amd/vulkan/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/meson.build

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: don't double free on error in get_presentation_support

isplay_finish(&display); > > > > return ret == 0; > > ... which is still used here. > Also it looks like this calls finish in the error case (result != 0). Agreed. > > Maybe > > int ret = wsi_wl_display_init(wsi, &display, wl_disp

[Mesa-dev] [PATCH mesa] meson: fix vulkan only build with tests

; /usr/bin/ld: src/mapi/glapi/libglapi_static.a(glapi_getproc.c.o):(.data.rel.ro+0x): undefined reference to `gl_dispatch_stub_345' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. Signed-off-by: Eric Engestrom --- src/meson.build | 8 ++--

Re: [Mesa-dev] [PATCH v2] meson: Don't allow building EGL on Windows or MacOS

27;) > > @@ -316,6 +319,8 @@ elif _egl == 'true' > > error('No platforms specified, consider > > -Dplatforms=drm,x11,surfaceless at least') > >elif not ['disabled', 'dri'].contains(with_glx) > > error('EGL

Re: [Mesa-dev] [PATCH mesa 1/3] include: sync eglplatform.h from Khronos

On Tuesday, 2018-10-02 16:32:44 +0100, Emil Velikov wrote: > Hi Eric, > > On Sun, 10 Jun 2018 at 09:36, Eric Engestrom wrote: > > > > An issue [1] was recently raised with the upstream eglplatform.h, as my > > upstreaming of the "X11 on Apple" resulted in

Re: [Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

Ping? I'm just adding `const` to make it easier to read and understand the code, and allow the compiler to tell us if we make a mistake and start modifying things shouldn't. On Tuesday, 2018-08-07 12:02:53 +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- >

[Mesa-dev] [PATCH mesa 4/4] clover: add missing meson build dependency

Fixes: 42ea0631f108d82554339 "meson: build clover" Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/clover/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/clover/meson.build b/src/gallium/state_trackers/clover/meson.b

[Mesa-dev] [PATCH mesa 3/4] svga: add missing meson build dependency

Fixes: a537231b226280bc1e5b7 "meson: build svga driver on linux" Signed-off-by: Eric Engestrom --- src/gallium/drivers/svga/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/svga/meson.build b/src/gallium/drivers/svga/meson.build index 2976212fdf

[Mesa-dev] [PATCH mesa 2/4] anv: add missing meson build dependency

Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" Signed-off-by: Eric Engestrom --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index f1beb1de6a

[Mesa-dev] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Eric Engestrom --- src/mesa/meson.build | 3 +-- src/meson.build | 13 - 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index ea884977db8052d86fcb

[Mesa-dev] [PATCH mesa] anv: suppress warning about unhandled image layout

Let's just be explicit that VK_NV_shading_rate_image is not supported. Suggested-by: Jason Ekstrand Fixes: 6ee17091708a41c4aa81a "vulkan: Update the XML and headers to 1.1.86" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+

[Mesa-dev] [PATCH mesa] egl: sync headers from Khronos

Signed-off-by: Eric Engestrom --- include/EGL/egl.h | 8 include/EGL/eglext.h | 9 + include/EGL/eglplatform.h | 8 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/include/EGL/egl.h b/include/EGL/egl.h index 93a21873c0f3ed850866

Re: [Mesa-dev] [PATCH] radv: Add support for VK_KHR_driver_properties.

On Sunday, 2018-09-30 20:03:49 +0200, Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_device.c | 27 +++ > src/amd/vulkan/radv_extensions.py | 1 + > 2 files changed, 28 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c >

Re: [Mesa-dev] [PATCH] i965: Don't bother to call blorp if the blit is zero-sized

On Monday, 2018-10-01 11:04:09 +0200, Juan A. Suarez Romero wrote: > On Tue, 2018-09-11 at 11:15 -0500, Jason Ekstrand wrote: > > Cc: mesa-sta...@lists.freedesktop.org > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892 > > --- > > src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++ >

Re: [Mesa-dev] Where to send Crucible patches?

On September 26, 2018 11:48:25 PM UTC, Caio Marcelo de Oliveira Filho wrote: > Hi, > > I was a bit unsure about where to send Crucible(*) patches, neither > README or HACKING file has the answer. In #dri-devel channel people > were also not sure. I've ended up sending to piglit mailing list,

[Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 95 - 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 6c9160a445c8f25a8ad5..2a30b1139f06cbb56769

[Mesa-dev] [PATCH mesa 6/6] fixup! vulkan/wsi/display: pass DRM modifiers to the kernel

(split out for review) --- src/vulkan/wsi/wsi_common_display.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 0b71932bfa0939039ae3..1518a1736e424319ab69 100644 --- a/src/vulkan/

[Mesa-dev] [PATCH mesa 2/6] vulkan/wsi/display: also select a plane when selecting a crtc

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 80 + 1 file changed, 80 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 2d378afe3d36fe7cc177..6c9160a445c8f25a8ad5 100644 --- a/src

[Mesa-dev] [PATCH mesa 5/6] vulkan/wsi/display: pass image's DRM modifiers to the kernel

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index c24b58e8c240f43ac512..0b71932bfa0939039ae3 100644 --- a

[Mesa-dev] [PATCH mesa 1/6] vulkan/wsi/display: setup the connector earlier

Instead of setting it up when the swapchain is presented, set it up when creating the swapchain. This means that multiple swapchains might use the same crtc, but only one can be active at a time, and the connectors are now refcounted. This is necessary for the next commit. Signed-off-by: Eric

[Mesa-dev] [PATCH mesa 4/6] vulkan/wsi/display: add comment

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 2a30b1139f06cbb56769..c24b58e8c240f43ac512 100644 --- a/src/vulkan/wsi

Re: [Mesa-dev] [PATCH] meson: de-duplicate LLVM check

On Monday, 2018-09-24 09:34:34 -0700, Dylan Baker wrote: > by adding `_llvm == 'true'` to the required argument we can check the > 'auto' and 'true' case in one path. Reviewed-by: Eric Engestrom > --- > meson.build | 23 --- >

[Mesa-dev] [PATCH mesa v2] gallivm: ensure string is null-terminated instead of assert()ing

Signed-off-by: Eric Engestrom --- v2: Use the util_* wrapper to make sure MSVC stays happy (Dylan) --- src/gallium/auxiliary/gallivm/lp_bld_printf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_printf.c b/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH] vulkan: Disable randr lease for libxcb < 1.13

+Cc Keith, Jason & Daniel, who know this code best. On Monday, 2018-09-24 08:46:22 +1000, Stuart Young wrote: > From: Maxime > > Since the Randr lease code was added, compiling against libxcb 1.12 no > longer works. > > CC: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.

Re: [Mesa-dev] [PATCH mesa 1/2] docs: update repo URLs after GitLab move

On Friday, 2018-09-21 16:29:48 +0100, Emil Velikov wrote: > On 21 September 2018 at 14:46, Eric Engestrom > wrote: > > I also updated the developer instructions; presumably someone who's been > > given commit rights already knows how to clone a repository :) > >

Re: [Mesa-dev] [PATCH mesa 2/6] nouveau: silence paranoid compiler's -Wclass-memaccess

ase. > > > > On Sat, Sep 22, 2018 at 6:07 AM, Ilia Mirkin wrote: > > > Based on the various fixes, warning seems bogus -- is the proper > > > solution -Wno-class-memaccess? (Or however one disables such > > > things...) > > > > > > O

[Mesa-dev] [PATCH mesa 3/6] r600: silence paranoid compiler's -Wclass-memaccess

Signed-off-by: Eric Engestrom --- src/gallium/drivers/r600/sb/sb_expr.cpp | 10 +- src/gallium/drivers/r600/sb/sb_if_conversion.cpp | 4 ++-- src/gallium/drivers/r600/sb/sb_ir.h | 2 +- src/gallium/drivers/r600/sb/sb_peephole.cpp | 4 ++-- 4 files changed

[Mesa-dev] [PATCH mesa 5/6] meson: make it trivial to add other -Wno-foo CFLAGS

Signed-off-by: Eric Engestrom --- meson.build | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 7b7bf4d8e609c92bbd06..863962186caa6afe8ae4 100644 --- a/meson.build +++ b/meson.build @@ -790,9 +790,12 @@ foreach a : ['-Wall',

[Mesa-dev] [PATCH mesa 6/6] meson+autotools: get rid of spammy GCC warning -Wformat-truncation

n we *know* that "/dev/dri/cardN" is not gonna be 4096 char long and it's safe to store it in a 32-char array). Anyway, we either add a ton of dead code all over the place to make GCC happy, or we get rid of its spam. I chose the latter. Signed-off-by: Eric Engestrom --- configu

[Mesa-dev] [PATCH mesa 4/6] gallivm: ensure string is null-terminated instead of assert()ing

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/gallivm/lp_bld_printf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_printf.c b/src/gallium/auxiliary/gallivm/lp_bld_printf.c index 575ebdfdf65b7fd43b94..cbfa278728b4ec8f4624

<    1   2   3   4   5   6   7   8   9   10   >