Re: [Mesa-dev] [PATCH] glsl: remove GCC construct from VECN macro

Am 27.03.2018 um 00:44 schrieb Rob Clark: > On Mon, Mar 26, 2018 at 6:38 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Mar 26, 2018 at 6:07 PM, Roland Scheidegger <srol...@vmware.com> >> wrote: >>> Am 26.03.2018 um 23:01 schrieb Rob Clark: >>>&

Re: [Mesa-dev] [PATCH] glsl: remove GCC construct from VECN macro

her compilers such as the Intel one or MSVC. >>> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105740 >>> Fixes: f407edf3407396379e16b0be74b8d3b85d2ad7f0 >>> Cc: Rob Clark <robdcl...@gmail.com> >>> Cc: Timothy Arceri <tarc...@i

Re: [Mesa-dev] [PATCH 2/4] gallium: add initial support for conservative rasterization

Am 22.03.2018 um 00:43 schrieb Ilia Mirkin: > On Wed, Mar 21, 2018 at 7:37 PM, Roland Scheidegger <srol...@vmware.com> > wrote: >> Personally I'm not a big proponent on propagating single-vendor >> extensions (which are useless for anything but one specific driver)

Re: [Mesa-dev] [PATCH 2/4] gallium: add initial support for conservative rasterization

Personally I'm not a big proponent on propagating single-vendor extensions (which are useless for anything but one specific driver) more or less directly through to gallium. There's an intel extension doing similar things already too. Ideally we'd end up with some bits in gallium which can do

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

Am 13.03.2018 um 05:28 schrieb Dave Airlie: > On 13 March 2018 at 14:24, Dave Airlie wrote: >> This is the main code for the soft fp64 work. It's mostly Elie's >> code with a bunch of changes by me. >> > > All the patches are in my tree here, along with some other bits: >

Re: [Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

Am 14.03.2018 um 02:05 schrieb Dave Airlie: > On 14 March 2018 at 10:46, Roland Scheidegger <srol...@vmware.com> wrote: >> Am 13.03.2018 um 05:24 schrieb Dave Airlie: >>> From: Elie Tournier <tournier.e...@gmail.com> >>> >>> v2: use mix.

Re: [Mesa-dev] [PATCH 15/50] glsl: Add "built-in" functions to do sqrt(fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > This currently uses fp64->fp32, sqrt(fp32), fp32->fp64. > > [airlied: The code is include from soft float for doing proper sqrt64 > but it needs to be decided if we need to pursue this and > how to

Re: [Mesa-dev] [PATCH 06/50] glsl: Add "built-in" functions to do lt(fp64, fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 135 > > src/compiler/glsl/builtin_functions.cpp | 4 +

Re: [Mesa-dev] [PATCH 04/50] glsl: Add "built-in" functions to do eq(fp64, fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 104 > > src/compiler/glsl/builtin_functions.cpp | 4 ++

Re: [Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > v2: use mix. > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 28 >

Re: [Mesa-dev] [PATCH 02/50] glsl: Add "built-in" functions to do neg(fp64) (v2)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > v2: use mix. > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 51 > + >

Re: [Mesa-dev] [PATCH] cmake: Warn that MSVC is unmaintained.

Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 12.03.2018 um 10:19 schrieb Jose Fonseca: > It has been broken for a while, and not much interest from our side > in keeping it going, as most of us are using MinGW cross-compilers > anyway. > > I'm not sure if t

Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

Looks great to me. (I think I even mentioned it looked odd to me that stack workarounds looked different on non-sb when I extended the sb workaround logic to exclude hemlock...) Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 09.03.2018 um 07:09 schrieb Dave Airlie: > From: Da

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

t cleanup to me too.  Just minor issues inline. Both are > > Reviewed-by: Jose Fonseca <jfons...@vmware.com> >> >> On 03/06/2018 01:34 PM, srol...@vmware.com wrote: >>> From: Roland Scheidegger <srol...@vmware.com> >>> >>> The motivation actu

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

Am 06.03.2018 um 21:52 schrieb Brian Paul: > Looks good.  That certainly does simplify things.  Two minor suggestions > below. > > In any case, for both, Reviewed-by: Brian Paul <bri...@vmware.com> > > On 03/06/2018 01:34 PM, srol...@vmware.com wrote: >>

Re: [Mesa-dev] [PATCH 4/4] glxinfo/wglinfo: improve GL_ARB_imaging query code

Am 06.03.2018 um 17:10 schrieb Emil Velikov: > On 5 March 2018 at 16:53, Brian Paul wrote: >> Print GL_MAX_CONVOLUTION_WIDTH, HEIGHT on separate lines. >> Print GL_MAX_COLOR_MATRIX_STACK_DEPTH in same section. >> --- >> src/xdemos/glinfo_common.c | 13 - >> 1 file

Re: [Mesa-dev] [PATCH] tgsi/scan: use wrap-around shift behavior explicitly for file_mask

Am 02.03.2018 um 08:41 schrieb Jose Fonseca: > On 02/03/18 02:23, Brian Paul wrote: >> On 03/01/2018 07:01 PM, srol...@vmware.com wrote: >>> From: Roland Scheidegger <srol...@vmware.com> >>> >>> The comment said it will only represent the lowest 32 regs.

Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

Am 01.03.2018 um 03:28 schrieb Ilia Mirkin: > On Wed, Feb 28, 2018 at 8:42 PM, Roland Scheidegger <srol...@vmware.com> > wrote: >> I suppose that's ok (and safer), albeit I'm not sure why it wouldn't >> work with nv50. >> Depth clip is enabled, yes, but I can

Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

, but there's extensions for it (NV_depth_buffer_float), so I'm a bit confused. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 01.03.2018 um 01:43 schrieb Ilia Mirkin: > These were getting mapped off into outer space, which would cause nv50 > and nvc0 to clip th

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

Am 28.02.2018 um 18:18 schrieb Dylan Baker: > Quoting Eric Engestrom (2018-02-28 09:08:41) >> On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: >>> On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

Am 28.02.2018 um 11:54 schrieb Jose Fonseca: > On 27/02/18 02:38, srol...@vmware.com wrote: >> From: Roland Scheidegger <srol...@vmware.com> >> >> Some state trackers require 128. >> (There are no plans to increase PIPE_MAX_SAMPLERS too, since with gl >> s

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

Am 27.02.2018 um 19:07 schrieb Roland Scheidegger: > Am 27.02.2018 um 17:39 schrieb Brian Paul: >> On 02/26/2018 07:45 PM, Roland Scheidegger wrote: >>> Am 27.02.2018 um 03:38 schrieb srol...@vmware.com: >>>> From: Roland Scheidegger <srol...@vmware.com> >&

Re: [Mesa-dev] [PATCH] nir: fix divide by zero crash during constant folding

I think you just have to rely on the default of them being disabled. It is a bug of an app calling into mesa with non-default float state. Roland Am 28.02.2018 um 04:35 schrieb Jason Ekstrand: > On Tue, Feb 27, 2018 at 7:28 PM, Connor Abbott >

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Not my area of expertise, but sure. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 27.02.2018 um 20:14 schrieb Francisco Jerez: > Do you care enough to give me a reviewed-by so I could land it right > away? > > Roland Scheidegger <srol...@vmware.com> writes: >

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

orge.kyria...@intel.com>> >> >> On Feb 25, 2018, at 6:52 PM, Roland Scheidegger >> <srol...@vmware.com<mailto:srol...@vmware.com>> wrote: >> >> Am 25.02.2018 um 21:12 schrieb Francisco Jerez: >> Roland Scheidegger <srol...@vmware.com<mail

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

Am 27.02.2018 um 17:39 schrieb Brian Paul: > On 02/26/2018 07:45 PM, Roland Scheidegger wrote: >> Am 27.02.2018 um 03:38 schrieb srol...@vmware.com: >>> From: Roland Scheidegger <srol...@vmware.com> >>> >>> Some state trackers require 128. >>> (T

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

Am 27.02.2018 um 03:38 schrieb srol...@vmware.com: > From: Roland Scheidegger <srol...@vmware.com> > > Some state trackers require 128. > (There are no plans to increase PIPE_MAX_SAMPLERS too, since with gl > state tracker it's unlikely more than 32 will be needed, if you nee

Re: [Mesa-dev] [PATCH 11/22] nir: Recognize some more open-coded fmin / fmax

Am 26.02.2018 um 23:21 schrieb Ian Romanick: > On 02/23/2018 05:14 PM, Jason Ekstrand wrote: >> On Fri, Feb 23, 2018 at 3:55 PM, Ian Romanick > > wrote: >> >> From: Ian Romanick >

Re: [Mesa-dev] Mesa (master): glsl: Switch ast_type_qualifier to a 128-bit bitset.

Am 26.02.2018 um 18:52 schrieb Kyriazis, George: > Hello Francisco, > > This change breaks my ubuntu 16.04 build with gcc 5.4.0. Here’t where it > breaks: > > CXX glsl/glsl_lexer.lo > In file included from ../../../src/compiler/glsl/glsl_lexer.ll:27:0: >

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Am 25.02.2018 um 21:12 schrieb Francisco Jerez: > Roland Scheidegger <srol...@vmware.com> writes: > >> Am 25.02.2018 um 03:35 schrieb Francisco Jerez: >>> Roland Scheidegger <srol...@vmware.com> writes: >>> >>>> This seems to have broken com

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

This seems to have broken compilation with some gcc versions (with scons build): In file included from src/compiler/glsl/ast_array_index.cpp:24:0: src/compiler/glsl/ast.h:648:16: error: member ‘ast_type_qualifier::bitset_t ast_type_qualifier::flags::i’ with constructor not allowed in union

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Am 25.02.2018 um 03:35 schrieb Francisco Jerez: > Roland Scheidegger <srol...@vmware.com> writes: > >> This seems to have broken compilation with some gcc versions (with scons >> build): >> >> In file included from src/compiler/glsl/ast_array_index.cpp:24:

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

Am 22.02.2018 um 08:58 schrieb Alejandro Piñeiro: > On 30/01/18 01:24, Roland Scheidegger wrote: >> Am 29.01.2018 um 17:03 schrieb Alejandro Piñeiro: >>> On 29/01/18 16:38, Roland Scheidegger wrote: >>>> Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: >>>&

Re: [Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

Looks great. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 22.02.2018 um 17:29 schrieb Jose Fonseca: > The MSVC version we (at VMware) primarily care about from now on is > 2015. > > We can drop support for building with 2013 in a future commit. I'm not > aware o

Re: [Mesa-dev] [PATCH] gallium: drop all the guard band float caps.

-by: Roland Scheidegger <srol...@vmware.com> Am 12.02.2018 um 20:32 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > Nobody queries these and nobody sets them to anything useful, > the docs say TODO. > > Drop them until a use appears. > &

Re: [Mesa-dev] [PATCH 03/17] gallium/llvmpipe: Fix compiler warnings about ddx/ddy/ddmax.

I'm wondering if it would help if no_rho_opt were const. But I suppose the problem there really is that the for loop and the if condition have swapped order the second time. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 10.02.2018 um 17:32 schrieb Eric Anholt: > My gcc doesn

Re: [Mesa-dev] [PATCH 2/2] gallium/util: silence clang warning in blitter code

For the series: Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 08.02.2018 um 18:02 schrieb Brian Paul: > Silence "warning: comparison of constant 4294967295 with expression > of type 'ubyte'". > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1

Re: [Mesa-dev] [PATCH 10/10] tgsi: use TGSI_INTERPOLATE_x arguments instead of zeros in ureg code

For the series: Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 08.02.2018 um 03:17 schrieb Brian Paul: > TGSI_INTERPOLATE_CONSTANT and TGSI_INTERPOLATE_LOC_CENTER have the > value zero so there's no change in behavior. It seems funny to > declare these fs input register

Re: [Mesa-dev] [PATCH] r600: fix texture gather swizzling.

@@ static int tgsi_tex(struct r600_shader_ctx *ctx) > > if (ctx->bc->chip_class == CAYMAN) { > /* GATHER4 result order is different from TGSI TG4 */ Maybe move the comment to the else clause. Reviewed-by: Roland Scheidegger <srol...@vmware.com> > -

Re: [Mesa-dev] [PATCH 2/5] st/mesa: don't check for ARB_draw_buffers_blend in update_blend

Am 07.02.2018 um 23:56 schrieb Timothy Arceri: > > On 01/02/18 06:55, Marek Olšák wrote> From: Marek Olšák > >> >> If the GL API is missing, different blend functions can't be set >> through GL. > > Looking at the commit that added this a476ca1fd1b4e7 the commit message is:

Re: [Mesa-dev] [PATCH] r600: fix rendering regression on r6/7 gpus

t.com> Looks alright to me. It's quite easy to miss changes to family-specific code (if those parts are separate) indeed... Reviewed-by: Roland Scheidegger <srol...@vmware.com> > --- > src/gallium/drivers/r600/r600_state.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(

Re: [Mesa-dev] [PATCH 6/6] tgsi: use tgsi_semantic enum type in ureg code

Looks alright to me. For the series: Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 07.02.2018 um 06:30 schrieb Brian Paul: > --- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 24 > src/gallium/auxiliary/tgsi/tgsi_ureg.h | 22 +++---

Re: [Mesa-dev] [PATCH 1/6] gallium/util: replace unsigned with tgsi enum types

ure_type tex_target, > + enum tgsi_interpolate_mode > interp_mode, > + bool load_level_zero, > + bool use_txf) Here and below, indentation? Albe

Re: [Mesa-dev] [PATCH] r600/atomic: fix ATOMCAS instruction.

Am 05.02.2018 um 07:47 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > This has 3 srcs. Depends on how you count :-). Reviewed-by: Roland Scheidegger <srol...@vmware.com> > > This fixes: > KHR-GL45.shader_atomic_counter_ops_tests.ShaderAt

Re: [Mesa-dev] [PATCH 3/9] r600: overhaul buffer resource query.

Am 06.02.2018 um 06:04 schrieb Dave Airlie: > On 6 February 2018 at 14:12, Roland Scheidegger <srol...@vmware.com> wrote: >> Am 05.02.2018 um 05:29 schrieb Dave Airlie: >>> From: Dave Airlie <airl...@redhat.com> >>> >>> This cleans up and fixes

Re: [Mesa-dev] [PATCH] r600/sb/cayman: fix indirect ubo access on cayman

xes: > KHR-GL45.gpu_shader5.uniform_blocks_array_indexing > (on cayman with sb) > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Roland Scheidegger <srol...@vmware.com> > --- > src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 2 +- > 1 file changed, 1 inser

Re: [Mesa-dev] [PATCH] r600: fixup sparse color exports.

d to record the highest one written to write to the > ps exports reg. > > This fixes: > KHR-GL45.enhanced_layouts.fragment_data_location_api Does that mean there's actually a performance benefit when there's no gaps? That's something the APIs wouldn't tell you :-). Reviewed-by:

Re: [Mesa-dev] [PATCH 9/9] r600: work out target mask at framebuffer bind.

For 7-9/9 Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 05.02.2018 um 05:29 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > If we only get 1,2,3,6 framebuffers we want a sparse target mask. > > Signed-off-by: Dave Airlie <airl...@re

Re: [Mesa-dev] [PATCH 8/9] r600: work out shader export mask at shader build time

Am 05.02.2018 um 05:29 schrieb Dave Airlie: > From: Dave Airlie > > Since enhanced layouts allows setting specific MRT outputs, we > can get sparse outputs, so we have to calculate the shader > mask earlier. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 6/9] r600/compute: only mark buffer/image state dirty for fragment shaders

ly use the ordinary atom list, maybe there should be a separate atom list really? Seems like dirty handling for compute in general could need some improvement. In any case, I suppose that'll have to do for now, so for 4-6/9 Reviewed-by: Roland Scheidegger <sorl...@vmware.com> > --- >

Re: [Mesa-dev] [PATCH 3/9] r600: overhaul buffer resource query.

stick to the offset parameter here. Just add both together in the caller - as far as this function is concerned two offsets don't really make sense. Other than that, and for 1-3/9 Reviewed-by: Roland Scheidegger <srol...@vmware.com> > { > struct tgsi_full_instruction *inst =

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

Am 05.02.2018 um 03:04 schrieb Roland Scheidegger: > Am 04.02.2018 um 20:13 schrieb Dave Airlie: >> On 2 February 2018 at 18:02, Roland Scheidegger <srol...@vmware.com> wrote: >>> Are you sure of that? You only get 11 stride bits to program, and they >>> are in byt

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

Am 04.02.2018 um 20:13 schrieb Dave Airlie: > On 2 February 2018 at 18:02, Roland Scheidegger <srol...@vmware.com> wrote: >> Are you sure of that? You only get 11 stride bits to program, and they >> are in bytes. Therefore I can't see how you could program 2048 (unless >&

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

Am 03.02.2018 um 03:12 schrieb Marek Olšák: > On Sat, Feb 3, 2018 at 2:55 AM, Roland Scheidegger <srol...@vmware.com> wrote: >> Am 03.02.2018 um 00:31 schrieb Marek Olšák: >>> On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger <srol...@vmware.com> >>> wro

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

Am 03.02.2018 um 00:31 schrieb Marek Olšák: > On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger <srol...@vmware.com> > wrote: >> Am 02.02.2018 um 23:39 schrieb Marek Olšák: >>> On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger <srol...@vmware.com> >&

Re: [Mesa-dev] [PATCH] r600/eg: use texture target to pick array size not view target (v2)

030000_DIM(dim) | > S_03_PITCH((pitch / 8) - 1) | >S_03_TEX_WIDTH(width - 1)); > This looks otherwise alright to me. Reviewed-by: Roland Scheidegger <srol...@vmware.com> FWIW there's some bits just below which also c

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

Am 02.02.2018 um 23:39 schrieb Marek Olšák: > On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger <srol...@vmware.com> > wrote: >> Am 02.02.2018 um 21:48 schrieb Marek Olšák: >>> Hi, >>> >>> This is the second and hopefully final versi

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

Am 02.02.2018 um 21:48 schrieb Marek Olšák: > Hi, > > This is the second and hopefully final version of 32-bit pointer > support for radeonsi. > > Constant buffer 0 now has restrictions on which buffers can be set > in that slot. > > I plan to push this when my LLVM patch lands in 6.0

Re: [Mesa-dev] [PATCH] r600/fp64: fix integer->double conversion

t;bc, ); > + if (r) > + return r; > + } > } That'll still work on eg (cypress) where UINT_TO_FLT is scalar, right? I just realized that for the low 8 bits you could actually skip the masking and use

Re: [Mesa-dev] [PATCH] r600: fix resq for buffer images.

[0].Register.File == TGSI_FILE_IMAGE) > + offset += R600_IMAGE_REAL_RESOURCE_OFFSET - > R600_MAX_CONST_BUFFERS + ctx->shader->image_size_const_offset; Can't the offset actually be handled by r600_do_buffer_txq() somehow? I'm always getting very confused about those o

Re: [Mesa-dev] [PATCH] r600: don't do stack workarounds for hemlock

Am 02.02.2018 um 12:16 schrieb Emil Velikov: > Hi Roland, > > On 30 January 2018 at 05:07, <srol...@vmware.com> wrote: >> From: Roland Scheidegger <srol...@vmware.com> >> >> By the looks of it it seems hemlock is treated separately to cypress, but >>

Re: [Mesa-dev] [PATCH] r600/eg: fix cube map array buffer images.

Oops my bad... Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 02.02.2018 um 07:57 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > This fixes a crash in: > KHR-GL45.texture_cube_map_array.texture_size_compute_sh. > > Signed-off-by: D

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am 02.02.2018 um 07:53 schrieb Gert Wollny: > Am Freitag, den 02.02.2018, 02:13 +0100 schrieb Roland Scheidegger: >> Am 30.01.2018 um 09:21 schrieb Gert Wollny: >>> Although gl_SampleMaskIn is declared as an array in GLSL, it is >>> effectively a 32 bit mask on all har

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

Are you sure of that? You only get 11 stride bits to program, and they are in bytes. Therefore I can't see how you could program 2048 (unless the hw would interpet 0 as 2048 but I think stride 0 is valid there?). Roland Am 02.02.2018 um 07:23 schrieb Dave Airlie: > From: Dave Airlie

Re: [Mesa-dev] [PATCH] r600/eg: add crap indirect compute support.

That's not much "indirect" the way it's done, but looks alright to me ;-). Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 30.01.2018 um 03:22 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > I think the cp packets can be made work, but I

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am 30.01.2018 um 09:21 schrieb Gert Wollny: > Although gl_SampleMaskIn is declared as an array in GLSL, it is > effectively a 32 bit mask on all hardware supported by mesa, so the > array indexing is ignored (Thanks Glenn Kennard for the explanation). > > Add a comment that the assert is not made

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

Am 02.02.2018 um 00:23 schrieb Dave Airlie: > On 2 February 2018 at 09:23, Dave Airlie <airl...@gmail.com> wrote: >> On 2 February 2018 at 02:05, Roland Scheidegger <srol...@vmware.com> wrote: >>> Am 01.02.2018 um 09:21 schrieb Dave Airlie: >>>

Re: [Mesa-dev] [PATCH] gallivm/llvmpipe: add const qualifiers on sampler variables

Makes sense. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 01.02.2018 um 21:18 schrieb Brian Paul: > Once a lp_build_sampler_soa or lp_build_sampler_aos object is created, > it should never be modified. Found by inspection. > --- > src/gallium/auxiliary/draw/draw_l

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

I suppose this is a bit inefficient if the hw actually supports some double ops? I mean for uint->double you could just convert the low 8 bits and high 24 bits (or different split) separately to float, convert both to double and add them. (I think should work for int->double exactly the same

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

if ((r = r600_bytecode_add_vtx_tc(ctx->bc, ))) > + return r; > + ctx->bc->cf_last->vpm = 1; > + > + /* compare the result with 0 */ > + memset(, 0, sizeof(struct r600_bytecode_alu)); > + alu.op = ALU_OP3_CNDE_INT; > + alu.is

Re: [Mesa-dev] [PATCH] r600/cayman: initial attempt at gl_HelperInvocation (v2)

Looks good to me (albeit disabling sb is a shame). Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 01.02.2018 um 03:19 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > This is a cayman only patch, it doesn't appear that > evergreen supports

Re: [Mesa-dev] [PATCH] r600/eg: make sure we allow vpm bit on other CF ops.

Looks alright to me (albeit I still don't really understand what this bit does with the various clauses...) Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 01.02.2018 um 03:01 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > the vpm bit wasn't bein

Re: [Mesa-dev] [PATCH] r600: fix buffer resinfo opcode translation.

Ah I see now how that's supposed to work... Previous to adding GET_BUFFER_RESINFO the op was just a fixed zero, and the op for this is the same on eg/cm (and we should not hit it with r600). But indeed that looks more like the code elsewhere... Reviewed-by: Roland Scheidegger <srol...@vmware.

Re: [Mesa-dev] [PATCH 1/5] mesa: change ctx->Color.ColorMask into a 32-bit bitmask

Am 31.01.2018 um 20:55 schrieb Marek Olšák: > From: Marek Olšák > > 4 bits per draw buffer, 8 draw buffers in total --> 32 bits. > > This is easier to work with. > --- > src/mesa/drivers/common/driverfuncs.c| 8 ++-- > src/mesa/drivers/common/meta.c

Re: [Mesa-dev] [PATCH] mesa: fix broken glGet*(GL_POLYGON_MODE) query

I wasn't sure if someone wanted to fix it by using special getter for it, but it might not be worth the trouble... Thanks! Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 31.01.2018 um 03:35 schrieb Brian Paul: > This reverts part of the patch which introduced the GLenum

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

FWIW the same commit also broke conform (completely - it will refuse to run even a single test due to failing mustpass). Default State test failed. State Report. (Current) <-> (Default) GL_POLYGON_MODE (State Information) GL_FILL -1 (Bad enumeration) <-> GL_FILL GL_FILL

Re: [Mesa-dev] [PATCH] mesa: remove invalid assertion in _mesa_enable_vertex_array_attrib()

Should the meta module not do this? In any case, Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 30.01.2018 um 18:14 schrieb Brian Paul: > The meta module passes some 0-based attrib values. Should fix Piglit > regressions reported by Mark Janes. > >

Re: [Mesa-dev] [PATCH] r600/sb: insert the else clause when we might depart from a loop

Makes sense to me, albeit I don't really quite understand sb... Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 30.01.2018 um 07:40 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > If there is a break inside the else clause and this means we >

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

Am 29.01.2018 um 17:03 schrieb Alejandro Piñeiro: > On 29/01/18 16:38, Roland Scheidegger wrote: >> Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: >>> >>> On 27/01/18 12:09, Roland Scheidegger wrote: >>>> Am 27.01.2018 um 09:52 schrieb Alejandro

Re: [Mesa-dev] [PATCH] r600/sb: Force ELSE path if the byte code started off with it

Am 29.01.2018 um 13:15 schrieb Gert Wollny: > sb optimized away the ELSE in a construct like > >while (foo) { > if (bar ) { > do something; > } else { > break; > } >} > > resulting in > >while (foo) { > if (bar ) { > do something; >

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: > > > On 27/01/18 12:09, Roland Scheidegger wrote: >> Am 27.01.2018 um 09:52 schrieb Alejandro Piñeiro: >>> On 27/01/18 01:59, srol...@vmware.com wrote: >>>> From: Roland Scheidegger <srol...@vmware.com&g

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

Am 27.01.2018 um 09:52 schrieb Alejandro Piñeiro: > On 27/01/18 01:59, srol...@vmware.com wrote: >> From: Roland Scheidegger <srol...@vmware.com> >> >> The size/type query is always legal (if we made it that far). >> This causes a difference f

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 26.01.2018 um 14:13 schrieb Antia Puentes: > Hi Roland, > > On 26/01/18 13:57, Roland Scheidegger wrote: >> Am 26.01.2018 um 11:31 schrieb Antia Puentes: >>> On 25/01/18 18:56, Roland Scheidegger wrote: >>> >>>> Am 25.01.2018 um 17:56 schrieb Rol

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 26.01.2018 um 11:31 schrieb Antia Puentes: > On 25/01/18 18:56, Roland Scheidegger wrote: > >> Am 25.01.2018 um 17:56 schrieb Roland Scheidegger: >>> Am 25.01.2018 um 16:30 schrieb Michel Dänzer: >>>> On 2018-01-24 05:38 PM, Juan A. Suarez Romero

Re: [Mesa-dev] [PATCH 3/4] r600: add ARB_query_buffer_object support

.chan = 2; > + alu.last = 1; > + r = r600_bytecode_add_alu(ctx->bc, ); > + if (r) > + return r; > + memset(, 0, sizeof(struct r600_bytecode_alu)); > + alu.op = ALU_OP1_MOV; > + tgsi_dst(ctx, >Dst[0], 0, ); > + alu.src[0].sel = treg; > + alu.src[0].chan = 0; > + alu.last = 1; > + r = r600_bytecode_add_alu(ctx->bc, ); > + if (r) > + return r; > + return 0; > +} But in any case, looks great to me (albeit I didn't check the math really - that udiv is complex...) For the series: Reviewed-by: Roland Scheidegger <srol...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 25.01.2018 um 17:56 schrieb Roland Scheidegger: > Am 25.01.2018 um 16:30 schrieb Michel Dänzer: >> On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >>> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >>> --- >>> src/mesa/main/fbobject.c | 3 +

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

to store a new image. > + */ > +static struct drawpix_cache_entry * > +find_oldest_drawpixels_cache_entry(struct st_context *st) > +{ > + unsigned oldest_age = ~0u, oldest_index = ~0u; > + unsigned i; > + > + /* Find entry with oldest (lowest) age */ > + for (i = 0; i

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Am 25.01.2018 um 16:30 schrieb Michel Dänzer: > On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >> --- >> src/mesa/main/fbobject.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH] mesa: simplify _mesa_delete_list() a bit, add some assertions

n += InstSize[n[0].opcode]; > -break; > +/* just increment 'n' pointer, below */ > +; > + } > + > + if (opcode != OPCODE_CONTINUE && opcode != OPCODE_END_OF_LIST) { I think you should just omit the test against OPC

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

; + unsigned i; > + > + /* Find entry with oldest (lowest) age */ > + for (i = 0; i < ARRAY_SIZE(st->drawpix_cache.entries); i++) { > + const struct drawpix_cache_entry *entry = > >drawpix_cache.entries[i]; > + if (entry->age < o

Re: [Mesa-dev] [PATCH] st/mesa: add some debug code in st_choose_format()

Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 25.01.2018 um 00:19 schrieb Brian Paul: > To aid in debugging gallium surface format selection issues. > --- > src/mesa/state_tracker/st_format.c | 23 ++- > 1 file changed, 18 insertions(+), 5 dele

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

Am 22.01.2018 um 08:16 schrieb Tapani Pälli: > > > On 01/22/2018 08:48 AM, Ilia Mirkin wrote: >> What es3 does require, though, is mrt. Maybe add something that >> ensures that mrt is supported? > > I guess that would be EXT_draw_buffers? That is currently enabled with > 'dummy_true'. But only

Re: [Mesa-dev] [PATCH 17/17] vbo: whitespace/formatting fixes in vbo_split_inplace.c

Looks all good to me albeit I'm still no vbo expert... For the series: Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 19.01.2018 um 18:47 schrieb Brian Paul: > --- > src/mesa/vbo/vbo_split_inplace.c | 215 > --- > 1 file chang

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

Am 18.01.2018 um 20:26 schrieb Kyriazis, George: >> On Jan 18, 2018, at 1:10 PM, Roland Scheidegger <srol...@vmware.com >> <mailto:srol...@vmware.com>> wrote: >> >> Am 17.01.2018 um 23:33 schrieb George Kyriazis: >>> The texture swizzle was not doing

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

Am 18.01.2018 um 20:35 schrieb Dave Airlie: > On 19 January 2018 at 04:30, Roland Scheidegger <srol...@vmware.com> wrote: >> Looks good to me, seems like you're nearly done with gl 4.5 ;-) > > Thanks, > > I've mostly written qbo support I think (the 64-bit int divide

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

Am 17.01.2018 um 23:33 schrieb George Kyriazis: > The texture swizzle was not doing the right thing for avx512-style > 16-wide loads. > > Special-case the post-load swizzle operations for avx512 so that we move > the xyzw components correctly to the outputs. > > cc: Jose Fonseca

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

Looks good to me, seems like you're nearly done with gl 4.5 ;-) Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 18.01.2018 um 05:11 schrieb Dave Airlie: > From: Dave Airlie <airl...@redhat.com> > > Only one piglit test fails, > sso-vs-gs-fs-array-interleave >

Re: [Mesa-dev] [PATCH] r600: fix relocs for PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE query

Am 17.01.2018 um 13:54 schrieb Nicolai Hähnle: > On 11.01.2018 23:54, srol...@vmware.com wrote: >> From: Roland Scheidegger <srol...@vmware.com> >> >> The command parser is very sad if we don't emit the relocs per hw >> query... >> >> However,

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

Looks alright to me. Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 17.01.2018 um 23:57 schrieb Brian Paul: > The optimization in change 8e4efdc895ea ("vbo: optimize some display > list drawing") missed the loopback case. This is used when the > glBegin/E

Re: [Mesa-dev] [PATCH] mesa/program: change validate_inputs() local var 'inputs' to GLbitfield64

Reviewed-by: Roland Scheidegger <srol...@vmware.com> Am 17.01.2018 um 06:18 schrieb Brian Paul: > Both state->prog->info.inputs_read and state->InputsBound are GLbitfield64 > so it seems that the OR of those values should be of the same type. > I'm not sure this fixes

<    1   2   3   4   5   6   7   8   9   10   >