Re: [Mesa-dev] [PATCH 03/13] dri: Add config attributes for color channel shift

Emil Velikov wrote: > On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > diff --git a/src/mesa/drivers/dri/common/utils.c > > b/src/mesa/drivers/dri/common/utils.c > > index 5a66bcf..1fdc160 100644 > > --- a/src/mesa/drivers/dri/common/utils.c > > +++ b/src/mesa/drivers/dri/common/utils.c >

Re: [Mesa-dev] [PATCH 02/13] drm-uapi: Add fp16 formats to drm_fourcc.h

Emil Velikov wrote: > Changes to drm-uapi should land in the kernel drm-next before being merged > here. > Otherwise we may end up with mesa and kernel using different > definitions, resulting in broken code :-( Sure, but we need userspace to be ready before landing new uapi in the kernel. Maybe

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

Emile Velikov wrote: > JFYI: > Checking the offending commit (like below) allows us to better track > where the patch is need plus it gives you a few automatic reviewers > ;-) > > Cc: Chad Versace > Cc: Eric Engestrom > Fixes: cd717cbe1a6 ("egl/dri2: Declare loop vars inside the loop") > >

Re: [Mesa-dev] [PATCH 13/13] wayland: Add buffer handling and visuals for fp16 formats

Daniel Stone wrote: > On Mon, 28 Jan 2019 at 18:43, Kevin Strasser wrote: > > Set loader caps indicating that wayland can handle both rgba ordering and > > fp16 formats. > > > > NOTE: This requries libwayland to provide definitions for > > WL_SHM_FORMAT_XBGR16161616F and

Re: [Mesa-dev] [PATCH 00/13] Enable fp16 visuals and fbconfigs

Adam Jackson wrote: > On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote: > > This series enables fp16 fbconfigs and visuals by leveraging existing > > off-screen rendering support. > > > > These formats can be used in conjunction with > > EXT_surface_SMPTE2086_metadata (not yet

Re: [Mesa-dev] [PATCH 11/13] gallium: Add buffer and configs handling or fp16 formats

Adam Jackson wrote: > On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote: > > Expose configs when allow_fp16_configs has been enabled and > > DRI_LOADER_CAP_FP16 is set in the loader. > > > > Also, make kms_swrast_dri respect format bpp, to allow for allocating > > buffers wider than 32 bpp.

Re: [Mesa-dev] [PATCH 04/13] egl: Convert configs to use shifts instead of masks

Adam Jackson wrote: > On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote: > > @@ -237,19 +268,35 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig > > *dri_config, int id, > > break; > > > >case __DRI_ATTRIB_RED_MASK: > > - dri_masks[0] = value; > > +

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

Adam Jackson wrote: > On Wed, 2019-01-16 at 17:58 +0000, Strasser, Kevin wrote: > > Adam Jackson wrote: > > > > > Probably what I'd do is only define those masks to non-zero for <=32bpp > > > formats, > > > > Not sure if I understood this state

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

Adam Jackson wrote: > On Wed, 2019-01-16 at 04:41 +0000, Strasser, Kevin wrote: > > Emil Velikov wrote: > > > > > > Please split this up a bit. I'm thinking of: > > > - dri_interface > > > - mesa > > > - egl > > > - gbm &g

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

Emil Velikov wrote: > Hi Kevin, > > Thanks for that massive undertaking in addressing this. Sure thing! > On 2019/01/04, Kevin Strasser wrote: > > The dri core api was written with the assumption that all attribute > > values would fit into 32 bits. This limitation means the config > > handlers

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

Adam Jackson wrote: > > On Fri, 2019-01-11 at 15:01 +, Emil Velikov wrote: > > > > > > @@ -460,6 +464,14 @@ driGetConfigAttribIndex(const __DRIconfig > > *config, > > > > else > > > > *value = 0; > > > > break; > > > > +case __DRI_ATTRIB_RED_MASK_HI: > > > > +

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

On 1/7/19 8:44 AM, Tapani Pälli wrote: > > On 1/4/19 11:56 PM, Kevin Strasser wrote: > >> While I have run this series against Piglit, I still need to sort out > >> test coverage for these formats. If anyone has pointers to existing > >> tests that would be really helpful. > > > > dEQP (EGL

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: expose EXT_texture_compression_s3tc for ES2

On Wed, Nov 9, 2016 at 12:44 PM, Kenneth Graunke wrote: > On Wednesday, September 21, 2016 4:32:27 PM PST Kevin Strasser wrote: > > The extension spec has been revised to include dependencies for OpenGL ES 2 > > and 3. > > > > Signed-off-by: Kevin Strasser

Re: [Mesa-dev] [PATCH v2 1/3] vulkan/wsi: Add a thread-safe queue implementation

On Tue, Nov 8, 2016 at 5:00 PM, Jason Ekstrand wrote: > From: Kevin Strasser > > In order to support FIFO mode without blocking the application on calls > to vkQueuePresentKHR it is necessary to enqueue the request and defer > calling the server

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Add a thread-safe queue implementation

On Thursday, 2016-11-03 20:51:59 -0700, Jason Ekstrand wrote: > From: Kevin Strasser > > In order to support FIFO mode without blocking the application on calls > to vkQueuePresentKHR it is necessary to enqueue the request and defer > calling the server until the next