Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

Am 19.07.19 um 18:18 schrieb Ilia Mirkin: On Fri, Jul 19, 2019 at 12:07 PM Tobias Klausmann wrote: On 19.07.19 15:39, Eric Engestrom wrote: On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 Fixes: https

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On 19.07.19 15:39, Eric Engestrom wrote: On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 `Fixes:` is used to indicate the commit that introduced the code being

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

into src/vulkan/meson.build as they apply to the overlay, utils & wsi. Since it's correct though, I landed Tobias' patch with my r-b and Cc: stable (I dropped the unnecessary [] though), and I sent MR !460 with your suggestion. Thanks, -Lionel On 16/03/2019 18:56, Tobias Klausmann wrote: Wit

[Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

terminated. The above misses the include directory for wayland: -I/usr/include/wayland Signed-off-by: Tobias Klausmann --- src/vulkan/util/meson.build | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vulkan/util/meson.build b/src/vulkan/util/meson.build index

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

On 17.12.18 23:16, Dylan Baker wrote: Quoting Tobias Klausmann (2018-12-17 14:05:13) On 17.12.18 20:33, Dylan Baker wrote: Quoting Emil Velikov (2018-12-17 11:10:00) On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: Quoting Emil Velikov (2018-12-13 08:15:57) From: Emil Velikov Reasonably

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

On 17.12.18 20:33, Dylan Baker wrote: Quoting Emil Velikov (2018-12-17 11:10:00) On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: Quoting Emil Velikov (2018-12-13 08:15:57) From: Emil Velikov Reasonably often people will want to build the loader w/o any drivers. Be that debugging an issue

[Mesa-dev] [PATCH] amd/vulkan: meson build - use radv_deps for libvulkan_radeon

de is contained in the (until now) unused radv_deps: if with_platform_wayland radv_deps += dep_wayland_client radv_flags += '-DVK_USE_PLATFORM_WAYLAND_KHR' libradv_files += files('radv_wsi_wayland.c') endif Fixes: 673dda83307 "meson: build "radv" vulkan driver for radeon h

Re: [Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

Hi, fyi: there is another bugreport #106372 [1], where i bisected the problem in the xserver and found a problematic commit, with code which can easily be reverted (patch in the bugreport), maybe you could check if that fixes the issue as well! PS: I looked into bugzilla last weekend where

[Mesa-dev] [PATCH] i965: mark function end of brw_regs_negative_equal() unreachable

*, const brw_reg*)': compiler/brw_reg.h:305:1: warning: control reaches end of non-void function [-Wreturn-type] Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/intel/compiler/brw_reg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_r

Re: [Mesa-dev] [PATCH v2] nv50/ir: rework the madsp subop handling

Hi, comments down below... Greetings, Tobias On 12/2/17 12:34 PM, Karol Herbst wrote: From: Karol Herbst Creating correct SubOps for OP_MADSP wasn't easy, because devs needed to know the proper values for each data type. Also the third source doesn't know any explicit

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

On 11/12/17 4:16 PM, Ilia Mirkin wrote: On Sun, Nov 12, 2017 at 9:09 AM, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: On 11/12/17 3:53 AM, Ilia Mirkin wrote: It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be und

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: add optimization for modulo by a non-power-of-2 value

delete_Instruction(prog, i); } break; lgtm, Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

On 11/12/17 3:53 AM, Ilia Mirkin wrote: It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be undefined, but that seems fairly surprising. It's not that much more effort to get it right, at least for positive modulo operators. Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH 1/2] nv50: make blending work so that zero wins in a multiplication

e good (or are they already renamed in envytools and not synced yet?). A bit off topic question is: Where does nvc0 set those regs? I have a hard time finding it. :O Anyway, the patch looks ok and you can add my R-b with or without renaming the regs: Reviewed-by: Tobias Kla

Re: [Mesa-dev] [PATCH] nv50,nvc0: enable using LOAD from constbuf

r shader-db run would be nice to see. Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> > > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 ++ > src/gallium/drivers/nouveau/n

Re: [Mesa-dev] [PATCH mesa] wayland-egl: fix wayland cflags

_LTLIBRARIES = libwayland-egl.la > noinst_HEADERS = wayland-egl-backend.h Oh, yep this is better! I should have changed it when fixing the build a few weeks ago. Acked-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] wayland-egl: redistribute the wayland.egl.h include

On 10/4/17 3:47 PM, Emil Velikov wrote: > On 3 October 2017 at 14:45, Tobias Klausmann > <tobias.johannes.klausm...@mni.thm.de> wrote: >> Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed >> wayland-client dependency") the wayland

[Mesa-dev] [PATCH] wayland-egl: redistribute the wayland.egl.h include

t;wayland-egl.h" ^~~ Fixes: ab0589c6ed ("wayland-egl: remove no longer needed wayland-client dependency") Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/wayla

Re: [Mesa-dev] [PATCH] wayland-egl: forward declare wl_egl_window* functions

On 10/3/17 3:37 PM, Emil Velikov wrote: > On 3 October 2017 at 14:34, Tobias Klausmann > <tobias.johannes.klausm...@mni.thm.de> wrote: >> Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed >> wayland-client dependency") the wayland

[Mesa-dev] [PATCH] wayland-egl: forward declare wl_egl_window* functions

gl.h include! Fixes: ab0589c6ed ("wayland-egl: remove no longer needed wayland-client dependency") Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/wayland/wayland-egl/wayland-egl-backen

[Mesa-dev] [PATCH] wayland-egl: redistribute wayland.egl.h include

e "wayland-egl.h" ^~~~~~~ Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Fixes: ab0589c6ed ("swayland-egl: remove no longer needed wayland-client dependency") --- src/egl/wayland/wayland-egl/Makefile.am | 3 ++- 1 file changed,

[Mesa-dev] [PATCH] nvc0: fix handling of inverted render condition

Wether we wait on an inverted rendering condition or not, we should not render on a passed query. This fixes the CTS test case 'KHR-GL45.conditional_render_inverted.functional'. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/gallium/drivers/nouvea

[Mesa-dev] [PATCH] nvc0/ir: propagate immediates to CALL input MOVs

0 0 Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_

[Mesa-dev] [PATCH] build: Don't bail on OSError in git_sha1_gen.py

When building sandboxed, we may encounter additional errors. Ignore the errors, as we are in a constrained environment. This can be observed when building latest git with OBS. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- bin/git_sha1_gen.py | 3 +++ 1 file c

[Mesa-dev] [RFC PATCH] nv50/ir: allow spilling of def values for constrained MERGES/UNIONS

This lets us spill more values and compile a big shader for Civilization 6. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/c

Re: [Mesa-dev] [PATCH] nv50/ir: fix MUL ConstantFolding with saturation

Looks good to me! Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> On 7/30/17 5:51 PM, Karol Herbst wrote: > For mul(a, +-1) codegen could end up generating OP_MOV with a saturation flag > set which we got simply ignored. > > Adding an assert

Re: [Mesa-dev] [PATCH] glsl/lower_distance: only set max_array_access for 1D clip dist arrays

Tested-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> On 6/12/17 1:47 AM, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> The max_array_access field applies to the first dimension, which means we only want to set it for the 1D clip dist arrays.

Re: [Mesa-dev] [PATCH] amd/common: Fix build with new ac_add_function_attr()

t;builder, src0, ctx->i32one, "")); ^~~~~~~ On Wed, 1 Mar 2017 at 21:22 Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de <mailto:tobias.johannes.klausm...@mni.thm.de>> wrote: Fix usage of

[Mesa-dev] [PATCH] amd/common: Fix build with new ac_add_function_attr()

, AC_FUNC_ATTR_BYVAL); ^~~~ Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/amd/common/ac_llvm_util.c | 3 +-- src/amd/common/ac_llvm_util.h | 2 ++ src/amd/common/ac_nir_to_llvm.c | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-)

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

On 02.10.2016 13:56, Nicolai Hähnle wrote: On 01.10.2016 22:22, Tobias Klausmann wrote: On 01.10.2016 21:46, Marek Olšák wrote: Hi, I propose that we use versioning in the form of "year.quarter". 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following quarters o

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

On 01.10.2016 21:46, Marek Olšák wrote: Hi, I propose that we use versioning in the form of "year.quarter". 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following quarters of the year, respectively. 2018 would start with 18.0, then 18.1, 18.2, 18.3. The motivation is that you can

[Mesa-dev] [PATCH v2] mesa/main: Fix missing return in non void function

This was found by obs: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function main/program_resource.c:109 Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> --- V2: Remove the !, cos

[Mesa-dev] [PATCH] mesa/main: Fix missing return in non void function

This was found by obs: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function main/program_resource.c:109 Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/mesa/main/program_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Mesa-dev] [RFC] st: guard against NULL pipe_surface

entral in update_framebuffer_size(). Greetings, Tobias [1] https://homepages.thm.de/~tjkl80/openmw_backtrace.txt On 18.08.2016 11:55, Marek Olšák wrote: Hi, Do you have a test case? Marek On Thu, Aug 18, 2016 at 1:44 AM, Tobias Klausmann <tobias.johannes.klausm...@m

[Mesa-dev] [RFC] st: guard against NULL pipe_surface

...@yahoo.com> Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/mesa/state_tracker/st_atom_framebuffer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa/state_tracker/st_atom_frame

Re: [Mesa-dev] [PATCH 3/4] nvc0/ir: dual issue two min/max instructions

Hi Karol, one question inline. On 13.08.2016 12:02, Karol Herbst wrote: min/max pairs can be dual issued on Kepler1 changes for ./GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0 /benchmark_duration_ms=6 /width=1024 /height=640: without dual_issue pass: inst_executed: 1.03G

Re: [Mesa-dev] [PATCH 2/4] nvc0/ir: don't dual issue instructions which depend on each other

== OPCLASS_TEXTURE || clA == OPCLASS_FLOW) return false; + + if (b->dependsOn(a)) + return false; + // anything with MOV if (a->op == OP_MOV || b->op == OP_MOV) return true; Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de>

Re: [Mesa-dev] [PATCH 1/4] nv50: add target->hasDualIssueing()

, const Value *) const; + virtual bool hasDualIssueing() const; virtual bool canDualIssue(const Instruction *, const Instruction *) const; virtual int getLatency(const Instruction *) const; virtual int getThroughput(const Instruction *) const; Reviewed-by: Tobias Klausmann &

Re: [Mesa-dev] [PATCH] anv: add the X related and Wayland CFLAGS to VULKAN_ENTRYPOINT_CPPFLAGS

On 04.06.2016 01:22, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Otherwise we might fail to find the headers in some scenarios. Cc: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reported-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm

Re: [Mesa-dev] [PATCH] anv: supply necessary headers to the generator

On 04.06.2016 00:54, Emil Velikov wrote: On 3 June 2016 at 23:03, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: With header in uncommen (non-system findable places) the build fails, use the already found places to include those headers. Are you sure about this ? What e

[Mesa-dev] [PATCH] anv: supply necessary headers to the generator

With header in uncommen (non-system findable places) the build fails, use the already found places to include those headers. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/intel/vulkan/Makefile.am | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] egl: fix build after introduction of new member in _egl_thread_info

On 02.06.2016 23:54, Rob Herring wrote: On Thu, Jun 2, 2016 at 4:45 PM, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: Starting with commit e8b38ca202fbe8c281aeb81a4b64256983f185e0 the dummy_thread misses the proper intialization for the new member, leading to the error

[Mesa-dev] [PATCH] egl: fix build after introduction of new member in _egl_thread_info

Starting with commit e8b38ca202fbe8c281aeb81a4b64256983f185e0 the dummy_thread misses the proper intialization for the new member, leading to the error stated at the bottom. This patch initializes the new member. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de>

Re: [Mesa-dev] [PATCH] automake: avoid fetching unnecessary data for the generation of git_sha1.h

On 01.06.2016 19:31, Eric Engestrom wrote: On Wed, Jun 01, 2016 at 12:18:57AM +0200, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefil

[Mesa-dev] [PATCH] automake: avoid fetching unnecessary data for the generation of git_sha1.h

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index f5c0773..d0990dc 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -22,8

Re: [Mesa-dev] [PATCH] glsl: add GL_EXT_clip_cull_distance define, add helpers

Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> On 25.05.2016 01:59, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> --- This addresses the feedback I got after pushing the enablement patch. docs/relnotes/11.3.0.html

Re: [Mesa-dev] [PATCH] glsl: add EXT_clip_cull_distance support based on ARB_cull_distance

On 24.05.2016 03:42, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 12 +++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/compiler/glsl/linker.cpp

Re: [Mesa-dev] [PATCH] nouveau: Make it compile

Latest master head compiles fine here without this patch for a small build (i965 and nouveau) On 16.05.2016 15:52, Daniel Vetter wrote: No idea why, but without this my mesa stopped compiling ... Signed-off-by: Daniel Vetter ---

Re: [Mesa-dev] [PATCH] nv50,nvc0: add support for cull distances

Looks a bit silly to review this patch as it is run under my name, but anyway: Reviewed-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> On 14.05.2016 16:21, Ilia Mirkin wrote: From: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Cull distances are just a

Re: [Mesa-dev] ARB_cull_distance (final?) and llvmpipe support

Hi Dave, i was not aware you are working on this actively as well, i had a series posted 5 days ago which got some critics and reviews [1]. The most important points where: 1. split functional change and renaming of the lowering pass [Ian] 2. check max clip/cull array sizes in link_shaders

Re: [Mesa-dev] report ARB_cull_distance v3

On 08.05.2016 23:29, Tobias Klausmann wrote: On 08.05.2016 22:50, Ilia Mirkin wrote: What exactly gets fed into the CLIPDIST and CULLDIST semantics? e.g. is CULLDIST[0].x the first cull distance, or is it the first entity in the combined cull/clip distance array? If the former, then this won't

Re: [Mesa-dev] [PATCH v3 06/11] glsl: Add arb_cull_distance support

On 09.05.2016 20:41, Ian Romanick wrote: snip + /* From the ARB_cull_distance spec: + * + * It is a compile-time or link-time error for the set of shaders forming + * a program to have the sum of the sizes of the gl_ClipDistance and + * gl_CullDistance arrays to

Re: [Mesa-dev] report ARB_cull_distance v3

commit/?id=5227e915803079e5e72a0b2fde3a11d62af8df99 Greetings, Tobias On Sun, May 8, 2016 at 4:44 PM, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: After the cleanup of my patches in v2, this is another take on finishing this extension. v2: cleanup, reordering of patches, split lowerin

[Mesa-dev] [PATCH v3 10/11] llvmpipe: Enable already implemented cull_distance

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index c6c18ee..6

[Mesa-dev] [PATCH v3 08/11] mesa/st: Add support for GL_ARB_cull_distance

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_program.c| 40 ++ 2 files changed, 41 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH v3 07/11] gallium: Add a pipe cap for arb_cull_distance

This lets us safely enable or disable the extension as needed Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drive

[Mesa-dev] [PATCH v3 04/11] glsl: rename lower_clip_distance to lower_distance.

From: Dave Airlie <airl...@redhat.com> This just renames the file in anticipation of adding cull lowering. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Edward O'Callaghan <eocalla

[Mesa-dev] [PATCH v3 11/11] nvc0: Implement cull_distance as a special form of clip distance

This enables ARB_cull_distance. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- docs/GL3.txt| 2 +- docs/relnotes/11.3.0.html | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++ src/gallium/d

[Mesa-dev] [PATCH v3 02/11] mesa/main: Add support for GL_ARB_cull_distance (v2)

airlied: v2: rename LowerClipDistance to LowerCombinedClipCullDistnace. I don't think we want any other behaviour with any current hw. Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/c

[Mesa-dev] [PATCH v3 05/11] glsl: Extend lowering pass for gl_ClipDistance to support other arrays (v2)

This will come in handy when we want to lower gl_CullDistance into gl_CullDistanceMESA. [airlied: drop separate APIs for clip/cull - just use single API to call both passes.] Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH v3 06/11] glsl: Add arb_cull_distance support

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> --- src/compiler/glsl/ast_to_hir.cpp | 14 src/compiler/glsl/builtin_variables.cpp | 11 ++- src/compiler/glsl/glcpp/glcpp-parse.y| 3 + src/compiler/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH v3 09/11] nv50/ir: Check for TGSI_SEMANTIC_CULLDIST in tgsi declarations

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nou

[Mesa-dev] [PATCH v3 01/11] glapi: Add GL_ARB_cull_distance

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mapi/glapi/gen/gl_API.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/ma

[Mesa-dev] report ARB_cull_distance v3

if an array was unsized - fix GL3.txt, add releasenote Dave Airlie (1): glsl: rename lower_clip_distance to lower_distance. Tobias Klausmann (10): glapi: Add GL_ARB_cull_distance mesa/main: Add support for GL_ARB_cull_distance (v2) mesa/prog: Add varyings for arb_cull_distance glsl

[Mesa-dev] [PATCH v3 03/11] mesa/prog: Add varyings for arb_cull_distance

Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Reviewed-by: Edward O'Callaghan <eocallag...@alterapraxis.com> --- src/mesa/program/prog_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_p

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

On 05.04.2016 01:32, Timothy Arceri wrote: On Mon, 2016-04-04 at 15:07 +0200, Tobias Klausmann wrote: On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Signed-off-by:

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

On 05.04.2016 00:06, Dave Airlie wrote: On 4 April 2016 at 23:07, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann <tobias.johannes.klausm...@m

Re: [Mesa-dev] [PATCH 11/12] nvc0: Implement cull_distance as a special form of clip distance

On 04.04.2016 04:32, Ilia Mirkin wrote: On Sun, Apr 3, 2016 at 10:15 PM, Dave Airlie <airl...@gmail.com> wrote: From: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> This enables ARB_cull_distance. This isn't enough - something needs to lower the CULLDIST into CLIPD

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de --- src/compiler/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH v2] st/mesa: do not init limits when compute shaders are not supported

of uniform blocks allowed for compute shaders is less than 12. This happens on Kepler but this might also affect other Gallium drivers. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Reported-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> Tested-by: Tobi

Re: [Mesa-dev] [PATCH 1/4] mesa: replace UsesClipDistance with ClipDistanceArraySize

On 18.10.2015 19:14, Marek Olšák wrote: From: Marek Olšák This is more practical and needed by gallium. --- src/glsl/linker.cpp| 33 +++-- src/glsl/nir/glsl_to_nir.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_vs.c | 2

Re: [Mesa-dev] [PATCH 3/4] st/mesa: pass the clip distance array size to drivers

On 18.10.2015 19:52, Marek Olšák wrote: On Sun, Oct 18, 2015 at 7:25 PM, Ilia Mirkin wrote: Patches 1-3 are Reviewed-by: Ilia Mirkin . Not familiar with the tgsi scan stuff. Do you have plans on finishing cull distance support btw? Dave Airlie

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog. It is not changing now, don't know if it will in the future. Using prog->getTarget() may save us from

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

On 31.08.2015 18:23, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

On 24.08.2015 17:51, Ilia Mirkin wrote: The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements vertexid-drawarrays Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 11.0 mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH] glsl: Extend lowering pass for gl_ClipDistance to support other arrays

This will come in handy when we want to lower gl_CullDistance into gl_CullDistanceMESA. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/Makefile.sources| 2 +- src/glsl/ir_optimization.h | 1 + src/glsl/lower_clip_distance.cpp | 574

Re: [Mesa-dev] [PATCH 2/4] nouveau/compiler: init the size and code variables to NULL/0

Mh especially GCC 5 seems to be picky about code, if we don't work around we soon will only see warnings for every file. Even if the compiler is buggy/to picky we should fix the code to not drown in warnings... :-) On 05.06.2015 22:23, Ilia Mirkin wrote: Sure. Fix it in GCC :) disable the

[Mesa-dev] [PATCH] docs: Mark ARB_cull_distance as in progress

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- I'm already getting emails wanting me to do this, so just mark it, wont change anything really docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 44a824b

Re: [Mesa-dev] [PATCH] docs: Mark ARB_cull_distance as in progress

, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- I'm already getting emails wanting me to do this, so just mark it, wont change anything really docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3

Re: [Mesa-dev] [PATCH 09/11] gallium: add support for arb_cull_distance

for llvmpipe, I'm not entirely sure for softpipe) if not there's some unaccounted difference somewhere how we'd thought of how this should work for dx10 vs. opengl). Hey nice to know llvmpipe already supports this, i'll test it! Tobias Roland Am 24.05.2015 um 19:58 schrieb Tobias Klausmann

Re: [Mesa-dev] [PATCH] glsl: avoid leaking linked gl_shader when there's a late linker error

pong the unhappyness case will hopefully soon be extended with cull_distance + clipvertex, so good to see this fixed! Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 25.05.2015 21:42, Ilia Mirkin wrote: ping On Sun, May 17, 2015 at 5:56 PM, Ilia Mirkin imir

[Mesa-dev] [PATCH 06/11] glsl: lower cull_distance into cull_distance_mesa

From: Dave Airlie airl...@redhat.com Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/Makefile.sources| 1 + src/glsl/ir_optimization.h | 1 + src/glsl/link_varyings.cpp | 15 +- src/glsl/link_varyings.h | 3 +- src/glsl

[Mesa-dev] [PATCH 01/11] glapi: add GL_ARB_cull_distance

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mapi/glapi/gen/gl_API.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 3090b9f..a792056 100644 --- a/src/mapi/glapi/gen

[Mesa-dev] [PATCH 04/11] mesa/st: add support for GL_ARB_cull_distance

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/state_tracker/st_extensions.c | 4 src/mesa/state_tracker/st_program.c| 34 ++ 2 files changed, 38 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src

[Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/ast_to_hir.cpp | 14 + src/glsl/builtin_variables.cpp | 13 +++- src/glsl/glcpp/glcpp-parse.y| 3 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH 10/11] nouveau/codegen: sort in galliums cull_distance semantic into the drivers bitmask

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 03/11] mesa/prog: Add varyings for arb_cull_distance

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/program/prog_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c index d588d07..e8855cd 100644 --- a/src/mesa/program/prog_print.c +++ b/src

[Mesa-dev] [PATCH 08/11] i965: rename UsesClipDistanceOut to UsesClipCullDistanceOut

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- src

[Mesa-dev] [PATCH 09/11] gallium: add support for arb_cull_distance

Add another pipe cap so we can savely enable of disable this extension Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/auxiliary/cso_cache/cso_context.c| 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c

[Mesa-dev] [PATCH 05/11] glsl: Add a helper to see if an array was unsize in the shader

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/glsl_types.cpp | 8 src/glsl/glsl_types.h | 10 -- src/glsl/linker.cpp | 2 +- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl

[Mesa-dev] [PATCH 11/11] nouveau/nvc0: implement cull_distance as a special form of clip distance

This enables ARB_cull_distance. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- docs/GL3.txt | 2 +- docs/relnotes/10.7.0.html | 4 +++- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 6

[Mesa-dev] [RFC PATCH 00/11] Implement ARB_cull_distance

This patch series adds the needed support for this extension to the various parts of mesa to finally enable it for nvc0. Dave Airlie (1): glsl: lower cull_distance into cull_distance_mesa Tobias Klausmann (10): glapi: add GL_ARB_cull_distance mesa/main: add support for GL_ARB_cull_distance

[Mesa-dev] [PATCH 02/11] mesa/main: add support for GL_ARB_cull_distance

Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/main/extensions.c | 1 + src/mesa/main/get.c | 26 ++ src/mesa/main/get_hash_params.py | 4 src/mesa/main/mtypes.h | 22

Re: [Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

On 25.05.2015 01:19, Timothy Arceri wrote: On Mon, 2015-05-25 at 00:46 +0200, Tobias Klausmann wrote: hi, replay inline. On 25.05.2015 00:34, Timothy Arceri wrote: On Sun, 2015-05-24 at 19:58 +0200, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm

Re: [Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

hi, replay inline. On 25.05.2015 00:34, Timothy Arceri wrote: On Sun, 2015-05-24 at 19:58 +0200, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/ast_to_hir.cpp | 14 + src/glsl/builtin_variables.cpp | 13

Re: [Mesa-dev] [PATCH v2] nv50/ir: avoid messing up arg1 of PFETCH

Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 23.05.2015 18:56, Ilia Mirkin wrote: There can be scenarios where the indirect arg of a PFETCH becomes known, and so the code will attempt to propagate it. Use this opportunity to just fold it into the first argument

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 18.05.2015 11:29, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). where is the S-o-b ? ;-) --- src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

On 18.05.2015 10:43, Samuel Pitoiset wrote: Thanks for the review. Can I get your R-b for the other patches of the series. :-) Oh silly me, it was meant to be a R-b for patch 1+2 on both series, sorry :) On 05/17/2015 06:46 PM, Tobias Klausmann wrote: Reviewed-by: Tobias Klausmann

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 17.05.2015 18:19, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/Makefile.sources| 1 + src/gallium/drivers/nouveau/nv50/nv50_context.h | 12

Re: [Mesa-dev] [PATCH 1/2] nvc0: add a header file for nvc0_query

Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 17.05.2015 18:21, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/Makefile.sources| 1 + src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 12

  1   2   >