Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

2017-08-28 Thread Marek Olšák
Please makes this a non-shader cap if the value doesn't vary between shaders. Marek On Sun, Aug 27, 2017 at 12:59 PM, Karol Herbst wrote: > this way Nouveau can report 128 inputs, but only 124 varyings. > > Fixes: 'KHR-GL45.limits.max_fragment_input_components' >

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

2017-08-28 Thread Ilia Mirkin
On Mon, Aug 28, 2017 at 4:23 AM, Nicolai Hähnle wrote: > On 27.08.2017 12:59, Karol Herbst wrote: >> >> this way Nouveau can report 128 inputs, but only 124 varyings. >> >> Fixes: 'KHR-GL45.limits.max_fragment_input_components' > > > Can you explain a bit more why this is

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

2017-08-28 Thread Nicolai Hähnle
On 27.08.2017 12:59, Karol Herbst wrote: this way Nouveau can report 128 inputs, but only 124 varyings. Fixes: 'KHR-GL45.limits.max_fragment_input_components' Can you explain a bit more why this is necessary? The GL CTS test only exercises the core profile, where it should be possible for

[Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

2017-08-27 Thread Karol Herbst
this way Nouveau can report 128 inputs, but only 124 varyings. Fixes: 'KHR-GL45.limits.max_fragment_input_components' Signed-off-by: Karol Herbst --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 +