Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-10 Thread Roland Scheidegger
Am 10.01.19 um 04:51 schrieb Tomasz Figa: > Hi Roland, > > On Thu, Jan 10, 2019 at 1:36 AM Roland Scheidegger wrote: >> >> Sorry but I had to revert this, as we've seen lots of assertion failures >> (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait: Assertion >> `f->issued' failed.).

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-09 Thread Tomasz Figa
Hi Roland, On Thu, Jan 10, 2019 at 1:36 AM Roland Scheidegger wrote: > > Sorry but I had to revert this, as we've seen lots of assertion failures > (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait: Assertion > `f->issued' failed.). For instance with libgl_xlib state tracker and

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-09 Thread Roland Scheidegger
Sorry but I had to revert this, as we've seen lots of assertion failures (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait: Assertion `f->issued' failed.). For instance with libgl_xlib state tracker and piglit. I'm not entirely sure if it's really safe to just remove the assert or if it

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-08 Thread Roland Scheidegger
Am 07.01.19 um 09:54 schrieb Tomasz Figa: > On Sun, Dec 23, 2018 at 12:55 AM Roland Scheidegger > wrote: >> >> Alright, I guess it should work... >> >> Reviewed-by: Roland Scheidegger >> > > Thanks! > > Would we have anyone who could help to commit it? Pushed (albeit I forgot the R-b on it,

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-07 Thread Tomasz Figa
On Sun, Dec 23, 2018 at 12:55 AM Roland Scheidegger wrote: > > Alright, I guess it should work... > > Reviewed-by: Roland Scheidegger > Thanks! Would we have anyone who could help to commit it? (I know that I was supposed to apply for commit rights, but I expect my contribution rate to be

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2018-12-22 Thread Roland Scheidegger
Alright, I guess it should work... Reviewed-by: Roland Scheidegger Am 14.12.18 um 09:17 schrieb Tomasz Figa: > If there is no last fence, due to no rendering happening yet, just > create a new signaled fence and return it, to match the expectations of > the EGL sync fence API. > > Fixes

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2018-12-20 Thread Tomasz Figa
Hi everyone, On Fri, Dec 14, 2018 at 5:17 PM Tomasz Figa wrote: > > If there is no last fence, due to no rendering happening yet, just > create a new signaled fence and return it, to match the expectations of > the EGL sync fence API. > > Fixes random "Could not create sync fence 0x3003"

[Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2018-12-14 Thread Tomasz Figa
If there is no last fence, due to no rendering happening yet, just create a new signaled fence and return it, to match the expectations of the EGL sync fence API. Fixes random "Could not create sync fence 0x3003" assertion failures from Skia on Android, coming from the following code: