Re: [Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

Hello Dylan, It looks fine to me as well. Thank you for fixing the merge conflict. Pierre On 2018-09-14 — 09:16, Dylan Baker wrote: > Quoting Pierre Moreau (2017-12-04 15:51:04) > > Those operations do not map to actual hardware instructions, therefore > > those should always be lowered to

Re: [Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

Hi Dylan, this patch only matters for debug builds (DEBUG set), but your merge result looks correct nonetheless. Thanks On Fri, Sep 14, 2018 at 6:16 PM, Dylan Baker wrote: > Quoting Pierre Moreau (2017-12-04 15:51:04) >> Those operations do not map to actual hardware instructions, therefore >>

Re: [Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

Quoting Pierre Moreau (2017-12-04 15:51:04) > Those operations do not map to actual hardware instructions, therefore > those should always be lowered to 32-bit instructions. > > Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations" > Signed-off-by: Pierre Moreau > --- >

Re: [Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

On Tue, Dec 5, 2017 at 12:51 AM, Pierre Moreau wrote: > Those operations do not map to actual hardware instructions, therefore > those should always be lowered to 32-bit instructions. > > Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations" > Signed-off-by:

[Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

Those operations do not map to actual hardware instructions, therefore those should always be lowered to 32-bit instructions. Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations" Signed-off-by: Pierre Moreau ---