Re: [Mesa-dev] [PATCH] radv: compact varyings after removing unused ones

2018-02-15 Thread Samuel Pitoiset
On 02/14/2018 11:24 PM, Timothy Arceri wrote: On 15/02/18 01:10, Samuel Pitoiset wrote: It makes no sense to compact before, and the description of nir_compact_varyings() confirms that. Reviewed-by: Timothy Arceri Your right this seems to be in the wrong place. There was a lot of restruct

Re: [Mesa-dev] [PATCH] radv: compact varyings after removing unused ones

2018-02-14 Thread Timothy Arceri
On 15/02/18 01:10, Samuel Pitoiset wrote: It makes no sense to compact before, and the description of nir_compact_varyings() confirms that. Reviewed-by: Timothy Arceri Your right this seems to be in the wrong place. There was a lot of restructuring around the time this landed so it seems to

[Mesa-dev] [PATCH] radv: compact varyings after removing unused ones

2018-02-14 Thread Samuel Pitoiset
It makes no sense to compact before, and the description of nir_compact_varyings() confirms that. Polaris10: Totals from affected shaders: SGPRS: 106000 -> 105600 (-0.38 %) VGPRS: 70704 -> 70640 (-0.09 %) Spilled SGPRs: 892 -> 878 (-1.57 %) Code Size: 2826240 -> 2812476 (-0.49 %) bytes Max Waves: