Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Mathias Fröhlich
Hi, Thanks, Brian and Marek for the review! best Mathias On Monday, 25 February 2019 22:44:37 CET Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Sun, Feb 24, 2019 at 1:46 AM wrote: > > > From: Mathias Fröhlich > > > > Hi Brian, > > > > Following a small optimization in the

Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Brian Paul
LGTM too. Reviewed-by: Brian Paul On Sun, Feb 24, 2019 at 1:46 AM wrote: > From: Mathias Fröhlich > > Hi Brian, > > Following a small optimization in the gallium state tracker to > avoid flagging ST_NEW_VERTEX_ARRAYS a bit more often: > > please review! > > best > > Mathias > > > > > Since

Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Feb 24, 2019 at 1:46 AM wrote: > From: Mathias Fröhlich > > Hi Brian, > > Following a small optimization in the gallium state tracker to > avoid flagging ST_NEW_VERTEX_ARRAYS a bit more often: > > please review! > > best > > Mathias > > > > > Since

[Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Brian, Following a small optimization in the gallium state tracker to avoid flagging ST_NEW_VERTEX_ARRAYS a bit more often: please review! best Mathias Since using bitmasks we can easily check if we have any current value that is potentially uploaded on array