Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Timothy Arceri
On 05/04/18 06:11, Marek Olšák wrote: From: Marek Olšák This fixes a radeonsi crash. The constant buffer didn't follow the PIPE_CAP_CONSTBUF0_FLAGS rule. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105026 --- src/gallium/auxiliary/cso_cache/cso_context.c

Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Marek Olšák
On Wed, Apr 4, 2018 at 5:41 PM, Ilia Mirkin wrote: > While I don't see anything obviously wrong in this patch, I also don't > see any issues in the old code. What API misuse is this dealing with? > The constant buffer didn't follow the PIPE_CAP_CONSTBUF0_FLAGS rule. Marek

Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Ilia Mirkin
While I don't see anything obviously wrong in this patch, I also don't see any issues in the old code. What API misuse is this dealing with? On Wed, Apr 4, 2018 at 4:11 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a radeonsi crash. > --- >

[Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Marek Olšák
From: Marek Olšák This fixes a radeonsi crash. --- src/gallium/auxiliary/cso_cache/cso_context.c | 17 src/gallium/auxiliary/cso_cache/cso_context.h | 3 +++ src/gallium/auxiliary/postprocess/pp_mlaa.c| 37 --