Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-24 Thread Marek Olšák
On Wed, Aug 24, 2016 at 3:44 PM, Roland Scheidegger wrote: > Am 24.08.2016 um 11:26 schrieb Marek Olšák: >> On Wed, Aug 24, 2016 at 2:10 AM, Roland Scheidegger >> wrote: >>> Am 22.08.2016 um 23:13 schrieb Marek Olšák: On Mon, Aug 22, 2016 at 10:18

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-24 Thread Roland Scheidegger
Am 24.08.2016 um 11:26 schrieb Marek Olšák: > On Wed, Aug 24, 2016 at 2:10 AM, Roland Scheidegger > wrote: >> Am 22.08.2016 um 23:13 schrieb Marek Olšák: >>> On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: On 23 August 2016 at 06:14, Marek Olšák

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-24 Thread Marek Olšák
On Wed, Aug 24, 2016 at 2:10 AM, Roland Scheidegger wrote: > Am 22.08.2016 um 23:13 schrieb Marek Olšák: >> On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: >>> On 23 August 2016 at 06:14, Marek Olšák wrote: On Mon, Aug 22, 2016

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-23 Thread Roland Scheidegger
Am 22.08.2016 um 23:13 schrieb Marek Olšák: > On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: >> On 23 August 2016 at 06:14, Marek Olšák wrote: >>> On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: On 08/22/2016 08:38 AM, Marek

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-23 Thread Roland Scheidegger
I don't really like this - I'd like to keep d3d10 semantics unless there's a good reason to change it. And I don't see such a reason - even with variable indexing you cannot use mixed int/uint/float textures since texturing results with using the wrong type of sampler are undefined anyway. Hence

[Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-23 Thread Marek Olšák
From: Marek Olšák Sampler view declarations have return types, but that doesn't work with variable indexing (e.g. SAMP[-1+i]). Adding the return type to the instruction is simpler. All sampler view declaration flags might have to be removed since variable indexing makes

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: > On 23 August 2016 at 06:14, Marek Olšák wrote: >> On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: >>> On 08/22/2016 08:38 AM, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Dave Airlie
On 23 August 2016 at 06:14, Marek Olšák wrote: > On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: >> On 08/22/2016 08:38 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Sampler view declarations have return types, but that

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: > On 08/22/2016 08:38 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Sampler view declarations have return types, but that doesn't work with >> variable indexing (e.g. SAMP[-1+i]). >> >> Adding the

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Brian Paul
On 08/22/2016 08:38 AM, Marek Olšák wrote: From: Marek Olšák Sampler view declarations have return types, but that doesn't work with variable indexing (e.g. SAMP[-1+i]). Adding the return type to the instruction is simpler. All sampler view declaration flags might have

[Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
From: Marek Olšák Sampler view declarations have return types, but that doesn't work with variable indexing (e.g. SAMP[-1+i]). Adding the return type to the instruction is simpler. All sampler view declaration flags might have to be removed since variable indexing makes