Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-08-04 Thread Eric Anholt
Emil Velikov emil.l.veli...@gmail.com writes: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the dri2_dpy-conn checking with the

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-08-01 Thread Emil Velikov
On 29 July 2015 at 18:17, Matt Turner matts...@gmail.com wrote: On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Alex Deucher
On Wed, Jul 29, 2015 at 12:19 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Matt Turner
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the

[Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Emil Velikov
Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the dri2_dpy-conn checking with the next commit. Signed-off-by: Emil Velikov