Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-27 Thread Bas Nieuwenhuizen
On Fri, Oct 27, 2017 at 5:03 PM, Andres Gomez wrote: > Bas, this patch looks like it should have been marked as fixing > 6ce550453f1 instead of e38685cc62e (?). Well my reasoning was that the bug got "visible" when we enabled Vega. The patch you refer to fixed part of it, but

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-27 Thread Andres Gomez
Bas, this patch looks like it should have been marked as fixing 6ce550453f1 instead of e38685cc62e (?). In any case, I was wondering whether it would be interesting to bring them both to the 17.2 stable queue and whether we would also want Timothy's preceding patch:

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-22 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 23/10/17 03:43, Bas Nieuwenhuizen wrote: Since it also uses the output vector before writing to memory. Fixes: e38685cc62e 'Revert "radv: disable support for VEGA for now."' --- src/amd/vulkan/radv_shader.c | 4 +--- 1 file changed, 1

[Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-22 Thread Bas Nieuwenhuizen
Since it also uses the output vector before writing to memory. Fixes: e38685cc62e 'Revert "radv: disable support for VEGA for now."' --- src/amd/vulkan/radv_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c