Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-13 Thread Timothy Arceri
On 12/08/17 06:32, Emil Velikov wrote: On 1 August 2017 at 08:35, Timothy Arceri wrote: When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop assigning unused storage

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-11 Thread Emil Velikov
On 1 August 2017 at 08:35, Timothy Arceri wrote: > When generation the storage offset for struct members we need > to skip opaque types as they no longer have backing storage. > > Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless > opaque types") >

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 10:21, Samuel Pitoiset wrote: > > > On 08/08/2017 07:34 AM, Timothy Arceri wrote: >> >> On 01/08/17 19:37, Timothy Arceri wrote: >>> >>> On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-08 Thread Samuel Pitoiset
On 08/08/2017 07:34 AM, Timothy Arceri wrote: On 01/08/17 19:37, Timothy Arceri wrote: On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? I'm not overly worried. If you really want to go that way we can, but I

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-07 Thread Timothy Arceri
On 01/08/17 19:37, Timothy Arceri wrote: On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? I'm not overly worried. If you really want to go that way we can, but I don't think it's necessary. So how do we move

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Timothy Arceri
On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? I'm not overly worried. If you really want to go that way we can, but I don't think it's necessary. On 08/01/2017 09:35 AM, Timothy Arceri wrote: When

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Samuel Pitoiset
Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? On 08/01/2017 09:35 AM, Timothy Arceri wrote: When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop

[Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Timothy Arceri
When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless opaque types") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101983 ---