Re: [Mesa-dev] [PATCH 20/22] i965: account for NIR uniforms without name

2018-05-02 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 18/04/18 00:36, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev Right now, the BRW linker code assumes nir_variable::name is always non-NULL, but thanks to ARB_gl_spirv we will soon be linking SPIR-V programs, and

[Mesa-dev] [PATCH 20/22] i965: account for NIR uniforms without name

2018-04-17 Thread Alejandro Piñeiro
From: Eduardo Lima Mitev Right now, the BRW linker code assumes nir_variable::name is always non-NULL, but thanks to ARB_gl_spirv we will soon be linking SPIR-V programs, and those explicitly require matching uniforms by location. The name is just a debug hint. v2: simplified,