Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-28 Thread Kenneth Graunke
On 01/20/2013 02:15 PM, Paul Berry wrote: [snip] As an alternative to those fixes, here's my refactoring suggestion: drop this function entirely, and instead, in brw_blorp_copytexsubimage(), create a temporary intel_renderbuffer to wrap around dst_image, and just call do_blorp_blit() directly.

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-24 Thread Martin Steigerwald
Am Sonntag, 20. Januar 2013 schrieb Paul Berry: --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 106 +++ src/mesa/drivers/dri/i965/brw_context.h | 8 ++ src/mesa/drivers/dri/intel/intel_tex_copy.c | 32 ++-- 3 files changed, 138

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-24 Thread Martin Steigerwald
According to KMail this went out as replay to all. Strange. Am Donnerstag, 24. Januar 2013 schrieb Martin Steigerwald: Am Sonntag, 20. Januar 2013 schrieb Paul Berry: --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 106 +++

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-21 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: On 19 January 2013 11:06, Kenneth Graunke kenn...@whitecape.org wrote: + //intel_renderbuffer_set_needs_downsample(dst_irb); I'm ok leaving this out--at the moment there's no way this code can be hit for a multisampled destination image.

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-21 Thread Paul Berry
On 21 January 2013 00:55, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: On 19 January 2013 11:06, Kenneth Graunke kenn...@whitecape.org wrote: + //intel_renderbuffer_set_needs_downsample(dst_irb); I'm ok leaving this out--at the moment there's no way

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-21 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: On 21 January 2013 00:55, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: On 19 January 2013 11:06, Kenneth Graunke kenn...@whitecape.org wrote: + //intel_renderbuffer_set_needs_downsample(dst_irb); I'm ok

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-21 Thread Paul Berry
On 20 January 2013 14:15, Paul Berry stereotype...@gmail.com wrote: On 19 January 2013 11:06, Kenneth Graunke kenn...@whitecape.org wrote: + /* CopyTexSubImage should happen even in conditional rendering. We could +* turn it off and back on again. For now, just bail instead. +*/

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-20 Thread Paul Berry
On 19 January 2013 11:06, Kenneth Graunke kenn...@whitecape.org wrote: The BLT engine has many limitations. Currently, it can only blit X-tiled buffers (since we don't have a kernel API to whack the BLT tiling mode register), which means all depth/stencil operations get punted to meta code,

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-20 Thread Paul Berry
On 20 January 2013 14:15, Paul Berry stereotype...@gmail.com wrote: Your interaction with blorp looks good. But I think there are some bugs in the resolves. My rules of thumb for depth/HiZ resolves are: - Resolves take care of the mismatch in access patterns between HiZ-aware components

[Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-19 Thread Kenneth Graunke
The BLT engine has many limitations. Currently, it can only blit X-tiled buffers (since we don't have a kernel API to whack the BLT tiling mode register), which means all depth/stencil operations get punted to meta code, which can be very CPU-intensive. Even if we used the BLT engine, it can't