Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Matt Turner
I don't like adding workarounds to our codebase for someone else's problem, generally, but specifically I think this is a bad idea because the name MESA_DEBUG is already used (it's an environment variable), and this is a completely separate meaning. ___

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Rob Clark
On Tue, Jan 10, 2017 at 12:07 PM, Jan Vesely wrote: > On Tue, 2017-01-10 at 16:43 +, Emil Velikov wrote: >> On 10 January 2017 at 15:04, Vedran Miletić wrote: >> > On 09/19/2016 08:39 PM, Vedran Miletić wrote: >> > > On 09/07/2016 06:52 PM, Vedran

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Jan Vesely
On Tue, 2017-01-10 at 16:43 +, Emil Velikov wrote: > On 10 January 2017 at 15:04, Vedran Miletić wrote: > > On 09/19/2016 08:39 PM, Vedran Miletić wrote: > > > On 09/07/2016 06:52 PM, Vedran Miletić wrote: > > > > LLVM and Mesa both define the DEBUG macro in incompatible

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Emil Velikov
On 10 January 2017 at 15:04, Vedran Miletić wrote: > On 09/19/2016 08:39 PM, Vedran Miletić wrote: >> On 09/07/2016 06:52 PM, Vedran Miletić wrote: >>> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >>> general practice, we should avoid using such generic

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Vedran Miletić
On 09/19/2016 08:39 PM, Vedran Miletić wrote: > On 09/07/2016 06:52 PM, Vedran Miletić wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid using such generic names when it is >> possible to do so. >> >> This patch renames all

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2016-09-19 Thread Vedran Miletić
On 09/07/2016 06:52 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG, > and removes