Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On 11.01.2018 12:22, Ilia Mirkin wrote: On Thu, Jan 11, 2018 at 3:51 AM, Gert Wollny wrote: Am Donnerstag, den 11.01.2018, 08:09 +0100 schrieb Gert Wollny: Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: [...] If your hardware executes all the vertices in

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Thu, Jan 11, 2018 at 3:51 AM, Gert Wollny wrote: > Am Donnerstag, den 11.01.2018, 08:09 +0100 schrieb Gert Wollny: >> Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: >> [...] >> > >> > If your hardware executes all the vertices in parallel, then a >> >

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Donnerstag, den 11.01.2018, 08:09 +0100 schrieb Gert Wollny: > Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: > [...] > > > > If your hardware executes all the vertices in parallel, then a > > barrier should be unnecessary. > > My first try for this patch did not include

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Donnerstag, den 11.01.2018, 08:18 +1000 schrieb Dave Airlie: > > > The number of writes is the same though, and as far as I can tell > > from the TGSI, the values written to LDS before the barrier are not > > read back within the shader - which makes me wonder whether the > > barrier is

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: [...] > > If your hardware executes all the vertices in parallel, then a > barrier should be unnecessary. My first try for this patch did not include forcing the barrier into slot x, which in turn resulted in failing piglits, e.g.    

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On 11 January 2018 at 06:13, Gert Wollny wrote: > Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: >> This seems to satisfy the sb optimizer, i.e. no regressions in the >> piglits compared to disabling sb for tesselation shaders with >> barriers but enabling

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Wed, Jan 10, 2018 at 3:50 PM, Connor Abbott wrote: > On Wed, Jan 10, 2018 at 3:27 PM, Ilia Mirkin wrote: >> On Wed, Jan 10, 2018 at 3:13 PM, Gert Wollny wrote: >>> Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny:

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Wed, Jan 10, 2018 at 3:27 PM, Ilia Mirkin wrote: > On Wed, Jan 10, 2018 at 3:13 PM, Gert Wollny wrote: >> Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: >>> This seems to satisfy the sb optimizer, i.e. no regressions in the >>>

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Wed, Jan 10, 2018 at 3:13 PM, Gert Wollny wrote: > Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: >> This seems to satisfy the sb optimizer, i.e. no regressions in the >> piglits compared to disabling sb for tesselation shaders with >> barriers but enabling

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: > This seems to satisfy the sb optimizer, i.e. no regressions in the > piglits compared to disabling sb for tesselation shaders with > barriers but enabling them in general. > --- Actually, it seems this is not enough, at least for

[Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

This seems to satisfy the sb optimizer, i.e. no regressions in the piglits compared to disabling sb for tesselation shaders with barriers but enabling them in general. --- The series goes on top of the r600 sb tessellation support patches. Best, Gert src/gallium/drivers/r600/sb/sb_bc.h