Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-30 Thread Eric Engestrom
On Wednesday, 2017-11-29 16:23:26 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:19:02) > > On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > > > These are the refactored commits related to the GSoC project involving > > > adding a st/omx state tracker using

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-30 Thread Julien Isorce
Hi Gurkirpal, I am glad to see you continue working on this out of the GSoC project. I have reviewed it already during that period so just giving my official "the series is:" Reviewed-by: Julien Isorce On 30 November 2017 at 00:23, Dylan Baker

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-29 07:19:02) > On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > > These are the refactored commits related to the GSoC project involving > > adding a st/omx state tracker using tizonia. > > There are still some parts of code that i didn't refactor

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Gurkirpal Singh
If you are referring to earlier discussion about having tizonia build problems then it was about disabling some extra CPU intensive features like the tizonia player which isn't needed here. This was only required if you wanted to build from source instead of downloading it. Later Juan added an

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Eric Engestrom
On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > These are the refactored commits related to the GSoC project involving > adding a st/omx state tracker using tizonia. > There are still some parts of code that i didn't refactor yet as > explained below: > 1) I wasn't sure if it's

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Christian König
Am 29.11.2017 um 05:02 schrieb Gurkirpal Singh: These are the refactored commits related to the GSoC project involving adding a st/omx state tracker using tizonia. There are still some parts of code that i didn't refactor yet as explained below: 1) I wasn't sure if it's okay to use #if-#else

[Mesa-dev] Refactored st/omx/tizonia commits

2017-11-28 Thread Gurkirpal Singh
These are the refactored commits related to the GSoC project involving adding a st/omx state tracker using tizonia. There are still some parts of code that i didn't refactor yet as explained below: 1) I wasn't sure if it's okay to use #if-#else declaratives for function declarations. For eg: One